Hugh McMaster
a905b4d6ba
regedit/tests: Test comma placement when parsing hex data.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-29 18:32:06 +02:00
Nikolay Sivov
f4e98d813f
regedit: Remove explicit iIndent field initialization.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-28 18:24:14 +02:00
Nikolay Sivov
b84f228805
regedit: Use notification message to clean up item data.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-28 18:24:11 +02:00
Hugh McMaster
b25337e6d6
regedit: Free the binary data buffer after saving the new value (Coverity).
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-28 18:23:04 +02:00
Hugh McMaster
ec0043f083
regedit/tests: Test whether EOF invalidates a hex data line ending in a backslash.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-27 19:13:54 +02:00
Hugh McMaster
82d3be8094
regedit/tests: Test whether a forward slash can be used as a concatenation marker.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-27 19:13:50 +02:00
Hugh McMaster
81fa517436
regedit/tests: Test the effects of comments and new lines that appear between valid hex data lines.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-27 19:13:48 +02:00
Hugh McMaster
a9726d0b90
regedit/tests: Test whether a line beginning with a backslash can follow a line ending in a backslash.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-27 19:13:44 +02:00
Hugh McMaster
a31f070ada
regedit/tests: Test line concatenation with comments, new lines and comma variations before a new default registry value.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-27 19:13:41 +02:00
Hugh McMaster
db9e4199e0
regedit/tests: Test line concatenation with comments, new lines and comma variations before a new registry value.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-27 19:13:38 +02:00
Hugh McMaster
82263293f6
regedit/tests: Test line concatenation with a new registry key on the next line.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-27 19:13:34 +02:00
Hugh McMaster
6b36ce329d
regedit/tests: Test backslashes with whitespace variations and comma placement.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-27 19:13:32 +02:00
Hugh McMaster
73af2479c7
regedit/tests: Use the verify_key*() functions where possible.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-26 18:19:34 +02:00
Hugh McMaster
f0e21863c9
regedit/tests: Use verify_key() for consistency with the verify_reg*() functions.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-26 18:19:32 +02:00
Hugh McMaster
758340a6e1
regedit: Free the buffer and reset data information on error and after setting the value.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-26 18:19:09 +02:00
Hugh McMaster
a76ce84fce
regedit/tests: Add tests to determine the effects of backslashes in hex data.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-23 15:19:36 +02:00
Hugh McMaster
a1b35b3bc4
regedit/tests: Add tests for parsing hex data.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-22 19:25:16 +02:00
Hugh McMaster
4a70d33552
regedit: Display data for all values in the GUI.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-21 19:15:12 +02:00
Hugh McMaster
878a0a4e14
regedit: Display all registry data types in the GUI.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-21 19:15:12 +02:00
Hugh McMaster
8803b9616b
regedit: Fail when parsing any hex data type that is greater than ULONG_MAX on Windows.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-21 19:15:12 +02:00
Hugh McMaster
e3234f6ede
regedit: Use a generic data type to correctly process all data types.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-20 18:43:30 +02:00
Hugh McMaster
cb563dbac6
regedit: Re-insert the default value item after deleting its data.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-16 15:25:38 +02:00
Hugh McMaster
7f76cf6c26
regedit: Use the correct mask flags with LVM_GETNEXTITEM.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-16 15:25:38 +02:00
Hugh McMaster
1f08ee2453
regedit: Allow the deletion of registry keys beginning with a lowercase 'H'.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-16 15:25:38 +02:00
Hugh McMaster
f535341d2b
regedit: Use a case insensitive comparison when parsing registry classes from registry file versions 4 and 5.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-16 15:25:37 +02:00
Hugh McMaster
8504a1563d
regedit: Free the memory used by the REG_DWORD and hex data types after saving the registry value.
...
We use a BOOL to handle all hex types, including those that are undefined (e.g.0x100).
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-16 15:25:37 +02:00
Hugh McMaster
a1924ae2da
regedit: Export hex data types without warning about unsupported data types.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-16 15:25:37 +02:00
Hugh McMaster
300df08e70
regedit: Remove an unused #define.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-16 15:22:07 +02:00
Hugh McMaster
191b81dbd3
regedit: Add data parsing operations to the state machine.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-15 21:54:38 +02:00
Hugh McMaster
d60c31eadb
regedit: Perform value name operations in the state machine.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-15 18:51:08 +02:00
Hugh McMaster
ca98e23451
regedit: Perform key operations in the state machine.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-15 18:51:08 +02:00
Hugh McMaster
ec87800856
regedit: Introduce a partial state machine for importing registry data.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-15 18:51:08 +02:00
Hugh McMaster
b1e48fb469
regedit: Free the stringValueData buffer before using it again (Coverity).
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-15 15:02:14 +02:00
Hugh McMaster
06b0a6d94d
regedit/tests: Test whether "" is interpreted as the default registry value.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-15 15:02:10 +02:00
Hugh McMaster
c414b2b570
regedit/tests: Output "(Default)" when referring to the default registry value.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-15 15:02:07 +02:00
Hugh McMaster
a726343fa5
regedit: Add status bar text for the 'Expand'/'Collapse' menu item.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-13 20:56:20 +02:00
Hugh McMaster
5058fa70a3
regedit/tests: Test the accepted range of the hex-based data types.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-13 20:56:19 +02:00
Hugh McMaster
955766a13b
regedit/tests: Test case sensitivity when creating and deleting registry keys.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-13 20:56:19 +02:00
Hugh McMaster
8096e23798
regedit/tests: Remove an un-needed tab character from a key in the key deletion tests.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-09 09:18:53 +02:00
Hugh McMaster
afde1624ca
regedit: Do not use REG_NONE as the default data type if strtoulW() fails.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-08 16:44:58 +02:00
Hugh McMaster
5669282e1d
regedit: Do not create registry keys that end without a closing bracket.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-08 16:44:58 +02:00
Hugh McMaster
eca563e9ce
regedit/tests: Add tests for value deletion.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-08 16:44:58 +02:00
Hugh McMaster
247e611de5
regedit/tests: Add tests for key creation and key deletion.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-08 16:44:57 +02:00
Hugh McMaster
75fed2d5a1
regedit: Use shared code to add favourite key items to the 'Remove' listbox.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-06 13:08:46 +02:00
Hugh McMaster
f0949baafc
regedit: Update handling of the 'Modify' menu items.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-05 11:14:12 +02:00
Hugh McMaster
adf298685f
regedit: Only show the 'Modify' menu items when the listview has focus.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-05 11:14:09 +02:00
Hugh McMaster
46bff016ab
regedit: Use the treeview item label in the 'Favourites' menu instead of the key path.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-05 11:12:36 +02:00
Hugh McMaster
27b2519ca4
regedit: Re-implement favourite registry key handling.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-05 11:12:32 +02:00
Hugh McMaster
b332c1a6d5
regedit: Update handling of the 'Modify' menu item.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-02 17:25:30 +02:00
Hugh McMaster
6c752aaf8d
regedit: Update handling of the new subkey and new value menu items.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-01 20:32:20 +02:00
Hugh McMaster
576d300e49
regedit: Update some resource strings.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-01 20:32:18 +02:00
Hugh McMaster
63a2a07e86
regedit: Add status bar text for the 'Modify Binary Data' menu item.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-01 20:30:41 +02:00
Hugh McMaster
6eef9a9554
regedit: Add status bar text for adding a new expandable string value.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-01 20:29:56 +02:00
Hugh McMaster
898ee58aa0
regedit: Fix handling of 'Copy Key Name' menu items.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-01 19:36:48 +02:00
Hugh McMaster
48716cba98
regedit: Update handling of the 'Copy Key Name' menu item.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 20:51:47 +02:00
Hugh McMaster
2aff2f612a
regedit: Update handling of the 'Rename' menu item.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 20:51:47 +02:00
Hugh McMaster
4144847aa5
regedit: Update handling of the 'Delete' menu item.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 20:51:46 +02:00
Hugh McMaster
948278cb7b
regedit: Never disable the 'Find' and 'Find Next' menu items.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 20:51:46 +02:00
Hugh McMaster
2689792cd4
regedit: Update the status bar when moving to the 'Computer' root node.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 20:51:46 +02:00
Hugh McMaster
06eceb3af2
regedit: Delete a listview item without refreshing the listview.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-30 21:49:51 +02:00
Hugh McMaster
9cd1fc3fc4
regedit: Update the data in a listview subitem without refreshing the listview.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-30 21:49:50 +02:00
Hugh McMaster
f3c4cca7bf
regedit: Add listview entries without refreshing the listview.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-30 21:49:50 +02:00
Hugh McMaster
ebfe566c16
regedit: Update a value name without refreshing the listview.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-30 21:49:50 +02:00
Hugh McMaster
c04f66a59f
regedit: Allow handling of return values from listview notification messages.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-30 21:49:50 +02:00
Hugh McMaster
fe38c9abad
regedit: Move the listview's NM_SETFOCUS handling to listview.c.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-30 21:49:50 +02:00
Hugh McMaster
51743827c9
regedit/tests: Add tests for importing Windows 3.1 registry data.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-26 08:10:41 +02:00
Hugh McMaster
d763aecc24
regedit: Use a separate pop-up menu for the 'Computer' root node.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-24 16:23:59 +02:00
Hugh McMaster
d09571d181
regedit: Add 'Expand' and 'Collapse' options to the treeview pop-up menu.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-24 16:22:18 +02:00
Hugh McMaster
0c9de25955
regedit: Remove duplicate HINSTANCE declaration from main.h.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-24 15:30:23 +02:00
Hugh McMaster
e880c9ca8c
regedit: Only show the 'New' pop-up menu when right-clicking beneath the listview item list.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-22 21:08:08 +02:00
Hugh McMaster
7bf054f198
regedit: Update and sort the pop-up menus.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-22 21:06:20 +02:00
Hugh McMaster
c5d38ce427
regedit: Re-select the listview item after renaming is complete.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-22 21:02:37 +02:00
Hugh McMaster
5474b7a43e
regedit: Always assign focus to the default value when refreshing the listview.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-22 21:02:33 +02:00
Hugh McMaster
7ea0892343
regedit/tests: Re-order the REG_NONE import tests and fix some copy/paste errors.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-19 17:44:22 +02:00
Nikolay Sivov
02b178e791
regedit: Fix a crash when exporting from top level key.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-18 16:17:48 +02:00
Hugh McMaster
d37a49f362
regedit/tests: Add tests for importing REG_BINARY data.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-17 21:57:12 +02:00
Hugh McMaster
5aea192a5a
regedit/tests: Add tests for importing REG_EXPAND_SZ data.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-17 21:57:12 +02:00
Hugh McMaster
2060e426a6
regedit/tests: Add tests for importing REG_NONE data.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-17 21:57:12 +02:00
Hugh McMaster
00a65cd507
regedit/tests: Test whether blank lines affect multi-line concatenation.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-17 21:57:12 +02:00
Hugh McMaster
3ce4beb0a7
regedit/tests: Test if REG_SZ and REG_DWORD support line concatenation.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-17 21:57:12 +02:00
Hugh McMaster
a0f5a2cc12
regedit/tests: Add tests for key name and value name concatenation.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-17 21:57:11 +02:00
Hugh McMaster
82246874d2
regedit: Merge processRegLinesA/W() into their caller.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-05 14:12:18 +02:00
Hugh McMaster
e8f0a8b38b
regedit: Merge header checks from processRegLinesA/W() to their caller.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-05 14:12:18 +02:00
Hugh McMaster
8753a1b271
regedit: Use a function pointer to read each registry line instead of calling get_lineA/W() directly.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-03 22:58:02 +02:00
Hugh McMaster
76b9e6c712
regedit: Return a Unicode line from get_lineA().
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-03 22:58:02 +02:00
Hugh McMaster
6b596ecf9e
regedit: Simplify clean-up in get_lineA/W().
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-03 22:58:02 +02:00
Hugh McMaster
8b5291bca6
regedit: Pass RegQueryValueEx() the actual buffer size (Coverity).
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-01 19:29:14 +02:00
Hugh McMaster
85e34436cd
regedit: Add a missing 'break' statement (Coverity).
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-01 19:29:14 +02:00
Huw Davies
6bc8ecafe8
regedit: Use the system metrics to retrieve the treeview icon sizes.
...
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-27 19:00:25 +02:00
Hugh McMaster
2392743146
regedit: Re-implement processSetValue().
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-25 20:53:07 +02:00
Hugh McMaster
9aff5c88ad
regedit: Validate REG_SZ import data before processing it any further.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-25 20:53:07 +02:00
Hugh McMaster
0481f31d4c
regedit: Simplify parseKeyName.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-25 20:53:07 +02:00
Hugh McMaster
2926c2822c
regedit/tests: Add some more import tests.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-24 20:30:18 +02:00
Hugh McMaster
6f667d1c42
regedit: Only show the context menu if the mouse is over a treeitem.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-20 18:58:46 +02:00
Hugh McMaster
ab0d0c6ee4
regedit: Select the targeted treeview item on right mouse click.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-20 18:58:46 +02:00
Hugh McMaster
4dc5a764c7
regedit: Call TrackPopupMenu() from WM_CONTEXTMENU.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-20 18:58:45 +02:00
Hugh McMaster
5af62255ef
regedit/tests: Add some REG_SZ import tests.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-12 19:04:10 +02:00
Jakub Bartmiński
9e35dd1545
regedit: Fall back to tree root on invalid path.
...
Signed-off-by: Jakub Bartmiński <jakub.bartm@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-11 22:02:30 +02:00
Hugh McMaster
0a71d4fa72
regedit: Re-implement convertHexToDWord().
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-11 15:55:24 +02:00
Hugh McMaster
467def8352
regedit/tests: Add a few more import tests.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-11 15:53:57 +02:00
Hugh McMaster
098be09bce
regedit/tests: Add tests for importing DWORD values.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-11 15:53:53 +02:00
Hugh McMaster
aacae19602
regedit: Skip any leading spaces and tabs that may be present in the line being parsed.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-03 14:09:49 +02:00
Hugh McMaster
0b513778c7
regedit/tests: Add import tests with various combinations of spaces and tabs.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-03 14:09:47 +02:00
Hugh McMaster
9ea9874abf
regedit: Remove unused #define.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-31 14:03:56 +02:00
Hugh McMaster
9ad4152e6d
regedit: Make "Unknown Type" translatable.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-30 22:06:33 +02:00
Hugh McMaster
5aaa77c9bb
regedit: Do not select/highlight a listview item on refresh.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-29 08:47:22 +02:00
Hugh McMaster
6d89696121
regedit: Do not use REG_NONE as the default data type on import error.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-29 08:47:20 +02:00
Hugh McMaster
523a61da85
regedit: Remove data types that cannot be imported and clean-up data_types array.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-29 08:47:18 +02:00
Hugh McMaster
f8afd05d6c
regedit/tests: Add mixed line concatenation and comment tests.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-24 12:45:11 +01:00
Hugh McMaster
0a7ff8aff7
regedit: Accept various forms of "REGEDIT" with trailing characters.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-22 16:28:50 +01:00
Hugh McMaster
5052a759b3
regedit: Return success or failure from import functions.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-22 16:28:10 +01:00
Hugh McMaster
f56d919ffe
regedit: Re-implement processRegLinesA().
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-22 16:25:01 +01:00
Hugh McMaster
e1e79d12b3
regedit: Parse UTF-16 file header for validation.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-22 16:23:49 +01:00
Hugh McMaster
e96056a026
regedit/tests: Add missing ok() check after RegOpenKeyExA().
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-21 20:52:04 +01:00
Hugh McMaster
6b6e2cb924
regedit: Re-implement processRegLinesW().
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-20 19:42:18 +01:00
Hugh McMaster
a3c9a2682c
regedit/tests: Add some line concatenation tests.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-06 19:44:18 +01:00
Hugh McMaster
00bd109e1f
regedit/tests: Test import with non-standard registry file headers.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-24 13:54:17 +01:00
Nikolay Sivov
a9bae9629c
regedit: Sort each of top level branches separately.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-20 10:32:13 +01:00
Nikolay Sivov
71a6eeb732
regedit: Make it clear whether it is a key or a value that is about to be removed.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-17 20:54:05 +01:00
Hugh McMaster
7073e27fbd
regedit: Sort treeview children on refresh.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-09 13:01:32 +01:00
Hugh McMaster
e23ca416bd
regedit: Refresh listview after import.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-09 13:01:32 +01:00
Hugh McMaster
9e1d356d78
regedit: Display a dialog message after successful/unsuccessful file import.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-09 13:01:15 +01:00
Hugh McMaster
8ce48b9fcd
regedit: Update some comments in edit.c.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-01 16:40:17 +01:00
Hugh McMaster
93b08c6289
regedit: Update dialog messages related to key and value renaming.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-01 16:40:12 +01:00
Hugh McMaster
ed5d1f2618
regedit: Update search completion message handling.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-01 16:39:09 +01:00
Hugh McMaster
6a8aea20ac
regedit: Combine error() and error_code_messagebox().
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-01 16:35:13 +01:00
Hugh McMaster
e0ab47ce87
regedit: Display custom error messages instead of strings from the system table.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-01 16:32:45 +01:00
Hugh McMaster
e31a0cc241
regedit: Use FormatMessage() for optimal memory usage.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-01 16:30:16 +01:00
Hugh McMaster
6350cfd8c7
regedit: Remove unnecessary error handling from message box functions in edit.c.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-01 16:26:55 +01:00
Zebediah Figura
679cc50195
regedit: When processing 3.1 ignore any lines that don't begin with HKCR.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-31 22:30:38 +01:00
Nikolay Sivov
c5f26bf56d
regedit: Clear value list when tree root is selected.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-31 10:52:03 +01:00
Nikolay Sivov
7dea6fef61
regedit: Always show treeview selection.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-31 10:52:03 +01:00
Zebediah Figura
da5b770453
regedit/tests: Add tests for importing Win 3.1 registry files.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-30 21:38:53 +01:00
Zebediah Figura
b0d475b858
regedit: Add support for importing Win 3.1 registry files.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-30 21:38:53 +01:00
André Hentschel
9ae26670e3
regedit: Remove dead assignment (clang).
...
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-16 22:02:27 +01:00
Francois Gouget
49c30d4b8e
regedit: Make output_writeconsole() static.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-10 19:19:15 +01:00
Hugh McMaster
1e1bfba1c4
regedit: Only allow key renaming via the Edit or Popup menus.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-09 20:49:09 +01:00
Hugh McMaster
061c4bce06
regedit/tests: Add tests for quotes and slashes in keys, values and data.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-05 14:54:55 +01:00
Hugh McMaster
56959b1808
regedit: Import files using 'rb' mode.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-02 20:27:55 +01:00
Hugh McMaster
e7d5503347
regedit/tests: Add tests for line concatenation when importing.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-20 13:02:24 +01:00
Hugh McMaster
dc6e2eaf09
regedit: Load Binary editor from context menu.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-19 14:21:28 +01:00
Hugh McMaster
eb3c4f43f6
regedit/tests: Add more tests for parsing comments.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-06 15:46:15 +01:00
Hugh McMaster
ced6d4618b
regedit/tests: Move existing comment tests to a separate function.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-06 15:46:10 +01:00
Hugh McMaster
750358fc44
regedit/tests: Test whether comments ending in a backslash affect the next line.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-02 15:54:03 +01:00
Hugh McMaster
b897c9b13d
regedit/tests: Fix line concatenation test.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-02 15:54:01 +01:00
Hugh McMaster
6cd9c7ffb5
regedit/tests: Test if the final line is imported if it doesn't end in a newline.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-23 22:36:40 +01:00
Hugh McMaster
c39ee374a7
regedit: Close the registry key handle in the read function instead of the parser.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-25 13:39:32 +02:00
Hugh McMaster
93f795950d
regedit: Do not close the registy key handle when a line break is encountered.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-25 13:39:27 +02:00
Hugh McMaster
5027f01a6a
regedit/tests: Add line break and complexity tests.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-24 14:04:17 +02:00
Hugh McMaster
4e43d76751
regedit/tests: Handle different data types with one verify_reg() function.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-24 14:04:15 +02:00