1e26f9601d
Add NULL check for sinkInterface in DataCache_GetAdvise.
2005-09-28 18:12:58 +00:00
a90c11330e
Add missing ! to fix a reversed condition check in
...
OleCreateDefaultHandler, in order to match intent in comment.
2005-09-28 18:12:45 +00:00
80e023bdea
Use the proper calling convention for 2 16-bit functions.
2005-09-27 09:32:41 +00:00
a8c7284f92
Assorted spelling fixes.
2005-09-26 10:58:41 +00:00
335fce9ce0
Fix .spec declarations for functinos with 64bit arguments (reported by
...
winapi_check).
2005-09-26 09:56:40 +00:00
c86fef8844
Move all 16-bit functions to an appropriate 16-bit file.
2005-09-25 15:17:10 +00:00
53ef9950f2
Implement some IRunningObject functions that actually start the server
...
and initialize it.
2005-09-23 10:08:35 +00:00
3daf39fb0c
Implement OleRegEnumVerbs.
2005-09-23 10:08:25 +00:00
044ccc40f3
Don't fail in CoRegisterClassObject if the class already exists and
...
the REGCLS_MULTIPLEUSE flag is specified.
2005-09-23 10:08:11 +00:00
0ec0f048e6
Removed unused debug channels.
2005-09-22 10:44:40 +00:00
6bc4327c92
- Initialize out pointer to NULL before access check in
...
IStorage_CreateStorage.
- WriteClassStg should return E_INVALIDARG if pstg is NULL instead of
asserting.
- ReadClassStg should return E_INVALIDARG if pstg is NULL instead of
crashing and a NULL pclsid should cause it to return the same
value.
2005-09-22 10:34:40 +00:00
9f1c6de1ef
We are no longer generating .spec.c files.
2005-09-21 14:42:52 +00:00
0a49c1752e
Implement OleIsRunning.
2005-09-20 11:36:56 +00:00
d389b57171
- Fix a trace to refer to the object ID rather than the legacy MID.
...
- Fix the error case of CoMarshalInterThreadInterface to release the
stream.
2005-09-20 11:36:40 +00:00
83f3b370b1
- Remove redunant braces.
...
- Compact multi-line comments that fit into one line.
- Remove comments that state the obvious.
- Remove extra brackets that are redundant because the -> operator
binds tighter than &.
- Change "this" to "This" to make code more like other interface
implementations.
- Remove redundant comparisons with NULL for pointers.
2005-09-19 14:42:53 +00:00
0ceacf017f
Fix the return codes during unmarshaling so that it returns failure
...
codes instead of S_FALSE returned from IStream_Read.
2005-09-19 14:34:04 +00:00
b3a4b59668
Fix ref-counting rules to match native DCOM Dlls.
2005-09-18 11:10:37 +00:00
18bd21d4f1
Re-arrange some functions and vtables so we don't have declarations
...
for all of the functions in the file.
2005-09-17 14:29:11 +00:00
43df8b61bb
Add exception handling for stubs.
2005-09-14 10:07:01 +00:00
5a49e40149
SendMessageTimeout takes a DWORD_PTR not a DWORD.
2005-09-12 20:43:32 +00:00
f8ee161a1b
Fixed some traces to use the right printf format and avoid typecasts.
2005-09-12 10:30:05 +00:00
20a1a203c6
Use a more portable scheme for storing the name of a critical
...
section.
2005-09-09 10:19:44 +00:00
908e9e889e
Relax the share mode validation for transacted storage, with a test.
2005-09-07 09:22:15 +00:00
b379e420ed
Fixes for function prototypes without arguments.
2005-09-06 09:27:37 +00:00
3f912e048e
The [string] attribute is only valid on byte, char and wchar_t types,
...
so replace "unsigned short" by "WCHAR".
2005-09-02 11:19:05 +00:00
611b5acbf8
Authors: Mike Hearn <mh@codeweavers.com>, Robert Shearman <rob@codeweavers.com>
...
Change stub manager to track the number of normal marshals instead of
using the state machine so that multiple marshals of the same object
and interface work correctly.
2005-09-02 11:18:45 +00:00
dab603def3
- Implement IMarshal on proxies so that we don't end up with proxies
...
to proxies, causing potential deadlock issues and performance
problems.
- Add a test for this situation and remove the todo_wine from another
test that now succeeds.
2005-08-27 09:25:16 +00:00
c8aedf9726
Add stub for CoAllowSetForegroundWindow.
2005-08-26 08:47:09 +00:00
bcb251d5b3
Remove unused thread handle entry from the apartment structure.
2005-08-25 09:50:36 +00:00
eafa666bee
Fix some gcc 4.0 warnings.
2005-08-22 09:26:53 +00:00
6c8527c31c
- return a precomputed result for a NULL string
...
- pass strlen an LPSTR to eliminate a sign warning
2005-08-22 09:19:38 +00:00
71af595499
Use LPSTORAGE to better match the PSDK.
...
Document the real SEGPTR type using the standard documentation
mechanisms. Fixes winapi_check warnings.
2005-08-16 16:01:15 +00:00
61aabd66f5
Warning fixes for gcc 4.0.
2005-08-15 10:49:39 +00:00
61b2fba9d7
Added CoCreateInstance16, CoGetClassObject16, OleLoad16 stubs.
2005-08-15 09:46:51 +00:00
628939d567
Use the proper WOW functions everywhere instead of the K32WOW variant.
2005-08-10 10:59:19 +00:00
21e3ba8cd1
Correct mismatches between spec files and comments about export
...
number.
2005-08-10 09:53:47 +00:00
d32610fabe
Remove local declarations already in included public headers.
2005-08-10 09:48:15 +00:00
d37f0abf07
Don't prefix the functions DllCanUnloadNow, DllGetClassObject and
...
Dll(Un)RegisterServer with the dll name so that the compiler can check
the prototypes.
2005-08-08 17:35:28 +00:00
170470ee0b
Implemented ILockBytes16 (memorystream) support for the 16bit compound
...
storage implementation.
Added ReadClassStg, OleDoAutoConvert, GetConvertStg
implementations/stubs.
2005-08-08 11:05:06 +00:00
04b7382db9
Remove duplicate definition of FILE_BEGIN.
2005-07-28 10:24:01 +00:00
b1a9701bb5
Replace the _ICOM_THIS_From macros by inline functions the way it's
...
already done in shelllink.c.
2005-07-27 11:10:52 +00:00
b8d3075d83
Uncomment the typedef in the DECLARE_INTERFACE macro, and get rid of
...
duplicate typedefs.
2005-07-26 18:32:53 +00:00
4f82e547d7
Fix some missing-declarations warnings.
2005-07-24 17:11:59 +00:00
c5feb317b3
Implemented IsValidInterface16, CoMemAlloc.
...
Added debug to HGLOBALLockBytes16_QueryInterface.
2005-07-24 16:15:24 +00:00
1c3054af32
Added OleSetMenuDescriptor16 stub.
2005-07-22 18:29:39 +00:00
c8187b0900
OleInitializeWOW gets 2 arguments.
2005-07-22 18:29:19 +00:00
ba4c61776d
16bit COM interfaces are cdecl, not WINAPI.
2005-07-22 18:26:31 +00:00
d32762808b
16bit interfaces are cdecl, so drop the WINAPI.
2005-07-22 09:03:29 +00:00
4fad9ddc86
Hack around broken state management so InstallShield works.
2005-07-20 10:30:04 +00:00
775898ba97
- Always query for the correct stub interface, otherwise we will be
...
pointing to the completely wrong object when a proxy does a
queryinterface.
- Remove assumption that the stub buffer will handle the lifetime of
the object.
2005-07-19 19:59:41 +00:00
5d873adf9f
Marshal return value from IRemUnknown_RemQueryInterface.
2005-07-19 19:43:05 +00:00
c0d7a25a42
Silence now noisy error messages caused by changes in the way we call
...
ipid_to_stubmanager. Move the error message to the one place it is
needed.
2005-07-19 19:42:33 +00:00
97be0be7e4
- We should be starting with 1 reference.
...
- IRpcStubBuffer_Disconnect can be called more than once.
2005-07-19 19:13:11 +00:00
28479ea4aa
By-pass the RPC runtime if possible when calling an STA by posting a
...
message directly to the apartment window for it to process. Fixes a
deadlock in InstallShield caused by having to create a thread when
freeing an object that comes from an STA apartment. Added tests that
fail without this fix.
2005-07-19 19:12:47 +00:00
e874408d65
Delete the stub manager outside of the apartment critical section
...
because the deletion may require the object to re-enter the
apartment.
2005-07-19 19:12:24 +00:00
0f9ebafbec
Initialize RegisteredClass properly in CoRegisterClassObject to
...
prevent crash in CoRevokeClassObject when accessing (uninitialized)
pMarshalledData.
2005-07-19 11:40:22 +00:00
e633b45300
Added some documentation.
2005-07-07 17:21:44 +00:00
c7fdb4565a
Fix gcc 4.0 -Wpointer-sign warnings.
2005-07-05 11:02:54 +00:00
809edabfbe
Const correctness fixes.
2005-06-27 09:53:46 +00:00
aa0b9aac0d
Sort entry points alphabetically.
2005-06-22 18:38:23 +00:00
863a4b1488
Fix some more -Wstrict-prototypes warnings.
2005-06-21 20:53:13 +00:00
ac6f562b52
Fix more -Wstrict-prototypes warnings.
2005-06-20 14:18:03 +00:00
0a645e8cb9
Convert some registry helper functions to use unicode versions of
...
CLSID & registry functions (untested).
2005-06-20 13:14:22 +00:00
5807cb79f0
Change the RPC code to use the unicode versions of the CLSID &
...
registry functions.
2005-06-20 10:33:28 +00:00
f419880d64
- Change some of the registry helper functions to use the unicode
...
versions of the CLSID & registry functions.
- Reindent CoGetClassObject and output an error message if the class
isn't registered.
- Add tests for the touched functions.
2005-06-20 10:33:17 +00:00
0220d7ac89
Fix declarations in the tests.
2005-06-15 10:20:30 +00:00
c2d5b444b3
Moved the NONAMELESSUNION/STRUCT macros to wine/test.h so that they
...
can be used in all the test.
2005-06-13 12:10:54 +00:00
fd5f7729cb
Fix PropVariant tests on Windows 2000 and above.
2005-06-13 10:02:10 +00:00
a1e466ae77
- Add registry entries for local-only OLE interfaces.
...
- Change IUnknown to local interface.
2005-06-13 10:01:43 +00:00
ec7a5931ae
Removed CLSID_CompositeMoniker (conflicting with static definition).
2005-06-09 09:47:44 +00:00
037bdc0dc0
IUnknown isn't a remotable interface so the stub manager shouldn't
...
need a marshaller for it.
2005-06-09 09:45:59 +00:00
eba47f1dfe
Make remaining OLE interface vtables const.
2005-06-06 19:50:35 +00:00
e46047e4da
Don't disconnect proxies flagged with SORFP_NOLIFETIMEMGMT. It makes
...
no sense and only causes trouble for proxies that depend on these
proxies being available.
2005-06-05 19:19:24 +00:00
e3f990467c
Add some tracing to the IRemUnknown RpcProxyBuffer implementation.
2005-06-05 18:13:47 +00:00
977806a884
- Don't assume the ROT is already empty.
...
- Test that IEnum::Clone doesn't also do a Reset.
2005-06-02 20:06:33 +00:00
95b71ed885
IEnum::Clone shouldn't do a Reset.
2005-06-02 20:06:22 +00:00
885e6298f2
Added tests for file monikers.
2005-06-02 19:43:03 +00:00
54f041ad32
- Base FileMonikerImpl_Save() on XP.
...
- Correct handling of Unicode strings & multibyte locales.
- More error checking.
- Change ERR to WARN.
- Match Windows quick & dirty estimate for GetSizeMax().
2005-06-02 19:42:48 +00:00
4f14044f29
Remove forward declarations.
2005-05-23 16:31:13 +00:00
8d6a673cf7
- Add error messages on failure in file moniker load function.
...
- Fix incorrect pointer check in both monikers.
- Fix max size calculation of item moniker to match native.
2005-05-23 10:27:42 +00:00
27d73d6115
- Add a useful trace message.
...
- Fix more places where custom header size was calculated exclusive of
the data size member.
- Optimize custom marshaling by getting size before calling the custom
marshaler so we can write the header before and not use a second
stream.
2005-05-23 10:27:23 +00:00
aebb745488
Comment out stub WEP entry points so that we can call WEP for builtin
...
dlls too.
2005-05-23 10:12:26 +00:00
0ddd30b0b6
Removed unnecessary code in the 16-bit DllEntryPoint function of some
...
dlls, and also fixed its ordinal in a few places.
2005-05-23 10:00:26 +00:00
b9ecbb6167
- Marshal objects & monikers into the ROT.
...
- Test for this behaviour.
2005-05-23 09:54:53 +00:00
bb4d6f88bf
Implement Hash function on composite moniker.
2005-05-23 09:52:13 +00:00
34d3049360
- Add a generic moniker marshaler that works by saving & loading
...
monikers to & from the stream.
- Use the generic moniker marshal in the file & item monikers and add
a class factory for each.
2005-05-19 14:22:14 +00:00
a890293f33
- Change remaining blocks of code with 2-space indentation to 4-space
...
indentation.
- Make vtables const.
- Remove an unnecessary memcpy and let the compiler do the work.
2005-05-19 12:04:58 +00:00
447ab61288
Write custom header up to and including size, not excluding.
2005-05-19 11:15:50 +00:00
10ee7b36e8
Implement IROTData::GetComparisonData for file & item monikers.
2005-05-18 18:28:15 +00:00
49b1d335d9
Big Endian specific code fixes in order to conform with
...
NONAMELESSSTRUCT.
2005-05-18 09:44:13 +00:00
b45e31608b
Obvious fixes to PropVariantClear and PropVariantCopy for vector
...
types.
2005-05-17 10:18:59 +00:00
ff87ad7ab1
Add a comment, and a no-op cleanup.
2005-05-16 21:37:54 +00:00
e140d02a2b
Differentiate between version 0 and version 1 property storages.
2005-05-16 17:52:36 +00:00
f3d99b2697
Move the Dll init function to compobj.c to avoid having global
...
variables. Remove need of ole32_main.h.
2005-05-16 14:12:53 +00:00
fc61f6c553
Make _xmalloc16() static.
2005-05-16 08:47:40 +00:00
81e2677939
Staticify FTMarshalImpl definition.
2005-05-16 08:47:26 +00:00
45bc1c21a1
Make HGLOBALStream_* functions static.
2005-05-16 08:47:14 +00:00
5d90f2bcf9
Store property names in the code page of the property set.
2005-05-16 08:43:35 +00:00
72f73ac452
Implement the IEnumMoniker interface for the ROT and provide tests to
...
exercise the interface.
2005-05-14 18:50:14 +00:00
2507264e05
- maintain proper byte order
...
- maintain PROPSETFLAG_ANSI flag based on codepage
- update comments
2005-05-14 11:06:44 +00:00
a22c767eb0
Remove function prototypes.
2005-05-13 17:45:50 +00:00
6b7676a1e8
Don't import from ntdll.
2005-05-13 17:42:49 +00:00
e3b43fa458
Make sure a stream can't be created in read only storage.
2005-05-13 13:58:43 +00:00
912ffd6a0f
Remove unnecessary declarations and make functions static.
2005-05-12 09:57:21 +00:00
2c6c67f4ea
Make functions static and remove unnecessary declarations.
2005-05-11 15:56:45 +00:00
3c5790646f
Add a stub implementation of CoIsHandlerConnected.
2005-05-11 12:57:16 +00:00
809cf354e4
Fix a memory leak in the ole storage implementation.
2005-05-10 15:59:59 +00:00
34fa35dc99
Added rules for building import libraries in the individual dll
...
makefiles, and added support for building a .def.a static import
library too.
2005-05-09 14:42:30 +00:00
4d1562495d
Correct/improve error checking in IPropertyStorage.
2005-05-09 09:26:43 +00:00
d62356aa1e
Added rules to build import libraries in the individual dll makefiles.
...
Generate import libraries with the right name right away instead of
using an intermediate .spec.def file.
2005-05-07 12:39:52 +00:00
cabe752d1d
Make ole32 tests loadable on NT4.
2005-05-07 12:09:58 +00:00
6e028f414d
Replace stub entry for StgOpenStorageEx with call to StgOpenStorage.
2005-05-06 14:32:30 +00:00
8188790946
Replace StgCreateStorageEx stub with call to StgCreateDocfile and add
...
required STGFMT_* enumerations.
2005-05-05 16:44:05 +00:00
b99dfb0c1a
Define and use endian conversion macros for big-endian machines.
2005-04-24 17:22:26 +00:00
bf83ba1fa3
- convert strings between property storage's code page and system code
...
page
- add tests for setting code page
- fix tests and behavior to match WinXP
2005-04-23 19:04:49 +00:00
950d678c5e
Make ole32 tests loadable on NT4.
2005-04-22 19:05:51 +00:00
4b9f767845
Specify the proper call convention in the PropSysFreeString()
...
implementation.
2005-04-20 16:21:16 +00:00
3ef8c51c8a
Tweak the API documentation to silence winapi_check warnings.
2005-04-20 15:18:42 +00:00
35356002e6
Zero out an invalidated runningObjectTableInstance pointer.
2005-04-15 16:11:29 +00:00
e68982fcaf
Implement FmtIdToPropStgName & PropStgNameToFmtId, with tests.
2005-04-15 14:09:18 +00:00
f7ff216a15
Fixed a buffer overflow.
2005-04-14 12:50:54 +00:00
e3e5cf19a8
Remove the need for the non-standard (Close|Delete)MetaFile16().
2005-04-13 15:16:40 +00:00
142254d746
Implement PropSys{Alloc|Free}String, and support BSTRs in
...
PropVariant{Clear|Copy} using them.
2005-04-13 11:13:55 +00:00
c1fe67bc36
- add write support to IPropertyStorage, with tests
...
- misc. cleanups the tests turned up
2005-04-11 18:50:45 +00:00
50794ce787
Add traces, add unit tests for IPropertyStorage, and fix the problems
...
they caught.
2005-04-11 14:30:24 +00:00
6714664dee
Eliminate forward declarations, make functions static.
2005-03-31 15:26:30 +00:00
6b10c324c5
Assorted spelling fixes.
2005-03-30 17:08:31 +00:00
9be7f2789f
WriteFmtUserTypeStg doesn't pull a CLSID from the registry - it's
...
unclear when (if at all) this gets written.
2005-03-29 18:56:22 +00:00
e42a23d2d3
Don't close reg key if the open failed.
2005-03-29 13:06:57 +00:00
c822566974
Change prototypes so gcc with some warnings doesn't bark.
2005-03-29 11:32:04 +00:00
a63c2eb30b
Remove function prototypes, make functions static.
2005-03-28 10:01:45 +00:00
e19ce3bd40
Remove unnecessary function prototypes.
2005-03-27 18:16:49 +00:00
1ff3bf8e69
Remove function prototypes, make functions static.
2005-03-27 18:16:25 +00:00
93416cdaf7
Assorted spelling fixes.
2005-03-23 13:15:18 +00:00
461c830745
Eliminate HeapAlloc casts.
2005-03-22 18:26:06 +00:00
665b9ca377
More trace info from storage32 test.
2005-03-22 18:18:43 +00:00
17c3106896
Eliminate casts of the return value of HeapAlloc.
2005-03-21 11:25:13 +00:00
811725ac20
Correct and complete some api documentation.
2005-03-21 10:55:13 +00:00
963b63ecbd
ix test for STGM_SHARE_EXCLUSIVE on nameless DocFiles.
2005-03-21 10:30:01 +00:00
1571df5722
Fix memory leak in OleDuplicateData on error path (found by Smatch).
2005-03-19 17:05:12 +00:00
dbf222f3aa
Use LMEM_ flags for LocalAlloc(), not GMEM_ (GlobalAlloc).
2005-03-17 20:53:37 +00:00
be84f8d9e6
Begin implementing IPropertyStorage.
2005-03-17 20:50:35 +00:00
1b5ebabdce
- Add critsec debugging info.
...
- Move the modal loop called during RPCs into CoWaitForMultipleHandles.
- Use a mutex for long remoting calls to IRemUnknown methods.
- Remove locking in apartment_disconnectproxies as it is not needed.
- Use PostMessage instead of SendMessage so we can run the message
loop or not as appropriate.
2005-03-17 10:26:20 +00:00
ac24801db0
Add a comment about byte order, change types to reduce casting and not
...
cast away constness.
2005-03-17 10:25:13 +00:00
34a0463bca
A few memory checks avoiding memory leaks.
2005-03-14 10:46:50 +00:00
77fc6a5d82
StgOpenStorage shouldn't open zero length storage files.
2005-03-11 13:17:10 +00:00
8971f06225
- Rename apartment functions to become more object-oriented.
...
- Rename register_ifstub to marshal_object to more accurately describe
what it does.
- Add new function, apartment_getoxid, to prepare for a possible
future patch where remoting is started on demand.
2005-03-11 10:19:10 +00:00
23805995a6
Fix the calling convention of DllCanUnloadNow.
2005-03-10 17:25:02 +00:00
6f2f76c410
Shared reading of storage files requires STGM_TRANSACTED.
2005-03-09 11:44:59 +00:00
527ef47d70
Make each ifproxy have its own channel buffer to fix a bug where a
...
proxy with multiple interfaces could invoke the wrong stub buffer on
the server.
2005-03-07 17:14:11 +00:00
Alex Villacís Lasso