25bf0a409a
rpcrt4: Update TODO list.
...
Out-of-memory check is performed by NdrAllocate and so isn't required to
be done in the unmarshalling functions.
2007-12-14 12:24:34 +01:00
4a028589eb
rpcrt4: Document NdrAllocate.
2007-12-14 12:24:24 +01:00
c7261b732b
rpcrt4: Partially revert commit 18faf3184b2ea263d77c2a7ad92eef27bc4ba08f.
...
Tests show that NdrPointerFree (and hence NdrFree) don't check whether
the memory was allocated with NdrAllocate before freeing it. This makes
sense as servers don't need to use NdrAllocate to allocate memory being
returned and so this commit caused that memory to be leaked.
NdrAllocate hasn't been changed as the tests show it is correct and it
appears that the memory list is used to implement the RpcSs memory model.
2007-12-14 12:24:21 +01:00
ce220e2b5f
rpcrt4: Free the base pointer in PointerFree when freeing a pointer with RPC_FC_P_DEREF.
2007-12-14 12:24:03 +01:00
d5ff3467bc
rpcrt4: Fix the check in NdrPointerFree.
...
Add comments to justify why this is the only check that is needed.
2007-12-14 12:23:55 +01:00
ded4b86625
Revert "rpcrt4: Try to free every non-stack pointer in PointerFree now that NdrFree does the sanity checking for us.".
...
This reverts commit 6db648302ce43f625a073426a35a6f40b7869d8b.
Tests show the assumptions in a commit that this commit depends on are
not valid.
2007-12-14 12:23:38 +01:00
e12b487e26
rpcrt4: Try to free every non-stack pointer in PointerFree now that NdrFree does the sanity checking for us.
2007-12-12 16:02:53 +01:00
9c8c74f388
rpcrt4: Store allocated memory in a singly-linked list to keep track of what we should and shouldn't free in NdrFree.
2007-12-12 16:02:43 +01:00
766d8a17af
rpcrt4: Pass the USER_MARSHAL_CB structure into user marshal routines.
2007-12-10 12:04:28 +01:00
a07afe7e06
rpcrt4: Implement NdrConformantArrayMemorySize.
2007-12-10 12:04:15 +01:00
417b9d80f2
rpcrt4: Save the buffer in EmbeddedPointerMemorySize, like EmbeddedPointerUnmarshall does.
2007-12-08 19:58:11 +01:00
d7a0de303e
rpcrt4: Fix the return value from NdrSimpleStructMemorySize.
2007-12-08 19:58:07 +01:00
3a13de3115
rpcrt4: Add a trace to NdrBaseTypeMemorySize.
2007-12-08 19:58:03 +01:00
7ae1d44816
rpcrt4: Implement PointerMemorySize.
2007-12-08 19:57:55 +01:00
8348f0413d
rpcrt4: Fix NdrConformantStructUnmarshall to use buffer memory if applicable and to reuse memory for embedded pointers.
2007-12-08 19:57:46 +01:00
a5f9ed81e3
rpcrt4: Fix NdrFixedArrayUnmarshall to use buffer memory if applicable and to reuse memory for embedded pointers.
2007-12-08 19:57:39 +01:00
abbceb137a
rpcrt4: Fix NdrConformantArrayUnmarshall to use buffer memory if applicable and to reuse memory for embedded pointers.
2007-12-08 19:57:32 +01:00
ba6aec70ca
rpcrt4: Implement NdrConformantStructFree.
2007-12-07 17:06:05 +01:00
2ebee18198
rpcrt4: Improve PointerFree to not free buffer memory.
2007-12-07 16:34:17 +01:00
13e47d762a
rpcrt4: Set the memory pointer in NdrBaseTypeUnmarshall to the buffer if we're unmarshalling on a server without memory being passed in.
2007-12-05 13:49:08 +01:00
17132f7e1f
rpcrt4: Set fMustAlloc to TRUE when unmarshalling an object pointer.
2007-12-05 13:48:59 +01:00
2a9fae7565
rpcrt4: Set the destination pointer in PointerUnmarshall before calling the referenced type's unmarshalling routine.
...
When a pointer that is dereferenced is encountered then this can result
in a stale pointer (i.e. the one that is marshalled into the buffer for
the embedded pointer unmarshalling case) being used instead of the one
that was intended.
2007-12-04 18:18:01 +01:00
d8e467b0fd
rpcrt4: Reverse the conditions for which *pPointer is assigned base_ptr_val in PointerUnmarshall.
...
In one condition (fMustAlloc == TRUE), base_ptr_val may be uninitialised
and so cause a valgrind warning. Reversing the check is harmless and
doesn't result in a performance decrease.
2007-12-03 13:10:21 +01:00
c735a14788
rpcrt4: Fix NdrSimpleStructUnmarshall to cope with [in, out] embedded pointers.
2007-11-30 11:56:30 +01:00
b676309db3
rpcrt4: Improve PointerUnmarshall to cope with keeping the non-NULL source pointer of a client unmarshall.
...
This will enable various types with embedded pointers to handle [in,out]
parameters correctly by keeping the existing memory.
2007-11-30 11:56:21 +01:00
4e8f69ac2d
rpcrt4: Move forcing of fMustAlloc to NULL to the callers of EmbeddedPointerUnmarshall.
...
This will enable them to be individually fixed up to use memory if it
was provided by the caller.
2007-11-30 11:56:11 +01:00
43e0c67fe2
rpcrt4: EmbeddedPointerUnmarshall doesn't need to change the address of the allocated memory, so reduce the level of indirection of the memory parameter by one.
2007-11-30 11:56:04 +01:00
8668369b4f
rpcrt4: Fix an integer overflow in NdrConformantStructMarshall and NdrConformantStructUnmarshall.
2007-11-29 13:31:05 +01:00
074898ba2b
rpcrt4: Fix some more potential buffer overflows.
2007-11-29 13:30:58 +01:00
5a3c34eb89
rpcrt4: Check there is enough space in the buffer and that the size doesn't cause an overflow when copying data to it.
2007-11-29 13:30:21 +01:00
d0223ecc0e
rpcrt4: Check for integer overflows when increasing the buffer length.
...
Rename safe_buffer_copy to safe_copy_from_buffer.
2007-11-29 13:30:04 +01:00
046f24a0e7
rpcrt4: Raise an exception if a NULL ref-pointer is passed in to PointerMarshall or PointerBufferSize.
2007-11-21 12:03:35 +01:00
04dc115b54
rpcrt4: Handle FC_IGNORE in the base type functions.
2007-11-05 15:06:06 +01:00
8caa325eb7
rpcrt4: Initialize allocated pointers to NULL in PointerUnmarshall.
...
This patch initializes allocated pointers in PointerUnmarshall since later
code checks the value for NULL (specifically, NdrConformantArrayUnmarshall).
2007-11-05 13:24:36 +01:00
acfde97b9e
rpcrt4, widl: Make pointer layouts compatible with windows; fix conformant array tests.
2007-10-11 16:24:28 +02:00
f67a6adf4e
rpcrt4: Implement RpcSmDestroyClientContext and RpcSsDestroyClientContext.
2007-09-19 11:36:41 +02:00
fa3d623882
rpcrt4: Constify some variables.
2007-08-20 11:56:05 +02:00
12d3905427
rpcrt4: Fix the buffer bounds check.
2007-07-19 12:03:50 +02:00
2703059933
rpcrt4: Never allocate memory for the discriminant in union_arm_unmarshall as the memory is part of the union and has already been allocated.
2007-07-16 22:46:59 +02:00
b44c16cc8d
rpcrt4: Check to make sure there is enough data in the buffer during unmarshalling, so that the code doesn't try to read beyound the end of the buffer.
2007-07-16 22:46:55 +02:00
686c0f094c
rpcrt4: Even though FC_ENUM16 is an unsigned type, the highest allowable value that can be marshalled is SHRT_MAX, not USHRT_MAX.
2007-07-16 22:46:47 +02:00
ea7b1694de
rpcrt4: Allow enums as union switch types.
2007-06-26 11:59:43 +02:00
545c2a95f6
rpcrt4: Dereference the pointer passed to the marshaling/unmarshaling/sizing routines in complex types for interface pointers.
2007-06-25 23:21:55 +02:00
fc124eca6e
rpcrt4: Implement marshalling, unmarshalling and buffer sizing for the context handle type.
2007-06-25 23:21:55 +02:00
d36f02eaa9
rpcrt4: Implement marshalling/unmarshalling for the range NDR type.
2007-06-25 23:21:54 +02:00
4174255e0c
rpcrt4: Set PointerBufferMark to the buffer location immediately after the non-pointer data in complex struct and array marshaling and unmarshaling to keep to the DCE/RPC specification.
2007-06-25 23:21:54 +02:00
0f826e7cc1
rpcrt4: Use the offset to array data in embedded pointer format descriptions.
2007-06-20 13:08:30 +02:00
d2c15ed01b
rpcrt4: Fix typo in union buffer size calculation.
2007-06-19 11:46:02 +02:00
6fd05b1dc7
rpcrt4: Fix bug calculating union switch type.
2007-06-19 11:45:51 +02:00
b09b917a5c
rpcrt4: Remove inaccurate comments.
2007-06-19 11:45:44 +02:00
0871ab9130
rpcrt4: Implement encapsulated union NDR functions.
2007-06-18 13:58:09 +02:00
d5d056ef75
rpcrt4: Exclude unused headers.
2007-05-18 14:11:22 +02:00
67813450b9
rpcrt4: Replace inline static with static inline.
2007-03-23 12:29:52 +01:00
b6d8b27be5
rpcrt4: The format structures used in the marshaling code should have 1-byte alignment.
2007-02-12 15:20:52 +01:00
e3abd2b3ff
rpcrt4: Implement NdrSimpleType{Marshall,Unmarshall}.
2007-01-24 11:59:01 +01:00
5962cf6e4f
rpcrt4: Add some stub documentation headers to make winapi_check happy.
...
Also fix some headers that identified internal APIs as external.
2006-11-13 13:00:53 +01:00
de21efbadd
rpcrt4: Win64 printf format warning fixes.
2006-11-10 11:31:59 +01:00
718f3c3505
rpcrt4: More "unsigned long" to "ULONG" changes in preparation of the removal of WINE_NO_LONG_AS_INT.
2006-11-10 11:31:45 +01:00
0628fb5098
rpcrt4/ndr_marshall.c: Bring the function definitions in sync with their declaration.
...
Those got out of sync due to the unsigned long to ULONG migration in the headers.
2006-11-10 11:31:26 +01:00
7147f79153
rpcrt4: Cast-qual warnings fix.
2006-09-26 11:40:33 +02:00
59be6e0600
rpcrt4: Remember to skip over the conformance description.
2006-08-18 11:34:26 +02:00
dd000074fe
rpcrt4: Support for SMVARRAY in EmbeddedComplexSize.
2006-07-25 11:31:59 +02:00
5700fe8a61
rpcrt4: Set BufferMark before calling EmbeddedPointerMarshall, EmbeddedPointerUnmarshall or EmbeddedPointerMemorySize.
2006-07-24 13:47:40 +02:00
a8531067c4
rpcrt4: Support small fixed arrays in EmbeddedComplexSize.
2006-07-24 13:47:31 +02:00
4c4fc14fe9
rpcrt4: Allocate memory based on MaxCount, not ActualCount in NdrConformantStringUnmarshall.
2006-07-24 13:47:25 +02:00
98c26a81fe
rpcrt4: Add support for marshaling the FC_HYPER base type in complex types.
...
Change the FIXME messages to print out unrecognised format characters in
hex rather than decimal.
2006-07-24 13:47:13 +02:00
9318cb0fbc
rpcrt4: Handle more structure padding values.
2006-07-18 11:12:47 +02:00
2cb3b22c26
rpcrt4: Fix Variance Callback Functions.
...
A callback function for computing the variance puts the computed value
into the same field as a conformance, so make sure to copy the value
into pCount before returning from ComputeConformanceOrVariance.
2006-07-14 12:38:53 +02:00
00e779370f
janitorial: Put "inline static" at the beginning of a declaration.
2006-07-07 14:30:35 +02:00
85ed9a5905
rpcrt4: Don't advance the buffer for FC_STRUCTPAD2.
2006-07-05 11:44:19 +02:00
35982d72f5
rpcrt4: Initialise pStubMsg->MemorySize to zero before calling
...
ComplexStructMemorySize from NdrComplexArrayUnmarshall.
2006-06-12 13:21:46 +02:00
539b48bff4
rpcrt4: Use safe_mutiply in conformant array functions.
2006-06-12 13:21:46 +02:00
8dea3c2aa8
rpcrt4: Pass in a maximum variance value to ReadVariance to allow us
...
to validate the conformance values being read from the wire.
2006-06-12 13:21:46 +02:00
613ee6d01c
rpcrt4: Check that strings are null-terminated on unmarshaling of conformant-varying structs.
2006-06-12 13:21:46 +02:00
a946eb420b
rpcrt4: Use safe_multiply when multiplying anything by pStubMsg->ActualCount or pStubMsg->MaxCount.
2006-06-12 13:21:46 +02:00
cec6092aa2
rpcrt4: Raise an exception during unmarshaling if a conformant string isn't null-terminated.
2006-06-12 13:21:46 +02:00
6e95bfe85a
rpcrt4: Introduce a new function, safe_multiply, which will raise an
...
exception if a multiply overflows a 4-byte integer.
This will protect the unmarshaling code against attacks specifying a
large variance.
Use this new function in the conformant string functions to harden them
against attack.
2006-06-12 13:20:30 +02:00
d98b73a17a
rpcrt4: Clear an object pointer during unmarshaling, otherwise we
...
could end up using the previously allocated memory even if it isn't
the right size, causing heap corruption.
2006-06-09 21:07:57 +02:00
578df90d6d
rpcrt4: Initialise pStubMsg->MemorySize to zero before calling ComplexStructMemorySize from NdrComplexArrayUnmarshall.
2006-06-09 21:07:44 +02:00
21673d03f9
rpcrt4: Implement more base types for complex types.
2006-06-09 21:07:22 +02:00
c9779ca16b
rpcrt4: Implement varying array NDR functions.
2006-06-05 13:25:09 +02:00
cd19c99284
rpcrt4: Don't call NdrBaseTypeMemorySize from within NdrBaseTypeUnmarshall.
2006-06-05 13:24:54 +02:00
a48433453b
rpcrt4: The lifetime of the binding handle stored in the context
...
handle is independent of the binding handle used in the call that
unmarshaled it, so we should use RpcBindingCopy to make a copy of it
and then call RpcBindingFree later to free it.
2006-06-03 11:42:25 +02:00
a4fff73ba3
rpcrt4: Fix an incorrect format string pointer being passed in to
...
ComputeVariance in NdrConformantVaryingStructBufferSize.
2006-06-03 11:42:13 +02:00
da44126395
rpcrt4: Align the buffer correctly when marshaling and unmarshaling context handles.
2006-06-03 11:41:51 +02:00
ec5b3c3ea6
rpcrt4: Freeing a NULL context handle is allowed.
2006-06-03 11:41:42 +02:00
1a346a4a13
rpcrt4: NdrClientContextMarshall/Unmarshall should both increment the buffer pointer.
2006-06-03 11:41:33 +02:00
dc6c640cd2
rpcrt4: Fix the unmarshaling of pointers in conformant varying arrays,
...
by passing the correct type format string to ReadConformance.
2006-06-03 11:41:22 +02:00
972ce2f635
rpcrt4: CContext can be NULL in NDRCContextMarshall, in which case we should marshall all-zeros.
2006-06-03 11:41:07 +02:00
678ad6286c
rpcrt4: Fix the pointer count used when handling embedded pointers in varying arrays.
2006-06-03 11:40:45 +02:00
7f98594f75
rpcrt4: Implement NDRCContext(Un)marshall and NDRCContextBinding.
2006-06-01 11:48:33 +02:00
bb835ae438
rpcrt4: Add ENUM32 support to ComplexStructMemorySize.
2006-05-31 15:48:11 +02:00
115525f3c4
rpcrt4: Make UserMarshalFlags static.
2006-05-30 12:25:22 +02:00
df57b025c6
rpcrt4: We should never pass an fMustAlloc value of TRUE into the
...
unmarshaler routines of embedded complexes in complex struct and array
unmarshaling.
Fixes a regression caused by commit
19fad8e710
2006-05-30 12:25:17 +02:00
cafd2ab37e
rpcrt4: Make sure to set a unique pointer with an id of 0 to NULL when unmarshaling.
2006-05-30 12:25:03 +02:00
ff9fd9c430
rpcrt4: Handle marshaling/unmarshaling full pointers.
2006-05-30 12:24:41 +02:00
a534fdec32
rpcrt4: Implement NdrClientContext(Un)Marshall.
2006-05-26 20:21:00 +02:00
013d00f094
rpcrt4: Even though FC_DEREFERENCE conformance is handled elsewhere in
...
ComputeConformanceOrVariance it is still necessary to set the count
variable to the value retrieved.
2006-05-26 20:15:49 +02:00
42bf8254c0
rpcrt4: Stub implementations for NDRS marshalling functions.
2006-05-25 10:45:01 +02:00
ec2a9cef3a
rpcrt4: Set the Memory field of the stub message structure to the
...
start of the memory that an embedded pointer is embedded in so that
FC_POINTER conformance works correctly.
2006-05-25 10:40:35 +02:00
Rob Shearman