Commit Graph

660 Commits

Author SHA1 Message Date
Mike McCormack 4007d748dc Make enter and escape trigger the default and cancel buttons in
dialogs.
2005-10-29 11:07:46 +00:00
Mike McCormack 29c93e431d Deleted two buggy functions that incorrectly and inefficiently check
whether a row already exists in a table, and replaced them with a call
to an existing working function that does the same thing correctly.
2005-10-29 11:07:29 +00:00
Mike McCormack ab787f9d89 Remove an incorrect comment and check for 0 being an invalid file
handle.
2005-10-29 11:07:11 +00:00
Mike McCormack d730baf3b1 Extract file directly to their target location, bypassing the need to
use temporary files and move files.
2005-10-29 10:31:06 +00:00
Thomas Weidenmueller 561f2f0399 Passing NULL as the last two parameters to ReadFile is illegal and
actually causes a crash on windows. The attached patch fixes this.
2005-10-29 10:29:08 +00:00
Mike McCormack 481bccc8b7 Add an implementation for MsiGetShortcutTargetA/W. 2005-10-29 10:28:30 +00:00
Mike McCormack 7d99f36d03 Fix a memory leak. 2005-10-28 16:41:02 +00:00
Mike McCormack 7bdcc78bcd Put the UI update code for cabinet file into a separate function. 2005-10-28 10:43:50 +00:00
Mike McCormack 8caef535e0 Return an error in MsiGetComponentPathW if passed a null component. 2005-10-28 10:41:20 +00:00
Mike McCormack 029c83d88e Fix error handling in MsiEvaluateCondition. 2005-10-28 10:41:05 +00:00
Mike McCormack 2fa0dbd595 Translate INVALID_HANDLE_VALUE to zero for cabinet handles. 2005-10-28 10:40:54 +00:00
Mike McCormack 923a9e47e7 Fix a memory leak in the cabinet extracting code. 2005-10-28 10:09:59 +00:00
Mike McCormack 0bf9978da2 Fix MsiGetPropertyA/W spec declarations. 2005-10-28 09:39:35 +00:00
Mike McCormack 03b4dbbdc4 Create component folders in the CreateFolders action. 2005-10-28 09:39:29 +00:00
Mike McCormack 558abec8d5 If an action fails, print out its name as well as the error code. Use
%d for error codes so it's easy to match them up to something in
winerror.h.
2005-10-27 12:39:28 +00:00
Mike McCormack 51c6618d8d Rename load_dynamic_stringW to msi_dup_record_field to better describe
what it does, and replace a few instances with MSI_RecordGetString to
avoid allocating memory.
2005-10-27 12:36:12 +00:00
Mike McCormack 1cd26d25fc Implement transforms. This still includes some debugging code which
can be enabled by setting debug_transform to 1 in the relevant
places.
2005-10-27 12:25:04 +00:00
Mike McCormack ba293eef48 Tidy up the RegisterProduct action a little. 2005-10-27 12:08:16 +00:00
Mike McCormack f8fef6ea94 Create a stub function to apply a single table transform and call it
where we need to apply transforms.
2005-10-26 13:56:33 +00:00
Mike McCormack 965a72add0 Enumerate the substorage transforms for any patches that are passed on
the command line with PATCH=.  Need to implement
table_apply_transform() before this will do anything interesting.
2005-10-26 12:06:21 +00:00
Mike McCormack 6d9c80e8a0 Create an internal handle-free api for reading MSI database summary
information.
2005-10-26 10:10:50 +00:00
Mike McCormack 2cb2316557 Switch back to using IPicture to load images. LoadImage did the
resizing for us, but doesn't handle jpeg files and requires us writing
a temp file, whereas IPicture handles jpeg files and can load directly
from a stream.
2005-10-26 10:10:34 +00:00
Mike McCormack 61f24a4ca7 Rename ACTION_DoTopLevelINSTALL to MSI_InstallPackage, remove its
duplicate 4th parameter.
Split the code to copy a package into a separate function.
2005-09-30 10:32:41 +00:00
Mike McCormack 0560ea618e Avoid UpdateWindow, it causes trouble with WS_EX_TRANSPARENT. 2005-09-29 10:48:08 +00:00
Alexandre Julliard 7e22be4d84 We are no longer generating .dbg.c files. 2005-09-29 10:35:58 +00:00
Mike McCormack 74f0de9638 Create a function to read a property as an integer. 2005-09-29 10:32:39 +00:00
Mike McCormack 3b95515015 Add some more action stubs, remove forward declarations. 2005-09-28 18:10:44 +00:00
Mike McCormack e3452228c6 Split command line parsing from MSI_InstallPackage into a separate
function.
2005-09-28 15:12:32 +00:00
Mike McCormack 41c8ab5bac Add the progress control. 2005-09-28 15:12:10 +00:00
Mike McCormack 8e74308a10 Fix and test MsiViewGetColumnInfo and binary fields. 2005-09-28 11:59:40 +00:00
Mike McCormack 3c37734f96 Don't quote numbers in a query, as it doesn't parse correctly. 2005-09-28 11:59:16 +00:00
Mike McCormack 41c788f5a1 Don't create MSI handles unless we have to pass one through the API. 2005-09-28 10:13:18 +00:00
Mike McCormack fbbb32d6d1 Create a function to determine the table's row size and use it.
Fix a memory leak in the table code.
2005-09-26 13:25:48 +00:00
Mike McCormack 744e22c7df Fix various query related memory leaks. 2005-09-26 10:55:18 +00:00
Mike McCormack 2586a0958e Make a macro function for unimplemented actions.
Add some more unimplemented action stubs.
2005-09-26 09:56:18 +00:00
Mike McCormack 3c62c53d77 Fill out the stubs for MsiApplyTransformA/W a bit more. 2005-09-26 09:55:38 +00:00
Mike McCormack c877a2ef53 Fix handle leaks in the test cases. 2005-09-26 09:55:12 +00:00
Mike McCormack de71dbb2d8 Make sure to set the minimum size before allocating string table
memory.
2005-09-26 09:54:56 +00:00
Mike McCormack 786920b7b6 Handle copying of the install package to a temporary file in one place
only.
2005-09-25 15:14:32 +00:00
Mike McCormack 0c9468d66b Fix another memory leak. 2005-09-25 15:14:16 +00:00
Mike McCormack b9a3a7a1f9 Stub implementation of the IsolateComponents action. 2005-09-25 15:14:03 +00:00
Mike McCormack 362079cfb0 Fix a memory leak. 2005-09-23 17:21:46 +00:00
Mike McCormack 94fbe09c5f Add a stub implementation of the BindImage action. 2005-09-23 17:21:10 +00:00
Mike McCormack 567f0314af Stub implementation of the PatchFiles action. 2005-09-23 11:06:57 +00:00
Mike McCormack 170278dfe0 Implement MsiGetShortcutTargetA. 2005-09-23 10:48:42 +00:00
Mike McCormack 8e22e7d7a9 Stub implementation of the MoveFiles action. 2005-09-23 10:48:17 +00:00
Dmitry Timoshkov 37548987ad COLOR_3DFACE is a better choice for the dialog background. 2005-09-23 10:47:26 +00:00
Mike McCormack 202166c343 Stub implementation of the RemoveIniValues action. 2005-09-23 10:09:18 +00:00
Mike McCormack 67f83ba7e5 Take advantage of the msi_get_deformatted_field function to simplify
some code.
2005-09-23 10:05:23 +00:00
Mike McCormack 216a4427d5 Avoid using static variables in the InstallFiles action. 2005-09-23 10:05:08 +00:00
Mike McCormack 470f23d471 Fix various memory leaks. 2005-09-22 10:56:26 +00:00
Mike McCormack 994382b2ee Skip the first character of a font identifier if it's \ or &. 2005-09-22 10:54:56 +00:00
Mike McCormack af71ce16bf Fix an error introduced when converting dialog lists to standard
lists.
2005-09-22 10:49:26 +00:00
Mike McCormack 566c69e7e4 Simplify the ProcessComponents action a little. 2005-09-22 10:49:17 +00:00
Mike McCormack 1c5967c48c Load a table's column information separately from the table itself. 2005-09-22 10:34:07 +00:00
Mike McCormack 75658d7aaa Make build_icon_path return the path directly. 2005-09-22 10:33:57 +00:00
Mike McCormack d34b1c23a2 Implement MsiSequenceA/W. 2005-09-21 10:55:23 +00:00
Mike McCormack 7d7da60db4 Don't refcount tables. 2005-09-21 10:20:20 +00:00
Mike McCormack f3f12ab56b Simplify the InstallValidate action a little. 2005-09-21 10:20:03 +00:00
Mike McCormack 4407ea632d Make sure not to free a a pointer that has been modified.
Check that the text identifier doesn't contain invalid characters.
2005-09-21 10:19:42 +00:00
Mike McCormack 6dc309187c Fix some simple memory leaks. 2005-09-21 09:43:29 +00:00
Dmitry Timoshkov 12b2cf4c77 Fix the usage of COLOR_xxx constants in the place of the window's
class hbrBackground.
2005-09-20 12:02:45 +00:00
Mike McCormack ee034ba4c2 Added memory allocation inline functions (part 2). 2005-09-20 11:59:14 +00:00
Mike McCormack 8dc28d5306 Added memory allocation inline functions (part 1). 2005-09-20 11:57:19 +00:00
Mike McCormack c621a5801f Fix if's that are followed by semicolons. 2005-09-20 11:37:58 +00:00
Jan Van Buggenhout eebf13a1d8 implement stubs for MsiSequence[AW]. 2005-09-20 11:37:30 +00:00
Milko Krachounov 980f817737 Bulgarian resources for mpr, msi, user, commdlg, oleaut32, shdocvw,
shell32, comctl32, msrle32, mshtml, winspool, wineps, serialui,
setupapi, wininet, regedit, uninstaller, notepad, winecfg and
winhelp.
2005-09-19 17:00:58 +00:00
Kimmo Myllyvirta d4dff29081 Added Finnish resources. 2005-09-19 14:29:49 +00:00
Alexander N. Sørnes f9b3edb42e Added Norwegian translations. 2005-09-18 12:26:22 +00:00
Mike McCormack 230e71cc18 Fix memory leaks in the table code. 2005-09-17 14:29:38 +00:00
Mike McCormack dcb0f239fe Read the MaskEdit template from the correct db field. 2005-09-17 14:29:29 +00:00
Mike McCormack b84e29747b Convert the list of dialog controls to a standard list. 2005-09-16 19:40:00 +00:00
Mike McCormack 6b5f290d75 Make load_string_table return the string table. 2005-09-16 19:01:40 +00:00
Mike McCormack 43fece976f Deformat all dialog text strings before using them. 2005-09-16 19:01:18 +00:00
Mike McCormack 978d12d0f6 Load riched20.dll on demand, and unload it after it's used (based on a
patch by Rob Shearman).
2005-09-16 18:45:33 +00:00
Mike McCormack 67189f9d1a Fix a bug in a previous patch spotted by Dieter Komendera. 2005-09-16 18:45:19 +00:00
Mike McCormack 4a202c2112 Fix the stub for MsiConfigureFeature. 2005-09-16 18:45:04 +00:00
Mike McCormack 062ad50510 Rename load_dynamic_property and remove its unused 3rd argument. 2005-09-15 15:04:08 +00:00
Mike McCormack 4db02cdb0b Use the new msi_reg_set* macros where possible. 2005-09-15 14:58:38 +00:00
Mike McCormack 8a61b4ef16 Create a macro to write a value to a subkey. 2005-09-15 09:31:41 +00:00
Mike McCormack fb45042e4d Create a macro function to write registry values. 2005-09-14 15:42:27 +00:00
Mike McCormack ade532a163 Remove some unused values in the object header. 2005-09-14 11:15:22 +00:00
Mike McCormack 5f1b258c9c Convert the list of tables to a standard list. 2005-09-14 10:07:26 +00:00
Alexandre Julliard 903e0b9fc5 Get rid of a couple of non-portable long long constants. 2005-09-13 11:26:36 +00:00
Mike McCormack 1cdffb26c9 Fix the handling of MsiGetTargetPath args (with test case). 2005-09-13 11:25:20 +00:00
Mike McCormack 2acf5086ff Make sure to release the package we grabbed on the error path. 2005-09-13 11:25:07 +00:00
Mike McCormack e17ef695a2 Fix the handling of MsiDoAction args (with test case). 2005-09-13 10:37:46 +00:00
Mike McCormack 79ca56cd6a Eliminate fixed length buffers from the MSIFEATURE structure. 2005-09-13 10:37:37 +00:00
Mike McCormack b2e2b70d06 Skip dash characters in the PIDMask for a MaskedEdit control. 2005-09-13 10:33:04 +00:00
Mike McCormack ca2c8c867f Eliminate yet more fixed length buffers. 2005-09-12 15:28:00 +00:00
Alexandre Julliard b597f99960 Fixed memory leak introduced in previous change. 2005-09-12 14:14:50 +00:00
Mike McCormack efcc1ec5e4 Fix more fixed length buffers. 2005-09-12 12:07:15 +00:00
Alexandre Julliard 92a5149540 Avoid non-portable va_list manipulations. 2005-09-12 11:13:05 +00:00
Mike McCormack cbb5709a04 Make sure not to access invalid components or features. 2005-09-12 11:08:20 +00:00
Mike McCormack a9a3bc7b14 Fix an uninitialized variable problem. 2005-09-12 10:11:23 +00:00
Mike McCormack 1f09af3004 Move a fixed size buffer to the heap. 2005-09-09 14:49:08 +00:00
Mike McCormack f11c8b0098 Reduce the indent level of a function. 2005-09-09 14:48:51 +00:00
Alexandre Julliard 20a1a203c6 Use a more portable scheme for storing the name of a critical
section.
2005-09-09 10:19:44 +00:00
Mike McCormack 5c1212261f Allocate memory rather than using fixed length buffers. 2005-09-08 12:42:31 +00:00
Mike McCormack 0232c5c45f Convert RunningActions array into a list. 2005-09-08 12:42:07 +00:00