Commit Graph

221 Commits

Author SHA1 Message Date
Michael Stefaniuc 45553a97b0 oledb32: Remove redundant not-NULL check (coccinellery).
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-02-22 12:27:05 +01:00
Alistair Leslie-Hughes 217ab34f57 oledb32/tests: Add convert DBTYPE_DATE -> DBTYPE_DBTIMESTAMP test.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-01-10 09:10:58 -06:00
Nikolay Sivov 1d52cfc47f oledb32/tests: Fix string leaks (Valgrind).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-12-17 10:08:03 +01:00
Alex Henrie a4adc1d7a8 oledb32: Make constant 'hexchars' static.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-12-04 16:13:10 +01:00
Alex Henrie 4d525212a9 oledb32: Turn variable 'format' into a static constant.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-30 19:36:51 +01:00
Michael Stefaniuc 3ba9ba7af5 oledb32: Use the ARRAY_SIZE() macro.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-19 08:07:07 +02:00
Michael Stefaniuc 166f8e6cc2 oledb32/tests: Use the available ARRAY_SIZE() macro.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-04 14:22:43 +02:00
Michael Stefaniuc f9ddf9ad6d oledb32: Use the global HeapAlloc() wrappers.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-05 10:00:04 +01:00
Alistair Leslie-Hughes 86147a9917 oledb32/tests: Add DataConvert DBTYPE_BSTR->DBTYPE_DBTIMESTAMP test.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-04 11:39:19 +01:00
Alistair Leslie-Hughes cce5ac1dea oledb32: Silence interfaces for IDataSourceLocator QI.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-03 10:44:02 +01:00
Alistair Leslie-Hughes 4ee4d4e2ad oledb32: Coerce Variant to VT_DATE when converting data.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-03 10:44:02 +01:00
Alistair Leslie-Hughes 7563a49721 oledb32: Fix typo.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-08 20:19:42 +01:00
Alistair Leslie-Hughes 4a5759dcc2 oledb32: DataConvert support DBTYPE_VARIANT -> DBTYPE_R4.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-08 20:19:35 +01:00
Alistair Leslie-Hughes 70d54d8c67 oledb32: Support DBTYPE_DBTIMESTAMP to DBTYPE_WSTR in DataConvert.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-28 11:30:32 +02:00
Alistair Leslie-Hughes 9d11f0f962 oledb32: Support DB/DATE/TIME/TIMESTAMP in GetConversionSize for W/STR.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-27 11:27:47 +02:00
Alistair Leslie-Hughes 6e148790f4 oledb32: Add FIXME for DBTYPE_NUMERIC type.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-22 10:58:01 +02:00
Alistair Leslie-Hughes 23b5640b32 oledb32: Add support for converting to W/STR types in GetConversionSize.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-22 10:57:05 +02:00
Alistair Leslie-Hughes b257f29473 oledb32: Supply a default dst len in GetConversionSize.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-22 10:57:03 +02:00
Alistair Leslie-Hughes eb96566ef4 oledb32/tests: Add to DBTYPE_WSTR tests for GetConversionSize.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-20 10:39:09 +02:00
Nikolay Sivov ffd3e8543c oledb32: Support textual representation of Mode property values.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-20 18:58:46 +02:00
Alistair Leslie-Hughes 39935fe5ad oledb32/tests: Add convert to DBTYPE_NUMERIC tests.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-27 16:54:54 +02:00
Alistair Leslie-Hughes a744cc81df oledb32: Support DBTYPE_NUMERIC in IDataConvert GetConversionSize.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-16 10:05:24 +01:00
Alistair Leslie-Hughes d4e14aa014 oledb32: Ignore IRunnableObject in IDataSourceLocator_QueryInterface.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-14 14:19:16 +01:00
Józef Kucia 97170a8a80 oledb32/tests: Do not use pointer to freed memory (Coverity).
Signed-off-by: Józef Kucia <jkucia@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-07 16:33:38 +01:00
Huw Davies aedd6e951c oledb32: Fix conversion of strings with embedded '\0' to DBTYPE_STR | DBTYPE_BYREF.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-01 15:57:25 +01:00
Alistair Leslie-Hughes 853de70bc0 oledb32/tests: Add tests for conversion to DBTYPE_STR.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-01 15:57:19 +01:00
Huw Davies 28debe67d2 oledb32: Fixed length calculation in conversion to DBTYPE_STR.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-01 15:57:15 +01:00
Alex Henrie 89b7529612 oledb32/tests: Fix a use-after-free in test_converttobyrefwstr.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-28 22:20:00 +01:00
Francois Gouget 87f21b12b3 oledb32: Add __WINE_ALLOC_SIZE attributes to heap_xxx() functions.
And standardize their parameter names.

Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-22 12:02:00 +01:00
Alistair Leslie-Hughes 98a2465abd oledb32: Support converting to DBTYPE_BYREF | DBTYPE_STR in DataConvert.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-22 11:32:14 +01:00
Nikolay Sivov 0cb665ca8a oledb32: Allow single quotation marks around property values.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-02 19:50:34 +01:00
Nikolay Sivov 83d33b6f94 oledb32: Added GetDataSource() for DataLinks object.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-02 19:50:34 +01:00
Nikolay Sivov c2a6738f9a oledb32: Added a stub IDataInitialize for DataLinks object.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-02 19:50:34 +01:00
Nikolay Sivov 37fcb0d630 oledb32: Fixed IDataInitialize definition.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-30 21:38:48 +01:00
Louis Lenders 239653ea12 oledb32: Add version resource.
Signed-off-by: Louis Lenders <xerox.xerox2000x@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-26 11:49:38 +01:00
Nikolay Sivov 275790c767 oledb32: Implement GetErrorParameters().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-16 13:20:15 -06:00
Nikolay Sivov 9a084ab6d3 oledb32: Use better naming for IErrorRecords implementation structure.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-16 13:20:13 -06:00
Nikolay Sivov 3fdfea7786 oledb32: Implement GetBasicErrorInfo().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-15 16:06:10 -06:00
Nikolay Sivov 333039f318 oledb32: Implement GetCustomErrorObject().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-15 16:06:07 -06:00
Nikolay Sivov 41984c62a6 oledb32: IErrorRecords uses 0-based index to access record info.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-15 16:06:04 -06:00
Nikolay Sivov 4a3054e445 oledb32: Use growing array to store error records.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-15 16:05:55 -06:00
Sebastian Lackner 81f110cc36 oledb32/tests: Fix incorrect usage of broken() function.
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-09-08 23:15:00 +09:00
Nikolay Sivov 85c6afe4ce oledb32: Support quoted values in initialisation strings.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-09 18:47:08 +09:00
Nikolay Sivov f5f6cfb0f7 oledb32: IErrorInfo methods are stubs.
There's no way to set error info for this object

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-03 22:25:10 +09:00
Nikolay Sivov dc8f504b51 oledb32/tests: Simplify recount check.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-18 10:36:18 +09:00
Alistair Leslie-Hughes e5daf33978 oledb32: GetConversionSize shouldn't fail for null variants.
If we have a NULL variant which will be converted to a non-fixed sized
type (DBTYPE_WSTR) then we just return S_OK.

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-23 16:32:12 +01:00
Alistair Leslie-Hughes 9c70026092 oledb32: Convert to a BSTR to work out it size.
This makes code for handling variants with DBTYPE_STR and DBTYPE_WSTR
types consistent.

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-22 13:51:01 +01:00
Nikolay Sivov ae9281e27f oledb32: Allow case-insensitive match for Provider keyword.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-04 14:41:38 +09:00
Alistair Leslie-Hughes 0edd515b95 oledb32: Support VT_NULL on all conversions.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-03 22:14:38 +09:00
Marcus Meissner 99549e1e2e oledb32: Free memory on error exit (Coverity). 2015-06-15 14:47:45 +09:00