f05618bd00
Do not HeapFree() memory not allocated by us in COMBO_GetText.
...
Convert return value from LB_GETTEXT into COMBO_GetText.
2001-05-02 01:08:59 +00:00
ed90b185f2
Draw the padding area of a combo box.
2001-04-30 18:17:46 +00:00
15a3b74356
Documentation name fixes.
2001-04-27 18:03:51 +00:00
7a06d45fca
Do not send WM_MOUSEACTIVATE for children of desktop.
2001-04-17 17:57:20 +00:00
d62c3f16ac
Remove redundant sending of WM_DRAWITEM message to ownerdrawn
...
combobox.
2001-04-17 17:29:31 +00:00
e8ffcaa372
Slightly improve keyboard tracking in combobox.
2001-04-16 19:32:19 +00:00
7c7a3571d4
Set the backgound mode to opaque to paint highlighted text.
2001-04-16 19:32:05 +00:00
3f03975f48
Added first/last message filters to MSG_InternalGetMessage to avoid
...
busy waits.
2001-04-12 21:09:03 +00:00
c9e11394a0
Added mappings for WM_CHARTOITEM and WM_MENUCHAR messages.
...
Removed mapping of 16-bit edit messages in the generic routines.
2001-04-10 21:46:27 +00:00
6df245dd68
Really do not roll up if selection is being tracked by arrow keys in
...
the dropdown listbox.
2001-04-09 18:30:25 +00:00
2ec34e48a3
Added TASK_GetPtr/TASK_GetCurrent functions to get the TDB for a task
...
handle.
2001-04-04 00:21:05 +00:00
9d4ae0eff9
Do not send the EN_CHANGE notification message until the selection
...
start and end values are filled in.
2001-04-02 19:13:24 +00:00
f11ff2a448
Update format engine to reduce flicker.
2001-03-31 00:51:10 +00:00
627aa4d772
Native version seems to always re-draw the selected text at the end of
...
a rollup.
2001-03-20 01:51:58 +00:00
2482ef3339
Fix system menu crash by ensuring that item->text is not null when
...
MF_TEXT set.
2001-03-19 19:16:21 +00:00
cf2ff27f5f
Recalculate menu sizes if WM_INITMENU has recreated/changed something.
2001-03-14 17:24:59 +00:00
a62f06d027
Yet another attempt on fixing notifications in the edit control.
2001-03-13 23:31:08 +00:00
87880c5e23
Fixed notifications of the edit control.
2001-03-10 19:16:46 +00:00
d36a3ef385
Call DefWindowProc for WM_CTLCOLORSTATIC message when the apps does
...
not.
2001-03-10 19:16:26 +00:00
3d0589ae7d
Fixed spelling/typos in comments.
2001-03-10 19:15:49 +00:00
fbc3619ca0
Make EDIT_UnlockBuffer cope with destroyed windows.
2001-03-05 19:29:47 +00:00
a862f68db5
Added a few missing stubs to KERNEL32 and USER32.
2001-02-26 22:33:29 +00:00
52ece0efef
Use GetSysColorBrush(COLOR_WINDOW) when there is no brush for drawing
...
background in listbox.
2001-02-26 22:31:55 +00:00
b32c00055c
Prepare background while drawing radio buttons and checkboxes.
2001-02-23 01:32:05 +00:00
da2892c0fb
Do not allocate any USER data on the system heap.
2001-02-23 01:13:42 +00:00
79413eda91
- Restructure PaintText code to remove FillRect from owner-drawn path.
...
- Change SetFocus to indicate focus set only after Notify is sent to owner.
- Get more info in a trace.
2001-02-20 01:53:12 +00:00
b99367e20e
debugstr_xxx already does the quoting.
2001-02-14 21:42:10 +00:00
9316fa3db3
Convert menu item to seperator only when string is NULL.
2001-02-14 00:23:45 +00:00
4a69939aa8
Don't crash on close from window manager.
2001-02-13 01:49:06 +00:00
bf60453c6a
Fix the behaviour of EM_GETLINE message.
2001-02-12 19:15:33 +00:00
8ac1acbb1a
Ownerdrawn combo boxes should use ODS_COMBOBOXEDIT in the itemState.
2001-02-12 01:17:16 +00:00
4782b0e57f
- When painting the text, if the control is OWNERDRAWN the issue the
...
WM_DRAWITEM message.
- Set the focused status at the end of the end of the Setfocus routine.
- Flip the order of updating the list box and issuing the WM_NOTIFY
for CBN_EDITUPDATE to match native.
2001-01-26 20:59:51 +00:00
40fddf7c1b
Do not notify parent of the Edit control on WM_SETTEXT when Edit is
...
part of the ComboBox.
2001-01-26 20:37:18 +00:00
0c61028734
Documentation ordinal fixes.
2001-01-25 22:22:21 +00:00
c1d35ccd9b
Use DrawFrameControl() instead of OEM bitmaps to paint caption buttons
...
and menu check marks.
2001-01-24 19:47:57 +00:00
9c446a13cd
Protect read-only edit control from modification.
2001-01-22 19:28:27 +00:00
05fc3cdf9a
Typo fixes in comments.
2001-01-22 02:22:26 +00:00
d661dbdd6c
Specified 'signed' on chars compared to -1.
2001-01-19 20:51:44 +00:00
a234db82eb
Solve remaining problems with scroll bars in the edit control.
2001-01-19 20:49:54 +00:00
df793bcb68
Add one missing buffer size rounding in the edit control.
...
Make rounding code slightly more readable.
2001-01-15 20:20:31 +00:00
a41b2cfdd0
Moved tweak support to USER dll. Removed tweak.h and cache.h.
2001-01-15 20:12:55 +00:00
f3ea345b2d
Guard against incoming string of NULL in WM_SETTEXT.
2001-01-12 23:01:41 +00:00
785203ced8
Fix the return value of WM_GETTEXT in the edit control.
2001-01-11 20:17:21 +00:00
376beadaaa
Various combobox fixes.
2001-01-11 20:17:07 +00:00
f77709ea19
Synchronize the sizes of the external and internal buffers at start
...
and end of message processing in the edit control.
2001-01-10 23:55:02 +00:00
db8fb6f387
Fixed returned length for LB_GETTEXT.
2001-01-10 23:54:46 +00:00
ba9b96457d
es->buffer_size is not always the length of the text currently in the
...
editbox, so use -1 instead.
2001-01-10 22:54:33 +00:00
7462099847
Added unicode window proc for the listbox control.
...
Replaced all ansi calls by their unicode equivalents.
Removed use of the custom local heap.
2001-01-09 21:51:04 +00:00
b3da1ac0cd
Ensure there is an edit control when we reset contents.
2001-01-09 20:49:53 +00:00
4866ac0859
Combobox should clear its current selection on response to
...
CB_SETCURSEL(-1) message.
2001-01-07 21:43:49 +00:00
75b278e9dd
Modify the look of bitmap menu items to match Win95 and Win98
...
Fix the sunken edge/bitmap overlap in the Win98 look
Introduce an IS_MAGIC_ITEM macro to test if the item is 'magic'
2001-01-06 01:45:51 +00:00
85ba8798b5
Took a stab at implementing LBS_NOSEL.
2001-01-06 00:34:14 +00:00
f5f9f2cc51
Added unicode window proc for combobox control.
...
Replaced ansi calls by their unicode equivalents.
2001-01-05 22:21:18 +00:00
009c1f8005
Added unicode window proc for the static control.
...
Replaced ansi calls by their unicode equivalents.
2001-01-05 22:20:57 +00:00
11dbda6bf9
Fixed some problems with scrolling in the edit control.
2001-01-05 03:40:35 +00:00
5818240965
Fixed the alignment of the MF_RIGHTJUSTIFY menu items.
2001-01-04 20:56:43 +00:00
fe9a0f0977
Fixed a problem where when deleting an item using index -1 on an empty
...
listbox we would pass through an illegal negative index and cause
problems.
2001-01-04 19:27:03 +00:00
a6d83ebae1
- clarify many error messages
...
- add data corruption warning to README file
2000-12-27 04:02:46 +00:00
366c0a16a5
Fix remaining signed/unsigned mismatches.
2000-12-22 20:28:05 +00:00
5801723b50
Replaced WIN16_GlobalLock16 by "official" function K32WOWGlobalLock16.
2000-12-22 01:09:26 +00:00
8058ead8ea
Don't write to buffer with zero length.
...
Removed some unused function parameters.
2000-12-21 20:19:21 +00:00
f8b96e272a
Make new edit control allocate its buffers with granularity 32 byte.
...
Ensure that all copied strings are 0 terminated.
2000-12-20 18:39:14 +00:00
4e62b9df8b
New unicode edit control.
2000-12-19 19:36:49 +00:00
44a182229b
winuser.h now requires that we include winbase.h first.
2000-12-19 04:53:20 +00:00
7c55bc0cd6
Only capture mouse when an item is selected.
2000-12-15 22:58:25 +00:00
956c847f49
Invalidate the focus rect when a listbox is resized.
2000-12-13 21:26:45 +00:00
982a223f36
Replaced PTR_SEG_TO_LIN macro by exported MapSL function.
...
Fixed a few ptr/segptr mismatches.
Moved CONV_RECT/POINT macros to wingdi16.h.
2000-12-13 20:20:09 +00:00
bf67259a41
Use the DRIVE_* API constants instead of the DRIVETYPE enum.
...
Changed DRIVE_CANNOTDETERMINE and DRIVE_DOESNOTEXIST to use the
correct names.
Cleaned up a few dependencies on internal drive.c functions.
2000-12-12 00:44:42 +00:00
91222da881
Moved most builtin controls structures into their respective C file.
...
Created new controls.h file private to user32.dll and moved remaining
builtin controls definitions there.
2000-12-10 23:01:33 +00:00
9877906b26
Removed dependencies on the internals of the CLASS structure.
...
Added support for having both ASCII and Unicode window procedures for
builtin classes.
2000-12-07 23:39:16 +00:00
cef7c7af61
Update internal controls on WM_WINDOWPOSCHANGED.
2000-12-06 03:21:57 +00:00
6213ab3a89
Fixed a problem where the string in a combo box flickers if you
...
rapidly reset the content and then replace the content.
2000-12-05 21:12:05 +00:00
2b3aa616e8
Added/modified documentation for function arguments.
2000-12-01 23:58:28 +00:00
537bcadf55
Don't update scrollbars when processing WM_DESTROY.
2000-11-30 20:37:29 +00:00
94a6832b04
WM_SETTEXT should return TRUE on success.
2000-11-29 00:02:46 +00:00
2b4be4be93
Made button control fully unicode aware.
2000-11-28 23:51:48 +00:00
24a62ab9b0
Got rid of the Wine internal lstrcpy* functions and of winestring.h.
2000-11-28 22:40:56 +00:00
529da54394
Require {DECLARE,DEFAULT}_DEBUG_CHANNEL statements to end in a ;
2000-11-27 23:54:25 +00:00
9cdd22c53d
When processing mouse messages in MENU_TrackMenu, use the coordinates
...
in lParam instead of those in MSG::pt.
2000-11-27 22:39:35 +00:00
2682bc24ca
Fixed a few dependencies on 16-bit or internal functions. Fixed a few
...
warnings.
2000-11-27 22:03:23 +00:00
ac7efef3b5
Changed GetProcAddress16 and 16-bit resource functions to take normal
...
pointers instead of SEGPTRs.
Removed WIN16_GetTempDrive.
2000-11-27 21:54:01 +00:00
7a947b34b7
General clean up of the edit control: removed transfer of unused
...
variables, fixed signed/unsigned mismatches.
2000-11-27 01:34:25 +00:00
cbbc7c3d60
Don't draw scrollbars if their client rectangle is empty.
2000-11-26 22:36:53 +00:00
2c691b31ce
Implemented Win16 behaviour of DDL_DRIVES in DlgDirList.
2000-11-25 03:06:03 +00:00
9308f640c1
Prepare switching to unicode of builtin widgets.
2000-11-15 23:05:52 +00:00
abe635cfd7
Get rid of some warnings about unused variables, signed/unsigned
...
comparisons and incomplete initializations.
2000-11-11 00:38:37 +00:00
0c247ec775
Fixed typos in comments.
2000-11-07 20:30:50 +00:00
75f9e647aa
Take into account the sunken border for Win98 look.
...
Leave a 1 pixel gap to the left of menu bitmap items for symetry (and
because Win9x does it).
Leave a 1 pixel gap above menu bar items for symetry (and because
Win9x does it).
2000-11-06 05:25:29 +00:00
606f6203d4
Don't reset MF_POPUP flag in SetMenu().
2000-11-05 03:18:11 +00:00
d5e15d3be1
Do not invert "magic" bitmap menu items.
2000-11-02 20:08:34 +00:00
908464d448
Authors: Andreas Mohr <amohr@codeweavers.com>, Dimitrie O. Paun <dimi@cs.toronto.edu>, Patrik Stridvall <ps@leissner.se>
...
Various warning fixes.
2000-11-01 03:11:12 +00:00
d0ff2ec08b
Make bitmap menu items look like in windows when selected,
...
i.e. inverted and hilited (in Win98 look).
2000-11-01 02:11:41 +00:00
e3810e3acc
Check for SB_CTL before displaying a caret.
2000-11-01 01:52:37 +00:00
eecb40ec43
Hide the caret only on the first WM_KEYDOWN.
2000-10-31 01:03:15 +00:00
45c9fd892f
- set the item height not only for the listbox, but also for the text field
...
- center text vertically
- beautify comments
2000-10-28 00:29:58 +00:00
ef55932f4b
Ask application to reinitialize its menu before processing an
...
accelerator key.
2000-10-26 21:47:20 +00:00
9a58351fda
Added support of blinking thumb as found in Windows scrollbar.
2000-10-25 21:26:27 +00:00
c946b1cccd
Converted menu string handling to Unicode.
2000-10-24 21:28:19 +00:00
a4251bbe4c
Do not block CBN_EDITCHANGE for WM_PASTE or WM_CUT with the
...
NOEDITNOTIFY flag, as these msgs can come directly from the app to the
combo wndproc.
2000-10-24 01:38:49 +00:00
6bfbc3d23e
Do not send EN_UPDATE to multi-line edit controls.
2000-10-23 00:38:10 +00:00
93fd46af54
Fixed the text color of higlighted menu bar item for the Win98 look.
...
Clicking on a separator should not close the menu.
Do not right align 'bitmap' items and the help menu for the Win9x look
and feels.
2000-10-23 00:37:49 +00:00
15bfcd0398
Moved $(MODULE).o rule out of Make.rules into the individual
...
Makefiles.
2000-09-29 00:28:25 +00:00
83f52d11c1
Moved all Win16 definitions out of the standard Windows headers.
2000-09-26 22:20:14 +00:00
072dfb57e3
Removed inclusion of wine/winestring.h from winbase.h and added it to
...
the C files that need it.
2000-09-25 23:30:56 +00:00
8caa407c05
In WM_DRAWITEM, always calls the app with a valid current focus_item.
2000-09-24 19:29:18 +00:00
6f07e8abbc
Fixed window lock problem in SetMenu().
2000-09-19 02:38:11 +00:00
6117fc4165
(Merged by Marcus Meissner <marcus@jet.franken.de>)
...
Fixed problem with origin for DST_COMPLEX style.
Fixed handling of DSS_DISABLED and DSS_DEFAULT styles.
Added handling of BS_MULTILINE style, label alignment
styles (BS_RIGHT, etc.) and some exotic styles BS_FLAT (only
pushbuttons for now), and BS_PUSHLIKE.
Modified label drawing procedure: now all kinds of buttons
use common BUTTON_DrawLabel function. Actual label drawing is
performed by DrawStateW function.
GroupBox must use WM_CTLCOLORSTATIC instead of WM_CTLCOLORBTN message.
2000-09-13 00:00:55 +00:00
ed66930518
SetScrollInfo : don't show/hide scrollbar if no parameter (minval,
...
maxval) change.
2000-09-12 23:59:10 +00:00
20cd9356a8
- fixes debugger output
...
- get rid of wrong comments
- fix comments
- .spec spelling fix
- improve warning message
2000-09-12 23:40:40 +00:00
5ae1c396cc
Avoid divide by zero when listbox set to zero height.
2000-09-09 19:39:24 +00:00
fbb2c9bdf8
GetMenu might be used to get child window id.
2000-09-09 19:38:34 +00:00
2b5d9c6e50
Always call LISTVIEW_SetSelection() for an item, even if that item
...
has been selected before, in order to let other items get erased.
2000-08-29 03:52:16 +00:00
597cb552ce
Update the edit box before rolling up the listbox, so the
...
selection isn't lost.
2000-08-14 17:18:49 +00:00
c7e7df8b17
Replaced all lstr* calls from inside Wine code by their str* equivalent.
2000-08-14 14:41:19 +00:00
198746d812
Replaced global Callbacks structure by appropriate glue code
...
generation. Removed a few unused entries in the Callout structure.
2000-08-14 14:29:22 +00:00
42d20f9dca
Merged clipboard driver into USER driver.
...
Moved all ttydrv source files to dlls/ttydrv.
Load functions pointer for the USER driver from the graphics driver
dll with GetProcAddress.
2000-08-10 01:16:19 +00:00
5ab9d860f2
Removed some unnecessary #includes and dll dependencies.
2000-08-09 22:35:05 +00:00
c4fac7867e
Initialize 'str' in ICONTITLE_GetTitlePos.
2000-08-07 23:51:02 +00:00
dbf5a4792c
Avoid resetting the background color when clearing out blank areas, as
...
it may have been set to something other than COLOR_WINDOW by the
application.
2000-08-06 03:35:52 +00:00
cb10fdab99
Replaced lstrlen/lstrcmp by libc equivalents everywhere we don't need
...
to trap exceptions.
2000-08-06 02:41:16 +00:00
b0efe28f6c
Removed a few dependencies on GDI internals from USER dll.
2000-08-04 04:18:04 +00:00
cef12530eb
Change logic of listbox resizing for 16 bits apps for lists without
...
LBS_NOINTEGRALHEIGHT style.
2000-08-01 20:48:40 +00:00
690142dc5b
Fix a few typos and such.
2000-07-23 13:43:00 +00:00
9fe0e634e5
Fixed calculation of buffer length after switch of window text to
...
unicode.
2000-07-23 13:33:48 +00:00
9788ba6e54
Set clipping region to client window before owner-drawn painting.
2000-07-16 15:39:37 +00:00
0e805aa358
Background of SS_SIMPLE static control is not filled (unless it has
...
SS_NOPREFIX too).
2000-07-16 14:39:21 +00:00
fcd352152f
All standard window controls should have CS_PARENTDC, but should still
...
clip to the control window.
2000-07-15 21:31:42 +00:00
7251640113
Don't clear selection when initial entry is not in the list.
2000-07-15 21:27:32 +00:00
235d39cf9e
Replaced %s by %p in EDIT_WM_SetText.
2000-07-15 15:12:38 +00:00
04da8b8f28
Convert WND.text field to Unicode.
...
Add new key to wine.ini in the section [x11drv] - TextCP, which means
code page used for texts passed to X.
Accordingly fix handlers of WM_SETTEXT/WM_GETTEXT.
2000-07-10 12:09:31 +00:00
2ffbb31e3a
Make the focus follow the last selected item for multiselect listboxes.
2000-07-09 12:18:14 +00:00
d292234835
Set the minimum dropped height to the combo list height if any in
...
CBDropDown.
2000-06-25 12:47:59 +00:00
c9e6031dca
CB_SETCURSEL should not generate another listbox event after updating
...
the edit box.
2000-06-18 17:20:37 +00:00
20af4c3c87
GetSystemMenu called with bRevert argument set to TRUE now returns
...
NULL as specified in Platform SDK.
2000-06-18 17:17:54 +00:00
ac3e81640a
Set clipping region to client window in LISTBOX_Paint.
2000-06-15 00:58:42 +00:00
41b07fb4d9
WM_SETREDRAW should repaint the listbox when set to on if something
...
has been changed.
2000-06-15 00:07:20 +00:00
50523d164f
Take focus before setting the caret position and selections.
2000-06-11 20:34:07 +00:00
13ffd58a1f
Added save and reset of SetBKMode values in WM_PAINT.
...
Added handling of lParam value in BM_SETSTYLE.
2000-06-11 20:08:46 +00:00
d552d98b51
Add support for icons set by STM_SETIMAGE.
2000-06-11 20:00:33 +00:00
9926d33450
- ComboLBox is always created as child of ComboBox. If ComboBox has style
...
other than CBS_SIMPLE, parent of listbox is set to desktop.
- In CBDropDown. ComboBox uses only first item to calculate height of
dropped listbox. Also if listbox is empty its height is unmodified
(previously it was set to 0).
- Added correct handling of WM_GETDLGCODE and WM_(SYS)KEYDOWN messages.
- General clean-up. Message order is now more precise (at least
notifications to client); listbox - combobox interaction has slight
differences comparing to Windows.
2000-06-07 03:48:02 +00:00
9eedcf5852
- Removed dependency of edit control from combobox implementation.
...
- Edit control uses undocumented window style 0x0200 to detect is it a part
of combobox. If so it calls GetDlgItem(hwndCombo, 1000) to get ComboLBox
window handle (see comments for combo.c below).
- EDIT_CheckCombo - modified for correct handling of keyboard messages.
- Processing of WM_GETDLGCODE and WM_CHAR for VK_RETURN and VK_ESCAPE
depends on whether listbox is dropped down. This prevents closing of dialog
if listbox is dropped down and allows combobox to process these keyboard
messages properly.
2000-06-07 03:47:34 +00:00
07917e40e8
- We can use wnd->wIDmenu for ComboLBox (it is not reset anymore in SetParent)
...
- When user clicks outside of dropped listbox, original selection must be
restored.
- ComboLBox has caret_on = FALSE on creation, that's why combobox sends
LB_CARETON message before dropping listbox down (but only for
CBS_DROPDOWNLIST - I don't now why).
2000-06-07 03:46:57 +00:00
72bdd5bee7
Stephane Lussier
...
Sheri Steeves
Haithem Hmida
- Height of the listbox should be adjust when LBS_OWNERDRAWFIXED is set
and not if LBS_OWNERDRAWVARIABLE is set, previously it was not adjusting
the size in both cases.
- When the caret index change, items repainting need tp be in this
order
a) Paint old caret item without the focus
b) Paint old caret item without the selection
c) Paint new caret item with the selection
d) Paint new caret item with the focus.
- When repainting the listbox, we should paint all items regarding if
they are slected or not and then paint after the focus item. So focus
item will end out being painted twice. (That's what Windows does).
2000-06-07 03:17:35 +00:00
b09c6ef5ae
Attempt to paint the checkbox and radio buttons better.
2000-06-04 01:32:59 +00:00
2e011a5243
Lots of spelling fixes that accumulated in my tree again, made several
...
error msgs more verbose, doc updates.
2000-06-01 23:28:25 +00:00
207f7019e6
Louis-Philippe Gagnon (of Macadamian for Corel)
...
Static controls weren't receiving WM_LBUTTONDBLCLK messages because the
Static window class was registered without the CS_DBLCLKS style (which it
has in Windows).
2000-06-01 23:15:49 +00:00
bfe15b12ad
MSDN: "WM_NCHITTEST - Returns HTCLIENT if the control style is
...
SS_NOTIFY; otherwise, returns HTTRANSPARENT. "
2000-06-01 22:46:51 +00:00
d566a0e309
Serge Ivanov
...
Returning DLGC_WANTALLKEYS for multiline edit control was not good because
it breaks navigation in dialogs.
2000-05-30 20:50:09 +00:00
8a92213111
- Creating combobox with CBS_SIMPLE style shall set internal flag CBF_EDIT.
...
- Edit text must be selected only if CB is in focus.
- If CB has edit control we have to call CBUpdateEdit to update its
contents. Invalidating textRect will not force updating of child
edit control, obviously.
- We have to protect ourselves from changing selection in listbox when
we receive listbox notification. So LBN_SELCHANGE -> CBUpdateEdit ->
EN_CHANGE will not reselect item in the lisbox.
2000-05-30 17:48:33 +00:00
dcc175de6a
Owen Wang
...
When you click on an icon to open a combo box, you would expect it to
be enabled so you can choose something in it. In Wine this was not
guaranteed since your default flags could get lost in the process-heap
of the application.
2000-05-30 15:28:06 +00:00
Marcus Meissner