6398448974
comctl32/comboex: Move debugging traces that require additional code into TRACE_ON() condition.
2009-12-24 12:15:41 +01:00
253edf0fbb
comctl32/comboex: Get rid of useless helper.
2009-12-24 12:15:41 +01:00
7d748b6ba0
comctl32/comboex: Don't invalidate all windows if Edit box isn't set up.
2009-12-24 12:15:41 +01:00
7deb277900
comctl32/comboex: Fix silly typo in CBEM_SETITEM handler (lParam wasn't set).
2009-12-24 12:15:41 +01:00
96d965f295
comctl32/comboex: Add test for internally sent Edit messages, remove corresponding comments.
2009-12-24 12:15:41 +01:00
ecc89bf6ef
comctl32/comboex: Use subclass chain for internally used controls.
2009-12-24 12:15:41 +01:00
7fa3778d8c
comctl32/rebar: Fix default just inserted band colors.
2009-12-23 14:27:30 +01:00
80ed866ff4
comctl32/tests: Explicitly create rebar for each test, cleanup main function a bit.
2009-12-23 14:27:30 +01:00
9ef90f480a
comctl32/updown: Don't change control z-order, this breaks auto buddy binding.
2009-12-23 14:27:30 +01:00
750ce6be35
comctl32/updown: Don't update buddy text if it's the same.
2009-12-23 14:27:30 +01:00
f0a35db253
comctl32/tests: Fix a test failure on older comctl32.
2009-12-22 15:40:00 +01:00
6cc141ff59
comctl32/updown: Simplify buddy subclassing using SetWindowSubclass chain.
2009-12-22 13:48:26 +01:00
705aee525a
comctl32/tests: Use win_skip() while skipping subclass tests.
2009-12-22 13:48:25 +01:00
48d42d4a93
comctl32/tests: Some tests for buddy procedure subclassing.
2009-12-22 13:48:25 +01:00
8fc96f20a3
comctl32/tests: Add ability to create any number of edit buddies.
2009-12-22 13:48:25 +01:00
64bd51b1d3
comctl32/toolbar: Improve fixme message conditions.
2009-12-22 13:48:24 +01:00
93d45253cd
comctl32/tests: Don't cast NULL to an integer type.
2009-12-21 15:01:24 +01:00
48efba00b6
comctl32/rebar: Don't read outside of bands array on dragging.
2009-12-21 15:01:24 +01:00
07fc19bbe3
comctl32/rebar: Collapse some parameter checks and winproc entries.
2009-12-21 15:01:24 +01:00
b6abcb2f86
comctl32/rebar: Move parameter cast to winproc.
2009-12-21 15:01:24 +01:00
1e74d5992c
comctl32/rebar: Use DPA to manage bands data.
2009-12-21 15:01:24 +01:00
6fd93a6c7e
comctl32: Use the module instance instead of that of the owner window for the toolbar configuration dialog.
2009-12-21 11:20:19 +01:00
fb1fada93a
comctl32/tests: Fix some test failures on older comctl32.
2009-12-15 11:44:56 +01:00
e81f2642f1
comctl32/treeview: Implement NM_SETCURSOR notification.
2009-12-14 12:04:05 +01:00
49dabfe31d
comctl32/treeview: Draw +/- signs with text color, not the lines' one.
...
+/- aren't affected by customdraw settings, only per control
set colors used.
2009-12-14 12:04:05 +01:00
b65a7a0052
comctl32/treeview: Fix default colors set on creation.
2009-12-14 12:04:05 +01:00
28d5410596
comctl32/treeview: Fix mouse tracking request code.
...
After query current tracking state passed parameters could be overwritten,
similar fix for Listview was recently committed.
2009-12-14 12:04:05 +01:00
1d0e02b63e
comctl32/tests: Fix a test failure on older comctl32.
2009-12-10 16:53:32 +01:00
83f2135e0d
comctl32/tests: Get rid of static handles, split tests finally.
2009-12-10 11:56:43 +01:00
6823e0f3ec
comctl32/treeview: Remove some forward declarations.
2009-12-10 11:56:35 +01:00
e3c34f2d29
comctl32/treeview: Use additional helper for item invalidation.
2009-12-10 11:56:23 +01:00
dc45e2c513
comctl32/treeview: Avoid a NULL pointer dereference.
2009-12-09 14:54:01 +01:00
c2a7535e9d
comctl32/listview: Update item width every time new item is inserted.
...
This prevents retaining previously stored width and unexpected item
displaying collapsing with ending ellipsis.
2009-12-09 14:25:21 +01:00
7d6412c82d
comctl32/datetime: Free internal data completely on control destruction.
2009-12-07 14:18:26 +01:00
bd8fc9c474
comctl32/tests: Don't forget to free array after tests.
2009-12-07 14:18:26 +01:00
0f003ef48d
comctl32/tests: Free imagelist after use.
2009-12-07 14:18:26 +01:00
6d989feff9
comctl32/treeview: Free items pointer array and root item on control destruction.
...
Two issues here: item pointers array wasn't freed, root item data wasn't freed.
Found by Valgrind.
2009-12-07 14:18:26 +01:00
eaee84f4db
comctl32/updown: Set width to default value on creation.
2009-12-03 14:02:54 +01:00
b2d89f4823
comctl32/updown: Specify all styles explicitly in tests.
2009-12-03 14:02:54 +01:00
fa92edfa48
comctl32: Implementation the WM_GETTEXT processing of datetime control.
2009-12-02 16:08:45 +01:00
e4e55ed8b4
comctl32: Test the WM_GETTEXT processing of datetime control.
2009-12-01 15:10:37 +01:00
1804941797
comctl32/treeview: Simplify WM_CHAR handler.
2009-12-01 13:14:11 +01:00
277c5139d2
comctl32/treeview: Clean up winproc a bit, move parameter check to handlers.
2009-12-01 13:14:06 +01:00
4376ccf3fc
comctl32: Use FAILED instead of !SUCCEEDED.
2009-12-01 13:04:36 +01:00
d2e169fadd
comctl32/header: Avoid uninitialized memory passed to HDM_INSERTITEM, some fields are always copied.
2009-11-30 12:56:53 +01:00
1e1c1310f5
comctl32/listview: Get rid of duplicated helper in tests.
2009-11-30 12:56:47 +01:00
78e7b3cf9c
comctl32/listview: New hover value should be passed using LPARAM.
2009-11-30 12:56:30 +01:00
ea058d22ba
comctl32/listview: Add NM_HOVER notification.
2009-11-30 12:56:21 +01:00
5f191553e8
comctl32/listview: Make mouse hover work.
...
Event data was overwritten by TME_QUERY response.
2009-11-30 12:56:05 +01:00
8eb9e7ebd5
comctl32/listview: Draw LVIS_CUT items with white foreground color.
2009-11-30 12:55:50 +01:00
999810566b
comctl32/listview: Implement LVS_EX_HEADERINALLVIEWS.
2009-11-30 12:55:43 +01:00
dcd54f08fc
comctl32/listview: Get rid of helper used once.
2009-11-30 12:55:23 +01:00
a729e040e6
comctl32/listview: Further winproc simplification.
2009-11-30 12:55:12 +01:00
60f0f4e8ca
comctl32/listview: Call default procedure directly from handlers if such forwarding needed.
2009-11-30 12:55:00 +01:00
8d43bdd2ee
comctl32/listview: Remove parameter check from winproc for LVM_SETITEMPOSITION32.
2009-11-30 12:54:37 +01:00
62c610df3c
comctl32/listview: Collapse some handlers call in winproc.
2009-11-30 12:54:01 +01:00
fc43895f49
comctl32/listview: Default column width in LVS_LIST to better value.
2009-11-30 12:53:40 +01:00
fa7c2b5c5f
comctl32/toolbar: Use proper button index when freeing a string in TOOLBAR_DeleteButton.
2009-11-23 13:09:25 +01:00
850ea2a711
comctl32/listview: Add support for LVFI_SUBSTRING.
2009-11-23 10:38:13 +01:00
b7b7b7113e
comctl32/listview: Fix find using partial string logic.
2009-11-23 10:38:00 +01:00
90c4abe86f
comctl32/listview: Add LVSIL_GROUPHEADER definition.
2009-11-23 10:37:44 +01:00
79c55c5dd1
comctl32/listview: Group control data members, there's no reasonable structure here.
2009-11-23 10:37:23 +01:00
899a53eda5
comctl32/listview: Send LVN_ENDLABELEDIT in any case, but with null text if it's the same.
2009-11-23 10:37:03 +01:00
f5f0763827
comctl32/listview: Don't forward WM_COMMAND (EN_KILLFOCUS) from Edit to parent window.
2009-11-23 10:36:51 +01:00
c39268967d
comctl32/listview: Do nothing on LVM_CANCELEDITLABEL if there's no label.
2009-11-23 10:36:41 +01:00
9cec74f300
comctl32/tab: Reset current selection on negative focus value.
2009-11-20 14:48:40 +01:00
33a1e827a7
comctl32/tab: Fix selection change when selected item is deleted.
2009-11-20 14:48:35 +01:00
336a68be54
comctl32/tab: Split tests to several functions not to depend from each other.
2009-11-20 14:48:31 +01:00
3371ba9f73
comctl32/tab: Fix reading out of array bounds on TCM_SETCURSEL.
2009-11-20 14:48:27 +01:00
c044fa8a59
comctl32/monthcal: Don't pass uninitialized data to MCM_SETTODAY, test isn't about this.
2009-11-19 16:16:52 +01:00
b0861921b2
comctl32/listview: Compare item text on insert depending on A/W message.
2009-11-19 14:24:31 +01:00
9e73769112
comctl32/tests: Fix some test failures on comctl32 4.70.
2009-11-19 12:29:30 +01:00
482c454e50
comctl32/tests: Fix imagelist v6 test failures on XP.
2009-11-19 11:48:51 +01:00
5ce3af5b37
comctl32/tests: Use SHIL_SYSSMALL instead of LARGE, and compare with system metrics.
...
This patch fixes a test failure if a user has a non-standard icon size
set. Windows 7, for instance, offers more variation than previous
versions of Windows in icon scaling. We should get the system icon
metric and compare our icon size against that.
2009-11-19 11:48:38 +01:00
459361d4d6
comctl32/tests: Use defined flags instead of magic numbers in v6 tests.
2009-11-17 15:14:53 +01:00
9db87f13d3
shell32: Implement SHGetImageList and remove todo_wine from imagelist tests.
2009-11-17 15:14:53 +01:00
c0a6c5cd3f
comctl32/tests: Add hotspot/drag test for IImageList.
2009-11-17 15:14:53 +01:00
341e6ed533
comctl32: Implement imagelist drag functions, GetOverlayImage.
2009-11-17 15:14:53 +01:00
2e9a6e96e3
comctl32: Implement GetImageRect, Get/SetIconSize, Get/SetBkColor.
2009-11-17 15:14:53 +01:00
9adc1b8fd6
comctl32/tests: Add test of IImageList_Merge function.
2009-11-17 15:14:53 +01:00
7caa61fde6
comctl32/imagelist: Make ImageList_Destroy just decrease refcount. Move actual destruction to ::Release.
2009-11-16 15:02:02 +01:00
4afc54540d
comctl32/imagelist: Use defined flags instead of magic numbers in tests.
2009-11-16 15:01:34 +01:00
3e20458aca
comctl32/imagelist: Get rid of magic field, use vtable pointer instead. Keep original layout.
2009-11-16 15:01:27 +01:00
c00b759415
comctl32: Fix typos.
2009-11-16 13:47:55 +01:00
76c7f28050
comctl32: Implement Copy, Merge and Clone methods in IImageList.
2009-11-16 13:30:01 +01:00
b37009ee80
comctl32/tests: Add further tests for IImageList.
2009-11-16 13:29:09 +01:00
8a4a761683
comctl32: Implement SetOverlayImage, Replace, AddMasked, Draw, Remove, GetImageInfo.
2009-11-16 13:29:01 +01:00
a07c922fa3
comctl32/tests: Add tests for IImageList based on standard imagelist tests.
2009-11-16 13:27:54 +01:00
dff6be098e
comctl32: Implement Add, ReplaceIcon, GetImageCount, SetImageCount in IImageList.
2009-11-16 13:27:37 +01:00
c2e0226d2f
comctl32: Removed useless NULL check (Coverity).
2009-11-16 12:43:07 +01:00
54a01bf5bc
comctl32/tests: Remove unused parameter.
2009-11-13 12:21:41 +01:00
856dda3288
comctl32/tests: Add IImageList creation test.
2009-11-13 12:14:46 +01:00
a4f2ab9d14
comctl32: Add basic structure for IImageList interface.
2009-11-13 12:14:40 +01:00
459a0c4de9
comctl32/treeview: Collapse some message handlers.
2009-11-12 17:06:47 +01:00
073486569a
comctl32/toolbar: Call handlers in more general way.
2009-11-12 17:06:35 +01:00
7b19d8bba6
comctl32/toolbar: Use single handler for TB_GETBUTTONTEXTW/TB_GETBUTTONTEXTA.
2009-11-12 17:06:26 +01:00
62a7373913
comctl32/toolbar: Use single handler for TB_SETBUTTONINFOW/TB_SETBUTTONINFOA pair.
2009-11-12 17:06:20 +01:00
e1f3edef3e
comctl32: Add support for scrolling during marquee selection.
2009-11-04 13:07:57 +01:00
c1877a2d50
comctl32: Cancel marquee selection if we lose focus in listview.
2009-11-04 13:07:57 +01:00
038e36aded
comctl32: Move marquee logic into separate function.
2009-11-04 13:07:57 +01:00
14991b78d8
comctl32: Add absolute version of iterator_frameditems.
2009-11-04 13:07:57 +01:00
9bd6887372
comctl32/tests: Use A-functions.
2009-10-28 16:07:48 +01:00
eaa939e942
comctl32/tests: Release Imagelist handles when no needed anymore.
2009-10-26 11:19:25 +01:00
31ae6a902e
comctl32/toolbar: Don't leak button strings.
2009-10-26 11:19:19 +01:00
a04c6db804
comctl32/tests: Explicitly initialize window handle.
2009-10-23 14:40:40 +02:00
a061d3a0d4
comctl32: Fix imagelist leak when switching LVS_EX_CHECKBOXES style.
2009-10-22 14:37:13 +02:00
cd7cfd7451
comctl32/listview: Free ID array when removing all items.
2009-10-22 14:37:02 +02:00
7301ec8aa8
comctl32/listview: Free column data on control destruction.
2009-10-22 14:36:56 +02:00
aaec03347d
comctl32/listview: Don't query header if it isn't created.
2009-10-22 14:36:47 +02:00
ebea81f131
comctl32/tests: Release activation context handle when we're done with tests.
2009-10-21 16:05:59 +02:00
57577fb20b
comctl32/header: Don't leak Imagelist handle.
2009-10-21 16:05:59 +02:00
e98687f425
comctl32/syslink: Implement LWS_IGNORERETURN.
2009-10-21 16:05:58 +02:00
b853de8038
comctl32/syslink: Implement LWS_TRANSPARENT style.
2009-10-21 16:05:58 +02:00
92c2d8afcd
comctl32/syslink: Add a WM_ERASEBKGND handler.
2009-10-21 16:05:58 +02:00
36e9153f38
comctl32: Ensure listview control has focus when marquee dragging.
2009-10-20 14:27:17 +02:00
41099b0ff7
comctl32/tests: Fix some test failures on older comctl32.
2009-10-20 14:00:36 +02:00
32bba6222b
comctl32: Add a trailing '\n' to a Wine trace.
2009-10-19 14:45:37 +02:00
5a45951f3e
comctl32/monthcal: Fix compilation on systems that don't support nameless unions.
2009-10-19 14:45:04 +02:00
a8f89a2ffa
comctl32/propsheet: Test and fix for crash processing PSM_INDEXTOHWND with no longer valid handle.
2009-10-19 14:44:57 +02:00
1ab851a1bd
comctl32/monthcal: Explicitly set required control size.
2009-10-19 11:45:20 +02:00
5517209a24
comctl32/header: Process input order array more accurately.
2009-10-19 11:45:17 +02:00
76859b0f47
comctl32/treeview: Erase background on WM_PAINT if BeginPaint() tells us to do it.
2009-10-19 11:45:12 +02:00
685fe55f97
comctl32: Only execute hit test in MouseMove if necessary.
2009-10-19 11:34:45 +02:00
cbdc99cdba
comctl32/monthcal: Get/set unicode format flag using MCM_[GET|SET]UNICODEFORMAT.
2009-10-16 13:36:01 +02:00
f84a6bdf3a
comctl32/tooltips: Remove unneeded helper parameter.
2009-10-15 14:16:05 +02:00
38c0d421ec
comctl32/tooltips: Remove redundant code, let handlers deal with A<->W conversions.
2009-10-15 14:15:35 +02:00
f394bed597
comctl32/tooltips: Test the way structure size field is validated.
2009-10-15 14:10:59 +02:00
98a7d8cf9d
comctl32/tooltips: Fix an obviously wrong structure size check.
2009-10-15 14:10:32 +02:00
2cc98ef94a
comctl32/monthcal: Reduce update rectangle after updating current selection.
2009-10-14 11:25:46 +02:00
ca579f7c61
comctl32/monthcal: Fix painting selected day, remove unneeded operations.
2009-10-14 11:25:41 +02:00
e1de222e4e
comctl32/comboex: Handle NULL item text case to avoid crash.
2009-10-14 11:25:34 +02:00
3c130309d3
comctl32/tests: Fix a test failure on older comctl32 versions.
2009-10-13 11:28:09 +02:00
e58b5349fb
comctl32/monthcal: Add separate handler for WM_PRINTCLIENT.
2009-10-13 11:27:59 +02:00
7beaa88ed9
comctl32/monthcal: Implement handler for WM_ERASEBKGND.
2009-10-13 11:27:52 +02:00
840a39e90a
comctl32/monthcal: Simplify painting operations, split painting to several helpers.
2009-10-13 11:27:48 +02:00
5a244bc863
comctl32/monthcal: Fix today link test.
2009-10-12 13:01:54 +02:00
a914372586
comctl32/datetime: Use SDK class name for inner button window.
2009-10-12 13:01:48 +02:00
f12f948849
comctl32/datetime: It isn't allowed to change DTS_SHOWNONE after creation.
2009-10-12 13:01:42 +02:00
a096ba4c5b
comctl32/datetime: Fix wrong assumption about DTN_DATETIMECHANGE flags, add DTN_CLOSEUP notifications.
2009-10-12 13:01:35 +02:00
8431bed5f6
comctl32/datetime: Get rid of duplicated helper.
2009-10-12 13:01:28 +02:00
a4b5c5db1c
comctl32: Don't use additional heap allocated pointer to old window procedure.
2009-10-12 13:01:21 +02:00
ecf89c7e3d
comctl32/monthcal: Fix selection during navigation with prev/next buttons.
2009-10-12 13:00:46 +02:00
c9e3e3bc8e
comctl32/monthcal: Fix multiselection days painting, including intersections with prev/next months.
2009-10-12 13:00:39 +02:00
4651624d35
comctl32/monthcal: Simplify parameter set of day of week calculation helper.
2009-10-12 13:00:30 +02:00
7d2ef4f23d
comctl32/monthcal: Fix column/row calculation for previous and next month.
2009-10-12 13:00:19 +02:00
22dddce999
comctl32/monthcal: Fix a test skip condition - zero is a valid day of week.
2009-10-12 13:00:08 +02:00
6b72f16906
comctl32/monthcal: Handle over/underflow while navigation with month menu.
2009-10-12 13:00:01 +02:00
18857222ec
comctl32/monthcal: Handle September 1752 with a special case - it's a 19 day month.
2009-10-12 12:59:53 +02:00
a00c217ce9
comctl32/monthcal: Reuse existing calls to get day of week.
2009-10-12 12:59:37 +02:00
2906aaf605
comctl32/monthcal: Process UpDown year control through subclass procedure.
2009-10-12 12:59:31 +02:00
Nikolay Sivov