Commit Graph

52 Commits

Author SHA1 Message Date
Alexandre Julliard 16fb8fd843 cabinet: Don't allocate a huge buffer on the stack. 2008-12-11 12:24:33 +01:00
Ricardo Filipe 1a12aace57 cabinet: Fix dead stores (llvm/clang). 2008-11-18 13:04:59 +01:00
Michael Stefaniuc bfe6fe678a cabinet: Do not cast NULL. 2008-11-03 13:38:43 +01:00
Rob Shearman 79ad9cbcdd cabinet: Check buffer size before copying in NONEfdi_decomp.
Check that the data will fit into the fixed sized buffer CAB(outbuf)
and return an error if not before copying.
2008-10-01 11:42:36 -05:00
Juan Lang c479ea631f cabinet: Use helper function to remove duplicate code. 2008-09-10 10:40:33 +02:00
Juan Lang 70cfa0c36e cabinet: Use helper function to remove duplicate code. 2008-09-10 10:40:27 +02:00
Alexandre Julliard c1add0ff51 cabinet: Always use INT_PTR for handles. 2008-06-18 20:48:54 +02:00
Dmitry Timoshkov 5ddd35f493 cabinet: Fix the regression caused by 4046075462. 2008-05-19 13:33:41 +02:00
Andrew Talbot 4046075462 cabinet: Remove order-of-evaluation dependencies. 2008-05-14 12:21:26 +02:00
Andrew Talbot 938150d01f cabinet: Indentation fix. 2008-05-05 13:34:05 +02:00
James Hawkins fe8c3f9059 cabinet: Revert "cabinet: Fix for FDICopy with an empty cabinet file.".
This reverts commit 33e561f53c.
Fixed the test that fails on all platforms.
2008-04-28 13:27:51 +02:00
Vitaly Perov 33e561f53c cabinet: Fix for FDICopy with an empty cabinet file. 2008-04-25 15:02:10 +02:00
Rob Shearman 903a486dc0 cabinet: Replace strcasecmp call with lstrcmpiA as strcasecmp isn't portable and doesn't take into account the current codepage. 2008-02-18 12:20:35 +01:00
Andrew Talbot 69599675a7 cabinet: Remove unneeded cast. 2007-12-31 17:41:09 +01:00
Andrew Talbot f2df3d7582 cabinet: Remove unneeded casts. 2007-12-06 12:07:36 +01:00
Andrew Talbot b3e56e9d0b cabinet: Remove unneeded casts. 2007-12-03 13:10:21 +01:00
Jeff Latimer 30892c8b8d cabinet: Remove unnecessary function. 2007-09-10 15:29:47 +02:00
James Hawkins 2918a272e3 cabinet: Return the value of GetLastError if FDICopy fails. 2007-08-24 11:26:48 +02:00
Alexandre Julliard d5ff728265 cabinet: Use the proper fcntl defines in the FDI_OPEN calls. 2007-08-22 12:19:00 +02:00
Dmitry Timoshkov 3c9e7a7f33 wine: Switch to using 'long' for INT_PTR type for 64-bit compatibility. 2007-05-25 20:37:56 +02:00
Alexandre Julliard a14920e50f cabinet: Make sure we don't try to close an invalid file handle. 2007-04-26 14:25:42 +02:00
Gerald Pfeifer cd7aecd52a cabinet: Simplify code in fdi_decomp(). 2007-03-16 11:18:42 +01:00
Andrew Talbot 5c812a14f3 cabinet: Constify some variables. 2007-03-15 12:15:38 +01:00
Alexandre Julliard a71a22c579 cabinet: Fixed fd leak in case of error. 2007-02-14 13:12:32 +01:00
Andrew Talbot 267fcdd009 cabinet: Improve initialization of some arrays. 2007-01-26 12:56:12 +01:00
Michael Stefaniuc 33af3c5c83 janitorial: Use the C standard for multiline strings. 2007-01-10 12:28:19 +01:00
James Hawkins a79765ff02 cabinet: Close the opened file handle even in error cases. 2006-12-15 12:20:37 +01:00
Andrew Talbot 49e8797de2 cabinet: Cast-qual warnings fix. 2006-10-20 10:19:46 +02:00
James Hawkins e981278769 cabinet: Make internal functions static. 2006-10-12 11:35:15 +02:00
Jonathan Ernst 360a3f9142 Update the address of the Free Software Foundation. 2006-05-23 14:11:13 +02:00
James Hawkins 877c8092cf cabinet: Move the remaining cabextract.c functions to fdi.c. 2006-01-12 13:30:43 +01:00
James Hawkins 362aa36d09 cabinet: Add documentation for FDITruncateCabinet. 2006-01-11 12:12:54 +01:00
James Hawkins d57c20ac95 cabinet: Store the cab file handle before extracting files so we can
close the cab file even if no files are extracted.
2006-01-09 20:23:15 +01:00
Stefan Huehner 17ed5537e7 Fix some more -Wmissing-declarations warnings. 2005-07-05 11:05:50 +00:00
Filip Navara 8f3b7dfddc Don't try to free pointer from union that isn't used. 2004-12-06 16:09:37 +00:00
Hans Leidekker 411fc5f164 Fix signed/unsigned comparison warnings. 2004-09-02 23:00:53 +00:00
Francois Gouget 2a3d5fc105 A few spelling fixes. 2003-09-08 18:54:08 +00:00
Alexandre Julliard e37c6e18d0 Fixed header dependencies to be fully compatible with the Windows
headers (with help from Dimitrie O. Paun).
2003-09-05 23:08:26 +00:00
Gregory M. Turner fc5e7048c5 Don't touch perf in FDIIsCabinet, InstallShield may already have freed
it.
2003-08-18 19:50:14 +00:00
Gregory M. Turner f910024057 Many words about cabinets. 2003-08-05 18:31:55 +00:00
Gregory M. Turner b8675b4312 Remember decompression state during extraction, so as to avoid
unnecessary work.
2003-08-02 00:42:23 +00:00
Gregory M. Turner 857398a9f8 - ERR("WARNING") just doesn't look right ;)
- treat zero file handle as invalid if the callback returns it
- provide the same args as Windows to the Open callback
2003-07-30 03:45:46 +00:00
Gregory M. Turner a8bbbf5ad1 - eliminate pesky global variables; should be threadsafe now
- fix more memory leaks
- fix some bugs
- some decruftification
- implement support for split cabinets and "NEXT_CABINET" notification
2003-07-19 03:09:21 +00:00
Francois Gouget 14a5d168e9 Fixed some common spelling errors. 2003-07-02 04:37:26 +00:00
Gregory M. Turner 50c6965c78 - remove unused loop that always iterates once
- remove warning
- preparations to use multiple fdi_decomp_state structures in a linkedlist,
  which will be used to implement split cabinets, if all goes according
  to plan -- this is somewhat analogous to struct cabinet in cabextract.
2003-06-23 18:10:47 +00:00
Francois Gouget c5f775a9c7 Typos/spelling fixes. 2003-06-18 03:30:39 +00:00
Gregory M. Turner 0c63c39c8d - move macros and constants into cabinet.h where they can be shared
between cabextract.c and fdi.c
- reminders to eliminate global variables (for multithread
  compatibility)
- remove struct fdi_cab: due to the nature of the FDI API, we cannot
  preload all the cabinets; this appears to obviate the need for struct
  fdi_cab
- "oppress" (that is, do not process) partial files which were
  continuations from another cabinet
- more than one partial file can exist in a single cabinet (how!?) --
  so move the partial file notification (and "oppression" that goes with
  it) into the loop that iterates through files
2003-06-17 03:56:51 +00:00
Gregory M. Turner d1957c6092 - most of FDICopy is now implemented, although the actual decompression is not.
- "can" -> "do"
- a novella about a bug
- fix some memory leaks
2003-06-13 23:15:55 +00:00
Gregory M. Turner 6f27b3bc06 - implement FDI{Create,Destroy,IsCabinet}
- fix a typo
- duplicate a bug
- some blathering about code duplication
- change fdi.c indentation to be consistent with cabextract.c
2003-06-13 18:04:35 +00:00
Greg Turner 55b2bf1d89 - port cabextract to wine
- implement cabinet.dll.Extract, urlmon.dll.Extract
- add SP6a registry key to winedefault.reg
2002-12-19 21:16:56 +00:00