57fa1bee65
msi: Do not open registry keys with no access rights.
...
Signed-off-by: Thomas Faber <thomas.faber@reactos.org>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-01 18:49:25 +09:00
7ab2139191
msi/tests: Use todo_wine_if() in tests.
...
Signed-off-by: Frédéric Delanoy <frederic.delanoy@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-20 12:07:11 +09:00
7b21373bf1
msi: Fix the CHAR column type.
...
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-15 21:30:04 +09:00
8fe7ee31a1
msi: Include the dialog in the check for duplicate event subscriptions.
...
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-26 22:37:32 +09:00
434f0f7cb1
msi: Refreh controls after spawned dialog is closed.
...
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-22 21:29:55 +09:00
e90b34e131
msi: Allow PathEdit controls to be updated.
...
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-22 21:29:52 +09:00
ae3f25cc44
msi: Fixed same file handle closed twice (Coverity).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-11 19:54:12 +09:00
689f048497
msi: Use the intended attributes when overwriting the target file in cabinet_copy_file.
...
Signed-off-by: Thomas Faber <thomas.faber@reactos.org>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-29 17:08:41 +01:00
88a96478c3
msi/tests: Simplify the logic in an if condition.
...
Signed-off-by: Sergey Isakov <isakov-sl@bk.ru>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-27 20:53:22 +09:00
11669fa5e2
Assorted spelling and grammar fixes.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-17 22:56:40 +09:00
2ee784e624
msi: Make sure to reset the 'in_quotes' state in all cases.
...
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-03 21:11:05 +09:00
2d7f00c8d3
Revert "msi: Correctly parse double quotes in the token value.".
...
This reverts commit 42caac841e
2015-11-03 21:10:59 +09:00
fe8ecc23aa
msi/tests: Add missing return value test (PVS-Studio).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-28 12:45:04 +09:00
2257928a7a
msi: Use VARIANT_BOOL values consistently for VT_BOOL type (PVS-Studio).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-21 21:19:51 +09:00
40922ccd4f
msi: Avoid shift overflow in msi_view_get_row.
...
Signed-off-by: Gerald Pfeifer <gerald@pfeifer.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-21 00:25:32 +09:00
6b9a87c7a8
msi: Add a trace to msi_get_property.
...
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
2015-10-06 22:59:58 +09:00
42caac841e
msi: Correctly parse double quotes in the token value.
...
This fixes an installer that passes to InstallProduct a command line like
PROPERTY1="Installing ""Product name"" version 8.0" PROPERTY2=1 PROPERTY3=1
In this case properties PROPERTY2 and PROPERTY3 were not recognized and that
led to an installation failure when a custom action didn't see them as set.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
2015-10-06 22:59:38 +09:00
1b3087e79f
msi/tests: Add a test for MsiInstallProduct with command line containing double quotes inside of the property.
...
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
2015-10-06 22:59:32 +09:00
9a5788afc1
msi: Set the PrimaryVolumeSpaceRequired and PrimaryVolumeSpaceRemaining properties.
...
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
2015-10-01 16:23:15 +09:00
100c043e89
msi/tests: Fix a test failure on Ultimate editions.
...
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
2015-09-25 21:02:52 +02:00
6e51cfddfd
msi: Feature treeview should have WS_TABSTOP style.
2015-09-14 16:47:52 +09:00
f326e372d1
msi/tests: Fix MsiProvideQualifiedComponent test failure.
2015-09-14 16:19:27 +09:00
e8f4fea5a0
msi: Check HKLM/Software/Classes/Installer/Components path while looking for components.
2015-09-09 18:26:32 +09:00
fca92ae67c
msi/tests: Avoid test failures when running as an unprivileged user.
2015-09-07 18:52:14 +09:00
d8f79a037c
msi: Fixed varg0 leak in InstallerImpl_SummaryInformation.
2015-09-01 15:23:53 +09:00
d3ce29449b
msi: Implement Installer::SummaryInformation.
2015-08-26 23:15:26 +09:00
ddaba7a369
msi: Don't add the same environment string more than once.
2015-08-26 23:15:26 +09:00
2ad9312f02
msi: Avoid using dialog record after free.
2015-08-18 19:57:11 +09:00
99dfc15e72
msi: Only remove environment strings that were added on install.
2015-08-18 17:30:17 +09:00
7834983541
msi/tests: Mark a test result on win2k3 as broken.
2015-07-17 20:19:41 +09:00
fed41f5306
msi: Don't call CloseServiceHandle() with an invalid handle.
2015-07-16 21:20:50 +09:00
dfae842cca
msi/tests: Avoid another test failure on win2k3.
2015-07-15 23:19:32 +09:00
0bd46f1501
msi: Add a stub implementation of MsiJoinTransaction.
2015-07-15 23:19:29 +09:00
f9dc20cfcc
msi: Fix a couple of memory leaks (Coverity).
2015-07-15 23:19:25 +09:00
17405f6b91
msi: Check the return value of MSI_QueryGetRecord (Coverity).
2015-07-15 23:19:23 +09:00
e1a65bed68
msi: Be more selective about which access modes are used to open or create keys.
...
An installer was failing when trying to create subkeys after denying
delete access to their parent key.
2015-07-15 23:19:09 +09:00
4a992fec01
msi: Fix a registry key leak.
2015-07-15 23:18:54 +09:00
b71075ad9b
msi/tests: Avoid test failures on win2k3.
2015-07-10 21:44:49 +09:00
a1dbf4d78b
msi: Remove shortcut which calls RegEnumValueW with value and val_count as NULL.
2015-07-01 15:19:13 +09:00
db5f235a8b
msi/tests: Test MsiSourceListEnumMediaDisks with volumeLabel and diskPrompt as NULL.
2015-07-01 15:19:09 +09:00
597c5f9c4b
msi: Open database cabinet streams through the streams implementation.
2015-06-22 19:18:48 +09:00
806ff30f92
msi/tests: Fix test failures on win2k3.
2015-06-22 19:17:50 +09:00
d0cb2519b6
msi: Free rec in error exit (Coverity).
2015-06-12 15:24:44 +09:00
12a2b849a6
msi: Inherit state for radio buttons from the parent group dynamically.
2015-04-29 12:22:57 +09:00
4710e973f8
msi: Initialize a variable (valgrind).
2015-04-21 22:21:36 +09:00
e6ce4de393
msi: Fix an invalid memory access (valgrind).
2015-04-21 22:21:31 +09:00
55b678e186
msi: Initialize a variable (valgrind).
2015-04-21 22:21:27 +09:00
6ef2d26a53
msi: Fix a trace.
...
Reported by Marcus Meissner.
2015-04-21 22:21:24 +09:00
8969377647
msi: Perform a suffix match on the volume name.
2015-04-17 14:52:45 +09:00
20c3c09fac
msi: Improve the check for files obsoleted by patches.
2015-04-17 14:52:42 +09:00
Thomas Faber