Commit Graph

1372 Commits

Author SHA1 Message Date
Michael Jung ea62530466 Enhanced UnixFolder's IDropTarget implementation.
Use STATIC_CAST macro more consistently.
2005-11-28 20:40:50 +01:00
Michael Jung 12dd1bc12e Use GetUIObjectOf instead of BindToObject to get a IDropTarget object. 2005-11-28 17:30:11 +01:00
Ge van Geldorp 72ed6eae4c Other code in shlexec.c (e.g. the extension handling code in
ShellExecute_GetClassKey) expects sei->lpFile to not be enclosed in
quotes.
2005-11-28 17:29:58 +01:00
Michael Jung c820a3c17f Modified KeyStateToDropEffect macro to match native shellview's
behaviour.
2005-11-28 11:17:19 +01:00
Michael Jung a83d55e929 Register the shell view itself as the drop target, not it's parent folder.
Forward drag&drop method calls to the folder currently under the cursor.
2005-11-28 11:00:33 +01:00
Ge van Geldorp 0991687d3c Load shortcut icon by resource id instead of by icon index. 2005-11-28 10:59:06 +01:00
Martin Fuchs 0b17529332 Correctly call HCR_GetFolderAttributes() in SHELL32_GetItemAttributes().
Directly return the correct "My Computer" attributes in
ISF_Desktop_fnGetAttributesOf().
Remove "todo_wine" from the "My Computer" attributes test case.
Add test case for retrieving the file system path from the
CSIDL_PROGRAM_FILES PIDL using SHGetPathFromIDListW().
2005-11-28 10:38:06 +01:00
Michael Jung 2919cec009 Initial stubbed implementation of UnixFolder's IDropTarget interface. 2005-11-28 10:36:04 +01:00
Alexandre Julliard 0ec7e1a591 Renamed all .cvsignore files to .gitignore. 2005-11-26 13:10:33 +01:00
Francois Gouget 6d442aeb34 Assorted spelling fixes. 2005-11-23 20:14:43 +01:00
Michael Jung 3531178b8b Use the ANSI codepage in IShellFolder::GetDisplayNameOf. 2005-11-23 15:20:33 +01:00
Michael Jung 46018bbc59 Also scan HKEY_CURRENT_USER for shell namespace extensions in Desktop
folder.
Fixed a handle leak in case of failing AddToEnumList call.
2005-11-23 15:17:54 +01:00
Michael Jung b2647030c4 Also scan HKEY_CURRENT_USER for shell namespace extensions in
MyComputer.
2005-11-23 15:17:22 +01:00
Michael Jung ae8a912605 Initialize OLE instead of just COM, in order to enable Drag & Drop. 2005-11-23 15:15:16 +01:00
Martin Fuchs d3521da667 SHGetFileInfoW(): handle SHGFI_LINKOVERLAY and SHGFI_OVERLAYINDEX.
SHMapPIDLToSystemImageListIndex(): determine overlay flag for
PidlToSicIndex() and return -1 in error cases.
Read shell overlay icon settings from registry to allow icon
overrides.
2005-11-21 13:35:06 +00:00
Dmitry Timoshkov 84d4fc5e03 Unconditionally fall back to ANSI DDE APIs in ShellExecute if current
emulated Windows version is Win9x, Excel refuses to communicate with a
unicode client in win9x mode.
2005-11-11 10:54:07 +00:00
Francois Gouget 0edbaf7e80 Remove spaces before '\n' in traces. 2005-11-10 12:14:56 +00:00
Markus Amsler 671738d5c1 Improve c2man Documented-Total count. Changes:
- add missing description
- add missing returns section
- complete missing A/W pairs
- reformate comments, to match c2man requirements
2005-11-10 11:15:22 +00:00
Michael Jung 0acf88651d Initialize COM prior to displaying the SHBrowseForFolder dialog. 2005-11-09 10:30:28 +00:00
Saulius Krasuckas 57707fa0ea Disable code that segfaults on Win98 SE. 2005-11-09 10:30:15 +00:00
Vincent Béron 695e392875 Unicodify systray.c. 2005-11-08 19:57:27 +00:00
Vincent Béron c5789f8cfc Move functions a bit to get rid of a static declaration. 2005-11-08 16:08:17 +00:00
Mike McCormack c189912cbd Fix a problem spotted by Dmitry and another one stopping correctly
formatted lnk files from being generated.
2005-11-08 10:55:15 +00:00
Michael Jung 14d9eec51a More robust code for querying ShellFolder attributes (some
ShellFolders ignore the flag mask in GetAttributesOf).
2005-11-07 20:11:27 +00:00
Michael Jung 329f4edefc - Move target folder initialization to a dedicated function.
- Use this function in BindToObject (should be faster).
- Special handling for FolderShortcut objects in Initialize method.
- Removed a todo_wine from a no longer failing unit test.
2005-11-05 10:44:28 +00:00
Mike McCormack 991e7054cf Partially implement and test the shelllink object's
IShellLinkDataList::CopyDataBlock and GetFlags methods.
2005-11-04 11:40:58 +00:00
Mike McCormack 85b3f37d31 Use advapi32.CommandLineFromMsiDescriptor to get msi component paths. 2005-11-04 11:15:33 +00:00
Michael Jung f5acfaad22 Replaced tabs with spaces. 2005-11-03 13:17:32 +00:00
Michael Jung 92032e6e35 Added some more unit tests for FolderShortcut objects. 2005-11-03 12:04:24 +00:00
Mike McCormack 32d5240178 Invoke shortcuts through IContextMenu, rather than trying to access
them directly.
2005-11-03 11:33:57 +00:00
Alexandre Julliard 73f7847297 Authors: Vitaliy Margolen <wine-patch@kievinfo.com>, Michael Jung <mjung@iss.tu-darmstadt.de>
Set all capability flags supported by the shellfolder, disregarding
the flag mask given to GetAttributesOf.
Unit tests to demonstrate this behaviour.
2005-11-03 09:56:07 +00:00
Mike McCormack 0de1f3e629 Pass the correct verb.
Add a space between extra parameters.
Wait for ShellExecute to complete.
2005-11-03 09:55:21 +00:00
Martin Fuchs 9f9fd4080b Correct WINAPI position for MSVC portability. 2005-11-02 20:51:41 +00:00
Michael Jung b2ff467e42 Added some comments to document unixfs. 2005-11-02 11:43:20 +00:00
Michael Jung 96f7e66cd5 Fixed crash in unixfs shellfolder handling with winamp. 2005-11-01 18:06:18 +00:00
Robert Shearman 055d96b721 Convert SHELL32_BindToChild to Unicode and fix up the callers. 2005-11-01 09:34:03 +00:00
Mike McCormack 9997f84eac Add void to empty declaration list. 2005-10-31 15:43:27 +00:00
Mike McCormack 0857fc2919 Handle MSI advertised shortcuts in the shelllink object. 2005-10-28 16:40:51 +00:00
Mike McCormack f86c4e8c90 Implement IContextMenu::QueryContextMenu and
IContextMenu::InvokeCommand.
2005-10-28 09:39:50 +00:00
Michael Jung 8fca00e030 Implemented UnixFolder's IPersistPropertyBag::Load method. 2005-10-27 12:09:59 +00:00
Michael Jung d699222eae Remove iconcache pre-initialization hack, it's not necessary any
more.
2005-10-27 12:08:44 +00:00
Dmitry Timoshkov 520bec000f Correctly handle flags parameter in SHAddToRecentDocs. 2005-10-27 10:22:38 +00:00
Mike McCormack 56aa241b97 Add the IObjectWithSite interface. 2005-10-27 10:19:16 +00:00
Dmitry Timoshkov 8cd388f398 Use appropriate DDE APIs (ANSI or unicode) for ShellExecuteA/W, Excel
2000 depends on that.
2005-10-18 14:11:17 +00:00
Mike McCormack 4a28e7cdc9 Use ShellLink_QueryInterface to return the right interface in
IShellLink_Constructor.
2005-10-18 10:36:03 +00:00
Aric Stewart 5a8d76749a MSDN states that the pszDisplayName member of BROWSEINFO is assumed to
be MAX_PATH in length. So when doing the A->W conversion in
BrowseForFolderA do not set that member to be the size of the
incoming string, instead make it MAX_PATH.
2005-10-17 08:54:53 +00:00
James Hawkins 8c523fe36c Test that the FO_COPY action creates output directories if they don't
exist.
2005-10-11 19:26:47 +00:00
Lionel Ulmer c734d93383 - fix first two arguments to 'FindExecutableA' (input strings instead
of pointers)
- fix last argument to 'FindExecutableW' (it's an output string)
2005-10-11 19:26:20 +00:00
Richard Cohen e1f752f704 Don't hardcode "windows" directory.
Make "My Pictures" etc. point to $HOME.
2005-10-10 10:29:53 +00:00
Jonathan Ernst 3eaad00da9 First creation of registry entries missed AppData. 2005-10-07 15:01:32 +00:00
Francois Gouget a1f9a13997 Use "static const" rather than "const static" as gcc -W complains
about the former.
2005-10-06 11:38:45 +00:00
Juan Lang 8630b8ab6e Use wine_get_dos_file_name rather than relying on GetFullPathNameW
hack.
2005-10-04 15:50:35 +00:00
Martin Fuchs 803146d220 Simplify 'sei' structure initialization in ShellExecuteA/W. 2005-10-03 11:02:47 +00:00
Alexandre Julliard 7e22be4d84 We are no longer generating .dbg.c files. 2005-09-29 10:35:58 +00:00
Kimmo Myllyvirta c70ea04706 Update Finnish resources. 2005-09-26 09:54:02 +00:00
Alexandre Julliard 0ec0f048e6 Removed unused debug channels. 2005-09-22 10:44:40 +00:00
Alexandre Julliard 9f1c6de1ef We are no longer generating .spec.c files. 2005-09-21 14:42:52 +00:00
Alexandre Julliard 5cb97d833a Generate 16-bit spec files as assembly code too. 2005-09-21 14:23:54 +00:00
Alexander N. Sørnes 51ff901f97 Added Norwegian translation of comctl32 and shell32. 2005-09-21 11:43:31 +00:00
Milko Krachounov 980f817737 Bulgarian resources for mpr, msi, user, commdlg, oleaut32, shdocvw,
shell32, comctl32, msrle32, mshtml, winspool, wineps, serialui,
setupapi, wininet, regedit, uninstaller, notepad, winecfg and
winhelp.
2005-09-19 17:00:58 +00:00
Ge van Geldorp 348449a486 Save a few megabytes of memory by loading the default icon only once
into the image lists.
2005-09-13 11:24:52 +00:00
Ge van Geldorp 5b7da80911 Fix execution of Control Panel items. 2005-09-12 12:10:57 +00:00
Juan Lang 4a9d838ca4 Remove an annoying dialog when trying to clean up a directory. 2005-09-12 10:09:50 +00:00
Alexandre Julliard 4c34d9386c Specify 64-bit integers as double instead of long long in spec files
so that we get the correct number of arguments.
2005-09-09 15:05:01 +00:00
Alexandre Julliard 20a1a203c6 Use a more portable scheme for storing the name of a critical
section.
2005-09-09 10:19:44 +00:00
Dmitry Timoshkov 4cc1c14005 Pass a locally modified version of SHELLEXECUTEINFO to
IShellExecuteHookW_Execute, this should pass through at least
sei_tmp.nShow retrieved from an .lnk file (fStartup).
2005-09-08 18:54:52 +00:00
Dmitry Timoshkov 8feb70aa01 - Stop using a not initialized variable szTemp in
_dbg_ILSimpleGetText, make _dbg_ILSimpleGetText return no value since
  nobody is using it.
- Stop dereferencing a possible NULL in pdump since
  _dbg_ILGetDataPointer can potentially return NULL (for instance for
  root or desktop pidl).
- Make shdebugstr_guid use standard wine_dbg_sprintf instead of the
  handmade solution.
2005-09-08 18:54:03 +00:00
Michael Jung c72d13291a Removed two todo_wine's around tests that meanwhile succeed on wine. 2005-09-07 13:28:49 +00:00
Michael Jung d101921b54 Pass correct pointer to SHFree in case of failure in
UNIXFS_path_to_pidl.
Return E_FAIL if we can't get the unix path in
IPersistFolder3::InitializeEx.
Return E_NOAGGREGATION if non-NULL pUnkOuter is given to the
constructor.
2005-09-07 13:28:38 +00:00
Michael Jung 937441b3ac Don't clone pidlLast in SHBindToParent. 2005-09-07 09:22:49 +00:00
Saulius Krasuckas 28f0c36036 SHELL32.ILFindLastID is exported by ordinal. 2005-09-06 14:05:07 +00:00
Juan Lang 9cbe48f80c Fix a test failing on Windows. Reported by Katerina Nizhnik. 2005-09-03 09:37:15 +00:00
Kevin Koltzau 95a173a52b Fix warnings in 64bit. 2005-09-02 11:32:17 +00:00
Dmitry Timoshkov 5e9e487b20 Translate file name from unix to ANSI encoding in
UnixFolder_IShellFolder2_GetDisplayNameOf.
2005-09-02 11:18:00 +00:00
Michael Jung 5c87552f6a Use FIXME's in stubs instead of TRACE's.
Infer pathmode from CLSID in UnixFolderConstructor.
Fail in IShellFolder::BindToObject, if folder does not initialize.
2005-08-30 09:58:21 +00:00
Michael Jung da953161fd Clone pidlLast before free'ing pidl after call to SHBindToParent. 2005-08-29 21:46:02 +00:00
Michael Jung 3676640e64 Added test to show that Windows does not allocate a new pidl in
SHBindToParent.
2005-08-29 21:45:49 +00:00
Michael Jung 060bfac706 Use StringFromGUID2 instead of StringFromCLSID in
UNIXFS_is_rooted_at_desktop.
2005-08-29 21:45:31 +00:00
Alexandre Julliard cc4da88563 Explicitly import kernel32 in tests that use it. 2005-08-27 09:27:09 +00:00
Michael Jung b0b4777422 Implemented 'My Documents' folder. 2005-08-26 10:05:34 +00:00
Michael Jung 868921648f Added some tests for CLSID_FolderShortcut objects. 2005-08-23 09:37:59 +00:00
Mike McCormack f49f36f9eb Fix gcc 4.0 warnings. 2005-08-23 09:37:30 +00:00
Michael Jung 6235c076a4 Initialize all members in UnixFolder constructor.
Support NULL value pidls in GetDisplayNameOf method.
2005-08-22 18:56:36 +00:00
Mike McCormack eafa666bee Fix some gcc 4.0 warnings. 2005-08-22 09:26:53 +00:00
Saulius Krasuckas 94feee327b Make file operations succeed on Win9x too. 2005-08-22 09:14:35 +00:00
Michael Jung b6d97d5654 Added stubbed implementation of IPersistPropertyBag interface.
Register unixfs as CLSID_FolderShortcut.
2005-08-19 13:58:52 +00:00
Jason Edmeades 602f0c10c7 Handle context menu->refresh, and F5 to initiate a refresh of the file
dialog.
2005-08-19 10:02:51 +00:00
Jason Edmeades c1cd0d22e0 Add the time to the file display dialog modified column. 2005-08-19 10:01:25 +00:00
Michael Jung f9fd061e95 Implemented IPersist::GetClassID. 2005-08-19 10:01:07 +00:00
Alexandre Julliard 702c959c7b Added missing ntdll imports. 2005-08-18 10:59:47 +00:00
Francois Gouget 5b5e5086d7 Test "%l" and "%L". At the same time this tests alternate verbs.
Test %1, %l and %L with no quotes.
test->todo is a bitmask so fix the checks accordingly.
2005-08-18 10:47:53 +00:00
Francois Gouget 0b5cc286e3 Fix ShellExecute("\"foo.doc\"") for Internet Explorer 6.
Update the conformance tests accordingly.
Tweak a trace because it's very confusing to see the path with no
escaped quotes in ShellExecuteA() and then with escaped quotes in
ShellExecuteExW32() (due to debugstr_w()).
2005-08-17 09:53:30 +00:00
Francois Gouget 7f65f6a4e2 Dynamically load StrRetToBufW(). This lets shell32_test.exe run on
systems that have version 4.72 of shlwapi.dll.
2005-08-16 19:29:40 +00:00
Francois Gouget 1fddb3ff20 Verify the parameters received by the child process using code lifted
from kernel32/tests/process.c.
Test passing parameters to .lnk files that point to an executable.
2005-08-16 19:29:27 +00:00
Michael Jung 2fac564cc5 Remove "initguid.h" include from shellpath test. 2005-08-16 16:00:07 +00:00
Ge van Geldorp 75139a3e01 Fix resource leak on error paths. 2005-08-15 14:50:18 +00:00
Mike McCormack 61aabd66f5 Warning fixes for gcc 4.0. 2005-08-15 10:49:39 +00:00
Saulius Krasuckas 6400c8e3dd Fix some SHGetSpecialFolderPathA exceptions on WinME:
- pass pointer to valid buffer as lpszPath.
- disable check passing NULL as lpszPath.
2005-08-15 10:22:56 +00:00
Alexandre Julliard 640bf7c6e8 Authors: Michael Jung <mjung@iss.tu-darmstadt.de>, Ge van Geldorp <gvg@reactos.com>
- Prepend Desktop folder path for files/directories stored in the
  filesystem Desktop folder when GetDisplayNameOf is called with the
  SHGDN_FORPARSING flags.
- Add testcases.
2005-08-15 09:41:58 +00:00
Saulius Krasuckas 7be2cd973c XP returns E_INVALIDARG on failure. 2005-08-15 09:40:45 +00:00