Commit Graph

321 Commits

Author SHA1 Message Date
Michael Stefaniuc 758f799205 comctl32: Just use 0 instead of casting NULL twice to an integer type. 2008-10-27 11:28:12 +01:00
Michael Stefaniuc 1659313142 comctl32: DPA_GetPtr() returns a LPVOID so don't cast its return value. 2008-10-24 14:24:59 +02:00
Michael Stefaniuc b723e6f6b6 comctl32: Remove the superfluous casting of the LPVOID returned by Alloc(). 2008-10-24 14:24:59 +02:00
Jan de Mooij 403221c228 comctl32/treeview: Fix pszText NULL pointer dereference. 2008-09-18 13:26:19 +02:00
Rob Shearman 6181419b64 comctl32: Fix use of arithmetic operator on Boolean type in TREEVIEW_ComputeItemInternalMetrics.
Use a conditional operator to get the same result, but improving
readability of the code.
2008-08-18 17:34:12 +02:00
Mikołaj Zalewski 60a1e20ba8 comctl32: Don't print ERRs for reflected messages. 2008-07-22 13:25:08 +02:00
Gerald Pfeifer baa818120c comctl32: Some simplifications. 2008-07-11 15:19:15 +02:00
Colin Finck 985b6e9c01 comctl32: Use a clip region when collapsing the treeview. 2008-06-19 11:47:17 +02:00
Andrew Talbot 2db311a843 comctl32: Dangling pointers fix. 2008-04-28 14:32:17 +02:00
Andrew Talbot 369d414d59 comctl32: Remove unused variables. 2008-04-14 12:42:36 +02:00
Rob Shearman 783b5b49a2 comctl32: Remove some more useless asserts. 2008-02-16 13:52:33 +01:00
Rob Shearman 82c41bb596 comctl32: Fix the character count passed to GetWindowTextW in TREEVIEW_Command. 2008-02-16 13:52:28 +01:00
Rob Shearman affe20164e comctl32: Remove a useless assert from TREEVIEW_GetItemIndex. 2008-02-16 13:52:24 +01:00
Lei Zhang 3980401231 comctl32: Use wine_dbgstr_rect() in traces. 2008-02-07 11:59:53 +01:00
Austin English c2a7914d1c comctl32: Spelling fixes. 2008-01-24 11:43:02 +01:00
Francois Gouget 44b52b128c Assorted spelling fixes. 2008-01-16 12:48:29 +01:00
Andrew Talbot 863ffb719b comctl32: Remove unneeded casts. 2008-01-02 12:38:41 +01:00
Gregor Brunmar f18b428ccf comctl32: Added context menu to treeview. 2007-12-07 19:01:45 +01:00
Andrew Talbot 1bf787d521 comctl32: Remove unneeded casts. 2007-12-03 13:10:21 +01:00
Andrew Talbot 4ccd78c2a1 comctl32: Fix a memory leak. 2007-09-14 14:42:59 +02:00
Aric Stewart 78da158ef8 comctl32: treeview: Ensure our textWidth is correct when returning the size of the text box. 2007-09-11 11:47:42 +02:00
Aric Stewart 4939aa2497 comctl32: Ensure item metric are calculated when an item becomes visible. 2007-09-11 11:47:30 +02:00
Dmitry Timoshkov 3c9e7a7f33 wine: Switch to using 'long' for INT_PTR type for 64-bit compatibility. 2007-05-25 20:37:56 +02:00
Mikołaj Zalewski 81cf09c6da comctl32: treeview: Treeviews shouldn't be sending NM_TOOLTIPSCREATED (with testcase). 2007-05-07 14:26:22 +02:00
Felix Nawothnig fe5881c788 comctl32: Allow enabling TVS_CHECKBOXES on the fly. 2007-04-07 11:01:22 +02:00
Andrew Talbot 3c9f867f77 comctl32: Constify some variables. 2007-04-03 11:22:06 +02:00
Piotr Caban 2b1f1093f0 comctl32: Set label width after editting. 2007-03-27 12:34:23 +02:00
Piotr Caban 47aaf09dc3 comctl32: Fixed TreeView_EndEditLabelNow crash. 2007-03-26 12:34:27 +02:00
Felix Nawothnig 6a514819db comctl32: Fix visual glitches with TVS_HASLINES. 2007-03-13 21:55:01 +01:00
Felix Nawothnig 5cdcfbfaa0 comctl32: Fix a typo. 2007-03-12 12:03:32 +01:00
Felix Nawothnig 8784d47cba comctl32: Remove redundant NULL checks before Free() calls. 2007-02-14 12:22:39 +01:00
Duane Clark 5bc1a8de87 treeview: Scrolling does not cause label being edited to lose focus. 2007-02-12 12:39:34 +01:00
Duane Clark 7942f5a0e4 treeview: Fix horizontal scrolling. 2007-01-12 11:53:06 +01:00
Felix Nawothnig 2eb171c1f5 treeview: Initialize iImage and iSelectedImage with zero. 2007-01-09 12:04:40 +01:00
Alexandre Julliard 656fc93815 Use GetDC instead of CreateDC where possible. 2007-01-02 17:16:36 +01:00
Alexandre Julliard 7cca856315 comctl32: Properly handle negative coordinates for mouse events. 2006-10-25 17:41:48 +02:00
Michael Ploujnikov 1c16d83379 comctl32: Win64 printf format warning fixes. 2006-10-14 20:17:06 +02:00
James Hawkins 3d2b37cc83 comctl32: Set the TVIF_TEXT mask when notifying the parent window of a selection change. 2006-10-04 09:59:27 +02:00
Jonathan Ernst 360a3f9142 Update the address of the Free Software Foundation. 2006-05-23 14:11:13 +02:00
qingdoa daoo 53654c6938 comctl32: Update first visible when appropiate in the TVI_SORT case. 2006-05-07 10:00:40 +02:00
Alexandre Julliard 6b76244bf4 Fixed creation of PS_ALTERNATE pens. 2006-01-30 15:02:53 +01:00
Eric Pouech 1d2f975ba9 comctl32: Fixed (harmless) typo. 2005-12-12 11:54:35 +01:00
Francois Gouget 0edbaf7e80 Remove spaces before '\n' in traces. 2005-11-10 12:14:56 +00:00
Alex Villacís Lasso 4082e9a69c Do not issue a GetUpdateRect() to query an update region for
WM_PAINT(wParam=HDC) case. Instead, use GetClientRect() for a bounding
rect.
2005-11-08 13:11:48 +00:00
Michael Kaufmann e9310da57b Handle WM_PRINTCLIENT.
Don't use SelectClipRgn in WM_PRINTCLIENT.
2005-11-08 12:52:35 +00:00
Marcus Meissner bd7ec9aca5 The last argument to MultiByteToWideChar is wide character count and
not the buffer size in bytes. Fixed all places where it was wrong.
2005-09-12 22:07:53 +00:00
Frank Richter 9e57091ffa Fix warnings in 64bit. 2005-08-30 10:07:17 +00:00
Frank Richter 171fea006d Add theming for treeview control. 2005-07-28 10:15:10 +00:00
Krzysztof Foltman 112df73530 Don't send TVN_SELCHANGING nor TVN_SELCHANGED if the same item is
selected again.
2005-06-13 11:38:55 +00:00
Vitaliy Margolen 71be094420 Don't redraw if no information has changed.
Fixed endless redraw loop if app using callback for images and/or
text.
Keep color changes made by app for the current draw cycle.
2005-04-18 10:20:51 +00:00
Vitaliy Margolen 3b3574a468 Send notifies after invalidating changed areas.
Don't use custom draw returned colors for control.
2005-04-14 13:56:12 +00:00
Jason Edmeades 06c7c90a69 Make the treeview correctly search when the top index is selected. 2005-03-23 11:58:58 +00:00
Dimitrie O. Paun a46b7fb404 Complete unicodification of the treeview common control. 2005-03-23 10:24:42 +00:00
Robert Shearman 6a365e0074 iSelectedImage is allowed to be 0. 2005-03-21 10:51:14 +00:00
Evan Deaubl 20c93c2c0d TREEVIEW_DoSelectItem should not do any of the TVGN_FIRSTVISIBLE work
if the newSelect parameter is NULL.
2005-03-14 10:51:06 +00:00
Martijn Vernooij 2c2db4b486 Scroll instead of repainting when expanding/collapsing trees.
Don't repaint on hover if 'hot tracking' isn't on.
2005-02-22 19:31:01 +00:00
Jon Griffiths ae720e6d7c Increase the required rectangle size before drawing big +/-. 2005-01-14 15:13:24 +00:00
Robert Shearman 040850e8c5 Don't highlight text in non-TVS_TRACKSELECT mode. 2005-01-11 10:39:33 +00:00
Eric Pouech cf1d00bb08 Removed excessive statement (break after return or goto, not useful
break, not needed vars...)
2005-01-09 16:42:53 +00:00
Crestez Leonard 30cde9b1a8 Fix bug with Treeview_SelectItem reselecting the same item. 2005-01-07 15:34:25 +00:00
Francois Gouget 9d589acc26 Assorted spelling fixes. 2005-01-04 20:39:54 +00:00
Robert Shearman 1e92f4a3c7 - Add code for hot tracking.
- Draw hot items with underline and with highlight colour with
  TVS_TRACKSELECT style.
- Set cursor to hand cursor with TVS_TRACKSELECT style.
- Make sure uInternalStatus is consistent with actual scrollbar state
  by forcing scrollbars off in WM_CREATE handler.
2004-12-17 18:52:04 +00:00
Huw Davies 3138b4a8fa The default font for the treeview should be the icon title font. 2004-11-21 15:41:08 +00:00
Robert Shearman 8d28e0314c Remove unnecessary WNDPROC casts. 2004-11-06 03:49:03 +00:00
Jon Griffiths 0fa33cad49 Draw +/- correctly for large icon sizes. 2004-10-07 17:34:31 +00:00
Francois Gouget 67aa858a31 Assorted spelling fixes. 2004-10-05 18:15:29 +00:00
Robert Shearman 847c81df89 Determine whether to do label edit before sending NM_CLICK. 2004-09-28 19:17:17 +00:00
Jon Griffiths f479f10660 Item height/expand button width must be >= than imagelist size.
Avoid a magic number, add FIXME for incorrect +/- drawing.
2004-09-28 02:35:48 +00:00
Filip Navara 317d6c592a Fix obviously wrong condition in an "if" statement. 2004-09-23 22:51:29 +00:00
Jon Griffiths 3772c73a6c CreateDCA -> CreateDCW 2004-09-13 23:22:30 +00:00
Vitaliy Margolen ba5d267b70 Make sure TreeView gets redrawn after calling EnsureVisible. 2004-09-13 19:17:35 +00:00
Robert Shearman cdb263e588 Replace GetWindowLong by GetWindowLongPtr. 2004-08-25 17:33:01 +00:00
Huw Davies 7e1d83ee70 Implemented TVS_NOSCROLL. 2004-05-02 04:20:06 +00:00
Francois Gouget 52c0832161 Make Unicode strings static const. 2004-04-20 01:12:17 +00:00
Martin Fuchs 5307b3f598 Return TRUE for TVM_EXPAND if treeview item is already expanded. 2004-04-14 04:27:59 +00:00
Steve Lustbader a752885c3d Handle the firstVisible item being NULL in
TREEVIEW_UpdateScrollBars().
2004-03-01 23:10:52 +00:00
Mike Hearn d04f253aa9 Grow the treeview control expander button by 1px in each direction to
match the native look.
2004-02-16 22:19:29 +00:00
Huw Davies d9558dbd19 Fix a TRACE. 2004-02-12 20:06:04 +00:00
Huw Davies 84e7547ef1 Move the selection to the previous sibling if it can't go to the next
or the parent.
Fix the selection change logic.
2004-01-21 22:16:02 +00:00
Alexandre Julliard 502f6c5634 Removed incorrect uses of DUMMYUNIONNAME. 2004-01-07 00:47:35 +00:00
Huw Davies 6cfbf89529 Merge {Set,Insert}Item[AW] to {Set,Insert}ItemT. 2003-11-27 01:11:01 +00:00
Ulrich Czekalla 1afef2c732 In TREEVIEW_EnsureVisible handle case where firstVisible is NULL. 2003-11-27 00:55:18 +00:00
Huw Davies 96b9057097 Merge GetItem[AW] into GetItemT. 2003-11-26 22:26:19 +00:00
Aric Stewart d78dfc8e44 Redraw if bold state changes. 2003-11-26 22:07:17 +00:00
Ulrich Czekalla 12f7a36132 Always recompute an item's text width in the case of text callbacks
and when its attributes change.
2003-11-26 22:03:58 +00:00
Huw Davies 5693ecd212 Unicodification. Based on a patch by Aric Stewart. 2003-11-26 03:37:30 +00:00
Huw Davies 4a8e33954e We need to send TVN_EXPAND* on collapsing either when the user has
initiated it with the mouse/keybaord or in response to a TVM_EXPAND
when the state is not TVIS_EXPANDEDONCE.  This brings the logic into
line with TREEVIEW_Expand.
2003-11-21 21:30:20 +00:00
Dimitrie O. Paun c594043316 Make the controls send notifications to the parent window passed to
them in CREATESTRUCT.  Based on a treeview patch by Igor Grahek.
2003-11-20 22:04:13 +00:00
Dimitrie O. Paun 6443ee58bc Cleanup the edit wndproc a bit. 2003-11-20 04:19:59 +00:00
Dmitry Timoshkov d6872aff18 Avoid setting infoPtr->firstVisible to NULL in TREEVIEW_Sort. 2003-11-13 20:49:00 +00:00
Adam Gundy c2d90611f6 Only send TVN_ITEMEXPANDING for items marked as having children. 2003-10-15 21:01:54 +00:00
Dimitrie O. Paun 7de279a73a Rename COMCTL32_{Alloc,ReAlloc,Free} to {Alloc,ReAlloc,Free}. 2003-09-22 21:32:33 +00:00
Alexandre Julliard f5cb3dde17 Moved undocumented functions out of the exported commctrl.h. 2003-09-17 20:15:21 +00:00
Alexandre Julliard 9d61596624 SLOWORD and SHIWORD do not exist on Win32 (reported by Filip Navara). 2003-09-17 04:28:28 +00:00
Alexandre Julliard cf52644a1c Removed the A/W constants for builtin cursors, icons and resource
types since they don't exist on Windows, and added typecasts
everywhere instead.
2003-09-10 03:56:47 +00:00
Alexandre Julliard e37c6e18d0 Fixed header dependencies to be fully compatible with the Windows
headers (with help from Dimitrie O. Paun).
2003-09-05 23:08:26 +00:00
Maxime Bellengé cb1c112dd6 Fix the creation of treeview with checkboxes. 2003-08-23 23:18:48 +00:00
Maxime Bellengé 3db30e376c Fix unreachable TVHT_ONITEMSTATEICON in TREEVIEW_LButtonDown. 2003-08-19 00:57:08 +00:00
Maxime Bellengé fb39442d7f Fix things broken by the last TREEVIEW_UpdateDispInfo patch. 2003-08-18 19:46:31 +00:00
Maxime Bellengé 305fda2ef8 Fix for TREEVIEW_UpdateDispInfo to test with the correct callbackMask. 2003-08-13 19:37:12 +00:00
Martin Fuchs bb40b30640 Send TVN_ITEMEXPANDING when the user tries to expand a tree item
_before_ checking for child items.
2003-07-21 22:04:42 +00:00
Adam Gundy a982259e3e When items are inserted in a partially populated treeview, the first
visible item was not correctly updated.
The first visible item was sometimes used to calculate the location of
other items when it had been freed.
2003-05-02 20:15:36 +00:00
Mike Hearn d0300d92e3 TreeView should not send two click notifications when bTrack is true. 2003-03-27 00:00:42 +00:00
Mike Hearn b27587dd0a TREEVIEW_GetItemA should ignore stateMask. 2003-03-26 23:35:50 +00:00
Mike Hearn 044a353161 Correct the check for changed treeview items, so item sets repaint
properly.
2003-03-26 01:22:10 +00:00
Adam Gundy 292d8429ab TREEVIEW_UpdateScrollBars() now copes with an empty tree. 2003-03-06 22:41:59 +00:00
Tim Segall efa2b0c159 Accept either TVI_ROOT or NULL for the parent to imply sort the entire
tree.
2003-02-25 03:59:12 +00:00
Dan Kegel 0fd521fee3 Change RECT to use LONG to match win32 standard headers and fix format
strings to use %ld for RECT elements.
2003-01-08 21:09:25 +00:00
Dimitrie O. Paun 297f3d898d Define NONAMELESS{STRUCT,UNION} explicitly in the files that need them. 2003-01-07 20:36:20 +00:00
Rolf Kalbermatter 6c79930413 Add config.h/port.h to allow compilation/linking in MSVC.
Fix some unsigned/signed warnings.
2002-12-16 22:43:58 +00:00
Francois Gouget d2667a4ce3 Removed unnecessary HANDLE typecasts. 2002-12-02 18:10:57 +00:00
Dimitrie O. Paun d2e881d543 - Typesafe parameters from TREEVIEW_NotifyFormat.
- Rewrite TREEVIEW_NotifyFormat.
- Fix several invocations of TREEVIEW_SendTreeviewNotify.
2002-11-27 20:15:49 +00:00
Dimitrie O. Paun 4bbd7b3e26 Fix some treeview notification codes between ANSI/Unicode mode. 2002-10-31 00:54:53 +00:00
Dimitrie O. Paun 02af550a2a Send the right notification code (A/W) depending on the Unicode
setting.
2002-10-29 21:25:35 +00:00
Andreas Mohr 6e256c72fe - fix some pselling
- enhance some TRACEs
2002-10-25 19:09:02 +00:00
Michael Stefaniuc 353529b2c8 - fix the "int format, HANDLE arg" type of warnings for comctl32
- compile the comctl32 dll with -DSTRICT
2002-10-23 22:19:10 +00:00
Michael Stefaniuc f3d1893f80 Add needed casts for a "no warnings" compile of comctl32. 2002-10-23 20:19:22 +00:00
Michael Stefaniuc 025c0b716b Prepare dlls/{comctl32,gdi,msvideo,setupapi,shell32,twain,winmm} for
the conversion of HWND to a void*.
2002-09-06 19:41:17 +00:00
Guy L. Albertelli 23739a339a Don't issue error message if message number in application range. 2002-07-16 01:23:59 +00:00
Vincent Béron 9a62491660 Removed trailing whitespace. 2002-05-31 23:06:46 +00:00
Guy L. Albertelli b4994d18e9 - Preliminary implementation of TVS_NOSCROLL and TVS_NOHSCROLL
- Implement A and W versions of WM_NOTIFY based on response to
  WM_NOTIFYFORMAT. Note that the EDITLABEL notifies are not done.
- Implement WM_NOTIFYFORMAT.
2002-03-20 01:29:04 +00:00
Alexandre Julliard 0799c1a780 Added LGPL standard comment, and copyright notices where necessary.
Global replacement of debugtools.h by wine/debug.h.
2002-03-09 23:29:33 +00:00
Andreas Mohr 8bc7f16caa Spelling/alignment fixes. 2002-02-27 01:34:08 +00:00
Aric Stewart 9d366f1f40 Added implementation of SetItemW. 2002-02-04 18:37:32 +00:00
Aric Stewart 5a64f285f2 Fix to GetItemW to stop whiping out the items text. 2002-02-01 19:54:10 +00:00
Bill Medland 32ca21caaa A treeview item may be TVI_ROOT. 2001-12-11 00:15:11 +00:00
Gerard Patel ede9881523 Do not keep the handle of a deleted item as the selectedItem.. 2001-08-20 18:00:54 +00:00
Guy L. Albertelli be73d10dc5 Add support to respond to the PGN_CALCSIZE version of the WM_NOTIFY
message.
2001-08-13 20:08:21 +00:00
Francois Gouget e76218dd61 Add '\n' at the end of traces. 2001-05-09 17:31:31 +00:00
Gerard Patel f6d3d0172d After an item text changes, the rectangle width should be
recalculated.
2001-04-09 18:28:47 +00:00
Gerard Patel 9c2d2bad90 Erase the in-memory DC for treeview and fixes the rectangle calculation. 2001-04-04 00:09:23 +00:00
Aric Stewart 79a11a1f21 Insert the item before calling a SetFirstVisible which can generate a
WM_PAINT message.
2001-02-20 23:43:21 +00:00
François Gouget 2ad985527f Handle WM_CHARs and pass them to TREEVIEW_ProcessLetterKeys. See also
LISTVIEW_ProcessLetterKeys in listview.c.
2001-02-12 18:08:08 +00:00
Alexandre Julliard 24a62ab9b0 Got rid of the Wine internal lstrcpy* functions and of winestring.h. 2000-11-28 22:40:56 +00:00
Aric Stewart cf94bf88c2 Treeview item sorting could mess up the visibleOrder of the items. 2000-11-02 20:09:43 +00:00
Alexandre Julliard 908464d448 Authors: Andreas Mohr <amohr@codeweavers.com>, Dimitrie O. Paun <dimi@cs.toronto.edu>, Patrik Stridvall <ps@leissner.se>
Various warning fixes.
2000-11-01 03:11:12 +00:00
Francois Gouget 7203ee6623 Use PS_ALTERNATE rather than PS_DOT.
Use Rectangle to draw focus rectangles.
2000-10-31 02:05:11 +00:00
Susan Farley 4dc7f4ca06 Under some conditions its necessary to explicitly show the
scrollbars.
2000-10-31 01:02:05 +00:00
Susan Farley 8d8c87b85a - When inserting an item, do not invalidate the area above the new
item.
- The debug function that verifies the tree after each insertion
  should be disabled by default.
2000-10-25 20:30:58 +00:00
Uwe Bonnes 4bfc2a8a2d Remember owner HWND when creating and use this hwnd for the WM_NOTIFY
message target.
2000-10-17 00:29:18 +00:00
Louis Philippe Gagnon d41e22bf0d Do not send a WM_CONTEXTMENU message when a TreeView receives a
WM_RBUTTONUP.
2000-10-13 23:07:08 +00:00
Susan Farley 036ae0b6b3 To improve custom-drawn items, add focus border to itemRects and do
not overlap them.
2000-10-13 20:13:38 +00:00
Susan Farley 3bd7f58706 On InsertItem with TVI_FIRST, the check for resetting firstVisible
must be done *before* the parent's firstChild changes.
2000-10-12 23:11:06 +00:00
Alexandre Julliard 83f52d11c1 Moved all Win16 definitions out of the standard Windows headers. 2000-09-26 22:20:14 +00:00
Alexandre Julliard 072dfb57e3 Removed inclusion of wine/winestring.h from winbase.h and added it to
the C files that need it.
2000-09-25 23:30:56 +00:00
Chris Morgan 36c8db8c7d Fix behavior of TVS_SINGLEEXPAND style broken in Corel merge. Optimize
redrawing in TREEVIEW_SetItemA() to redraw only if the item changes.
2000-09-22 20:48:15 +00:00
Chris Morgan 5f9fd77db3 Merged main Wine changes into Corel's treeview control rewritten by
Serge Ivanov and Andrew Lewycky.  Fixed item focus behavior to match
Windows.  Fixed item selection when un/expanding items.  Implemented
WM_SETREDRAW.  Added Corel's COMCTL32_CreateToolTip() helper function
to commctrl.c.
2000-09-13 20:27:30 +00:00
Andreas Mohr 217a682b4f Minor cosmetic changes. 2000-08-25 21:56:19 +00:00
Chris Morgan 33b668095b Removed direct calls to TREEVIEW_Refresh(). 2000-08-20 03:40:21 +00:00
Alexandre Julliard c7e7df8b17 Replaced all lstr* calls from inside Wine code by their str* equivalent. 2000-08-14 14:41:19 +00:00