Commit Graph

1976 Commits

Author SHA1 Message Date
Carlo Bramini 47ff95429a wininet: Use return value of sprintf() instead of calling strlen() and simplify code.
Signed-off-by: Carlo Bramini <carlo_bramini@users.sourceforge.net>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-14 11:07:09 -06:00
Gerald Pfeifer 3cb027c743 wininet: Increase buffer in _test_status_code to avoid potential potential overflow.
Signed-off-by: Gerald Pfeifer <gerald@pfeifer.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-03 11:51:37 +02:00
Andrew Eikum 7e841432ed wininet: Don't crash by debug printing too long URLs.
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-09-28 11:26:53 +09:00
Jacek Caban 7d9a439274 wininet: Don't return available data sizes larger than the read buffer.
Based on patch by Hans Leidekker.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-15 12:55:02 +09:00
Bernhard Übelacker 0fcecad8d8 wininet/tests: Fix pathLen given to InternetCrackUrlA.
Signed-off-by: Bernhard Übelacker <bernhardu@mailbox.org>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-04 10:53:03 -05:00
Jacek Caban 16d300cacd wininet: Return data available in current chunk in chunked_get_avail_data.
Based on a patch by Hans Leidekker.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-02 09:08:57 -05:00
Jacek Caban e7d6bba22e wininet: Added chunked stream blocking tests.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-01 09:58:10 -05:00
Jacek Caban 6e0c842dfa wininet: Rewrite chunked stream to store full stream state and allow non-blocking reads crossing chunk boundries.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-01 09:58:06 -05:00
Sebastian Lackner 93832ef88d wininet/tests: Add a test for recently introduced regression related to InternetCrackUrl.
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-08 23:07:20 +09:00
Sebastian Lackner 259b517f2b wininet/tests: Avoid unnecessary initialization of variables.
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-08 23:07:20 +09:00
Michael Müller cacad1df98 wininet: Correctly set lpszUrlPath in InternetCrackUrlW for urls without path component.
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-08 23:07:20 +09:00
Michael Müller 9e4df5ef79 wininet/tests: Fix some typos in ok() messages.
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-07 19:58:02 +09:00
Sebastian Lackner 1eb2c5520c wininet: Use list_head get first entry of list.
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-07 19:57:57 +09:00
Jacek Caban 27ea3804dd wininet: Added semi-stub INTERNET_OPTION_END_BROWSER_SESSION implementation.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-06 23:10:28 +09:00
Jacek Caban b53b717dad wininet: Always set returned size in InternetGetCookieExA.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-06 23:10:24 +09:00
Jacek Caban 8332d80665 wininet: Free all cookie data in free_cookie.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-06 23:10:22 +09:00
Jacek Caban a9a6948b79 wininet: Include stdlib.h before winsock2.h in http.c.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-03 10:54:18 +09:00
Jacek Caban 86d14ad17e wininet: Use INTERNET_SendCallback in ftp.c.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-21 11:23:50 +09:00
Jacek Caban 0d9dcf5c8f wininet: Ignore unknown attributes in get_cookie.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-21 11:23:48 +09:00
Jacek Caban 3a7bd03da0 wininet: Fixed tests on win10.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-21 11:23:46 +09:00
Thomas Faber 877a628aa6 wininet: Avoid buffer overrun in alloc_object.
Signed-off-by: Thomas Faber <thomas.faber@reactos.org>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-03 12:29:36 +09:00
Jacek Caban fff5dca787 wininet: Correctly handle the last proxy override in HTTP_ShouldBypassProxy.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-01 01:04:45 +09:00
Jacek Caban 5eca697aba wininet: Skip more problematic tests on IE6.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-30 11:10:19 +09:00
Jacek Caban 0fdba71bed wininet: Added missing LeaveCriticalSection to set_cookie (coverity).
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-30 11:10:15 +09:00
Jacek Caban 9a85a84765 wininet: Fixed leak in HTTP_DealWithProxy (coverity).
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-30 11:10:12 +09:00
Sebastian Lackner ff1fb7f51c wininet: Initialize user_len before GetUserNameW call.
Fixes a regression introduced by 441347f084.

Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Jacek Caban<jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-21 00:53:52 +09:00
Jacek Caban b72c2e85b4 wininet: Return NULL instead of FALSE in get_proxy_autoconfig_url.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-21 00:53:51 +09:00
Jacek Caban 441347f084 wininet: Store cookie URL in cookie_container_t.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-19 11:57:59 +09:00
Jacek Caban e73f5782ff wininet: Moved more redirect URL handling to a helper function and get rid of its maximum size assumption.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-19 11:57:57 +09:00
Jacek Caban 5141c911ff wininet: Don't assume maximal URL length in HTTP_GetRedirectURL.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-19 11:57:55 +09:00
Jacek Caban 216474c24e wininet: Use compose_request_url in INTERNET_OPTION_URL implementation.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-19 11:57:52 +09:00
Jacek Caban 453e0e1112 wininet: Don't use host header in compose_request_url.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-19 11:57:45 +09:00
Jacek Caban 7528f4d533 wininet: Use scheme id instead of string in HTTP_HandleRedirect.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-19 11:57:41 +09:00
Jacek Caban 228c06086a wininet: Get rid of INTERNET_INVALID_PORT_NUMBER fixups after InternetCrackUrl calls.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-18 10:34:10 +09:00
Jacek Caban dfa014a572 wininet: Don't assume maximum URL length in HTTP_DealWithProxy.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-18 10:34:08 +09:00
Jacek Caban 3413d01764 wininet: Pass host name as substring to get_server.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-18 10:34:06 +09:00
Jacek Caban bd1f39ea27 wininet: Don't assume maximal URL length in HTTP_ShouldBypassProxy.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-18 10:34:04 +09:00
Jacek Caban 1d5670c7c4 wininet: Removed maximum URL length assumption from get_proxy_autoconfig_url.
Also use correct encoding.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-18 10:34:01 +09:00
Jacek Caban 7d541b3fd3 wininet: Include config.h in internet.c for Mac configure macros.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-18 10:33:59 +09:00
Jacek Caban e0e0b6b7c6 wininet: Initialize url_w in InternetCrackUrlA.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-18 10:33:57 +09:00
Jacek Caban 41e45509b6 wininet: Don't assume maximal URL length in INTERNET_InternetOpenUrlW.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-18 10:33:55 +09:00
Jacek Caban 9e497aeca2 wininet: Added test of request with a long URL.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-18 10:33:53 +09:00
Jacek Caban 4227dfaa94 wininet: Store request URL in req_file_t.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-18 10:33:50 +09:00
Jacek Caban ce4bdcd0c1 wininet: Rewrite test_accept_encoding using more generic request.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-18 10:33:47 +09:00
Jacek Caban 238a462d2b wininet: Added test of cookies with long URL.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-17 11:51:33 +09:00
Jacek Caban 8264e2de94 wininet: Rerite COOKIE_crackUrlSimple to use substrings.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-17 11:51:29 +09:00
Jacek Caban 18a31e49bc wininet: Pass arguments as substrings to set_cookie.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-17 11:51:24 +09:00
Jacek Caban 8fe7be58ea wininet: Added IsDomainLegalCookieDomainW helper with substrings as arguments.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-17 11:51:19 +09:00
Jacek Caban 4f39a2dbb3 wininet: Pass arguments as substrings to get_cookie.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-17 11:51:15 +09:00
Jacek Caban b6f64a468d wininet: Pass arguments as substrings to load_persistent_cookie.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-17 11:51:11 +09:00