Commit Graph

36 Commits

Author SHA1 Message Date
Alex Henrie 68c3ac7680 shell32: Fix sizeof argument in DoPaste (Coverity).
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-04-07 22:44:39 +02:00
Eric Pouech 570e24a014 shell32: Enable compilation with long types.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-02-18 09:32:11 +01:00
Zebediah Figura 3113c5412f shell32: Remove redundant definitions of undocumented shell functions.
Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-02-04 09:48:55 +01:00
Alexandre Julliard b215536852 shell32: Use wide char string literals.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-09-20 22:45:48 +02:00
Alexandre Julliard 48d62fc623 shell32: Build with msvcrt.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-09-17 20:24:05 +02:00
Alex Henrie adb4259aa9 shell32: Fix use of uninitialized variable in paste_pidls (Clang).
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-08-05 23:11:23 +02:00
Damjan Jovanovic 9bc7d41080 shell32: Use the paste_pidls() helper function for the CFSTR_SHELLIDLISTW format too.
Signed-off-by: Damjan Jovanovic <damjan.jov@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-05-26 21:32:24 +02:00
Damjan Jovanovic 91b0340170 shell32: Support the CF_HDROP format too when pasting from the context menu.
Signed-off-by: Damjan Jovanovic <damjan.jov@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-05-26 21:31:37 +02:00
Damjan Jovanovic 401de24b89 shell32: Fix a lock leak.
Signed-off-by: Damjan Jovanovic <damjan.jov@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-05-26 21:31:22 +02:00
Damjan Jovanovic 19379007e5 shell32: Fix pasting from the shellview context menu.
Pasting from the shellview context menu is completely broken,
as the desktop folder's BindToObject() always fails since the CIDA
parent folder PIDL is an empty PIDL. The desktop shell folder
doesn't support the ISFHelper interface either. Rather bind to
each item's immediate parent, and copy each item individually.
Also try get error handling to work a little better.

Signed-off-by: Damjan Jovanovic <damjan.jov@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-05-03 20:42:29 +02:00
Damjan Jovanovic 566454b9dc shell32: Implement some of the missing shellview IContextMenu command verbs.
Signed-off-by: Damjan Jovanovic <damjan.jov@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-05-03 20:42:29 +02:00
Damjan Jovanovic 2b6458b757 shell32: Use a smaller range of shellview menu IDs in our IContextMenu functions.
The shellview menu IDs are very large, eg. FCIDM_SHVIEW_OPEN is 0x7102,
while applications want menu IDs to fit into a small range, eg. 1-1000 for
Explorer++. This causes our IContextMenu_QueryContextMenu() functions to
leave out most menu options. We should rebase our shellview menu ids
by -0x7000 so they occupy a smaller range.

This gets both Explorer++ and Double Commander to show the correct
right-click menus.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=24893
Signed-off-by: Damjan Jovanovic <damjan.jov@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-30 22:59:50 +02:00
Damjan Jovanovic 91a8b4819e shell32: The menu wIDs in hmenu were rebased by idCmdFirst.
Signed-off-by: Damjan Jovanovic <damjan.jov@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-30 22:59:50 +02:00
Francois Gouget e523fab898 shell32: Fix a typo in a comment.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-01 19:43:04 +02:00
Michael Müller 1f08db5654 shell32: Add general tab in file property dialog.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-08 11:08:51 +02:00
Nikolay Sivov e3b200bd8a shell32: Use global memory allocation helpers.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-22 14:16:33 +01:00
Nikolay Sivov 308a5ff7c8 shell32: Add IObjectWithSite stub for context menus.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-19 13:43:52 +01:00
Nikolay Sivov 408f856f02 shell32: Added IShellExtInit stub for context menus.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-19 13:43:52 +01:00
Nikolay Sivov ce5fb75f7f shell32: Reduce code duplication in GetCommandString().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-22 10:16:40 +01:00
Nikolay Sivov 8499ace1ff shell32: Use IS_INTRESOURCE() to test context menu verb kind.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-09 09:18:42 +02:00
Francois Gouget 351d907bbd shell32: Remove unneeded NONAMELESSXXX directives. 2015-03-20 17:50:06 +09:00
Thomas Faber b1b92046c2 shell32: Avoid a variable-length array. 2014-03-25 13:55:46 +01:00
Frédéric Delanoy 0666ac3ed8 shell32: Use BOOL type where appropriate. 2013-10-22 16:37:40 +02:00
Nikolay Sivov 725b069e68 shell32: Fix remaining cases of implementation pointer being returned. 2013-09-04 11:36:42 +02:00
Daniel Jelinski b49c9ac923 shell32: Simplify cut/copy operations. 2013-08-20 12:02:29 +02:00
Daniel Jelinski e6acc695c6 shell32: Return command strings for a few more commands. 2013-08-15 18:04:40 +02:00
Daniel Jelinski 6509499fc9 shell32: Context menu offset is handled by client. 2013-08-15 18:04:24 +02:00
Daniel Jelinski c687b4adf4 shell32: Fix context menu creation. 2013-08-15 18:04:02 +02:00
Andrew Talbot 1a190a9da3 shell32: Avoid signed-unsigned integer comparisons. 2013-02-26 11:26:53 +01:00
Nikolay Sivov 72a7c34109 shell32: Avoid casts when creating item menu. 2012-01-11 17:47:30 +01:00
Nikolay Sivov 3efda60ef6 shell32: Avoid pointer casts when background menu is created. 2012-01-11 17:47:30 +01:00
Nikolay Sivov 9fe57a8acf shell32: Update to IContextMenu3. 2012-01-11 17:47:29 +01:00
Nikolay Sivov 82c72f2fae shell32: Use shared IUnknown implementation for both vtables. 2012-01-11 17:47:28 +01:00
Nikolay Sivov bfc39c83b5 shell32: Get rid of menu enabling helper. 2012-01-11 17:47:28 +01:00
Nikolay Sivov dff08c9771 shell32: Merge menu implementations together. 2012-01-11 17:47:27 +01:00
Nikolay Sivov e9fa059976 shell32: Merge ShellView menu implementations into a single file. 2012-01-10 18:29:04 +01:00