Commit Graph

844 Commits

Author SHA1 Message Date
Nikolay Sivov 6b2675dc8f comctl32/listview: Always return zero state mask for subitems.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-22 10:16:45 +01:00
Andrey Gusev 2000386baf comctl32: Fix a typo in comment.
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-08 13:58:11 +01:00
Nikolay Sivov 9f019b7c76 comctl32/listview: Directly reset focused item on item count change.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-11 18:21:15 +01:00
Huw Davies da419d80b7 comctl32: Simplify handling of the marquee highlight.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-14 16:14:16 +01:00
Nikolay Sivov ee7ddd1ed3 comctl32/listview: Pass WM_NCCREATE down to default procedure.
Problem analyzed by Vadim Druzhin <cdslow@mail.ru>.

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-10 20:04:14 +02:00
Hugh McMaster 1d45250a58 comctl32/listview: Invalidate the focus rectangle when the control gets or loses focus.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-08 20:13:56 +09:00
Zebediah Figura 11c557b66c comctl32: Don't FIXME on handled cases.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-26 12:27:45 +02:00
Nikolay Sivov 65d64e15c8 comctl32/listview: Simplify a couple of conditions that are using LVFI_PARTIAL.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-22 13:45:09 +02:00
Nikolay Sivov 407a3c06fa comctl32/listview: Search through all items in LVFI_NEARESTXY mode.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-22 13:45:09 +02:00
Alex Henrie 5fe449307f comctl32/listview: When adding a scrollbar, update the other one.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-18 13:37:57 +02:00
Nikolay Sivov 8ef79b023a comctl32/listview: Convert item text once when looking for insertion point.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-09 16:37:43 -05:00
Nikolay Sivov 791924a2e1 comctl32/listview: Remove internal autoarrange flag, it breaks positioning.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-03 17:15:35 +02:00
Alex Henrie 690022c61b comctl32: Return TRUE from LVM_REDRAWITEMS with bad indices.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-20 17:23:22 +01:00
Nikolay Sivov fa846bdb27 comctl32/listview: Fix indentation warnings on GCC 6.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-15 18:31:09 +09:00
Nikolay Sivov 622a24046f comctl32/listview: Return earlier on allocation failure (Coverity).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-04 09:08:51 -05:00
Nikolay Sivov e0361765ab comctl32/listview: Remove redundant check in LVM_DELETECOLUMN handler.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-01 05:30:18 -05:00
Nikolay Sivov 5faab43d34 comctl32/listview: Filter invalid indices when setting selection mark.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-01 05:30:17 -05:00
Michael Stefaniuc 65a2e59a78 comctl32: Avoid using CopyRect() on RECT structs.
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-24 21:10:32 +09:00
Andrey Gusev ee19a56a94 comctl32: Fix a typo in comment.
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-27 16:21:59 +09:00
Nikolay Sivov 3febb46237 comctl32/listview: Hit test data pointer is never NULL when sending LVN_ITEMACTIVATE.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-17 11:50:01 +09:00
Nikolay Sivov f4542cf7d7 comctl32/listview: Simplify setting redraw mode flag.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-02 18:31:08 +09:00
Michael Stefaniuc 903ea19122 comctl32: Use SetRect() instead of open coding it.
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-29 23:23:36 +09:00
Nikolay Sivov f5ca9b9104 comctl32/listview: Handle DPA_SetPtr() failure (Coverity).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-08 23:24:53 +09:00
Michael Stefaniuc d49201138d comctl32: Use SetRectEmty() instead of open coding it.
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-03 22:29:03 +09:00
Akihiro Sagawa af4a757ad2 comctl32: Prevent invalid focus change notifications from LVS_OWNERDATA lists.
Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-21 00:00:21 +09:00
Piotr Caban ddcab8acea comctl32: Set listview focus in WM_LBUTTONDOWN.
This patch reverts commit 098dc7b330 and
moves focus setting after LVN_ITEMCHANGED notification is sent. Writing
tests for it is tricky because native blocks inside WM_LBUTTONDOWN message.

Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-02 12:59:04 +09:00
Nikolay Sivov 7a59b27f4d comctl32/listview: Fix printf format (PVS-Studio).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-28 22:31:32 +09:00
Piotr Caban 9c87c7e76d comctl32: Don't use uninitialized LVITEM fields in LISTVIEW_InsertItemT when LVS_EX_CHECKBOXES was specified.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
2015-10-07 21:28:50 +09:00
Piotr Caban 4dd26ee814 comctl32: Don't ask for WM_MOUSEHOVER messages when LVS_EX_TRACKSELECT was not specified.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
2015-10-07 21:28:49 +09:00
Huw Davies 4f06425a03 comctl32: Set the item size after LISTVIEW_ScrollColumns().
LISTVIEW_ScrollColumns() increments the item width by the scroll
delta, so we need the original width to still be present.
2015-09-08 14:48:09 +09:00
Francois Gouget f8a7d6ed74 Assorted spelling fixes. 2015-08-07 23:50:48 +09:00
Nikolay Sivov 30cdd59252 comctl32/listview: Always forward HDM_SETORDERARRAY to a header. 2015-03-31 14:47:56 +09:00
Nikolay Sivov d12c2f8b6f comctl32/listview: Use defined name instead of magic value. 2015-03-31 14:47:54 +09:00
Nikolay Sivov 9fcfaaa64a comctl32/listview: Support header item image/bitmap in LVSCW_AUTOSIZE_USEHEADER case. 2015-03-31 14:47:52 +09:00
Nikolay Sivov c4a3651e34 comctl32/listview: Remove outdated TODO comment. 2015-03-30 16:37:44 +09:00
Nikolay Sivov 5c2e7075df comctl32/listview: Always forward LVM_GETCOLUMNORDERARRAY to header. 2015-03-30 16:37:40 +09:00
Nikolay Sivov 3c9db1df60 comctl32/listview: Fix scrolling in LV_VIEW_DETAILS view. 2015-03-30 16:37:34 +09:00
Nikolay Sivov 782253f18d comctl32/listview: Fix focus rectangle for LVS_EX_FULLROWSELECT case. 2015-03-30 16:37:31 +09:00
Nikolay Sivov 326af51ec2 comctl32/listview: Fix item focus rectangle to use proper label/selection bounds. 2015-03-30 16:37:27 +09:00
Nikolay Sivov b6dc726bbd comctl32/listview: Update view on style change only if LVS_TYPEMASK styles have changed. 2015-03-23 16:36:06 +09:00
Michael Stefaniuc 2db0a3d01e comctl32: Merge two if blocks with identical condition (PVS-Studio). 2014-12-05 11:24:12 +01:00
Sebastian Lackner 392321f4f6 comctl32: Allocate new memory in notify_forward_header() to avoid Free() on wrong pointer. (Valgrind). 2014-06-23 10:12:25 +02:00
Nikolay Sivov fa3e750e2c comctl32/listview: Fix custom draw stage sequence. 2014-05-12 10:55:09 +02:00
Nikolay Sivov d24095a7d1 comctl32: Fix LVN_DELETEALLITEMS notification for LVS_OWNERDATA case. 2014-04-09 14:58:17 +02:00
Marcus Meissner 318169a86f comctl32: Process GetKeyState return correctly (Coverity). 2014-04-08 18:28:29 +02:00
Andrey Gusev be367393c9 Assorted typos fixes. 2014-01-13 17:37:42 +01:00
Frédéric Delanoy 5ba7f79bad Assorted spelling fixes. 2013-12-03 19:41:53 +01:00
Nikolay Sivov f13d8cc373 comctl32: Fix LVS_OWNERDRAWFIXED handling in hittesting. 2013-09-09 11:27:54 +02:00
Alexandre Julliard 7624da76a8 comctl32: Remove comments about native behavior, that's not a valid source of information. 2013-05-29 15:43:27 +02:00
Daniel Jelinski 27fb2fb076 comctl32/listview: Fix overwriting of item values. 2013-03-25 13:57:15 +01:00