9f1cdb4970
msi: Do not free hPackage twice or uninitialized (Coverity).
...
Signed-off-by: Marcus Meissner <marcus@jet.franken.de>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 09:39:55 +02:00
457431ab5b
msi: Reuse the custom action server process where possible.
...
We use a named pipe to communicate between the client (i.e. the process that
called MsiInstallProduct() and the custom action server. The naïve approach
has the client send custom action GUIDs to the server and the server send
back the results of executing the action, but this fails in the case of
nested custom actions, so instead we send back handles of threads for the
client to wait on.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-11 15:45:11 +02:00
6135b38d7d
msi: Avoid connecting to the RPC server more than once.
...
This is a no-op as is, but is necessary as of the next patch in the case of
nested custom actions.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-11 15:45:11 +02:00
7908d6ee39
msi: Create the custom action thread inside msiexec.exe.
...
This patch is effectively a no-op by itself, but makes the next patch
architecturally much simpler. We need the main thread to be non-blocking
to allow nested custom actions to work, so creating the thread inside of
msiexec allows the custom action thread to write the result of the action to
the server pipe while the main thread simply reads from it.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-11 15:45:11 +02:00
5c7cf0a47d
msi: Avoid starting the RPC server more than once for a given package.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-11 15:45:11 +02:00
d0451d5734
msi: Mark exported wine functions CDECL.
...
Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-19 20:46:50 +02:00
756bbb5bb7
msi: Store the current script in the package.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-06 11:18:34 +02:00
f4bcd95fa7
msi: Avoid leaking custom action data.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-09 15:50:28 +02:00
deb4f97000
msi: Check return value of GetBinaryType().
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-04 16:56:44 +02:00
e355cb6277
msi: Don't load a custom action DLL in the main process.
...
This has no effect anymore, and won't work if the architecture doesn't match.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-01 13:12:26 +02:00
6049b0f8c3
msi: Execute the custom action server with the correct bitness.
...
The bitness depends solely on the bitness of the DLL (tested manually).
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-01 13:12:26 +02:00
71c0738c0e
msi: Initialize [out] strings to NULL.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-27 19:56:36 +02:00
85d1fb62b3
msi: Execute custom actions in a separate process.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-26 13:27:10 +02:00
2635333922
msi: Make remote_GetActionInfo() RPC-compatible.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-26 13:27:05 +02:00
2192c9a50a
msi: Make MsiGetProperty() RPC-compatible.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-17 20:57:40 +02:00
8bfb4e8b62
msi: Convert the IWineMsiRemote* remote interfaces to RPC stubs.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-16 11:48:17 +02:00
b9b459810f
msi: Allocate the remote handle on the server side.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-16 11:46:28 +02:00
f25501db4b
Revert "msi: Store the current script in the package."
...
Commit 036f007e2486bc556f9fe1e668d41f
2018-01-04 15:13:33 +01:00
036f007e24
Revert "msi: Don't execute a deferred custom action when not running the install script.".
...
This (effectively) reverts commit 86bc556f9f
2017-12-22 11:39:34 +01:00
13a00077e4
msi: Complain louder if we can't find a custom action DLL or EXE.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-05 20:30:04 +01:00
e1e668d41f
msi: Store the current script in the package.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-19 20:01:39 +02:00
5245b9d3a8
msi: Remove a superfluous substructure.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-19 20:01:35 +02:00
86bc556f9f
msi: Don't execute a deferred custom action when not running the install script.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-18 09:57:07 +02:00
3033daec11
msi: Implement UI messages for dialogs.
...
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-07 13:01:26 +02:00
92aa91d2de
msi: Fix stack alignment in CUSTOMPROC_wrapper.
...
Spotted by Dmitry Timoshkov.
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-07 16:44:18 +09:00
17b05316a5
msi: Clean up handling of temporary files.
2015-04-01 22:34:20 +09:00
2478421d87
msi: Return interface pointer instead of impl pointer.
2015-03-24 18:16:37 +09:00
dc33b13581
msi: Fix a record leak on error paths (Coverity).
2014-03-27 12:06:04 +01:00
fcb924c144
msi: Fall back to the global temporary directory when the TempFolder property resolves to a non-existing directory.
2014-01-03 17:00:08 +01:00
b64fabf39e
msi: Don't defer custom actions in the UI sequence if they match the currently running script.
2013-06-03 21:11:51 +02:00
1be1b8433a
msi: Remove an unused parameter from action_type_matches_script.
2013-05-29 18:12:05 +02:00
30fc34b881
msi: Fix memory leak.
2013-05-21 12:06:26 +02:00
b637d4ca94
msi: Remove const from integer parameters.
2013-01-21 16:28:13 +01:00
5b642da8cb
msi: Execute concurrent installers in a separate process.
2013-01-21 16:27:57 +01:00
af08a2f6ba
msi: Pass string length to msi_set_property in ACTION_CustomAction.
2012-10-29 14:41:55 +01:00
2a31a3c057
msi: Don't create a copy of deferred custom action data.
2012-10-29 14:41:44 +01:00
0f1d3474a8
msi: Add a length parameter to msi_set_property and use it where appropriate.
2012-10-29 14:41:36 +01:00
6a588baaf7
msi: Use inline wrappers for calling COM methods.
2012-07-27 17:05:32 +02:00
f55ee1a212
msi: Don't crash if no working directory is specified for custom action type 34.
2012-07-09 15:06:35 -04:00
022915f75b
msi: Don't hide failure of script custom actions.
2012-05-15 16:26:37 +02:00
dd205230a0
msi: Keep the UI level fixed during the lifetime of a package.
2012-04-05 17:53:20 +02:00
b00e7039c5
msi: Execute custom actions in the right script.
2012-01-06 21:57:40 +01:00
cd4432bc9b
msi: Make sure to keep a reference to custom action data until the actions are finished.
2011-12-06 15:51:00 +01:00
a100550383
msi: Trace the exit code from custom action processes.
2011-11-14 13:10:19 +01:00
e1c2e8828f
msi: Clean up the database queries.
2011-07-27 11:55:16 +02:00
823560d472
msi: Get rid of the remaining tabs.
2011-07-01 14:39:36 +02:00
5ca2277cc5
msi: Pass the full custom action command to CreateProcess.
2011-06-14 13:15:25 +02:00
b4c20e7fef
msi: Get rid of forward declarations for custom action handlers.
2011-06-07 14:18:34 +02:00
880ef2bb35
msi: Factor out common code to execute custom action commands.
2011-06-07 14:18:33 +02:00
1ab830188a
msi: Execute the rollback script if the installation failed.
2011-05-20 12:44:37 +02:00
Marcus Meissner