Commit Graph

457 Commits

Author SHA1 Message Date
Jakob Eriksson 461c830745 Eliminate HeapAlloc casts. 2005-03-22 18:26:06 +00:00
Jakob Eriksson 30af06f788 Fix for NT4 behaviour. 2005-03-22 16:39:02 +00:00
Vincent Béron 1e365f7791 Fixed some calling conventions. 2005-03-21 10:32:45 +00:00
Jakob Eriksson 21a0c3b4fc CryptAcquireContextA() can return NTE_FAIL on Windows 98. 2005-03-15 19:32:38 +00:00
Alexandre Julliard 3fe9aa2054 Avoid accessing an uninitialized string in the failure case. 2005-03-14 17:20:58 +00:00
Alexander Yaworsky 401d4cf42a Correct incorrect use of arguments to QueryServiceConfigA. Spotted by
Troy Rollo.
2005-03-10 11:14:04 +00:00
Jason Edmeades de70942e6d Add stub for SetSecurityInfo. 2005-03-07 11:00:24 +00:00
Jakob Eriksson 0667f919ab Account for permissions on Win2k. 2005-03-05 10:47:13 +00:00
Troy Rollo bf6d5fc66b Make GetFileSecurityW return a standard SECURITY_DESCRIPTOR instead of
an uninitialised (and invalid) one.
2005-03-05 10:46:34 +00:00
Troy Rollo 4021f530d7 Return an empty string for service dependencies when there are no
dependencies, rather than a NULL pointer, which causes some apps to
SEGV.
2005-03-04 12:32:50 +00:00
Troy Rollo 74e2cfb66c Correct incorrect use of arguments to QueryServiceConfigW. 2005-03-04 10:47:41 +00:00
James Hawkins e8d1e2f745 Fix RegOpen/CloseKey. 2005-02-25 16:52:10 +00:00
Jakob Eriksson e2dab32daa Apparently NT4 can also return ERROR_ENVVAR_NOT_FOUND. 2005-02-23 12:44:15 +00:00
James Hawkins d5e2b7c843 Add RegOpenKey, RegCloseKey tests. 2005-02-21 20:37:26 +00:00
Jakob Eriksson e026ef742e Apparently NT4 can also return ERROR_ENVVAR_NOT_FOUND. 2005-02-17 11:50:36 +00:00
Francois Gouget dd073bbb3f Cast the GetProcAddress() return value to avoid warnings about the
function pointer being of the wrong type.
Fix assorted signed/unsigned comparison warnings.
2005-02-14 21:04:45 +00:00
Vincent Béron d8a26f2c5f Suppress a warning. 2005-02-14 11:52:48 +00:00
Stefan Leichter 68e1208f59 Make advapi32_test.exe loadable on NT 3.51. 2005-02-14 11:06:16 +00:00
Robert Shearman b0f02b28b9 - Implement AdjustTokenPrivileges, DuplicateTokenEx and
GetTokenInformation (for the TokenPrivileges case).
- Return STATUS_NO_TOKEN for OpenThreadToken when there is no token
  set for the thread.
2005-02-11 11:52:06 +00:00
Francois Gouget 4d801b66e6 Assorted spelling fixes. 2005-02-10 19:19:35 +00:00
Alexandre Julliard d6df8f5675 Don't make the test key volatile, that can break other tests. 2005-01-27 11:15:00 +00:00
Mike McCormack 81ed8be90d Convert services to use pipes for RPC instead of shared memory. 2005-01-24 19:33:43 +00:00
Mike McCormack 939179d681 Fix, add and rearrange winsvc.h declarations. 2005-01-14 16:50:57 +00:00
Mike McCormack c3ead97b4e Move all service stubs together, make them consistent. 2005-01-14 16:20:41 +00:00
Mike McCormack 1afd5f68f8 Cleanup service handles. 2005-01-14 15:13:40 +00:00
Mike McCormack 4a0f999859 Use CreateEventW in preference to CreateEventA for unnamed events. 2005-01-07 15:40:09 +00:00
Jakob Eriksson 6239fc72de On NT4 we can also get ERROR_RING2_STACK_IN_USE from
CryptAcquireContext().
2005-01-04 20:31:53 +00:00
Mike McCormack 8d830b6246 Add some missing declarations in the spec file. 2005-01-03 20:10:45 +00:00
Hans Leidekker 0cc2031409 Stub implementations for GetKernelObjectSecurity,
GetPrivateObjectSecurity, GetServiceKeyName{A,W},
ImpersonateNamedPipeClient, InitiateSystemShutdown{A,W},
IsTokenRestricted, LogonUser{A,W}, LookupAccountNameW,
LookupPrivilegeDisplayName{A,W}, MapGenericMask,
ObjectCloseAuditAlarm{A,W}, ObjectOpenAuditAlarm{A,W},
ObjectPrivilegeAuditAlarm{A,W}, PrivilegedServiceAuditAlarm{A,W},
QueryServiceLockStatus{A,W}, SetAclInformation,
SetPrivateObjectSecurity, SetSecurityDescriptorControl,
SetServiceBits, LsaSetInformationPolicy, LsaLookupNames,
LsaEnumerateTrustedDomains.
2005-01-03 17:12:51 +00:00
Michael Stefaniuc 15a308a9d7 Do not check for non NULL pointer before HeapFree'ing it. It's
redundant.
2005-01-03 14:56:42 +00:00
Mike McCormack 816f86560e Fix CreateService's error code for a service that already exists. 2004-12-27 17:44:47 +00:00
Rein Klazes 3714a39867 Correct cases where arguments of ok() calls depend on the order in
which they are evaluated.
2004-12-27 17:26:37 +00:00
Mike McCormack 1645ab0492 Don't use RtlCreateUnicodeStringFromAsciiz, it doesn't preserve NULL. 2004-12-27 17:10:31 +00:00
Michael Stefaniuc 5ad7d858e0 Do not check for non NULL pointer before HeapFree'ing it. It's
redundant.
2004-12-23 17:06:43 +00:00
Alexandre Julliard 1d36d12917 Fixed prototypes of a couple of ntdll functions.
Replaced the CallWin32ToNt macro by a proper function.
PBOOL cannot be cast to PBOOLEAN, we need to use an intermediate
variable.
2004-12-22 15:31:16 +00:00
Hans Leidekker 49f7f6c208 Stub implementations for AdjustTokenGroups, AreAllAccessesGranted,
CreatePrivateObjectSecurity, CreateProcessAsUser{A,W},
DestroyPrivateObjectSecurity, DuplicateToken{,Ex},
EnumDependentServices{A,W}, GetEffectiveRightsFromAcl{A,W},
ConvertStringSecurityDescriptorToSecurityDescriptorA. Implementations
for BuildExplicitAccessWithName{A,W},
BuildTrusteeWithObjectsAndName{A,W},
BuildTrusteeWithObjectsAndSid{A,W}.
Correct prototype for InitializeAcl, RtlCopySid and RtlGetAce.
Use the CallWin32ToNt macro only with functions that return an
NTSTATUS.
2004-12-21 16:16:10 +00:00
Ivan Leo Puoti a329904a3f In OpenSCManagerW() allow lpDatabaseName to be an empty string. 2004-12-21 16:05:28 +00:00
Michael Jung a3b97e051a Respect the sDescription parameter in CryptSignHash and
CryptVerifySignature.
2004-12-21 14:34:18 +00:00
Michael Jung e9cb2e6d5f ixed calculation of buffer size in CRYPT_ANSIToUnicode and
CRYPT_UnicodeToANSI.
2004-12-20 18:52:41 +00:00
Jon Griffiths 873cd009d0 Remove unneeded headers to reduce unneeded rebuilds. 2004-12-15 10:54:44 +00:00
James Hawkins ce4a4ef981 Minor documentation addition. 2004-12-14 15:27:05 +00:00
James Hawkins 7f34c04067 Cleanup some documentation. 2004-12-14 15:26:04 +00:00
Alexander Yaworsky e849a56673 Check service database name in OpenSCManager(). 2004-12-09 16:52:10 +00:00
Mike McCormack 0128a849b1 Stub implementations for Lsa(Store/Retrieve)PrivateData. 2004-12-08 14:02:26 +00:00
Alexander Yaworsky 9087fb2000 Notify StartService when service control dispatcher has been
started. Otherwise StartService terminates service process.
2004-12-08 14:01:26 +00:00
Alexander Yaworsky e2b9000b84 Implemented RegisterServiceCtrlHandler, ControlService. 2004-12-07 14:24:58 +00:00
Stefan Leichter 2d136f0de9 Fix missing imports on NT4. 2004-12-06 20:38:24 +00:00
Mike McCormack 4bda758157 Stub implementations for DecryptFile, EncryptFile and
GetServiceDisplayName.
2004-12-06 16:17:08 +00:00
Alexander Yaworsky bb1466e861 Implemented SetServiceStatus, QueryServiceStatus. 2004-12-06 11:35:22 +00:00
James Hawkins e3ba250034 Only call test_set_provider_ex() once. 2004-12-06 11:34:40 +00:00
Alexander Yaworsky e6985ab3a5 Basic implementation of service control dispatcher. 2004-12-02 19:51:41 +00:00
Alexander Yaworsky 78b64795d7 Introduced service thread. 2004-12-01 15:31:34 +00:00
Mike McCormack 418672f2e5 Added a stub implementation for GetCurrentHwProfileW. 2004-12-01 15:27:59 +00:00
Eric Pouech 0a258964c2 Const correctness fixes. 2004-11-30 21:38:57 +00:00
James Hawkins 88aeb475c0 Fixed a few memory leaks. 2004-11-30 17:33:27 +00:00
Alexander Yaworsky 8109cfd443 Merge Unicode and ASCII versions of StartServiceCtrlDispatcher.
Implement StartServiceCtrlDispatcherA on the top of
StartServiceCtrlDispatcherW.
Get rid of HEAP_strdupWtoA.
2004-11-30 17:29:03 +00:00
Alexander Yaworsky 970a877995 Move up SERV_* functions. 2004-11-21 15:50:08 +00:00
James Hawkins 2515ff77fc Added beginnings of RegQueryValueEx tests. 2004-11-19 18:13:30 +00:00
Jason Edmeades d80247ef67 - Stub SetServiceObjectSecurity to pretend to work (return true).
- Change QueryServiceObjectSecurity so it initializes the ACL with a
  null DACL, and return as though it worked.
- Changed QueryServiceStatus to tell if the service is running by the
  presence of some named shared storage - copied from StartService when
  it checks to see if its already running.
2004-11-10 01:31:39 +00:00
Juan Lang 0fca5acba8 - implement LookupPrivilegeName
- correct LookupPrivilegeValue (had a buffer overrun and sometimes
  returned incorrect LUIDs for well-known values)
- make AllocateLocallyUniqueId less obviously incorrect
- add a bunch of test cases
2004-11-04 04:52:17 +00:00
Jakob Eriksson 2a798e5f31 AllocateAndInitializeSid does not work on Win98. 2004-11-03 22:14:55 +00:00
Michael Jung 6b12414fc8 CryptGetUserKey: Set return key handle to zero in case of failure. 2004-11-01 21:07:24 +00:00
Michael Jung 2f2f3a1d13 CryptCreateHash: Set returned hash handle to zero in case of failure. 2004-10-27 21:15:10 +00:00
Juan Lang 531be0b887 Update comment for LsaOpenPolicy. 2004-10-25 21:43:47 +00:00
Mike McCormack 5bc8077511 Implement ChangeServiceConfig2A using ChangeServiceConfig2W. 2004-10-21 20:57:09 +00:00
Mike McCormack 2e82a0965b Implement ChangeServiceConfigA using ChangeServiceConfigW. 2004-10-21 19:51:53 +00:00
Alexandre Julliard bbde53fb02 RegQueryValueW must return count in bytes for empty string too. 2004-10-19 21:14:09 +00:00
Michael Jung 162171e258 Fixed a typo in CryptExportKey. 2004-10-18 19:35:24 +00:00
Michael Jung 09a81f8c3f CryptDeriveKey - set return key handle to NULL in case of failure. 2004-10-11 19:52:54 +00:00
Alexandre Julliard 06e35a776b Removed wrong memset calls. 2004-10-07 19:14:21 +00:00
Alexandre Julliard 6c6f71c8a9 Fixed MD4Final/MD5Final entries (spotted by Vincent Béron). 2004-10-07 19:13:33 +00:00
Hans Leidekker b6aa6210cd Implement MD{4,5}Init MD{4,5}Update and MD{4,5}Final.
Add tests for these functions.
2004-10-06 18:53:29 +00:00
Dmitry Timoshkov f2dca03dec Make advapi32/crypt.c test pass under win2k SP4, do stricter error
checking, comment out a couple of tests failing under win2k, add a
note why RSA_CPAcquireContext may fail.
2004-10-05 02:09:36 +00:00
Hans Leidekker b96edb38cd Implement SystemFunction006().
Add a test for SystemFunction006().
2004-10-04 20:42:05 +00:00
Dmitry Timoshkov 964422524c Avoid a crash in advapi32/test_sha_ctx.c test if required entry points
are missing.
2004-10-04 19:31:17 +00:00
Alexander Yaworsky d9c9bfd779 Start only first service in the service table. 2004-09-27 20:35:27 +00:00
Alexander Yaworsky 31ec065bfd Restructured code of StartServiceCtrlDispatcherA/W. 2004-09-25 00:28:42 +00:00
Alexander Yaworsky 9d590d5059 Pass arguments to the service program. 2004-09-21 00:23:32 +00:00
Filip Navara e1db054315 Implement A_SHA* functions present in Windows XP and later systems. 2004-09-17 18:15:28 +00:00
Juan Lang bd0e74253c - correct ConvertStringSidToSidW and ConvertSidToStringSidW, with
tests
- add ConvertStringSidToSidA
- add missing exports for ConvertStringSidToSidA/W
2004-09-16 20:27:52 +00:00
Alexander Yaworsky 6a36f28f2a Pass argv[0] (service name) to the service program. 2004-09-16 20:27:31 +00:00
Alexander Yaworsky 81dfe73ef8 Added stubs for MD4, MD5 and SHA functions. 2004-09-16 19:09:13 +00:00
Alexander Yaworsky 8484d3fbae Proper finalization in StartServiceW. 2004-09-14 19:39:19 +00:00
Mike McCormack 7d3431ed1d Stub implementation for QueryServiceObjectSecurity. 2004-09-14 19:25:35 +00:00
Mike McCormack 8ea4fffb98 Make sure not to interfere with the lasterror value returned by the
CSP in CryptAcquireContextA.
2004-09-14 17:43:41 +00:00
Alexander Yaworsky 37180dd6d5 Implemented LockServiceDatabase and UnlockServiceDatabase. 2004-09-10 21:12:25 +00:00
Wolfgang Schwotzer 9c4890042d LookupAccountNameA stub always returns a valid SID. 2004-09-07 20:41:35 +00:00
Mike McCormack 8100e0eec2 Return the correct error when OpenService is called with a
non-existing service.
2004-09-06 20:28:32 +00:00
Hans Leidekker 411fc5f164 Fix signed/unsigned comparison warnings. 2004-09-02 23:00:53 +00:00
James Hawkins 19f2669c24 - remove unnecessary type conversions
- added tests for crypt
2004-09-01 22:46:29 +00:00
Alexander Yaworsky 7db2149f65 Implemented QueryServiceConfigA. 2004-09-01 17:29:00 +00:00
Alexander Yaworsky 871635c650 Expand ImagePath in QueryServiceConfigW. 2004-08-31 18:50:39 +00:00
Alexander Yaworsky 3ab2818948 Sanity check when closing service handle. 2004-08-31 17:32:05 +00:00
James Hawkins 1c251e9a69 Make CryptSetProviderEx only delete the 'Name' value and not delete
the entire 'Type XXX' key when deleting the default provider.
2004-08-30 23:57:18 +00:00
Alexander Yaworsky 5f115371ce Changed SC_HANDLEs from HKEYs to pointers to internal structures. 2004-08-30 23:57:03 +00:00
Huw Davies 8e9d88c1a1 Fix full name of HKEY_CURRENT_CONFIG. 2004-08-26 18:22:58 +00:00
Alexander Yaworsky 968e252149 StartService must pass full command line to service program. 2004-08-26 18:10:01 +00:00
Evan Deaubl 18e195a89b Added GetSecurityInfo stub. 2004-08-26 00:29:06 +00:00
Mike McCormack fd4675c501 Make SetTokenInformation call NtSetInformationToken. 2004-08-25 17:30:46 +00:00
James Hawkins 1a6fa44658 Enable ERROR_MORE_DATA to be set in CryptGetDefaultProvider. 2004-08-20 19:25:35 +00:00
James Hawkins e02eb90509 Added tests for CryptSetProviderEx. 2004-08-20 19:25:03 +00:00
Mike McCormack e27ae38f01 Fix BuildTrusteeWithSid, implement and test BuildTrusteeWithName. 2004-08-19 19:01:12 +00:00
Aric Stewart 4a18630fef Let StartServiceCtrlDispatcher handle services not started by
StartService.
2004-08-17 22:29:01 +00:00
James Hawkins a26b7e30b1 If pszTypeName is too small to hold the type name in
CryptEnumProviderTypes, return ERROR_MORE_DATA.
2004-08-17 22:08:16 +00:00
Mike McCormack 945364754e Remove unnecessary casts in crypt tests. 2004-08-17 22:07:59 +00:00
Mike McCormack 93eeaa417d Implemented Get/SetFileSecurity A->W. 2004-08-16 23:18:23 +00:00
James Hawkins 25a6a0e08a Fix alloc test in CryptEnumProviderTypesW that failed if the alloc
succeeded.
2004-08-16 21:10:38 +00:00
James Hawkins ddad3152a1 Fixed a few crypt test bugs. 2004-08-16 21:10:18 +00:00
Mike McCormack 985646f07a Declaration, implemention and test for BuildTrusteeWithSid. 2004-08-16 21:07:50 +00:00
Mike McCormack d73c03a8b0 Add some stub declarations. 2004-08-16 19:58:24 +00:00
Mike McCormack 55257303d7 Move declaration of LSA* structs to ntsecapi.h. 2004-08-16 19:47:21 +00:00
Francois Gouget 870f55fefc Fix the PSID and PSECURITY_DESCRIPTOR types.
Add PISID and PISECURITY_DESCRIPTOR.
2004-08-13 23:55:43 +00:00
Mike McCormack edf55ec7d9 Implement SetThreadToken using NtSetInformationThread. 2004-08-13 23:20:27 +00:00
James Hawkins 7aa82c80d4 If the pszProvName param of CryptEnumProviders is too small to hold
the provider name, SetLastError to ERROR_MORE_DATA.
2004-08-13 19:45:40 +00:00
James Hawkins e672d8b6b4 Added tests for CryptEnumProviders. 2004-08-12 03:24:20 +00:00
James Hawkins e1f5370f42 Cleanup A->W cross call in CryptEnumProviders. 2004-08-12 03:24:10 +00:00
Mike McCormack f8167f01bc Implement A->W call for SetNamedSecurityInfo. 2004-08-09 22:55:47 +00:00
James Hawkins 8cc77c1805 Make CryptEnumProvidersA pcbProvName parameter contain the correct
size of the provider name on return.
2004-08-09 22:53:58 +00:00
Mike McCormack d161a8f64e Fix definition of LookupPrivilegeNameW and declare it. 2004-08-09 19:46:15 +00:00
James Hawkins 62851fdb52 Fix alloc failure check in CryptEnumProvidersW. 2004-08-09 18:51:48 +00:00
Mike McCormack e00a0ea330 Added a test for ConvertSidToStringSidW. 2004-08-09 18:47:22 +00:00
Mike McCormack be303074d6 Implemented ConvertSidToStringSidA/W. 2004-08-09 18:47:06 +00:00
Mike McCormack 2d86d17f2f Implement A->W call for GetNamedSecurityInfo. 2004-08-06 17:31:17 +00:00
Alexandre Julliard c09881d51c Fixed some more freeing issues in CryptAcquireContextA. 2004-08-02 18:49:26 +00:00
Michael Jung 4ce6ee1b31 Fixed a potential double call to CRYPT_Free on variable "temp". 2004-07-30 00:07:35 +00:00
Alexandre Julliard bba76fca45 Don't crash on NULL data in RegSetValueExA (reported by Mike Hearn and
Andreas Mohr).
Removed a couple of unnecessary version checks.
2004-07-24 02:32:50 +00:00
Michael Jung 74ed099347 - Changed some FIXMEs to TRACEs, since they report on a problem in the
way the client uses the dll rather than in the dll itself.
- Cover the case, when the pszProvider parameter points to an empty
  string.
- Fixed some imprecisions in error reporting.
- Removed the "wine_todo's" arround the corresponding unit-tests.
2004-07-24 02:27:15 +00:00
Michael Jung 7439680542 - Fixed a problem with dwProvType values greater than 99 in
CRYPT_GetTypeKeyName.
- Fixed error reporting in the case of dwProvType == 0.
- Removed "todo_wine" from the corresponding unit test.
2004-07-22 19:43:03 +00:00
Michael Jung ccf487fc4d Added some unit tests for the CryptAcquireContext API function. 2004-07-21 19:37:29 +00:00
Alexandre Julliard 01bb813156 Fixed some duplicate CRYPT_Free calls (spotted by Michael Jung). 2004-07-16 19:19:00 +00:00
Michael Jung 4651067f43 Use RegQueryValueExA instead of RegQueryValueA in
CryptEnumProviderTypes.
2004-07-15 18:59:34 +00:00
Michael Jung 81e6f0c15c Reference counting for CRYPTPROV objects.
Implemented CryptContextAddRef.
2004-07-13 23:34:13 +00:00
James Hawkins 6a358c4090 Added and cleaned API docs. 2004-07-13 23:33:14 +00:00
James Hawkins 250c7c08bb Added some more API docs. 2004-07-12 23:32:10 +00:00
Ge van Geldorp 606cc0acb6 Add missing privilege names. 2004-07-07 00:47:50 +00:00
William Lahti d5a31871cd Implemented AreAnyAccessesGranted. 2004-05-25 00:22:42 +00:00
Juan Lang 56b5164686 - If a crypto provider does not have a Signature in the registry,
check for the presence of the SigInFile value before failing.
- Get rid of a couple redundant assignments.
2004-05-17 19:48:00 +00:00
Mike McCormack 0effd76987 Pass crypt provider and type to CPAcquireContext. 2004-05-12 23:29:44 +00:00
Alexandre Julliard 6ddfba14e2 Fixed buffer size handling in GetUserNameA (reported by Hannu
Valtonen).
2004-05-10 21:26:58 +00:00
Alexandre Julliard c4effa39e6 Use the Unix codepage to convert the user name to Unicode. 2004-05-07 04:01:28 +00:00
Francois Gouget 0345908a27 Assorted spelling fixes. 2004-04-28 00:24:44 +00:00
Jon Griffiths 50ce0844ba Documentation fixes. 2004-04-23 21:32:34 +00:00
Francois Gouget 52c0832161 Make Unicode strings static const. 2004-04-20 01:12:17 +00:00
Francois Gouget 6a6c85c6d8 Make Unicode const strings static so they are not copied to the stack
each time we enter the function.
2004-04-19 20:12:14 +00:00
Mike Hearn 481a67e887 Documentation for SystemFunction040 and SystemFunction041 has become
available, so stub them out in case applications use them.
2004-04-17 00:23:50 +00:00
Alexandre Julliard bea945eed9 OpenServiceW: don't use the requested service access rights for the
registry key access rights, they are not the same thing.
2004-04-12 22:18:39 +00:00
Alexandre Julliard c420138d99 OpenSCManagerA/W arguments are strings. 2004-04-12 22:11:24 +00:00
Raphael Junqueira 8c16d405e0 Added some stubs. 2004-04-07 19:00:30 +00:00
Alexandre Julliard 9e4ed6460c .spec.c files are no longer used for 32-bit dlls. 2004-03-24 03:36:44 +00:00
Juan Lang 4161a8b474 Stub CommandLineFromMsiDescriptor to prevent a crash in Accelerys
Materials Studio.
2004-03-22 21:31:26 +00:00