Commit Graph

2145 Commits

Author SHA1 Message Date
Dmitry Timoshkov 24f3d50ccc wininet: Remove unused parameter from create_netconn().
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-07 19:27:22 +02:00
Alistair Leslie-Hughes 6552ddaaa5 wininet: Always copy the password even if blank.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-20 19:36:08 +02:00
Michael Stefaniuc d870d4105d wininet: Use the more common ARRAY_SIZE spelling.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-06 19:44:26 +02:00
Michael Stefaniuc 8d876e740e wininet/tests: Use the available ARRAY_SIZE() macro.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-22 01:01:55 +02:00
Michael Stefaniuc 91c1fc2ff9 wininet/tests: Use the correct array size in a notification_data test.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-21 11:18:35 +02:00
Jacek Caban 54b414b121 wininet: Simplify header string handling in HTTP_HttpSendRequestW.
Spotted by Mark Jansen, avoids potential double-free.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-11 16:51:19 +02:00
Jacek Caban 2bba45765b wininet: Add stub for INTERNET_OPTION_REFRESH.
Based on patch by Michael Müller.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-03 17:56:23 +02:00
Jacek Caban d9dd9023fd wininet: Allow INTERNET_OPTION_SETTINGS_CHANGED on all handle types.
Based on patch by Michael Müller.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-03 17:56:23 +02:00
Alistair Leslie-Hughes bb41feacd4 wininet: Add support for FormatMessage.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-04 22:04:26 +02:00
Austin English c8861df6d1 wininet: Add ParseX509EncodedCertificateForListBoxEntry stub.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-29 17:24:13 +02:00
André Hentschel be002fd92b wininet: Fix negated check for drain_content result (clang).
Introduced with 4f40039cd7

Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-28 23:39:20 +02:00
Piotr Caban ea0dae6db2 wininet: Fix https connections over proxy.
Successful CONNECT request switch to tunnel instead of having a message
body.

Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-16 00:59:42 +01:00
Alexandre Julliard 105b3dc816 wininet/tests: Update the winehq.org certificate data.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-06 15:46:09 -06:00
Michael Stefaniuc a6a059f802 wininet: Use the global HeapAlloc() wrappers.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-06 12:58:59 +01:00
Wei Xie 6d6dd78e5d wininet: Don't release connection too early.
Signed-off-by: Wei Xie <xiewei@linuxdeepin.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-19 16:40:55 +01:00
Wei Xie 3f06a09604 wininet/tests: Check null pointer in InternetGetSecurityInfoByURLW.
Signed-off-by: Wei xie <xiewei@linuxdeepin.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-09 16:03:50 +01:00
Alex Henrie 7b2ead8da0 wininet/tests: Fix off-by-one errors in HTTP tests (Coverity).
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-08 19:26:54 +01:00
Andrey Gusev dc9088b9eb wininet/tests: Fix resource leak.
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-05 17:33:41 +01:00
Nikolay Sivov aeb4394299 wininet/tests: Fix some leaks (Coverity).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-04 15:03:55 +01:00
Daniel Lehman b84ba52248 wininet: Use case-insensitive comparison for server name.
Signed-off-by: Daniel Lehman <dlehman@esri.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-29 21:30:02 +01:00
Alex Henrie 16226c44da wininet/tests: Skip cookie attributes tests on IE < 8.0.
INTERNET_COOKIE_HTTPONLY was introduced in IE 8.0.

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-17 14:32:02 +02:00
Daniel Lehman 1b25de7d57 wininet: Fix proxy bypass with wildcard if domain length matches with server.
Signed-off-by: Daniel Lehman <dlehman@esri.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-08 16:23:15 +02:00
Alistair Leslie-Hughes 43deec95f6 wininet: Use standard wine_dbgstr_longlong.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-25 12:47:14 +02:00
Jacek Caban e09155723b wininet/tests: Added more persistent connection tests.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-18 08:09:53 +09:00
Jacek Caban 085ce269b1 wininet: Drain content before reusing connection in open_http_connection.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-18 08:09:47 +09:00
Jacek Caban 59395d8845 wininet: Never do blocking reads in chunked_read if zero chunk size is aready read.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-18 08:09:44 +09:00
Jacek Caban 4f40039cd7 wininet: Release connection in HTTPREQ_Read only if remaining control data may be drainad without blocking.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-18 08:09:40 +09:00
Jacek Caban 8090d169ab wininet: Store error state separately from end of stream in chunked stream.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-18 08:09:36 +09:00
Jacek Caban 752d078a42 wininet: Always use drain_content specific to stream type.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-18 08:09:32 +09:00
Jacek Caban 90b936f0b2 wininet: Try to read reamaining data in chunked_drain_content.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-18 08:09:29 +09:00
Jacek Caban 2ecdac8846 wininet: Return error codes from HTTP streams.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-18 08:09:25 +09:00
Jacek Caban 7949a22b43 wininet: Correctly pass URL length to InternetCrackUrlW in get_redirect_url.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-08 20:13:57 +09:00
Jacek Caban a24b8267d5 wininet: Improved cookie debug traces.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-25 14:14:14 +02:00
Nikolay Sivov f55a116101 wininet: Fix potential use-after-free (Coverity).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-10 20:51:11 +02:00
Jacek Caban 89f1d8c58a wininet: Fixed connection_pool_cs declaration.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-07 19:49:46 +02:00
Jacek Caban cee99826b6 wininet: Return an error on redirect with no host name specified.
Inspired by Michael Müller's patch.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-26 18:18:56 +02:00
Jacek Caban 61e28c01c6 wininet: Moved INTERNET_STATUS_REDIRECT notification to HTTP_HandleRedirect.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-26 18:18:54 +02:00
Jacek Caban 19cb65b156 wininet/tests: Fixed potential buffer overflow (coverity).
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-14 11:52:18 +02:00
Jacek Caban a0af1eba27 wininet/tests: Silence noisy traces.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-12 12:03:27 +02:00
Jacek Caban 23e78c01af wininet/tests: Added redirection tests using test server.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 21:33:37 +02:00
Jacek Caban 71ae1923d9 wininet/tests: Introduce open_socket_request helper.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 21:33:37 +02:00
Jacek Caban 74beb8236d wininet/tests: Create events once for all tests.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 21:33:37 +02:00
Jacek Caban 6d6c73863f wininet/tests: Added a helper for testing INTERNET_OPTION_URL.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 21:33:37 +02:00
Jacek Caban 9c959154f6 wininet: Correctly handle redirects to non-http URLs.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 20:51:47 +02:00
Akihiro Sagawa 05c23c95f8 wininet: Use isspaceW() instead of isspace() for WCHARs.
Found with Coccinelle.

Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-17 16:11:26 +02:00
Jacek Caban 7d8cf318a4 wininet: Don't use returned read size if read failed in gzip_read.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-07 18:05:48 +02:00
Jacek Caban 2952c637e3 wininet: Get rid of no longer needed get_avail_data from data stream implementations.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-13 19:28:54 +01:00
Jacek Caban 295291b4be wininet: Always use non-blocking reads in HTTP_ReceiveRequestData.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-13 19:28:52 +01:00
Jacek Caban 4b1445940d wininet/tests: Added more HTTP read tests.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-10 23:21:28 +01:00
Jacek Caban fd0ac40798 wininet: Get rid of no longer needed blocking_mode_t.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-10 23:21:23 +01:00
Jacek Caban 18f9d0303a wininet: Get rid of no longer needed BLOCKING_WAITALL.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-10 23:21:23 +01:00
Jacek Caban 7eaadabc5c wininet: Merge InternetReadFile and InternetReadFileEx implementations.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-10 23:21:23 +01:00
Jacek Caban a546e8acaa wininet: Reimplemented InternetQueryDataAvailable on top of async_read.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-10 23:21:23 +01:00
Jacek Caban 08808747b2 wininet: Rewrite InternetReadFileEx for http protocol to make use of non-blocking reads.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-10 23:21:23 +01:00
Jacek Caban 98bcd00e21 wininet: Rewrite asynchronous read to try to fill whole buffer and not buffer additional data unless requested.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-10 23:21:22 +01:00
Jacek Caban c140a70425 wininet: Propagate WSAEWOULDBLOCK from read_http_stream.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-10 23:21:22 +01:00
Jacek Caban f42a2ccad1 wininet: Pass blocking mode to HTTPREQ_Read.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-10 23:21:22 +01:00
Jacek Caban 67b56774c5 wininet: Propagate WSAEWOULDBLOCK result from content decoding reads.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-10 23:21:22 +01:00
Bruno Jesus 7207b3dbc9 wininet/test: Improve tests for InternetGetConnectedStateEx.
Signed-off-by: Bruno Jesus <bjesus@codeweavers.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-08 16:37:19 +01:00
Bruno Jesus 36f6387e5c wininet: Forward InternetGetConnectedState to Ex function.
Signed-off-by: Bruno Jesus <bjesus@codeweavers.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-06 19:44:39 +01:00
Jacek Caban 7b42dc4931 wininet: Improved netconn_drain_content.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-27 16:24:59 +01:00
Michael Müller 6caecb6e58 wininet: Handle query parameters for HTTPS urls in InternetOpenUrlW.
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-23 13:15:46 +01:00
André Hentschel e9be49067f wininet: Fix some more spec file entries.
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-23 13:15:45 +01:00
Francois Gouget 8f669b63a6 wininet/tests: A spelling fix in an ok() message.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-10 21:34:33 +01:00
André Hentschel 07e3181db3 wininet: Fix some spec file entries.
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-30 21:38:51 +01:00
Jacek Caban 725b55ded2 wininet: Get rid of no longer needed INTERNET_INVALID_PORT_NUMBER in get_server.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-15 23:29:50 +01:00
Michael Müller 0d22e43f8c wininet: Handle INTERNET_INVALID_PORT_NUMBER in HttpOpenRequest.
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-15 23:29:42 +01:00
Fabian Maurer 8c39694882 wininet: Changed usage of UrlEscapeW to fit winapi behavior.
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-14 17:32:36 +01:00
Daniel Lehman b3d12a16ce wininet: Canonicalize URL in HttpOpenRequest.
Signed-off-by: Daniel Lehman <dlehman@esri.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-30 13:23:09 +01:00
Carlo Bramini 47ff95429a wininet: Use return value of sprintf() instead of calling strlen() and simplify code.
Signed-off-by: Carlo Bramini <carlo_bramini@users.sourceforge.net>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-14 11:07:09 -06:00
Gerald Pfeifer 3cb027c743 wininet: Increase buffer in _test_status_code to avoid potential potential overflow.
Signed-off-by: Gerald Pfeifer <gerald@pfeifer.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-03 11:51:37 +02:00
Andrew Eikum 7e841432ed wininet: Don't crash by debug printing too long URLs.
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-09-28 11:26:53 +09:00
Jacek Caban 7d9a439274 wininet: Don't return available data sizes larger than the read buffer.
Based on patch by Hans Leidekker.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-15 12:55:02 +09:00
Bernhard Übelacker 0fcecad8d8 wininet/tests: Fix pathLen given to InternetCrackUrlA.
Signed-off-by: Bernhard Übelacker <bernhardu@mailbox.org>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-04 10:53:03 -05:00
Jacek Caban 16d300cacd wininet: Return data available in current chunk in chunked_get_avail_data.
Based on a patch by Hans Leidekker.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-02 09:08:57 -05:00
Jacek Caban e7d6bba22e wininet: Added chunked stream blocking tests.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-01 09:58:10 -05:00
Jacek Caban 6e0c842dfa wininet: Rewrite chunked stream to store full stream state and allow non-blocking reads crossing chunk boundries.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-01 09:58:06 -05:00
Sebastian Lackner 93832ef88d wininet/tests: Add a test for recently introduced regression related to InternetCrackUrl.
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-08 23:07:20 +09:00
Sebastian Lackner 259b517f2b wininet/tests: Avoid unnecessary initialization of variables.
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-08 23:07:20 +09:00
Michael Müller cacad1df98 wininet: Correctly set lpszUrlPath in InternetCrackUrlW for urls without path component.
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-08 23:07:20 +09:00
Michael Müller 9e4df5ef79 wininet/tests: Fix some typos in ok() messages.
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-07 19:58:02 +09:00
Sebastian Lackner 1eb2c5520c wininet: Use list_head get first entry of list.
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-07 19:57:57 +09:00
Jacek Caban 27ea3804dd wininet: Added semi-stub INTERNET_OPTION_END_BROWSER_SESSION implementation.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-06 23:10:28 +09:00
Jacek Caban b53b717dad wininet: Always set returned size in InternetGetCookieExA.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-06 23:10:24 +09:00
Jacek Caban 8332d80665 wininet: Free all cookie data in free_cookie.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-06 23:10:22 +09:00
Jacek Caban a9a6948b79 wininet: Include stdlib.h before winsock2.h in http.c.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-03 10:54:18 +09:00
Jacek Caban 86d14ad17e wininet: Use INTERNET_SendCallback in ftp.c.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-21 11:23:50 +09:00
Jacek Caban 0d9dcf5c8f wininet: Ignore unknown attributes in get_cookie.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-21 11:23:48 +09:00
Jacek Caban 3a7bd03da0 wininet: Fixed tests on win10.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-21 11:23:46 +09:00
Thomas Faber 877a628aa6 wininet: Avoid buffer overrun in alloc_object.
Signed-off-by: Thomas Faber <thomas.faber@reactos.org>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-03 12:29:36 +09:00
Jacek Caban fff5dca787 wininet: Correctly handle the last proxy override in HTTP_ShouldBypassProxy.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-01 01:04:45 +09:00
Jacek Caban 5eca697aba wininet: Skip more problematic tests on IE6.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-30 11:10:19 +09:00
Jacek Caban 0fdba71bed wininet: Added missing LeaveCriticalSection to set_cookie (coverity).
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-30 11:10:15 +09:00
Jacek Caban 9a85a84765 wininet: Fixed leak in HTTP_DealWithProxy (coverity).
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-30 11:10:12 +09:00
Sebastian Lackner ff1fb7f51c wininet: Initialize user_len before GetUserNameW call.
Fixes a regression introduced by 441347f084.

Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Jacek Caban<jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-21 00:53:52 +09:00
Jacek Caban b72c2e85b4 wininet: Return NULL instead of FALSE in get_proxy_autoconfig_url.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-21 00:53:51 +09:00
Jacek Caban 441347f084 wininet: Store cookie URL in cookie_container_t.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-19 11:57:59 +09:00
Jacek Caban e73f5782ff wininet: Moved more redirect URL handling to a helper function and get rid of its maximum size assumption.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-19 11:57:57 +09:00
Jacek Caban 5141c911ff wininet: Don't assume maximal URL length in HTTP_GetRedirectURL.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-19 11:57:55 +09:00
Jacek Caban 216474c24e wininet: Use compose_request_url in INTERNET_OPTION_URL implementation.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-19 11:57:52 +09:00
Jacek Caban 453e0e1112 wininet: Don't use host header in compose_request_url.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-19 11:57:45 +09:00
Jacek Caban 7528f4d533 wininet: Use scheme id instead of string in HTTP_HandleRedirect.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-19 11:57:41 +09:00
Jacek Caban 228c06086a wininet: Get rid of INTERNET_INVALID_PORT_NUMBER fixups after InternetCrackUrl calls.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-18 10:34:10 +09:00
Jacek Caban dfa014a572 wininet: Don't assume maximum URL length in HTTP_DealWithProxy.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-18 10:34:08 +09:00
Jacek Caban 3413d01764 wininet: Pass host name as substring to get_server.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-18 10:34:06 +09:00
Jacek Caban bd1f39ea27 wininet: Don't assume maximal URL length in HTTP_ShouldBypassProxy.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-18 10:34:04 +09:00
Jacek Caban 1d5670c7c4 wininet: Removed maximum URL length assumption from get_proxy_autoconfig_url.
Also use correct encoding.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-18 10:34:01 +09:00
Jacek Caban 7d541b3fd3 wininet: Include config.h in internet.c for Mac configure macros.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-18 10:33:59 +09:00
Jacek Caban e0e0b6b7c6 wininet: Initialize url_w in InternetCrackUrlA.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-18 10:33:57 +09:00
Jacek Caban 41e45509b6 wininet: Don't assume maximal URL length in INTERNET_InternetOpenUrlW.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-18 10:33:55 +09:00
Jacek Caban 9e497aeca2 wininet: Added test of request with a long URL.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-18 10:33:53 +09:00
Jacek Caban 4227dfaa94 wininet: Store request URL in req_file_t.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-18 10:33:50 +09:00
Jacek Caban ce4bdcd0c1 wininet: Rewrite test_accept_encoding using more generic request.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-18 10:33:47 +09:00
Jacek Caban 238a462d2b wininet: Added test of cookies with long URL.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-17 11:51:33 +09:00
Jacek Caban 8264e2de94 wininet: Rerite COOKIE_crackUrlSimple to use substrings.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-17 11:51:29 +09:00
Jacek Caban 18a31e49bc wininet: Pass arguments as substrings to set_cookie.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-17 11:51:24 +09:00
Jacek Caban 8fe7be58ea wininet: Added IsDomainLegalCookieDomainW helper with substrings as arguments.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-17 11:51:19 +09:00
Jacek Caban 4f39a2dbb3 wininet: Pass arguments as substrings to get_cookie.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-17 11:51:15 +09:00
Jacek Caban b6f64a468d wininet: Pass arguments as substrings to load_persistent_cookie.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-17 11:51:11 +09:00
Jacek Caban 51cacda534 wininet: Pass arguments as substrings to create_cookie_url.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-17 11:51:07 +09:00
Jacek Caban b1aa9bf807 wininet: Pass arguments as substrings to get_cookie_container.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-17 11:51:03 +09:00
Jacek Caban 5b98186abf wininet: Pass domain to get_cookie_domain as a substring.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-17 11:50:58 +09:00
Jacek Caban f70c9ae8d1 wininet: Fixed handing NULL buffer in InternetReadFileExW.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-17 11:50:53 +09:00
Jacek Caban cebb5d3066 wininet: Fixed internet tests on win10.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-17 11:50:50 +09:00
Sebastian Lackner a3a572beb0 wininet: Return synchronously from InternetReadFile if there is no more data to read.
Similar to 87fffa1ebf.

Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-17 11:49:50 +09:00
Jacek Caban f5c97b5060 wininet: Added open_simple_request helper and use it where appropriate.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-14 14:39:56 +09:00
Jacek Caban 1d834438ca wininet: Get rid of test_http1_1 test.
I can only guess what author meant to test, but those are useless in
their current shape and we already have better persistent connection
tests anyway.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-14 14:39:55 +09:00
Jacek Caban f4e68eef37 wininet: Fixed http tests on win10.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-14 14:39:55 +09:00
Jacek Caban f6714f3832 wininet: Updated winehq.org cert info.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-14 14:39:55 +09:00
Jacek Caban e68e03c72a wininet/tests: Added IRD_NO_WAIT flag tests.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-05 01:27:52 +09:00
Jacek Caban 9e08c55187 wininet: Added support for IRF_NO_WAIT flag.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-05 01:27:52 +09:00
Jacek Caban 87fffa1ebf wininet: Return synchronously from InternetReadFileEx if there is no more data to read.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-05 01:27:51 +09:00
Sebastian Lackner 179137c259 wininet/tests: Add tests for asynchronous InternetReadFile.
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-29 00:54:13 +09:00
Michael Müller 221590213e wininet: Handle async mode in HTTPREQ_ReadFile.
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-29 00:54:13 +09:00
Sebastian Lackner 45459965aa wininet: Send INTERNET_STATUS_RESPONSE_RECEIVED notification in async handler.
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-29 00:54:13 +09:00
Sebastian Lackner e14f2c0b7a wininet/tests: Add tests for asynchronous InternetReadFileEx.
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-29 00:54:12 +09:00
Michael Müller d332ff7445 wininet: Fix async check in HTTPREQ_ReadFileEx.
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-29 00:54:12 +09:00
Jacek Caban 8e2586db52 wininet: Don't use INTERNET_MAX_HOST_NAME_LENGTH in InternetCheckConnectionW.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-28 12:41:17 +09:00
Jacek Caban e0c7741d22 wininet: Don't use INTERNET_MAX_* macros in parse_proxy_url.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-28 12:41:15 +09:00
Jacek Caban 72f5c3f2e7 wininet: Don't use INTERNET_MAX_HOST_NAME_LENGTH in InternetGetSecurityInfoByURLW,.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-28 12:41:12 +09:00
Jacek Caban 4be4e282b7 wininet/tests: Added tests of InternetCrackUrl with URLs longer than INTERNET_MAX_URL_LENGTH.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-27 23:59:10 +09:00
Jacek Caban f1a8c8ae0a wininet: Rewrite InternetCrackUrlA to properly handle errors.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-27 23:58:53 +09:00
Jacek Caban 82d413d96d wininet: Use heap_strndupAtoW in InternetOpenUrlA.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-27 23:58:12 +09:00
Jacek Caban d282a64280 wininet: Added new heap_strndupAtoW helper and use it in HttpAddRequestHeadersA.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-27 23:57:44 +09:00
Jacek Caban 41f69916c0 wininet: Fixed handling too small buffers in InternetCrackUrlW.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-27 23:56:04 +09:00
Jacek Caban 40992ee873 wininet: Simplify handling ICU_DECODE in InternetCrackUrlW.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-27 23:55:28 +09:00
Michael Müller 05a10d5fc8 wininet/tests: Add more tests for INTERNET_INVALID_PORT_NUMBER.
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-27 19:42:27 +09:00
Sebastian Lackner 076189c762 wininet: Remove unused 'sync' argument from HTTPREQ_Read.
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-22 21:04:37 +09:00
Alistair Leslie-Hughes 5ee82583f7 wininet: Free socket when connection is freed.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-12 12:03:17 +09:00
Alexandre Julliard 61d1c95ea4 wininet/tests: Remove todo from a succeeding test.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-18 02:03:22 +09:00