Commit Graph

670 Commits

Author SHA1 Message Date
Dmitry Timoshkov 40fddf7c1b Do not notify parent of the Edit control on WM_SETTEXT when Edit is
part of the ComboBox.
2001-01-26 20:37:18 +00:00
Patrik Stridvall 0c61028734 Documentation ordinal fixes. 2001-01-25 22:22:21 +00:00
Alexandre Julliard c1d35ccd9b Use DrawFrameControl() instead of OEM bitmaps to paint caption buttons
and menu check marks.
2001-01-24 19:47:57 +00:00
Dmitry Timoshkov 9c446a13cd Protect read-only edit control from modification. 2001-01-22 19:28:27 +00:00
Francois Gouget 05fc3cdf9a Typo fixes in comments. 2001-01-22 02:22:26 +00:00
Josh DuBois d661dbdd6c Specified 'signed' on chars compared to -1. 2001-01-19 20:51:44 +00:00
Dmitry Timoshkov a234db82eb Solve remaining problems with scroll bars in the edit control. 2001-01-19 20:49:54 +00:00
Dmitry Timoshkov df793bcb68 Add one missing buffer size rounding in the edit control.
Make rounding code slightly more readable.
2001-01-15 20:20:31 +00:00
Alexandre Julliard a41b2cfdd0 Moved tweak support to USER dll. Removed tweak.h and cache.h. 2001-01-15 20:12:55 +00:00
James Hatheway f3ea345b2d Guard against incoming string of NULL in WM_SETTEXT. 2001-01-12 23:01:41 +00:00
Dmitry Timoshkov 785203ced8 Fix the return value of WM_GETTEXT in the edit control. 2001-01-11 20:17:21 +00:00
Dmitry Timoshkov 376beadaaa Various combobox fixes. 2001-01-11 20:17:07 +00:00
Dmitry Timoshkov f77709ea19 Synchronize the sizes of the external and internal buffers at start
and end of message processing in the edit control.
2001-01-10 23:55:02 +00:00
Gerard Patel db8fb6f387 Fixed returned length for LB_GETTEXT. 2001-01-10 23:54:46 +00:00
James Hatheway ba9b96457d es->buffer_size is not always the length of the text currently in the
editbox, so use -1 instead.
2001-01-10 22:54:33 +00:00
Dmitry Timoshkov 7462099847 Added unicode window proc for the listbox control.
Replaced all ansi calls by their unicode equivalents.
Removed use of the custom local heap.
2001-01-09 21:51:04 +00:00
Ulrich Czekalla b3da1ac0cd Ensure there is an edit control when we reset contents. 2001-01-09 20:49:53 +00:00
Dmitry Timoshkov 4866ac0859 Combobox should clear its current selection on response to
CB_SETCURSEL(-1) message.
2001-01-07 21:43:49 +00:00
François Gouget 75b278e9dd Modify the look of bitmap menu items to match Win95 and Win98
Fix the sunken edge/bitmap overlap in the Win98 look
Introduce an IS_MAGIC_ITEM macro to test if the item is 'magic'
2001-01-06 01:45:51 +00:00
Andreas Mohr 85ba8798b5 Took a stab at implementing LBS_NOSEL. 2001-01-06 00:34:14 +00:00
Dmitry Timoshkov f5f9f2cc51 Added unicode window proc for combobox control.
Replaced ansi calls by their unicode equivalents.
2001-01-05 22:21:18 +00:00
Dmitry Timoshkov 009c1f8005 Added unicode window proc for the static control.
Replaced ansi calls by their unicode equivalents.
2001-01-05 22:20:57 +00:00
Dmitry Timoshkov 11dbda6bf9 Fixed some problems with scrolling in the edit control. 2001-01-05 03:40:35 +00:00
Francois Gouget 5818240965 Fixed the alignment of the MF_RIGHTJUSTIFY menu items. 2001-01-04 20:56:43 +00:00
Aric Stewart fe9a0f0977 Fixed a problem where when deleting an item using index -1 on an empty
listbox we would pass through an illegal negative index and cause
problems.
2001-01-04 19:27:03 +00:00
Andreas Mohr a6d83ebae1 - clarify many error messages
- add data corruption warning to README file
2000-12-27 04:02:46 +00:00
Dmitry Timoshkov 366c0a16a5 Fix remaining signed/unsigned mismatches. 2000-12-22 20:28:05 +00:00
Alexandre Julliard 5801723b50 Replaced WIN16_GlobalLock16 by "official" function K32WOWGlobalLock16. 2000-12-22 01:09:26 +00:00
Dmitry Timoshkov 8058ead8ea Don't write to buffer with zero length.
Removed some unused function parameters.
2000-12-21 20:19:21 +00:00
Dmitry Timoshkov f8b96e272a Make new edit control allocate its buffers with granularity 32 byte.
Ensure that all copied strings are 0 terminated.
2000-12-20 18:39:14 +00:00
Dmitry Timoshkov 4e62b9df8b New unicode edit control. 2000-12-19 19:36:49 +00:00
François Gouget 44a182229b winuser.h now requires that we include winbase.h first. 2000-12-19 04:53:20 +00:00
Ulrich Czekalla 7c55bc0cd6 Only capture mouse when an item is selected. 2000-12-15 22:58:25 +00:00
Louis Philippe Gagnon 956c847f49 Invalidate the focus rect when a listbox is resized. 2000-12-13 21:26:45 +00:00
Alexandre Julliard 982a223f36 Replaced PTR_SEG_TO_LIN macro by exported MapSL function.
Fixed a few ptr/segptr mismatches.
Moved CONV_RECT/POINT macros to wingdi16.h.
2000-12-13 20:20:09 +00:00
Alexandre Julliard bf67259a41 Use the DRIVE_* API constants instead of the DRIVETYPE enum.
Changed DRIVE_CANNOTDETERMINE and DRIVE_DOESNOTEXIST to use the
correct names.
Cleaned up a few dependencies on internal drive.c functions.
2000-12-12 00:44:42 +00:00
Alexandre Julliard 91222da881 Moved most builtin controls structures into their respective C file.
Created new controls.h file private to user32.dll and moved remaining
builtin controls definitions there.
2000-12-10 23:01:33 +00:00
Alexandre Julliard 9877906b26 Removed dependencies on the internals of the CLASS structure.
Added support for having both ASCII and Unicode window procedures for
builtin classes.
2000-12-07 23:39:16 +00:00
Louis Philippe Gagnon cef7c7af61 Update internal controls on WM_WINDOWPOSCHANGED. 2000-12-06 03:21:57 +00:00
Aric Stewart 6213ab3a89 Fixed a problem where the string in a combo box flickers if you
rapidly reset the content and then replace the content.
2000-12-05 21:12:05 +00:00
Patrik Stridvall 2b3aa616e8 Added/modified documentation for function arguments. 2000-12-01 23:58:28 +00:00
Louis Philippe Gagnon 537bcadf55 Don't update scrollbars when processing WM_DESTROY. 2000-11-30 20:37:29 +00:00
Andreas Mohr 94a6832b04 WM_SETTEXT should return TRUE on success. 2000-11-29 00:02:46 +00:00
Dmitry Timoshkov 2b4be4be93 Made button control fully unicode aware. 2000-11-28 23:51:48 +00:00
Alexandre Julliard 24a62ab9b0 Got rid of the Wine internal lstrcpy* functions and of winestring.h. 2000-11-28 22:40:56 +00:00
Dimitrie O. Paun 529da54394 Require {DECLARE,DEFAULT}_DEBUG_CHANNEL statements to end in a ; 2000-11-27 23:54:25 +00:00
Louis Philippe Gagnon 9cdd22c53d When processing mouse messages in MENU_TrackMenu, use the coordinates
in lParam instead of those in MSG::pt.
2000-11-27 22:39:35 +00:00
Alexandre Julliard 2682bc24ca Fixed a few dependencies on 16-bit or internal functions. Fixed a few
warnings.
2000-11-27 22:03:23 +00:00
Alexandre Julliard ac7efef3b5 Changed GetProcAddress16 and 16-bit resource functions to take normal
pointers instead of SEGPTRs.
Removed WIN16_GetTempDrive.
2000-11-27 21:54:01 +00:00
Dmitry Timoshkov 7a947b34b7 General clean up of the edit control: removed transfer of unused
variables, fixed signed/unsigned mismatches.
2000-11-27 01:34:25 +00:00
Chris Morgan cbbc7c3d60 Don't draw scrollbars if their client rectangle is empty. 2000-11-26 22:36:53 +00:00
Ove Kaaven 2c691b31ce Implemented Win16 behaviour of DDL_DRIVES in DlgDirList. 2000-11-25 03:06:03 +00:00
Dmitry Timoshkov 9308f640c1 Prepare switching to unicode of builtin widgets. 2000-11-15 23:05:52 +00:00
Joerg Mayer abe635cfd7 Get rid of some warnings about unused variables, signed/unsigned
comparisons and incomplete initializations.
2000-11-11 00:38:37 +00:00
Francois Gouget 0c247ec775 Fixed typos in comments. 2000-11-07 20:30:50 +00:00
Francois Gouget 75f9e647aa Take into account the sunken border for Win98 look.
Leave a 1 pixel gap to the left of menu bitmap items for symetry (and
because Win9x does it).
Leave a 1 pixel gap above menu bar items for symetry (and because
Win9x does it).
2000-11-06 05:25:29 +00:00
James Abbatiello 606f6203d4 Don't reset MF_POPUP flag in SetMenu(). 2000-11-05 03:18:11 +00:00
Dmitry Timoshkov d5e15d3be1 Do not invert "magic" bitmap menu items. 2000-11-02 20:08:34 +00:00
Alexandre Julliard 908464d448 Authors: Andreas Mohr <amohr@codeweavers.com>, Dimitrie O. Paun <dimi@cs.toronto.edu>, Patrik Stridvall <ps@leissner.se>
Various warning fixes.
2000-11-01 03:11:12 +00:00
Dmitry Timoshkov d0ff2ec08b Make bitmap menu items look like in windows when selected,
i.e. inverted and hilited (in Win98 look).
2000-11-01 02:11:41 +00:00
Francois Gouget e3810e3acc Check for SB_CTL before displaying a caret. 2000-11-01 01:52:37 +00:00
Francois Gouget eecb40ec43 Hide the caret only on the first WM_KEYDOWN. 2000-10-31 01:03:15 +00:00
Andreas Mohr 45c9fd892f - set the item height not only for the listbox, but also for the text field
- center text vertically
- beautify comments
2000-10-28 00:29:58 +00:00
Dmitry Timoshkov ef55932f4b Ask application to reinitialize its menu before processing an
accelerator key.
2000-10-26 21:47:20 +00:00
Francois Methot 9a58351fda Added support of blinking thumb as found in Windows scrollbar. 2000-10-25 21:26:27 +00:00
Aric Stewart c946b1cccd Converted menu string handling to Unicode. 2000-10-24 21:28:19 +00:00
Susan Farley a4251bbe4c Do not block CBN_EDITCHANGE for WM_PASTE or WM_CUT with the
NOEDITNOTIFY flag, as these msgs can come directly from the app to the
combo wndproc.
2000-10-24 01:38:49 +00:00
Ulrich Weigand 6bfbc3d23e Do not send EN_UPDATE to multi-line edit controls. 2000-10-23 00:38:10 +00:00
Francois Gouget 93fd46af54 Fixed the text color of higlighted menu bar item for the Win98 look.
Clicking on a separator should not close the menu.
Do not right align 'bitmap' items and the help menu for the Win9x look
and feels.
2000-10-23 00:37:49 +00:00
Alexandre Julliard 15bfcd0398 Moved $(MODULE).o rule out of Make.rules into the individual
Makefiles.
2000-09-29 00:28:25 +00:00
Alexandre Julliard 83f52d11c1 Moved all Win16 definitions out of the standard Windows headers. 2000-09-26 22:20:14 +00:00
Alexandre Julliard 072dfb57e3 Removed inclusion of wine/winestring.h from winbase.h and added it to
the C files that need it.
2000-09-25 23:30:56 +00:00
Gerard Patel 8caa407c05 In WM_DRAWITEM, always calls the app with a valid current focus_item. 2000-09-24 19:29:18 +00:00
Andreas Mohr 6f07e8abbc Fixed window lock problem in SetMenu(). 2000-09-19 02:38:11 +00:00
Serge Ivanov 6117fc4165 (Merged by Marcus Meissner <marcus@jet.franken.de>)
Fixed problem with origin for DST_COMPLEX style.
Fixed handling of DSS_DISABLED and DSS_DEFAULT styles.

Added handling of BS_MULTILINE style, label alignment
styles (BS_RIGHT, etc.) and some exotic styles BS_FLAT (only
pushbuttons for now), and BS_PUSHLIKE.

Modified label drawing procedure: now all kinds of buttons
use common BUTTON_DrawLabel function. Actual label drawing is
performed by DrawStateW function.

GroupBox must use WM_CTLCOLORSTATIC instead of WM_CTLCOLORBTN message.
2000-09-13 00:00:55 +00:00
Gerard Patel ed66930518 SetScrollInfo : don't show/hide scrollbar if no parameter (minval,
maxval) change.
2000-09-12 23:59:10 +00:00
Andreas Mohr 20cd9356a8 - fixes debugger output
- get rid of wrong comments
- fix comments
- .spec spelling fix
- improve warning message
2000-09-12 23:40:40 +00:00
Mike McCormack 5ae1c396cc Avoid divide by zero when listbox set to zero height. 2000-09-09 19:39:24 +00:00
Dmitry Timoshkov fbb2c9bdf8 GetMenu might be used to get child window id. 2000-09-09 19:38:34 +00:00
Andreas Mohr 2b5d9c6e50 Always call LISTVIEW_SetSelection() for an item, even if that item
has been selected before, in order to let other items get erased.
2000-08-29 03:52:16 +00:00
Susan Farley 597cb552ce Update the edit box before rolling up the listbox, so the
selection isn't lost.
2000-08-14 17:18:49 +00:00
Alexandre Julliard c7e7df8b17 Replaced all lstr* calls from inside Wine code by their str* equivalent. 2000-08-14 14:41:19 +00:00
Alexandre Julliard 198746d812 Replaced global Callbacks structure by appropriate glue code
generation. Removed a few unused entries in the Callout structure.
2000-08-14 14:29:22 +00:00
Alexandre Julliard 42d20f9dca Merged clipboard driver into USER driver.
Moved all ttydrv source files to dlls/ttydrv.
Load functions pointer for the USER driver from the graphics driver
dll with GetProcAddress.
2000-08-10 01:16:19 +00:00
Alexandre Julliard 5ab9d860f2 Removed some unnecessary #includes and dll dependencies. 2000-08-09 22:35:05 +00:00
Marcus Meissner c4fac7867e Initialize 'str' in ICONTITLE_GetTitlePos. 2000-08-07 23:51:02 +00:00
Susan Farley dbf5a4792c Avoid resetting the background color when clearing out blank areas, as
it may have been set to something other than COLOR_WINDOW by the
application.
2000-08-06 03:35:52 +00:00
Alexandre Julliard cb10fdab99 Replaced lstrlen/lstrcmp by libc equivalents everywhere we don't need
to trap exceptions.
2000-08-06 02:41:16 +00:00
Alexandre Julliard b0efe28f6c Removed a few dependencies on GDI internals from USER dll. 2000-08-04 04:18:04 +00:00
Gerard Patel cef12530eb Change logic of listbox resizing for 16 bits apps for lists without
LBS_NOINTEGRALHEIGHT style.
2000-08-01 20:48:40 +00:00
Ove Kaaven 690142dc5b Fix a few typos and such. 2000-07-23 13:43:00 +00:00
Gerard Patel 9fe0e634e5 Fixed calculation of buffer length after switch of window text to
unicode.
2000-07-23 13:33:48 +00:00
Gerard Patel 9788ba6e54 Set clipping region to client window before owner-drawn painting. 2000-07-16 15:39:37 +00:00
Gerard Patel 0e805aa358 Background of SS_SIMPLE static control is not filled (unless it has
SS_NOPREFIX too).
2000-07-16 14:39:21 +00:00
Dave Hawkes fcd352152f All standard window controls should have CS_PARENTDC, but should still
clip to the control window.
2000-07-15 21:31:42 +00:00
Susan Farley 7251640113 Don't clear selection when initial entry is not in the list. 2000-07-15 21:27:32 +00:00
Marcus Meissner 235d39cf9e Replaced %s by %p in EDIT_WM_SetText. 2000-07-15 15:12:38 +00:00
Dmitry Timoshkov 04da8b8f28 Convert WND.text field to Unicode.
Add new key to wine.ini in the section [x11drv] - TextCP, which means
code page used for texts passed to X.
Accordingly fix handlers of WM_SETTEXT/WM_GETTEXT.
2000-07-10 12:09:31 +00:00
Gerard Patel 2ffbb31e3a Make the focus follow the last selected item for multiselect listboxes. 2000-07-09 12:18:14 +00:00
Gerard Patel d292234835 Set the minimum dropped height to the combo list height if any in
CBDropDown.
2000-06-25 12:47:59 +00:00
Gerard Patel c9e6031dca CB_SETCURSEL should not generate another listbox event after updating
the edit box.
2000-06-18 17:20:37 +00:00
Francois Jacques 20af4c3c87 GetSystemMenu called with bRevert argument set to TRUE now returns
NULL as specified in Platform SDK.
2000-06-18 17:17:54 +00:00
Gerard Patel ac3e81640a Set clipping region to client window in LISTBOX_Paint. 2000-06-15 00:58:42 +00:00
Gerard Patel 41b07fb4d9 WM_SETREDRAW should repaint the listbox when set to on if something
has been changed.
2000-06-15 00:07:20 +00:00
Jason Mawdsley 50523d164f Take focus before setting the caret position and selections. 2000-06-11 20:34:07 +00:00
Sheri Steeves 13ffd58a1f Added save and reset of SetBKMode values in WM_PAINT.
Added handling of lParam value in BM_SETSTYLE.
2000-06-11 20:08:46 +00:00
Huw D M Davies d552d98b51 Add support for icons set by STM_SETIMAGE. 2000-06-11 20:00:33 +00:00
Serge Ivanov 9926d33450 - ComboLBox is always created as child of ComboBox. If ComboBox has style
other than CBS_SIMPLE, parent of listbox is set to desktop.
- In CBDropDown. ComboBox uses only first item to calculate height of
  dropped listbox. Also if listbox is empty its height is unmodified
  (previously it was set to 0).
- Added correct handling of WM_GETDLGCODE and WM_(SYS)KEYDOWN messages.
- General clean-up. Message order is now more precise (at least
  notifications to client); listbox - combobox interaction has slight
  differences comparing to Windows.
2000-06-07 03:48:02 +00:00
Serge Ivanov 9eedcf5852 - Removed dependency of edit control from combobox implementation.
- Edit control uses undocumented window style 0x0200 to detect is it a part
  of combobox. If so it calls GetDlgItem(hwndCombo, 1000) to get ComboLBox
  window handle (see comments for combo.c below).
- EDIT_CheckCombo - modified for correct handling of keyboard messages.
- Processing of WM_GETDLGCODE and WM_CHAR for VK_RETURN and VK_ESCAPE
  depends on whether listbox is dropped down. This prevents closing of dialog
  if listbox is dropped down and allows combobox to process these keyboard
  messages properly.
2000-06-07 03:47:34 +00:00
Serge Ivanov 07917e40e8 - We can use wnd->wIDmenu for ComboLBox (it is not reset anymore in SetParent)
- When user clicks outside of dropped listbox, original selection must be
  restored.
- ComboLBox has caret_on = FALSE on creation, that's why combobox sends
  LB_CARETON message before dropping listbox down (but only for
  CBS_DROPDOWNLIST - I don't now why).
2000-06-07 03:46:57 +00:00
Alexandre Julliard 72bdd5bee7 Stephane Lussier
Sheri Steeves
Haithem Hmida
- Height of the listbox should be adjust when LBS_OWNERDRAWFIXED is set
  and not if LBS_OWNERDRAWVARIABLE is set, previously it was not adjusting
  the size in both cases.
- When the caret index change, items repainting need tp be in this
  order
  a) Paint old caret item without the focus
  b) Paint old caret item without the selection
  c) Paint new caret item with the selection
  d) Paint new caret item with the focus.
- When repainting the listbox, we should paint all items regarding if
  they are slected or not and then paint after the focus item. So focus
  item will end out being painted twice. (That's what Windows does).
2000-06-07 03:17:35 +00:00
Susan Farley b09c6ef5ae Attempt to paint the checkbox and radio buttons better. 2000-06-04 01:32:59 +00:00
Andreas Mohr 2e011a5243 Lots of spelling fixes that accumulated in my tree again, made several
error msgs more verbose, doc updates.
2000-06-01 23:28:25 +00:00
Alexandre Julliard 207f7019e6 Louis-Philippe Gagnon (of Macadamian for Corel)
Static controls weren't receiving WM_LBUTTONDBLCLK messages because the
Static window class was registered without the CS_DBLCLKS style (which it
has in Windows).
2000-06-01 23:15:49 +00:00
Serge Ivanov bfe15b12ad MSDN: "WM_NCHITTEST - Returns HTCLIENT if the control style is
SS_NOTIFY; otherwise, returns HTTRANSPARENT. "
2000-06-01 22:46:51 +00:00
Alexandre Julliard d566a0e309 Serge Ivanov
Returning DLGC_WANTALLKEYS for multiline edit control was not good because
it breaks navigation in dialogs.
2000-05-30 20:50:09 +00:00
David Grant 8a92213111 - Creating combobox with CBS_SIMPLE style shall set internal flag CBF_EDIT.
- Edit text must be selected only if CB is in focus.
- If CB has edit control we have to call CBUpdateEdit to update its
  contents. Invalidating textRect will not force updating of child
  edit control, obviously.
- We have to protect ourselves from changing selection in listbox when
  we receive listbox notification. So LBN_SELCHANGE -> CBUpdateEdit ->
  EN_CHANGE will not reselect item in the lisbox.
2000-05-30 17:48:33 +00:00
Alexandre Julliard dcc175de6a Owen Wang
When you click on an icon to open a combo box, you would expect it to
be enabled so you can choose something in it. In Wine this was not
guaranteed since your default flags could get lost in the process-heap
of the application.
2000-05-30 15:28:06 +00:00
Alexandre Julliard ab2f43f99b Serge Ivanov
- Added handling of WM_MOUSEACTIVATE message
- Added in_focus field to internal listbox's structure. This flag is set on
  receiving WM_SETFOCUS message and is reseted on WM_KILLFOCUS. All calls to
  GetFocus function were replaced with checks of this flag.
- In LISTBOX_HandleLButtonDown: focus is set only if 'in_focus' flag is
  clear
2000-05-26 22:28:34 +00:00
Alexandre Julliard fa2c79398d Henning Hoffmann
Don't send EN_CHANGE after painting the edit.
Send it wherever text is changed.
2000-05-26 01:24:56 +00:00
Ulrich Czekalla 70d5a95236 Moved the EN_UPDATE notification out of the paint handler. Instead,
the notification is sent when an InvalidateRect is made after
modifying the text.
2000-05-26 01:17:34 +00:00
Alexandre Julliard c616625945 Louis-Philippe Gagnon (of Macadamian Technologies for Corel)
Added event handler for WM_MBUTTONDOWN (sends WM_PASTE message).
2000-05-25 23:01:39 +00:00
Rob Farnum b200793de4 Post a WM_CANCELMODE message to wake up the internal menu handling
code. This fixes the problem of a menu being orphaned when the parent
window disappears, or if the parent loses focus.
2000-05-23 23:34:17 +00:00
Ulrich Czekalla c804e3eac4 Capture ^V,^X,^C and translate it to the corresponding message for
paste, cut, copy.
2000-05-23 21:16:07 +00:00
Alexandre Julliard 7f90a8c900 Serge Ivanov
Fixed WM_LBUTTONDBLCLK handling.
2000-05-23 04:18:12 +00:00
Andreas Mohr a8edb3e461 Some part of EDIT_EM_LineLength code was commented (broken). Restored
the capability to calculate the remaining non-selected chars of a
selection area.
2000-05-23 04:05:05 +00:00
Alexandre Julliard f5d4244f71 Sheri Steeves
The edit is now detected correctly if the parent is a combo box. It
wasn't working when the combobox was superclassed.
2000-05-18 00:16:53 +00:00
Susan Farley d34205ef94 Avoid calls to SetFocus when they are unnecessary. 2000-05-15 02:34:20 +00:00
Gerard Patel c6369b0bd7 When new menu Id is not found or index > nitems, insert the new menu
at end of current menu.
2000-05-14 22:52:52 +00:00
Susan Farley f1d467a337 Distinguish RADIOCHECK style menu items from standard checkmark menu
items.
2000-05-12 21:59:31 +00:00
Susan Farley b64aa2460e Like the AUTORADIOBUTTON, the parent of a RADIOBUTTON style button
should be sent a BN_CLICKED when it receives the focus.
2000-05-12 21:51:09 +00:00
Guy Albertelli f12b70addb Revalidate menu handle in mt.hTopMenu after DispatchMessage. 2000-05-11 00:06:11 +00:00
Aric Stewart 70cc169d1c - Wine was passing the wrong hwnd as the owner when processing owner
drawn menubars.
- When doing MENU_CalcItemSize for the menu bar we were not properly
  padding the returned rect.
2000-05-10 21:54:07 +00:00
Ken Thomases 130f0d88c1 Fixed to display popup-menu arrow on owner-drawn popup menus.
Fixed positioning of submenus relative to parent menus.
2000-05-10 21:38:37 +00:00
Chris Morgan c0872e3119 Fixed scrolling bug. 2000-05-07 18:24:36 +00:00
Susan Farley 86d0b031bb Handle ^C, ^V and ^X in an edit control properly. 2000-05-05 18:21:02 +00:00
Ove Kaaven b4018e7a57 Fix edit control's WM_GETTEXT behaviour. 2000-04-23 19:59:11 +00:00
Stephane Lussier 4bdf4af11e Implemented Mousewheel support. 2000-04-18 11:56:33 +00:00
Patrik Stridvall 2d6457c11a Added/fixed some documentation reported by winapi_check. 2000-03-28 20:22:59 +00:00
Francois Gouget 6d77d3a1df Use min/max instead of MIN/MAX. 2000-03-25 21:44:35 +00:00
Huw D M Davies 65a0fa6e4e Send the correct ODA_ code when deselecting an item. 2000-03-25 21:41:17 +00:00
Alexandre Julliard 7f3418fba0 Store monitor size and depth in the generic structure.
Merged monitor driver into USER driver.
2000-03-25 17:30:13 +00:00
Huw D M Davies 2d6eabacc3 Set the correct value for the cch element of MENUITEMINFO in
GetMenuItemInfo.
2000-03-24 19:48:53 +00:00
Huw D M Davies 2e34030a02 Stop a WM_SETTEXT message (and friends) to a combo sending CBN_EDIT*
messages to the parent.
2000-03-24 19:44:39 +00:00
Alexandre Julliard 28c3a1baf3 Moved graphics initialisation to the x11drv/ttydrv dll init code.
Merged event, keyboard and mouse drivers into USER driver.
2000-03-20 18:21:19 +00:00
Patrik Stridvall 6cc47d4924 Removed a lot of unnecessary includes and fixed the compile errors. 2000-03-08 18:26:56 +00:00
Ulrich Czekalla 60b1c38e86 The static control only needs to invalidate its rect when we SetText. 2000-03-08 18:22:51 +00:00
Ulrich Czekalla 33026a2a6e Send WM_HELP message when F1 is pressed. 2000-02-26 19:13:44 +00:00
Yuxi Zhang f94c3c55c1 In the listbox, when the last item is selected and deleted, it still
appeared in the window.

Sheri Steeves <sheri@macadamian.com>
In LISTBOX_UpdateScroll(), if the listbox did not have the WS_SCROLL
style it would just return.  This left the horizontal scroll bar
uninitialized and it was appearing at the bottom of the listbox when
it did not have to.

Serge Ivanov <sergei@corel.com>
LISTBOX_SetColumnWidth adds extra 2 pixels to the passed column width
(it says it is for column margins). Obviously it is wrong, because
margins must be internal.
2000-02-26 19:13:12 +00:00
Bill Jin 4f155e88bc Bitmap buttons were not refreshed correctly. 2000-02-26 18:29:15 +00:00
Alexandre Julliard 916f975624 Improved the selector get/set functions.
Support ANSI-compatible inline asm (with the help of Patrik Stridvall).
2000-02-26 16:51:13 +00:00
Jeremy White d3e22d9d55 Removed #include of wingdi.h and windef.h from winuser.h (and resolved
the resulting compilation failures).
2000-02-10 19:03:02 +00:00
Luc Tourangeau e84b678408 Implementation of Static OwnerDraw. 2000-02-07 16:01:04 +00:00
Alexandre Julliard b2f6f0e7d2 Removed resource.h. 2000-02-03 01:54:36 +00:00
Dmitry Timoshkov 6fb62f52f5 Correct the behaviour of the accelerator keys in dialogs according to
the Windows' one.
2000-01-29 22:09:40 +00:00
Gerard Patel 3e629748cf Validate the menu handles. 2000-01-17 22:22:16 +00:00
Pascal Lessard ae6de763e9 Stop menu tracking when clicking on the menu bar where there is no
menu item.
2000-01-09 02:38:02 +00:00
Marcus Meissner cb3c7bfa70 GetMenuString should return itemlength on 0 nMax or NULL str
InsertItem pos=-1, flags = 0 should append item
(thanks to Sander van Leeuwen)
2000-01-08 22:25:57 +00:00
Rein Klazes e8256f589f Don't show the scrollbar if SetScrollinfo() is called with only the
SIF_DISABLENOSCROLL flag.
2000-01-04 00:28:55 +00:00
Dmitry Timoshkov cd207587ec ComboBox should not send bogus messages to edit buddy and to itself. 1999-12-12 20:47:45 +00:00
Rein Klazes 80c924f1f4 In win32 a WM_MENUSELECT message should contain the position when the
item refers to a submenu, not the submenu's handle as in win16.
1999-12-12 19:40:46 +00:00
Marcus Meissner ed0da3f66c Removed 2 useless include winversion.h
Do not make autodetected version fix on first calls if it is Win31.
1999-12-12 00:44:06 +00:00
Ulrich Weigand 2faf2cf964 Perform 16/32A/32W message mapping for posted messages. 1999-12-10 03:47:13 +00:00
Dimitrie O. Paun dd03cc19fd Make use of the DEFAULT_DEBUG_CHANNEL where appropriate.
Use the default version of FIXME, ERR, WARN, TRACE for the default
channel.
1999-12-08 03:56:23 +00:00
Dmitry Timoshkov 0958a20725 Fix problem with EN_UPDATE notification sent by edit control. 1999-12-08 03:25:30 +00:00
Dmitry Timoshkov 38d04b8ff4 Allow to deselect all items by sending CB_SETCURSEL(-1) to the combo. 1999-12-06 00:57:20 +00:00
Dmitry Timoshkov f92a777007 Remove hack for keyboard messages in dialogs. 1999-12-05 23:51:15 +00:00
Dmitry Timoshkov 92f376f78b Show use of undocumented messages. 1999-12-05 02:45:10 +00:00
Dmitry Timoshkov f4a27b8d41 When combobox selection changes, update its edit box accordingly. 1999-11-28 19:45:58 +00:00
Dmitry Timoshkov e0f493e5b0 Notify parent of listbox if requested. 1999-11-28 19:44:33 +00:00
Rein Klazes 077ec0cffd Send WM_CTLCOLOREDIT not WM_CTLCOLORSTATIC messages to parent of a
disabled edit control if the application expects a windows version
before WIN95 and NT40.
1999-11-10 19:55:29 +00:00
Jim Aston aebda22e61 Fixed the height of the ComboBox drop list. 1999-11-07 21:04:57 +00:00
Karl Lessard 4a0a7df6a3 When a popupmenu is currently active on the screen, it shouldn't
remove mouse click messages that don't belong to it from the queue.
1999-11-07 05:17:10 +00:00
Marcus Meissner 2e48a2cc22 Do not clear the drawing area for etched static controls.
Replaced our own drawing stuff in etched static controls by DrawEdge.
1999-10-31 17:36:26 +00:00
Pierre Mageau 891d4d22a7 Fixed loop with WM_SYSCHAR. 1999-10-23 20:05:04 +00:00
Abey George 889a3be68f Draw the item text from the top of the item rect. 1999-10-23 17:12:24 +00:00
Gerard Patel 8c36254147 Make WM_GETTEXTLENGTH return length for dropdownlist combos. 1999-10-13 13:50:17 +00:00
Francois Boisvert 73d7337e83 Removed FillRect in the ownerdrawn button procedure. 1999-10-13 13:49:42 +00:00
Juergen Schmied 371c420549 Made TrackPopupMenu with TPM_RETURNCMD returning the id instead of
true.
1999-10-13 12:27:44 +00:00
Karl Lessard 13409b32cd Make ExecFocusedItem return -1 on failure. 1999-09-28 16:24:58 +00:00
Gerard Patel 6df0694f7c Force recalculation of menu when calling InsertMenuItem. 1999-09-28 13:05:54 +00:00
Stephane Lussier 5ca2ec4288 Return key should not be ignored in multiline edit even if
ES_WANTRETURN flag isn't set.
1999-09-27 11:45:07 +00:00
Rein Klazes 61b15de4ba Use an extra bit in the button status byte to flag whether the
DefButtonWndProc should process the WM_LBUTTONUP message.
1999-09-27 11:38:47 +00:00
Abey George b59d4bc503 Don't send WM_ENTERMENULOOP, WM_INITMENU & WM_INITMENUPOPUP messages
when TPM_NONOTIFY flag is set in TrackPopupMenu.
1999-09-22 15:10:42 +00:00
Francis Beaudet 2862362259 Fixed display bug in the static control. 1999-09-20 18:28:08 +00:00
Pascal Lessard 445c910e89 Message removed when menu tracking finish on a WM_LBUTTONDOWN. 1999-09-20 18:27:14 +00:00
Dennis Björklund 4352c7a9d0 Send correct WM_MENUSELECT when menu closes. 1999-09-19 18:28:35 +00:00
Noomen Hamza 502e4f5dc6 The MDIClient class must be registered with the IDC_ARROW cursor. 1999-09-19 14:11:41 +00:00
Francis Beaudet f132872741 Implemented the disabled state of the combobox. 1999-09-19 14:09:52 +00:00
Richard Cohen 56753621d3 Protect SetMenu from rogue menu handle.
GetMenu16 can just call GetMenu.
1999-09-19 14:08:13 +00:00
Pascal Lessard 07c447f971 Added a case for menu handling in win31. 1999-09-19 12:03:25 +00:00
Dennis Björklund 9af3ebaa7b Fixed win9x look on checkboxes and radiobuttons. 1999-09-13 16:06:17 +00:00
Eric Pouech 0c62bf064d Added MenuItemFromPoint stub. 1999-09-13 15:11:35 +00:00
Nick Holloway b9ce4fd51b For Win 3.x applications, if they have either horizontal or vertical
scrollbars, enable both.
1999-09-11 16:29:00 +00:00
Pierre Mageau 25c62cc61f Set the mouse capture on the combo listbox. 1999-09-11 16:26:03 +00:00
Abey George 3cee09c0fc Draw the focus rectangle for buttons with BS_3STATE, BS_RADIOBUTTON,
BS_CHECKBOX, BS_AUTO* styles.
1999-09-11 16:22:10 +00:00
Pascal Lessard aed79e58c7 Implemented the behavior around the ES_WANTRETURN style in the edit
control.
1999-09-10 13:58:34 +00:00
Pierre Mageau a433582363 Modified CBDropDown to find the best height of the listbox. 1999-09-05 12:12:30 +00:00
Stephane Lussier cdb5650d1e Initialize the enabling state variable in the edit. 1999-09-04 14:27:50 +00:00
Pascal Lessard 3405f5c6cd The format rect is recalculated for each font change. MoveEnd &
MoveHome improved.
1999-09-04 10:59:07 +00:00
Pascal Lessard 2eb0a302a0 Menu hides when clicked for a second time. 1999-09-03 16:38:52 +00:00
Stephane Lussier 93805344ee Keep the enable state in the edit structure instead of calling
IsWindowEnabled().
1999-09-03 16:37:00 +00:00
Francis Beaudet 49936036e6 Slight 1 pixel adjustment on the position of the radio button bitmap. 1999-09-03 15:07:21 +00:00
Pascal Lessard 6fe38e560e The backspace is now handled in the WM_CHAR message. 1999-09-03 15:02:48 +00:00
Francis Beaudet f22ff403ac Fixed a little positioning bug with the checkbox. 1999-09-03 12:35:18 +00:00
Gerard Patel 8e5c72e195 Implemented wParam of WM_PAINT msg for edit control. 1999-09-03 12:23:52 +00:00
Stephane Lussier a833f63783 Avoid changing the activation state in EnableMenuItem. 1999-08-21 14:46:06 +00:00
Rein Klazes d35c834b77 Make sure that an empty string never matches a listbox entry in
LISTBOX_FindString().
1999-08-21 13:04:58 +00:00
Eric Pouech 562309adac Fixed crash when accessing sysmenu. 1999-08-21 12:59:44 +00:00
Francis Beaudet 7ed1af3df3 Ensure that the WM_ENTERIDLE message is not sent if the wake-up event
for the MSG_InternalGetMessage() call is a WM_TIMER.
1999-08-15 16:58:03 +00:00
Pascal Lessard dde4d61f5a EM_SETSEL scrolls if outside of the visible range.
"shift+home" selection improved in the edit control.
1999-08-15 16:30:11 +00:00
Francis Beaudet 28d2ccb07c Fixed the look of the combobox's drop down button when in Win95 look. 1999-08-14 15:51:49 +00:00
Francis Beaudet 742e135446 Handle the case when the button is really small. 1999-08-07 12:26:52 +00:00
Alexandre Julliard 15de615276 Got rid of dsprintf and related macros. 1999-08-04 12:22:42 +00:00
Patrik Stridvall 0e38aa7fda Various ANSI C compability fixes. 1999-07-31 17:34:43 +00:00
Pascal Lessard d814bb657a Implemented the system button behavior and associated it to the system
menu in win95. Also permit the SC_CLOSE item to be disabled.
1999-07-31 13:02:02 +00:00
Rein Klazes dbb4ad8284 Fix handling of WM_LBUTTONDCLICK message for buttons with certain
styles.
1999-07-31 11:10:52 +00:00
Pierre Mageau cfbafe3247 Fixed a problem when the style is BS_BITMAP or BS_ICON: the bitmap or
icon needed to be centered when the button is smaller than the bitmap.
1999-07-30 18:03:15 +00:00
Francis Beaudet 06e8886ee8 Implemented proper win95 support for the WS_BORDER style. 1999-07-30 17:59:35 +00:00
Francis Beaudet f6a225b84e Changed the WS_BORDER style to a WS_EX_CLIENTEDGE style for the
listbox control.
1999-07-30 17:58:24 +00:00
Francis Beaudet bc0b020428 Fixed the border for the listbox created by the simple combobox. 1999-07-30 17:57:45 +00:00
Abey George 6e013e5c24 Fixed incorrect edit control behaviour in mouse message handling. 1999-07-27 17:08:26 +00:00
Gerard Patel c9a6d50c20 Several focus and selection problems in listboxes. 1999-07-25 13:03:17 +00:00
Huw D M Davies df78d68589 Use GDI APIs to access bitmap info. 1999-07-25 11:15:54 +00:00
Dennis Björklund b49b411784 Small fix in UITOOLS95_DrawRectEdge().
Also a fix to draw scrollbar-buttons more like in win9x.
1999-07-18 18:28:34 +00:00
Francis Beaudet ba296e3898 Fixed fake WM_LBUTTONUP message. 1999-07-18 15:36:08 +00:00
Francis Beaudet 9b4748b6e5 Implemented the BS_ICON style. 1999-07-18 15:29:43 +00:00
Dennis Björklund 736eef4a20 Win9x look & feel on scrollbars. 1999-07-18 15:26:25 +00:00
Dennis Björklund 767b099fe8 Win9x look & feel on buttons and a fix for ownerdrawn buttons
(background set to COLOR_BTNFACE).
1999-07-15 16:07:19 +00:00
Luc Tourangeau 70cd8cb4ae Added BN_CLICKED notification in WM_SETFOCUS. 1999-07-10 11:57:29 +00:00
Abey George 318832ea8e Fixed the height of the dropped list when there are few items in the
list.
1999-07-10 11:34:01 +00:00
Ove Kaaven a8aa5e4f63 Fixed check for whether to call SetWindowPos when showing a window
scroll bar.
1999-07-04 12:48:38 +00:00
Alexandre Julliard 6a232b0c40 Reverted previous change. 1999-07-03 15:51:07 +00:00
Gerard Patel 40ed511c86 Cancel pending notifications when EM_SETMODIFY is called. 1999-07-03 15:47:50 +00:00
Gerard Patel ed941a101f Make GetScrollInfo return scroll pos when program requests thumb pos
outside drag operation.
1999-07-03 11:52:38 +00:00
Patrik Stridvall 1ed4ecffa8 ANSI C fixes.
Removed warnings.
Made the include files self-sufficient.
Some Solaris fixes.
1999-06-26 14:58:24 +00:00
Slava Monich 359a748d9b In case if scrollbar has the same background color as the window
it belongs to, it needs to be filled with 0x55aa bitmap brush.
1999-06-26 11:42:27 +00:00
Alexandre Julliard 9cbe067afa Authors: Chris Morgan <cmorgan@wpi.edu>, James Abbatiello <abbeyj@wpi.edu>
Draw a 3D border around edit controls when not in WIN31_LOOK.
1999-06-26 11:38:13 +00:00
Alexandre Julliard f9c20b6592 Authors: Chris Morgan <cmorgan@wpi.edu>, James Abbatiello <abbeyj@wpi.edu>
Only draw a black border around normal buttons when in WIN31_LOOK.
1999-06-26 11:37:18 +00:00
Noomen Hamza 46c4d39853 Remove the WM_LBUTTONUP message from the queue after selecting a mouse
menu item.
1999-06-26 10:14:27 +00:00
Patrik Stridvall 4bf335497d Removed direct references to CLASS internals. 1999-06-12 14:52:15 +00:00
Francis Beaudet 6ec3eaf54b Fixed a few behaviors of the combobox that were broken. 1999-06-12 10:51:19 +00:00
Ron Cemer e0ec8fd931 Fixes for several bugs in which portions of the scrollbar were not
being redrawn correctly, the focus rectangle was not being correctly
removed from the thumb before redrawing, etc.; added complete Win9x
and WinNT look and feel support.
1999-06-06 17:19:18 +00:00
Eric Pouech dfed208e90 When looking into sys menu, check if items are present before
dereferencing.
1999-06-05 11:43:50 +00:00
Rein Klazes be7a9d16ea Do not process WM_LBUTTONUP message in ButtonWndProc()
when the mouse is not captured.
1999-06-05 08:54:27 +00:00
Pascal Lessard d9ab1f3f1c Support TPM_RETURNCMD in TrackPopupMenu. 1999-05-29 10:56:43 +00:00
Paul Quinn 7572207564 Stop a listbox bug that causes a div by zero when the item height
is zero. Doesn't solve the root of the problem though.
1999-05-22 18:45:06 +00:00
Marcus Meissner ddca315388 Replaced all occurences of SYSMETRICS_xx and sysMetrics[SM_xx] by
GetSystemMetrics(SM_xx), removed no longer needed includes of
sysmetrics.h.
1999-05-22 11:33:23 +00:00
Ulrich Weigand ab7abb14bd Removed superfluous WIN_ReleaseWndPtr. 1999-05-17 14:53:21 +00:00
Francois Boisvert 3b876e4040 Changed CBGetDroppedControlRect to be compliant with Windows API. 1999-05-14 18:37:28 +00:00