Hugh McMaster
60c8dfdd0b
reg: Prevent buffer over-read when querying REG_NONE values with no data.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-05-06 18:53:48 +02:00
Hugh McMaster
1dd785d149
reg: Avoid allocating zero bytes of memory when handling REG_BINARY data.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-05-06 18:53:48 +02:00
Hugh McMaster
e2dfb0aff4
reg: Allow the 'reg_data' pointer to be NULL.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-05-06 18:53:48 +02:00
Jacek Caban
fdf568aaae
ntdll: Inherit tty std input and output in processes attached to Unix console.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50117
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-05-05 21:52:23 +02:00
Alexandre Julliard
85846bfbf4
taskmgr: Avoid wcsncpy().
...
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-05-04 21:33:15 +02:00
Hugh McMaster
cf1e6d3f3f
reg: Only prompt the user to overwrite registry data if the given key already exists and [/f] is not supplied.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-05-03 21:06:23 +02:00
Hugh McMaster
d433d1f122
reg: Fail if access is denied when adding registry data.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-05-03 21:06:17 +02:00
Hugh McMaster
a0dc4d7ce3
reg: Add or modify the (Default) registry value if [/v] is not specified.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-05-03 21:06:09 +02:00
Hugh McMaster
2c73949a46
reg: Replace the 'reg_count' variable name with context-specific names.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-30 22:59:50 +02:00
Hugh McMaster
08786274e2
reg/tests: Update error messages.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-30 22:59:50 +02:00
Hugh McMaster
357601a01b
reg/tests: Add two REG_DWORD tests.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-30 22:59:50 +02:00
Hugh McMaster
a8e961ecac
reg/tests: Fix a typo in a REG_DWORD test.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-30 22:59:50 +02:00
Hugh McMaster
94b582b1a6
reg/tests: Split the REG_DWORD_BIG_ENDIAN tests from the REG_DWORD tests.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-30 22:59:50 +02:00
Hugh McMaster
1110421da9
reg/tests: Use string literals instead of a char buffer for REG_MULTI_SZ tests.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-30 22:59:50 +02:00
Hugh McMaster
1aae492dcb
reg/tests: Add and amend tests adding a (Default) value.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-30 22:59:50 +02:00
Alexandre Julliard
7cdb88a5d8
include: Update the SYSTEM_PROCESS_INFORMATION structure.
...
Spotted by Alex Henrie.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-30 22:59:50 +02:00
Hugh McMaster
dedcd7c100
reg: Use correct error message if RegCreateKeyExW() fails.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-29 23:37:45 +02:00
Francois Gouget
f932fb327a
winetest: Fix the path to the ntoskrnl.exe/tests source.
...
It's the only test with a .exe extension for which the source is not in
programs!
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-29 23:37:45 +02:00
Alexandre Julliard
20984f2e1f
regsvr32: Restart the correct version for all supported architectures.
...
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-29 23:37:45 +02:00
Hugh McMaster
8203c5db02
reg/tests: Verify that only the (Default) value is overwritten when neither /v nor /ve is specified.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-28 16:25:48 +02:00
Hugh McMaster
1ce21dbb5f
reg/tests: Rework syntax tests for the 'copy' operation.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-28 16:25:48 +02:00
Hugh McMaster
33cfc644a0
reg: Don't enumerate a registry key for subkeys if we know the key does not have subkeys.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-28 16:25:48 +02:00
Hugh McMaster
35ccb87a76
reg: Print a new line when recursing and the current key has no registry values.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-28 16:25:48 +02:00
Hugh McMaster
ec0a799ea8
reg: Only print the name of the registry key if it contains values or we are recursing.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-28 16:25:48 +02:00
Hugh McMaster
f32816268e
reg: Do not print a line break after querying a registry key.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-28 16:25:48 +02:00
Hugh McMaster
c809f94624
reg: Consistently use 'hkey' for HKEY variables.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-28 16:25:48 +02:00
Alexandre Julliard
f87e8ec2c5
wineboot: Run wine.inf for all supported architectures.
...
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-28 10:25:02 +02:00
Henri Verbeet
6b49b50bbe
explorer: Initialise window->pidl to NULL in shellwindows_Register().
...
Since array_reserve() doesn't.
Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-26 21:34:02 +02:00
Alexandre Julliard
b51aab9199
winecfg: Get the builtins list from the architecture-specific PE directory.
...
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-26 21:34:02 +02:00
Hugh McMaster
e685718c3b
reg: Print the full key path without a trailing backslash.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-21 21:00:33 +02:00
Francois Gouget
5549ad21b3
winetest: Trace skipped dlls when in exclude (-n) mode.
...
When the command line specifies the list of tests to run, tracing all
the skipped dlls unnecessarily spams the test output.
But when the command line contains the list of (at most 64) excluded
dlls, tracing them ensures tools analysing the report know why the
corresponding dlls were skipped.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-21 10:53:11 +02:00
Hugh McMaster
797520db8f
reg: Fail if a system key has a trailing backslash but no subkey path.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-20 22:57:10 +02:00
Hugh McMaster
6d2ab37a44
reg: Drop key output from the "Invalid system key" error message.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-20 21:07:10 +02:00
Hugh McMaster
8b0602023a
reg/tests: Add tests for querying a key only containing subkeys.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-20 21:07:10 +02:00
Hugh McMaster
c573fce35b
reg/tests: Use 'hkey' in 'query' tests for consistency with other reg.exe tests.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-20 21:07:10 +02:00
Hugh McMaster
9752dfeea8
reg/tests: Only try querying an invalid key once.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-20 21:07:10 +02:00
Hugh McMaster
e9412a8ae0
reg/tests: Test key creation and initialization of the Default registry value.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-16 22:39:46 +02:00
Hugh McMaster
559086af62
reg/tests: Only pass a newly created HKEY if it is used in later tests.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-16 22:39:46 +02:00
Alexandre Julliard
c5c610e364
wusa: Restart 64-bit version from the system32 directory.
...
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-16 11:15:18 +02:00
Alexandre Julliard
9dcdb90f42
winedbg: Restart 64-bit version from the system32 directory.
...
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-16 11:15:18 +02:00
Alexandre Julliard
d30b39edbf
winecfg: Restart 64-bit version from the system32 directory.
...
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-16 11:15:18 +02:00
Alexandre Julliard
59165212ca
wineboot: Restart 64-bit version from the system32 directory.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51006
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-16 11:15:14 +02:00
Alexandre Julliard
ba713a8cf0
uninstaller: Restart 64-bit version from the system32 directory.
...
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-16 11:13:21 +02:00
Gijs Vermeulen
0bf71745f0
cmd: Use terminated strings.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48486
Signed-off-by: Gijs Vermeulen <gijsvrm@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-15 17:41:40 +02:00
Hugh McMaster
45b66285c3
reg/tests: Refactor 'add' tests into registry types, keys and syntax checks.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-15 17:41:40 +02:00
Hugh McMaster
f6566bf749
reg/tests: Test output of keys with a trailing backslash.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-15 17:41:40 +02:00
Hugh McMaster
f4b4398d79
reg/tests: Compare output of some 'query' recursion tests.
...
Recursively querying a registry key for a given value name produces an extra
line specifying the number of matches found.
This line is locale-specific, so we only exclude it from the comparison
on a test-by-test basis.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-15 17:41:40 +02:00
Hugh McMaster
5983247c3a
reg/tests: Compare 'query'test output with expected output.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-14 20:51:00 +02:00
Hugh McMaster
5bc2af7b1c
reg/tests: Give 'query' tests some structure.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-14 20:50:38 +02:00
Hugh McMaster
3d772fe408
reg/tests: Reorder failing 'query' tests.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-14 20:50:33 +02:00