Commit Graph

411 Commits

Author SHA1 Message Date
Nikolay Sivov f9736bcc6e comctl32/toolbar: Properly handle invalid arguments processing TB_ADDSTRING message. 2010-10-04 15:00:07 +02:00
Alexandre Julliard af6fb4712f comctl32: Fix positioning of toolbars that have the WS_BORDER style. 2010-07-20 14:40:32 +02:00
Alexandre Julliard 48e396ea6c comctl32: Load comctl32 builtin bitmaps as 32-bit DIBs. 2010-06-02 15:51:39 +02:00
Alexandre Julliard 95c529dee6 comctl32: Only support an alpha channel for 32-bpp DIB-based imagelists. 2010-06-02 12:46:58 +02:00
Nikolay Sivov 006362567b comctl32/toolbar: Fix possible null pointer dereference. 2010-03-02 11:12:05 +01:00
Michael Stefaniuc 223603cc1c comctl32: Use IS_INTRESOURCE instead of HIWORD to check a resource. 2010-01-26 12:13:51 +01:00
Michael Stefaniuc 9dd502a332 comctl32: Remove some explicit LPARAM/WPARAM casts. 2009-12-28 12:27:14 +01:00
Jason Edmeades 64bd51b1d3 comctl32/toolbar: Improve fixme message conditions. 2009-12-22 13:48:24 +01:00
Alexandre Julliard 6fd93a6c7e comctl32: Use the module instance instead of that of the owner window for the toolbar configuration dialog. 2009-12-21 11:20:19 +01:00
Sergey Khodych fa7c2b5c5f comctl32/toolbar: Use proper button index when freeing a string in TOOLBAR_DeleteButton. 2009-11-23 13:09:25 +01:00
Nikolay Sivov 073486569a comctl32/toolbar: Call handlers in more general way. 2009-11-12 17:06:35 +01:00
Nikolay Sivov 7b19d8bba6 comctl32/toolbar: Use single handler for TB_GETBUTTONTEXTW/TB_GETBUTTONTEXTA. 2009-11-12 17:06:26 +01:00
Nikolay Sivov 62a7373913 comctl32/toolbar: Use single handler for TB_SETBUTTONINFOW/TB_SETBUTTONINFOA pair. 2009-11-12 17:06:20 +01:00
Nikolay Sivov 31ae6a902e comctl32/toolbar: Don't leak button strings. 2009-10-26 11:19:19 +01:00
Austin English a19754ab66 comctl32: Add missing prototype. 2009-10-05 13:46:00 +02:00
Aled Hughes 85abd4c3cf comctl32/toolbar: Avoid unnecessary invalidation on TB_HIDEBUTTON. 2009-08-03 15:03:23 +02:00
Vladimir Pankratov 585e8dfbb4 comctl32: Fix division by zero. 2009-07-15 14:04:12 +02:00
Nikolay Sivov f6bdb637bf comctl32/toolbar: Move parameter cast to WinProc level, some code cleanup. 2009-06-29 14:32:12 +02:00
Nikolay Sivov e7dc4ed07f comctl32/toolbar: Move initialization to WM_NCREATE handler. 2009-06-26 14:40:04 +02:00
Andrew Talbot f5d8fa6613 comctl32: Constify some variables. 2009-06-08 12:41:54 +02:00
Nikolay Sivov 8296075fa7 comctl32/toolbar: Don't free Toolbar control data too early. 2009-05-25 11:37:27 +02:00
Nikolay Sivov 1f43da01c0 comctl32/toolbar: No need to use GetSysColor directly. 2009-05-19 15:41:37 +02:00
Nikolay Sivov 97ecd468c4 comctl32/toolbar: Use already cached control window style. 2009-05-19 15:41:30 +02:00
Nikolay Sivov b97600699a comctl32/toolbar: Remove superfluous forward declarations. 2009-05-19 15:41:24 +02:00
Nikolay Sivov 9a0f600574 comctl32/toolbar: Retrieve control data once at WinProc. 2009-05-19 15:41:09 +02:00
Giuseppe Bilotta 585c3abb6b comctl32/toolbar: When a null lParam is passed to TB_GETBUTTONTEXTA, we should not return -1 but the string size. 2009-05-07 15:15:07 +02:00
Giuseppe Bilotta fcc9b57c7a comctl32/toolbar: Skip iString field for separators. 2009-05-07 15:14:42 +02:00
Giuseppe Bilotta 6a01f71949 comctl32/toolbar: Fix trace info for TOOLBAR_InternalInsertButtonsT. 2009-04-22 17:00:51 +02:00
Igor Tarasov 3e235cc363 comctl32: TOOLBAR_SetImageList should recalculate toolbar only if it is necessary. 2009-04-22 12:56:19 +02:00
Igor Tarasov 74baffb254 comctl32: Fix typo in TOOLBAR_SetButtonSize code. 2009-04-21 14:25:15 +02:00
Igor Tarasov c037b333c8 comctl32: Fix regression caused by 2d751ee56a.
Fixing regression produced by "comctl32: Correct handling of toolbar
separators size". As it came out, some applications DO rely on iBitmap
value, but it can be received not with TB_GETBUTTONINFO, but with
TB_GETBITMAP.
2009-04-20 14:13:54 +02:00
Igor Tarasov 2d751ee56a comctl32: Correct handling of toolbar separators size. 2009-03-31 12:40:59 +02:00
Igor Tarasov 88b64d486d comctl32: CCS_VERT flips toolbar separators orientation. 2009-03-31 12:40:51 +02:00
Gerald Pfeifer 9d9880bd34 comctl32: Simplify eight TOOLBAR_ function invocations. 2009-02-16 16:01:37 +01:00
Michael Stefaniuc da6d7920de comctl32: Remove superfluous pointer casts. 2009-02-13 13:00:25 +01:00
Mikołaj Zalewski aa7a0b85b0 comctl32: toolbar: Only changing TBSTYLE_EX_MIXEDBUTTONS should cause a recalc. 2009-02-02 15:48:26 +01:00
Mikołaj Zalewski 574c0dcc32 comctl32: toolbar: Unlike in listview, TB_SETEXTENDEDSTYLE takes the actual style, not a mask. 2009-02-02 15:48:26 +01:00
Mikołaj Zalewski 5de172af78 comctl32: toolbar: TB_SETBUTTONINFO should do a relayout instead of a recalc. 2009-02-02 15:48:26 +01:00
Mikołaj Zalewski ada088e62d comctl32: toolbar: Use different function for dumping of TBUTTON_INFO and TBBUTTON. 2009-02-02 15:48:26 +01:00
Mikołaj Zalewski ca9f7d3140 comctl32: toolbar: Move common TB_ADDBUTTONS and TB_INSERTBUTTONS code into a helper function, makes TB_INSERTBUTTON with a text perform a recalc (with testcase). 2009-02-02 15:48:26 +01:00
Mikołaj Zalewski d31828b500 comctl32: toolbar: Make sure all TBUTTON_INFO fields are initialized when a button is added in the middle. 2009-01-28 12:09:51 +01:00
Alasdair Sinclair 4475045fe1 comctl32: Fix missing void in empty parameter list. 2009-01-26 15:07:30 +01:00
Reece Dunn 7fcc9629f8 comctl32: Don't generate a fixme message for the TBSTYLE_EX_DOUBLEBUFFER extended style. 2009-01-26 14:30:41 +01:00
Gerald Pfeifer bcfc2027fb comctl32: Simplify ten functions by removing unused parameters. 2009-01-23 12:57:02 +01:00
Gerald Pfeifer e985ca06cf comctl32: Simplify twelve functions by removing unused parameters. 2009-01-19 14:50:39 +01:00
Rob Shearman 76b805dad4 comctl32: Add names for now documented toolbar messages. 2009-01-02 14:27:43 +01:00
Gerald Pfeifer 6bdcdc4232 comctl32: Simplify fifteen functions by removing unused parameters. 2009-01-02 12:39:31 +01:00
Ricardo Filipe 66019452f4 comctl32: Remove dead stores (llvm/clang). 2008-11-21 11:28:51 +01:00
Sergey Khodych 7f25cd993c comctl32: toolbar: Use a cx field for buttons in TOOLBAR_WrapToolbar. 2008-11-06 11:56:03 +01:00
Sergey Khodych 65e9a6e02e comctl32: toolbar: Improve text layout in TBSTYLE_LIST toolbars. 2008-11-06 11:55:56 +01:00
Sergey Khodych 1232b08449 comctl32: toolbar: Calculate a correct size for empty buttons with the BTNS_AUTOSIZE style. 2008-11-06 11:55:51 +01:00
Michael Stefaniuc 62e17fa8c4 comctl32: Do not cast zero. 2008-11-04 11:26:22 +01:00
Michael Stefaniuc d1791f8108 comctl32: Remove superfluous casts as HANDLE to other handle types. 2008-10-28 12:34:05 +01:00
Michael Stefaniuc b723e6f6b6 comctl32: Remove the superfluous casting of the LPVOID returned by Alloc(). 2008-10-24 14:24:59 +02:00
Mikołaj Zalewski a289bab122 comctl32: toolbar: TB_SETBITMAPSIZE should not change a coordinate when passed -1 (with testcase). 2008-07-23 11:20:58 +02:00
Mikołaj Zalewski 60a1e20ba8 comctl32: Don't print ERRs for reflected messages. 2008-07-22 13:25:08 +02:00
Andrew Talbot 3c5308b804 comctl32: Indentation fix. 2008-05-23 11:58:18 +02:00
Aric Stewart e1a0715b4a comctl32: Fix an off-by-one error in toolbar TOOLBAR_SetHotItem. 2008-04-24 22:12:32 +02:00
Austin English c531e2abdb Spelling fixes. 2008-04-23 12:31:07 +02:00
Andrew Talbot 161d3322d6 comctl32: Remove unused variables. 2008-04-16 14:08:04 +02:00
Andrew Talbot 369d414d59 comctl32: Remove unused variables. 2008-04-14 12:42:36 +02:00
Lei Zhang 7f5c97693e comctl32: Fix TB_GETSTRING return values. 2008-03-12 12:00:14 +01:00
Lei Zhang 375f60b07a comctl32: Add tests for TB_GETSTRING, fix NULL pointer access. 2008-03-12 12:00:08 +01:00
Andrew Talbot 8d555e825b comctl32: Assign to structs instead of using memcpy. 2008-02-12 23:00:03 +01:00
Lei Zhang 3980401231 comctl32: Use wine_dbgstr_rect() in traces. 2008-02-07 11:59:53 +01:00
Austin English c2a7914d1c comctl32: Spelling fixes. 2008-01-24 11:43:02 +01:00
Andrew Talbot 863ffb719b comctl32: Remove unneeded casts. 2008-01-02 12:38:41 +01:00
Andrew Talbot 1bf787d521 comctl32: Remove unneeded casts. 2007-12-03 13:10:21 +01:00
Alexander Dorofeyev 35ff6d6750 comctl32: Fix broken detection of non-empty string. 2007-10-29 14:32:16 +01:00
Alexander Dorofeyev 77c376e0f8 comctl32: Pass command id of button in wParam. 2007-10-29 14:32:10 +01:00
Lionel Debroux 29ddd49130 comctl32: Remove redundant NULL check before free (found by Smatch). 2007-10-22 12:36:08 +02:00
Jason Edmeades 881c204c02 comctl32: toolbar: Implemented SetRows. 2007-08-28 12:26:13 +02:00
Mikołaj Zalewski 31be5005c6 comctl32: toolbar: Test and fix invalid indexes passed in TB_ISBUTTON*. 2007-07-20 11:34:34 +02:00
Mikołaj Zalewski 5507a073c5 comctl32: toolbar: We should send TBN_GETDISPINFOW even for ANSI controls (with testcase). 2007-07-11 11:59:33 +02:00
Mikołaj Zalewski e66523e19b comctl32: toolbar: The iImage in TBN_GETDISPINFO should be initialized to -1. 2007-07-11 11:53:33 +02:00
Dmitry Timoshkov 18366472c7 comctl32: Fix a compilation warning in 64-bit mode. 2007-06-01 12:42:06 +02:00
Dmitry Timoshkov 3c9e7a7f33 wine: Switch to using 'long' for INT_PTR type for 64-bit compatibility. 2007-05-25 20:37:56 +02:00
Mikołaj Zalewski 7b8241b1ee comctl32: toolbar: TB_SETIMAGELIST should try to preserve button width. 2007-05-16 11:55:38 +02:00
Mikołaj Zalewski 3d7a65355e comctl32: toolbar: Don't execute TB_GETBUTTONINFO if cbSize is invalid. 2007-04-24 10:19:04 +02:00
Mikołaj Zalewski 10b1d00113 comctl32: toolbar: Merge TOOLBAR_GetButtonInfoA and TB_GetButtonInfoW. 2007-04-24 10:18:33 +02:00
Felix Nawothnig 7657913873 comctl32: Allow destruction of toolbar in BN_CLICKED handler. 2007-04-06 12:31:08 +02:00
Andrew Talbot 51ee497174 comctl32: Constify some variables. 2007-04-03 11:21:51 +02:00
Mikołaj Zalewski 7bf7cdd1a9 comctl32: toolbar: TB_HIDEBUTTON and TB_MOVEBUTTON shouldn't force a recalc. 2007-03-28 12:05:15 +02:00
Mikołaj Zalewski 307f39c0d5 comctl32: toolbar: We shouldn't try to resize standard bitmaps. 2007-03-21 11:59:31 +01:00
Mikołaj Zalewski e3b7c3045a comctl32: toolbar: Test standard buttons size. 2007-03-21 11:59:21 +01:00
Mikołaj Zalewski d4a67c4382 comctl32: toolbar: The default button size is 16x16. 2007-03-21 11:59:11 +01:00
Andrew Talbot 74ab88ca97 comctl32: Replace inline static with static inline. 2007-03-17 20:03:19 +01:00
Michael Stefaniuc 22ecd7aa67 comctl32: Remove redundant NULL checks before Free() (found by Smatch). 2007-03-08 11:58:04 +01:00
Mikołaj Zalewski dadc4248cf comctl32: toolbar: Copy bitmaps with CopyImage so that it works also for DIBs (based on a patch by Oleg Krylov). 2007-02-07 11:03:09 +01:00
Mikołaj Zalewski 292cb4d2ac comctl32: toolbar: Fix the TB_SETBITMAPSIZE for width or height zero (with testcase). 2007-01-16 16:54:25 +01:00
Mikołaj Zalewski e6b1bd5f30 comctl32: toolbar: Recalc the toolbar after a TB_SETIMAGELIST. 2007-01-16 11:17:39 +01:00
Mike McCormack f23ab81738 comctl32: Downgrade an ERR to a WARN. 2006-11-09 11:44:42 +01:00
Mikołaj Zalewski 0559afda80 comctl32: toolbar: Use the width of the current button instead of nButtonWidth to position the icon. 2006-11-02 12:31:18 +01:00
Mikołaj Zalewski 420f7cb076 comctl32: toolbar: The SetButtonSize should not allow too small buttons. 2006-11-02 12:31:06 +01:00
Mikołaj Zalewski 3bfcacc54c comctl32: toolbar: The top margin should be computed and saved in CalcToolbar. 2006-11-02 12:30:53 +01:00
Mikołaj Zalewski a8a0a65515 comctl32: toolbar: Add a LayoutToolbar that works like CalcToolbar but doesn't overwrite the button sizes. 2006-11-02 12:30:34 +01:00
Mikołaj Zalewski f7f1479a08 comctl32: toolbar: Fix buttons heights. 2006-11-02 12:30:17 +01:00
Mikołaj Zalewski 9ec280c258 comctl32: toolbar: The string should be included in the height of a button-less toolbar only if there is a string in the pool. 2006-11-02 12:29:50 +01:00
Mikołaj Zalewski d57a61f831 comctl32: toolbar: Add support for WM_SETFONT. 2006-11-02 12:29:32 +01:00
Oleg Krylov 32caf30f9c comctl32: Create tooltip windows with WS_POPUP style. 2006-10-25 20:21:34 +02:00