57fa1bee65
msi: Do not open registry keys with no access rights.
...
Signed-off-by: Thomas Faber <thomas.faber@reactos.org>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-01 18:49:25 +09:00
ae3f25cc44
msi: Fixed same file handle closed twice (Coverity).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-11 19:54:12 +09:00
2ee784e624
msi: Make sure to reset the 'in_quotes' state in all cases.
...
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-03 21:11:05 +09:00
2d7f00c8d3
Revert "msi: Correctly parse double quotes in the token value.".
...
This reverts commit 42caac841e
2015-11-03 21:10:59 +09:00
42caac841e
msi: Correctly parse double quotes in the token value.
...
This fixes an installer that passes to InstallProduct a command line like
PROPERTY1="Installing ""Product name"" version 8.0" PROPERTY2=1 PROPERTY3=1
In this case properties PROPERTY2 and PROPERTY3 were not recognized and that
led to an installation failure when a custom action didn't see them as set.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
2015-10-06 22:59:38 +09:00
9a5788afc1
msi: Set the PrimaryVolumeSpaceRequired and PrimaryVolumeSpaceRemaining properties.
...
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
2015-10-01 16:23:15 +09:00
ddaba7a369
msi: Don't add the same environment string more than once.
2015-08-26 23:15:26 +09:00
99dfc15e72
msi: Only remove environment strings that were added on install.
2015-08-18 17:30:17 +09:00
fed41f5306
msi: Don't call CloseServiceHandle() with an invalid handle.
2015-07-16 21:20:50 +09:00
17405f6b91
msi: Check the return value of MSI_QueryGetRecord (Coverity).
2015-07-15 23:19:23 +09:00
e1a65bed68
msi: Be more selective about which access modes are used to open or create keys.
...
An installer was failing when trying to create subkeys after denying
delete access to their parent key.
2015-07-15 23:19:09 +09:00
4a992fec01
msi: Fix a registry key leak.
2015-07-15 23:18:54 +09:00
597c5f9c4b
msi: Open database cabinet streams through the streams implementation.
2015-06-22 19:18:48 +09:00
17b05316a5
msi: Clean up handling of temporary files.
2015-04-01 22:34:20 +09:00
20ef12a762
msi: Don't mark global assembly files as installed when they are extracted.
2015-04-01 22:34:20 +09:00
006801366e
msi: Don't apply file patches in the cabinet extraction callback.
2015-04-01 22:34:19 +09:00
0762dd68f8
msi: Store the disk id for file patches.
2015-04-01 22:34:19 +09:00
7a4d8f57c7
msi: Improve tracing.
2015-03-17 00:19:48 +09:00
4c1791f53e
msi: Add offsets to file patch sequence numbers.
2015-03-04 23:57:42 +09:00
c4bf8a85ee
msi: Fix memory leak (Coverity).
2015-02-16 19:18:44 +09:00
e52cbbcd03
msi: Remove 32-bit component registry keys with KEY_WOW64_32KEY flag.
2015-01-19 14:20:27 +01:00
cdf3c23645
msi: Open 32-bit component registry keys with KEY_WOW64_32KEY flag.
2015-01-19 14:20:10 +01:00
165c9e7cb9
msi: Remove no-op toupperW() statement (PVS-Studio).
2014-12-10 13:32:01 +01:00
2a8043aa6b
msi: Properly handle service control events in Start/StopService.
2014-12-02 13:07:16 +01:00
609de1a80a
msi: Call execute_script directly in InstallFinalize.
2014-11-04 21:19:31 +09:00
98ae03ff4d
msi: Update properties after each transform that affects the property table.
2014-11-04 21:19:28 +09:00
35ce56ac85
msi: Pass a database pointer to msi_clone_properties instead of a package pointer.
2014-11-04 21:19:24 +09:00
7f57d8f19a
msi: Format registry values before interpreting value type.
2014-10-31 10:49:19 +09:00
29baed1bc2
msi: Improve support for advertized shortcuts.
2014-09-12 15:30:13 +02:00
614cb7eac7
msi: Update the cached product code when the property has changed.
2014-09-01 21:10:12 +02:00
04f9058a28
msi: Set the OutOfNoRbDiskSpace property.
2014-09-01 21:10:12 +02:00
b1a4055245
msi: Don't check feature install level on features specified in arguments.
2014-07-24 13:02:45 +02:00
0dff7bff9a
msi: Fix feature actions overriding in process_state_property.
2014-07-24 13:02:43 +02:00
331c86f124
msi: Don't publish features with non positive install level.
2014-07-24 13:02:42 +02:00
3fa41c9e70
msi: Fixed missing free in an error path (Coverity).
2014-03-10 10:41:15 +01:00
f525038142
msi: Remove the product reference when a shared component is unregistered.
2014-03-03 17:02:51 +01:00
1ae3bcc94d
msi: Don't install services without an image path.
...
Spotted by Aric Stewart.
2014-02-22 08:41:22 -06:00
f21225a41b
msi: Fix typo in a field name.
2014-02-13 17:52:15 +01:00
48908c130c
msi: Remove the unused CurrentlyScripting field from MSISCRIPT.
2014-01-03 17:00:12 +01:00
41d2b53c5b
msi: Always derive the SourceDir property from the database path.
2014-01-03 17:00:02 +01:00
9612ed1ba6
msi: Get extension name by strrchrW instead of strchrW.
2013-11-13 18:31:36 +01:00
8793b5fe28
msi: Use BOOL type where appropriate.
2013-10-28 10:40:20 +01:00
b64fabf39e
msi: Don't defer custom actions in the UI sequence if they match the currently running script.
2013-06-03 21:11:51 +02:00
74aa47fa8e
msi: The UI sequence exists if there are runnable actions in the InstallUISequence table.
2013-05-29 18:12:01 +02:00
4b4bd0201c
msi: Remove trailing spaces from command line property name.
2013-05-20 21:15:38 +02:00
10975967df
msi: Set the PrimaryVolumePath and PrimaryVolumeSpaceAvailable properties.
2013-05-09 19:24:16 +02:00
b98ef8f087
msi: Treat an empty install location as missing.
2013-05-07 17:20:46 +02:00
aeb7d70ffd
msi: Handle more than one patch per file.
2013-02-27 19:23:13 +01:00
bfe5e58d3a
msi: Don't remove products if msidbUpgradeAttributesOnlyDetect is set.
2013-02-15 16:56:19 +01:00
a248f4f001
msi: Set the OriginalDatabase property after applying transforms, not before.
2013-01-21 16:27:41 +01:00
Thomas Faber