Commit Graph

714 Commits

Author SHA1 Message Date
Nikolay Sivov ffd84dc429 comdlg32: Fix some leaks on error paths (Coverity).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-02 12:28:12 +02:00
Nikolay Sivov 855d7b0fd8 comdlg32: Add some traces for custom Places (Coverity).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-02 12:28:12 +02:00
Michael Stefaniuc e2dae70fe0 comdlg32: Use the available ARRAY_SIZE() macro.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-29 17:27:45 +02:00
Nikolay Sivov 1b04429965 comdlg32: Hide Read-only checkbox for Save dialogs.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-26 11:28:19 +02:00
Nikolay Sivov 725c02614b comdlg32: Use shell API directly.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-21 10:13:05 +01:00
Nikolay Sivov 8bbb32c99d comdlg32: Add support for Places bar customization.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-21 10:12:52 +01:00
Nikolay Sivov 0092e2ea0f comdlg32: Use flat navigation toolbar.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-21 10:12:50 +01:00
Nikolay Sivov fe572072c3 comdlg32: Remove most of Combo macros.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-20 11:40:34 +01:00
Nikolay Sivov 2118ce0fa9 comdlg32: Add a helper to test if file dialog hook is enabled.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-20 11:40:29 +01:00
Nikolay Sivov 7514475c1c comdlg32: Use ARRAY_SIZE macro.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-20 11:40:25 +01:00
Nikolay Sivov b8d1e929e7 comdlg32: Detach file dialog data after child windows were destroyed.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-20 11:40:19 +01:00
Nikolay Sivov 38898e939c comdlg32: Use memory allocation helpers.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-20 11:40:15 +01:00
Nikolay Sivov 69d7e05179 comdlg32: Implement Places toolbar for file dialogs.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-19 12:35:11 +01:00
Nikolay Sivov 284bfc677b comdlg32/tests: Remove a macro.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-16 16:41:25 +01:00
Alexandre Julliard 908fa3eb8d comdlg32: Correctly initialize the item dialog structure.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-02 15:40:36 +01:00
Alexandre Julliard 77d65c3948 comdlg32: Add a helper function to select a combo box item.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-18 19:51:22 +01:00
Fabian Maurer aa7941d41b comdlg32/fontdlg: Allow setting value by typing it into the edit fields.
The font-dialog allows the user to select a value from the combobox by
typing it into its edit field. This operation seems unique to the
fontdialog. It works case-insensitively and doesn't change the
selection in the edit field.

Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-20 12:37:15 +01:00
Fabian Maurer 823c4b14b4 comdlg32: Use proper size for combobox controls.
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-31 18:55:25 +02:00
Nikolay Sivov 1c1db33aba comdlg32: Improve tracing messages.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 10:53:58 +02:00
Nikolay Sivov c4b133e231 comdlg32: Simplify notification helper.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-31 10:53:56 +02:00
Nikolay Sivov 3c33ebd662 comdlg32: Use existing symbol for Help button id.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-11 10:17:50 -05:00
Huw Davies 5d9ab56d9e comdlg32: Select the correct font before querying the extents.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-05 14:12:18 +02:00
Huw Davies e77771c0bf comdlg32: Set the radiobuttons' font if they're part of a visual group.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-05 14:12:18 +02:00
Huw Davies 00994524f5 comdlg32: Use pixel sizes throughout.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-05 14:12:18 +02:00
Huw Davies 6df0198a2b comdlg32: Scale the control size limits with dpi.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-05 00:19:54 +02:00
Huw Davies 6891b5a044 comdlg32: Don't ask for icon information since it's unused.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-25 11:47:19 +02:00
Nikolay Sivov a44a608378 comdlg32: Take nMaxFile into account when converting A->W.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-13 19:28:11 +01:00
Nikolay Sivov b47de18ce1 comdlg32: Use GetPropW() to get to file dialog data.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-21 13:57:36 +01:00
Nikolay Sivov c23a91cb63 comdlg32: Consolidate file dialog initialization to avoid duplication.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-21 13:57:36 +01:00
Nikolay Sivov aef84332a2 comdlg32: Expand initial directory path for file open dialog.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-21 13:57:36 +01:00
Alex Henrie e07d20f3f3 comdlg32: Don't crash if an IShellFolder could not be created.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-14 22:46:58 +01:00
Alex Henrie bd1b3c104e comdlg32: Use localized "Path does not exist" string.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-14 22:46:57 +01:00
Józef Kucia 1707df3da2 comdlg32: Delay OleInitialize() until after file dialog window is created.
This fixes a problem exposed by commit
f65e04770d.

Signed-off-by: Józef Kucia <jkucia@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-02 20:40:13 +01:00
Józef Kucia 5dda6495eb comdlg32/tests: Add test for OLE initialization in file dialogs.
Signed-off-by: Józef Kucia <jkucia@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-02 20:40:13 +01:00
Nikolay Sivov 6c4aaf776f comdlg32: Always use original Open File dialog template.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-26 10:37:08 +01:00
Michael Stefaniuc eff2ecc39a comdlg32: Avoid some superfluous pointer casts.
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-08 13:56:02 +01:00
Alistair Leslie-Hughes 3126d9ca4c comdlg32/tests: Test when a directory is passed to OpenFileName Dialog.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-27 18:06:29 +02:00
Bruno Jesus 5809118892 comdlg32: Avoid crash when a path is passed into Open File Dialog.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-27 18:06:23 +02:00
Carlo Bramini a1b0d92587 comdlg32: Uses SetDlgItemInt() to simplify the code.
Signed-off-by: Carlo Bramini <carlo_bramini@users.sourceforge.net>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-17 16:48:47 -07:00
Alistair Leslie-Hughes 326a9ea137 comdlg: Select all text when enter is pressed.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-09-09 20:20:53 +09:00
Alistair Leslie-Hughes b11d7f7482 comdlg32: Clear the filename text on OPEN_BROWSE.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-09-09 20:20:53 +09:00
Nikolay Sivov 384ece4d7e comdlg32/itemdlg: Fix setting NULL file name (Coverity).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-28 21:38:13 +09:00
Lauri Kenttä c851ecca2b comdlg32: Avoid repeated GlobalLock etc in filedlg.
Signed-off-by: Lauri Kenttä <lauri.kentta@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-08 12:11:16 +09:00
Lauri Kenttä f99da3f3a1 comdlg32: Avoid generating filenames twice in filedlg.
Signed-off-by: Lauri Kenttä <lauri.kentta@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-08 12:11:02 +09:00
Lauri Kenttä 86a993ea3c comdlg32: Init clipboard format only once in filedlg.
Signed-off-by: Lauri Kenttä <lauri.kentta@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-08 12:10:20 +09:00
Michael Stefaniuc 3ad882ff24 comdlg32: Use InflateRect() instead of open coding it.
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-04 17:29:35 +09:00
Michael Stefaniuc 4e7272f087 comdlg32: Avoid using CopyRect().
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-22 22:16:35 +09:00
Michael Stefaniuc db134bbd5a comdlg32/tests: Use wine_dbgstr_rect() to print RECTs.
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-10 20:34:03 +09:00
Pierre Schweitzer d288d8d333 comdlg32: Check for overflow before dereferencing.
Signed-off-by: Pierre Schweitzer <pierre@reactos.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-02 18:30:45 +09:00
Michael Stefaniuc 69f6493a8c comdlg32: Use wine_dbgstr_rect() to trace a RECT.
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-21 18:42:25 +09:00