Commit Graph

1585 Commits

Author SHA1 Message Date
Vitaliy Margolen c03dabb2fe Adjust all dimensions to match native.
Invalidate whole tab area when multi-line.
In vertical tab placement go from top to bottom.
Fix annoying visual artifacts.
2004-03-02 04:52:35 +00:00
Steve Lustbader a752885c3d Handle the firstVisible item being NULL in
TREEVIEW_UpdateScrollBars().
2004-03-01 23:10:52 +00:00
Robert Shearman 57cc6f58ba Update common control function documentation. 2004-02-27 04:40:08 +00:00
Matt Chapman 766fc7cc9c REBAR_Layout should respect the minimum size of bands even when
RBBS_FIXEDSIZE is not set.
2004-02-27 04:32:54 +00:00
Matt Chapman cc5d49f8cb REBAR_ShowBand needs to force layout of the rebar after a band is
hidden/unhidden.
2004-02-27 00:43:04 +00:00
Matt Chapman c286ca06a0 Fix a reentrancy issue in the property sheet implementation by not
caching a pointer that can change.
2004-02-25 01:24:22 +00:00
Christian Costa 1fba717981 Accept null module instance, Loadstring can handle it. 2004-02-24 01:04:27 +00:00
Maxime Bellengé 820aa3762f Fix a regression in ImageList_Create when creating a dibsection. 2004-02-24 00:58:59 +00:00
Alexandre Julliard f310fdf3a0 Removed a couple of unneeded helper functions. 2004-02-20 19:58:39 +00:00
Ulrich Czekalla 5a864b2f70 Use dibsections for the images. 2004-02-20 19:57:09 +00:00
Huw Davies 9af2de85ea If TBSTYLE_EX_HIDECLIPPEDBUTTONS is set then invalidate the area that
changes in a resize.
Don't call SWP unless we're actually adjusting anything.
2004-02-20 19:56:52 +00:00
Robert Shearman 64d68b106a - Implement string functions in comctl32.
- Use CompareString in shlwapi wherever possible instead of ugly
  helpers.
2004-02-20 05:16:37 +00:00
Dimitrie O. Paun e879638d36 LVN_BEGINRDRAG is implemented now. Fix typo. 2004-02-20 05:12:49 +00:00
Aric Stewart d240ae8d62 Implemented LISTVIEW_ApproximateViewRect for LVS_REPORT. 2004-02-20 01:05:39 +00:00
Fabian Cenedese 7142a4e0b2 ListView should behave in OWNERDRAW as in FULLROWSELECT. This allows
to select cells not in the first column in REPORT mode with OWNERDRAW
style set.
2004-02-17 22:47:51 +00:00
Robert Shearman 997ce1926e Forward some wrapper functions since we don't care about compatibility
with Win98 in this case.
2004-02-17 22:47:21 +00:00
Robert Shearman 187c8b71ce Move string functions to separate file. 2004-02-17 21:02:18 +00:00
Robert Shearman 41596e8031 - Fix some traces.
- The TBM_GET*HOTLIST functions take imagelist ID in wParam.
- Implement TBM_GETSTRING{A,W}.
- Implement undocumented 0x462 message.
2004-02-17 20:28:19 +00:00
Robert Shearman 524cad7413 Documentation update. 2004-02-17 20:23:05 +00:00
Mike Hearn d04f253aa9 Grow the treeview control expander button by 1px in each direction to
match the native look.
2004-02-16 22:19:29 +00:00
Aric Stewart e56178d9d5 Work toward properly updating the SelectionMark when the selected
state changed inside a listbox.
2004-02-13 22:40:37 +00:00
Huw Davies d9558dbd19 Fix a TRACE. 2004-02-12 20:06:04 +00:00
Huw Davies 951b0a2271 Only redraw button in PressButton and Indeterminate if its state has
changed.
2004-02-11 05:26:30 +00:00
Huw Davies e722167e0d Honour TB_SETMAXTEXTROWS. 2004-02-11 04:02:29 +00:00
Ulrich Czekalla 54b6ccd501 Add support for BTNS_WHOLEDROPDOWN.
Populate button rect when sending TBN_DROPDOWN.
2004-02-10 20:08:45 +00:00
Dmitry Timoshkov e6f01981fc Add partial support for some undocumented toolbar messages. 2004-02-10 01:34:47 +00:00
Francois Gouget ad5ff7ceeb Assorted spelling and case fixes. 2004-02-09 22:07:42 +00:00
Huw Davies a1edb9204f TB_ADDBUTTONS can pass a string ptr instead of an index.
TB_GETBUTTONINFO only returns a string if it's not in the internal
string list.
2004-02-09 21:47:01 +00:00
Huw Davies 89ef25e218 Use the BTNS_* toolbar button style defines rather than the outdated
TBSTYLE_*.
2004-02-09 21:01:10 +00:00
Huw Davies 6b27cde3a2 Add a missing return. 2004-02-07 01:28:10 +00:00
Vitaliy Margolen a6637ddb5d - Fix handling of TCS_RAGGEDRIGHT style.
- Clip UpDown control only if it is present.
- Add ToDos.
2004-02-07 01:02:03 +00:00
Robert Shearman 436145e975 Fix nGrow initialization in DPA_CreateEx. 2004-02-06 05:16:32 +00:00
Jon Griffiths ed39e7c039 Draw disabled toolbar buttons correctly. 2004-02-03 00:08:34 +00:00
Ulrich Czekalla 710bd6fb6a We should forward WM_COMMAND notification to the active page for any
additional non-standard controls in the property sheet frame.
2004-01-27 20:11:05 +00:00
Francois Gouget 231fbff8d0 Add trailing '\n's to ok() calls. 2004-01-27 04:01:10 +00:00
Francois Gouget 6b6ed724ae Add missing '\n's to debug traces. 2004-01-27 00:01:43 +00:00
Alexandre Julliard 4e47ccb490 There is no need for a private heap in comctl32, memory allocations
should go to the standard process heap (reported by Ge van Geldorp).
2004-01-26 20:23:08 +00:00
Alexandre Julliard d07c1004e3 Moved a few remaining 16-bit definitions out of the standard headers. 2004-01-23 22:51:41 +00:00
Huw Davies d21266ad74 The tab control should be multiline. 2004-01-23 20:47:11 +00:00
Ge van Geldorp adeaa30555 Discard mouse button up events if no button is currently pressed. 2004-01-23 20:46:47 +00:00
Ge van Geldorp 0472291e4c Generate all binary resources using bin2res. 2004-01-23 02:11:53 +00:00
Huw Davies 84e7547ef1 Move the selection to the previous sibling if it can't go to the next
or the parent.
Fix the selection change logic.
2004-01-21 22:16:02 +00:00
Francois Gouget a5aa8dc1d0 DPA_Create is missing from all recent import libraries so use
GetProcAddress to load it.
Add '\n' to 'ok' calls.
2004-01-19 21:47:35 +00:00
Francois Gouget 4cd80a3637 Add trailing '\n's to ok() calls. 2004-01-19 21:43:43 +00:00
Vincent Béron 7b11e537b0 Get rid of a W->A cross call in ImageList_LoadImageW. 2004-01-16 02:01:46 +00:00
Francois Gouget eb10f347e6 Fix a race that caused the Microsoft Viewers 'file extraction'
animation to sometimes have a pink background.
2004-01-13 05:07:56 +00:00
Alexandre Julliard 502f6c5634 Removed incorrect uses of DUMMYUNIONNAME. 2004-01-07 00:47:35 +00:00
Francois Gouget 640cc3f3e1 Assorted spelling fixes. 2004-01-06 22:08:33 +00:00
Mike McCormack 2de64d4b08 On a RB_SETBANDINFO message only redraw the rebar if something
changed.
2004-01-02 20:46:05 +00:00
Duane Clark 88c25c86e5 Reinitialize thumb when trackbar size is changed. 2003-12-30 19:10:15 +00:00
Mike Hearn a25b352f47 Remove flat scrollbar stub fixmes. 2003-12-13 01:33:51 +00:00
Vik Kumar 7ad932efda Added Japanese translation. 2003-12-12 05:57:22 +00:00
Jon Griffiths b56583ec1a Don't call GetWindowLong for every comparison while sorting. 2003-12-10 00:37:14 +00:00
Jon Griffiths 0e04023b91 Added Thai translation. 2003-12-04 04:46:13 +00:00
Vitaliy Margolen 036dcf167e - Fix drawing of HotTracked tabs & buttons.
- More tab size fixes in different styles.
- Don't use new padding until style changes.
- Fix left alignment of labels &| icons.
- Don't draw over UpDown control.
- Fully erase tabs when scrolling.
- More tests.
2003-12-02 03:31:44 +00:00
Dmitry Timoshkov 2964888d05 A general cleanup of the version resources in Wine DLLs. 2003-11-30 05:59:29 +00:00
Huw Davies 6cfbf89529 Merge {Set,Insert}Item[AW] to {Set,Insert}ItemT. 2003-11-27 01:11:01 +00:00
Ulrich Czekalla 1afef2c732 In TREEVIEW_EnsureVisible handle case where firstVisible is NULL. 2003-11-27 00:55:18 +00:00
Huw Davies 96b9057097 Merge GetItem[AW] into GetItemT. 2003-11-26 22:26:19 +00:00
Aric Stewart d78dfc8e44 Redraw if bold state changes. 2003-11-26 22:07:17 +00:00
Robert Shearman 7d6afc5ddc - Add support for TBSTYLE_EX_MIXEDBUTTONS.
- Add support for TBSTYLE_EX_HIDECLIPPEDBUTTONS.
- Replace 'magic numbers' with #define'd constants.
- Fix TBN_INITCUSTOMIZE.
- Add support for TBN_CUSTHELP and TBN_RESET.
- Fix TB_SETEXTENDEDSTYLE (it appears it should or the new style,
  rather than set).
- Fix TB_SETSTYLE (this is meant to be for setting the control style,
  not the button style).
2003-11-26 22:05:02 +00:00
Ulrich Czekalla 12f7a36132 Always recompute an item's text width in the case of text callbacks
and when its attributes change.
2003-11-26 22:03:58 +00:00
Huw Davies 5693ecd212 Unicodification. Based on a patch by Aric Stewart. 2003-11-26 03:37:30 +00:00
Rein Klazes 8ba9b5fc7e Use button face color for the image mask when adding a bitmap to the
toolbar, not the color of the top left pixel of the image.
2003-11-25 01:45:50 +00:00
Rein Klazes 7f7cde0eee Fix some confusion between number of bitmaps and number of buttons in
TOOLBAR_ReplaceBitmap().
2003-11-21 21:30:48 +00:00
Huw Davies 4a8e33954e We need to send TVN_EXPAND* on collapsing either when the user has
initiated it with the mouse/keybaord or in response to a TVM_EXPAND
when the state is not TVIS_EXPANDEDONCE.  This brings the logic into
line with TREEVIEW_Expand.
2003-11-21 21:30:20 +00:00
Dimitrie O. Paun c594043316 Make the controls send notifications to the parent window passed to
them in CREATESTRUCT.  Based on a treeview patch by Igor Grahek.
2003-11-20 22:04:13 +00:00
Dimitrie O. Paun 6443ee58bc Cleanup the edit wndproc a bit. 2003-11-20 04:19:59 +00:00
Dimitrie O. Paun e5762652d2 Remove some dead code: hwndParent is not used anywhere. 2003-11-20 04:19:41 +00:00
Ivan Leo Murray-Smith 15a9d28707 Added/updated Italian resources. 2003-11-19 02:14:44 +00:00
Huw Davies a63270f183 Unswap Page Up & Down and fix TBS_DOWNISLEFT.
NM_* notifications go via WM_NOTIFY not WN_?SCROLL.
Pull the notification window from the CreateStruct.
Send a TB_THUMBPOSITION at the end of a drag.
2003-11-18 19:39:40 +00:00
Rein Klazes b76e883344 The LVN_GETDISPINFO notify message should point to the same iSubItem
as in the call to LISTVIEW_GetItemT, valid or not. Fix a badly placed
brace.
2003-11-18 19:38:30 +00:00
Aric Stewart 89ba8760f3 We need to make sure that customdraw_fill is called even if
CDRF_NOTIFYITEMDRAW is not being used because we used the text and
background colors from that struct later.
2003-11-18 00:04:27 +00:00
Rein Klazes 7b6b9d6e93 Ignore invalid iSubItem in LISTVIEW_GetItemT(). 2003-11-17 20:01:49 +00:00
Huw Davies 83e9fd8513 Implemented LVS_EX_CHECKBOXES. 2003-11-13 20:50:25 +00:00
Dmitry Timoshkov d6872aff18 Avoid setting infoPtr->firstVisible to NULL in TREEVIEW_Sort. 2003-11-13 20:49:00 +00:00
Huw Davies 50c9ff030f Fix some weird logic in ImageList_Write. 2003-11-12 22:41:44 +00:00
Huw Davies ac24a0a692 A multicolumn listview should get a customdraw notification for the
item as well as one for subitem 0.
2003-11-12 22:41:27 +00:00
Huw Davies 818c5861c4 Add support for LVS_EX_SUBITEMIMAGES. 2003-11-11 00:26:15 +00:00
Robert Shearman fc58ef8119 Added chevron support. 2003-11-09 00:28:24 +00:00
Huw Davies a7c4fa8119 ReleaseCapture on lbuttondown if the cursor is outside an item, just
like the native one does.
2003-11-09 00:27:20 +00:00
Huw Davies 4de17c3724 LISTVIEW_GetSubItemRect should succeed if subitem == 0 whatever mode
the listview is in.
2003-11-05 00:35:57 +00:00
Rein Klazes 56121b7161 Correctly place a toolbar with CCS_BOTTOM style at the bottom, not the
top.
2003-11-05 00:35:28 +00:00
Huw Davies e63e39f2c5 PropSheetPageProc callback should always have hwnd = 0. 2003-11-04 04:23:00 +00:00
Alexandre Julliard 55cb8177b5 Authors: Ulrich Czekalla <ulrich@codeweavers.com>, Huw Davies <huw@codeweavers.com>
Added drag and drop support to listview.
2003-11-04 04:22:37 +00:00
Huw Davies 3ce815e7f3 Fix a fixme. 2003-11-04 04:22:07 +00:00
Huw Davies f94159cdb2 Don't get confused if PSN_SETACTIVE returns a positive number that
isn't a resource id.
2003-11-03 22:15:39 +00:00
Huw Davies b37adfb4b5 Make the listview send its notifications to the parent window passed
to it in CREATESTRUCT.  Based on a treeview patch by Igor Grahek.
2003-11-03 22:15:22 +00:00
Robert Shearman 90f3057b41 - Use the style returned in custom draw structure to draw the button,
as apps may modify the style this way.
- Disabled buttons can become hot.
- Retrieve image list for drawing after getting image list ID (in
  I_IMAGECALLBACK case).
2003-10-31 00:08:39 +00:00
Vitaliy Margolen 785bae8aae - Fix tab size for TCS_OWNERDRAWFIXED style.
- Correct size recalculation after setting tab width.
- Fix button sizes to match native.
- Center both vertically and horizontally tab text & icon.
- Use correct left/center alignment flags.
2003-10-31 00:06:42 +00:00
Francois Gouget f405629e8e Weekly spelling fixes. 2003-10-28 21:45:30 +00:00
Hans Leidekker a2977cf5b8 Added Dutch translations. 2003-10-27 22:04:36 +00:00
Robert Shearman fad1e1108e Don't store band text if "" is passed into SetBandInfo. 2003-10-24 04:18:42 +00:00
Maxime Bellengé ed3847247e Fix TAB_DeleteItem and TAB_DeleteAllItems regressions introduced by
the last TAB_InvalidateTabArea changes.
Correct the indentation for these functions.
2003-10-21 23:44:03 +00:00
Mike McCormack 8a6ca5ad3f Don't use free'd pointer in status control - found by Valgrind. 2003-10-21 23:43:14 +00:00
Adam Gundy c2d90611f6 Only send TVN_ITEMEXPANDING for items marked as having children. 2003-10-15 21:01:54 +00:00
Maxime Bellengé 5b99b3df29 - Implemented HEADER_SetBitmapMargin and HEADER_GetBitmapMargin.
- Get rid of some magic numbers in HEADER_DrawItem.
- Fixed the drawing of images from imagelist when the
  HDF_BITMAP_ON_RIGHT flag is set.
2003-10-14 20:13:42 +00:00
Maxime Bellengé 8147ee1095 Only redraw the necessary area of the tab component and not the whole
component like windows does.
2003-10-14 20:12:05 +00:00
Vitaliy Margolen bd7bdbce3f Fix setting size of tab control. 2003-10-14 01:16:16 +00:00
Dimitrie O. Paun fbdfd910c1 Remove SYMBOLFILE and LDDLLFLAGS from Makefiles. 2003-10-11 01:09:15 +00:00
Daniel Marmier ee1eb63b31 Fixed warnings with gcc option "-Wwrite-strings". 2003-10-07 03:30:47 +00:00
Dimitrie O. Paun 54e6b0d938 Extract binary resources to files, to fit the standard. 2003-10-03 05:01:33 +00:00
Pavel Roskin 5b7f03cf9f Ignore window caption from PROPSHEETHEADER in wizards. Update window
caption when changing pages.
2003-10-02 04:26:53 +00:00
Dimitrie O. Paun 7de279a73a Rename COMCTL32_{Alloc,ReAlloc,Free} to {Alloc,ReAlloc,Free}. 2003-09-22 21:32:33 +00:00
Vincent Béron bf5f07a5b4 Yet another batch of French resources updates. 2003-09-22 21:16:56 +00:00
Maxime Bellengé e5cd5a778a When an item is activated, we should send a NMITEMACTIVATE struct and
not a NMHDR one.
2003-09-22 19:27:33 +00:00
Alexandre Julliard 10aacbf3ef Renamed the COMCTL32_* functions to use the exported name. 2003-09-17 22:42:04 +00:00
Alexandre Julliard f5cb3dde17 Moved undocumented functions out of the exported commctrl.h. 2003-09-17 20:15:21 +00:00
Alexandre Julliard 1084a8ba93 Moved out of windef.h a few definitions that don't belong there
(reported by Filip Navara).
2003-09-17 04:31:27 +00:00
Alexandre Julliard 9d61596624 SLOWORD and SHIWORD do not exist on Win32 (reported by Filip Navara). 2003-09-17 04:28:28 +00:00
Filip Navara 2773106058 Fixed definitions of TTTOOLINFOA/W_V1_SIZE and
REBARBANDINFOA/W_V3_SIZE.
2003-09-16 01:17:25 +00:00
Robert Shearman d973bfb1c1 - Make sure dropdown arrow is always centered.
- Add support for the TBNRF_HIDEHELP customization flag, but emit a
  FIXME when it isn't present.
2003-09-12 00:21:57 +00:00
Robert Shearman 5dbf835b43 Add proper names to ordinal-only functions. 2003-09-11 01:04:24 +00:00
György 'Nog' Jeney 80428c4c9d Fix invalid C constructs (spotted by Marcus Meissner). 2003-09-11 01:03:27 +00:00
Alexandre Julliard cf52644a1c Removed the A/W constants for builtin cursors, icons and resource
types since they don't exist on Windows, and added typecasts
everywhere instead.
2003-09-10 03:56:47 +00:00
Francois Gouget ae50013017 Fix the case of product and company names. 2003-09-08 19:38:45 +00:00
Alexandre Julliard e37c6e18d0 Fixed header dependencies to be fully compatible with the Windows
headers (with help from Dimitrie O. Paun).
2003-09-05 23:08:26 +00:00
Dimitrie O. Paun 6d0019fb0e Adjust selection ranges before we insert the item so we don't mix the
new selection with the existing ones (reported by Eric Pouech).
2003-09-04 19:38:44 +00:00
Stefan Leichter c7a539d8e1 Updated minor version number. 2003-09-04 00:04:16 +00:00
Kevin Groeneveld 3219ae74fb Change default range of up-down control to match range used in
window.
2003-09-02 23:05:21 +00:00
Maxime Bellengé bcd1222650 Implemented TAB_SetMinTabWidth and TAB_HighlightItem. 2003-09-02 00:56:43 +00:00
Dimitrie O. Paun dad477ce3f If we don't send custom draw messages for subitems, inherit the color
& text attributes of the main item.
2003-09-01 23:55:33 +00:00
Rok Mandeljc d4c1ebabdb Minor updates of Slovenian translations. 2003-08-29 22:21:43 +00:00
Mike Hearn b79fc16577 Avoid division by zero when the imagelist is created with a width of
zero (ie no images).
2003-08-29 22:10:25 +00:00
Duane Clark 78cd28793a Button width should be the larger of text width/bitmap width. 2003-08-27 23:11:35 +00:00
Dimitrie O. Paun 31d4a7c47f Always setup the selection colour, not just in custom draw. 2003-08-25 23:44:51 +00:00
Dimitrie O. Paun 2fb93f1b85 Fix the hit test for full row select in REPORT mode (found, debugged,
and tested by Eric Pouech).
2003-08-25 00:53:11 +00:00
Maxime Bellengé cb1c112dd6 Fix the creation of treeview with checkboxes. 2003-08-23 23:18:48 +00:00
José Manuel Ferrer Ortiz 5069edc2de More Spanish translations. 2003-08-23 23:04:49 +00:00
Filip Navara 1ccaaa1a82 Fixed prototypes of CreateStatusWindowA/W, ImageList_Copy,
ImageList_EndDrag, ImageList_SetImageCount.
2003-08-22 23:51:15 +00:00
Maxime Bellengé 3db30e376c Fix unreachable TVHT_ONITEMSTATEICON in TREEVIEW_LButtonDown. 2003-08-19 00:57:08 +00:00
Maxime Bellengé fb39442d7f Fix things broken by the last TREEVIEW_UpdateDispInfo patch. 2003-08-18 19:46:31 +00:00
Maxime Bellengé 305fda2ef8 Fix for TREEVIEW_UpdateDispInfo to test with the correct callbackMask. 2003-08-13 19:37:12 +00:00
Dmitry Timoshkov 4d1d5fd353 Accept SIZE_MAXIMIZED as one of statuses of MDI windows. 2003-08-11 18:42:47 +00:00
Duane Clark 0d5aae1a0d Oops, back to hard coding initial thumb size until we figure out how
it really should work.
Fix the channel size/selection range for the TBS_ENABLESELRANGE
style.
One pixel tweaks in several spots.
2003-08-06 22:05:11 +00:00
Stephan BEUZE 767070203d - Avoid division by zero in TRACKBAR_GetTicPos
- Manage negative range TRACKBAR_DrawOneTic
2003-08-05 18:25:26 +00:00
Duane Clark 9ebf12c36d The initial size of the thumb depends on SM_CYCAPTION.
Correctly draw the thumb as in Windows.
The channel/thumb position also depends on TBS_NOTICKS.
The first and last tic marks should be inset from the channel length
by half the thumb width.
When TBS_BOTH style set, make sure to draw both sets of tics.
2003-08-02 00:44:00 +00:00
Stefan Haller 43858e4d0d Ignoring LISTVIEW_ScrollColumns() request if no columns in list. 2003-07-24 00:03:13 +00:00
Martin Fuchs bb40b30640 Send TVN_ITEMEXPANDING when the user tries to expand a tree item
_before_ checking for child items.
2003-07-21 22:04:42 +00:00
Mike McCormack ec0d425278 Set defaults for the Next/Prev button. 2003-07-21 20:01:59 +00:00
Francois Gouget 56aaea2f43 Spelling fixes. 2003-07-09 02:52:57 +00:00
Mike McCormack fc86392af8 Preserve A/W when creating propsheet dialogs. 2003-07-09 02:49:52 +00:00
Dmitry Timoshkov 4e1ef0c114 For all DLLs with defined DllMain and which do not require
DLL_THREAD_ATTACH/DLL_THREAD_DETACH notifications, call
DisableThreadLibraryCalls() in order to slightly improve performance
on thread creation/exiting.
2003-06-30 20:53:48 +00:00
Marcelo Duarte de08661413 - Localization to Portuguese of Brazil
- Revision and addition of missing resources
- Minor typo fix and codepage fix in programs/winefile resource.
2003-06-30 20:22:35 +00:00
Francois Gouget 9591836ffb 'sizeof type' is best avoided as it won't always compile (e.g. 'int
main() {return sizeof int;}'). Use 'sizeof(type)' instead.
2003-06-18 19:45:22 +00:00
Francois Gouget c5f775a9c7 Typos/spelling fixes. 2003-06-18 03:30:39 +00:00
Mike Hearn d2b8e39b5c - Unbreak vertical trackbars
- Make it more closely resemble the native control
- Add focus rectangle
- Misc fixes and cleanups
2003-06-16 19:39:27 +00:00
Robert Shearman 7614f27f3b - Make button text centre correctly when dropdown arrow is present
- Centre dropdown arrow
2003-06-13 16:30:24 +00:00
Dimitrie O. Paun 36d0e2ba63 Align the text vertically in single line labels (spotted by BiGgUn). 2003-06-06 18:13:47 +00:00
Dimitrie O. Paun bc9de0500e Remove bFirstPain funky optimization, it is causing too much grief. 2003-06-04 20:19:11 +00:00
Maxime Bellengé 66855d4a22 Fix listview custom draw notification for CDDS_ITEMPREPAINT and
CDDS_SUBITEMPREPAINT messages.
2003-05-22 03:37:10 +00:00
Robert Shearman f644c787ee Update ordering on insertion of an item. 2003-05-22 03:34:54 +00:00
Dimitrie O. Paun bb993e0127 Inserting column zero should not modify the main item (spotted by
Robert Shearman).
2003-05-21 18:25:10 +00:00
Uwe Bonnes 2c4fd4289c New comctl32 test directory and test case for DPA_Search. 2003-05-15 23:58:48 +00:00
Uwe Bonnes 29ef801b40 DPA_Search: Handle DPAS_INSERTBEFORE on empty list. 2003-05-15 23:55:12 +00:00
Vitaliy Margolen d8d12a0bca Revert change for resizing buttons. 2003-05-13 23:38:01 +00:00
Ulrich Czekalla 535e0f6238 Fixed bad non-client calculation. 2003-05-13 22:05:50 +00:00
Huw Davies 89e2766fc7 Fix DTM_SETSYSTEMTIME.
Make the show/hide button actually do something.
Add support for the 'yyyy' format.
2003-05-13 22:04:40 +00:00
Vitaliy Margolen 32eb1c7354 Get rid of direct ImageList access hacks. 2003-05-13 03:36:54 +00:00
Vitaliy Margolen e43edbd557 Rearrange members of HIMAGELIST to match Windows.
Reuse image and mask DCs.
2003-05-13 03:36:27 +00:00
Robert Shearman c00aa9985a Fix use of freed memory. 2003-05-13 00:30:10 +00:00
Huw Davies 130e21795c Fixed a possible memory corruption.
Fixed a memory leak.
2003-05-12 03:19:35 +00:00
Stephan Beuze 442dd75420 Implemented Get/SetToolTips functions. 2003-05-11 03:44:13 +00:00
Alexandre Julliard dd74d9d889 Ordinals 410-413 are the window subclassing functions. 2003-05-11 03:40:59 +00:00
Dimitrie O. Paun c6e988eaa0 Fix custom draw for item 0. 2003-05-11 03:29:25 +00:00
Huw Davies 5594fcea74 Invalidate the window when the range is changed. 2003-05-11 02:38:05 +00:00
Igor Stepin 97b7bc1984 Added a lot of Russian translations. 2003-05-04 02:33:08 +00:00
Adam Gundy a982259e3e When items are inserted in a partially populated treeview, the first
visible item was not correctly updated.
The first visible item was sometimes used to calculate the location of
other items when it had been freed.
2003-05-02 20:15:36 +00:00
Adam Gundy 06d610ec9b Check the mask flags in the item structure to determine how much
memory to read/write.
2003-05-02 20:14:33 +00:00
Mike Hearn 266a2f297e Change return code comparison in AVI control (from patch by
stanleyg76@yahoo.com).
2003-04-30 23:59:46 +00:00
Maxime Bellengé 0485fc19b6 Fix bounding rectangle computation for an ownerdraw tab. 2003-04-30 00:50:26 +00:00
Dimitrie O. Paun dfdeaaf922 Generate custom draw notifications for ownerdraw listviews (based on a
patch by Maxime Bellengé).
Reorganize the custom draw code for better reuse.
2003-04-30 00:49:44 +00:00
Stephan BEUZE 8410e71fb5 Implemented message TCM_SETPADDING with the Dimitri's advice. 2003-04-27 20:34:30 +00:00
Maxime Bellengé dcaf137736 Fix the computation of the trackbar's size. 2003-04-27 00:31:06 +00:00
Maxime Bellengé 5b44c77fb4 Remove the sending of NM_TOOLTIPSCREATED which is non existent under
Windows during the creation of the trackbar.
2003-04-26 02:07:43 +00:00
Vitaliy Margolen 4bddbe8b19 Fix buffer overflow in datetime. 2003-04-02 23:25:01 +00:00
Adam Gundy 9e3772f699 Zero initialize the reserved bytes in the toolbar details returned by
TOOLBAR_GetButton().
2003-04-02 23:19:45 +00:00
Vitaliy Margolen 1420acef09 Fix ImageList_Read - the root cause of ugly toolbar icons. 2003-04-02 23:18:17 +00:00
Mike Hearn d0300d92e3 TreeView should not send two click notifications when bTrack is true. 2003-03-27 00:00:42 +00:00
Mike Hearn b27587dd0a TREEVIEW_GetItemA should ignore stateMask. 2003-03-26 23:35:50 +00:00
Mike Hearn 044a353161 Correct the check for changed treeview items, so item sets repaint
properly.
2003-03-26 01:22:10 +00:00
Dimitrie O. Paun a50bd8117f Send LVN_ODCACHEHINT notification for LVS_OWNERDATA style in all modes
(based on a patch by Vitaliy Margolen).
2003-03-24 19:28:50 +00:00
Alexandre Julliard 114a31a2a8 Take advantage of new winebuild syntax to remove redundant function
names in spec files.
2003-03-20 03:53:12 +00:00
Jon Griffiths cd4234aa49 Documentation updates. 2003-03-18 18:35:48 +00:00
Mike Hearn c7b1874b54 Fix the tab height so the labels don't clip, and restore the offset
constant to what it was before.
2003-03-17 04:43:26 +00:00
Mike Hearn 22813d4634 Fix a typo. 2003-03-17 04:43:05 +00:00
Vitaliy Margolen eded087e4e Changes for Icon and SmallIcon modes:
- fix typo causing wrong scroll boundaries
 - reverse mouse wheel scroll directions
 - fix navigation with keyboard when auto arranged
2003-03-15 00:05:46 +00:00
Dimitrie O. Paun d39af613a3 Spacing information is signed (debugged and fixed by Vitaliy
Margolen).
Decode spacing information in the window procedure.
Some spelling fixes.
2003-03-14 22:58:22 +00:00
Tony Lambregts 7ce3a5ad63 Replace DPRINTF with TRACE. 2003-03-14 04:11:17 +00:00
Mike Hearn c6914b202a - Reduced tab offset constant slightly to avoid clipping the label.
- Prevent label overdraw of updown control by reducing the width of
  the invalidated region.
2003-03-12 20:14:12 +00:00
Mike Hearn 6b2d22a0f6 It's not just height that can be set to the default by passing zero to
TCM_SETITEMSIZE, but also width.
2003-03-10 19:04:13 +00:00
Adam Gundy a4944ff123 TOOLBAR_AddBitmap() and TOOLBAR_ReplaceBitmap() are not supposed to
modify the bitmap - we call ImageList_AddMasked() which turns all
masked pixels black. Fixed by making a copy of the bitmap to give to
ImageList_AddMasked().
2003-03-07 23:02:46 +00:00
Adam Gundy 64eff97f51 When shifting the list's indices, we must not send notify messages if
we have to refocus. Item modification handlers are not supposed to be
called here.
2003-03-07 20:35:30 +00:00
Adam Gundy 1af319d9e2 PROPSHEET_CreateDialog() is documented to return -1 on failure, and
the dialog handle on success.
2003-03-07 20:29:58 +00:00
Tony Lambregts e295d3996e Janitorial. Get rid of W->A call. 2003-03-06 22:43:43 +00:00
Adam Gundy 292d8429ab TREEVIEW_UpdateScrollBars() now copes with an empty tree. 2003-03-06 22:41:59 +00:00
Vitaliy Margolen e6af4ec6bd Fix invisible tabs in TabControls with fixed tab width. 2003-03-04 04:34:03 +00:00
Tim Segall efa2b0c159 Accept either TVI_ROOT or NULL for the parent to imply sort the entire
tree.
2003-02-25 03:59:12 +00:00
Michael Stefaniuc 745a78f490 Remove some unreachable code. 2003-02-24 20:48:45 +00:00
Eric Pouech a89063e3dc Added handling for PSNRET_INVALID in PSN_APPLY notification. 2003-02-24 20:40:45 +00:00
Duane Clark 65a9f4daac Support the undocumented behavior of deleting column zero. 2003-02-14 23:31:45 +00:00
Dimitrie O. Paun 00ccf38987 Correctly remember the first paint event, but delay item metrics
calculation until we actually have some items.
2003-02-14 19:24:11 +00:00
Gerald Pfeifer 820157b836 Avoid warnings caused by assert(...). 2003-02-12 21:28:04 +00:00
Dimitrie O. Paun 15e0657f6b Compute matrix of first paint when we actually have some items
(problem first spotted & debugged by Duane Clark).
2003-02-11 22:17:31 +00:00
Alexandre Julliard 43690e9e47 Removed no longer needed inclusion of heap.h. 2003-01-24 00:54:58 +00:00
Francois Gouget 9b0b1e078a Remove (POINTER)NULL casts. 2003-01-14 23:43:41 +00:00
Dan Kegel 0fd521fee3 Change RECT to use LONG to match win32 standard headers and fix format
strings to use %ld for RECT elements.
2003-01-08 21:09:25 +00:00
Dimitrie O. Paun 297f3d898d Define NONAMELESS{STRUCT,UNION} explicitly in the files that need them. 2003-01-07 20:36:20 +00:00
Alexandre Julliard b4a4c05aed Removed a few more #ifdef __WINE__. 2003-01-04 00:19:17 +00:00
Dimitrie O. Paun cef5961d2b Eliminate lots of __WINE__ conditionals from the headers. 2003-01-03 19:12:55 +00:00
Lionel Ulmer 5e36ae56b2 Check the value of the pfnCallback in addition to the callback bit. 2003-01-03 03:06:42 +00:00
Chris Morgan fa93b446d0 Listview should scroll by at least one column, fixes bug where item
being wider than listview prevents any scrolling from occuring.  Added
printing of the scroll code text during tracing of scroll functions.
2003-01-03 03:04:22 +00:00
Rein Klazes 0e162e4643 Let ANIMATE_OpenA return FALSE (= failure) upon a request to close a
previously opened AVI clip when there isn't one.
2003-01-02 17:54:23 +00:00
Duane Clark 521aa7412d Validate imagelists with christmas magic. 2003-01-02 17:51:13 +00:00
Duane Clark 3d2e380244 Report mode padding tweaks.
Fix to LISTVIEW_GetSubItemRect.
2002-12-23 02:02:06 +00:00
Rolf Kalbermatter 6c79930413 Add config.h/port.h to allow compilation/linking in MSVC.
Fix some unsigned/signed warnings.
2002-12-16 22:43:58 +00:00
Robert Shearman 096becedd8 Implemented StrStrIW. 2002-12-13 23:25:59 +00:00
Rolf Kalbermatter 4f7ec6335c Typo found by compiling with standard MSVC warning level. 2002-12-13 00:35:44 +00:00
Dimitrie O. Paun 9c50730354 Get rid of generic notification support in comctrl32. The MS docs were
misleading in that all controls send these notifications. They don't.
2002-12-10 19:07:59 +00:00
Dimitrie O. Paun 5720007370 - Plug a bunch of memory leaks.
- Make ranges_destroy behave more like free().
- Fix messed up indentation from tabs set to 4 chars.
- Updated the documentation.
2002-12-10 19:07:27 +00:00
Francois Gouget 3db0008552 Define PSH_WIZARD97 (problem reported by jaymz@free.fr). 2002-12-06 23:19:54 +00:00
Ove Kaaven 1f5315c80f Make sure that no files except unknwn.h include wine/obj_base.h
directly.
2002-12-05 20:33:07 +00:00
Alexandre Julliard 18d029722f Removed input.h, queue.h, spy.h and sysmetrics.h and moved their
contents to user.h.
Moved message.h and winproc.h to dlls/user.
2002-12-03 23:34:52 +00:00
Francois Gouget d2667a4ce3 Removed unnecessary HANDLE typecasts. 2002-12-02 18:10:57 +00:00
Dimitrie O. Paun d2e881d543 - Typesafe parameters from TREEVIEW_NotifyFormat.
- Rewrite TREEVIEW_NotifyFormat.
- Fix several invocations of TREEVIEW_SendTreeviewNotify.
2002-11-27 20:15:49 +00:00
Andreas Mohr 1e6258fca5 Added the missing cx member to the MyDLGITEMTEMPLATEEX struct. 2002-11-25 02:45:19 +00:00
Aric Stewart eb56d81956 LVN_GETDISPINFO seems to always be Ansi. 2002-11-25 01:11:11 +00:00
Tisheng Chen 80a6620815 Added Simplified Chinese support. 2002-11-20 19:47:44 +00:00
Alexandre Julliard bb0fd59674 Setting the horizontal scrollbar can change the values for the
vertical one so make sure we compute them separately.
2002-11-18 19:51:11 +00:00
Dimitrie O. Paun 0fe326c499 Use DeleteDC instead of DeleteObject to free HDCs (spotted by Dietrich
Teickner <Dietrich_Teickner@t-online.de>).
Clear the imagelist structure on deletion, as some stupid apps free
imagelists multiple times.
2002-11-18 19:45:22 +00:00
Ulrich Czekalla fbf98737d2 - Add support for multiple image lists.
- Add TBN_INITCUSTOMIZE notification.
- Correctly populate TBN_QUERYDELETE.
- Support TBN_GETBUTTONINFOW.
2002-11-13 21:21:03 +00:00
Huw Davies 8d74ef1030 Check the return value of ImageList_GetImageInfo before adjusting the
size.
2002-11-13 19:39:09 +00:00
Rolf Kalbermatter 91befd6902 Fix some NULL dereferencing. 2002-11-11 22:19:42 +00:00
Dimitrie O. Paun add721769b Do not draw the text of the item being edited. 2002-11-06 22:32:00 +00:00
Dimitrie O. Paun c6ff9064d0 Fix the 'jumping selection' bug (#1108).
Misc small cleanups.
2002-11-06 22:01:56 +00:00
Alexandre Julliard 1e1313d54c Made the dll entry point default to DllMain and removed most of the
'init' spec file declarations.
2002-11-04 23:53:41 +00:00
Carlos Lozano 5347222b23 lParam was not properly sent in COMBOEX_DrawItem. 2002-10-31 22:02:47 +00:00
Dimitrie O. Paun 40dab82a13 Append columns with large column indices. 2002-10-31 22:01:33 +00:00
Dmitry Timoshkov 601a3abec1 Fix some types and function prototypes according to Platform SDK
definitions.
2002-10-31 01:04:39 +00:00
Dimitrie O. Paun 4bbd7b3e26 Fix some treeview notification codes between ANSI/Unicode mode. 2002-10-31 00:54:53 +00:00
Rein Klazes d9310e76c4 Fix for listview wheelmouse message handling. 2002-10-29 23:08:33 +00:00
Sander van Leeuwen f9768f4792 Fixed font object leak in WM_SETFONT handler. 2002-10-29 21:28:37 +00:00
Dimitrie O. Paun 02af550a2a Send the right notification code (A/W) depending on the Unicode
setting.
2002-10-29 21:25:35 +00:00
Alexandre Julliard 26a470e1f0 set_main_item: ignore meaningless bits in stateMask for LVS_OWNERDATA
instead of failing.
2002-10-28 21:21:42 +00:00
Dimitrie O. Paun 2d2e6acbbd We should always have a main item in report mode. 2002-10-28 20:40:21 +00:00
Dimitrie O. Paun 7e12841030 Properly fill lParam in NMLISTVIEW. 2002-10-28 20:38:39 +00:00
Dimitrie O. Paun 173d40a493 Fix crash-inducing typo/thinko. 2002-10-28 20:38:03 +00:00
Dimitrie O. Paun 5574e750c5 Mark immutable objects as const. Fix inconsistent *-style. 2002-10-28 20:37:28 +00:00
Dimitrie O. Paun f5221578f6 Add LVHITTESTINFO debug helper. More tracing. 2002-10-28 20:36:52 +00:00
Dimitrie O. Paun 17b97eb929 Despite what the docs say, we have to invalidate the list on
WM_SETREDRAW(TRUE).
2002-10-28 20:36:16 +00:00
Dimitrie O. Paun ccc8f7dca9 Eliminate flicker when resizing, docs updates. 2002-10-28 20:35:44 +00:00
Dimitrie O. Paun 19a1c42386 Cleanup, and simplification of UpdateSize. 2002-10-28 20:35:09 +00:00
Dimitrie O. Paun 9a9fcab763 Handle focus item properly in SetItemCount. 2002-10-28 20:34:34 +00:00
Dimitrie O. Paun f9e70d8b81 Remove only the necessary selections when setting the item count. 2002-10-28 20:34:00 +00:00
Dimitrie O. Paun 28a2f193a3 Rewrite of the SetItemCount: bugs got squashed,
LVSICF_{NOSCROLL,NOINVALIDATEALL} implemented.
2002-10-28 20:33:18 +00:00
Carlos 5803819971 lParam was not properly sent in TTM_ADDTOOLW. 2002-10-28 18:50:36 +00:00
Carlos 392defd3ef lParam was not properly sent in CBEN_GETDISPINFOW. 2002-10-28 18:50:14 +00:00
Andreas Mohr 6e256c72fe - fix some pselling
- enhance some TRACEs
2002-10-25 19:09:02 +00:00
Dimitrie O. Paun 5a11b009f1 Do not invalidate list on WM_SETREDRAW.
Update size info even if redrawing is disabled.
Trivial cleanups, and some tracing.
2002-10-25 03:21:25 +00:00
Dimitrie O. Paun 221398344e We can avoid flicker on column resize only if it's left align. 2002-10-25 03:20:43 +00:00
Dimitrie O. Paun fa5b29acd3 Always draw the main item in full row select. 2002-10-25 03:20:03 +00:00
Dimitrie O. Paun f7441d00ed Use iterators to render over the columns, in report mode. 2002-10-25 03:19:24 +00:00
Dimitrie O. Paun 863d6a87f5 Small iterator-over-range[s] cleanup. 2002-10-25 03:18:47 +00:00
Dimitrie O. Paun 83679e6b88 Eliminate most of the flicker when resizing columns.
More debug tracing.
2002-10-25 03:18:07 +00:00
Dimitrie O. Paun ab97b86902 Fix subitem background color in full row select. 2002-10-25 03:17:36 +00:00
Dimitrie O. Paun b14c82a8b8 We should callback for inexistent subitems.
Do not store callback items for subitems, even if we're asked to.
Small cleanup.
2002-10-25 03:17:04 +00:00
Dimitrie O. Paun 16db256923 Fix crash when computing the item width of a report with no columns.
Override custom draw bkgnd color for selection items.
Fill background for all items that have a bkgnd colour.
2002-10-25 03:16:26 +00:00
Dimitrie O. Paun 3520c83275 Keep autoarranging items until one is moved. 2002-10-25 03:15:51 +00:00
Dimitrie O. Paun 01e82f2b27 Abstract autoarranging decision to a helper function. 2002-10-25 03:15:18 +00:00
Dimitrie O. Paun 5b8361463d Do not do screen work if refreshing is disabled.
Reimplement SetRedraw to cope with the changes.
2002-10-25 03:14:44 +00:00
Dimitrie O. Paun c4e45d7f94 Rewrite the UpdateScroll function: simpler, faster.
Add debugging helper for SCROLLINFO.
Fix potential bug in debugging helpers.
2002-10-25 03:14:06 +00:00
Dimitrie O. Paun 89ab25a737 Avoid division by 0 by initializing the item size in on creation.
Rename update_icon_size to set_icon_size, fix parameters order.
Assorted cleanups.
2002-10-23 23:32:50 +00:00
Dimitrie O. Paun 5ffde298fe Append to the end of the DPA, if insert index is too large. 2002-10-23 23:32:19 +00:00
Carlos 9fa51e4172 Fixed duplicated arrows in header control. 2002-10-23 23:31:35 +00:00
Dimitrie O. Paun b894605987 Fix thinko that slipped in with the prev patch (reenables refresh).
Mark a few things that needs looking at.
Small cleanup.
2002-10-23 22:32:25 +00:00
Dimitrie O. Paun 9cdcd44eaa Do not invalidate the window before the first paint job.
Assorted cleanups.
2002-10-23 22:31:47 +00:00
Dimitrie O. Paun f7051c88ae Use InvalidateItem instead of explicit InvalidateRect, it is cleaner,
and faster when redraw is disabled.
2002-10-23 22:31:13 +00:00
Dimitrie O. Paun c093196c05 Transform the invalidation macros to proper functions. 2002-10-23 22:30:39 +00:00
Dimitrie O. Paun bf46fab650 Delay some size computations until after first paint. 2002-10-23 22:29:47 +00:00
Rein Klazes 7d9b04dbe2 Reorganize the item size calculation (a bit simpler, and faster). 2002-10-23 22:28:44 +00:00
Rein Klazes 1fd077939f Search through all items when LISTVIEW_FindItemW is called with
LVFI_PARAM flag.
2002-10-23 22:28:03 +00:00
Dimitrie O. Paun bf761a331c Delete the items if we actually own them. 2002-10-23 22:25:42 +00:00
Dimitrie O. Paun 8f15b6e6b3 Do not callback to the parent for lParam when in LVS_OWNERDATA.
Docs update.
2002-10-23 22:25:10 +00:00
Michael Stefaniuc 353529b2c8 - fix the "int format, HANDLE arg" type of warnings for comctl32
- compile the comctl32 dll with -DSTRICT
2002-10-23 22:19:10 +00:00
Michael Stefaniuc 85e40cf37a Add casts to compile with -DSTRICT. 2002-10-23 20:58:33 +00:00
Dimitrie O. Paun 5acd96bb4e Do not crash if callback text is not filled (behave like native).
Render report mode from top to bottom (easier on the eye).
Docs updates, type fixes, more traces.
2002-10-23 20:57:13 +00:00
Dimitrie O. Paun 6608328f76 Collect all bugs, missing features, etc in the header doc.
Minor cleanups.
2002-10-23 20:56:30 +00:00
Dimitrie O. Paun 9ff0da09ff Do not autoarrange if we insert/delete from the end of the list. 2002-10-23 20:55:05 +00:00
Dimitrie O. Paun c5da549d10 Rework SetItemPosition, bunch of bugs squashed in the process.
Complete icon alignment rewrite: cleaner, incremental, etc.
Completely avoid aligning all icons on every insert
  - icon placement is incrementally computed now: it's fast.
Small cleanups, docs update, etc.
2002-10-23 20:54:23 +00:00
Dimitrie O. Paun c5e2731939 Rename LISTVIEW_ITEM to ITEM_INFO for consistency.
Rename LISTVIEW_SUBITEM to SUBITEM_INFO for same reason.
Fix type in comment spotted by Bobby Bingham.
2002-10-23 20:53:42 +00:00
Patrik Stridvall cf07e10017 Don't use wine/unicode.h in the header files, include it directly
where needed instead.
2002-10-23 20:20:59 +00:00
Michael Stefaniuc f3d1893f80 Add needed casts for a "no warnings" compile of comctl32. 2002-10-23 20:19:22 +00:00
Christian Neumair 513eb2a24a Collect all bugs, missing features, etc in the header doc. 2002-10-23 18:43:32 +00:00
Dimitrie O. Paun d664540782 Bring header's height more inline with native's. 2002-10-22 00:41:45 +00:00
Dimitrie O. Paun 254e7484fa DPAs can't have more than 0x8000 elements (fixed with lots of help
from Carlos <clozano@andago.com).
2002-10-21 19:54:06 +00:00
Dimitrie O. Paun c7fbc1b2c9 No need to increment item size, it's already adjusted by DPA_SetPtr
(found, and fixed by Carlos <clozano@andago.com>).
2002-10-21 19:49:44 +00:00
Dimitrie O. Paun 6168b98176 Do not rely on HeapReAlloc to allocate a NULL pointer. 2002-10-21 19:49:12 +00:00
Dimitrie O. Paun 7888385d76 Rewrite DPA_InsertPtr in terms on DPA_SetPtr, so that it's simpler,
cleaner, and more correct.
It now expands the array to accomodate larger than current size
indexes.
2002-10-21 19:48:37 +00:00
Dimitrie O. Paun a87b685350 Do not send uninitialized lParams on notification msgs (found by Rein
Klazes <rklazes@xs4all.nl>).
2002-10-21 19:46:46 +00:00
Dimitrie O. Paun 6deae0b86d Complete rewrite of the rcView implementation.
Lots of bugs fixed in rcView computation.
Assorted cleanups, and simplifications.
2002-10-21 19:46:08 +00:00
Dimitrie O. Paun c9e0133357 Split ranges_destroy in ranges_clear, and ranges_destroy.
Rewrite DeleteAllItems, for cleaner, faster, more correct code.
2002-10-21 19:45:29 +00:00
Dimitrie O. Paun 62f4c61d22 Updated header documentation to the latest, and greatest. 2002-10-21 19:44:51 +00:00
Dimitrie O. Paun 06701fb09e Optimize invalidation on insert.
Share the invalidation code between {Delete,Insert}Item.
2002-10-21 19:44:18 +00:00
Dimitrie O. Paun f18e271bff Rewrite DeleteItemT: cleaner, a lot faster.
Number of bug were fixed.
The minimum possible is redrawn.
2002-10-21 19:43:37 +00:00
Dimitrie O. Paun c859242ac8 Implement most of LVM_ARRANGE.
Make use of it, where it was appropriate.
Use infoPtr->dwStyle directly, in most places.
Assorted cleanups.
2002-10-21 19:43:03 +00:00
Dimitrie O. Paun 56c17651a0 Proper (type wise) return types. 2002-10-21 19:42:30 +00:00
Dimitrie O. Paun 214c721160 Reorganize header notifications.
Support notifications that don't have embedded size info.
Invalidate columns on format change (if needed).
Assorted cleanups.
2002-10-21 19:41:56 +00:00
Dimitrie O. Paun 713d0a061f Crash on internal NULL pointers, don't test all over the place. 2002-10-21 19:41:00 +00:00
Dimitrie O. Paun e37692bd33 When removing focus, no need to go through all elements. 2002-10-21 19:40:26 +00:00
Dimitrie O. Paun feb326118f Fix colors for selected items in full row select mode.
Fix bug caused by use of uninitialized state.
2002-10-21 19:39:45 +00:00
Dimitrie O. Paun 7c26e53ac0 Fix computation of subitem box, when invalidating it. 2002-10-21 19:34:38 +00:00
Dimitrie O. Paun 2223014df3 Assert on inconsistent range list states.
Various code cleanups, few potential bugs fixed.
2002-10-21 19:33:59 +00:00
Dimitrie O. Paun 074e2b4caa Do not grow the item list to arbritary index: if requested index is
larger than current count, just append.
Miscellaneous cleanups.
2002-10-21 19:33:14 +00:00
Dimitrie O. Paun be0641face SetColumnWidth rewrite: simpler, cleaner code. Bugs squashed. 2002-10-21 19:32:38 +00:00
Dimitrie O. Paun bf965278b5 Handle generic column width changes.
Fix bug in SetColumnT which rendered it unusable.
Column code cleanup.
2002-10-21 19:32:07 +00:00
Dimitrie O. Paun 0acaf0e961 Assert on internal invariants, rather than fail gracefully. 2002-10-21 19:31:34 +00:00
Dimitrie O. Paun 88c26b9c01 More docs compliant alignment handling for subitems. 2002-10-21 19:31:01 +00:00
Dimitrie O. Paun f8514f5b3c Fix notification from header, on item changed.
Small indentation fixes.
2002-10-21 18:22:51 +00:00
Duane Clark d126f4768c Correct the behavior for disabled toolbar buttons. 2002-10-21 18:19:02 +00:00
Dimitrie O. Paun 0def1dd4e4 Do not create a range list for an empty range. 2002-10-19 19:26:17 +00:00
Dimitrie O. Paun 0613b7212a Store the entire format bitmap in the column info.
Rewrite GetColumnT to take advantage of that.
Related cleanups, and simplifications.
2002-10-19 19:25:41 +00:00
Dimitrie O. Paun 569de03864 Column zero has the image enabled always, irrespective of format. 2002-10-19 19:25:01 +00:00
Dimitrie O. Paun 231e9ef25b Unify {Insert,Set}ColumnT as much as possible.
Fix a bunch of problems in SetColumnT.
2002-10-19 19:24:24 +00:00
Dimitrie O. Paun 3893cb7fb2 Fix function header documentation. 2002-10-19 19:23:31 +00:00
Dimitrie O. Paun e877b77a9d Better report mode.
Use the new column information to simplify, and speed up the code.
Enable support for images in subitems (in LVS_REPORT mode).
2002-10-19 19:20:35 +00:00
Dimitrie O. Paun 0dbab63fa6 When deleting an item, remove selection, don't add it! 2002-10-19 00:59:34 +00:00
Dimitrie O. Paun 0ba3dc7589 More traces to help us make sense of the output.
Faster, cleaner ranges_{add,del}.
2002-10-19 00:21:02 +00:00
Dimitrie O. Paun c79eb2de5f Fix ranges insertion bug (specify DPAS_SORTED when searching).
Add a lot of assert-ed consistency checks.
Add bunch of trace messages.
2002-10-19 00:20:21 +00:00
Dimitrie O. Paun a2dd8ecc33 Inspect style bits independently on style change. 2002-10-19 00:19:28 +00:00
Dimitrie O. Paun b50692ee82 Rewrite StyleChanged procedure
o some bugs have been fixed
  o cleaner, simpler code
Fix some corner case, icon size computation bugs.
Assorted docs updates.
2002-10-19 00:18:48 +00:00
Dimitrie O. Paun 323f9c23f0 Keep track of per-column information inside the listview.
Cache header rectangles.
Used the cached info instead of calling to the header each time.
Update the listview as we track column width changes.
Unify column handling between {Insert,Delete}Column, and width
changes.
Simplify RefreshReport, by using the new column info.
2002-10-19 00:18:11 +00:00
Dimitrie O. Paun a72e9f617e Do not query items that are just being inserted. 2002-10-19 00:17:24 +00:00
Dimitrie O. Paun f8f559fa3c Reorganize things a bit so that we no longer need the 'valid' flag on
each item.
Small comments update.
2002-10-19 00:16:37 +00:00
Alexandre Julliard 23bb3715f7 Added support for building certain dlls with -DSTRICT.
Added -DWINE_NO_STRICT flag to dlls that don't support STRICT yet.
2002-10-18 23:46:28 +00:00
Martin Fuchs fe7d46a221 pszText is stored as Unicode, so call DrawTextW() instead of
DrawTextA().
2002-10-18 00:20:04 +00:00
Dimitrie O. Paun c18c7332b8 Instrument SetItemT to change only _one_ item at a time. That is, if
we have to change focus, we call it recursively to first remove the
focus from the item that has it. This allows simpler, and more correct
invalidation handling.
2002-10-17 21:55:41 +00:00
Dimitrie O. Paun 8f38417376 Unify set_{owner,main}_item functions.
Fix {old,new}state and lParam reporting in LVN_ITEMCHANG{ING,ED}.
Fix sanity check conditions for LVS_OWNERDATA.
2002-10-17 21:54:57 +00:00
Dimitrie O. Paun 96dca36cc8 More, better tracing to help nail down some crashes.
Fix typo in GetItemT (found, and fixed by Huw Davies).
Exit right away from GetItemT if nothing is asked (mask == 0).
Assorted code cleanups.
2002-10-17 21:53:56 +00:00
Dimitrie O. Paun 305fb4c3dd Deal with sparsely populated listviews.
Crash on internal corruption.
2002-10-17 21:38:21 +00:00
Dimitrie O. Paun ef4a6fc7e5 Add ability to create an iterator over a range list.
Fix memory leak when destroying ranges.
Add function that will to a 'deep' clone of a range list.
Add function that will subtract a range list from another.
Do not crash on NULL ranges (similar in spirit to HDPAs).
Fancy deselection routines uses the above infrastructure to deselect
the minimum possible.
Modify SetGroupSelection to take advantage of all this new
infrastructure, to avoid flicker on selection extension.
2002-10-17 21:37:24 +00:00
Dimitrie O. Paun fa81ec674b Change the definition of ranges to exclude the upper bound. 2002-10-17 21:36:29 +00:00
Dimitrie O. Paun bac35001fe Handle range tracing in a consistent fashion. 2002-10-17 21:35:47 +00:00
Dimitrie O. Paun 58b2ad925b Remove dated comments. 2002-10-17 21:35:08 +00:00
Dimitrie O. Paun 66dd824dbc Better encapsulation of the ranges concept. 2002-10-17 21:34:15 +00:00
Dimitrie O. Paun be8189bd9c Notification code cleanup, more traces, etc. 2002-10-17 01:20:18 +00:00
Jerry Jenkins 7d789599d5 Added missing RemoveProp calls. 2002-10-17 01:18:52 +00:00
Dimitrie O. Paun 89eb8fdba3 We need to provide focus info always in ICON mode (spotted by Huw
Davies).
2002-10-16 19:57:31 +00:00
Mike McCormack bcfffe7b08 Duplicate selected items list in LISTVIEW_RemoveAllSelections to
prevent infinite loops.
2002-10-16 19:56:06 +00:00
Dimitrie O. Paun 3dd4dabffb Remember the global colors in custom draw mode. 2002-10-16 19:05:43 +00:00
Dimitrie O. Paun ef9adbb6f5 Compute only the old state that we're gonna look at. 2002-10-16 19:05:02 +00:00