Commit Graph

1589 Commits

Author SHA1 Message Date
Dimitrie O. Paun ad23586ce1 Pull the WM_TIMER handling into its own function.
ANIMATE_DrawFrame shouldn't worry about locking, the lock should be
held by the caller.
2005-03-21 11:27:49 +00:00
Robert Shearman 6a365e0074 iSelectedImage is allowed to be 0. 2005-03-21 10:51:14 +00:00
Dimitrie O. Paun dcd3fde210 Complete unicodification. 2005-03-21 10:30:33 +00:00
Dimitrie O. Paun d09baae23d Proper handling for GWL_STYLE.
Store and use hwndSelf in the PAGER_INFO.
Pass the infoPtr around instead of hwnd.
Use proper types in the function signatures.
Fix a few return statements.
2005-03-21 10:30:18 +00:00
Dimitrie O. Paun 3e7c8e78dc Delete the critical section when freeing up the infoPtr. 2005-03-21 10:27:58 +00:00
C. Scott Ananian f65e415d64 UPDOWN_GetBuddyInt should not fail when the control is empty. 2005-03-18 14:09:12 +00:00
Alexandre Julliard 654eee5291 Revert changes to the painting code, the WM_CTLCOLORSTATIC message
should not be sent from the animation thread.
2005-03-18 10:30:13 +00:00
C. Scott Ananian 793fd5646b Started a unit test case for the updown control. 2005-03-16 19:52:40 +00:00
Dimitrie O. Paun fa241ee719 Audit the control against Comctl32.dll version 6.0.
Proper handling of GWL_STYLE.
Implement WM_CLOSE. Fix WM_SIZE implementation.
Small cleanups.
2005-03-16 19:47:52 +00:00
Dimitrie O. Paun e3335ee7c1 Cleanup and simplify the painting code.
Fix a potential bug along the way.
2005-03-15 15:39:38 +00:00
Evan Deaubl 20c93c2c0d TREEVIEW_DoSelectItem should not do any of the TVGN_FIRSTVISIBLE work
if the newSelect parameter is NULL.
2005-03-14 10:51:06 +00:00
Jon Griffiths 6cf8602ebb Comment out a test that crashes on early versions. 2005-03-14 10:10:00 +00:00
Dimitrie O. Paun 5294ba5816 Unicodification and typesafe interfaces. 2005-03-14 10:09:24 +00:00
Dimitrie O. Paun 50a0c8f734 Unicodification. Small cleanups. 2005-03-03 13:51:47 +00:00
Francois Gouget fbb3343547 Assorted spelling fixes. 2005-03-02 13:53:50 +00:00
Robert Shearman 50d77e6877 - Fix one more place where the code assumes row indices are
zero-based.
- Document a known bug in the layout code.
2005-03-02 10:12:52 +00:00
Dimitrie O. Paun 5dfdd18abc Fix indentation for consistency with the rest of the file. 2005-03-02 10:08:29 +00:00
Filip Navara 65bd0962a8 Implement SB_SETBORDERS. 2005-03-01 11:44:38 +00:00
Robert Shearman 6d582fed50 - Make row number be zero-based.
- Improvements to dumping functions to not dump out fields that may
  not have been filled in.
2005-03-01 10:44:15 +00:00
Jon Griffiths 3388eb0885 Remove unneeded calls to TAB_GetInfoPtr(), const fixes, inline small
funcs & remove unused parameters.
2005-02-25 16:19:07 +00:00
Jon Griffiths eb5bf7dd38 Documentation spelling fixes. 2005-02-25 14:07:56 +00:00
Michael Stefaniuc 443f9273b1 - ImageList_LoadImage{A,W} were basicaly a cut'n'paste of each
other. Removed the A variant and did a A->W translation.
- ImageList_LoadImageW: get the bitmap size from the image itself and
  not from the mask (ImageList_LoadImageA did that).
2005-02-24 12:46:57 +00:00
Francois Gouget d95630ebf3 Add the -noname flag to match the Platform SDK. 2005-02-23 15:41:14 +00:00
Maxime Bellengé f28afa1047 Correctly displays the text with ellipsis when there is not enough
room in a header item and an image from an imagelist is displayed on
the right of the text.
2005-02-23 12:41:43 +00:00
Martijn Vernooij 2c2db4b486 Scroll instead of repainting when expanding/collapsing trees.
Don't repaint on hover if 'hot tracking' isn't on.
2005-02-22 19:31:01 +00:00
Maxime Bellengé 33c7e15f77 Take into account the new size of a column when the header size
change.
2005-02-21 20:38:31 +00:00
Maxime Bellengé 7462a8f53f Fix SetItem so that items don't get wrongly re-ordered. 2005-02-21 18:34:17 +00:00
Alex Villacís Lasso 18bfe6a095 Change SUBLANG_DEFAULT to SUBLANG_NEUTRAL for LANG_SPANISH in all
resources, so that Spanish locales other than Spain also use Spanish
resources.
2005-02-16 21:10:59 +00:00
Dmitry Timoshkov 39f960bdfa - Fix prototypes of GetClassLongA/W, GetClassLongPtrA/W and
SetClassLongA/W according to SDK definitions.
- Add prototypes for SetClassLongPtrA/W, protect some GWL_ and GCL_
  constants from using in Wine or in _WIN64 mode.
- Fix all places in Wine affected by the above changes.
2005-02-15 21:51:06 +00:00
Francois Gouget 4d801b66e6 Assorted spelling fixes. 2005-02-10 19:19:35 +00:00
Alexandre Julliard d7726c3a73 Store the "managed" flag as a window property instead of the
Wine-specific WS_EX_MANAGED style bit.
2005-02-01 18:53:59 +00:00
Thomas Weidenmueller e8e42e4614 When a toolbar doesn't have the TBSTYLE_FLAT style redrawing the
buttons when moving the mouse is not necessary.
2005-01-28 17:19:29 +00:00
Francois Gouget da8b3dd7f2 Assorted spelling fixes. 2005-01-26 21:09:04 +00:00
Tinus aee4f25ed6 Properly allow removing toolbar bitmaps by changing it into 0. 2005-01-24 18:59:13 +00:00
Alexandre Julliard 32d9dab38d Authors: Gunnar Dalsnes <hardon@online.no>, Ge van Geldorp <gvg@reactos.com>
STATUSBAR_SetTextT:
- ntext wasn't freed on return if text was unicode
- part->text was always freed, but if the previous style was
  SBT_OWNERDRAW, part->text would contain 32bit data
- free old text if new style is SBT_OWNERDRAW but old style wasn't
2005-01-21 16:18:38 +00:00
Paul Vriens f93a0780c9 Remove the checking/setting of the defaults in TRACKBAR_Create. 2005-01-17 13:38:44 +00:00
Paul Vriens 740d6bc3a0 Remove needless check for horizontal or vertical pager. 2005-01-17 13:38:28 +00:00
Dimitrie O. Paun 3bc9380619 Use the LVCFMT_{LEFT,RIGHT,CENTER} enumeration flags properly. 2005-01-14 16:21:41 +00:00
Jon Griffiths ae720e6d7c Increase the required rectangle size before drawing big +/-. 2005-01-14 15:13:24 +00:00
Robert Shearman fbcc21be62 Use the DrawFocusRect function to draw the focus rect, instead of a
broken home-brewed solution.
2005-01-11 10:43:03 +00:00
Robert Shearman 040850e8c5 Don't highlight text in non-TVS_TRACKSELECT mode. 2005-01-11 10:39:33 +00:00
Mike McCormack 07aa50bc48 Fix image list mask and blending. 2005-01-10 14:29:20 +00:00
Evan Deaubl c84832160c GetItemA/W on header controls should handle message even if index is
invalid.
2005-01-10 14:25:30 +00:00
Eric Pouech cf1d00bb08 Removed excessive statement (break after return or goto, not useful
break, not needed vars...)
2005-01-09 16:42:53 +00:00
Crestez Leonard 30cde9b1a8 Fix bug with Treeview_SelectItem reselecting the same item. 2005-01-07 15:34:25 +00:00
Ulrich Czekalla b13b2474da WM_GETTEXTLENGTH should return zero for owner drawn status bars. 2005-01-06 19:44:24 +00:00
Francois Gouget 9d589acc26 Assorted spelling fixes. 2005-01-04 20:39:54 +00:00
Vitaly Lipatov 6971e1d762 Add comments, fix negative value from GetCurFocus. 2005-01-03 20:12:42 +00:00
Michael Stefaniuc 5ad7d858e0 Do not check for non NULL pointer before HeapFree'ing it. It's
redundant.
2004-12-23 17:06:43 +00:00
Francois Gouget 6fb1a20020 Assorted spelling fixes. 2004-12-20 19:27:06 +00:00
Robert Shearman 10411d5fe5 - Make the month calendar child window auto-size instead of using a
hard coded 200px.
- Use SetFocus when the control is clicked on to get the correct
  behaviour when another control clicked on.
- Force the WS_EX_CLIENTEDGE style, instead of emulating it.
2004-12-20 17:00:46 +00:00
Ulrich Czekalla e05dcc2975 Add partial handler for WM_PRINTCLIENT. 2004-12-20 16:55:57 +00:00
Robert Shearman 1e92f4a3c7 - Add code for hot tracking.
- Draw hot items with underline and with highlight colour with
  TVS_TRACKSELECT style.
- Set cursor to hand cursor with TVS_TRACKSELECT style.
- Make sure uInternalStatus is consistent with actual scrollbar state
  by forcing scrollbars off in WM_CREATE handler.
2004-12-17 18:52:04 +00:00
Robert Shearman 1d2bdf5ab9 - Implement WM_ENABLE handler to update cached control style when the
control is disabled.
- Move background drawing into WM_ERASEBKGND handler and draw the
  background differently when disabled.
- Change WM_PAINT handler to draw text with transparent background and
  with the correct colour for the style.
- Initialize selected field to -1 instead of 0 so that the control
  notices when field 0 is selected.
2004-12-17 18:50:11 +00:00
Jon Griffiths 873cd009d0 Remove unneeded headers to reduce unneeded rebuilds. 2004-12-15 10:54:44 +00:00
Eric Pouech 4056d7ef8c Fixed some errors in function prototypes. 2004-12-13 21:19:01 +00:00
Jon Griffiths d6139af2da Implement the remaining MRU functions, fix a couple of differences
from native comctl32, add tests of MRU behaviour and documentation.
2004-12-10 15:31:38 +00:00
Alexandre Julliard ebe3c529b1 Janitorial: C booleans must not be compared against TRUE. 2004-12-09 14:07:59 +00:00
Thomas Weidenmüller a1f3756daa Free allocated font handles when control is destroyed. 2004-12-08 19:36:23 +00:00
Filip Navara 0e6c60076f - Don't use DrawEdge with NULL device context, it's invalid call and
sets last error.
- Tooltip icons must be destroyed with DestroyIcon and not with
  DeleteObject.
- Rebar cursors must be destroyed with DestroyCursor and not with
  DeleteObject.
2004-12-07 14:27:43 +00:00
Eric Kohl d267f993f9 DrawStatusText() must not process prefix characters. 2004-12-06 16:15:38 +00:00
Ulrich Czekalla 21970dc2f7 Prevent the animation thread from waiting on itself when it stops. 2004-12-01 15:27:18 +00:00
Dmitry Timoshkov 30bebfdc38 - Pass infoPtr around in month calendar control.
- Add support for WM_SETFONT and WM_GETFONT messages.
2004-11-30 17:35:16 +00:00
James Hawkins 88aeb475c0 Fixed a few memory leaks. 2004-11-30 17:33:27 +00:00
Robert Shearman d7dd3e37c8 Store the new style before redrawing and repositioning the control. 2004-11-30 17:28:10 +00:00
Alexandre Julliard a79c534c0e Avoid using the MAKEPOINTS macro, it's broken on big endian. 2004-11-24 18:28:31 +00:00
Huw Davies 3138b4a8fa The default font for the treeview should be the icon title font. 2004-11-21 15:41:08 +00:00
Zach Gorman 4b5a5868f1 Add the DT_NOPREFIX flag when calling DrawText() for single-line
listview controls.
2004-11-19 18:09:29 +00:00
Robert Shearman b98b7dd65d - Set cache bitmap dimensions correctly when a 0x0 image list is used.
- Optimize WM_STYLECHANGED handler to only redraw when a CCS_* style
  is changed, like native.
2004-11-10 01:30:47 +00:00
Dmitry Timoshkov 47361da574 - do not move updown control and buddy if an alignment was not requested
- in UDM_SETACCEL handler do not forget to update number of accelerators
- update arrows info in WM_LBUTTONDOWN as well as in WM_MOUSEMOVE
- use accelerators in WM_LBUTTONDOWN handler
2004-11-09 20:03:47 +00:00
Robert Shearman a9b1aa28b3 - bNtfUnicode is a dup' of bUnicode so remove it and fix the few
places where it was used.
- Remove a load of useless NULL infoPtr checks.
- Hardcode the default padding like native instead of using a wacky formula.
- Replace some tabs with spaces and remove NMHDR casts.
2004-11-08 22:17:02 +00:00
Dmitry Timoshkov 00176e33b3 Dimensions of month calendar control should not depend on the client
window size.
2004-11-08 20:27:02 +00:00
Robert Shearman 8d28e0314c Remove unnecessary WNDPROC casts. 2004-11-06 03:49:03 +00:00
Robert Shearman 75314f474f Implement TBN_RESTORE notification. 2004-11-06 03:45:38 +00:00
Dmitry Timoshkov d3eb0550f5 Convert NativeFont control to unicode, use hbrBackground as in native. 2004-11-01 21:08:10 +00:00
Dmitry Timoshkov 99a6afcd6c Do not retrieve infoPtr twice in ToolbarWindowProc entry. 2004-11-01 21:07:43 +00:00
Dimitrie O. Paun f07f08cfe6 Send notification messages in the format dictated by
infoPtr->notifyFormat.
2004-11-01 21:07:11 +00:00
Alexandre Julliard 7d716db7e7 Use correct type instead of void* in item linked list. 2004-10-27 21:37:02 +00:00
Dimitrie O. Paun c1996e9aeb Use typesafe signature where possible. 2004-10-27 21:16:27 +00:00
Dimitrie O. Paun 2bccfc4aa9 Rename STATUSWINDOWINFO to STATUS_INFO, for consistency with other
controls. Fix some prototypes. Always pass infoPtr around.
2004-10-27 21:16:17 +00:00
Dimitrie O. Paun bc88300968 Minor cleanups. 2004-10-27 21:16:03 +00:00
Dimitrie O. Paun 5873eb501e Use Unicode functions where possible. 2004-10-27 21:15:53 +00:00
Thorsten Kani d93d3d5ada Use address of tab_item.extra when building drawitemstruct. 2004-10-26 00:22:31 +00:00
Dimitrie O. Paun 63fe9d4490 Implement proper GWL_STYLE handling, proper reaction to style changes.
Merge {{Inc,Dec}rement,Reset{Up,Down}}Field into one method. Fix a
bunch of bugs in the process.  Implement DTM_[GS]ETMCFONT. Indentation
fixes, cleanups.
2004-10-26 00:11:31 +00:00
Dimitrie O. Paun 186b4b6843 Use only Unicode functions, it makes it easier to see we are fully
Unicode compliant.
2004-10-25 21:47:57 +00:00
Robert Shearman e0f1444d4e - Don't fill in any more information than native does for notifications.
- Store hit code in a signed integer so that we can see whether it is
  less than zero.
2004-10-25 21:45:14 +00:00
Robert Shearman acfd725df4 - Don't leak memory when an app sends TTM_SETTITLE twice.
- An lParam of 0 indicates that the title should be removed.
2004-10-25 21:44:50 +00:00
Francois Gouget 3bb5b093e8 Assorted spelling fixes. 2004-10-22 22:27:51 +00:00
Dimitrie O. Paun 6898ccbe65 Audit the Date Time Control. Unicodification.
Type safe functions (pass infoPtr and type safe values around).
Some cleanup and indentation fixes.
2004-10-22 19:52:08 +00:00
Uwe Bonnes 194bac7781 Monthcal_SetRange: Set proper value for min date. 2004-10-21 22:28:12 +00:00
Robert Shearman a4b013c9f2 Always remove WS_BORDER style from ComboBoxEx control. 2004-10-21 20:59:38 +00:00
Thorsten Kani c0a142ccee Don't add extra OFFSET_X/Y to the calculation of rcBitmap.top/left,
just use GetSystemMetrics.
2004-10-21 20:58:43 +00:00
Robert Shearman 5e6e9fb120 Correct the date of the completeness audit. 2004-10-21 19:56:32 +00:00
Dimitrie O. Paun 5d0366f5a0 Audit the month calendar. 2004-10-21 19:52:28 +00:00
Robert Shearman 18f0bf732d - Draw with ILD_TRANSPARENT instead of ILD_NORMAL to draw bitmaps from
the native shell image list properly (reported by Thorsten Kani).
- Rewrite TOOLBAR_NotifyFormat to avoid side-effects.
2004-10-21 19:52:16 +00:00
Robert Shearman 9cfb943561 Implement SetPathWordBreakProc and MirrorIcon. 2004-10-19 22:59:59 +00:00
Robert Shearman 5d0c01c4e0 Rebar completeness audit. 2004-10-19 22:59:14 +00:00
Ge van Geldorp 109f41aadc Pass correct uiParam for SPI_GETNONCLIENTMETRICS. 2004-10-19 21:09:42 +00:00
Ge van Geldorp 4e44eb2c9c Don't free subclass stack while it's still in use. 2004-10-18 23:14:38 +00:00
Robert Shearman a16223e302 - TBN_DELETINGBUTTON sends the command ID, not the index.
- Fill in tbButton structure for TBN_DELETINGBUTTON notification.
- Document TBN_QUERY* sending indices.
2004-10-18 19:39:22 +00:00