Commit Graph

1901 Commits

Author SHA1 Message Date
Serge Gautherie 2df16753f0 advapi32: Fix 3 comments about pdwReserved and dwFlags.
Signed-off-by: Serge Gautherie <winehq-git_serge_180711@gautherie.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-03-18 19:37:21 +01:00
Serge Gautherie 32b23dd114 advapi32/tests: Add more cases for CryptReleaseContext().
Signed-off-by: Serge Gautherie <winehq-git_serge_180711@gautherie.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-03-17 16:04:49 +01:00
Serge Gautherie 812c981886 advapi32/tests: Check all CryptReleaseContext() calls.
Signed-off-by: Serge Gautherie <winehq-git_serge_180711@gautherie.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-03-17 16:00:32 +01:00
Serge Gautherie 8b9e3dae4f advapi32: Fix CryptReleaseContext() last error on NULL provider.
Signed-off-by: Serge Gautherie <winehq-git_serge_180711@gautherie.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-03-17 16:00:22 +01:00
Serge Gautherie 62df03af96 advapi32: Use standard refcount in CRYPTPROV.
Signed-off-by: Serge Gautherie <winehq-git_serge_180711@gautherie.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-03-17 16:00:07 +01:00
Serge Gautherie 9cc8b501ee advapi32: CryptReleaseContext() dwFlags parameter is DWORD, not ULONG_PTR.
Signed-off-by: Serge Gautherie <winehq-git_serge_180711@gautherie.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-03-17 15:59:57 +01:00
Francois Gouget a909baeb4e tests: Report all errors when failing to wait for a child process.
Report the line number where the test failed to wait for the child so
one can identify which child process did not behave as expected.
Also wait_child_process() is meant for the general case so report
all non-crash error cases as test failures so they are accounted for.
Omit the "winetest_" prefix to match the other Wine test functions and
so the underlying winetest_wait_child_process() function can be wrapped
with the usual line-capturing macros.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48651
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-03-17 10:51:44 +01:00
Francois Gouget efb5050894 advapi32/tests: Simplify the name of the test unit for child processes.
The official name (shown by --list) has no path nor extension.

Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-02-21 00:55:44 +01:00
Rémi Bernon 56a83c585a advapi32/tests: Fix some format-overflow warnings.
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-02-11 22:39:59 +01:00
Qian Hong 0024d18430 advapi32: Fix the name and use of DOMAIN_GROUP_RID_USERS.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-02-02 18:48:23 +01:00
Zebediah Figura ee01244434 advapi32: Return the string SID if LookupAccountSid() fails.
Based on a patch by Qian Hong.

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-02-02 18:48:23 +01:00
Zebediah Figura e291fb4dc9 advapi32/tests: Clean up and expand tests for LsaLookupSids().
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-02-02 18:48:23 +01:00
Francois Gouget 82aa066fcc advapi32/tests: Avoid failure when GetServiceKeyName() gets a smart quote.
For non-English languages the Spooler display name may contain non-ASCII
characters, typically a smart quote. On Windows 7 GetServiceKeyName()
fails when it gets such characters.

Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-01-29 22:44:11 +01:00
Nikolay Sivov 970d8d5d09 advapi32/tests: Remove some workarounds in Crypt* tests.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-01-10 18:41:48 +01:00
Nikolay Sivov a7e1e4f72e advapi32/tests: Use CreateWellKnownSid() directly.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-01-10 18:41:06 +01:00
Nikolay Sivov 10646ddb91 advapi32/tests: Remove some workarounds for older versions.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-01-09 09:25:01 +01:00
André Hentschel 2114a4dd9b advapi32/tests: Don't test function directly when reporting GetLastError().
Found with Coccinelle.

Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-01-06 19:36:32 +01:00
Alexandre Julliard 4429b9f803 advapi32/tests: Use debug.h functions.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-12-17 16:55:16 +01:00
Zebediah Figura 8313551d26 advapi32/tests: Remove a todo_wine.
This seems to have been fixed by recent changes to CreateProcess() implementation.

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-11-14 09:33:44 +01:00
Dmitry Timoshkov fde235da03 kernelbase: Implement EqualDomainSid.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-11-12 22:05:58 +01:00
Andrew Eikum 9e817f8f8b ntdll: Add missing spec file entry for EtwEventWriteString.
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-10-31 17:44:06 +01:00
Andrew Eikum 364d654ba3 advapi32: Add EventRegister and EventUnregister tests.
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-10-31 17:43:58 +01:00
Zebediah Figura e80d84eb52 advapi32/tests: Clean up double NotifyServiceStatusChange() tests.
Simplify different paths, explicitly test data2.was_called, and test
that the correct notification is produced for Windows 8+ (previously
an intermittent failure was observed due to this uninitialized field).

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-10-27 19:25:20 +01:00
Zebediah Figura a39d0c7a39 advapi32/tests: Accept another value for the default service pre-shutdown timeout.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-10-27 19:25:17 +01:00
Zebediah Figura 4eee305bb8 advapi32/tests: Clean up tests for duplicate service names.
Use our own services instead of relying on a system service, and
account for differing Windows 10 behaviour.

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-10-27 19:25:15 +01:00
Zebediah Figura 7d35a261ba advapi32/tests: Use unique names for each created service.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-10-21 17:11:43 +02:00
Gijs Vermeulen 70bb655155 advapi32/tests: Fix test_process_security with non-English locale.
Signed-off-by: Gijs Vermeulen <gijsvrm@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-10-17 21:04:45 +02:00
Sven Baars 1f2c17d2bc advapi32/tests: Remove a superfluous CloseServiceHandle call (Coverity).
Signed-off-by: Sven Baars <sven.wine@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-10-07 23:54:07 +02:00
Zebediah Figura fec26c87ff advapi32/tests: Use unique service names in test_wow64().
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47891
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-10-07 09:59:24 +02:00
Nikita Morozkin c27ee58420 advapi32: Stub SetPrivateObjectSecurityEx().
Signed-off-by: Nikita Morozkin <nmzikcs@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-10-01 17:10:50 +02:00
Francois Gouget 171f24eba2 advapi32/tests: Spelling tweaks in ok() messages.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-09-02 20:46:52 +02:00
Francois Gouget 432cb69178 advapi32/tests: Spelling fixes in a couple of comments.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-09-02 20:46:48 +02:00
Richard Yao 8d55542473 advapi32: Add EventWriteString stub.
"Are You Ready for Valve Index?" needs this to work.

Signed-off-by: Richard Yao <ryao@gentoo.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-08-19 16:13:26 +02:00
Zebediah Figura 2430c17202 services: Don't redirect the image file path for kernel drivers.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47623
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-08-19 11:29:28 +02:00
Qian Hong 2e53f8bccb advapi32: Initialize the LsaLookupSids() LSA_TRANSLATED_NAME.Name string properly.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=39129
Signed-off-by: Damjan Jovanovic <damjan.jov@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-08-02 10:52:03 +02:00
Alexandre Julliard 0b709c5d85 advapi32: Move performance stubs to kernelbase.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-06-25 13:22:17 +02:00
Alexandre Julliard de406c70e5 advapi32: Move access control functions to kernelbase.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-06-25 13:22:17 +02:00
Alexandre Julliard 0ded440242 advapi32: Move security descriptor functions to kernelbase.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-06-25 13:22:17 +02:00
Alexandre Julliard 7557620aeb advapi32: Move token functions to kernelbase.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-06-25 13:22:17 +02:00
Alexandre Julliard d03eae54f4 advapi32: Move sid functions to kernelbase.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-06-25 13:22:17 +02:00
Alexandre Julliard c7548d6c4f advapi32: Move registry functions to kernelbase.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-06-25 13:22:17 +02:00
Alexandre Julliard d5249c0f6d advapi32: Move MD5 implementation to ntdll.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-06-24 15:00:29 +02:00
Alexandre Julliard 5768fd6dd2 advapi32: Move MD4 implementation to ntdll.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-06-24 15:00:29 +02:00
Alexandre Julliard 45e0f91de1 advapi32: Move SHA1 implementation to ntdll.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-06-24 14:52:10 +02:00
Alexandre Julliard f535bcb2e6 advapi32: Move more event log stubs to ntdll.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-06-24 14:52:08 +02:00
Alistair Leslie-Hughes 1b714ca088 advapi32: Don't read a value that might be uninitialized (Coverity).
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-06-17 21:34:19 +02:00
Andrey Gusev 7b8554b3b8 advapi32: Implement LookupAccountSidLocalA/W.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47286
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-31 12:44:10 +02:00
Daniel Lehman 023ad350e2 advapi32: Implement EnumDynamicTimeZoneInformation.
Signed-off-by: Daniel Lehman <dlehman25@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-29 11:45:37 +02:00
Hans Leidekker 17110a0a89 advapi32: Improve the SaferComputeTokenFromLevel stub.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47274
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-28 12:06:46 +02:00
Akihiro Sagawa b9b5117fe7 advapi32: Cache result of LoadString.
Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-27 14:42:07 +02:00
Akihiro Sagawa 62f5210364 advapi32: Fix the error code on load failure.
Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-27 14:42:03 +02:00
Akihiro Sagawa cb555215a9 advapi32: Fix the error code on parse failure.
Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-27 14:42:01 +02:00
Akihiro Sagawa e798d25f25 advapi32: Expand environment variables even if REG_SZ type is used.
Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-27 14:41:59 +02:00
Akihiro Sagawa 1ed4c150a2 advapi32: RegLoadMUIString doesn't accept a string without '@' prefix.
Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-27 14:41:57 +02:00
Akihiro Sagawa 90f79099a4 advapi32/tests: Add more RegLoadMUIString tests.
Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-27 14:41:53 +02:00
Akihiro Sagawa 3c1359af10 advapi32: Implement REG_MUI_STRING_TRUNCATE flag.
Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-24 21:56:00 +02:00
Akihiro Sagawa ed16573795 advapi32: Factor out load_mui_string().
Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-24 21:55:58 +02:00
Akihiro Sagawa 1ca4ecadec advapi32/tests: Add RegLoadMUIString tests with REG_MUI_STRING_TRUNCATE flag.
Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-24 21:55:56 +02:00
Akihiro Sagawa 4fe6460a30 advapi32: Return required buffer size in RegLoadMUIString.
Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-13 13:27:33 +02:00
Akihiro Sagawa 2d9a7cd39d advapi32: Remove useless RegLoadMUIStringA implementation.
This commit avoids brokeness in advance.
Otherwise, it will be broken when we support ERROR_MORE_DATA in
RegLoadMUIStringW.

Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-13 13:26:59 +02:00
Akihiro Sagawa bfdfe85229 advapi32: Improve load_string to return error code.
Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-13 13:26:47 +02:00
Akihiro Sagawa ec716f74d7 advapi32: Improve parameter sanity checks in RegLoadMUIString.
Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-13 13:26:18 +02:00
Akihiro Sagawa 1b7f3698f0 advapi32: Support the base directory parameter in RegLoadMUIString.
Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-13 13:25:19 +02:00
Akihiro Sagawa c29a5560a6 advapi32/tests: Add basic RegLoadMUIString tests.
Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-13 13:24:53 +02:00
Alexandre Julliard 6e0a5b81a4 advapi32: Use strncmpiW instead of memicmpW for strings without embedded nulls.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-07 11:30:29 -05:00
Louis Lenders 8c61f824f9 advapi32: Add InitiateShutdown{A,W} stub.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47131
Signed-off-by: Louis Lenders <xerox.xerox2000x@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-07 09:16:47 -05:00
Austin English 1a5ad9e65d advapi32: In ReadEventLogA/W, return ERROR_HANDLE_EOF instead of ERROR_CALL_NOT_IMPLEMENTED.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46905
Signed-off-by: Austin English <austinenglish@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-06 07:13:53 -05:00
Qian Hong 1058647e14 server: Create primary group using DOMAIN_GROUP_RID_USERS.
Signed-off-by: Vijay Kiran Kamuju <infyquest@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-01 11:15:29 +02:00
Vijay Kiran Kamuju a7b8e84567 advapi32/tests: Add additional tests for NtAccessCheck.
Signed-off-by: Vijay Kiran Kamuju <infyquest@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-04-26 21:36:25 +02:00
Erich E. Hoover 92ee3543e5 advapi32: Fix the initialization of combined DACLs when the new DACL is empty.
Wine-Bug:  https://bugs.winehq.org/show_bug.cgi?id=38423
Signed-off-by: Vijay Kiran Kamuju <infyquest@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-04-26 21:35:38 +02:00
Erich E. Hoover 9aac7ca191 advapi32: Move the DACL combining code into a separate routine.
Signed-off-by: Vijay Kiran Kamuju <infyquest@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-04-26 21:34:40 +02:00
Qian Hong 48821e2b16 advapi32/tests: Test prefix and use of TokenPrimaryGroup Sid.
Signed-off-by: Vijay Kiran Kamuju <infyquest@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-04-26 21:28:19 +02:00
Erich E. Hoover 5a79077250 server: Add default security descriptor DACL for processes.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=15980
Signed-off-by: Erich E. Hoover <erich.e.hoover@gmail.com>
Signed-off-by: Vijay Kiran Kamuju <infyquest@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-04-24 21:57:48 +02:00
Erich E. Hoover e11e8705eb server: Add default security descriptor ownership for processes.
Signed-off-by: Erich E. Hoover <erich.e.hoover@gmail.com>
Signed-off-by: Vijay Kiran Kamuju <infyquest@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-04-24 21:57:48 +02:00
Detlef Riekenberg 9e8e520467 advapi32/tests: Accept failure code from recent win10.
Signed-off-by: Detlef Riekenberg <wine.dev@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-03-22 09:21:14 +01:00
Austin English acdedf4f0c advapi32: Add RegLoadAppKeyA/RegLoadAppKeyW stubs.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=41591
Signed-off-by: Austin English <austinenglish@gmail.com>
Signed-off-by: Vijay Kiran Kamuju <infyquest@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-03-19 19:15:59 +01:00
Louis Lenders 642d6c695a advapi32: Add AuditQuerySystemPolicy stub.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46643
Signed-off-by: Louis Lenders <xerox.xerox2000x@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-03-19 19:10:34 +01:00
Dmitry Timoshkov cd5c9a2bed advapi32: CryptAcquireContext(CRYPT_DELETEKEYSET) should set returned provider handle to 0.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-03-12 20:32:59 +01:00
Dmitry Timoshkov b13b8ccc1f advapi32/tests: Add a test for provider handle returned by CryptAcquireContext(CRYPT_DELETEKEYSET).
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-03-12 20:32:57 +01:00
Hans Leidekker 8021d449f4 advapi32: Add a stub implementation of SaferIdentifyLevel.
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-03-06 18:32:09 +01:00
Jacek Caban 8a2347baff services: Associate notify handle with service handle instead of service entry.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-01-28 22:23:28 +01:00
Jacek Caban 9084b9761d advapi32/tests: Add test using NotifyServiceStatusChange on different handles of the same service.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-01-28 22:23:19 +01:00
Akihiro Sagawa 64addb512b advapi32: Load a resource dll as data file in RegLoadMUIStringW.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46266
Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-12-12 19:43:12 +01:00
Alex Henrie bf413496cd advapi32: Turn several string variables into static constants.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-30 11:41:05 +01:00
Alistair Leslie-Hughes cb8353b6e8 advapi32: Add DECL_HOTPATCH to registry functions.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46135
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-14 17:48:55 +01:00
Michael Stefaniuc dc235ab4a7 advapi32: Use the ARRAY_SIZE() macro.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-12 20:32:11 +01:00
Alex Henrie c296a21cdb advapi32: Fix memory leak in QueryServiceConfig2W (Coverity).
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-06 21:04:04 +01:00
Louis Lenders 924fd31cad advapi32: Add stub for RegQueryReflectionKey.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45796
Signed-off-by: Louis Lenders <xerox.xerox2000x@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-10-30 19:00:35 +01:00
Jacek Caban 2600ecd4ed server: Use a separated object for each opened named pipe device file.
Allows using proper options for ioctl pseudo fd.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-10-30 00:10:14 +01:00
Alexandre Julliard 2769bb1e9b kernel32: Add CreateProcessAsUserA/W.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-10-26 21:18:26 +02:00
Brendan McGrath c970b263c0 advapi32: Don't create a WoW6432 MachineGuid.
Signed-off-by: Brendan McGrath <brendan@redmandi.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-10-18 19:56:20 +02:00
Nikolay Sivov afaada7e5f advapi32: Add a name for WinBuiltinAnyPackageSid.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-10-08 09:32:36 +02:00
Nikolay Sivov 7c0cd8c740 advapi32: Add WinCreatorOwnerRightsSid to wellknown list.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-10-08 09:32:21 +02:00
Nikolay Sivov 7f30ad1e47 advapi32/tests: Test return SIDs for wellknown two-character names.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-10-08 09:32:14 +02:00
Alexandre Julliard ac7ae92af1 server: Allow specifying the security descriptor for a new process.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-20 14:50:48 +02:00
Alexandre Julliard 39afcaac4a server: Create the initial thread as a separate request.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-20 14:50:48 +02:00
Joris van der Wel adede14dc2 advapi32/tests: Add additional tests for passing a thread sd to CreateProcess.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-18 21:07:17 +02:00
André Hentschel 056c0039b2 advapi32/tests: Allow ERROR_ACCESS_DENIED for newer Win10.
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-17 18:33:48 +02:00
Louis Lenders b80780ad0f advapi32: Add stub for TraceSetInformation.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45813
Signed-off-by: Louis Lenders <xerox.xerox2000x@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-14 12:54:33 +02:00
André Hentschel 56885a1ca9 advapi32/tests: Allow ERROR_ACCESS_DENIED for newer Win10.
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-10 12:31:58 +02:00
Jacek Caban 58233b47e0 kernel32: Always create file with FILE_READ_ATTRIBUTES access in CreateFile.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-21 23:02:28 +02:00
Guillaume Charifi 94dda4690b kernel32: Add stub for GetDynamicTimeZoneInformationEffectiveYears().
Signed-off-by: Guillaume Charifi <guillaume.charifi@sfr.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 13:55:55 +02:00
Dmitry Timoshkov 6500f882da advapi32: Read the configured object list for the performance provider.
FIXME: it's not currently used, but the queries should be matched
against the configured object lists, and the providers should be
loaded and called only in case of a match.

Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-12 12:57:54 +02:00
Dmitry Timoshkov 8be6b299bc advapi32: If the query is not specified the default query is "Global".
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-12 12:57:54 +02:00
Dmitry Timoshkov a77eed47b4 advapi32: Performance providers' Open() expects to see the configured name as its parameter.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-12 12:57:54 +02:00
Dmitry Timoshkov 903de9b678 advapi32: Add initial support for querying performance counters data.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-12 12:57:54 +02:00
Dmitry Timoshkov 72a7de1a0f advapi32/tests: Add more tests for performance counters.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-11 15:45:11 +02:00
Michael Stefaniuc 962b31c80b include: Add a generic available ARRAY_SIZE().
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-04 10:39:15 +02:00
Michael Stefaniuc 0f2f4e7ff8 advapi32/tests: Use the available ARRAY_SIZE() macro.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-29 09:28:02 +02:00
Michael Stefaniuc 7b5668a6e7 include: Make ARRAY_SIZE() available in wine/test.h.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-25 12:09:17 +02:00
Zebediah Figura 3b8ec3046a advapi32: Correctly translate SERVICE_REQUIRED_PRIVILEGES_INFO to RPC.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-14 10:11:21 +02:00
Daniel Lehman 54bcff15ef advapi32/tests: Free subkey.
Signed-off-by: Daniel Lehman <dlehman@esri.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-10 18:17:59 +02:00
Daniel Lehman 1353d02904 server: Notify parents of registry value changes.
Signed-off-by: Daniel Lehman <dlehman@esri.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-07 12:09:47 +02:00
Daniel Lehman 8dee2df662 advapi32/tests: Add RegNotifyChangeKeyValue tests.
Signed-off-by: Daniel Lehman <dlehman@esri.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-07 12:09:44 +02:00
Daniel Lehman 19e96b567f advapi32/tests: Add tests for REG_NOTIFY_THREAD_AGNOSTIC.
Signed-off-by: Daniel Lehman <dlehman@esri.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-03 10:38:52 +02:00
Daniel Lehman 36a67edd1e advapi32/tests: Don't call function in assert().
Signed-off-by: Daniel Lehman <dlehman@esri.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-02 09:46:39 +02:00
Sebastian Lackner 731f22835e advapi32/tests: Add basic tests for BuildSecurityDescriptor.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-18 11:08:31 +02:00
Andrew Wesie b58577aa54 advapi32: Implement BuildSecurityDescriptorW.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-18 11:08:22 +02:00
Jacek Caban 269dbdcfbf advapi32: Initialize svcctl_GetNotifyResults output parameter to NULL.
Otherwise rpcrt4 treats its uninitialized value as output buffer.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-09 09:56:08 +02:00
Michael Stefaniuc f9fda1e20f advapi32: Use the available ARRAY_SIZE() macro.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-29 17:27:56 +02:00
Michael Stefaniuc 716103b1bb advapi32/tests: Use the available ARRAY_SIZE() macro.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-29 17:27:53 +02:00
Dmitry Timoshkov 923f7246be advapi32: Use larger buffers for domain names.
Otherwise GetComputerNameExW(ComputerNamePhysicalDnsDomain) and
GetComputerNameExW(ComputerNameDnsDomain) fail if the names don't
fit into MAX_COMPUTERNAME_LENGTH characters.

Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-29 16:06:03 +02:00
Stefan Leichter bae48da7c5 advapi32: Silence the fixme in EventActivityIdControl.
Signed-off-by: Stefan Leichter <sle85276@gmx.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-26 21:10:16 +02:00
Gijs Vermeulen 9702de2002 advapi32/tests: Introduce ARRAY_SIZE macro.
Signed-off-by: Gijs Vermeulen <gijsvrm@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-20 11:37:25 +01:00
Gijs Vermeulen 89e2cf6b2b advapi32: Introduce ARRAY_SIZE macro.
Signed-off-by: Gijs Vermeulen <gijsvrm@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-20 11:37:00 +01:00
Dmitry Timoshkov 411ccfb921 advapi32: Also initialize DnsDomainName and DnsForestName in LsaQueryInformationPolicy.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-02 16:19:43 +01:00
Dmitry Timoshkov eb077e9fac advapi32: Return correct short domain name.
Also remove suffix and uppercase the returned name as Windows does.

Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-02 16:19:43 +01:00
Dmitry Timoshkov a3bcaca48d advapi32: Use GetWindowsAccountDomainSid() to retrieve the domain SID.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-02 16:19:43 +01:00
Dmitry Timoshkov 09cd27871b advapi32: Initialize more fields in LsaQueryInformationPolicy(PolicyDnsDomainInformation).
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-01 19:25:56 +01:00
Alistair Leslie-Hughes 4bbbc261d1 ntdll: Support TokenLogonSid in NtQueryInformationToken.
Based on a patch by Andrew Wesie.

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-07 19:38:29 +01:00
Andrew Eikum e5294a7414 advapi32: Also wait on services without a control thread during shutdown.
Tested service messages during OS shutdown manually on Windows 7.

Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-06 19:39:12 +01:00
Alistair Leslie-Hughes 2b01220230 advapi32: Support WinLogonIdsSid in IsWellKnownSid.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-30 10:00:03 +01:00
Michael Stefaniuc 56d0cfbabd advapi32: Use the global HeapAlloc() wrappers.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-30 09:07:18 +01:00
Andrew Eikum 1f88b90b74 advapi32: Implement NotifyServiceStatusChange.
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-23 18:28:38 +01:00
Matteo Bruni 9ccce0ce64 advapi32/tests: Fix a couple of leaks (Valgrind).
Signed-off-by: Matteo Bruni <mbruni@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-11 19:11:33 +01:00
Matteo Bruni f6f5c96677 advapi32/tests: Fully initialize ACLs (Valgrind).
Signed-off-by: Matteo Bruni <mbruni@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-10 23:59:44 +01:00
Andrew Eikum 9c95bfcc30 advapi: Fix return value for QueryServiceConfig2W.
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-03 23:27:06 +01:00
André Hentschel ab2ae76ea4 advapi32/tests: Don't cast return value from HeapAlloc.
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-02 15:52:22 +01:00
Zebediah Figura 0c5381c6ce advapi32/tests: Skip tests modifying HKLM if limited.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-02 13:25:20 +01:00
Gerald Pfeifer 8b8b6d545d advapi32: Include <stdarg.h> since winbase.h expects va_list.
Signed-off-by: Gerald Pfeifer <gerald@pfeifer.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-27 16:15:25 +01:00
Hans Leidekker 5bc2e83c7a advapi32: Fix size returned from ConvertStringSecurityDescriptorToSecurityDescriptor on 64-bit.
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-24 16:48:02 +01:00
Hans Leidekker 84a9503298 advapi32/tests: Add tests for MakeSelfRelativeSD.
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-24 16:48:02 +01:00
Austin English adc8d95e02 advapi32: Add initial Perf* stubs.
Signed-off-by: Austin English <austinenglish@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-20 12:37:15 +01:00
Hans Leidekker 1d03ba7611 advapi32: Fix parsing empty DACL/SACL security descriptor strings.
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-17 17:39:04 +01:00
Hans Leidekker f947546927 advapi32: Add traces to ConvertStringSecurityDescriptorToSecurityDescriptorA/W.
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-17 17:38:46 +01:00
Hans Leidekker cd8165a488 advapi32; Remove unused foward declarations.
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-17 17:36:37 +01:00
Michael Müller 07b629e8e4 advapi32: Implement GetExplicitEntriesFromAclW.
Signed-off-by: Vincent Povirk <vincent@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-13 21:20:49 +01:00
Hans Leidekker 251c9ccff7 advapi32: Fix QueryServiceConfig2 on Wow64.
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-08 21:06:52 +01:00
Hans Leidekker 445996d31b advapi32: Fix EnumServicesStatusEx on Wow64.
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-08 21:06:48 +01:00
Hans Leidekker ac0744d450 advapi32: Fix EnumServicesStatus on Wow64.
The structures returned by this function contain pointers, which breaks on Wow64 if
the client is 32-bit (the service manager always runs in a 64-bit process).

This patch introduces a variant of ENUM_SERVICE_STATUS with offsets instead of pointers
and converts the structures on the client side.

The downside is that we need to buffer the data, but in return we can get rid of the
dummy buffer pointer.

Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-08 21:06:40 +01:00