431e369f62
ole32: Convert dll registration to the IRegistrar mechanism.
2010-12-03 19:51:08 +01:00
5f49129e03
resources: Define a generic mechanism for adding extra values to the common version block.
2010-12-03 14:53:59 +01:00
796aca38f0
ole32: Fix the test for arbitrary property ids.
2010-12-01 11:14:39 +01:00
c75a4fd50a
ole32: Fix an off-by-one error that broke reading of many properties.
2010-12-01 11:14:34 +01:00
df219f8758
ole32: Revert "ole32: Only read known format ids when attempting to read summary information.".
...
This reverts commit c94b2687d2
2010-12-01 11:14:29 +01:00
41193de135
ole32: Avoid unneccessary stream conversion.
...
Truncating a large stream to less than 0x1000 bytes would cause an
unnecessarily expensive conversion.
2010-11-23 13:17:06 +01:00
ddc5cbb371
ole32/tests: Added a couple of simple tests for StgCreateStorageEx.
2010-11-18 12:52:38 +01:00
42cd791c4d
ole32: Use default values if options passed to StgCreateStorageEx are NULL.
2010-11-18 12:52:38 +01:00
e883aeb394
ole32: Cache the contents of one extended big block depot block.
2010-11-16 21:54:18 +01:00
0c6f2a6d2a
ole32: Skip more tests on win9x.
2010-11-16 15:12:43 +01:00
54bf38575e
ole32: Get rid of the ICOM_THIS_MULTI macro.
2010-11-11 20:16:59 +01:00
8d101b269d
ole32: Cache all extended big block depot locations.
2010-11-04 11:55:48 +01:00
abf8da6727
ole32: Implement OnRun and OnStop.
2010-11-01 16:16:12 +01:00
6b05b2a927
ole32: Remove some useless comments.
2010-11-01 16:16:05 +01:00
96ab42728d
ole32: Re-order some functions.
2010-11-01 16:15:57 +01:00
c41c05057c
ole32: Rename cache entry parameters from 'This' - it leads to too much confusion with the data cache itself, which is the real COM object.
2010-11-01 16:15:49 +01:00
4d137e4702
ole32: Add a stub advise sink object to the data cache.
2010-11-01 16:15:38 +01:00
ad326999ec
ole32/tests: Add tests to exercise the datacache's IDataObject::GetData.
2010-11-01 16:15:32 +01:00
a5caff3bac
ole32: Pass failures from delegate object's ::QueryInterface in default handler.
2010-10-21 12:28:51 +02:00
d95e2dbd62
ole32: OleLoad should not fail even if IOleObject::GetMiscStatus fails.
2010-10-18 19:08:38 +02:00
1e04e923be
ole32: Use the correct resource ids for the drag&drop cursors.
2010-10-18 19:08:37 +02:00
bc8e70c089
ole32/tests: Make some variables static.
2010-10-01 13:37:14 +02:00
620ca68d01
ole32: Allocate a small temp variable on the stack instead of the heap.
2010-09-29 10:07:54 +02:00
91d91afb7d
ole32: Create a FORMATETC if one is not given in OleCreate.
2010-09-28 17:33:20 +02:00
250b55c41d
ole32: Call the draw_continue function.
2010-09-28 17:33:17 +02:00
6c7dd939cf
ole32/tests: Mark the draw_continue callbacks as optional. Win9x can skip calls under low-load conditions.
2010-09-28 17:33:17 +02:00
81b8ee863e
makefiles: Add a standard header for all makefiles to replace the common variable initializations.
2010-09-19 12:36:48 +02:00
8d25534613
ole32: Check for interface NULL which happens with e.g. Abiword.
2010-09-16 13:37:32 -05:00
2752c3bcd0
ole32: Don't fail if the file ends during a big block.
...
Apparently, it's valid for the last block in a file to be incomplete.
2010-09-08 13:30:46 +02:00
dd84876c3e
ole32: Use int64 in the spec file for 64-bit integers.
2010-08-31 14:23:48 +02:00
89646084ba
ole32: Cache data and block locations in BigBlockStream objects.
2010-08-26 13:59:31 +02:00
101de22a1a
ole32: Flush before returning from any storage API call that writes.
2010-08-26 13:59:28 +02:00
127260bb62
ole32: Pass a real IUnknown ptr to CoMarshalInterface.
2010-07-28 16:28:21 +02:00
ffac31da09
ole32: Use IsEqualIID instead of memcmp to compare REFIIDs.
2010-07-23 11:46:29 +02:00
6d1ef3a6a6
ole32: Implement cross-process drag and drop.
2010-07-22 16:11:59 +02:00
a2e1dd29dc
ole32/tests: Relax the reference counting tests a bit. We only care whether references are held or not.
2010-07-22 16:11:51 +02:00
1b0182f9bb
ole32: Use IsEqualIID() instead of memcmp().
2010-07-21 17:38:37 +02:00
114510801f
ole32: No need to test for interface pointer being null.
2010-07-21 17:38:37 +02:00
2f61e19156
ole32: Fix assumption about HRESULT failure code value.
2010-07-21 17:38:37 +02:00
5185409144
ole32: Remove redundant variables.
2010-07-21 17:38:37 +02:00
b86d515ed6
dlls: Remove explicit imports of kernel32 and ntdll.
2010-07-21 17:38:36 +02:00
5116b979b2
ole32: Flush the ILockBytes object of a storage on commit and final release.
...
Some ILockBytes objects will not really write changes until their Flush
method is called. Also, further optimizations to the storage implementation
will involve caching writes, which will have to be flushed at times.
2010-07-19 14:38:16 +02:00
b7dbfcbd48
ole32: Remove an unused variable.
2010-07-19 14:38:16 +02:00
d0e6e4aa82
ole32: Use ILockBytes_Stat to get the filename of a storage.
2010-07-19 14:38:16 +02:00
14f8f9d5b5
ole32: Remove the BigBlockFile abstraction and always use an ILockBytes.
2010-07-19 14:38:16 +02:00
4171499411
ole32: Don't map storage files in memory.
2010-07-19 14:38:16 +02:00
7f3c92b2a0
ole32: Update storage header saving code based on the latest MS spec.
...
These fields are needed for the MS storage implementation to load
files that were created by Wine with a block size of 4096.
2010-07-19 14:38:16 +02:00
9c95761d9e
ole32: Always check the size of the small block root chain.
...
In some storage files, the size of this stream is not a multiple of the big
block size. This means that we may need to enlarge the stream even when we
don't really have to allocate more space for it.
2010-05-28 16:22:24 +02:00
d64ee9ff11
ole32: Fix seeking backwards in hglobalstream.
2010-05-27 14:46:43 +02:00
ff4292c229
ole32/tests: Add more IStream_Seek tests for hglobalstream.
2010-05-27 14:46:42 +02:00
162e420f0e
ole32: Avoid potential NULL pointer dereferences in a TRACE.
2010-05-26 10:11:05 +02:00
78d1686b90
ole32: Implement the IAdviseSink call_as proxies and stubs.
...
Based on a patch by Rob Shearman.
2010-05-25 12:49:19 +02:00
c94b2687d2
ole32: Only read known format ids when attempting to read summary information.
2010-05-25 12:02:47 +02:00
b4c3a04165
ole32/tests: Test creating an IPropertySetStorage with an unknown format id.
2010-05-25 12:02:37 +02:00
07325c7d7c
ole32/tests: Add tests for output parameters in MkParseDisplayName.
2010-05-21 18:58:05 +02:00
7bdf023e69
ole32: Validate pointer parameters in MkParseDisplayName.
2010-05-21 18:58:05 +02:00
2c80e14eec
ole32: Use window property to store registered drop target.
2010-05-18 08:53:08 +02:00
57ddceea34
ole32: Use a temporary variable in TransactedSnapshotImpl_EnsureReadEntry.
...
CreateStubEntry can change the value of This->entries, in which case the
assignment can go to the wrong place. So instead, assign to a temporary
variable, and copy the data back after all CreateStubEntry calls are finished.
2010-05-13 11:51:07 +02:00
bf1e9a2e93
ole32: Fixed 2 uninitialized variable use (Coverity).
2010-05-10 10:03:43 +02:00
dbf123ba0d
ole32: Fix reads past the end of streams.
2010-05-07 12:46:50 +02:00
4ad114cfae
ole32: Use the cached information in BlockChainStream_GetCount.
2010-05-07 12:46:39 +02:00
e40afcb2b6
ole32: Always move unmodified streams instead of copying on commit.
2010-05-06 17:55:43 +02:00
d07a4868a1
ole32: Rewrite transacted storage to be more lazy.
...
When creating a new transacted storage object (or reverting an
existing one), rather than copy the original storage, we simply create
a "stub directory entry" for the root. As stub entries are accessed,
we fill in their data from the parent and create new stubs for any
linked entries. The streams have copy on write semantics - reads are
from the original entry until a change is made, then we make a copy in
the scratch file.
When committing transacted storages, we have to create a new tree with
the new data so that the storage entry can be modified in one step,
but unmodified sections of the tree can now be shared between the new
tree and the old. An entry can be shared if it and all entries
reachable from it are unmodified. In the trivial case where nothing
has been modified, we don't have to make a new tree at all.
2010-05-06 17:55:34 +02:00
56fdbc226e
ole32/ole2: Use W calls for registry access.
2010-05-06 14:22:23 +02:00
42550953a6
ole32: Store the location of all blocks in a big block chain in memory.
...
A big block chain is a linked list, and we pretty much need random
access to them. This should theoretically make accessing a random
point in the chain O(log2 n) instead of O(n) (with disk access scaling
based on the size of the read/write, not its location). It
theoretically takes O(n) memory based on the size, but it can do
better if the chain isn't very fragmented (which I believe will
generally be the case for long chains). It also involves fetching all
the big block locations when we open the chain, but we already do that
anyway (and it should be faster to read it all in one go than
piecemeal).
2010-05-05 10:41:57 +02:00
93cc582a8d
ole32: Remove some assumptions about the internals of BlockChainStream.
2010-05-05 10:41:26 +02:00
286c5f8816
ole32/marshal: Compare with S_OK instead of keeping in mind that it's zero.
2010-05-03 15:43:01 +02:00
c6f74e386b
ole32: Fix return value for CoRevokeMallocSpy.
2010-05-03 15:40:20 +02:00
889900f020
ole32: Fix return value of DefaultHandler_SetClientSite.
2010-05-03 15:40:13 +02:00
f3ab3d971a
ole32/ole2: If no effect action selected use ::DragLeave() instead of ::Drop().
2010-05-03 13:58:59 +02:00
9c44ed8a6b
ole32/ole2: After IDropTarget::DragEnter() failure target doesn't count as valid.
2010-05-03 13:58:54 +02:00
071d16d624
ole32/tests: Additional test for RevokeDragDrop with destroyed window.
2010-05-03 13:58:41 +02:00
5426320d82
ole32/ole2: Fix simple parameter handling for DoDragDrop().
2010-05-03 13:58:38 +02:00
a37dfe3584
ole32/tests: Move tests to a separate function.
2010-05-03 13:58:34 +02:00
c22d776e74
ole32: Only fail on missing Implemented Categories key if we actually have categories to check.
2010-05-03 13:56:41 +02:00
5ac7b165e6
ole32: Use LoadCursorW instead of -A version.
2010-04-28 07:30:55 -05:00
16bd9d53b9
ole32: Avoid uninitialized value to be potentialy passed to UnhookWindowsHookEx.
2010-04-28 07:29:37 -05:00
d819f13911
ole32: Use -W versions of window/message calls.
2010-04-28 07:28:52 -05:00
1e3aba6e7c
ole32: Remove variable res which is not really used from CompositeMonikerImpl_Reduce.
2010-04-26 09:03:09 -05:00
0b149df987
ole32: Create storage files with 4096-byte blocks when asked.
2010-04-13 11:30:48 +02:00
38b6f4dfff
ole32/tests: Avoid using a pointer difference in a trace.
2010-04-09 16:14:16 +02:00
9b471fbd14
ole32: Fix the free threaded marshaller data for 64-bit pointers.
2010-04-07 13:09:49 +02:00
a8ffa9bace
ole32: Don't use in-memory structure layouts to build the wire data, define wire-specific structures instead.
2010-04-06 18:07:59 +02:00
eab89da812
ole32: Add missed initialization of virtual function table.
2010-03-29 15:50:22 +02:00
a8e2f4327f
ole32: Always start the 64-bit version of rpcss.exe on Wow64.
2010-03-29 15:50:09 +02:00
f930c87fd6
objbase.h: CLSIDFromString: Add constness to the parameters declaration in accordance with MSDN.
2010-03-29 12:11:02 +02:00
49a817c064
ole32: Check the small block size limit of storage files.
...
This value is stored in the storage file header. We currently hard-code it to
0x1000. I don't expect to see files in the wild with other values, but
according to MS this is a valid configuration. For now, just fail if we see
another value.
I've also upgraded the message for unexpected values in storage file headers
to a fixme, since they are valid according to MS.
2010-03-22 10:47:58 +01:00
975c820fce
ole32: Don't register an IMallocSpy object when the ole trace is used.
...
There's no need for this. Any useful information we could get out of it
is availble from the olemalloc channel, and it means that the ole channel
changes behavior in a way that's visible to programs.
2010-03-22 10:47:47 +01:00
e05b8416b8
ole32: Track the lowest possibly-free small block in storage files.
...
This makes creating small block chains O(n) instead of O(n**2) because we
don't have to keep rechecking the first blocks in the file.
2010-03-22 10:47:42 +01:00
0498534b6b
ole32: Remove useless parameter check.
2010-03-17 16:35:47 +01:00
825a635692
ole32: Turn FIXME to TRACE for CoGetTreatAsClass.
2010-03-16 17:04:15 +01:00
bef5645eb1
makefiles: Remove the no longer needed explicit separators for dependencies.
2010-03-16 13:28:19 +01:00
93c2256cff
ole32: Allow storage files with a block size of 4096 to open.
2010-03-15 13:46:59 +01:00
5ceb003a24
ole32: Remove knowledge of block sizes from the BigBlockFile object.
...
We can't determine the correct block size until we read the header, and we
can't create the BigBlockFile until we know the correct block size. To
solve this dilemma, have StorageImpl calculate the file size it needs instead
of asking the BigBlockFile to "ensure a big block exists".
2010-03-15 13:46:48 +01:00
926669741e
ole32: Remove the NUM_BLOCKS_PER_DEPOT_BLOCK define.
...
This should always be calculated based on the big block size.
2010-03-15 13:46:31 +01:00
7b43123762
ole32: Remove the BIG_BLOCK_SIZE define.
...
Big block sizes can be 512 or 4096, so we define arrays that are large
enough in either case.
2010-03-15 13:46:19 +01:00
b90ab46a82
ole32: Remove the unused BlockBits structures from BigBlockFile objects.
2010-03-15 13:46:07 +01:00
4b7e7bd77f
ole32: Fix the big block offset calculation.
...
Use the actual big block size from the open storage file. Also, remove a
special case that was only used for reading/writing the header.
2010-03-15 13:45:55 +01:00
f3db25fc25
ole32: Don't treat the header as a big block in StorageImpl_SaveFileHeader.
2010-03-15 13:45:36 +01:00
7f3211f383
ole32: Don't treat the header as a big block in StorageImpl_LoadFileHeader.
...
The header is always 512 bytes, regardless of the big block size.
2010-03-15 13:45:30 +01:00
8d58a91fa3
ole32: Allow CopyTo to succeed in spite of already open source streams.
2010-03-15 13:17:34 +01:00
a456e641db
ole32/tests: Avoid sizeof in traces.
2010-03-05 15:17:57 +01:00
3733789aa9
ole32: Add tests for CopyTo in recursive situations.
2010-03-04 12:29:21 +01:00
11abad24dd
ole32: Add a test showing IStorage_CopyTo ignores open objects in the source.
2010-03-03 11:49:27 +01:00
24ff704835
ole32: Clear the sibling links when reinserting a renamed element.
2010-03-02 16:44:12 +01:00
0ed4c6df24
ole32: IMoniker_IsRunning returns E_INVALIDARG when bindctx is NULL.
2010-03-02 11:12:37 +01:00
f08206b31f
ole32: Fix the HGLOBAL stream Seek implementation.
2010-02-25 12:10:40 +01:00
4cd390ca4e
ole32/tests: Improve the HGLOBAL stream tests for Seek.
2010-02-25 12:10:35 +01:00
6164ce2d82
makefiles: Use the standard C_SRCS variable as the list of test files.
...
This enables it to be auto-updated by make_makefiles.
2010-02-22 10:47:11 +01:00
d420a858da
ole32: Add error checking to StorageBaseImpl_CreateStorage.
2010-02-15 12:20:01 +01:00
1fab6e3515
ole32: Add error checking to StorageBaseImpl_CreateStream.
2010-02-15 12:20:00 +01:00
35b800dc92
ole32: Only warn about storage share mode once.
2010-02-12 11:54:36 +01:00
da250c9afe
ole32: IStorage_Revert has no effect for non-transacted storages.
2010-01-25 12:58:22 +01:00
c3af2dd752
ole32: Rearrange declarations in itemmoniker.c to avoid unnecessary forward declarations.
2010-01-22 12:18:46 +01:00
7fe78c14e9
ole32: Downgrade StgIsStorageFile debug info from WARN to TRACE.
2010-01-07 09:25:51 +01:00
0debd2fef4
ole32: Remove fixme for transacted mode.
2010-01-04 11:41:28 +01:00
2bc9ba758e
ole32: Fix some pointer cast warnings on 64-bit.
2009-12-31 12:12:16 +01:00
56bc0515c2
ole32/storage32: Fix return value for invalid access mode in OpenStream.
2009-12-30 16:13:57 +01:00
88219db8ab
ole32: Handle SetClipboardData failing in OLE clipboard functions.
2009-12-30 13:36:50 +01:00
36bfaea96d
ole32: Fix stream reference leak in test_ReadClassStm.
2009-12-30 13:36:46 +01:00
b7d86b54d9
ole32: Release the data object and free the cached enum data upon OleUninitialize.
2009-12-30 13:36:42 +01:00
ffc4a49bcb
ole32: Always allow changes to read-only transacted storages.
...
The only time the write permissions of transacted storages matter is when
committing.
2009-12-28 11:54:49 +01:00
25d15c68dc
ole32/tests: Fix a test failure on several platforms.
2009-12-22 13:48:24 +01:00
b3511ebb70
ole32: Reread the stream entry after setting the size in StreamWriteAt.
...
In simple mode, StreamWriteAt would assume that StreamSetSize uses the size
it asks for, but in some cases the size would be pushed above the small block
limit. StreamWriteAt would then attempt to write using a small block chain,
even though a big block chain was created.
2009-12-21 15:01:24 +01:00
fc50ff07d6
ole32: Store the most recent item name in IEnumSTATSTG instead of a stack.
2009-12-21 15:01:24 +01:00
4492850200
ole32: Make IEnumSTATSTG functions fail when the parent is invalid.
2009-12-21 15:01:23 +01:00
2010e0fb28
ole32: Add some tests for IEnumSTATSTG.
2009-12-21 15:01:23 +01:00
4f0dfb51b3
ole32: Fix memory leaks in the storage test.
2009-12-18 11:44:04 +01:00
5d9fd1b716
ole32: Compare upper character values directly in entryNameCmp.
...
The sort function used by native is not entirely consistent with lstrcmpiW,
even on Windows.
2009-12-18 11:43:34 +01:00
776ee9ee81
ole32: Fix a memory leak.
2009-12-18 11:39:08 +01:00
393c5af205
ole32: Add a cache for block chain streams in StorageImpl.
2009-12-16 12:24:27 +01:00
c6d4df8b1c
ole32: Fix several memory leaks in the tests.
...
Found by Valgrind.
2009-12-16 12:24:19 +01:00
3ac34f7416
ole32: Properly free temporary objects when StorageBaseImpl_CopyTo fails.
2009-12-14 12:06:35 +01:00
6afe24c38d
ole32: Remove an unnecessary special case in StorageBaseImpl_CopyTo.
...
Opening a storage when it has already been opened now fails with
STG_E_ACCESSDENIED. If we attempt to copy a storage to its own child, this
will happen during the copy.
2009-12-14 12:06:25 +01:00
0ad48797f8
ole32: Fix a memory leak in StorageBaseImpl_CopyTo.
...
Spotted by valgrind.
2009-12-14 12:06:17 +01:00
3ff33e9303
ole32: Implement Revert for transacted storage objects.
2009-12-11 12:16:26 +01:00
226363f5df
ole32: Implement transacted storage.
2009-12-11 12:16:26 +01:00
d799f7e189
ole32: Add a stub transacted storage type.
...
TransactedSnapshotImpl acts as a proxy between the user and the storage
interfaces that modify the file directly (or another transacted storage).
Currently, it does not change the operations.
2009-12-11 12:16:26 +01:00
42142200d5
ole32: Add Invalidate to the storage vtable.
2009-12-11 12:16:26 +01:00
75fe621192
ole32: Create internal storage objects with a refcount of 1.
...
For consistency with StorageImpl_Construct.
2009-12-11 12:16:25 +01:00
49d40d80f4
ole32/tests: Don't crash on Win9x/WinMe by using more A-functions.
2009-12-10 12:39:52 +01:00
8b3ff9d179
ole32: Remove the ancestorStorage attribute.
2009-12-10 11:51:39 +01:00
5d39c31bff
ole32: Make IEnumSTATSTGImpl reference the parent storage.
2009-12-10 11:51:29 +01:00
43184aaf52
ole32: Make findElement take a StorageBaseImpl.
2009-12-10 11:51:21 +01:00
55b3a6e59f
ole32: Don't use ancestorStorage to decide if a storage is transacted.
2009-12-10 11:51:10 +01:00
1a12141d86
ole32: Add a test for modifying read-only substorage objects.
2009-12-10 11:51:01 +01:00
09db528847
ole32: Release the error info strings.
...
Found by Valgrind.
2009-12-09 16:50:36 +01:00
44a9bae9f8
ole32: Fix some pointer cast warnings on 64-bit.
2009-12-09 12:04:01 +01:00
df0ef756b3
ole32: Add an attribute to StorageBaseImpl to track its reverted status.
2009-12-09 12:03:40 +01:00
5b79c5a5e4
ole32: Store the parent of internal storage objects.
2009-12-09 12:03:30 +01:00
Alexandre Julliard