James Hawkins
5e5c4a9809
msi: Don't publish the product for the custom action test.
2008-03-15 11:02:50 +01:00
Marcus Meissner
db71fb15aa
msi: Initialize variables.
2008-03-14 11:21:22 +01:00
James Hawkins
65f99ed91b
msi: Test and fix MsiSourceListAddSource.
2008-03-13 11:36:24 +01:00
Rob Shearman
58130dde08
msi: Passing NULL for szBuffer and NULL for pcchValueBuf into MsiGetProductInfo{A, W} shouldn't crash.
...
Add a test for this.
2008-03-12 19:21:27 +01:00
Rob Shearman
dd31a1eac4
msi: Fix typos which caused joins of three or more tables to not work properly.
...
In JOIN_fetch_int and JOIN_fetch_stream, prev_rows should be multiplied
by the rows encountered in the current table so that prev_rows contains
all of counts of the rows encountered multiplied together, rather than
just the count of the rows in the last table encountered.
2008-03-12 19:21:19 +01:00
James Hawkins
de4cab20a8
msi: Deformat the service name and display name when installing the service.
2008-03-12 12:00:23 +01:00
James Hawkins
2d0ff97406
msi: Ignore the custom action type 51 if the source field is empty.
2008-03-11 12:12:24 +01:00
James Hawkins
776a7d7065
msi: Fix an off-by-one error when applying embedded transforms.
2008-03-11 12:12:14 +01:00
James Hawkins
5871bee8c7
msi: Optimize MsiSourceListAddSourceEx for adding to the end of the list.
2008-03-11 12:12:07 +01:00
Andrew Talbot
6661f43438
msi: Assign to structs instead of using memcpy.
2008-03-07 11:01:07 +01:00
James Hawkins
d52f48fed4
msi: Fix handling of published installer properties.
2008-03-07 10:52:46 +01:00
Ove Kaaven
be874f1a26
msi: Fix bug in handling of multivolume CAB files.
2008-03-07 10:52:11 +01:00
James Hawkins
c8acf21e0c
msi: Break out the publishing tests into their respective actions.
2008-03-06 16:24:39 +01:00
Paul Vriens
2c22e9aeb6
msi/tests: Make tests run on win9x/NT4 again.
2008-03-05 11:21:56 +01:00
Rob Shearman
48000893f9
makefiles: Simplify the use of the IMPORTLIB variable in the DLL makefiles.
...
Only specify the root to keep platform-specifics out of the individual
DLL makefiles.
2008-03-04 20:55:01 +01:00
James Hawkins
4609eccd72
msi: Add tests for MsiGetProductInfoEx.
2008-03-04 11:54:21 +01:00
James Hawkins
ad70693539
msi: Implement MsiGetProductInfoEx.
2008-03-04 11:54:21 +01:00
James Hawkins
0c3ecefbc3
msi: Include query.h to pull in the definition of STREAMS_CreateView.
2008-03-01 12:18:54 +01:00
James Hawkins
6febb8fda8
msi: Remove a pointless wrapper of RegCreateKey.
2008-03-01 12:18:43 +01:00
James Hawkins
4439e0b57d
msi: Make local functions static.
2008-03-01 12:18:40 +01:00
James Hawkins
617eb48d5b
msi: Implement the UILevel property of the Installer object.
2008-03-01 12:18:24 +01:00
James Hawkins
724c8da734
msi: Don't bail out if the row to modify is not found as not all modify commands need the row.
2008-03-01 12:17:31 +01:00
James Hawkins
eedfacdfe7
janitorial: Remove links to any microsoft site.
2008-03-01 12:04:03 +01:00
Alexandre Julliard
848383ac82
msi/tests: Replace a printf() by a trace().
2008-02-29 20:55:42 +01:00
James Hawkins
174b7b51ac
msi: Update controls based on a property when that property changes.
2008-02-28 10:59:22 +01:00
James Hawkins
5e2bc5b3fe
msi: If a feature's action is INSTALLSTATE_UNKNOWN, MsiEvaluateCondition should return MSICONDITION_FALSE.
2008-02-28 10:59:16 +01:00
Marcus Meissner
eb836b718f
msi: Initialize type (Coverity).
2008-02-28 10:50:57 +01:00
Rob Shearman
3183ad65d2
msi: Fix buffer size calculation in build_default_format.
2008-02-28 10:44:11 +01:00
Rob Shearman
03e466b837
msi: Fix the buffer size calculation in msi_build_createsql_prelude.
2008-02-28 10:44:06 +01:00
James Hawkins
9101665233
msi: Change the property variant if the types don't match.
2008-02-27 14:52:26 +01:00
Paul Vriens
1bbac341df
msi/tests: Fix test that depends on the order of the files in a directory.
2008-02-27 14:52:25 +01:00
Paul Vriens
6b37543adc
msi/tests: Skip tests that contain functions that are not available.
2008-02-27 14:52:24 +01:00
Paul Vriens
ecf8c5af36
msi/tests: Skip tests for functions that are not available.
2008-02-27 14:52:24 +01:00
Paul Vriens
e7937f3cd5
msi/tests: Make sure tests will run on Win9x and NT.
2008-02-27 14:52:24 +01:00
James Hawkins
bdbb7a0348
msi: Search existing published sources if the media cannot be found.
2008-02-26 11:20:46 +01:00
James Hawkins
cf84e2df5b
msi: Allow setting a media disk as the last used source in the internal msi_set_last_used_source.
2008-02-26 11:20:35 +01:00
James Hawkins
7d10d1d2d0
msi: Store the media type and set the last used source type accordingly.
2008-02-26 11:20:27 +01:00
James Hawkins
6e2048bbc7
msi: Read the source list properties from the user-unmanaged context.
2008-02-26 11:20:18 +01:00
James Hawkins
acfed4cfab
msi: Read the disk prompt source list property from the user-unmanaged context.
2008-02-26 11:20:13 +01:00
James Hawkins
d62bd166dc
msi: Remove setting a source list property that's in the wrong place.
2008-02-26 11:20:07 +01:00
James Hawkins
4d2cf7a44b
msi: Publish source information in the user-unmanaged context.
2008-02-26 11:20:02 +01:00
James Hawkins
7e8cd606a0
msi: Add tests for MsiSourceListEnumMediaDisks.
2008-02-26 11:19:45 +01:00
James Hawkins
1bd49bcf74
msi: Implement MsiSourceListEnumMediaDisks.
2008-02-26 11:19:40 +01:00
James Hawkins
45d7d6a4e1
msi: Fix skipping a NULL record.
2008-02-26 11:19:29 +01:00
Paul Vriens
89c8e795d8
msi/tests: Make tests run on win9x/NT4 again.
2008-02-25 19:49:54 +01:00
James Hawkins
21b4af1b46
msi: Fix and simplify handling of REG_MULTI_SZ strings in the WriteRegistryValues action.
2008-02-25 12:22:16 +01:00
James Hawkins
b532c0c306
msi: Simplify MsiSourceListAddMediaDisk.
2008-02-25 12:22:09 +01:00
James Hawkins
d3b3738567
msi: Remove invalid fixmes.
2008-02-25 12:22:03 +01:00
James Hawkins
08172ad1c4
msi: Return the result of the call to OpenSourceKey.
2008-02-25 12:21:58 +01:00
James Hawkins
34d50c1e3e
msi: Validate the parameters of MsiSourceListAddMediaDisk.
2008-02-25 12:21:51 +01:00
James Hawkins
1fced5cc1d
msi: Add tests for MsiSourceListAddMediaDisk.
2008-02-25 12:21:42 +01:00
James Hawkins
8b540d2670
msi: Fix the INSTALLPROPERTY_LASTUSEDTYPE case.
2008-02-25 12:21:19 +01:00
James Hawkins
737dedfcbb
msi: Fix the INSTALLPROPERTY_LASTUSEDSOURCE case.
2008-02-25 12:20:56 +01:00
James Hawkins
d41cae07d5
msi: Factorize and fix the INSTALLPROPERTY_MEDIAPACKAGEPATH case.
2008-02-25 12:20:48 +01:00
James Hawkins
f178985db3
msi: Simplify the check for a valid product code.
2008-02-25 12:20:39 +01:00
James Hawkins
868de4d56b
msi: Add more tests for MsiSourceListGetInfo.
2008-02-25 12:20:33 +01:00
James Hawkins
88c7c2c7a1
msi: Fix the size of the data sent in to RegSetValueExW.
2008-02-22 12:11:16 +01:00
James Hawkins
e43eee8759
msi: Fix the INSTALLPROPERTY_LASTUSEDSOURCE case of MsiSourceListSetInfo.
2008-02-21 12:53:00 +01:00
James Hawkins
6c7339eea1
msi: Allow enumerating the sources without querying the source name.
2008-02-21 12:53:00 +01:00
James Hawkins
3de0014750
msi: Publish a few SourceList properties.
2008-02-21 12:53:00 +01:00
James Hawkins
2d5ba8d20d
msi: Implement MsiSourceListEnumSources.
2008-02-21 12:53:00 +01:00
James Hawkins
55b470545f
msi: Forward MsiSourceListEnumSourcesA to a stub implementation of MsiSourceListEnumSourcesW.
2008-02-20 12:07:10 +01:00
Gerald Pfeifer
db70edfc82
msi: Remove unused parameter to msi_comp_find_prodcode().
2008-02-19 18:08:38 +01:00
Gerald Pfeifer
6bf0f0e1f6
msi: Adjust the signedness of three variables.
2008-02-19 18:08:28 +01:00
James Hawkins
123602df78
msi: Remove invalid FIXMEs.
2008-02-19 13:39:25 +01:00
James Hawkins
7cf6be8aeb
msi: Return ERROR_INVALID_PARAMETER if the context is machine and szUserSid is non-NULL.
2008-02-19 13:39:25 +01:00
James Hawkins
4ee1745e81
msi: Validate the dwOptions parameter of MsiSourceListSetInfo.
2008-02-19 13:39:25 +01:00
James Hawkins
95ef6a1fbc
msi: Simplify the MEDIAPACKAGEPATH and DISKPROMPT cases.
2008-02-19 13:39:25 +01:00
James Hawkins
fe987103fb
msi: Return the results from OpenSourceKey.
2008-02-19 13:39:25 +01:00
James Hawkins
d37ac289db
msi: Return ERROR_UNKNOWN_PATCH if dwOptions contains MSICODE_PATCH.
2008-02-19 13:39:25 +01:00
James Hawkins
f83d049888
msi: Validate the szProduct parameter of MsiSourceListSetInfo.
2008-02-19 13:39:25 +01:00
James Hawkins
10be16f33a
msi: Add tests for MsiSourceListSetInfo.
2008-02-19 13:39:25 +01:00
Francois Gouget
4a7bedfe75
msi: Use 'HKCU\Software\Microsoft\MS Setup (ACME)' as a source for the default user and company names before falling back to the RegisteredXXX values. Fix the conformance test accordingly.
2008-02-19 13:39:24 +01:00
Rob Shearman
9b5d3677df
msi: Remove some unused functions.
2008-02-19 13:39:24 +01:00
James Hawkins
9d0ae904d0
msi: Add tests for MsiSourceListEnumSources.
2008-02-18 12:41:37 +01:00
James Hawkins
f177dc9f90
msi: Add tests for enumerating the source list after publishing.
2008-02-18 12:41:37 +01:00
James Hawkins
40aa7df344
msi: Implement the MSIMODIFY_REFRESH command of MsiViewModify.
2008-02-18 12:41:37 +01:00
James Hawkins
30e5321867
msi: Add tests for the MSIMODIFY_REFRESH command.
2008-02-18 12:41:37 +01:00
James Hawkins
bbdf79bc8c
msi: Convert REG_DWORD properties to strings in MsiGetProductInfo.
2008-02-18 12:41:37 +01:00
James Hawkins
8412a1363b
msi: Set the UserLanguageID property.
2008-02-18 12:41:37 +01:00
Rob Shearman
85fbdfcc9e
msi: Fix the character count passed into RegSetValueExA in test_MsiQueryFeatureState.
2008-02-18 12:41:36 +01:00
Marcus Meissner
11b25a65ac
msi: Fixed error reporting of add_streams_to_table.
2008-02-16 15:15:26 +01:00
Paul Vriens
4c105b2f5c
msi/tests: Services are not available on win9x.
2008-02-15 11:07:19 +01:00
Rob Shearman
e35bd05082
msi: Add stub implementation of MsiIsProductElevatedA/W.
2008-02-15 09:59:59 +01:00
James Hawkins
050fa6a40c
msi: Add tests for source folder resolution.
2008-02-13 16:41:14 +01:00
James Hawkins
ec086f77e3
msi: Handle carriage returns in MsiDatabaseImport.
2008-02-12 22:59:53 +01:00
James Hawkins
00cfd2899b
msi: Use MsiViewModify instead of building a SQL query when adding rows to the table.
2008-02-12 22:59:46 +01:00
James Hawkins
4cc569cce6
msi: Read the language info from the file.
2008-02-12 22:59:37 +01:00
James Hawkins
1f3d6a9744
msi: Reimplement MsiGetProductInfo.
2008-02-12 22:59:29 +01:00
James Hawkins
f461a8d4c1
msi: Test the remaining installer properties returned by MsiGetProductInfo.
2008-02-11 20:55:03 +01:00
James Hawkins
ff0dc44f2d
msi: Return ERROR_INVALID_PARAMETER if szProduct is invalid.
2008-02-11 20:53:13 +01:00
James Hawkins
33c1e6ef56
msi: Add tests for MsiGetProductInfo.
2008-02-11 20:47:52 +01:00
James Hawkins
0d56df214b
msi: Successfully return an empty string when requesting a record index beyond the record's size.
2008-02-11 20:45:24 +01:00
James Hawkins
2750ed167f
msi: Don't check for the existence of the msi package when running a concurrent install.
2008-02-11 20:45:17 +01:00
James Hawkins
a8d87a86cc
msi: Handle the special table _ForceCodepage in MsiDatabaseExport.
2008-02-11 20:42:29 +01:00
James Hawkins
7d529228d3
msi: Add tests for not using quotes in SQL queries.
2008-02-11 20:42:19 +01:00
Alexandre Julliard
2e6ec39565
msi/tests: Fix test that depends on the order of the files in a directory.
2008-02-11 20:41:40 +01:00
James Hawkins
d89ee5fdd6
msi: Test using carriage returns in SQL queries and imported tables.
2008-02-07 12:09:10 +01:00
Michael Stefaniuc
41848c828b
msi: Fix "type of 'x' defaults to 'int'" warnings.
2008-02-06 11:36:04 +01:00
James Hawkins
2f658cb337
msi: Fix handling of the NULL separator when writing registry values.
2008-02-05 12:21:23 +01:00
James Hawkins
5a0d459cc4
msi: Reimplement MsiFormatRecord.
2008-02-05 12:19:37 +01:00
James Hawkins
e618c6d115
msi: Add more tests for MsiFormatRecord.
2008-02-05 12:19:37 +01:00
James Hawkins
ffc251f5dd
msi: Return ERROR_MORE_DATA if the size is too small.
2008-02-05 12:19:37 +01:00
James Hawkins
dc8f714ade
msi: Return the string length even if the string is NULL.
2008-02-05 12:19:37 +01:00
James Hawkins
40841946f5
msi: Leave room for the NULL terminator.
2008-02-05 12:19:37 +01:00
James Hawkins
d165435048
msi: Return ERROR_FILE_INVALID if the file has no version information.
2008-02-05 12:19:37 +01:00
James Hawkins
03335de8d0
msi: Return ERROR_INVALID_PARAMETER if a string pointer is non-NULL and the size pointer is NULL.
2008-02-05 12:19:37 +01:00
James Hawkins
856800c84b
msi: Translate ERROR_BAD_PATHNAME into ERROR_FILE_NOT_FOUND.
2008-02-05 12:19:37 +01:00
James Hawkins
5d46eeac75
msi: Only convert output strings if the call succeeded.
2008-02-05 12:19:36 +01:00
James Hawkins
8079d9f2ab
msi: Add tests for MsiGetFileVersion.
2008-02-05 12:19:36 +01:00
James Hawkins
146e34e662
msi: Implement the MSIMODIFY_ASSIGN action of MsiViewModify for the streams table.
2008-02-05 12:19:36 +01:00
James Hawkins
56574c7c6e
msi: Add tests for using single quotes in an INSERT query.
2008-02-05 12:19:36 +01:00
Paul Vriens
46f1330e02
msi/tests: Only use functions if they are implemented.
2008-01-24 12:08:44 +01:00
Paul Vriens
3272fef91a
msi/tests: Only use functions if they are implemented.
2008-01-24 12:08:39 +01:00
James Hawkins
1868abda89
msi: Add more MsiFormatRecord tests.
2008-01-21 11:51:20 +01:00
Marcus Meissner
943ac9795b
msi: Replaced msi_free() by LocalAlloc() since ConvertSidToStringSidW uses LocalAlloc().
...
Spotted by Christoph von Wittich <Christoph@ApiViewer.de>.
2008-01-21 11:51:08 +01:00
Christoph von Wittich
007833f130
msi: Fix process token leak.
2008-01-21 11:39:37 +01:00
Francois Gouget
44b52b128c
Assorted spelling fixes.
2008-01-16 12:48:29 +01:00
James Hawkins
ced64861f5
msi: dest_path refers to the directory prefix, not the entire file path.
2008-01-16 12:16:43 +01:00
Francois Gouget
62c59deaa1
msi/tests: Tweaked so it does not look like things are misspelled.
2008-01-11 12:25:44 +01:00
Gerald Pfeifer
388edd1086
msi: Complete initializers.
2008-01-10 13:20:15 +01:00
James Hawkins
4b75f33012
msi: Actually delete the row data instead of blanking it out.
2008-01-09 13:38:02 +01:00
James Hawkins
419a8a2426
msi: Test committing a table with a removed row.
2008-01-09 13:38:02 +01:00
James Hawkins
ce8199a46e
msi: Handle markers in the WHERE section of an UPDATE query, with tests.
2008-01-09 13:38:02 +01:00
Rico Schüller
63c5e152a1
msi: Fix memory leaks (found by Smatch).
2008-01-07 13:46:06 +01:00
James Hawkins
5352d099b4
msi: Create parent directories when duplicating files if they don't exist, with tests.
2008-01-07 12:16:56 +01:00
James Hawkins
837588c6a3
msi: Pad the month and day to two digits.
2008-01-07 12:16:45 +01:00
James Hawkins
d316a94ecb
msi: Remove an erroneous table.
2008-01-07 12:16:30 +01:00
James Hawkins
c37849ad82
msi: Copy the temporary package when storing the installer.
2008-01-07 12:16:15 +01:00
James Hawkins
e28cedf698
msi: Check the local package for existence when resolving the package source.
2008-01-07 12:16:04 +01:00
James Hawkins
b012c3366c
msi: Directly download mi->source now that SourceDir points to the URL.
2008-01-07 12:15:56 +01:00
James Hawkins
186487663a
msi: OriginalDatabase can be a URL so check for a forward slash too.
2008-01-07 12:15:48 +01:00
James Hawkins
062070bfbe
msi: SourceDir is formed from the path of OriginalDatabase.
2008-01-07 12:15:27 +01:00
James Hawkins
781e19aa4c
msi: OriginalDatabase is the fully-expanded path to the original package if the package is local and installed from the command line.
2008-01-07 12:15:16 +01:00
James Hawkins
c777d3095a
msi: Factor out msi_set_sourcedir_props.
2008-01-07 12:15:10 +01:00
James Hawkins
4121c9bbc6
msi: If the package is a URL, the OriginalDatabase property should be the URL and the DATABASE property should be the path to the local temporary package.
2008-01-07 12:15:01 +01:00
James Hawkins
31c461ea5b
msi: WriteEnvironmentStrings should also write to REG_EXPAND_SZ strings.
2008-01-07 12:14:52 +01:00
James Hawkins
4b4f737bfc
msi: Only read an internal package if the file to install is compressed.
2008-01-07 12:14:43 +01:00
Gerald Pfeifer
2b1e487d36
msi: Adjust the types of loop variables.
2008-01-04 12:12:43 +01:00
Gerald Pfeifer
bb8471beac
msi: Remove an extraneous safety check and simplify generate_error_string().
2008-01-03 11:53:45 +01:00
Gerald Pfeifer
739152ce3e
msi: Remove an extraneous safety check and simplify deformat_string().
2008-01-02 13:29:41 +01:00
Austin English
92e7fed80c
msi: Fix several typos.
2008-01-02 13:20:06 +01:00
Lionel Debroux
99ad76c3c1
msi: Correctly handle return value of msi_realloc.
2008-01-02 13:17:52 +01:00
Gerald Pfeifer
f7fea9e9f0
msi: Simplify condition in TABLE_fetch_stream().
2008-01-02 12:38:42 +01:00
Michael Stefaniuc
1f26b146d1
janitorial: Remove superfluous backslashes at end of lines.
2007-12-31 19:23:45 +01:00
Gerald Pfeifer
63655bc1a1
msi: Add missing initializer for delete_ops.
2007-12-31 17:29:24 +01:00
Gerald Pfeifer
05cf0bdf81
msi: Fix error handling in encode_streamname().
2007-12-27 13:43:56 +01:00
Rob Shearman
5b072fbbec
msi: Fix several memory leaks after using IEnumSTATSTG_Next.
...
The pwcsName field of STATSTG must be freed, otherwise the memory will
be leaked.
2007-12-26 14:02:01 +01:00
Andrew Talbot
15d6436295
msi: Remove unneeded cast.
2007-12-24 13:30:24 +01:00
James Hawkins
f0d369ba44
msi: Allow whitespace after the property name when setting a property in the dialog.
2007-12-23 14:17:11 +01:00
James Hawkins
58c7fe1095
msi: Allow the not-equal operator in WHERE query string comparisons.
2007-12-23 14:17:11 +01:00
James Hawkins
3c0f7ca4e6
msi: Fix deleting temporary rows, with tests.
2007-12-23 14:17:11 +01:00
James Hawkins
f4eea10bed
msi: The BS_GROUPBOX style should only be used if the HasBorder attribute is set.
2007-12-20 12:17:21 +01:00
James Hawkins
18407eafdc
msi: Initialize a default COM apartment for custom actions.
2007-12-20 10:47:35 +01:00
James Hawkins
1d42de71ea
msi: Allow NULL parameters to be passed to the local MsiSetProperty.
2007-12-20 10:47:32 +01:00
James Hawkins
b774ffe1d2
msi: Free the ordering information.
2007-12-19 12:18:54 +01:00
Francois Gouget
a39ea2e8ba
msi: Add a trailing '\n' to Wine traces.
2007-12-18 12:32:55 +01:00
James Hawkins
91c205e8c0
msi: Sort each table of the join separately.
2007-12-18 12:32:55 +01:00
James Hawkins
f93ee6f420
msi: Test sorting a table using a column that is not selected.
2007-12-18 12:32:55 +01:00
James Hawkins
b1ce93f944
msi: Set the text color after calling the window proc.
2007-12-17 11:48:39 +01:00
James Hawkins
b1cc87cb65
msi: The line control has a height of exactly 2 device units.
2007-12-17 11:48:35 +01:00
James Hawkins
4295ce4fb6
msi: Return ERROR_INVALID_PARAMETER if the product list is empty and index is not zero.
2007-12-17 11:48:30 +01:00
James Hawkins
88d51ad122
msi: Return ERROR_UNKNOWN_COMPONENT if no products exist.
2007-12-17 11:48:26 +01:00
James Hawkins
3edd258fcd
msi: Also check the local system component key for the clients.
2007-12-17 11:48:21 +01:00
James Hawkins
fced2fee2f
msi: Check the user component key for the clients.
2007-12-17 11:48:13 +01:00
James Hawkins
5f7b95dadd
msi: Validate the parameters of MsiEnumClients.
2007-12-17 11:48:03 +01:00
James Hawkins
64c75d1e02
msi: Add tests for MsiEnumClients.
2007-12-17 11:47:58 +01:00
James Hawkins
4777a3a33b
msi: Simplify ExpandAnyPath.
2007-12-17 11:47:49 +01:00
James Hawkins
ce6e84c071
msi: Verify that the PID_PAGECOUNT and PID_REVNUMBER summary info properties exist.
2007-12-17 11:35:33 +01:00
James Hawkins
620862e385
msi: If the package doesn't exist, return ERROR_FILE_NOT_FOUND.
2007-12-17 11:35:23 +01:00
James Hawkins
f933dd8b4f
msi: Validate the parameters of MsiOpenPackage.
2007-12-17 11:35:17 +01:00
James Hawkins
8fab39cc60
msi: Add more tests for MsiOpenPackage.
2007-12-17 11:35:11 +01:00
James Hawkins
1277e1b55a
msi: Release the record when loading the hash data.
2007-12-17 11:35:05 +01:00
Marcus Meissner
964a0303c1
msi: Fixed buffer overflow in number parsing.
2007-12-17 11:33:33 +01:00
James Hawkins
fa8476e7f6
msi: Close the file handle returned by FindFirstFile.
2007-12-14 12:26:21 +01:00
Lionel Debroux
fe444f0217
msi: Fix memory leaks (found by Smatch).
2007-12-13 14:30:40 +01:00
Lionel Debroux
1bed47a3b3
msi: Fix missing alloc check.
2007-12-13 14:30:40 +01:00
James Hawkins
d51ed8bd93
msi: Free the cabinet string on error.
2007-12-12 13:48:50 +01:00
James Hawkins
80894d1c52
msi: Properly release the record.
2007-12-12 13:48:46 +01:00
James Hawkins
e62b8c9b99
msi: Free the user sid string.
2007-12-12 13:48:42 +01:00
James Hawkins
f919a24eb2
msi: Free the deformatted string.
2007-12-12 13:48:38 +01:00
James Hawkins
e6431cd06e
msi: Handle the CompLocator table in the AppSearch action.
2007-12-08 19:53:49 +01:00
James Hawkins
44349af11a
msi: Reimplement MsiGetProductCode.
2007-12-08 19:53:43 +01:00
James Hawkins
2634d86a08
msi: Remove two tests that depend on the sort order of RegEnumValue.
2007-12-08 19:53:39 +01:00
James Hawkins
8090dbad93
msi: Add tests for MsiGetProductCode.
2007-12-07 17:07:16 +01:00
James Hawkins
383a8a5b92
msi: Reimplement MsiGetComponentPath.
2007-12-05 12:08:04 +01:00
James Hawkins
ced84f5b53
msi: Add tests for MsiGetComponentPath.
2007-12-05 12:07:35 +01:00
James Hawkins
440af17322
msi: Test the CompLocator subset of the AppSearch action.
2007-12-04 18:17:01 +01:00
James Hawkins
c77d200f27
msi: Add a stub implementation of MsiEnumComponentCostsW.
2007-12-03 14:03:11 +01:00
James Hawkins
b57a2f93a9
msi: Implement the Version property of the Installer object.
2007-12-03 14:03:06 +01:00
James Hawkins
6a30e1b0b4
msi: Test the CCPSearch action.
2007-12-03 14:03:00 +01:00
James Hawkins
80bbf58378
msi: Use a hash table for reordering rows in a WHERE query to conserve space.
2007-12-03 13:44:46 +01:00
James Hawkins
33a4fe19de
msi: Don't check for the media or cabinet if the cabinet is internal.
2007-11-29 13:37:13 +01:00
James Hawkins
32d3ffc5c5
msi: Make sure attr is valid before checking for the directory bit.
2007-11-29 13:37:07 +01:00
Anatoly Lyutin
704c399237
msi: Fix invalid SQL query.
2007-11-28 11:14:42 +01:00
James Hawkins
63fe32a8bb
msi: Downgrade an ERR to a WARN.
2007-11-26 12:28:49 +01:00
James Hawkins
6dd927a265
msi: Fix the condition of a FIXME.
2007-11-26 12:28:44 +01:00
James Hawkins
0a05a87436
msi: Downgrade an ERR to a WARN.
2007-11-26 12:28:37 +01:00
James Hawkins
8912798fb5
msi: Downgrade a FIXME to a WARN.
2007-11-26 12:28:31 +01:00
James Hawkins
ca9a4dc0d9
msi: Only check the volume label if it's different than the first media's volume label.
2007-11-26 12:28:24 +01:00
James Hawkins
4160722b07
msi: Check the destination file's hash and skip that file if the hash matches.
2007-11-26 12:28:15 +01:00
James Hawkins
6a6a218548
msi: Set the file contents of the file hash test file explicitly.
2007-11-26 12:28:03 +01:00
James Hawkins
e100288934
msi: Verify the szFilePath parameter of MsiGetFileHash.
2007-11-26 12:27:53 +01:00
James Hawkins
ef7d16c816
msi: Add tests for MsiGetFileHash and clean up the existing tests.
2007-11-26 12:27:45 +01:00
Misha Koshelev
ac2c1b8070
msi: automation: Fix ITypeInfo leak.
2007-11-20 16:39:19 +01:00
Misha Koshelev
c30d03f8cc
msi/tests: automation: Add missing VariantClear.
2007-11-20 16:39:14 +01:00
Misha Koshelev
74a2ce4d99
msi/tests: Close opened service handles.
2007-11-20 16:38:56 +01:00
Misha Koshelev
fce6f56f93
msi: automation: Fix automation object reference counts when objects are created.
2007-11-20 16:38:42 +01:00
James Hawkins
075e84bd90
msi: Check the cabinet's full path for existence, not just the cabinet name.
2007-11-20 12:29:00 +01:00
James Hawkins
78eead93fd
msi: Don't check for a cabinet's existence if it's embedded in the package.
2007-11-19 12:55:36 +01:00
James Hawkins
4e9940990b
msi: Don't ignore the error returned by ready_media.
2007-11-15 12:48:29 +01:00
James Hawkins
b1507aee98
msi: Only check the presence of the cabinet if the file is compressed.
2007-11-15 12:48:18 +01:00
James Hawkins
0023759a4b
msi: Add tests for situations involving missing cabinets.
2007-11-15 12:48:08 +01:00
James Hawkins
bb747e4fbe
msi: Simplify ready_media.
2007-11-15 12:47:59 +01:00
James Hawkins
474fca1eec
msi: Fix the condition for checking a drive.
2007-11-13 13:35:50 +01:00
James Hawkins
bee95916f7
msi: Set the file to NULL when running the directory search.
2007-11-13 13:35:41 +01:00
James Hawkins
9459ef5ab1
msi: Implement the VolumeSelectCombo control.
2007-11-13 13:35:27 +01:00
James Hawkins
c68825569d
msi: Test the Uninstall registry entries.
2007-11-13 13:35:21 +01:00
James Hawkins
f6b27673b0
msi: Delete the uninstall key when the product is removed.
2007-11-13 13:35:01 +01:00
James Hawkins
0e29f314f5
msi: Return a remote interface to the database in a custom action.
2007-11-12 12:06:40 +01:00
James Hawkins
7dffb518c0
msi: Create the _Tables table when creating a database.
2007-11-12 12:06:29 +01:00
James Hawkins
ef1277d462
msi: Test the default tables added by MsiOpenDatabase.
2007-11-12 12:06:22 +01:00
Alexandre Julliard
0590fe2ecf
Make some variables static.
2007-11-06 14:38:54 +01:00
James Hawkins
25a612b8f3
msi: Test that the install state is dependent on the feature and component registration.
2007-11-06 14:01:21 +01:00
James Hawkins
c31fd4371a
msi: Process the ADDSOURCE property when setting feature states.
2007-11-06 14:01:17 +01:00
James Hawkins
75b825da17
msi: Test the install states of removed features.
2007-11-06 14:01:12 +01:00
James Hawkins
fcc490d047
msi: Add a missing struct initialization.
2007-11-06 14:01:03 +01:00
James Hawkins
1a0b23cd7d
msi: Implement the CCPSearch standard action.
2007-11-05 14:55:24 +01:00
James Hawkins
1c1cf26997
msi: Explicitly check the returned value against -1 as the variable is unsigned.
2007-11-05 14:55:14 +01:00
James Hawkins
3a5178e900
msi: Don't update a table entry when applying a transform if the string value is the same.
2007-11-05 14:54:11 +01:00
James Hawkins
9d71238a16
msi: Fix the location used to write the user's environment variables.
2007-11-05 14:54:05 +01:00
James Hawkins
2df062182a
msi: Remove an unused parameter.
2007-11-05 14:53:58 +01:00
James Hawkins
556a01d7c5
msi: Use a magic constant to silence signedness comparison warnings.
2007-11-05 14:53:34 +01:00
James Hawkins
546bcef0bb
msi: MsiQueryProductState returns INSTALLSTATE, not UINT.
2007-11-05 14:53:27 +01:00
James Hawkins
b03082c397
msi: MsiQueryFeatureState and MsiUseFeatureEx return INSTALLSTATE, not UINT.
2007-11-05 14:53:21 +01:00
James Hawkins
37895faaa8
msi: MsiViewGetError returns MSIDBERROR, not UINT.
2007-11-05 14:53:16 +01:00
James Hawkins
76275bea09
msi: Remove an unused parameter.
2007-11-05 14:53:10 +01:00
James Hawkins
cf8e9e3311
msi: Remove an unused parameter.
2007-11-05 14:53:04 +01:00
James Hawkins
bb54ed1335
msi: Fix the sign of an index variable.
2007-11-05 14:52:56 +01:00
James Hawkins
1a896348d5
msi: Remove a legacy error check.
2007-11-05 14:52:51 +01:00
James Hawkins
35a6782d7b
msi: Test and implement the MSIMODIFY_DELETE command.
2007-11-05 14:52:46 +01:00
James Hawkins
341d1fa7b5
msi: Initialize a handle in case MsiGetSummaryInformation fails.
2007-11-05 14:52:38 +01:00
James Hawkins
21bde9d974
msi: Fix the location used to read machine context source list info.
2007-11-05 14:52:31 +01:00
James Hawkins
21619964da
msi: szUserSid must be NULL if context is MSIINSTALLCONTEXT_MACHINE.
2007-11-05 14:52:25 +01:00
James Hawkins
14d439c863
msi: Handle the MSIINSTALLCONTEXT_USERMANAGED context.
2007-11-05 14:52:19 +01:00
James Hawkins
3d5b3ef903
msi: Reimplement MsiSourceListAddSourceEx to handle reordering the source list.
2007-11-05 14:52:09 +01:00
James Hawkins
d9a8f0b5fe
msi: The options must include a source type.
2007-11-05 14:48:31 +01:00
James Hawkins
7fe6aad7fa
msi: An empty source is an invalid parameter.
2007-11-05 14:48:25 +01:00
James Hawkins
dde89244e5
msi: Append a slash to network and url sources.
2007-11-05 14:48:16 +01:00
James Hawkins
798429f9ca
msi: Validate the product code.
2007-11-05 14:47:33 +01:00
James Hawkins
861ae27a4f
msi: Return the error from OpenSourceKey.
2007-11-05 14:47:26 +01:00
James Hawkins
266ee0f571
msi: Add tests for MsiSourceListAddSourceEx.
2007-11-05 14:47:11 +01:00
James Hawkins
22c10da044
msi: Don't create the product source key when adding a source.
2007-11-05 14:46:59 +01:00
James Hawkins
44e1c7d79b
msi: Implement MsiSourceListAddSourceExA.
2007-11-05 14:46:52 +01:00
James Hawkins
405d0be4f7
msi: do_query is supposed to fail, so don't release a handle that is never initialized.
2007-11-05 14:46:41 +01:00
James Hawkins
07c3f4411e
msi: A feature's requested action does not depend on its installed state.
2007-11-01 12:43:24 +01:00
James Hawkins
ccdf578ba2
msi: Only unpublish the features if the entire product is being uninstalled.
2007-11-01 12:43:18 +01:00
James Hawkins
9f11a5a878
msi: Properly register features.
2007-11-01 12:43:12 +01:00
James Hawkins
fc6b9dd4e4
msi: Properly register and unregister components.
2007-11-01 12:43:06 +01:00
James Hawkins
eec9bbb12d
msi: Remove a duplicated function.
2007-11-01 12:42:57 +01:00
James Hawkins
c3df74e24f
msi: Implement the MoveFiles standard action.
2007-11-01 12:42:50 +01:00
James Hawkins
b9a29e221f
msi: Test the MoveFiles standard action.
2007-11-01 12:41:54 +01:00
James Hawkins
4d2e148fb0
msi: Use package_from_db instead of opening the package with MsiOpenPackage.
2007-10-26 14:03:47 +02:00
James Hawkins
1d9c680eed
msi: Output expected values on failing tests.
2007-10-26 14:03:47 +02:00
James Hawkins
a992991262
msi: Define _WIN32_MSI to pull in new definitions.
2007-10-26 14:03:47 +02:00
James Hawkins
d258484b0b
msi: Set the ROOTDRIVE property so the admin sequence won't choose its own.
2007-10-26 14:03:46 +02:00
James Hawkins
5169d04ec2
msi: Add missing newline to the adm_custom_action table.
2007-10-26 14:03:46 +02:00
Francois Gouget
c4b1195c0c
Assorted spelling fixes.
2007-10-23 18:20:27 +02:00
James Hawkins
5606428a71
msi: Set media info strings to NULL after freeing them.
2007-10-23 18:05:32 +02:00
James Hawkins
85bd53a675
msi: Include the null terminator when writing data to the stream.
2007-10-23 18:05:25 +02:00
James Hawkins
39bcc662e4
msi: Don't delete the table if the table deleted itself because of a release.
2007-10-23 18:05:05 +02:00
James Hawkins
b6cfc405bd
msi: Release the record only after using the record's data.
2007-10-23 18:04:50 +02:00
Mikolaj Zalewski
96e4320feb
msi: Use BS_GROUPBOX for group boxes.
2007-10-22 12:36:07 +02:00
Detlef Riekenberg
c54219fb40
msi/tests: Do not leak a HKEY when RegQueryValueEx failed.
2007-10-19 12:26:17 +02:00
Mikolaj Zalewski
d5b620ea0b
msi: Make the WriteEnvironmentStrings handling of [~] a bit better.
2007-10-18 13:21:44 +02:00
James Hawkins
2694cf3ff8
msi: Add handling for MSIMODIFY_INSERT for the streams table.
2007-10-18 12:10:13 +02:00
James Hawkins
2274388323
msi: Save nonpersistent strings as holes in the string pool.
2007-10-18 12:10:05 +02:00
James Hawkins
36df6a0655
msi: Test adding nonpersistent strings to the string table.
2007-10-18 12:09:52 +02:00
James Hawkins
26f86c55c9
msi: Return ERROR_FUNCTION_FAILED if a matching row is not found.
2007-10-18 12:09:39 +02:00
James Hawkins
46ec7ee183
msi: Return ERROR_FUNCTION_FAILED when inserting duplicate keys.
2007-10-18 12:09:33 +02:00
Alexandre Julliard
6adf058089
msi: Avoid casting const pointers to non-const.
2007-10-17 14:14:21 +02:00
Alexandre Julliard
71747518ad
msi: Properly clear the new table data when a column is added.
2007-10-17 14:13:53 +02:00
Marcus Meissner
6f865b9497
msi: Common Files is translated to current language.
2007-10-17 13:41:45 +02:00
Marcus Meissner
9684c9fee6
msi: Marked two variables static.
2007-10-17 13:40:59 +02:00
James Hawkins
0e2db26fa3
msi: Only double the returned size when szValueBuf is NULL.
2007-10-16 12:48:07 +02:00
Daniel Nylander
59450c91ff
msi: Add Swedish translation.
2007-10-16 12:38:10 +02:00
Detlef Riekenberg
7f655802a3
msi: Dump the database name in a FIXME.
2007-10-04 11:28:53 +02:00
Alexandre Julliard
cd2780e2a7
msi: Avoid accessing a freed object.
2007-10-01 18:07:49 +02:00
Mikolaj Zalewski
cf84cbac5b
msi: Add some already implemented function to the spec file.
2007-09-28 11:00:04 +02:00
Juan Lang
a3331c6f22
msi: Initialize nested.
2007-09-18 10:42:14 +02:00
Juan Lang
71a78c4478
msi: Make sure nested is initialized.
2007-09-18 10:42:05 +02:00
Juan Lang
c2d66da665
msi: Don't crash if record has no fields.
2007-09-18 10:41:58 +02:00
Alexandre Julliard
e4959bf1bc
msi: We can now store binary files in the repository.
2007-09-17 15:53:53 +02:00
Stefan Leichter
e96695a652
msi: Remove 'recursive registry key delete' function.
2007-08-27 11:58:35 +02:00
Paul Vriens
f581a1cbef
msi/tests: Be verbose when GetProcAddress fails.
2007-08-21 21:38:31 +02:00
Marcus Meissner
fb4901759b
msi: Allocate 1 byte more buffer.
2007-08-13 12:25:32 +02:00
James Hawkins
b353a09569
msi: Add tests for the RemoveFiles standard action.
2007-08-13 11:35:42 +02:00
Paul Vriens
5f16125246
msi/tests: Run tests again on win98 and NT4.
2007-08-10 16:19:03 +02:00
James Hawkins
6ac0816109
msi: Implement the UnpublishFeatures standard action.
2007-08-10 12:58:17 +02:00
Francois Gouget
5771700019
msi: Better match the PSDK types, remove some now unused types from win32.api, and update it to fix the winapi_check warnings.
2007-08-09 14:12:44 +02:00
James Hawkins
511bdd9de8
msi: Simplify MsiQueryComponentState, with more tests.
2007-08-09 13:53:36 +02:00
James Hawkins
0713c32869
msi: Implement the remaining contexts for MsiQueryComponentState.
2007-08-08 15:32:00 +02:00
James Hawkins
ca55c7a330
msi: Implement the MSIINSTALLCONTEXT_MACHINE context for MsiQueryComponentState.
2007-08-07 12:39:48 +02:00
James Hawkins
5f442207d5
msi: Forward MsiQueryComponentStateA to MsiQueryComponentStateW.
2007-08-07 12:39:36 +02:00
James Hawkins
072adfa99a
msi: Add tests for MsiQueryComponentState.
2007-08-07 12:39:27 +02:00
Francois Gouget
4deb14a3b6
msi: Fix the MsiEnumProductsEx*(), MsiQueryComponentState*() and MsiProvideQualifiedComponentEx*() prototypes.
2007-08-06 13:57:53 +02:00
James Hawkins
f1b790be06
msi: Fix the size allocated for the deferred custom action string.
2007-08-06 12:18:08 +02:00
James Hawkins
2e6ed06fdc
msi: Reimplement joins to allow joining any number of tables, each of arbitrary size.
2007-08-02 12:18:42 +02:00
James Hawkins
4f6a93b9c8
msi: Add tests for joining three tables.
2007-08-02 12:18:42 +02:00
Paul Vriens
5e7b31b51d
msi/registry: Use the return value of squash_guid.
2007-07-30 23:37:58 +02:00
James Hawkins
37286473a0
msi: Add a stub implementation of MsiSourceListEnumSourcesA.
2007-07-30 15:27:02 +02:00
James Hawkins
5e81dbebb0
msi: Treat an empty string and a NULL string as the same value.
2007-07-30 15:26:51 +02:00
Misha Koshelev
03d19b5782
msi: Use SysAllocString/SysFreeString for BSTR members of EXCEPINFO structure.
2007-07-30 13:38:11 +02:00
James Hawkins
9089835c35
msi: Use a more unique property separator.
2007-07-30 12:51:55 +02:00
James Hawkins
ac1f717ab8
msi: Keep track of the wildcard record index.
2007-07-30 12:51:47 +02:00
James Hawkins
b830fb0a34
msi: Implement the MSIMODIFY_UPDATE command in the SELECT view.
2007-07-27 12:24:39 +02:00
James Hawkins
fb45206ed7
msi: Initialize the size parameter.
2007-07-27 12:24:08 +02:00
James Hawkins
b0ac20e951
msi: Add more tests for MSIMODIFY_UPDATE.
2007-07-27 12:24:02 +02:00
James Hawkins
6af199ef9c
msi: Use a different separator as a semi-colon may separate values in the CustomActionData.
2007-07-25 13:03:45 +02:00
James Hawkins
f4147ca004
msi: Add handling for the MSIMODIFY_UPDATE command.
2007-07-24 11:49:59 +02:00
James Hawkins
479aca4731
msi: Add tests for the MSIMODIFY_UPDATE command.
2007-07-24 11:49:50 +02:00
James Hawkins
8a7690c151
msi: Properly delete the columns view.
2007-07-24 11:49:33 +02:00
Andrew Talbot
0e14c29d66
msi: Cast-qual warning fix.
2007-07-24 11:25:40 +02:00
James Hawkins
ccef56f2cc
msi: Ref count temporary columns and release them when necessary.
2007-07-23 11:55:34 +02:00
James Hawkins
0fd733bf90
msi: Implement adding columns using the ALTER command.
2007-07-23 11:55:11 +02:00
Juan Lang
955f5f3910
msi: Return FALSE from MsiGetMode for MSIRUNMODE_OPERATIONS.
2007-07-19 14:38:37 +02:00
James Hawkins
3b1ab76986
msi: Implement reference counting for tables, manipulated with the HOLD and FREE sql commands.
2007-07-19 12:00:43 +02:00
James Hawkins
0169533be8
msi: Add more tests for the ALTER command.
2007-07-19 11:59:59 +02:00
Michael Stefaniuc
02933a11de
dlls: Remove unreachable break after return/break. Found by Smatch.
2007-07-19 11:57:49 +02:00
James Hawkins
24e158e972
msi: Only double the size if the remote call is from MsiGetPropertyA.
2007-07-18 12:58:23 +02:00
James Hawkins
929acbcb7f
Revert "msi: Only call a custom action remotely if the type is msidbCustomActionTypeInScript."
...
This reverts f2ae31000b
commit.
2007-07-18 12:58:15 +02:00
James Hawkins
f2ae31000b
msi: Only call a custom action remotely if the type is msidbCustomActionTypeInScript.
2007-07-17 12:55:03 +02:00
James Hawkins
dc3060c542
msi: Load the AdminProperties stream if the package is an Admin package.
2007-07-17 12:54:53 +02:00
Paul Vriens
02d14c85e7
msi/tests: Don't create a directory that's not needed.
2007-07-16 13:36:49 +02:00
James Hawkins
6805bf8ace
msi: Add a test for running an ADMIN install.
2007-07-13 14:41:34 +02:00
James Hawkins
ba257f0cea
msi: Add a test for installing from different current working directories.
2007-07-13 14:41:14 +02:00
James Hawkins
6c940b9b49
msi: Fix compilation in MSVC.
2007-07-13 14:41:04 +02:00
James Hawkins
ed281b725a
msi: Fix three tests that were failing in Windows.
2007-07-13 14:40:59 +02:00
James Hawkins
c7b53d37e1
msi: Fix automation.c compile for MSVC.
2007-07-13 14:40:55 +02:00
James Hawkins
30fc5602de
msi: Reload properties as they may have been changed by a transform.
2007-07-13 12:27:33 +02:00
James Hawkins
cf3f442754
msi: Fix a copy and paste error.
2007-07-13 12:27:28 +02:00
Alexandre Julliard
3f9632ca53
msi/tests: Comment out call to function that is still a stub in Wine.
2007-07-12 13:00:47 +02:00
James Hawkins
0f6aaf86bd
msi: Add tests for adding properties with a transform during an install.
2007-07-11 12:42:59 +02:00
James Hawkins
1093eb83cd
msi: Add tests for adding properties in a transform.
2007-07-11 12:42:55 +02:00
James Hawkins
5a8e0e8c1d
msi: Fix current _Property table tests and add more tests.
2007-07-11 12:42:45 +02:00
James Hawkins
f0b97cb1e1
msi: Check for NULL transform, as there may be no transforms for the _Columns or _Tables tables.
2007-07-11 12:00:53 +02:00
James Hawkins
17ba74195b
msi: Handle adding columns in transforms.
2007-07-10 13:35:50 +02:00
James Hawkins
9285351ad3
msi: Test adding columns with data in a transform.
2007-07-10 13:35:39 +02:00
James Hawkins
5af06dec83
msi: Delete msifile after the tests.
2007-07-10 13:35:31 +02:00
James Hawkins
dfa1b1299c
msi: Match the changes made by the hand-generated and API-generated transforms.
2007-07-10 13:35:11 +02:00