Commit Graph

196 Commits

Author SHA1 Message Date
Juan Lang 961193bc5d shell32: Always NULL-terminate path in SHGetPathFromIDList. 2006-07-11 17:37:13 +02:00
Jonathan Ernst 360a3f9142 Update the address of the Free Software Foundation. 2006-05-23 14:11:13 +02:00
Eric Pouech 1be2e1edef shell32: Fixes for bugs found by valgrind on shell32 tests harness.
- read strings from left to right (PathGetDriveNumberW)
- don't access buffers before they are filled (SHGetPathFromIDListW)
- fill buffers & variables on all paths (SHELL_FindExecutable)
- handle error condition (unix_fs)
- don't shoot in the blind for AW APIs (tests/shelllink.c)
2006-02-22 12:04:02 +01:00
Michael Jung d7326ca7e5 shell32: Return a GUID pidl for CSIDL_PERSONAL in SHGetFolderLocation.
The tests (shellpath.c/testPersonal) already show that it can be either 
PT_FOLDER or PT_GUID. It's PT_GUID on WinXP.
2006-02-14 11:35:12 +01:00
Huw Davies 51fd750707 shell: Fix incorrect usage of the return value of StrRetToStrNW. 2006-01-20 20:17:07 +01:00
Michael Jung 5136f57f12 shell32: Helper function for unicode support in folder and file pidls. 2006-01-03 13:23:44 +01:00
Francois Gouget 0edbaf7e80 Remove spaces before '\n' in traces. 2005-11-10 12:14:56 +00:00
Markus Amsler 671738d5c1 Improve c2man Documented-Total count. Changes:
- add missing description
- add missing returns section
- complete missing A/W pairs
- reformate comments, to match c2man requirements
2005-11-10 11:15:22 +00:00
Michael Jung 937441b3ac Don't clone pidlLast in SHBindToParent. 2005-09-07 09:22:49 +00:00
Jason Edmeades c1cd0d22e0 Add the time to the file display dialog modified column. 2005-08-19 10:01:25 +00:00
Ge van Geldorp 75139a3e01 Fix resource leak on error paths. 2005-08-15 14:50:18 +00:00
Michael Jung 433197172d Fail in SHGetDataFromIDList when called on special folder. 2005-07-08 14:18:32 +00:00
Mike McCormack e28c014a84 -Wpointer-sign fixes. 2005-07-03 12:03:35 +00:00
Michael Jung ebb1aaee86 Implement SHGetPathFromIDList based on GetDisplayNameOf. 2005-06-15 10:20:00 +00:00
Mike Hearn 25abe7c537 Fix SHELL_GetPathFromIDList[AW] to return the desktop path given an
empty PIDL.
2005-05-10 08:27:23 +00:00
Huw Davies 0e5b772cdc Add a unicode pidl type.
Improve support for PT_YAGUID.
Improve IShellLink debugging.
2005-04-13 14:39:27 +00:00
Francois Gouget 93416cdaf7 Assorted spelling fixes. 2005-03-23 13:15:18 +00:00
Mike McCormack 3d9ba61478 Cleanup, create unicode versions of _ILCreateFromPath,
_ILCreateGuidFromStr, and _ILCreateFromFindData.
2005-02-22 14:50:35 +00:00
Mike McCormack 59ce35aba8 Remove tabs and make formatting consistent. 2005-02-21 18:36:47 +00:00
Francois Gouget 4d801b66e6 Assorted spelling fixes. 2005-02-10 19:19:35 +00:00
Michael Stefaniuc 5ad7d858e0 Do not check for non NULL pointer before HeapFree'ing it. It's
redundant.
2004-12-23 17:06:43 +00:00
Alexandre Julliard 758b2887e9 Remove some no longer needed AW functions. 2004-12-17 19:20:07 +00:00
Jon Griffiths f82272c92f Remove unneeded headers to reduce unneeded rebuilds. 2004-12-16 14:35:55 +00:00
Eric Pouech 0a258964c2 Const correctness fixes. 2004-11-30 21:38:57 +00:00
Juan Lang 535679aec7 Fix CSIDL_CONTROLS and CSIDL_PRINTERS PIDL types, and update tests now
that they pass.
2004-10-26 00:17:31 +00:00
Francois Gouget 486d020c1b Don't define COBJMACROS in objbase.h.
Update the Wine sources accordingly.
2004-10-07 03:06:48 +00:00
Marcus Meissner 2e6e18bfbb Marked some functions in debughlp as static.
Do not use REFIID as return, but IID*.
2004-08-09 18:49:42 +00:00
Ge van Geldorp c390bb2aea Match prototypes to Platform SDK. 2004-06-28 20:32:53 +00:00
Juan Lang 6d169747d6 Correct return value in a couple of error cases. 2004-04-15 05:04:10 +00:00
Martin Fuchs a9a04e8d4f - make drive letters in PIDLs always uppercase to enable PIDL
comparison
- Unicodify _ILCreateDrive()
2004-04-15 04:57:46 +00:00
Martin Fuchs 618cf6fc0f Return "file not found" error values instead of E_INVALIDARG if
_ILCreateFromPathA() failed to find files.
2004-04-14 23:57:46 +00:00
Juan Lang bbdd20d536 Correct some PIDL types and eliminate some magic numbers in PIDL
allocation; correct a copy-pasto from a previous patch.
2004-04-14 19:33:07 +00:00
Juan Lang c00fbafbbf Move control panel applet enumeration to cpanelfolder.c. 2004-04-08 04:37:43 +00:00
Martin Fuchs 31cd6b8cf3 - SHBindToParent(): request correct COM interface from desktop.
- _ILCreateFromFindDataA(): type cast to eliminate MSVC compiler
  warning.
2004-04-07 21:58:50 +00:00
Juan Lang f3301c6ba9 - comment fixes
- improved error checking and conformance with Windows
- remove some spurious error messages
2004-04-07 19:45:48 +00:00
Juan Lang 42f28a72e9 - rename PT_SPECIAL to PT_SHELLEXT
- remove unnecessarily complex _ILCreate
- combine _ILCreateValue and _ILCreateFolder, since their outputs
  differed by only one byte.
2004-04-06 23:12:11 +00:00
Juan Lang fe7c9e5f95 Rename PT_MYCOMP to PT_GUID, and the corresponding union member from
mycomp to guid.
2004-04-06 03:22:29 +00:00
Martin Fuchs dd46d6df9e Implementation of the control panel folder in shell namespace. 2004-03-27 01:42:22 +00:00
Francois Gouget b948778660 Assorted spelling fixes. 2004-03-23 23:20:16 +00:00
Robert Shearman f6e1be6afe Allow passing NULL to ILFindLastID. 2004-03-22 22:58:19 +00:00
Alexandre Julliard 22508e576f FindFirstFile can return an empty short name if the long name is a
valid DOS name, fixed callers to handle that properly.
2004-03-17 01:50:27 +00:00
Martin Fuchs fa828cd057 - move some PIDL function declarations from undocshell.h into public
header, as they are no longer undocumented
- implement context menu support for Winefile
2004-02-11 04:18:12 +00:00
Mike McCormack cb9a22b787 Fix the bounds checking in SHGetPathFromIDListA/W. 2004-02-09 20:56:41 +00:00
Francois Gouget 6b6ed724ae Add missing '\n's to debug traces. 2004-01-27 00:01:43 +00:00
Martin Fuchs 516b50f34c - don't link directly to NTDLL; use MultiByteToWideChar() instead of
RtlCreateUnicodeStringFromAsciiz()
- directly call InitCommonControlsEx()
2004-01-26 20:13:03 +00:00
Alexandre Julliard aa43d01627 Authors: Martin Fuchs <martin-fuchs@gmx.net>, Ge van Geldorp <ge@gse.nl>
Reimplementation of SHGetPathFromIDListA/W() using the new helper
functions SHELL_GetPathFromIDListA/W(). The new implementation avoids
using IShellFolder::GetDisplayNameOf(), so that it
- returns the absolute file system path, not relative to the dekstop
- returns FALSE as error code if the path can not converted in a valid
  file system path
- doesn't return virtual CLSID paths
2004-01-21 23:50:26 +00:00
Martin Fuchs 74bcd4e43f Implemented SHGetRealIDL(). 2004-01-21 22:12:55 +00:00
Martin Fuchs 423cb99ac5 - SHGetDataFromIDListA/W(): handle drives when retrieving file
attributes
- fixed error handling to avoid GPFs
2004-01-20 23:38:04 +00:00
Martin Fuchs 6e775f898a - declare PT_RAS_FOLDER for the "RAS Connections" folder
- handle PT_RAS_FOLDER and PT_NETPROVIDER in debugging functions and
  _ILGetTextPointer() / _ILGetSTextPointer()
2004-01-18 22:08:46 +00:00
Martin Fuchs 963dd34ec0 - correct return value of SHGetPathFromIDList[AW]() for virtual
folders like "My Computer"
- correct path parsing in ISF_Desktop_fnParseDisplayName()
- handle CLSID paths in ISF_MyComputer_fnParseDisplayName()
- return CLSID path in ISF_MyComputer_fnGetDisplayNameOf()
2003-12-30 19:24:22 +00:00
Dmitry Timoshkov 3baa9b99fd Protect ILIsParent from NULL pidls. 2003-11-04 04:21:01 +00:00
Dimitrie O. Paun b0f4a564a1 Move useful information out of documentation/shell32. 2003-10-09 19:47:08 +00:00
Francois Gouget 224063f033 Some spelling fixes.
Fix the case of WineHQ.
2003-09-29 20:20:53 +00:00
Rolf Kalbermatter 5e46d9f9d7 Add some comments to functions and minor fixes.
Export already existing (but still undocumented) functions
ILCreateFromPathA/W.
2003-09-25 20:26:28 +00:00
Rolf Kalbermatter 58c0561bad Added declarations for newly documented SHChangeNotify API and fixed
some prototypes.
2003-09-22 19:24:13 +00:00
Rolf Kalbermatter d1ffc6f11c Implemented SHSimpleIDListFromPath correctly. 2003-09-17 04:17:33 +00:00
Alexandre Julliard e37c6e18d0 Fixed header dependencies to be fully compatible with the Windows
headers (with help from Dimitrie O. Paun).
2003-09-05 23:08:26 +00:00
Martin Fuchs 63fecde98b Declare LPCITEMIDLIST as 'const' pointer and adjust shell32
implementation to the corrected type.
2003-09-02 01:01:06 +00:00
Martin Fuchs 65b4d2dc75 Fixed Ansi version of RenderFILENAME and implement a Unicode version.
Implemented CFSTR_FILENAME with Unicode filename.
2003-07-26 20:32:43 +00:00
Mike Hearn 72d8aa5ec2 Deal with the case of loading an empty PIDL from a stream better in
ILLoadFromStream.
2003-07-22 01:00:47 +00:00
Robert Shearman f0df2b2c51 Add a PIDL type For Network Provider. 2003-05-19 21:42:44 +00:00
Rolf Kalbermatter 468494cb83 Implemented ILGetDisplayNameExA and ILGetDisplayNameExW and call them
from ILGetDisplayNameAW and ILGetDisplayNameExAW.
2003-04-17 02:18:33 +00:00
Rolf Kalbermatter 1c481f3da8 Add new helper function to create a relative file or folder ItemIDList
for a path and change usage of SHSimpleIDListFromPath to call new
function instead.
2003-03-26 23:35:23 +00:00
Jon Griffiths cd4234aa49 Documentation updates. 2003-03-18 18:35:48 +00:00
Rolf Kalbermatter 65a3de5aa3 Change calls to CLSIDFromString to SHCLSIDFromStringW except in
SHCLSIDFromStringW for the time being.
2002-12-16 23:48:30 +00:00
Rolf Kalbermatter caf31cee32 Added Unicode versions of the HCR_ internal functions. 2002-12-13 23:45:36 +00:00
Rolf Kalbermatter a1b709d32e Resolve SHGetPathFromIDListW -> SHGetPathFromIDListA call.
Remove Fixme comment in SHGetPathFromIDList as StrRetToStrN should
take care of this.
Get rid of some unsigned/signed comparison warnings with default
warnings in MSVC.
2002-12-12 23:00:24 +00:00
Johan Dahlin 991fd85d2f Make shell32 compile with -DSTRICT. 2002-11-21 23:56:42 +00:00
Patrik Stridvall ced69a9cad Fixed mismatches between the Wine headers and the Microsoft headers. 2002-11-12 01:05:00 +00:00
Patrik Stridvall 9aab47ed24 MSVC compatibility fixes. 2002-08-28 23:42:34 +00:00
Alexandre Julliard fb2eca812d Import comctl32 functions from shell32 by ordinal.
Removed some unnecessary ordinals in comctl32.spec.
2002-07-29 00:24:58 +00:00
Juergen Schmied 1e5ec8893d - Cleaned up the implementation of shell folders and put them into
separate files.
- Fixed some memory leaks.
- Some more fixes.
2002-07-24 01:56:03 +00:00
Juergen Schmied 23b808791e - changed STRRET definition
- small changes for seperation of shell32 from ole32
- debughelper for printing interface names (shell internal)
- changed shell memory allocation to use IMalloc of ole32 when this
  library is already loaded
- fallback IMalloc internally in shell
- unified constructor syntax for several objects  created by DllGetClassObject
- rewrote instance creation for com objects
- made the desktop folder parsing paths like ::{CLSID}
- Implemented IPersistFolder3 partially
2002-07-02 02:05:17 +00:00
Vincent Béron 9a62491660 Removed trailing whitespace. 2002-05-31 23:06:46 +00:00
Juergen Schmied 7919d5a178 Moving the pidl debug functions to a separate file and made them self
contained. This prevents useless trace messages generated from the
debug functions themselves.
2002-05-09 19:42:07 +00:00
Huw D M Davies 0b8e8d10b7 Check for failure of IShellFolder_GetDisplayNameOf. 2002-04-03 22:52:52 +00:00
Alexandre Julliard 0799c1a780 Added LGPL standard comment, and copyright notices where necessary.
Global replacement of debugtools.h by wine/debug.h.
2002-03-09 23:29:33 +00:00
Andreas Mohr 8bc7f16caa Spelling/alignment fixes. 2002-02-27 01:34:08 +00:00
Alexandre Julliard c72a9aa83e CodeWeavers
Minor fixes.
2002-01-31 21:05:05 +00:00
Alexandre Julliard 18f4d651c5 Removed use of SET_DEBUGGING, it's broken anyway. 2002-01-22 00:54:20 +00:00
Francois Gouget 7aa67c1d6a Make the Wine trace facilities accessible from Winelib applications. 2002-01-21 23:39:36 +00:00
Guy Albertelli aafec98803 - Define rest of URL_ESCAPE... and other flags.
- Define implemented interfaces for reg.c and url.c.
2001-11-06 22:31:19 +00:00
Francois Gouget 070e749cfb Don't prefix %p with 0x.
Various English fixes.
2001-11-06 21:01:32 +00:00
Francois Gouget b60c4ce0f0 Don't print NULL strings (crashes on Solaris).
Small code maintainability tweak in ShellExecuteExA.
Two typo fixes in winmm.
2001-10-14 16:15:05 +00:00
Alexandre Julliard 3954117ce4 Moved undocshell.h to dlls/shell32. Removed shell16.h. 2001-08-16 18:49:56 +00:00
Patrik Stridvall 01d5e5b071 Documentation fixes. 2001-07-02 19:59:40 +00:00
Patrik Stridvall 3ca9823941 Documentation ordinal fixes. 2001-06-20 23:03:14 +00:00
Patrik Stridvall 8b216b3d02 Documentation ordinal fixes. 2001-06-19 18:20:47 +00:00
Andreas Mohr 0005e81fe1 Implemented SHELL32.IsNetDrive and SHELL32.ILSaveToStream needed for
IE 5.
2001-01-18 23:04:19 +00:00
Huw D M Davies 62519abbaf Moved all the documented shlwapi functions out of undocshell.h into
shlwapi.h.  Nothing but files in dlls/shell32 will now include
undocshell.h.
2001-01-07 21:50:52 +00:00
Alexandre Julliard 24a62ab9b0 Got rid of the Wine internal lstrcpy* functions and of winestring.h. 2000-11-28 22:40:56 +00:00
Alexandre Julliard eb58e1d597 Declare debug channels in all dlls that need them; added imports of
ntdll where necessary.
2000-11-05 04:53:07 +00:00
Alexandre Julliard 83f52d11c1 Moved all Win16 definitions out of the standard Windows headers. 2000-09-26 22:20:14 +00:00
Alexandre Julliard 74af67ef42 Removed shell.h. Cleaned up the nested includes mess in wine/obj_*.h. 2000-09-26 00:00:55 +00:00
Alexandre Julliard d586dc99be Replaced VERSION_* calls by exported API equivalents. 2000-08-14 14:35:01 +00:00
Alexandre Julliard 917910324f Cleaned up a few inter-dll dependencies. 2000-06-23 16:13:33 +00:00
Juergen Schmied 3e56dbc9a4 - fixed null-pidl from _ILCreateControl
- some more no-name functions in shlwapi
2000-06-16 21:50:59 +00:00
Juergen Schmied 0d18aad17a - New (some stubs): SHGetFolderLocation, PathAddExtension,
PathIsUNCServer, PathIsUNCServerShare, PathMakePretty,
  SHCreateShellPalette, SHOpenRegStream, SHOpenRegStream2
- Many string functions implemented
- Some stubs for exports by ordinal
2000-06-01 23:25:44 +00:00
Juergen Schmied 1b4f5bb2ce Small fixes. 2000-04-28 20:17:14 +00:00
Ulrich Czekalla 40cd846356 _ILGetFileDate should convert the date to local time before generating
the string (_ILGetFileDateTime does not).
2000-04-11 19:36:35 +00:00