Commit Graph

60 Commits

Author SHA1 Message Date
Andrey Gusev 9519216fa0 winhlp32: Remove redundant comparison.
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-09 16:02:31 +01:00
Andrey Gusev 6ef27773a7 winhlp32: Fix a typo in comment.
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-27 16:22:51 +09:00
Kirill Smirnov 85c67cca96 winhlp32: Fix an uninitialized variable (clang).
Signed-off-by: Kirill K. Smirnov <kirill.k.smirnov@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-17 14:18:03 +09:00
Jean-Christophe Cardot 1dba777e69 winhlp32: Use debugstr_a() to trace.
Signed-off-by: Jean-Christophe Cardot <wine@cardot.net>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-22 21:04:34 +09:00
Francois Gouget ddcbbb6943 winhlp32: Remove an unneeded NONAMELESSSTRUCT directive. 2015-04-03 11:22:14 +09:00
Michael Stefaniuc 9bf064a67a winhlp32: Simplify code that happened to work by chance (PVS-Studio). 2015-03-06 20:32:03 +09:00
Frédéric Delanoy 1e214eb5d3 Assorted spelling/grammar fixes. 2014-10-02 16:58:53 +02:00
Nikolay Sivov 6c1d5f0bac winhlp32: Remove unused assignments (Coverity). 2014-04-11 18:56:28 +02:00
Frédéric Delanoy 6eadc8ca4e winhlp32: Use BOOL type where appropriate. 2013-10-22 16:37:40 +02:00
Rico Schüller ab8cc4acdb winhlp32: Always open files as read only. 2013-04-08 11:37:03 +02:00
André Hentschel bc240bd323 winhlp32: Mark up fallthrough switch case (coverity). 2012-11-08 15:37:52 +01:00
Alexandre Julliard c0f65cc99b winhlp32: Don't use strncpy. 2012-01-23 16:07:36 +01:00
Alexandre Julliard e12d39dc10 winhlp32: Avoid Unicode macros. 2012-01-20 12:50:15 +01:00
Francois Gouget d30316568a winhlp32: Add support for accelerators in general and F1 in particular. 2011-04-08 13:03:22 +02:00
Francois Gouget 3767e9a2dc winhlp32: Remove the unimplemented help color and visibility menus. 2011-03-31 14:02:13 +02:00
Alexandre Julliard 5d69141014 winhlp32: Use a standard About dialog, with the proper icon. 2010-10-15 16:17:51 +02:00
André Hentschel ba56392b92 winhlp32: Update translations. 2010-08-24 12:24:20 +02:00
Eric Pouech 0f234ce461 winhelp: When following a link, don't do it into a popup, but its parent. 2010-06-14 14:14:15 +02:00
Eric Pouech dbab3367a3 winhelp: Don't close popup just after they are created. 2010-06-07 12:34:22 +02:00
Eric Pouech 0865dc7c8c winhelp: Don't reset window position when reusing the current window. 2010-06-07 12:34:21 +02:00
Eric Pouech 79af1859fa winhelp: When opening a page, don't reopen the same page from macro, even if requested. 2010-06-07 12:34:08 +02:00
Alexandre Julliard 84412cb0f5 winhlp32: Get rid of the shadow window, it's ugly and causes z-order issues. 2010-05-22 11:24:03 +02:00
Gerald Pfeifer 073743170c winhlp32: Remove variable keyDelta which is not really used from WINHELP_MainWndProc. 2010-05-03 15:37:39 +02:00
Gerald Pfeifer b33d0d5405 winhlp32: Remove not really used id from WINHELP_IndexDlgProc. 2010-04-20 16:22:28 +02:00
Alexandre Julliard 0763861873 winhlp32: Set the window class small icon for all classes. 2010-04-19 20:13:11 +02:00
Rob Shearman dd4804c413 winhlp32: Restore the original window proc for the richedit control before freeing the winhelp window memory. 2009-11-09 19:43:31 +01:00
Eric Pouech 3d0475eb4d winhelp: Added support for hotspot links in graphical objects. 2009-09-22 17:46:52 +02:00
Owen Rudge 395acfc545 winhlp32: Ensure Open dialog is modal. 2009-07-24 11:10:55 +02:00
Eric Pouech a99ab94cc5 winhlp32: Fixed some cases where winhlp32 didn't shutdown as expected. 2009-06-29 12:25:35 +02:00
Stefan Stranz 1a0a47d60c winhlp32: Fix crash on launch. 2009-06-04 12:50:55 +02:00
Eric Pouech a105f924f4 winhlp32: Fix typo in color init. 2009-06-01 16:16:04 +02:00
Eric Pouech d67df82636 winhlp32: Correctly set the window's title when no window information is present. 2009-06-01 16:16:04 +02:00
Eric Pouech 82ffc04ef3 winhlp32: Now manage windows with refcounts. 2009-06-01 16:16:04 +02:00
Eric Pouech e3beef0af5 winhlp32: Remove the lpszName field from the window structure, as it's given by the window info. 2009-06-01 16:16:04 +02:00
Eric Pouech a6104304f4 winhlp32: Window name lookup is supposed to be insensitive. 2009-06-01 16:16:03 +02:00
Eric Pouech 042bbf9a41 winhlp32: Force the handling of a current help window while processing a macro. 2009-06-01 16:16:03 +02:00
Rein Klazes 9e8f2a7024 programs: Make some of the open file dialogs of a few programs resizable. 2009-05-06 12:20:10 +02:00
Michael Stefaniuc cd4a7c3146 winhlp32: Remove superfluous casts. 2009-04-06 12:58:01 +02:00
Dylan Smith 2592fea305 winhlp32: Invalidate scrollbar when changing pages. 2009-03-24 10:27:27 +01:00
Dylan Smith cbf820abb0 winhlp32: Links are clicked on WM_LBUTTONDOWN not WM_LBUTTONUP.
This behaviour was tested against native winhlp32 by pressing down the
left mouse button and holding it while over the link to avoid having
WM_LBUTTONUP sent.  I noticed that the action for clicking the link
happened right away, without waiting for me to release the mouse button.
2009-03-12 13:09:54 +01:00
Dylan Smith a36b408f7e winhlp32: Prevent cursor flicker on mouse moves over richedit control.
Previously the cursor was being set by winhlp32 on WM_MOUSEMOVE, then
the richedit control would change it again on WM_SETCURSOR.  Since the
cursor set in both of these places was different, the cursor would
flicker from being frequently changed.

The reason winhlp32 is setting the cursor, rather than letting the
richedit control set the cursor, is that winhlp32 needs the hand cursor
to be shown over a link.  My first instinct was to just add the CFE_LINK
effect to the link characters, however this also forced a colour for the
link that was inconsistent with native winhlp32.  Native winhlp32
doesn't seem to load any richedit dll, so this doesn't imply that there
is an undocumented way of changing the colour of characters with
CFE_LINK.

This patch has winhlp32 override the WNDPROC for the richedit control to
handle the WM_SETCURSOR.  It simply sets the cursor to the hand if the
cursor is over the link, otherwise it just calls the original richedit
window proc.
2009-03-11 13:03:33 +01:00
Dylan Smith fb63cd0c87 winhlp32: Use EM_SCROLL to scroll richedit control.
Previously the richedit control contents were scrolled directly using
ScrollWindow.  This caused the richedit control to not actually scroll,
but only look like it scrolled, therefore causing plenty of glitches.
2009-03-09 12:04:11 +01:00
Alexandre Julliard 1cd730b289 winhlp32: Fix a crash when started without arguments. 2009-02-24 16:57:29 +01:00
Marcus Meissner 55ae86ccb1 winhlp32: Check hlpfile for being NULL (Coverity). 2009-02-02 15:44:39 +01:00
Alexandre Julliard 32484769b8 winhlp32: Use GetWindowLongPtr to retrieve a pointer, and make sure there is enough space for it. 2009-01-09 14:05:56 +01:00
Francois Gouget 7d81ca1c31 winhlp32: Make some functions static in winhelp.c. 2009-01-08 14:52:52 +01:00
Francois Gouget 2364498da3 winhlp32: Reorder some functions to avoid forward declarations in winhelp.c. 2009-01-08 14:52:47 +01:00
Kirill K. Smirnov 520ab5c261 winhlp32: Clear richedit area before setting text. 2008-08-05 14:09:38 +02:00
Kirill K. Smirnov a7cb435400 winhlp32: Remove outdated comment. 2008-08-01 12:21:03 +02:00
Eric Pouech 8291034d01 winhelp: Double clicking in the index list should open the page. 2008-07-14 12:20:45 +02:00