2d5ca30994
wininet: Removed redundant NULL check (Coverity).
2008-11-03 11:50:10 +01:00
bd80529709
wininet: Add an exception handler in HttpOpenRequestA to protect against invalid accept type pointers.
2008-10-24 14:25:00 +02:00
d5dca63cb6
wininet: Don't destroy authentication data when closing the connection.
...
Fixes basic authentication in combination with connection close semantics.
Spotted by Vincent Povirk.
2008-10-17 14:12:33 +02:00
b261836709
wininet: Fix HTTP_ProcessCookies only processing one cookie.
2008-10-08 14:17:08 +02:00
0715d9c123
wininet: Fix crash when calling HttpQueryInfoA/W(HTTP_QUERY_RAW_HEADERS) before any response has been received from a server.
2008-10-08 12:17:11 +02:00
128b8a5e0c
wininet: Avoid a crash on certain buffer size queries in HTTP_HttpQueryInfoW.
2008-10-07 12:03:12 +02:00
d31ce9ae37
wininet: Compare HRESULT values explicitly against S_OK instead of using an implicit != 0 comparison.
2008-10-01 11:43:30 -05:00
8c20124fc4
wininet: Support setting username and password through options.
2008-09-25 11:51:41 +02:00
f7e56d19c4
wininet: Remove redundant CrLf variables.
2008-08-28 11:24:50 +02:00
bc9e214f6f
wininet: Work around NULL headers when handling HTTP_QUERY_RAW_HEADERS_CRLF.
2008-08-28 11:24:50 +02:00
17c0c0a54b
wininet: Default to keep-alive when the server is HTTP/1.1, not when it isn't.
2008-08-19 14:56:06 +02:00
1e7f89194c
wininet: HTTP_QUERY_RAW_HEADERS_CRLF length shouldn't include nul.
2008-07-31 14:02:04 +02:00
216d4c0834
wininet: Fix cookie buffer overflow.
...
Spotted by Yann Droneaud.
2008-07-21 12:22:05 +02:00
572b0bab88
wininet: Move insertion of cookie header from HttpOpenRequest to HttpSendRequest.
...
Based on a patch by Yann Droneaud.
2008-07-21 12:21:58 +02:00
e3e2622e41
wininet: Fix a memory leak.
2008-07-21 12:21:27 +02:00
7426e7e055
wininet: Moved more InternetQueryOption implementation to vtbl.
2008-07-21 12:18:48 +02:00
13a95f1648
wininet: Move InternetQueryOption(INTERNET_OPTION_USER_AGENT) to vtbl.
2008-07-21 12:18:41 +02:00
fd5b97bc4d
wininet: Always respect Proxy-Connection: or Connection: if it exists.
2008-07-17 10:51:26 +02:00
4f51b6c1d8
wininet: Add port number to Host HTTP header.
2008-07-07 14:16:07 +02:00
ad2f53db8f
wininet: Add support of INTERNET_FLAG_NO_CACHE_WRITE.
2008-07-07 14:16:07 +02:00
70218092bb
wininet: Remove unneeded variable.
2008-07-04 19:50:58 +02:00
bdf311f91f
wininet: Only reconnect when redirected to an external site.
2008-06-30 15:08:47 +02:00
6233704481
wininet: Resolve hostname once per connection.
2008-06-24 11:45:18 +02:00
34ff555cf9
wininet: Send a 'Pragma: no-cache' header if asked for.
2008-06-24 11:45:10 +02:00
3434935f44
wininet: Clear last error upon successful return from HttpSendRequest.
2008-06-24 11:44:57 +02:00
62e0a8ca38
wininet: Fix memory leak in HTTP_DeleteCustomHeader.
...
Free the memory associated with the field and value of the custom
header otherwise it will be leaked. Found by Valgrind.
2008-06-21 11:12:50 +02:00
bbd550ad5c
wininet: Always pass a variable as lpNumberOfBytesWritten on a WriteFile call if lpOverlapped is set to NULL.
2008-06-19 11:47:03 +02:00
656a035821
wininet: Don't send a "Connection: Close" header.
2008-06-02 14:05:32 +02:00
2f99450c49
wininet: Make resolving hostnames thread-safe.
2008-06-02 13:44:31 +02:00
bd58463eda
wininet: Send https scheme to proxy server when appropriate.
2008-05-22 11:44:29 +02:00
694a09284a
wininet: Fix buffer size query for HttpQueryInfo(HTTP_QUERY_RAW_HEADERS_CRLF).
2008-05-19 14:04:10 +02:00
e1b889830d
wininet: INTERNET_STATUS_REQUEST_COMPLETE callback must supply a handle.
2008-05-19 13:35:24 +02:00
6021fa09f3
wininet: Fix a typo in is_basic_auth_value.
...
This fixes basic authentication when the server uses a realm string.
2008-05-19 13:35:19 +02:00
1c5bc9a772
wininet: HTTP_BuildProxyRequestUrl returns a pointer.
2008-05-12 14:01:06 +02:00
aec0e93d23
wininet: Don't overwrite content length header in HttpSendRequest.
2008-05-12 14:00:51 +02:00
493b6915ca
wininet: Deal with bogus accept types array passed into HttpOpenRequestA.
2008-05-07 17:49:31 +02:00
07ae2992b8
wininet: Remove unused variables.
2008-05-05 12:52:26 +02:00
e2f690a0ac
wininet: Don't add the user agent header until HttpSendRequest is called.
2008-05-05 12:51:56 +02:00
d3051cba22
wininet: Don't forget the INTERNET_STATUS_REDIRECT callback in HttpEndRequest.
2008-04-24 12:03:34 +02:00
a1ebffb452
wininet: Remove custom content-length/type headers from redirects.
2008-04-23 12:23:39 +02:00
6e59cd2c34
Spelling fixes.
2008-04-22 12:20:12 +02:00
bade2a31a6
wininet: Correct the case where Content-Length is set as well as Transfer-Encoding == chunked.
2008-04-18 11:45:52 +02:00
631f469cb5
wininet: Avoid size_t type in trace.
2008-04-04 13:12:21 +02:00
612f3c1414
wininet: Use INTERNET_MAX_URL_LENGTH to size buffers we intend to store a URL in.
2008-04-01 11:27:03 +02:00
8210e1b454
wininet: Parse the redirect URL in HTTP_HandleRedirect in case of a proxy connection.
2008-04-01 11:26:52 +02:00
729631d907
wininet: Remove dead code from HTTP_DealWithProxy and improve its debug trace.
2008-04-01 11:26:42 +02:00
e4c59c263d
wininet: Don't set the host port from the server port.
...
This works for direct connections but in case of proxy connections server
port and host port usually are different.
2008-03-31 13:00:42 +02:00
0ffe9f5207
wininet: Fix redirects through a proxy.
...
HTTP_DealWithProxy replaces the request path with a full URL to make sure
a correct request is built for for the proxy. This will work just once in
case of a redirect because the path will be appended to the redirect url,
resulting in an incorrect url.
2008-03-31 13:00:32 +02:00
454fae8432
wininet: Don't close proxy connections when keep-alive is specified.
2008-03-31 13:00:18 +02:00
0929593b6c
wininet: InternetReadFileExA should check INTERNET_FLAG_ASYNC.
2008-03-28 09:50:42 +01:00
aaecdf79bd
wininet: HttpSendRequestExA is not a stub.
2008-03-28 09:50:38 +01:00
058761fa34
wininet: Support chunked reads in InternetReadFileEx too.
2008-03-26 23:48:13 +01:00
0936601f5b
wininet: Implement chunked reads.
2008-03-26 13:46:12 +01:00
3a57711bb8
wininet: Don't strip Accept-Encoding headers from version 1.1 requests.
2008-03-25 11:33:32 +01:00
db5745c001
wininet: If we receive an error from InitializeSecurityContext in HTTP_DoAuthorization then set pAuthInfo->finished so that we don't carry on using the security context.
2008-03-15 10:58:38 +01:00
e74514b138
wininet: Assume that if we're connected to an HTTP/1.1 server then connections can be kept alive by default.
...
So don't close the connection in this case in HTTP_FinishedReading.
2008-03-15 10:58:38 +01:00
ebaa4d987d
wininet: Only clear authentication header if the connection has authentication information.
2008-03-12 17:55:21 +01:00
b8ad4dee86
wininet: Fix proxy authentication by using the data in lpwhr->pProxyAuthInfo in HTTP_InsertAuthorization instead of lpwhr->pAuthInfo when inserting the Proxy-Authentication header.
2008-03-12 17:55:12 +01:00
7e63f95326
wininet: Move InternetQueryOption(INTERNET_OPTION_SECURITY_CERTIFICATE_STRUCT) to vtbl.
2008-03-12 12:00:00 +01:00
ce6a2289c6
wininet: Move InternetQueryOption(INTERNET_OPTION_DATAFILE_NAME).
2008-03-12 11:59:54 +01:00
0e010d83a1
wininet: Move InternetQueryOption(INTERNET_OPTION_URL) to vtbl.
2008-03-12 11:59:47 +01:00
e2933c20d6
wininet: Move INTERNET_OPTION_HANDLE_TYPE to vtbl.
2008-03-12 11:59:41 +01:00
0be05ab6aa
wininet: Retrieve the maximum token length from the SSP and use a buffer of that length in calls to InitializeSecurityContextW.
...
Otherwise, InitializeSecurityContextW could run out of space with our
small, fixed buffer and fail.
2008-03-10 19:12:54 +01:00
7631bdf0c1
wininet: Allow HTTP_DoAuthorization to accept a NULL username/domain in the non-Basic case.
...
When using SSPI, pass in a NULL identity in this case so that the SSP
can try to use cached credentials.
2008-03-10 19:12:54 +01:00
8c6ac00820
wininet: Don't call DeleteSecurityContext and FreeCredentialsHandle on invalid handles.
2008-03-10 19:12:54 +01:00
bdc81d9963
wininet: Make the reference count of WININETHANDLEHEADER thread-safe by using InterlockedIncrement/InterlockedDecrement.
2008-03-10 19:12:54 +01:00
d597fd12fc
wininet: Moved InternetReadFileExA to vtbl.
2008-03-03 20:45:31 +01:00
ca39a55e88
wininet: Don't use INTERNET_ReadFile in HTTP_DrainContent.
2008-03-03 12:00:32 +01:00
3b4ca69e18
wininet: Move InternetReadFile to vtbl.
2008-03-03 12:00:20 +01:00
9a5c046129
wininet: Move INTERNET_STATUS_REQUEST_COMPLETE call from INTERNET_ReadFile.
2008-03-03 12:00:06 +01:00
3314184597
wininet: Move InternetQueryDataAvailable to vtbl.
2008-02-29 20:07:13 +01:00
8c45eecca7
wininet: Moved InternetFindNextFileW implementation to vtbl.
2008-02-28 10:44:42 +01:00
0e33eee9a2
wininet: Use vtbl for InternetSetOption(INTERNET_OPTION_[SEND|RECEIVE]_TIMEOUT) implementation.
2008-02-27 14:52:25 +01:00
1ffcfbce85
wininet: Use vtbl in InternetWriteFile implementation.
2008-02-27 14:52:24 +01:00
7dc9bf677b
wininet: Moved close_connection to vtbl.
2008-02-27 14:52:24 +01:00
5a535d6b23
wininet: Moved handle destructor to vtbl.
2008-02-27 14:52:24 +01:00
5132fb4469
wininet: Fix retrieving raw headers.
2008-02-27 14:52:24 +01:00
abfa73b5c1
wininet: Document HttpAddRequestHeadersW()'s handling of the trailing '\0'. Fix tracing of the corresponding header strings as they may not be '\0' terminated.
2008-02-19 13:39:24 +01:00
719cd82f35
wininet: Fix potential buffer overrun in HttpQueryInfoA.
...
If HTTP_QUERY_CUSTOM is specified then the buffer contains a
null-terminated string on input and data of length len on output. The
code wasn't taking into account that the input len could be less than
the length of the string and thus could result in the allocated buffer
being overrun with the call to WideCharToMultiByte.
2008-02-19 13:39:24 +01:00
9717113fcb
wininet: Rename a function to better match what it does.
2008-02-18 13:33:52 +01:00
2617fb6dea
wininet: Handle the "100 Continue" response by ignoring it.
2008-02-18 13:33:33 +01:00
d0033dbaed
wininet: Honour the version override in HttpOpenRequest.
2008-02-18 13:33:10 +01:00
f8f9dbbbe7
wininet: Fix an off-by-one error in the boundary checks in HTTP_DecodeBase64.
2008-02-16 13:54:17 +01:00
f979134270
wininet: Code clean up.
2008-02-15 10:00:12 +01:00
d7a49e8147
wininet: Added beginning support for HTTP cache files.
2008-02-15 10:00:03 +01:00
45481db078
wininet: Remove unneeded casts.
2008-02-05 12:19:37 +01:00
b0912d1151
wininet: Add zero value content length header to POST requests only.
2008-02-04 14:18:51 +01:00
c132dd9360
wininet: Send HTTP/1.1 requests by default.
2008-02-04 14:18:20 +01:00
b069ef4268
wininet: Make sure not to overwrite any caller supplied authorization header.
2008-02-04 14:18:20 +01:00
59ab0cf362
wininet: HTTP_Connect should fail if a NULL or empty hostname is passed in.
...
Add tests for these circumstances.
2008-02-04 13:04:34 +01:00
5edcf3ab6c
wininet: Pass the server name into InitializeSecurityContextW.
2008-01-25 12:30:08 +01:00
3f1a20b8b1
wininet: Fix type of a loop variable in HTTP_BuildHeaderRequestStr().
2008-01-14 15:31:37 +01:00
0e4adae973
Spelling fixes.
2008-01-07 13:41:01 +01:00
4d84eb26d0
wininet: Fix handling of host and referrer headers in HttpOpenRequest.
2008-01-07 12:02:12 +01:00
fe475d9e88
wininet: Check return value of InternetCrackUrl when checking referrer host.
2008-01-03 13:30:26 +01:00
01826e0c98
wininet: Don't clear the auth data for Basic authentication in HTTP_InsertAuthorizationForHeader.
...
It isn't tracked per connection, unlike NTLM authentication, and so the
server will return a 401 error and try to get us to authenticate again.
However, this doesn't work as the authentication information is assumed
by the code to be valid for the whole connection.
2007-11-27 16:42:26 +01:00
9adf83e90d
wininet: Don't use HEAP_ZERO_MEMORY on memory that's fully initialized.
2007-11-08 12:18:31 +01:00
a1ab4a7eff
wininet: Fix another typo.
2007-11-08 12:18:30 +01:00
b210e3a751
wininet: Fix typo.
2007-11-08 12:18:30 +01:00
6f44627b04
wininet: Release object in HttpSendRequestExW before return on error.
2007-11-05 15:05:16 +01:00
64359c2432
wininet: Always send a content length header, even if there is no content.
2007-10-29 13:06:50 +01:00
d857c04c95
wininet: Don't assume lpBuffersIn is not NULL.
2007-10-23 12:23:52 +02:00
7d2ac2039b
wininet: Release object in HttpEndRequestW after use.
2007-10-18 13:21:28 +02:00
728e5fa559
wininet: Track child handles, free all child handles on WININET_FreeHandle as native.
2007-09-21 11:53:04 +02:00
d4337f2b5e
wininet: Fix many wininet prototypes: the context is a DWORD_PTR now.
2007-08-30 17:02:49 +02:00
0f117e568f
wininet: Separate connection closing from object destruction.
2007-08-23 13:13:24 +02:00
5320d3e3ea
wininet: Don't send INTERNET_STATUS_HANDLE_CLOSING when closing handle opened with InternetOpen for HTTP connection.
2007-08-22 12:18:59 +02:00
3fa49f0f02
wininet: Make HttpQueryInfo[AW] work for lpBuffer == NULL and len > 0.
2007-08-16 11:52:06 +02:00
ab7d17727c
wininet: Support HTTP_QUERY_RAW_HEADER_CRLF|HTTP_QUERY_FLAG_REQUEST_HEADERS.
2007-08-16 11:51:52 +02:00
bb9413d77a
wininet: Process caller supplied headers after inserting connection and authorization headers, not before.
2007-08-10 12:58:17 +02:00
c8dfc02bfb
wininet: Strip Accept-Encoding from http/1.0 requests.
2007-07-27 12:47:51 +02:00
cb28969c2a
wininet: Implement NTLM support for proxy authentication.
2007-06-06 12:11:34 +02:00
7ad691a5ee
wininet: Mark Proxy Authorization header as a request header, so it actually gets sent.
2007-06-01 12:40:22 +02:00
76507d475b
wininet: Don't close the connection if the caller passes in zero for the number of bytes to be read.
...
Only close the connection when the bytes read equals the content length.
Fixup HTTP_DrainContent, which relied on the previous incorrect
behaviour to instead close connections with no content length manually.
2007-05-29 13:49:02 +02:00
2e21d090cb
wininet: Cope with non-nul-terminated header strings being passed to HttpSendRequestW.
2007-05-29 13:44:36 +02:00
4d1b8b1a4e
wininet: Fix basic authentication by putting Basic directing into the scheme field, as the pszAuthValue can have an optional realm string appended.
2007-05-29 13:44:35 +02:00
8ee390f6f5
wininet: Exclude unused headers.
2007-05-29 12:10:17 +02:00
7b94871c9f
wininet: Pass context to InitializeSecurityContext in second parameter.
...
Otherwise, the call will now fail with SEC_E_INVALID_HANDLE.
2007-05-29 11:54:42 +02:00
847cc51d3b
wininet: Implement basic non-proxy authentication.
2007-05-21 16:52:21 +02:00
4b507685e8
wininet: Add support for SSPI authentication for HTTP.
2007-05-21 16:52:10 +02:00
46fc9c2e11
wininet: Constify some variables.
2007-02-26 13:38:37 +01:00
2024f68753
wininet: Skip empty accept type strings in HttpOpenRequest.
2007-02-13 11:50:01 +01:00
aab5e5856e
Don't put single quotes around '%s' when using the debugstr_*() functions.
2007-01-18 12:55:50 +01:00
1ec14b0b25
wininet: Fix HTTP_EncodeBasicAuth by passing an out buffer to the second set of character set conversion calls.
2007-01-17 11:24:09 +01:00
a9ebc706e3
wininet: Change HTTP_EncodeBase64 to operate on a series of bytes, instead of text.
...
Change HTTP_EncodeBasicAuth to convert the username and password into
utf8 before base64 encoding.
2007-01-15 12:31:11 +01:00
9efe083ec5
wininet: HTTP_HttpQueryInfoW deals with bytes, not characters so update the callers that have this wrong assumption.
2007-01-15 12:30:53 +01:00
7b002a39b8
wininet: Allow a NULL value to be passed into HTTP_ProcessHeader
...
instead of crashing so that when used with the replace flag it will
delete an existing value.
2007-01-15 12:30:46 +01:00
e66d1cd5e9
wininet: Consistenly use INTERNET_SetLastError().
2007-01-10 11:58:47 +01:00
47a8b86b53
wininet: Use Keep-Alive for HTTP requests if specified by the flags passed into HttpOpenRequest.
2007-01-08 12:39:50 +01:00
a9c2cfa8d9
wininet: Fix the handling of Accept types passed into HttpOpenRequest
...
by properly coalescing all the types into the Accept header value,
rather than just adding the first.
2007-01-08 12:39:47 +01:00
7e8ef764b8
wininet: Rename HTTP_Base64 to HTTP_EncodeBase64 to more accurately reflect what it does.
2007-01-08 12:39:42 +01:00
06b19b018a
wininet: Fix the releasing of the wrong reference count in HTTP_CloseHTTPRequestHandle.
...
lpwhr obviously already has a reference count of 0 because it is being destroyed.
2007-01-04 21:17:53 +01:00
272954bd81
wininet: Change the HTTP code to not assume that the connection will be closed at the end of every request.
2007-01-04 21:17:34 +01:00
f0163ae7d6
wininet: Don't send callbacks in HTTP_CloseConnection if not connected.
2007-01-04 21:17:19 +01:00
ac1b527498
wininet: Use the Content-Length header to work out how much HTTP data there is left to be read
...
and don't try to read any more than what is available.
2007-01-04 21:17:12 +01:00
cf43b16036
wininet: Always send a Connection header set to "close" because that is what we expect for the moment.
2007-01-04 21:16:38 +01:00
14fb418942
wininet: Fix HTTP redirects by reseting loop_next after one loop.
2007-01-04 21:14:54 +01:00
49f5ee746c
wininet: Get rid of ASYNC_FUNC enum.
2006-12-26 12:50:19 +01:00
c156845560
wininet: Use proc instead of enum in HTTPSENDREQUESTW request.
2006-12-26 12:48:09 +01:00
72575a06ca
wininet: Make a function for resolving the server name for an HTTP request
...
and sending the appropriate callbacks and use it to remove some duplicated code.
2006-12-07 11:42:51 +01:00
4319ec6b83
wininet: Make HTTP_HandleRedirect no longer call HTTP_HttpSendRequestW.
...
Make the redirect handling in HTTP_HttpSendRequestW iterate instead of recurse.
2006-12-07 11:42:38 +01:00
1031c5f9c6
wininet: Revert commit 760043c245.
...
After more testing I've checked that current code is bad, but my patch
was also wrong and causes regression in WoW.
2006-11-02 21:01:05 +01:00
5c53baac8d
wininet: Inherit INET_CALLBACKW from parent handler.
2006-10-31 11:46:49 +01:00
760043c245
wininet: Call SendCallback in destructor instead of InternetCloseHandle.
2006-10-30 11:36:16 +01:00
957516f8e6
wininet: Remove lpwhparent from WININETHANDLERHEADER.
2006-10-30 11:36:02 +01:00
61a1cef6f6
wininet: Use lpHttpSession instead of lpwhcalback where possible.
2006-10-30 11:34:58 +01:00
a9bdc01e19
wininet: Store pointer to WININETHTTPSESSIONW in WININETHTTPREQUESTW.
2006-10-30 11:34:51 +01:00
a541a44f51
wininet: Use lpAppInfo instead of lpwhparent where possible.
2006-10-30 11:34:41 +01:00
c250617d88
wininet: Store WININETAPPINFOW pointer in WININETHTTPSESSIONW.
2006-10-30 11:34:21 +01:00
cc7a86ec7e
wininet: Use HTTP_ADDHDR_FLAG_REPLACE flag in HTTP_HttpSendRequest to add Content-Length header.
2006-10-23 12:28:58 +02:00
Marcus Meissner