d528e76076
riched20: Use the point from char helpers to calculate the selection rectangle.
2013-02-14 17:35:20 +01:00
2a6f99efcc
riched20: The string len parameter is no longer necessary.
2013-02-14 17:35:06 +01:00
42b0c6ea33
riched20: Make it possible to perform point -> char conversion while holding a context.
2013-02-14 17:35:03 +01:00
530c546a3f
riched20: Remove the special case tab handling now that we handle that in draw_space.
2013-02-14 17:35:00 +01:00
4cbe94f42a
riched20: Move the white space painting operations to a common function.
2013-02-14 17:34:57 +01:00
4178de89ef
riched20: Move text color determination to a helper function.
2013-02-14 17:34:48 +01:00
681a9e1de6
riched20: Move y offset calculation to a helper function.
2013-02-14 17:34:41 +01:00
c2c5121d19
riched20: Move underline pen creation to a helper function.
2013-02-14 17:34:31 +01:00
82c8e567fb
riched20: Pass the run to the text drawing routine.
2013-02-14 17:34:23 +01:00
941775e311
riched20: The run width is always passed so we don't need to calculate it again.
2013-02-14 17:34:13 +01:00
c07212b3d0
riched20: Move run extent calculation to wrap.c.
2013-02-12 19:56:41 +01:00
9e8a9f4f65
riched20: Move the split point calculation to wrap.c.
2013-02-08 19:31:09 +01:00
68d72f4792
riched20: Move SplitRun to wrap.c and make it static.
2013-02-07 15:51:11 +01:00
6c1b292f0b
riched20: Let C look like C.
2013-02-07 12:04:01 +01:00
5168d66be7
riched20: Move the text to the paragraph level.
2013-02-05 20:15:37 +01:00
b730efc9b4
riched20: Pass character ptrs to the whitespace finding functions.
2013-02-05 20:15:37 +01:00
872a2ad031
riched20: Pass a character ptr and length to SplitParagraph.
2013-02-05 20:15:36 +01:00
48b9ab37ac
riched20: Pass the character ptr and string length directly to the break proc helper.
2013-02-05 10:51:26 +01:00
bf6bb4fc70
riched20: Actually pass the ANSI string to the break proc.
2013-02-05 10:51:15 +01:00
86f077b163
riched20: Add an explicit run length member and use it rather than accessing the string length.
2013-01-31 16:32:12 +01:00
f24ba125f6
riched20: Use the get_text helper in a few more places.
2013-01-31 16:32:07 +01:00
76cfe7dc50
riched20: Rewrite the run whitespace test to take a run parameter.
2013-01-31 16:32:01 +01:00
29e54f07f7
riched20: Rewrite the run splittable test to take a run parameter.
2013-01-31 16:31:52 +01:00
27578f8bb6
riched20: Add a helper to retrieve the run text.
2013-01-30 17:19:31 +01:00
c17af77b5c
riched20: Add a helper to debug the run text.
2013-01-30 17:19:28 +01:00
95938b7a10
riched20: Add a paragraph ptr to each run.
2013-01-30 17:19:22 +01:00
dee40e90ce
riched20: Move undo handling to a different set of structs as the display item structs are not a good fit.
2013-01-29 17:50:17 +01:00
ca46d22bca
riched20: Simplify adding the undo items when joining paragraphs.
2013-01-25 17:30:42 +01:00
7a27ffb28c
riched20: Avoid an unnecessary string duplication.
2013-01-22 19:13:07 +01:00
368f9123c9
riched20: Flush the output buffer before a codepage change.
2012-12-05 20:23:51 +01:00
87cdc7341d
riched20/tests: Remove a superfluous function pointer cast.
2012-11-30 19:12:16 +01:00
34f74fdc71
riched20: Remove duplicate operand in expression (coverity).
2012-11-05 11:11:53 +01:00
709a0b764d
Use the CP_ACP and NULL macros instead of numeric literals when converting strings between ANSI and Unicode.
2012-09-24 22:27:28 +02:00
28821a924c
riched20/tests: Use proper method macros.
2012-08-24 11:32:59 +02:00
3a2de10a9c
riched20: Fixed pointer to value out of scope (Coverity).
2012-08-20 10:57:08 +02:00
cb8c500ee6
riched20: Added support for UTF8 BOM stream.
2012-08-17 13:58:11 +02:00
7839d134e9
riched20/tests: Fixed typo in test_EM_STREAMIN.
2012-08-16 13:46:20 +02:00
01ebba0fc4
riched20/tests: Added UTF8 BOM test.
2012-08-16 13:07:02 +02:00
c0cfc9a87a
riched20: Avoid a TRUE:FALSE conditional expression.
2012-08-15 12:12:51 +02:00
e3f0d40840
riched20: Use proper interface methods macros.
2012-08-13 11:48:23 +02:00
a59e766ea7
riched20: Accept middle click as paste (like edit control does).
2012-06-19 11:09:49 +02:00
8660d5e77f
riched20/tests: Check the correct return value.
2012-05-25 13:45:01 +02:00
10d800b6b8
richedit: Invalidate a range of paragraphs without marking them.
2012-05-18 18:10:27 +02:00
306b3510a9
riched20/tests: Remove duplicated ok() call.
2012-05-17 10:18:15 +02:00
2ebfd01b51
richedit: Remove some unused structure fields.
2012-05-14 12:04:24 +02:00
4996043374
riched20: Don't need to redraw when changing selection from none to none.
2012-05-10 08:30:58 +02:00
1f8cbe1645
richedit: Avoid scanning all text for paragraphs to invalidate.
2012-05-09 11:55:58 +02:00
18fa3287f6
richedit: Remove always FALSE parameter from ME_PaintContent.
2012-05-08 09:42:16 +02:00
25ed3b9572
riched20/tests: Don't cast NULL to an integer.
2012-04-16 12:07:11 +02:00
39f416cd9d
riched20/tests: Add COM aggregation tests for CreateTextServices().
2012-03-28 11:39:12 +02:00
67389533bc
riched20/tests: Get the CreateTextServices() pointer only once.
2012-03-28 11:39:04 +02:00
74c5d202a1
riched20: Support COM aggregation in CreateTextServices().
2012-03-28 11:38:59 +02:00
6f299c5d76
riched20: Avoid a forward declaration of a vtbl.
2012-03-28 11:38:44 +02:00
51998b929a
riched20: Drop the WINE_ prefix from a FIXME.
2012-03-12 10:11:16 +01:00
e2264859c8
riched20: Fix some GDI object leaks.
2012-01-30 11:54:47 +01:00
efbde389c7
richedit: v1.0 richedit uses CR and LF for enter.
2012-01-23 16:07:41 +01:00
8dd66bc927
riched20: Avoid hardcoding the Unicode string literal lengths.
2011-12-16 17:40:38 +01:00
5e0050d001
riched20: Do not return incorrect values from ME_CharFromPoint[Cursor].
2011-10-24 20:27:30 +02:00
3ac36cb50f
riched20/tests: Test format rect adaption to window size and behavior with zero-sized windows.
2011-10-24 19:54:08 +02:00
791d000f96
riched20: Simplify ME_PrepareParagraphForWrapping.
2011-10-24 19:54:02 +02:00
f3a3ce8a51
riched20: Avoid a forward declaration.
2011-10-24 19:37:08 +02:00
28cb0b683e
riched20: Constify some ME_Context pointer parameters.
2011-10-24 19:37:08 +02:00
3de330db54
tests: Remove unneeded assert.h includes.
2011-09-27 10:59:56 +02:00
9d2da7fa66
riched20/tests: Remove unnecessary SetFocus calls.
2011-09-26 12:19:43 +02:00
fdb2bc4be9
riched20/tests: Avoid using flaky method of simulating typing.
2011-09-26 12:19:40 +02:00
f61d417a34
richedit: Return number of chars inserted for EM_STREAMIN with SF_RTF.
2011-09-26 12:16:59 +02:00
e060272de7
richedit: Return number of bytes read for EM_STREAMIN with SF_TEXT.
2011-09-26 12:16:56 +02:00
c992ca277d
Assorted spelling fixes.
2011-08-24 19:07:46 +02:00
73876d6ccd
riched20: Fix uninitialized variable usage.
2011-08-22 17:15:02 +02:00
7e309601f3
dlls: Assorted spelling fixes.
2011-08-03 14:15:50 +02:00
28b2d03a8c
riched20/tests: Fix test_EM_FINDWORDBREAK comments.
2011-08-01 18:26:25 +02:00
faa05713ad
riched20: Declare some variables unsigned.
2011-08-01 11:16:56 +02:00
dafd6fecd1
riched20/tests: Add test for WB_ISDELIMITER.
2011-07-20 19:23:05 +02:00
7ed4f20305
riched20: Remove dead assignment (Clang).
2011-07-06 11:29:18 +02:00
82da77c0a6
richedit: Fix incorrect GUID values for ITextHost and ITextHost2.
2011-07-05 14:44:43 +02:00
819e1a899a
riched20/tests: Test the text services IIDs.
2011-07-05 14:44:33 +02:00
598a7f6edf
riched20: Mark internal symbols with hidden visibility.
2011-05-24 11:55:55 +02:00
3f2f2eb678
riched20: Finish the COM cleanup in richole.c.
2011-05-19 10:09:30 +02:00
b1ae962997
riched20: COM cleanup for the IOleClientSite iface.
2011-05-19 10:09:22 +02:00
a12ed578c5
riched20: COM cleanup for the ITextSelection iface.
2011-05-17 13:45:02 +02:00
2b53df89cb
riched20: Fixed some lParams with keycodes (Coverity).
2011-05-06 14:23:46 +02:00
0cd53a589d
riched20: Use correct flag name (Coverity).
2011-05-06 14:23:46 +02:00
2ae0d40c8f
riched20: Adjusted shift by 8 bits to 16 bits (Coverity).
2011-05-06 14:23:45 +02:00
c52c15ef99
riched20: COM cleanup for the ITextServices iface.
2011-04-11 12:10:30 +02:00
e18ae2139b
riched20: COM cleanup for the ITextHost iface.
2011-04-11 12:10:20 +02:00
cc2cd5a525
riched20/tests: Add a '\n' to an ok() call.
2011-03-07 11:09:27 +01:00
c17df92e5d
riched20/tests: Remove win9x hacks.
2011-02-28 13:13:33 +01:00
4b7795a943
riched20: Add a missing break.
2011-02-23 19:23:38 +01:00
f8da57ca89
riched20: Fix a c89 conformance issue in ITextImpl->editor->rcFormat initialization.
2011-02-16 14:02:59 +01:00
1e758c5e8c
riched20: Do not call callback when no data needs to be flushed.
2011-02-09 13:49:03 -06:00
75e4e607c6
riched20/tests: Make sure return value is used (LLVM/Clang).
2011-02-09 09:25:58 -06:00
997a681300
riched20/tests: Fix editor tests.
2011-01-24 14:43:27 +01:00
bee48efdce
riched20/tests: Skip some tests on non-English platforms.
2011-01-19 16:54:02 +01:00
d43cddcc83
richedit: Clear non-default style when changing to plain text mode.
...
Although the text must be empty for the mode to change to plain text
mode, there still may be a non-default style for the temporary insert
style and style for the end of text run.
2011-01-12 11:32:19 +01:00
cea221caa0
riched20/tests: Don't test function directly when reporting GetLastError().
2010-12-30 15:00:58 +01:00
9a6f5ad239
riched20: Standardize the COM usage in clipboard.c.
2010-12-09 12:28:52 +01:00
0acf4a297b
riched20/tests: Use an iface instead of a vtbl pointer in ITextHostTestImpl.
2010-12-09 12:28:41 +01:00
954558806e
riched20: Use the correct resource id for the reverse arrow cursor.
2010-10-18 19:08:37 +02:00
b20e75f5e9
riched20/tests: Cleaned up ITextServices::TxGetNaturalSize test and fixed test failures.
2010-10-13 17:45:23 +02:00
d08fc66732
riched20/tests: Plug a few memory leaks and make failure messages more meaningful.
2010-10-06 20:46:49 +02:00
95c1bd4da9
riched20/tests: Make some variables static.
2010-10-01 13:40:29 +02:00
81b8ee863e
makefiles: Add a standard header for all makefiles to replace the common variable initializations.
2010-09-19 12:36:48 +02:00
c0ee555e8f
richedit: Avoid redundant calls to ME_CalcRunExtent.
...
ME_SplitRun is only called by wrapping code. In all but one call the
returned second half of the split run will be returned, get passed back
to ME_WrapHandleRun, then ME_CalcRunExtent will be called at the start of
ME_WrapHandleRun through ME_WrapSizeRun.
2010-07-30 11:36:02 +02:00
8b8e4f89b2
richedit: Use ME_Cursor as parameter to ME_SplitRunSimple.
...
The paragraph needed to be included in the parameters to avoid needing
traverse the linked list of display items to find the paragraph.
2010-07-30 11:36:02 +02:00
68b44f740c
richedit: Remove checks for converting internal CHARFORMAT structs.
...
Prevents extra copying from having to be done for converting between
unicode/ascii or between the normal or extended version of the structure.
2010-07-30 11:36:02 +02:00
ad056fe7d7
richedit: Check for bits instead of equality in EM_SETCHARFORMAT.
...
There are unsupported flags documented on MSDN which would cause problems
for the equality checks used in EM_SETCHARFORMAT. Also, to handle a
combined set of flags they must be checked for in the right order.
2010-07-30 11:36:01 +02:00
16d7890426
richedit: Don't change text mode with undo or redo stack.
2010-07-30 11:36:01 +02:00
75eef41881
richedit: Return correct values when EM_SETTEXTMODE fails.
...
The checks for the text length and invalid parameters needed to be swapped,
and the code could be easily simplified.
2010-07-30 11:36:01 +02:00
4c174fc845
richedit: Removed unused run flags values.
...
The only place MERF_SKIPPED was in debug code, and MERF_CALCBYWRAP was only
used to clear this unused flag value, so I got rid of both of them.
2010-07-29 10:28:29 +02:00
15251ad84b
richedit: Removed redundant variable ptLastSplittableRun.
2010-07-29 10:28:06 +02:00
dfa80b35b0
richedit: Invalidate without calling UpdateWindow in many cases.
2010-07-29 10:28:00 +02:00
1964e603fd
richedit: Remove redundant commit and repaint in ME_StreamInText.
...
ME_StreamInText is only used in one function, ME_StreamIn, which always
calls ME_CommitUndo and ME_UpdateRepaint after calling this function.
2010-07-29 10:27:38 +02:00
328a3f1d8c
richedit: EN_UPDATE notification is sent on WM_PAINT.
2010-07-29 10:27:30 +02:00
b86d515ed6
dlls: Remove explicit imports of kernel32 and ntdll.
2010-07-21 17:38:36 +02:00
be3073fce1
richedit: Fix streaming rtf with table at the start of the text.
...
The first paragraph was being handled just by ME_StreamOutParaProps,
but subsequent paragraphs would check if the paragraph was starting or
ending a table. So I moved the code to check for tables into
ME_StreamOutParaProps.
2010-07-19 14:38:16 +02:00
e2f6b1d83d
richedit: Don't break when streaming out a table, just continue.
...
This is a regression caused by commit
54b53b6018
2010-07-19 14:38:16 +02:00
61e5fec020
riched20: Process messages which arrive before WM_NCCREATE.
2010-07-08 17:33:25 +02:00
6072a69d38
richedit: Keep default char format on WM_SETFONT in plain text mode.
2010-06-07 15:27:52 +02:00
b88b007d95
richedit: Fix assignment to wrong variable (LLVM/Clang).
2010-05-25 12:02:28 +02:00
3f1d3e0ea1
richedit: Simplify redundant code in WM_IME_COMPOSITION.
2010-05-24 11:30:23 +02:00
e809bc887d
richedit: Commit undo items after modifications in WM_IME_COMPOSITION.
...
ME_InsertTextFromCursor could previously follow the ME_CommitUndo call
leaving uncommitted changes which would cause improper grouping of commits,
or an assertion failure.
2010-05-24 11:30:12 +02:00
fb7d6b783e
richedit: Missing HeapFree in WM_IME_COMPOSITION. (Smatch).
...
ME_InsertTextFromCursor copies the string passed into it rather than making
taking ownership of it.
2010-05-24 11:30:06 +02:00
dcbc22b985
richedit: Send EN_SELCHANGE after wrapping but before EN_CHANGE.
...
The call to ME_SendSelChange cannot be done in ME_CommitUndo like it was
before, because it must be done after wrapping. Native richedit controls
send EN_CHANGE first, which is sent in ME_UpdateRepaint, so
ME_SendSelChange must be before this notification in ME_UpdateRepaint.
2010-05-19 11:17:55 +02:00
d312d4e33c
richedit: Revert commit that caused a regression. (Bug 22758).
...
Revert commit 049cf5aca0
2010-05-19 11:17:55 +02:00
cf13e8a390
riched20: Avoid using long.
2010-05-17 12:42:33 +02:00
f772c799ae
riched20: Remove variables yprev and ys which are not really used from ME_ArrowPageUp.
2010-05-17 12:42:31 +02:00
049cf5aca0
richedit: Avoid notifying parent window in improper state.
...
ME_CommitUndo and ME_CommitCoalescingUndo call ME_SendSelChange, which
may notify the parent window that the selection has changed, therefore
should generally be called after wrapping the text. Otherwise, the parent
window may send a message to the editor and cause an assertion failure.
2010-05-17 12:42:31 +02:00
6dd4b071cc
riched20: Remove variable pCell which is not really used from ME_StreamIn.
2010-05-10 10:11:34 +02:00
2d462ad088
riched20: Remove variable ys which is not really used from ME_ArrowPageDown.
2010-05-10 10:11:29 +02:00
f29514fbec
riched20: Remove variable di which is not really used from ME_InsertEndRowFromCursor.
2010-05-03 15:42:18 +02:00
14ef0fed9c
riched20: Remove variable changed which is not really used from ME_PrepareParagraphForWrapping.
2010-05-03 15:40:04 +02:00
01777ac5ce
riched20: Remove variable yprev which is not really used from ME_ArrowPageDown.
2010-05-03 15:37:31 +02:00
bef5645eb1
makefiles: Remove the no longer needed explicit separators for dependencies.
2010-03-16 13:28:19 +01:00
534398a57e
richedit: GTL_PRECISE to GETTEXTLENGTHEX implies GTL_NUMBYTES.
...
If GTL_PRECISE is passed without specifying either GTL_NUMCHARS or
GTL_NUMBYTES, behave as if GTL_NUMBYTES was passed.
2010-03-01 11:33:01 +01:00
7ed13120ab
richedit: Make zooming affect all pictures.
2010-03-01 11:32:33 +01:00
1f2575ba7c
richedit: Documented paragraph border widths are in points not pixels.
...
The border widths documented by msdn are in points which are 72 dpi, which
is not equivalent to pixels (normally 96 dpi). I pre-converted all the
border widths to 96 dpi resolution since this avoids needed to store
fractions, and often avoids the need for convertion to the displays
resolution.
2010-03-01 11:32:18 +01:00
fe9933ae4d
richedit: Added some extra tests for EM_FORMATRANGE.
...
The existing tests were not properly testing the return value for the case
where all the text fits in the page rect, so this patch adds a couple of
simple tests for this case.
2010-02-22 12:03:09 +01:00
6164ce2d82
makefiles: Use the standard C_SRCS variable as the list of test files.
...
This enables it to be auto-updated by make_makefiles.
2010-02-22 10:47:11 +01:00
9106860c85
richedit: Prevent crash on word selection at end of paragraph.
2010-02-18 12:18:17 +01:00
535afbd3aa
richedit: Move function ME_GetParaLineSpace to make it static.
2010-02-10 11:32:31 +01:00
e9693d6272
richedit: Removed unused local variable yStart.
2010-02-05 10:06:30 +01:00
fc3e2ba954
riched20: Don't print the function name twice in ERR/WARN.
...
The ERR/WARN macros already print the function name.
2010-02-04 13:39:28 +01:00
0539d5e497
richedit: Initialize fields for windowless richedit controls.
...
Caught by valgrind.
2010-01-25 13:01:17 +01:00
530a6c4598
richedit: Prevent uninitialized value from being used.
...
NULL may be returned by ITextHost::TxGetDC. Caught by valgrind.
2010-01-25 13:01:05 +01:00
d3bc43b5ed
Grammar fixes "is doesn't" => "doesn't".
2010-01-11 11:33:59 -06:00
3b45ababfb
riched20: Remove some explicit LPARAM/WPARAM casts.
2009-12-28 12:27:13 +01:00
8808fccd57
riched20: Initialise window size.
...
Found by Valgrind.
2009-12-16 12:42:40 +01:00
d4383b4498
riched20: Initialise the style flags.
...
Found by Valgrind.
2009-12-15 16:09:12 +01:00
d88c47fccb
riched20: Fix a memory leak.
...
Found by Valgrind.
2009-12-14 12:04:05 +01:00
c848e4ee86
riched20: Check for NULL in rtf reader (Coverity).
2009-12-03 10:21:44 +01:00
Huw Davies