f9768f4792
Fixed font object leak in WM_SETFONT handler.
2002-10-29 21:28:37 +00:00
02af550a2a
Send the right notification code (A/W) depending on the Unicode
...
setting.
2002-10-29 21:25:35 +00:00
26a470e1f0
set_main_item: ignore meaningless bits in stateMask for LVS_OWNERDATA
...
instead of failing.
2002-10-28 21:21:42 +00:00
2d2e6acbbd
We should always have a main item in report mode.
2002-10-28 20:40:21 +00:00
7e12841030
Properly fill lParam in NMLISTVIEW.
2002-10-28 20:38:39 +00:00
173d40a493
Fix crash-inducing typo/thinko.
2002-10-28 20:38:03 +00:00
5574e750c5
Mark immutable objects as const. Fix inconsistent *-style.
2002-10-28 20:37:28 +00:00
f5221578f6
Add LVHITTESTINFO debug helper. More tracing.
2002-10-28 20:36:52 +00:00
17b97eb929
Despite what the docs say, we have to invalidate the list on
...
WM_SETREDRAW(TRUE).
2002-10-28 20:36:16 +00:00
ccc8f7dca9
Eliminate flicker when resizing, docs updates.
2002-10-28 20:35:44 +00:00
19a1c42386
Cleanup, and simplification of UpdateSize.
2002-10-28 20:35:09 +00:00
9a9fcab763
Handle focus item properly in SetItemCount.
2002-10-28 20:34:34 +00:00
f9e70d8b81
Remove only the necessary selections when setting the item count.
2002-10-28 20:34:00 +00:00
28a2f193a3
Rewrite of the SetItemCount: bugs got squashed,
...
LVSICF_{NOSCROLL,NOINVALIDATEALL} implemented.
2002-10-28 20:33:18 +00:00
5803819971
lParam was not properly sent in TTM_ADDTOOLW.
2002-10-28 18:50:36 +00:00
392defd3ef
lParam was not properly sent in CBEN_GETDISPINFOW.
2002-10-28 18:50:14 +00:00
6e256c72fe
- fix some pselling
...
- enhance some TRACEs
2002-10-25 19:09:02 +00:00
5a11b009f1
Do not invalidate list on WM_SETREDRAW.
...
Update size info even if redrawing is disabled.
Trivial cleanups, and some tracing.
2002-10-25 03:21:25 +00:00
221398344e
We can avoid flicker on column resize only if it's left align.
2002-10-25 03:20:43 +00:00
fa5b29acd3
Always draw the main item in full row select.
2002-10-25 03:20:03 +00:00
f7441d00ed
Use iterators to render over the columns, in report mode.
2002-10-25 03:19:24 +00:00
863d6a87f5
Small iterator-over-range[s] cleanup.
2002-10-25 03:18:47 +00:00
83679e6b88
Eliminate most of the flicker when resizing columns.
...
More debug tracing.
2002-10-25 03:18:07 +00:00
ab97b86902
Fix subitem background color in full row select.
2002-10-25 03:17:36 +00:00
b14c82a8b8
We should callback for inexistent subitems.
...
Do not store callback items for subitems, even if we're asked to.
Small cleanup.
2002-10-25 03:17:04 +00:00
16db256923
Fix crash when computing the item width of a report with no columns.
...
Override custom draw bkgnd color for selection items.
Fill background for all items that have a bkgnd colour.
2002-10-25 03:16:26 +00:00
3520c83275
Keep autoarranging items until one is moved.
2002-10-25 03:15:51 +00:00
01e82f2b27
Abstract autoarranging decision to a helper function.
2002-10-25 03:15:18 +00:00
5b8361463d
Do not do screen work if refreshing is disabled.
...
Reimplement SetRedraw to cope with the changes.
2002-10-25 03:14:44 +00:00
c4e45d7f94
Rewrite the UpdateScroll function: simpler, faster.
...
Add debugging helper for SCROLLINFO.
Fix potential bug in debugging helpers.
2002-10-25 03:14:06 +00:00
89ab25a737
Avoid division by 0 by initializing the item size in on creation.
...
Rename update_icon_size to set_icon_size, fix parameters order.
Assorted cleanups.
2002-10-23 23:32:50 +00:00
5ffde298fe
Append to the end of the DPA, if insert index is too large.
2002-10-23 23:32:19 +00:00
9fa51e4172
Fixed duplicated arrows in header control.
2002-10-23 23:31:35 +00:00
b894605987
Fix thinko that slipped in with the prev patch (reenables refresh).
...
Mark a few things that needs looking at.
Small cleanup.
2002-10-23 22:32:25 +00:00
9cdcd44eaa
Do not invalidate the window before the first paint job.
...
Assorted cleanups.
2002-10-23 22:31:47 +00:00
f7051c88ae
Use InvalidateItem instead of explicit InvalidateRect, it is cleaner,
...
and faster when redraw is disabled.
2002-10-23 22:31:13 +00:00
c093196c05
Transform the invalidation macros to proper functions.
2002-10-23 22:30:39 +00:00
bf46fab650
Delay some size computations until after first paint.
2002-10-23 22:29:47 +00:00
7d9b04dbe2
Reorganize the item size calculation (a bit simpler, and faster).
2002-10-23 22:28:44 +00:00
1fd077939f
Search through all items when LISTVIEW_FindItemW is called with
...
LVFI_PARAM flag.
2002-10-23 22:28:03 +00:00
bf761a331c
Delete the items if we actually own them.
2002-10-23 22:25:42 +00:00
8f15b6e6b3
Do not callback to the parent for lParam when in LVS_OWNERDATA.
...
Docs update.
2002-10-23 22:25:10 +00:00
353529b2c8
- fix the "int format, HANDLE arg" type of warnings for comctl32
...
- compile the comctl32 dll with -DSTRICT
2002-10-23 22:19:10 +00:00
85e40cf37a
Add casts to compile with -DSTRICT.
2002-10-23 20:58:33 +00:00
5acd96bb4e
Do not crash if callback text is not filled (behave like native).
...
Render report mode from top to bottom (easier on the eye).
Docs updates, type fixes, more traces.
2002-10-23 20:57:13 +00:00
6608328f76
Collect all bugs, missing features, etc in the header doc.
...
Minor cleanups.
2002-10-23 20:56:30 +00:00
9ff0da09ff
Do not autoarrange if we insert/delete from the end of the list.
2002-10-23 20:55:05 +00:00
c5da549d10
Rework SetItemPosition, bunch of bugs squashed in the process.
...
Complete icon alignment rewrite: cleaner, incremental, etc.
Completely avoid aligning all icons on every insert
- icon placement is incrementally computed now: it's fast.
Small cleanups, docs update, etc.
2002-10-23 20:54:23 +00:00
c5e2731939
Rename LISTVIEW_ITEM to ITEM_INFO for consistency.
...
Rename LISTVIEW_SUBITEM to SUBITEM_INFO for same reason.
Fix type in comment spotted by Bobby Bingham.
2002-10-23 20:53:42 +00:00
cf07e10017
Don't use wine/unicode.h in the header files, include it directly
...
where needed instead.
2002-10-23 20:20:59 +00:00
f3d1893f80
Add needed casts for a "no warnings" compile of comctl32.
2002-10-23 20:19:22 +00:00
513eb2a24a
Collect all bugs, missing features, etc in the header doc.
2002-10-23 18:43:32 +00:00
d664540782
Bring header's height more inline with native's.
2002-10-22 00:41:45 +00:00
254e7484fa
DPAs can't have more than 0x8000 elements (fixed with lots of help
...
from Carlos <clozano@andago.com).
2002-10-21 19:54:06 +00:00
c7fbc1b2c9
No need to increment item size, it's already adjusted by DPA_SetPtr
...
(found, and fixed by Carlos <clozano@andago.com>).
2002-10-21 19:49:44 +00:00
6168b98176
Do not rely on HeapReAlloc to allocate a NULL pointer.
2002-10-21 19:49:12 +00:00
7888385d76
Rewrite DPA_InsertPtr in terms on DPA_SetPtr, so that it's simpler,
...
cleaner, and more correct.
It now expands the array to accomodate larger than current size
indexes.
2002-10-21 19:48:37 +00:00
a87b685350
Do not send uninitialized lParams on notification msgs (found by Rein
...
Klazes <rklazes@xs4all.nl>).
2002-10-21 19:46:46 +00:00
6deae0b86d
Complete rewrite of the rcView implementation.
...
Lots of bugs fixed in rcView computation.
Assorted cleanups, and simplifications.
2002-10-21 19:46:08 +00:00
c9e0133357
Split ranges_destroy in ranges_clear, and ranges_destroy.
...
Rewrite DeleteAllItems, for cleaner, faster, more correct code.
2002-10-21 19:45:29 +00:00
62f4c61d22
Updated header documentation to the latest, and greatest.
2002-10-21 19:44:51 +00:00
06701fb09e
Optimize invalidation on insert.
...
Share the invalidation code between {Delete,Insert}Item.
2002-10-21 19:44:18 +00:00
f18e271bff
Rewrite DeleteItemT: cleaner, a lot faster.
...
Number of bug were fixed.
The minimum possible is redrawn.
2002-10-21 19:43:37 +00:00
c859242ac8
Implement most of LVM_ARRANGE.
...
Make use of it, where it was appropriate.
Use infoPtr->dwStyle directly, in most places.
Assorted cleanups.
2002-10-21 19:43:03 +00:00
56c17651a0
Proper (type wise) return types.
2002-10-21 19:42:30 +00:00
214c721160
Reorganize header notifications.
...
Support notifications that don't have embedded size info.
Invalidate columns on format change (if needed).
Assorted cleanups.
2002-10-21 19:41:56 +00:00
713d0a061f
Crash on internal NULL pointers, don't test all over the place.
2002-10-21 19:41:00 +00:00
e37692bd33
When removing focus, no need to go through all elements.
2002-10-21 19:40:26 +00:00
feb326118f
Fix colors for selected items in full row select mode.
...
Fix bug caused by use of uninitialized state.
2002-10-21 19:39:45 +00:00
7c26e53ac0
Fix computation of subitem box, when invalidating it.
2002-10-21 19:34:38 +00:00
2223014df3
Assert on inconsistent range list states.
...
Various code cleanups, few potential bugs fixed.
2002-10-21 19:33:59 +00:00
074e2b4caa
Do not grow the item list to arbritary index: if requested index is
...
larger than current count, just append.
Miscellaneous cleanups.
2002-10-21 19:33:14 +00:00
be0641face
SetColumnWidth rewrite: simpler, cleaner code. Bugs squashed.
2002-10-21 19:32:38 +00:00
bf965278b5
Handle generic column width changes.
...
Fix bug in SetColumnT which rendered it unusable.
Column code cleanup.
2002-10-21 19:32:07 +00:00
0acaf0e961
Assert on internal invariants, rather than fail gracefully.
2002-10-21 19:31:34 +00:00
88c26b9c01
More docs compliant alignment handling for subitems.
2002-10-21 19:31:01 +00:00
f8514f5b3c
Fix notification from header, on item changed.
...
Small indentation fixes.
2002-10-21 18:22:51 +00:00
d126f4768c
Correct the behavior for disabled toolbar buttons.
2002-10-21 18:19:02 +00:00
0def1dd4e4
Do not create a range list for an empty range.
2002-10-19 19:26:17 +00:00
0613b7212a
Store the entire format bitmap in the column info.
...
Rewrite GetColumnT to take advantage of that.
Related cleanups, and simplifications.
2002-10-19 19:25:41 +00:00
569de03864
Column zero has the image enabled always, irrespective of format.
2002-10-19 19:25:01 +00:00
231e9ef25b
Unify {Insert,Set}ColumnT as much as possible.
...
Fix a bunch of problems in SetColumnT.
2002-10-19 19:24:24 +00:00
3893cb7fb2
Fix function header documentation.
2002-10-19 19:23:31 +00:00
e877b77a9d
Better report mode.
...
Use the new column information to simplify, and speed up the code.
Enable support for images in subitems (in LVS_REPORT mode).
2002-10-19 19:20:35 +00:00
0dbab63fa6
When deleting an item, remove selection, don't add it!
2002-10-19 00:59:34 +00:00
0ba3dc7589
More traces to help us make sense of the output.
...
Faster, cleaner ranges_{add,del}.
2002-10-19 00:21:02 +00:00
c79eb2de5f
Fix ranges insertion bug (specify DPAS_SORTED when searching).
...
Add a lot of assert-ed consistency checks.
Add bunch of trace messages.
2002-10-19 00:20:21 +00:00
a2dd8ecc33
Inspect style bits independently on style change.
2002-10-19 00:19:28 +00:00
b50692ee82
Rewrite StyleChanged procedure
...
o some bugs have been fixed
o cleaner, simpler code
Fix some corner case, icon size computation bugs.
Assorted docs updates.
2002-10-19 00:18:48 +00:00
323f9c23f0
Keep track of per-column information inside the listview.
...
Cache header rectangles.
Used the cached info instead of calling to the header each time.
Update the listview as we track column width changes.
Unify column handling between {Insert,Delete}Column, and width
changes.
Simplify RefreshReport, by using the new column info.
2002-10-19 00:18:11 +00:00
a72e9f617e
Do not query items that are just being inserted.
2002-10-19 00:17:24 +00:00
f8f559fa3c
Reorganize things a bit so that we no longer need the 'valid' flag on
...
each item.
Small comments update.
2002-10-19 00:16:37 +00:00
23bb3715f7
Added support for building certain dlls with -DSTRICT.
...
Added -DWINE_NO_STRICT flag to dlls that don't support STRICT yet.
2002-10-18 23:46:28 +00:00
fe7d46a221
pszText is stored as Unicode, so call DrawTextW() instead of
...
DrawTextA().
2002-10-18 00:20:04 +00:00
c18c7332b8
Instrument SetItemT to change only _one_ item at a time. That is, if
...
we have to change focus, we call it recursively to first remove the
focus from the item that has it. This allows simpler, and more correct
invalidation handling.
2002-10-17 21:55:41 +00:00
8f38417376
Unify set_{owner,main}_item functions.
...
Fix {old,new}state and lParam reporting in LVN_ITEMCHANG{ING,ED}.
Fix sanity check conditions for LVS_OWNERDATA.
2002-10-17 21:54:57 +00:00
96dca36cc8
More, better tracing to help nail down some crashes.
...
Fix typo in GetItemT (found, and fixed by Huw Davies).
Exit right away from GetItemT if nothing is asked (mask == 0).
Assorted code cleanups.
2002-10-17 21:53:56 +00:00
305fb4c3dd
Deal with sparsely populated listviews.
...
Crash on internal corruption.
2002-10-17 21:38:21 +00:00
ef4a6fc7e5
Add ability to create an iterator over a range list.
...
Fix memory leak when destroying ranges.
Add function that will to a 'deep' clone of a range list.
Add function that will subtract a range list from another.
Do not crash on NULL ranges (similar in spirit to HDPAs).
Fancy deselection routines uses the above infrastructure to deselect
the minimum possible.
Modify SetGroupSelection to take advantage of all this new
infrastructure, to avoid flicker on selection extension.
2002-10-17 21:37:24 +00:00
fa81ec674b
Change the definition of ranges to exclude the upper bound.
2002-10-17 21:36:29 +00:00
Sander van Leeuwen