c32d9d7004
msi: Get rid of ACTION_VerifyFeatureForAction.
2010-02-16 12:29:01 +01:00
598c542607
msi: Get rid of ACTION_VerifyComponentForAction.
2010-02-16 12:28:56 +01:00
54391a11c0
msi: Update the UI when registering or unregistering type libraries.
2010-02-16 12:28:48 +01:00
438ad93b22
msi: Implement and test MsiGetPatchInfoA/W.
2010-02-15 16:36:39 +01:00
b4bdfe6746
msi: Add tests for creating and removing shortcuts.
2010-02-15 12:20:02 +01:00
2276c291fc
msi: Implement the RemoveShortcuts standard action.
2010-02-15 12:20:02 +01:00
983cff23fa
msi/tests: Fix a test failure on Win9x/WinMe.
2010-02-12 16:39:39 +01:00
f7879b43d5
msi: Fix a memory leak in ITERATE_StartService.
...
Found by Valgrind.
2010-02-12 14:49:38 +01:00
82d50fa675
msi: Return the right error from ITERATE_RegisterTypeLibraries.
2010-02-12 14:49:38 +01:00
98761037ab
msi: Implement the UnregisterTypeLibraries standard action.
2010-02-12 14:49:38 +01:00
bbfaf6af75
msi: Add tests for installing and removing ODBC drivers.
2010-02-11 14:38:45 +01:00
28bf8e1f0d
msi: Implement the RemoveODBC standard action.
2010-02-11 14:38:45 +01:00
2568e5ec65
msi: Make sure attrs variable is properly double nul-terminated in ITERATE_InstallODBCDataSource.
2010-02-11 14:38:45 +01:00
4742dfba98
msi: The File_Setup field in the ODBCDriver and ODBCTranslator tables is optional.
2010-02-11 14:38:45 +01:00
312e4f6b23
msi/tests: Run the 'in_use' tests again.
2010-02-10 17:31:28 +01:00
068cb1291b
msi: Add a partial implementation of the ValidateProductID standard action.
2010-02-10 14:31:49 +01:00
7331b3ca98
msi: Implement the UnregisterFonts standard action.
2010-02-10 14:31:15 +01:00
5df62d0c42
msi: Add stub implementations of the DisableRollback and InstallAdminPackage standard actions.
2010-02-10 14:31:05 +01:00
9644d1dcd7
makefiles: Generate a general catch-all dependency on .tab.h files to replace the manually maintained ones.
2010-02-08 20:58:00 +01:00
f5af1ca399
msi: Implement the SelfUnregModules standard action.
2010-02-05 15:33:11 +01:00
3864ddf9f2
msi: Implement the RemoveFolders standard action.
2010-02-05 15:33:05 +01:00
5c4a3bd61b
msi: Handle some error returns (Coverity).
2010-02-04 17:27:34 +01:00
9fab263d39
msi: Call Custom function via wrapper.
2010-02-04 14:06:34 +01:00
b9da31f112
msi: Implement the DeleteServices standard action.
2010-02-04 13:39:29 +01:00
3d38c07706
msi: Add tests for the _Streams table implementation.
2010-02-04 13:39:29 +01:00
19b50cff34
msi: Fix an off-by-one error in STREAMS_find_matching_rows.
2010-02-04 13:39:29 +01:00
95a21c27da
msi: Give the Name field from the _Streams table a valid type.
2010-02-04 13:39:29 +01:00
24dd10c6b0
msi: Make room for the new row in STREAMS_insert_row.
2010-02-04 13:39:28 +01:00
c1940c1c5f
msi: Allow overwriting an existing stream in STREAMS_set_row.
2010-02-04 13:39:28 +01:00
dcbe0fdff2
msi: Encode the stream name before trying to open it.
2010-02-04 13:39:28 +01:00
b833ae0263
msi: Improve error handling in STREAMS_set_row and add_streams_to_table.
2010-02-04 13:39:28 +01:00
5741df2e58
msi: Implement STREAMS_get_row.
2010-02-04 13:39:28 +01:00
74d6fe35a2
msi: Remove unused and redundant name field from STREAM structure.
2010-02-04 13:39:28 +01:00
aafcf1a536
msi: Remove function name from fixme.
2010-02-04 13:39:28 +01:00
643f55abab
msi: Don't print the function name twice in a WARN.
2010-02-04 13:39:28 +01:00
06e15ee9e6
msi: Copy InstallerImpl_LastErrorRecord to use it for DatabaseImpl.
2010-02-04 13:39:26 +01:00
9a0020ade9
msi: Move some helpers to the module where they are used.
2010-02-03 11:31:48 +01:00
29f47299c2
msi: Implement the ScheduleReboot standard action.
2010-02-03 11:31:48 +01:00
552a9c9b85
msi: Add a stub implementation of the SetODBCFolders standard action.
2010-02-03 11:31:48 +01:00
743ead45c8
msi: Test duplicating files from a nonexistent component.
2010-02-02 11:47:19 +01:00
3299bfd471
msi: Fix crash with access to component.
2010-02-02 11:47:19 +01:00
086711818b
msi/tests: Fix some test failures on Win9x up to W2K.
2010-02-02 11:47:19 +01:00
2197da7770
msi: Fix Italian translation.
2010-02-01 12:48:13 +01:00
246f9305e9
msi: Don't fail if the service to start is already running.
2010-02-01 12:11:18 +01:00
a0774cabab
msi: Avoid using HIWORD() on string pointers.
2010-01-29 17:25:49 +01:00
0ee3836844
msi: Add Ukrainian translations.
2010-01-29 13:30:04 +01:00
1d0db2b19b
msi: Don't create all directories in the CreateFolders action.
...
The CreatFolders action should create only the directories listed in the
CreateFolder table, the rest will be created during the InstallFiles action.
Fixes the EndNote 8 installer.
2010-01-28 15:30:26 +01:00
aa19638cb9
msi: Improve some traces.
2010-01-28 15:30:25 +01:00
7c9cb1e1be
msi: Name and arguments in the service control table are formatted strings.
2010-01-28 15:30:25 +01:00
4d14ea47f7
msi: Add a test for MsiSetTargetPath.
2010-01-28 15:30:25 +01:00
0d770c96fe
msi: Don't evaluate the condition table when there are overrides.
2010-01-27 18:46:08 +01:00
36b654e695
msi: Add tests for updating rows in join tables.
2010-01-22 13:09:15 +01:00
882e4fb233
msi: Add support for updating rows in join tables.
2010-01-22 13:09:11 +01:00
de3fa09cb2
msi: Add a partial stub for the ValidateProductID control event.
2010-01-20 15:36:00 +01:00
06c45a8d59
msi: Correct the setting of environment variables.
...
Contrary to the MSDN, you can 'create only' whilst using a previous value
(ie +-variable and [~];value). This breaks the install of an application
I was debugging who uses that throughout for all their variables. In
addition whilst adding some tests I've also cleaned up invalid prefix
syntax handling and semicolon removal if the original string is empty.
2010-01-20 15:34:19 +01:00
72393c55e9
msi: Add a test to exersize the code to retrieve rows from join tables.
2010-01-19 16:50:56 +01:00
2bfce6cfdc
msi: Fix parsing of feature overrides.
2010-01-18 14:39:23 +01:00
1423ef9923
msi: Support retrieving rows from join tables.
2010-01-18 14:39:17 +01:00
0c437f558c
msi: Queue dynamically allocated strings in cond.y.
2010-01-08 17:03:15 +01:00
2e339c471e
msi/tests: Remove dead url.
2010-01-06 09:52:52 +01:00
d1a916a614
msi: Implement recursive INSTALLSTATE updates for msi treeview selector.
2010-01-06 09:51:17 +01:00
dcf1a0c891
msi: Fix some pointer cast warnings on 64-bit.
2009-12-31 12:12:15 +01:00
e2f7946bbc
msi: Removed unnecessary NULL check.
2009-12-22 13:48:26 +01:00
4749b079b5
msi/tests: Fix test failures on Win9x/WinMe.
2009-12-21 15:01:24 +01:00
839e487c84
msi: Propagate errors from IStorage_OpenStream again in db_get_raw_stream.
...
Fixes a regression introduced by ef522c5ef0
2009-12-18 11:47:46 +01:00
699cfc915a
msi: Avoid a crash in STREAMS_delete.
2009-12-18 11:47:39 +01:00
d9c52bfa70
msi: Free the current filename if we choose to not extract the file.
2009-12-18 11:45:30 +01:00
178ebae4c0
msi: Reset the ALLUSERS property from to 2 to 1.
2009-12-17 14:21:39 +01:00
ff2aa7e3a6
msi: Fix download of installer packages. Return errors from msi_download_file and copy_package_to_temp.
2009-12-17 14:21:32 +01:00
26d541b2a9
msi: Initialize type. If the value did not exist, type was uninitialized and passed to RegSetValueExW.
2009-12-17 13:09:46 +01:00
6b403d1a31
msi: Move MSITRANSFORM and MSISTREAM and associated methods to the dabatase implementation file as they are database objects/methods.
2009-12-17 12:53:34 +01:00
a2f5d0e270
msi: Free the cached streams when closing the database.
2009-12-17 12:53:27 +01:00
2102dbe854
msi: Remove an unused field from the string table.
2009-12-17 12:43:25 +01:00
2c526b7fe7
msi: Replace the string table hash with a sorted index.
2009-12-16 13:04:35 +01:00
ef522c5ef0
msi: Clone the open stream instead of trying to open a stream again.
2009-12-16 13:04:35 +01:00
8ed06175a0
msi: Free the temp buffer if we haven't assigned it to *appValue.
2009-12-16 12:42:39 +01:00
b530f38baa
msi: Refactor freeing the import sql strings.
2009-12-16 12:42:33 +01:00
1b7238a969
msi: Simplify ITERATE_WriteEnvironmentString.
...
Now we only allocate enough memory to exactly match the size of the
constructed string. Before, we were leaving some memory uninitialized
and overwriting the allocated memory in certain circum.
2009-12-16 12:27:11 +01:00
be1b1605f9
msi: Free the columns view if check_column_exists fails.
2009-12-16 12:26:59 +01:00
1a4a112d76
msi: Fix a leaking record handle.
2009-12-16 12:26:51 +01:00
b93c2c3544
msi: Free the join view if we fail to create the table view.
2009-12-16 12:26:45 +01:00
1692e1fe67
msi: Keep track of the current view in the sql parser.
...
This allows us to free said view in the case of a syntax error. This
also allows us to get rid of a few places where we tried to clean up
the view ourselves in the parsing code.
2009-12-16 12:26:38 +01:00
6df6332198
msi: Reject greater than and less than string comparisons in WHERE clauses.
2009-12-15 11:45:04 +01:00
8fe8a100c8
msi: Free the enumeration data returned by IEnumSTATSTG_Next.
2009-12-14 12:20:48 +01:00
7abb42a994
msi: Free each table object when deleting the join view.
2009-12-14 12:20:43 +01:00
ee2cf9a597
msi: Free the Streams and Storages view object in their respective delete methods.
2009-12-14 12:20:39 +01:00
f45db6eee7
msi: Implement DROP_delete that deletes the drop view. We were leaking the view before.
2009-12-14 12:20:33 +01:00
37a058208d
msi: Fix a record handle leak.
2009-12-14 12:20:25 +01:00
d2fe01aa32
msi: Free each storage name when deleting the storages view.
2009-12-14 12:20:20 +01:00
3188792a30
msi: Store the number of types we queried. We were leaking these types because we didn't have the correct count.
...
This change also fixes weird 8-space indenting in free_merge_tables.
2009-12-14 12:20:14 +01:00
12134243c3
msi: Free each stream name when deleting the streams view.
2009-12-14 12:20:03 +01:00
a7fe36b327
msi: Don't free str until the last instance of its use.
2009-12-14 12:19:58 +01:00
f4829063bc
msi: Make sure we don't access pcchValueBuf when szBuffer is NULL, as pcchValueBuf is not required to be initialized in this case.
2009-12-14 12:19:52 +01:00
8b50188f57
msi/tests: Fix a handle leak.
2009-12-11 20:20:30 +01:00
350cdd2fe5
msi/tests: Remove some barriers to running msi tests in parallel.
2009-12-11 17:47:30 +01:00
50833f0780
msi: Wine fails the test and passes us a Session object back, so free it in this case.
2009-12-11 12:16:27 +01:00
e38c36a1f9
msi: Refactor the Installer.RelatedProducts method into InstallerImpl_RelatedProducts.
2009-12-11 12:16:27 +01:00
105933f202
msi: Refactor the Installer.Products method into InstallerImpl_Products.
2009-12-11 12:16:27 +01:00
9f09d47be3
msi: Refactor the Installer.ProductInfo method into InstallerImpl_ProductInfo.
2009-12-11 12:16:27 +01:00
fd2884a155
msi: Refactor the Installer.ProductState method into InstallerImpl_ProductState.
2009-12-11 12:16:27 +01:00
11b4fe743a
msi: Refactor the Installer.RegistryValue method into InstallerImpl_RegistryValue.
2009-12-11 12:16:27 +01:00
138d5f1f6c
msi: Refactor the Installer.Version method into InstallerImpl_Version.
2009-12-11 12:16:27 +01:00
96c480b880
msi: Refactor the Installer.InstallProduct method into InstallerImpl_InstallProduct.
2009-12-11 12:16:27 +01:00
851e4779be
msi: Refactor the remaining Installer object stub methods into respective functions.
2009-12-11 12:16:27 +01:00
dc0889752a
msi: Refactor the Installer.UILevel method into InstallerImpl_UILevel.
2009-12-11 12:16:27 +01:00
18ba830ff8
msi: Refactor the Installer.SummaryInformation method to InstallerImpl_SummaryInformation.
2009-12-11 12:16:27 +01:00
554e1318c0
msi: Refactor Installer.OpenProduct and Installer.OpenDatabase into respective functions.
2009-12-11 12:16:27 +01:00
b33d47e773
msi: Refactor the Installer.OpenPackage method into InstallerImpl_OpenPackage.
2009-12-11 12:16:26 +01:00
b73389b6bf
msi: Refactor the Installer.CreateRecord method into InstallerImpl_CreateRecord.
2009-12-11 12:16:26 +01:00
ae58e29e5e
msi: Stub out a few more Installer object methods.
2009-12-11 12:16:26 +01:00
9ab7d9e21a
msi: Close the original record before copying new data into it.
2009-12-11 12:16:26 +01:00
a44b653d53
msi: Fix a handle leak in the record tests.
2009-12-11 12:16:26 +01:00
d90aca35c4
msi: Add a NULL terminator to file->dest after reallocation.
2009-12-08 12:36:51 +01:00
b13803ea40
msi: Free the column info data when updating the table column info.
2009-12-08 12:36:36 +01:00
c20902314b
msi: Make sure to free the extra row data when deleting a row.
2009-12-08 12:36:28 +01:00
3840de5b1e
msi/tests: Loosen check on kernel32 language version.
2009-12-07 14:18:29 +01:00
25ab693008
msi: The second parameter to Installer.OpenPackage is optional, so set a default value of 0 if the parameter is not provided.
2009-12-07 09:49:06 +01:00
1ff6c08621
msi: Verify that the first parameter to Installer.OpenPackage is a VT_BSTR.
...
It seems ugly to open up the parameters in pDispParams, but
DispGetParam will happily convert a VT_EMPTY to a VT_BSTR and not
return an error.
2009-12-07 09:49:06 +01:00
4687604356
msi: It's possible to send in more than two parameters to Installer.OpenPackage, but sending in zero parameters should return DISP_E_TYPEMISMATCH.
2009-12-07 09:49:06 +01:00
b614052895
msi: Add more tests for the Installer.OpenPackage method.
...
The following series fixes a few leaks reported by valgrind. We were
leaking exception info caused by Installer.OpenPackage failing when we
didn't expected it.
2009-12-07 09:49:06 +01:00
7d3e664312
msi: MsiSetMode returns a UINT system error code, not a BOOL.
2009-12-04 14:34:57 +01:00
6b8b82ef13
msi: ExpandEnvironmentStringsW returns the required size in characters, so multiply the required size by sizeof(WCHAR) when allocating the buffer.
2009-12-03 10:22:40 +01:00
fd8620f6c0
msi/tests: Don't check more bytes than written to the file.
2009-12-01 13:16:30 +01:00
abb23d8bd5
msi: Support _Streams, _Storages tablename prefixes in SELECT.
2009-11-24 15:54:06 +01:00
f7ba4b2ec0
msi/tests: Test for SELECT table.column FROM table.
...
Make sure that mixing table columns returns the expected
data. eg: SELECT t1.action, t2.action FROM t1, t2
should return distinct data.
2009-11-24 15:54:00 +01:00
5c56e1f440
msi: Add support for table names in select statements.
...
Propagate tablename from 'SELECT tablename.column from tablename' queries
into VIEW_find_column(). Previously, the tablename had been dropped.
2009-11-24 15:53:53 +01:00
d28eabda5c
msi: Shedule rename operation also for ERROR_USER_MAPPED_FILE.
2009-11-20 14:37:09 +01:00
83e7a1214a
msi: Sign extend the value when converting from a small integer.
2009-11-19 11:50:36 +01:00
1f7a07ebe3
oleaut32: Ignore milliseconds in VarDateFromUdate implementation.
2009-11-19 11:35:40 +01:00
bd4bc16147
msi: Don't set the ALLUSERS property.
2009-11-17 16:05:27 +01:00
fd549aa25d
msi: Set the LogonUser property.
2009-11-17 16:05:15 +01:00
84ddfd8739
msi: Test more variations of environment string prefixes.
2009-11-13 13:35:58 +01:00
e52531ab1d
msi: Handle environment strings without a value.
2009-11-13 12:21:46 +01:00
b960b967c9
msi: Improve stub for MsiGetFeatureCost{A, W} and hook the stub into the VolumeCostList dialog control.
2009-11-09 19:43:23 +01:00
97619affe5
msi/tests: Make the handler_xxx() functions static.
...
Also remove extraneous semi-colons.
2009-11-09 19:40:44 +01:00
0839ae88ca
msi/tests: MsiSetExternalUIRecord not present before Installer 3.1.
2009-11-05 11:57:21 +01:00
808343fb5b
msi: Implement MsiSetExternalUIRecord.
2009-11-03 22:23:08 +01:00
90fa4fe155
msi: Unicode and ANSI global UI handlers are mutually exclusive.
2009-11-03 22:23:01 +01:00
4b5248c9e0
msi: Add support for the Unicode version of the global UI handler.
2009-11-03 22:22:54 +01:00
0513f3c4e6
msi: Add support for msidbControlAttributesProgress95.
2009-10-29 15:48:38 +01:00
df8780356b
msi: Limit the progress to its maximal value, use MulDiv for better results.
2009-10-29 15:48:27 +01:00
07c321ba73
msi: Test that a query on a join of two tables returns data from the correct table.
2009-10-27 14:01:50 +01:00
cc366e1282
msi: Add tablename tracking to VIEW_find_column.
...
This fixes the bug where multiple columns of the same name, but
different tables are members of a join. Any attempt to refer to these
columns will resolve to the first available column with that name,
irregardless of any tablename modifier.
2009-10-27 14:01:23 +01:00
2eb33f5bcb
msi: Avoid accessing uninitialized memory in ACTION_AppSearchReg.
...
Found by valgrind.
2009-10-27 10:53:56 +01:00
3f70b07870
msi/tests: Fix a couple of user SID string leaks.
...
Found by valgrind.
2009-10-27 10:53:42 +01:00
e58ebbf3e0
msi: Fix calculation of required buffer size in MsiSummaryInfoGetPropertyW.
2009-10-23 12:04:38 +02:00
394a437723
msi/tests: Free the string returned from ConvertSidToStringSid.
...
Found by valgrind.
2009-10-23 12:04:06 +02:00
483590a3c5
msi/tests: Avoid accessing uninitialized memory.
...
Found by valgrind.
2009-10-23 12:04:00 +02:00
a15e6cbb1a
msi: Avoid accessing uninitialized memory.
...
Found by valgrind.
2009-10-21 17:05:54 +02:00
47ec8ab0f3
msi: Remove table_find_insert_idx().
...
The function table_find_insert_idx() is replaced by the more generic
function find_insert_index().
2009-10-20 15:57:25 +02:00
f6ae2507ef
msi: Fix table rows order.
2009-10-20 15:57:09 +02:00
efacff81d6
msi: Add function get_table_value_from_record.
2009-10-20 15:57:01 +02:00
9dddb94b99
msi: Fix merging string type checks.
2009-10-20 15:55:43 +02:00
925fb3b408
msi/tests: Add tests for rows order.
2009-10-20 15:07:07 +02:00
8d49633275
msi/tests: Add test for merging string types.
2009-10-20 15:03:39 +02:00
a3214c978d
msi: Fix a failure with merging existing tables.
2009-10-20 15:03:33 +02:00
6aad5cb307
msi/tests: Add tests for merging existing tables.
2009-10-20 15:03:24 +02:00
afcd2c5358
msi: Open the database read/write in MSI_OpenPackageW.
...
Fixes transforms that add binary streams.
2009-10-20 14:40:01 +02:00
8dd3d389b0
msi: Create the local copy before opening the database.
2009-10-20 14:39:55 +02:00
33d9f37f4a
msi: Always create a temporary copy of the package.
2009-10-20 14:39:47 +02:00
534f20bc49
msi: Get rid of some redundant initializations.
2009-10-19 15:02:42 +02:00
b7a81df452
msi: Allocate MSISCRIPT structure at package creation time.
2009-10-19 15:02:36 +02:00
a187b43ddd
msi: Eliminate the last parameter from ACTION_PerformActionSequence.
2009-10-15 14:17:24 +02:00
e3aa2f33d9
msi: Use a function to test the UI level instead of passing a boolean around.
2009-10-15 14:17:18 +02:00
796eed1dc7
msi: Reorder functions to avoid forward declarations.
2009-10-15 14:17:06 +02:00
55b89f4a66
msi: Add some tests for MsiGetTargetPathW.
2009-10-15 14:16:57 +02:00
843382f284
msi: Define common strings only once.
2009-10-15 14:16:50 +02:00
fe935e8d50
Assorted spelling fixes.
2009-10-08 12:17:31 +02:00
fa6ffb4d5d
Fix empty function prototypes.
2009-10-07 12:24:53 +02:00
35df8f2d69
msi/tests: Skip some tests on Win9x/WinMe.
2009-10-02 11:51:23 +02:00
9c8b83ce01
msi: Schedule a rename operation when the file to overwrite is in use.
2009-10-01 12:04:02 +02:00
f8ec47d5c6
msi/tests: Remove trailing '\'.
2009-09-29 18:08:30 +02:00
c0c6daeb5a
msi: Test installing over in-use files.
2009-09-29 16:06:23 +02:00
46ac59f988
msi: Don't set the Installed property twice.
2009-09-29 16:06:23 +02:00
2beee126a7
msi: Test the Installed property.
2009-09-29 16:06:22 +02:00
1b7d1d4c87
msi: Respect UI level in custom action type 19.
2009-09-29 16:06:22 +02:00
4086ff6248
msi: Add tests to show that the condition table is ignored when there are overrides.
2009-09-22 16:20:51 +02:00
ae3418fdd9
msi: Test last used source property in combination with cabinet storage.
2009-09-22 16:20:48 +02:00
c6e7558cda
msi/tests: Fix some test failures on Vista/W2K8.
2009-09-22 16:15:36 +02:00
6867de0714
msi/tests: Skip some tests on Win9x/WinMe.
2009-09-18 08:56:16 -05:00
659768e203
msi: Set or override a user environment string when there is no prefix.
2009-09-16 12:57:33 -05:00
86e08ea4e4
msi: Don't append the cabinet file name in find_published_source.
2009-09-16 12:56:57 -05:00
60d0cf41b3
msi: GetDriveType and GetVolumeInformation require a path terminated by a slash.
2009-09-16 12:56:50 -05:00
fc15d6d5ad
msi: Downgrade two ERRs to WARNs.
2009-09-16 12:56:44 -05:00
90d283f0eb
msi: Improve a trace.
2009-09-16 12:56:38 -05:00
5669e67d48
msi: Set ProductState property.
2009-09-11 16:19:54 +02:00
dd1ca6ca5e
msi: Ignore CoInitialize failure in ACTION_CreateShortcuts.
2009-09-10 22:32:13 +02:00
3a7c2d005c
msi: Open the database read/write when the update count is greater than zero in MsiGetSummaryInformation.
2009-09-10 10:50:28 +02:00
92cd7a8fa0
msi: Add a test to show that creating shortcuts works regardless of COM initialization state.
2009-09-09 16:25:00 +02:00
e98a52e585
msi: Force overwriting of read-only files when extracting a cabinet, with tests.
2009-09-09 12:19:28 +02:00
05e9a1fce8
msi: Add a partial implementation of MsiDetermineApplicablePatchesW.
2009-09-02 14:41:31 +02:00
1169aa9a58
msi: Set REINSTALL property when the product is already installed and the command line is empty.
2009-09-02 14:41:24 +02:00
167ef04727
msi/tests: Create only a single restore point.
2009-08-28 16:48:27 +02:00
eb101df687
msi: Fix column width calculation.
...
The iTunes 8 installer database has an integer column of size 1 which
takes up two bytes at storage level, so adjust the column size calculation
to account for this difference.
2009-08-04 13:05:45 +02:00
0b60ed8ff1
msi: Fix parsing of integer column width specifiers.
2009-08-04 13:05:30 +02:00
04deb6d7d1
msi: Convert the Russian resources to UTF-8.
2009-08-03 14:56:39 +02:00
2c5bd49297
msi: Build a proper tab chain by walking through the controls list.
...
Simply changing Z-order as we encounter windows is not sufficient to
ensure correct ordering, we have to rebuild the list from scratch.
2009-07-15 14:22:14 +02:00
ec4edbfd6c
msi: Implement ASSIGN mode in MsiViewModify.
2009-07-06 15:25:39 +02:00
eaea537f0f
msi/tests: Add tests for MsiViewModify ASSIGN mode.
2009-07-06 15:25:36 +02:00
e801cae520
msi: Update French translation.
2009-07-03 13:11:24 +02:00
5234f1fd0a
msi: Build language resource files separately.
...
Do not include them from an other rc file.
2009-07-02 11:44:15 +02:00
60b7604aa1
msi: Support opening transform databases.
2009-06-30 13:46:39 +02:00
3271362a26
msi: The dialog units are based on a 12-point font size, despite the documentation.
2009-06-25 12:09:45 +02:00
5392014e29
msi: Release more msi_custom_action_info when no longer needed.
2009-06-22 13:09:03 +02:00
e86ebd75b0
msi: Release msi_custom_action_info when no longer needed.
2009-06-22 13:08:55 +02:00
65ac206194
msi: Insert new tables in correct _Tables location.
2009-06-22 13:08:36 +02:00
19d783d34d
msi/tests: Add tests for order of tables.
2009-06-22 13:08:28 +02:00
a66dc8f981
msi: Add Lithuanian translation.
2009-06-22 11:28:00 +02:00
9a1b829923
msi/tests: Fix some test failures on Win95 by using more A-functions.
2009-06-19 13:52:38 +02:00
44b53ef35e
msi/tests: Fix test (logical || with non-zero constant).
2009-06-19 13:52:26 +02:00
e3a7ae8a30
msi: Add some reinstall tests.
2009-06-12 17:33:15 +02:00
9e5d07bb53
msi: Add a test to insert a null primary key temporary row and check its order.
2009-06-11 13:23:25 +02:00
2cc9a710b1
msi: Store temporary rows in the same place as persistent rows, just with a flag.
2009-06-11 13:23:25 +02:00
8fb7fdd029
msi: Fix a crash when freeing memory.
2009-06-11 11:45:48 +02:00
9b6cf22607
msi/tests: Make sure we only create one logfile.
2009-06-09 17:01:13 +02:00
890b5dafb6
msi: Check the correct pointers for allocation failure (Coverity).
2009-06-05 15:19:57 +02:00
f9e33e9af6
msi/tests: Ignore case when comparing file names.
2009-06-04 12:18:20 +02:00
761736e6aa
msi: Add more tests for MsiGetSourcePath.
2009-06-04 12:18:15 +02:00
a0b9315dff
msi: Add tests for importing a _SummaryInformation table.
2009-06-04 12:18:09 +02:00
d02dbf4492
msi: Initialize some variables.
2009-06-04 12:18:04 +02:00
c1670fb353
msi: Don't trace an out parameter.
2009-06-04 12:17:59 +02:00
7d837b9f82
msi: The assembly file version field is optional.
2009-05-29 15:35:59 +02:00
22a277cc2e
msi: Fix some memory leaks.
2009-05-28 15:29:09 +02:00
a4b76ceee7
msi: Consistently use the parser allocator when parsing a query.
2009-05-28 15:29:02 +02:00
5922de46de
msi: Don't duplicate the table name in CREATE_CreateView.
...
The table name is tracked in the list attached to the parent query object,
which is destroyed after the view object.
This plugs a leak since the duplicated table name was never freed.
2009-05-28 15:28:53 +02:00
2018de00e1
msi: Constify some parameters.
2009-05-28 15:28:45 +02:00
db355b4903
msi/tests: Remove unused variable.
2009-05-28 12:42:17 +02:00
45c00da496
msi/tests: Prevent crash when ConvertSidToStringSidA is not available.
2009-05-27 15:40:30 +02:00
ff5b29e5eb
msi: Add support for merging tables that are not in target database.
2009-05-27 12:51:51 +02:00
97200b0b31
msi/tests: Add test for merging tables that are not in target database.
2009-05-27 12:51:36 +02:00
987d17dc6f
msi: Fix merging tables with string primary keys.
2009-05-27 12:51:31 +02:00
a807e86dd7
msi/tests: Add test for merging tables with string primary keys.
2009-05-27 12:51:22 +02:00
086fcfc1f4
msi: Initialize a variable.
2009-05-27 12:51:15 +02:00
cad837c999
msi: Add support for importing binary OBJECTS.
2009-05-27 12:51:10 +02:00
e7ebbbe62e
msi/tests: Add test for importing binary OBJECTS.
2009-05-26 15:27:27 +02:00
d9568722aa
msi: Support transforms with binary OBJECTS.
2009-05-26 15:18:09 +02:00
f6dd90de5e
msi: Add support for binary OBJECTS.
2009-05-26 15:18:02 +02:00
8356484c9f
msi/tests: Add tests for binary OBJECTS.
2009-05-26 15:17:52 +02:00
623dad0963
msi/tests: Tweak the get_user_sid() functions to simplify their use.
...
Now the function deals with all errors and win_skips() itself.
2009-05-26 14:10:27 +02:00
6c64da8b7c
msi: Subscribe to SetProgress event on adding progress bar control to dialog.
2009-05-21 16:17:52 +02:00
d9ffbe4e82
msi/tests: Use win_skip() to skip over unimplemented functionality.
2009-05-19 12:01:20 +02:00
aea6418ff0
msi: Initialize variable in MSI_ApplyPatchW.
2009-05-14 17:39:29 +02:00
0d8a826ef5
msi: Reject NULL or empty patch package parameter in MsiApplyPatch.
2009-05-06 16:09:55 +02:00
1cfc88a500
msi: Initialize info and patch variables (Coverity 923).
2009-05-05 11:35:22 +02:00
a31e9a1bfa
msi/tests: Run tests again with older msi versions (MsiApplyMultiplePatchesA).
2009-05-05 11:33:52 +02:00
2f37672225
msi/tests: Fix MsiApplyMultiplePatches tests on Windows.
2009-05-04 12:51:01 +02:00
b4b8bc830f
msi: Implement MsiApplyMultiplePatchesA/W.
2009-05-01 16:19:39 +02:00
0a81fbfa39
msi: Fix LONGCHAR column data type.
2009-04-28 13:10:04 +02:00
508028ae03
msi/tests: Test type for LONGCHAR columns.
2009-04-28 13:10:03 +02:00
5e829d1323
msi: Fix SHORT column data type.
2009-04-28 13:10:03 +02:00
407866186c
msi/tests: Test type for INTEGER, SHORT, LONG columns.
2009-04-28 13:10:03 +02:00
15cb7290ee
msi: Fix INT column data type.
2009-04-28 13:10:03 +02:00
fa8f8a3efc
msi/tests: Test type for INT column.
2009-04-28 13:10:03 +02:00
7daf9b6ef5
msi: Fix wrong calling convention.
2009-04-27 13:24:51 +02:00
8b348fca27
msi/tests: Fix package test when run on a different drive than C:\.
2009-04-23 18:14:25 +02:00
b91fc465ff
msi: Fix ACTION_AppSearchDr on empty path.
2009-04-23 18:14:25 +02:00
34202629c9
msi/tests: Add empty dir test for the DrLocator part of the AppSearch action.
2009-04-23 18:14:25 +02:00
03afdb0217
msi: Enfore use of GetFileAttributes return value.
2009-04-23 18:14:25 +02:00
55ad3fdda2
msi: Fix another double free.
...
parser_alloc() allocates memory and puts it on a list attached the to query object.
EXPR_sval() frees memory allocated via parser_alloc() on error but does not remove
the pointer from the list, which means that when the query destructor is called it
will be freed again.
2009-04-20 17:40:43 +02:00
91ac47b84b
msi: Fix a double free.
...
TABLE_drop() calls TABLE_remove_column() which calls msi_update_table_columns()
which frees column info and possibly returns without reallocating. When that
happens it will be freed again when TABLE_drop() finally calls free_table().
2009-04-20 17:40:38 +02:00
e00d864a35
msi: Fix buffer length value returned by MSI_RecordGetStringW on null and empty strings.
2009-04-20 17:26:13 +02:00
edac581d6a
msi/tests: Test MsiRecordGetString on null and empty strings.
2009-04-20 17:26:10 +02:00
a26da7b7a3
msi/tests: Replace lstrcatW with memcpy to fix failures on win95.
2009-04-20 17:20:01 +02:00
cf6ec333a5
msi/tests: Replace long with LONG.
2009-04-20 14:12:37 +02:00
f3a1660181
msi: Remove superfluous cast of a MSIHANDLE in a TRACE().
2009-04-20 14:12:34 +02:00
184474ea66
msi: Support setting summary information by importing a _SummaryInformation table.
2009-04-14 15:20:58 -05:00
112bb084f1
msi/tests: Fix test when content indexing is disabled.
2009-04-10 14:43:57 +02:00
7b2a44f257
msi/tests: Fix format test when run on root drive directory.
2009-04-10 11:14:21 +02:00
215fd0b813
msi/tests: Handle running the tests as a domain user.
2009-04-07 14:21:25 +02:00
e3b558887d
msi: Build a proper source path in MsiConfigureProductExW.
...
We were passing uninitialized data which would ultimately end up in the
registry.
2009-03-31 12:41:42 +02:00
965698cd28
msi: Don't publish package name as part of product properties.
...
This value does not exist directly under the product key on Windows.
2009-03-31 12:41:36 +02:00
03ff6ba641
msi/tests: Fix a copy & paste typo in a test message.
2009-03-30 17:51:03 +02:00
36dbb69b66
msi/tests: Verify path names case insensitively.
2009-03-30 15:09:00 +02:00
4365b34838
msi: Allocate token information buffer dynamically.
2009-03-27 15:51:26 +01:00
f0d1d61d3b
msi: Add tests for MsiEnumProducts.
2009-03-27 15:51:26 +01:00
9163b0d0a3
msi: Enumerate products from all contexts.
...
Fix for office 2007 proofing tools installer.
2009-03-27 15:51:26 +01:00
836d9af1be
msi/tests: Avoid size_t in traces.
2009-03-26 14:01:26 +01:00
6fa69c3f2b
msi: Remove redundant NULL check before msi_free (Smatch).
2009-03-26 11:51:08 +01:00
9c6e6efa32
msi: Detect privately installed assemblies.
...
Another fix for the office 2007 sp1 installer.
2009-03-25 15:02:45 +01:00
c2221f325f
msi: Add some tests for MsiQueryFeatureState.
...
These tests confirm that a feature is reported as advertised if only
one of its components is missing.
2009-03-25 15:02:37 +01:00
28bc76b5d3
msi: Verify the existence of fusion.dll before reporting the .Net version.
...
Fixes an issue with .Net 3.0 where it does not install a new
fusion.dll but does add a key to the registery. The fact that a new
dll is not installed has been verified on windows.
2009-03-25 12:39:27 +01:00
86af876987
msi: Only apply a transform when its language id matches the system language id.
...
Fix for office 2007 sp1 installer.
2009-03-24 13:32:11 +01:00
b8965ee7c9
msi: Don't initialize COM for custom action threads.
2009-03-24 13:31:59 +01:00
c844582177
msi: Add stub implementations of MsiSourceListClearAllExA/W.
2009-03-24 13:31:36 +01:00
7590a3f335
msi: Implement MsiReinstallProductA/W.
2009-03-24 13:31:24 +01:00
201e291e5d
msi: Add stub implementations of MsiDeterminePatchSequenceA/W.
2009-03-24 13:31:12 +01:00
6789fa8544
msi: Add the Romanian translation.
2009-03-24 13:00:02 +01:00
5e62686a0f
msi: Handle a NULL and empty szPackagePath in MsiInstallProduct (Coverity 181).
2009-03-23 15:52:18 +01:00
fb8db0ac13
msi: Don't try to release a NULL record, with tests (Coverity 536).
2009-03-23 15:52:17 +01:00
baf86bd5bb
msi: MsiCollectUserInfo cannot be called from a custom action (Coverity 565, 566).
2009-03-23 15:52:17 +01:00
cb958cd773
msi: Test and handle the case where the SourceList key does not exist and the PackageName value does not exist in MsiGetProductInfo.
2009-03-23 15:52:17 +01:00
dc50773c28
msi: Factor out the MsiEnumPatchesEx tests and test the NULL szUserSid and an szUserSid that is different from the current user.
2009-03-23 15:52:17 +01:00
c965d839f9
msi: Allow the enumeration of other users' patches.
2009-03-23 15:52:17 +01:00
f7c615b188
msi: Enumerate the current user's patches if szUserSid is NULL.
2009-03-23 15:52:17 +01:00
3956bb5b0e
msi: Fix a typo (Coverity 910).
2009-03-23 15:52:17 +01:00
fccdccc378
msi: Update the German translation.
2009-03-23 15:52:17 +01:00
b4cb8562ae
msi: Convert the German translation to UTF8 encoding.
2009-03-23 15:52:17 +01:00
39600d9d2e
msi: Reorder the condition operators so that longer strings are matched first.
...
This allows ~<< to be properly matched.
2009-03-23 15:26:02 +01:00
ba50d15060
msi: Set concurrency model to multi-threaded for custom action threads.
...
A custom action in the office 2007 sp1 installer fails right after calling
CoInitializeEx(NULL, COINIT_MULTITHREADED). This is because our code calls
CoInitialize(NULL) first, which sets a different concurrency model, and a
subsequent call with a different model will return RPC_E_CHANGED_MODE.
Ergo, we should set the model to multi-threaded too.
2009-03-13 14:52:48 +01:00
4da865f324
msi: Handle ADVERTISE overrides.
2009-03-13 13:21:07 +01:00
804d66039d
msi: Correct spec entry for MsiGetProductInfoA/W.
2009-03-13 13:21:07 +01:00
7a8000d4e8
msi/tests: Fix a test for systems with %TEMP% being less than 2 levels deep.
2009-03-12 14:29:56 +01:00
40cfbaf023
msi: Fix handling of REINSTALL overrides.
...
We were forcing features with a REINSTALL override to be reinstalled
locally, which is only correct if the original install state is local.
This causes problems with the office 2007 sp1 installer, which applies
a REINSTALL override to an advertised feature.
2009-03-12 14:29:56 +01:00
fca2626768
msi/tests: Fix a test failure on Win95.
2009-03-03 12:36:25 +01:00
9540d762ad
msi: Handle reading from a NULL stream.
2009-03-02 12:06:37 +01:00
2f1eacfcad
msi: Don't treat carriage returns as spaces.
2009-03-02 12:06:30 +01:00
7f3faffc3b
msi: Don't allow nested quotes in SQL queries.
2009-03-02 12:06:24 +01:00
e821f9d724
msi: Add missing calls to MsiViewClose.
2009-03-02 12:06:18 +01:00
293bdffa29
msi: Use a SQL marker to query the _Property table when fetching a property.
2009-03-02 12:06:10 +01:00
f36e13fd81
msi: Delete the view on error.
2009-03-02 12:06:02 +01:00
046bcc918c
msi: The PATH environment variable can be longer than MAX_PATH, so dynamically allocate strings to deal with that.
2009-03-02 12:05:57 +01:00
37c5e04010
msi: The _Streams and _Storages table are special and always exist.
2009-03-02 12:05:45 +01:00
c9b3bc1165
msi: Column attributes for temporary string and int columns should be g and j respectively.
2009-03-02 12:05:28 +01:00
c07b554edc
msi: Order primary keys to be first in the column list when creating a table.
2009-03-02 12:05:09 +01:00
b3c9875cf7
msi: Correctly order transposed column values in the INSERT query.
2009-03-02 12:04:57 +01:00
148ef5f485
msi: Add reinstall tests.
...
Based on a patch by Aric Stewart.
2009-02-26 15:13:25 +01:00
b55c031032
msi: Fix a failing test on win9x.
2009-02-26 12:14:19 +01:00
a7d5adc91f
msi: Trace the username to help debug test failures on certain machines.
2009-02-26 12:14:13 +01:00
5735e2fafd
msi: Fix a failing test on win9x.
2009-02-26 12:14:08 +01:00
ea28915133
msi: Don't create a temporary table that is not held.
2009-02-26 12:14:01 +01:00
241933e13c
msi: A non-temporary table cannot have a temporary primary key.
2009-02-26 12:13:57 +01:00
74aa053485
msi: The _Tables and _Columns tables have no persistence attribute.
2009-02-26 12:13:52 +01:00
2f8c2a8d41
msi: Make sure the view being updated is the same view the record was fetched from.
2009-02-26 12:13:49 +01:00
e872681af7
msi: Set field zero to the name of the table containing the primary keys.
2009-02-26 12:13:44 +01:00
7d7f14c101
msi: Add tests for field zero of a record.
2009-02-26 12:13:10 +01:00
60ad75eade
msi: Make sure a constant string's quotes match up.
2009-02-26 12:13:02 +01:00
b5ac29a73d
msi/tests: Add some tests for MsiEnumPatchesW, fix a few failures on XP.
2009-02-25 16:06:21 +01:00
b4d81f8517
msi: Fix handling of buffer sizes in MsiEnumPatchesA and avoid a redundant call to MsiEnumPatchesW.
2009-02-25 16:06:21 +01:00
18cd216e80
msi: Don't release view object twice in check_assembly_installed.
2009-02-19 16:17:17 +01:00
43094e4a3e
msi: Make comparison of assembly field names case insensistive.
2009-02-19 16:17:17 +01:00
fb04bcf638
Fix position of CDECL qualifier for functions that return pointers.
2009-02-06 14:54:01 +01:00
c0ad988e67
msi: Remove unused functions.
2009-02-06 13:04:03 +01:00
4e29ceeb77
include: Define LANGID in wtypes.idl.
2009-02-04 15:06:25 +01:00
0194b8f08c
jscript: Add IActiveScriptParse64 declaration and use it on Win64.
2009-02-03 12:39:23 +01:00
8ca2aa3da9
msi: Fix compiler warning on older gcc.
2009-01-30 13:44:06 +01:00
0bd6da81c5
msi/tests: Fix missing void in empty parameter list.
2009-01-29 12:19:44 +01:00
8fec17b5ad
msi: Add stub implementations of MsiSourceListClearSourceA/W.
2009-01-27 14:27:00 +01:00
76b08f3aa7
msi: Initialize row (Coverity).
2009-01-26 16:08:25 +01:00
2fbe8d23eb
msi: Fix potential NULL pointer dereference in ILockBytes_Release (Coverity).
2009-01-26 15:49:01 +01:00
9598a50916
msi: Fix NULL dereference in MsiQueryComponentStateW (Coverity).
2009-01-26 15:48:57 +01:00
c3e2cb00d5
msi: Remove redundant pointer check (Coverity).
2009-01-26 14:30:34 +01:00
78457300aa
msi/tests: EstimatedSize is not set consistently between Windows Installer versions.
2009-01-20 14:02:43 +01:00
3355f3d66f
msi/tests: Double nul-terminate REG_MULTI_SZ values.
2009-01-19 14:18:04 +01:00
349d8bd1a1
msi/tests: Windows Installer 3.0 often returns ERROR_INVALID_PARAMETER.
2009-01-19 14:17:57 +01:00
6d75522fb4
msi/tests: Fix a few handle leaks.
...
This was pointed out by Christoph von Wittich.
2009-01-19 13:36:27 +01:00
5f3ac30b3c
msi: Remove superfluous pointer casts.
2009-01-15 12:43:03 +01:00
9975dcd19e
msi/tests: Remove superfluous pointer casts.
2009-01-15 12:42:57 +01:00
f516cab017
include: Change to LONG/ULONG in fdi.h for Win64 compatibility.
2009-01-14 12:21:20 +01:00
602f42c25f
include: Change to LONG/ULONG in fci.h for Win64 compatibility.
2009-01-14 12:21:13 +01:00
f9f2e91198
msi/tests: Opening package with relative filename sometimes succeeds on Windows.
2009-01-12 14:34:51 +01:00
668197a898
msi: Declare some functions static.
2009-01-12 13:10:53 +01:00
81ecd7041a
msi: Fix pointer cast warnings on 64-bit.
2009-01-08 17:26:44 +01:00
35811a9078
msi/tests: Use CreateFile instead of OpenFile to avoid handle casts.
2009-01-08 13:05:27 +01:00
bb7efb1deb
msi/tests: Skip some tests if we don't have enough rights.
2009-01-08 12:40:26 +01:00
6bd893a960
msi: Change MSIHANDLE to ULONG for Win64 compatibility.
...
Also fix the compiler warnings produced by this change.
2009-01-05 12:34:12 +01:00
ddc34141cd
msi/tests: Fix pointer casting warnings on 64-bit.
2009-01-03 20:13:45 +01:00
3e7ac7ea2e
msi/tests: Add CDECL to the cabinet callback functions.
2009-01-03 20:12:49 +01:00
49abc9878f
msi: Add missing CDECL to cabinet functions.
2008-12-23 18:50:57 +01:00
2a5cf54f05
msi/tests: Avoid sizeof in traces.
2008-12-20 13:32:59 +01:00
17ffb562aa
msi: Fix some NULL checking in MSI_RecordGetStringA.
...
Includes a few record tests with a NULL buffer.
2008-12-18 14:19:40 +01:00
f10eb0bfa2
msi: EndDialog with Ignore should not be an error.
2008-12-17 11:38:52 +01:00
8bd9a3aa09
janitorial: Don't depend on user32 for the self registration functions.
2008-12-17 11:38:32 +01:00
017fee4aa0
msi/tests: Run tests again on Win9x and NT4.
2008-12-16 12:51:20 +01:00
0ccb714470
msi: Add tests for MsiGetPatchInfo.
2008-12-15 12:36:00 +01:00
c059ceb5b0
msi: Set the property specified by the Source attribute of the Media table when applying a patch.
2008-12-15 12:34:56 +01:00
01eb930005
msi: Publish the patch information.
2008-12-15 12:34:52 +01:00
5aac1ec6e5
msi: Implement MsiGetPatchInfoExW.
2008-12-15 12:34:35 +01:00
b5e3e19a19
msi: Add the ability to query a specific context for install properties.
2008-12-15 12:34:18 +01:00
880b9199a9
msi: Add the ability to query a specific context for a patch.
2008-12-15 12:34:12 +01:00
4a9f6995aa
msi: Add the ability to query a specific context for a product key.
2008-12-15 12:34:06 +01:00
d195ee3cc4
msi: Forward MsiGetPatchInfoExA to MsiGetPatchInfoExW.
2008-12-15 12:34:00 +01:00
199a26c81a
msi: Add a stub implementation of MsiGetPatchInfoEx.
2008-12-15 12:33:56 +01:00
0d7cb11fdf
msi/tests: Make enum_stream_names() and package_RegDeleteTreeW() static.
2008-12-15 12:25:48 +01:00
0b99af82b2
msi: Don't include msvcrt headers.
2008-12-12 10:19:54 +01:00
5f3287d79f
*Ko.rc: Update Korean resource.
...
Fix the unnecessary SUBLANG_NATURAL.
Change the font size from 8 to 9.
2008-12-11 12:21:07 +01:00
194c053021
msi/tests: Skip tests on win9x due to different registry keys.
2008-12-11 11:50:12 +01:00
732c1e8d31
msi/tests: Run tests again on Win9x and NT4.
2008-12-10 10:48:05 +01:00
dfb8b664d6
msi: Add tests for MsiGetProductProperty.
2008-12-09 11:24:19 +01:00
da783c3888
msi: Implement MsiGetProductPropertyW.
2008-12-09 11:24:13 +01:00
06a438152c
msi: Forward MsiGetProductPropertyA to MsiGetProductPropertyW.
2008-12-09 11:24:09 +01:00
61c94d281a
msi: Add tests for MsiEnumPatches.
2008-12-09 11:24:04 +01:00
e07ed1a2eb
msi: Implement MsiEnumPatchesW.
2008-12-09 11:23:56 +01:00
c46f2102c9
msi: Forward MsiEnumPatchesA to MsiEnumPatchesW.
2008-12-09 11:23:49 +01:00
a9e0290934
msi: Add the ability to delete multiple users' component keys.
2008-12-09 10:28:14 +01:00
bdf7da9bdc
msi: Remove a duplicated function.
2008-12-09 10:28:04 +01:00
8438d21127
msi: Remove a duplicated function.
2008-12-09 10:27:58 +01:00
98c703ab87
msi: Add the ability to open multiple users' install properties key.
2008-12-09 10:27:52 +01:00
b198f4f23f
msi: Add the ability to open multiple users' component keys.
2008-12-09 10:27:45 +01:00
930b429d1e
msi: Add the ability to open multiple users product keys.
2008-12-09 10:27:37 +01:00
947c4c312a
msi: Add tests for MsiEnumPatchesEx.
2008-12-09 10:25:47 +01:00
ff87f354c4
msi: Fix an uninitialized variable.
2008-12-09 10:25:44 +01:00
94d22682c1
msi: Remove an unused declaration.
2008-12-08 22:02:53 +01:00
87fef9fd22
msi: Implement MsiEnumPatchesExW.
2008-12-08 12:18:49 +01:00
a32fcfa9b1
msi: Forward MsiEnumPatchesExA to MsiEnumPatchesExW.
2008-12-08 12:06:42 +01:00
7df94f3b04
msi: Fix the type of the last parameter of MsiEnumPatchesEx.
2008-12-08 12:06:06 +01:00
4153fc1904
msi: Set DllVersion registry key for CLSID_IMsiServerMessage.
2008-11-28 13:41:00 +01:00
d7119f2b73
msi: Remove WINAPI on static functions where not needed.
2008-11-28 12:54:37 +01:00
b1a54bf7a3
msi: Remove casts of void pointers.
2008-11-25 11:55:56 +01:00
3c533397e9
msi/tests: Skip tests on win9x by checking functionality instead of registry keys.
2008-11-17 13:16:08 +01:00
1dba41b104
msi/tests: Skip some tests on Win9x and WinMe.
2008-11-13 15:41:30 +01:00
b4874a8921
msi/tests: Fix some test failures on Win9x and WinMe.
2008-11-11 14:06:49 +01:00
7051bf5e22
msi: Remove an unused registry function.
2008-11-04 11:24:16 +01:00
e3074348fc
msi: Factor out the code to open the UserData features key.
2008-11-04 11:24:11 +01:00
0c01c586c7
msi: Factor out the code to open the features key.
2008-11-04 11:24:04 +01:00
70be1e7746
msi: Factor out the code to open a product key.
2008-11-04 11:23:51 +01:00
f12b9cea99
msi: Factor out the table insertion code.
2008-11-04 11:23:30 +01:00
2abb8bba13
msi: Factor out the table insertion code.
2008-11-04 11:23:07 +01:00
88f39d95f2
msi: Factor out the table insertion code.
2008-11-04 11:22:45 +01:00
4f199a10ad
Remove the remaining casts of NULL.
2008-11-03 13:42:09 +01:00
ca71e5aff0
msi: Allow private properties from the AdminProperties property list.
2008-10-30 11:47:10 +01:00
019f4af1c2
msi: Do not reinstall an assembly that already exists in the global assembly cache.
2008-10-29 13:29:32 +01:00
cec5d3f514
msi/tests: Fix a failing test on all platforms up to and including win2k.
2008-10-28 12:13:53 +01:00
c261030d21
msi: Skip the leading period of the extension to be registered.
2008-10-27 12:02:19 +01:00
2ffa433f80
msi: Convert command line property names to uppercase.
2008-10-27 12:02:13 +01:00
bf9538f383
msi: Use the long file name in the WriteIniValues action.
2008-10-27 12:02:04 +01:00
7616a750ba
msi: Set the source path tests to "interactive" to avoid timing out on some machines.
2008-10-27 12:01:57 +01:00
cd4b952863
msi: Fix several test failures.
2008-10-24 14:25:01 +02:00
acfc915914
msi: Fix a failing test in win9x.
2008-10-24 14:25:01 +02:00
f18c6ba28d
msi: Only compare the file version if a version was specified.
2008-10-22 13:54:53 +02:00
1c9886d6e7
msi: Sign-compare warnings fix.
2008-10-21 11:45:44 +02:00
40db5bdb16
msi: Sign-compare warnings fix.
2008-10-21 11:45:39 +02:00
03282df13d
msi: Use the quoted part of the registry value when searching for a file or directory.
2008-10-20 13:16:24 +02:00
6df69c6aaa
msi: Fix a copy and paste error.
2008-10-20 13:16:09 +02:00
7eba78dc7e
msi: Strip the file off the parent path if it's not a directory.
2008-10-20 13:16:04 +02:00
0ed516908b
msi: Only check the file signature if the candidate file is not a directory.
2008-10-20 13:15:36 +02:00
1fb22654e4
msi: Append the next directory to search to the current directory when recursing.
2008-10-20 13:11:14 +02:00
4aca381ff7
msi: Only append a backslash to directories.
2008-10-20 13:10:59 +02:00
7497f1ab5c
msi: Don't get rid of the file signature when searching the DrLocator table.
2008-10-20 13:10:54 +02:00
2e17638dc4
msi: Simplify and clean up ACTION_RecurseSearchDirectory.
2008-10-20 13:10:50 +02:00
29c0836fcc
msi: Handle searching for directories in the IniLocator part of the AppSearch action.
2008-10-20 13:10:44 +02:00
c48497d0e6
msi: Handle searching for a file with no signature.
2008-10-20 13:10:39 +02:00
326a1b6c47
msi: Add more tests for the RegLocator part of the AppSearch action.
2008-10-20 13:10:34 +02:00
859bd01b5e
msi: Check the file version when a version is provided in the signature.
2008-10-20 13:10:28 +02:00
fbba2e8b93
msi: Add more tests for the AppSearch action.
2008-10-20 13:10:19 +02:00
642cddf180
msi: Return the requested ini field.
2008-10-20 13:10:08 +02:00
f1e2041bf4
msi: Pass the correct view to get_row.
2008-10-20 13:09:59 +02:00
f80b5f6e66
msi: All files are uncompressed in an administrative image.
2008-10-17 11:44:21 +02:00
7620bb367f
msi: Append a backslash to the AppSearch registry path.
2008-10-16 11:22:43 +02:00
3adf1e4e0e
msi: Append a backslash to the AppSearch directory path.
2008-10-16 11:22:40 +02:00
47ac325f82
msi: Fix the returned format of REG_BINARY data.
2008-10-13 13:04:30 +02:00
6d02194a46
msi: Expand REG_EXPAND_SZ registry values in the RegLocator table.
2008-10-13 13:00:47 +02:00
65915af1ae
msi: Append the file signature to the component's directory when searching for the component's key path.
2008-10-13 13:00:42 +02:00
701c2a2728
msi: Add tests for the DrLocator part of the AppSearch action.
2008-10-13 13:00:37 +02:00
33c9e80be5
msi: Add tests for the RegLocator part of the AppSearch action.
2008-10-13 13:00:32 +02:00
3e76ade6c8
msi: Add tests for the IniLocator part of the AppSearch action.
2008-10-13 13:00:25 +02:00
41c8bc8ae6
msi: Add more tests for the CompLocator part of the AppSearch action.
2008-10-13 13:00:06 +02:00
87e21fe585
msi/tests: Clean up the binary.dat file.
2008-10-09 14:27:21 +02:00
68268dc3df
msi: Initialize the count variable to zero.
2008-10-09 13:01:31 +02:00
451aff9ae5
msi: Add extra constraints on the formatting string of edit path text.
2008-10-09 13:01:25 +02:00
1484c6272d
msi: Add a stub implementation of MsiDetermineApplicablePatches.
2008-10-09 13:01:18 +02:00
8128d97fd4
msi: Replace lengthy calls to MSI_DatabaseOpenView with MSI_OpenQuery.
2008-10-09 12:58:47 +02:00
f03889ae82
msi: Add initial implementation of MsiDatabaseMerge, with tests.
2008-10-09 12:58:25 +02:00
c9ec69db02
msi: Add tests for converting record fields between strings and ints.
2008-10-09 12:58:12 +02:00
b187008345
msi: Remove a part of a debugging statement that was accidentally left in.
2008-10-09 12:58:09 +02:00
704ebf280e
msi: Use the right FAILED/SUCCEEDED macro instead of negating the opposite.
2008-10-08 13:43:17 +02:00
e88b09a342
msi: Don't update the table columns if there are no more columns.
...
This should fix the heap corruption that caused intermittent crashes
for patchwatcher.
2008-10-07 12:14:03 +02:00
7cd6736886
msi: Add tests for dropping tables with multiple columns.
2008-10-07 12:13:52 +02:00
374c042880
msi: Remove the columns in reverse order.
2008-10-07 12:13:46 +02:00
aa230a6267
msi: Remove a break that kept other columns from getting the table name.
2008-10-07 12:13:39 +02:00
d15fddf6f5
msi: Resolve file source paths dynamically, as the source directory can be changed.
2008-10-07 12:13:33 +02:00
417134709d
msi: Added MsiInstallMissingComponentW stub implementation.
2008-10-07 12:12:54 +02:00
62c544cf4f
msi: Implement the DROP TABLE sql command.
2008-10-06 13:05:52 +02:00
48e6e584d3
msi: Fix a test that fails in win95.
2008-10-01 11:41:34 -05:00
4749ee2662
msi: Forward MsiDatabaseMergeA to MsiDatabaseMergeW.
2008-10-01 11:41:29 -05:00
525865447e
msi: Add a stub implementation of MsiDatabaseMerge.
2008-10-01 11:41:23 -05:00
628b8e7630
msi: Fix potential uninitialized use of substg.
2008-09-30 11:33:38 -05:00
3713720351
msi: Fix several test failures in win9x.
2008-09-29 17:24:17 -05:00
dd142bf5a7
msi/tests: Fix explicit C:\\Program Files\\ references.
2008-09-29 17:23:42 -05:00
e16e15bf0c
msi: Add stub for MsiSetExternalUIRecord.
2008-09-25 13:27:38 +02:00
88a5bdb858
msi: Remove redundant NULL check before SysFreeString.
2008-09-23 12:12:35 +02:00
67b06ecba5
msi/tests: Reduce buffer to size of string written.
2008-09-15 11:43:53 +02:00
2dfcb94211
msi/tests: Prevent a crash on NT4.
2008-09-15 11:23:42 +02:00
58ddb6f564
msi/tests: Create only one log file and delete it afterwards.
2008-09-11 11:43:09 +02:00
ef1b0cacfa
msi: Reduce destination file name used in the MoveFiles action to the long file name.
...
Add a test for this behaviour.
2008-09-10 12:08:52 +02:00
be759dddb8
msi: Uninitialized variable fix (Coverity).
2008-09-10 10:41:54 +02:00
d11968cade
msi: Fix a few file access discrepancies between platforms.
2008-09-09 11:46:17 +02:00
765275a306
msi: Make sure read-only source files are set writable after being copied.
2008-09-08 12:47:22 +02:00
8a9ba8f73f
msi: Actions should be run even if the installed state is the same as the requested state.
2008-09-08 12:47:22 +02:00
96412ee564
Annotate with allocation size attribute.
2008-09-05 11:22:26 +02:00
3f00006f1f
msi: Source for new patch files can only be compressed.
2008-09-04 11:52:21 +02:00
9eb3a9c157
msi: Add simplified and traditional Chinese resources.
2008-09-04 11:41:53 +02:00
e5fd83da6d
msi: Fix a failing test in Vista.
2008-09-03 13:14:51 +02:00
c559895ce9
msi/tests: Create a system restore point when needed.
2008-09-02 13:28:23 +02:00
4bc832c29a
msi/tests: Add a missing CoUninitialize.
2008-09-02 13:27:46 +02:00
f40890c940
msi: Add tests for opening an empty package.
2008-08-29 13:26:33 +02:00
d880470dbf
msi: Handle converting a value of REG_DWORD in MsiSourceListEnumMediaDisks.
2008-08-29 13:26:25 +02:00
dd0ec9f811
msi/tests: Remove service tests.
2008-08-28 11:03:42 +02:00
4b9fd1d5e2
msi: Store the _Columns and _Tables tables in the database structure.
2008-08-25 11:40:46 +02:00
3bec162d51
msi: Skip the component action detection logic if there is no product code.
2008-08-25 11:40:38 +02:00
d596ae29d8
msi: Skip the feature action detection logic if there is no product code.
2008-08-25 11:40:30 +02:00
c855fbfcd8
msi: Don't install a feature that is disabled.
2008-08-25 11:40:22 +02:00
9288055beb
msi: Only set the action to source if the component has a local feature.
2008-08-25 11:40:15 +02:00
3807a91739
msi: Fix the logic to determine the appropriate action of the feature.
2008-08-25 11:40:09 +02:00
63064f7a45
msi: Handle features installed as source in MsiQueryFeatureState.
2008-08-25 11:40:02 +02:00
472b991958
msi: Don't remove a misc file if the action is unknown.
2008-08-21 11:44:39 +02:00
7c9873e471
msi: Fix the logic to determine the appropriate action of the component.
2008-08-21 11:44:27 +02:00
f909e1c06e
msi: Don't remove a file that is installed as source.
2008-08-21 11:44:19 +02:00
4553d0fd47
msi: Remove an invalid setting of the install state.
2008-08-21 11:44:13 +02:00
39b874706c
msi: Handle components installed as source in MsiQueryComponentState.
2008-08-21 11:44:05 +02:00
b965a74ef2
msi: Downgrade an ERR to a TRACE.
2008-08-21 11:43:58 +02:00
7b858882ac
msi: If the filename is empty or NULL, remove the directory.
2008-08-21 11:43:51 +02:00
96dd6ce167
msi: Handle processing a component that is installed to source.
2008-08-21 11:43:44 +02:00
5a3c3b6a12
msi: Use MsiQueryFeatureState to determine the feature's state.
2008-08-19 13:56:08 +02:00
42115638c8
msi: Use MsiQueryComponent state to determine the component's state.
2008-08-19 13:56:04 +02:00
10a2a5effe
msi: Base removal of a file on the component's action, not the file's state.
2008-08-19 13:56:01 +02:00
7fbce31ef7
msi: Add more tests for feature and component states.
2008-08-19 13:55:58 +02:00
5ea0d9d807
ole32: Storage sharing should be implemented in ole32, not the lower-level file API.
2008-08-19 13:55:53 +02:00
0e6bfb3b43
msi: Test the file access and share modes of MsiOpenDatabase.
2008-08-19 13:39:51 +02:00
e64a699b07
msi: Remove misc files from the RemoveFile table.
2008-08-19 13:39:40 +02:00
a00bdc1178
msi: A file's component's state does not determine file removal.
2008-08-19 13:39:30 +02:00
f33ef6ac3b
msi: Don't remove a file if the old file is strictly newer than the version to be installed.
2008-08-19 13:39:19 +02:00
ca4b17efe8
msi: Don't check for a NULL component, as the component is guaranteed to exist.
2008-08-19 13:39:11 +02:00
9a8d2f3f5c
msi: Ignore a file that has a missing component.
2008-08-19 13:39:02 +02:00
74239fcd91
msi: Factor out media handling and use the new interface to efficiently extract assemblies.
2008-08-19 13:37:51 +02:00
bf51518449
msi: Perform costing again for the InstallExecute sequence.
2008-08-19 13:36:32 +02:00
d9f2120f14
msi: Ignore all non-stream elements when filling the _Streams table.
2008-08-19 13:36:25 +02:00
cda469c890
msi: Fix handle leak in ITERATE_SelfRegModules.
2008-08-18 17:34:12 +02:00
6e63953b4c
msi: Also check the LocalPackage install property when searching for the product package.
2008-08-18 17:15:46 +02:00
d500dc4f31
msi: Test how MsiConfigureProductEx locates the source package.
2008-08-18 17:04:53 +02:00
92ed390b28
msi: Change an ERR that was supposed to be a TRACE.
2008-08-05 14:09:34 +02:00
8782fdba1b
msi: Add a stub implementation of MsiEnumPatchesEx.
2008-08-04 13:04:30 +02:00
68e6be45e1
msi: Add tests for MsiOpenProduct.
2008-07-31 13:04:44 +02:00
9b426be0ee
msi: Reimplement MsiOpenProduct.
2008-07-31 13:04:36 +02:00
469e4a5c94
msi: Directly register the typelib if it's not embedded in a PE module.
2008-07-29 12:20:19 +02:00
dfec94c157
msi: Add tests for MsiConfigureProductEx.
2008-07-29 12:20:11 +02:00
cbf32ff28a
msi: Set the ALLUSERS property for the machine context.
2008-07-29 12:20:03 +02:00
0b240c7aa3
msi: Handle the INSTALLSTATE_ABSENT state in MsiConfigureProductEx.
2008-07-29 12:19:57 +02:00
9518d7f8c7
msi: Properly locate the published product in MsiConfigureProductEx.
2008-07-29 12:19:51 +02:00
ac976c94c8
msi: Validate the szProduct parameter of MsiConfigureProductEx.
2008-07-29 12:19:44 +02:00
38106ac230
msi: Handle the package context when unpublishing the product.
2008-07-29 12:19:37 +02:00
396eea6006
msi: Determine the source path based on the short/long file names bit of the Word Count summary property.
2008-07-22 13:10:56 +02:00
ede4a3b598
msi: Set all folders' source paths to the root directory if the source type is compressed.
2008-07-22 13:10:45 +02:00
7538f9ac19
msi: Use the newly added defines from the msidbSumInfoSourceType enumeration.
2008-07-22 13:10:38 +02:00
36f282b0b1
msi: Test mixing short and long source paths when installing a file.
2008-07-22 13:10:31 +02:00
64a9e0f750
msi: msidbFileAttributesVital has no effect on the installation of files.
2008-07-22 13:10:21 +02:00
4e467ad729
msi: Halt the installation with an error if a source file is missing.
2008-07-22 13:10:12 +02:00
27ce47a263
msi: Test getting the source path from a package with short file names.
2008-07-22 13:10:00 +02:00
e806a285ef
msi: Test getting the source path from a package with compressed files.
2008-07-22 13:09:51 +02:00
45f9cb4d62
msi: Add more tests for MsiGetSourcePath.
2008-07-22 13:09:44 +02:00
4cacdc7dba
msi: Initialize the update function pointer when creating the control.
2008-07-18 11:15:38 +02:00
014b96ef15
msi: Added Session::Message implementation.
2008-07-17 11:36:22 +02:00
0f75796a28
msi: Remove unneeded address-of operators from array names.
2008-07-11 14:06:19 +02:00
1fed032a43
msi: Only copy the resulting string if the RegistryValue call succeeded.
2008-07-09 10:44:59 +02:00
1ed12b76e1
msi: Add tests for opening a package from a database.
2008-07-09 10:44:54 +02:00
79c64acc7b
tests: Don't depend on the static uuid libraries in the tests.
...
This avoids trouble with the broken MingW libraries when
cross-compiling the tests.
2008-07-08 17:51:45 +02:00
e59b3fa864
msi: Consolidate and add more SourceDir tests.
2008-07-08 10:55:05 +02:00
26ae658986
msi: Only use the long filename when resolving the source path.
2008-07-08 10:55:01 +02:00
44bfb9911b
msi: Consolidate the MsiGetSourcePath tests and add more tests.
2008-07-08 10:54:58 +02:00
ca4758201d
msi: Parse the MSIDBOPEN_PATCHFILE flag.
2008-07-08 10:50:11 +02:00
ccd030c7d3
msi: Add handling for the special _Storages table.
2008-07-08 10:50:04 +02:00
ae9b579135
msi: Properly add a storage to the database and verify its contents.
2008-07-08 10:48:33 +02:00
d9ac95be5b
msi: Test the special _Storages table.
2008-07-02 12:04:08 +02:00
c9969780bc
msi: Correct spec file entry for MsiGetFileVersion{A, W}.
2008-06-30 15:09:12 +02:00
89a8cfdb53
msi: Don't overwrite a file that has a greater or equal version to the source file.
2008-06-25 20:28:52 +02:00
6056fd1b05
msi: Add another MsiGetFileVersionTest.
2008-06-25 10:43:02 +02:00
0097275f3f
msi: Add tests for MsiGetUserInfo.
2008-06-24 12:16:01 +02:00
41fe12f149
msi: Reimplement MsiGetUserInfo.
2008-06-24 12:15:48 +02:00
72fedf7d88
msi: Handle the machine context in MsiQueryFeatureState.
2008-06-24 12:15:38 +02:00
200eba3b94
msi: Handle the user managed context in MsiQueryFeatureState.
2008-06-24 12:15:31 +02:00
aefd63dc4e
msi: Add more tests for MsiQueryFeatureState.
2008-06-24 12:15:23 +02:00
2d4e4b6ae2
msi: Create the SourceList key in msi_publish_sourcelist.
2008-06-24 12:15:16 +02:00
58e1543960
msi: Fix the published location of the upgrade code for the machine context.
2008-06-24 12:15:10 +02:00
301f2a5eae
msi: Open the local user data product key for the machine context.
2008-06-24 12:15:03 +02:00
e6d126cd49
msi: Test the PublishProduct action with the machine context.
2008-06-24 12:14:56 +02:00
cdb33f8a39
msi: Publish the UpgradeCode in PublishProduct.
2008-06-24 12:14:49 +02:00
5538fa0290
msi: Publish media disks whether the drive type is removable or not.
2008-06-24 12:14:42 +02:00
ef640a6cd5
msi: Publish a few more product properties.
2008-06-24 12:14:36 +02:00
c7ab4fad08
msi: Allow checking a REG_MULTI_SZ string.
2008-06-24 12:14:30 +02:00
db2e8d2fdf
msi: Squash the package code property.
2008-06-24 12:14:23 +02:00
ebeb537939
msi: Factor out publishing the product properties.
2008-06-24 12:14:14 +02:00
d809b4e2d9
msi: Don't publish the product to an invalid location.
2008-06-24 12:14:07 +02:00
ee8b4a0132
msi: Don't set an invalid install property in PublishProduct.
2008-06-24 12:14:00 +02:00
68e6071d3c
msi: Factor out publishing the product source list.
2008-06-24 12:13:53 +02:00
fac97bb8c5
msi: Factor out publishing icon files.
2008-06-24 12:13:46 +02:00
bb8d253ecc
msi: Rewrite the PublishProduct test to only check the registry changes.
2008-06-19 12:34:36 +02:00
c0f8bfd2dd
msi: Test the RegisterProduct action with the machine context.
2008-06-19 12:34:29 +02:00
45de896a3d
msi: Factor out the publishing of installation properties.
2008-06-19 12:34:23 +02:00
b635e3170f
msi: Don't publish the upgrade key to an invalid location.
2008-06-19 12:34:15 +02:00
2194889d5d
msi: Rewrite the RegisterProduct test to only check the registry changes.
2008-06-19 12:34:04 +02:00
2a180e060a
msi: Fix the PublishFeatures action to handle the package context.
2008-06-19 12:33:55 +02:00
61daa613dd
msi/tests: Fix some test failures.
...
Results on test.winehq.org show failures for at least Vista as new
DISPID's are known there.
2008-06-19 11:55:05 +02:00
af56e28f7e
msi: Don't publish features to an invalid location.
2008-06-18 16:24:09 +02:00
d8e4258d08
msi: Rewrite the PublishFeatures test to only check the registry changes.
2008-06-18 16:24:05 +02:00
5f46dfd698
msi: Fix the RegisterUser action to handle the package context.
2008-06-18 16:24:01 +02:00
79d0c3719f
msi: Rewrite the RegisterUser test to only check the registry changes.
2008-06-18 16:23:57 +02:00
288af81a7c
msi: Fix the ProcessComponents action to handle the package context.
2008-06-18 16:23:27 +02:00
5f11262da9
msi: Determine the installation context after reading properties from the command line.
2008-06-18 16:23:22 +02:00
4aa3a997f8
msi: Don't publish components to the Installer key.
2008-06-18 16:23:18 +02:00
073d55e73b
msi: Rewrite the ProcessComponents test to only check the registry changes.
2008-06-18 16:17:56 +02:00
d3cc801da1
msi: Set the source path for uncompressed files when loading the file.
2008-06-11 11:27:15 +02:00
dbbd5ca736
msi: Load folders first.
2008-06-11 11:26:55 +02:00
ad2c9211bc
msi/tests: Cleanup registry after test.
2008-06-11 11:26:22 +02:00
a302ec645c
msi/tests: Initialize buffer lengths before calling MsiSourceListEnumMediaDisks.
2008-06-06 10:28:35 +02:00
ecfa0fbcea
msi: MsiSourceListEnumMediaDisksW: free original string, not substring.
2008-06-04 12:53:25 +02:00
76d6b76737
msi: Mark some data as constant.
2008-05-26 19:46:09 +02:00
77d259f46c
msi: Search the last used source if the cabinet to extract cannot be found.
2008-05-22 11:30:54 +02:00
70cd6bfbbd
msi: Check that the file key is valid before installing the assembly.
2008-05-20 15:43:54 +02:00
14a42f802d
Make Swedish use SUBLANG_NEUTRAL.
2008-05-19 16:09:13 +02:00
95282bdeaa
msi: Reset the hasLocalFeature flag when updating components.
2008-05-19 13:36:45 +02:00
6221975407
msi: Don't enable a feature's components if that feature is disabled.
2008-05-19 13:36:37 +02:00
69c02d0b03
msi: Create the MSI hidden window on demand.
2008-05-14 21:51:10 +02:00
ece5a047de
msi: Set the OutOfDiskSpace property.
2008-05-14 12:22:01 +02:00
9460ae35b5
msi: Copy the assembly file directly if it's not compressed.
2008-05-14 12:21:54 +02:00
7ae4f695bc
msi: Convert string variables to ints when appropriate.
2008-05-13 10:44:22 +02:00
ca8e867da7
msi: Test the ScreenX/Y properties.
2008-05-13 10:43:55 +02:00
b74ee6fbcd
msi: Danish translation.
2008-05-07 12:08:58 +02:00
633ee950a1
Assorted spelling fixes.
2008-05-07 12:07:11 +02:00
d2364d5d27
Add a comment warning when a table must be kept sorted for later use with bsearch().
2008-05-06 16:11:09 +02:00
42a61d7ed7
Assorted spelling fixes.
2008-05-06 16:10:20 +02:00
6d91fd8ce6
msi: Use the handle to the treeview item if the item text is not returned.
2008-05-05 13:34:05 +02:00
02b531b302
msi: Fix a typo.
2008-05-05 12:54:00 +02:00
33c3bdeb03
msi: A progid who is its own parent cannot have a clsid.
2008-05-02 11:33:28 +02:00
dad21bbcbf
makefiles: List the static libraries as normal imports instead of extra libs.
2008-04-30 14:23:55 +02:00
bfe07d1d07
msi: Add initial implementation of MsiPublishAssemblies.
2008-04-30 13:45:23 +02:00
ef07d83405
Include wine/port.h everywhere we use exceptions.
2008-04-29 20:18:49 +02:00
f2189d17b0
msi: Remove a debugging call.
2008-04-28 12:27:09 +02:00
8ebe988d2e
Add makedep magic comments for typelibs in resource files.
2008-04-24 22:14:21 +02:00
06bf8ea291
msi: Avoid creating zero-length string values in the registry.
2008-04-22 17:05:05 +02:00
68975938f6
msi: Remove unused variables.
2008-04-22 11:54:38 +02:00
a5d15b3b60
msi: Fix a few tests that fail in win9x.
2008-04-21 13:20:12 +02:00
4a75b8bf09
msi: Fix the value parameter of IWineMsiRemotePackage::FormatRecord to have the right level of indirection for an [out] parameter.
...
Remove the redundant size parameter and simplify the client code such
that the remote function is only called once, with the value being
automatically allocated. Add corresponding code on the server side to
automatically allocate said value.
2008-04-17 11:39:37 +02:00
5644f05edf
msi: Spelling fixes.
2008-04-08 12:25:13 +02:00
04a740efc4
msi: Added Slovenian translation.
2008-04-07 21:39:59 +02:00
4d9c17da02
msi: Don't execute the view again when modifying a WHERE query.
2008-04-07 11:27:39 +02:00
bcba82dc0c
msi: Open the install properties key based on the install context.
2008-04-07 11:27:30 +02:00
e21a26e47b
msi: Test and reimplement MsiQueryProductState.
2008-04-07 11:27:24 +02:00
85866317c5
msi: Don't reorder the table when matching rows as the results are already ordered.
2008-04-07 11:27:15 +02:00
82517d6d67
msi: Set the install context based on the ALLUSERS property.
2008-04-07 11:27:10 +02:00
30c1b88828
msi: Reset the feature states if iInstallLevel is 0 or below.
2008-04-07 11:26:54 +02:00
405b31aa96
msi: Updated Korean resource.
2008-04-04 12:02:27 +02:00
9e85ec3bad
msi: Remove tentative declaration of static array with no size specifier.
2008-04-04 11:04:20 +02:00
061085fa94
msi: Fix joining a nonexistent table with another table.
2008-04-03 11:30:01 +02:00
c48daf93bb
msi: Downgrade a few messages to WARN.
2008-04-03 11:29:58 +02:00
a7d02a1f08
msi: Handle the case where no files match the wildcard in MoveFiles.
2008-04-03 11:29:53 +02:00
bed661aef4
msi: Handle sorting an empty table.
2008-04-02 12:31:01 +02:00
ddfefc036f
msi: Fix a typo.
2008-03-25 11:44:57 +01:00
fb508ff8fa
msi: Implement the StopServices action.
2008-03-24 11:39:47 +01:00
fdd55977bc
msi: Don't hardcode the root drive.
2008-03-24 11:39:29 +01:00
9048ecef83
msi: INSTALLPROPERTY_AUTHORIZED_LUA_APP is only available with msi >= 3.0.
2008-03-24 11:38:36 +01:00
d69342cd67
msi: Initialize the size parameter.
2008-03-24 11:38:30 +01:00
01316db0ce
msi: Remove the dependence on compressed cabinets in the install tests.
2008-03-21 11:24:11 +01:00
5bec7d4bbf
msi: Don't trace the tables names on import.
2008-03-20 14:27:35 +01:00
efc56634fa
msi: Fix the registry root indices for Installer::RegistryValue.
2008-03-20 14:27:35 +01:00
05af003fc1
msi: Fix a few failing tests on win9x.
2008-03-20 14:27:35 +01:00
0b98ce8ff5
msi: Clean up the db when skipping the tests.
2008-03-20 14:27:35 +01:00
a9ebec9849
msi: win95 returns ERROR_BAD_PATHNAME.
2008-03-20 14:27:35 +01:00
e94b065df3
msi: Fix the type of the ID parameter of MsiSourceListEnumMediaDisks.
2008-03-20 14:27:35 +01:00
73f0b3c39b
msi/tests: Skip the tests if we are unable to identify the user SID. This fixes crashes on Win9x.
2008-03-19 11:21:23 +01:00
ecc948ab48
msi: Fix a few test failures on win9x.
2008-03-18 11:15:57 +01:00
afb575d599
msi: Fix a few test failures on win9x.
2008-03-18 11:15:53 +01:00
669122fdfe
msi: Fix a few test failures on win9x.
2008-03-18 11:15:49 +01:00
c1e3f831ec
msi: Skip the Installer object tests on win9x.
2008-03-18 11:15:45 +01:00
55365b77d7
msi: Fix a few tests of display IDs that don't exist on win9x.
2008-03-18 11:15:40 +01:00
97f1afbd3b
msi: Skip the endlines test if the table fails on import.
2008-03-18 11:15:34 +01:00
5e5c4a9809
msi: Don't publish the product for the custom action test.
2008-03-15 11:02:50 +01:00
db71fb15aa
msi: Initialize variables.
2008-03-14 11:21:22 +01:00
65f99ed91b
msi: Test and fix MsiSourceListAddSource.
2008-03-13 11:36:24 +01:00
58130dde08
msi: Passing NULL for szBuffer and NULL for pcchValueBuf into MsiGetProductInfo{A, W} shouldn't crash.
...
Add a test for this.
2008-03-12 19:21:27 +01:00
dd31a1eac4
msi: Fix typos which caused joins of three or more tables to not work properly.
...
In JOIN_fetch_int and JOIN_fetch_stream, prev_rows should be multiplied
by the rows encountered in the current table so that prev_rows contains
all of counts of the rows encountered multiplied together, rather than
just the count of the rows in the last table encountered.
2008-03-12 19:21:19 +01:00
de4cab20a8
msi: Deformat the service name and display name when installing the service.
2008-03-12 12:00:23 +01:00
2d0ff97406
msi: Ignore the custom action type 51 if the source field is empty.
2008-03-11 12:12:24 +01:00
776a7d7065
msi: Fix an off-by-one error when applying embedded transforms.
2008-03-11 12:12:14 +01:00
5871bee8c7
msi: Optimize MsiSourceListAddSourceEx for adding to the end of the list.
2008-03-11 12:12:07 +01:00
6661f43438
msi: Assign to structs instead of using memcpy.
2008-03-07 11:01:07 +01:00
d52f48fed4
msi: Fix handling of published installer properties.
2008-03-07 10:52:46 +01:00
be874f1a26
msi: Fix bug in handling of multivolume CAB files.
2008-03-07 10:52:11 +01:00
c8acf21e0c
msi: Break out the publishing tests into their respective actions.
2008-03-06 16:24:39 +01:00
2c22e9aeb6
msi/tests: Make tests run on win9x/NT4 again.
2008-03-05 11:21:56 +01:00
48000893f9
makefiles: Simplify the use of the IMPORTLIB variable in the DLL makefiles.
...
Only specify the root to keep platform-specifics out of the individual
DLL makefiles.
2008-03-04 20:55:01 +01:00
4609eccd72
msi: Add tests for MsiGetProductInfoEx.
2008-03-04 11:54:21 +01:00
ad70693539
msi: Implement MsiGetProductInfoEx.
2008-03-04 11:54:21 +01:00
0c3ecefbc3
msi: Include query.h to pull in the definition of STREAMS_CreateView.
2008-03-01 12:18:54 +01:00
6febb8fda8
msi: Remove a pointless wrapper of RegCreateKey.
2008-03-01 12:18:43 +01:00
4439e0b57d
msi: Make local functions static.
2008-03-01 12:18:40 +01:00
617eb48d5b
msi: Implement the UILevel property of the Installer object.
2008-03-01 12:18:24 +01:00
724c8da734
msi: Don't bail out if the row to modify is not found as not all modify commands need the row.
2008-03-01 12:17:31 +01:00
eedfacdfe7
janitorial: Remove links to any microsoft site.
2008-03-01 12:04:03 +01:00
848383ac82
msi/tests: Replace a printf() by a trace().
2008-02-29 20:55:42 +01:00
174b7b51ac
msi: Update controls based on a property when that property changes.
2008-02-28 10:59:22 +01:00
5e2bc5b3fe
msi: If a feature's action is INSTALLSTATE_UNKNOWN, MsiEvaluateCondition should return MSICONDITION_FALSE.
2008-02-28 10:59:16 +01:00
eb836b718f
msi: Initialize type (Coverity).
2008-02-28 10:50:57 +01:00
3183ad65d2
msi: Fix buffer size calculation in build_default_format.
2008-02-28 10:44:11 +01:00
03e466b837
msi: Fix the buffer size calculation in msi_build_createsql_prelude.
2008-02-28 10:44:06 +01:00
9101665233
msi: Change the property variant if the types don't match.
2008-02-27 14:52:26 +01:00
1bbac341df
msi/tests: Fix test that depends on the order of the files in a directory.
2008-02-27 14:52:25 +01:00
6b37543adc
msi/tests: Skip tests that contain functions that are not available.
2008-02-27 14:52:24 +01:00
ecf8c5af36
msi/tests: Skip tests for functions that are not available.
2008-02-27 14:52:24 +01:00
e7937f3cd5
msi/tests: Make sure tests will run on Win9x and NT.
2008-02-27 14:52:24 +01:00
bdbb7a0348
msi: Search existing published sources if the media cannot be found.
2008-02-26 11:20:46 +01:00
cf84e2df5b
msi: Allow setting a media disk as the last used source in the internal msi_set_last_used_source.
2008-02-26 11:20:35 +01:00
7d10d1d2d0
msi: Store the media type and set the last used source type accordingly.
2008-02-26 11:20:27 +01:00
6e2048bbc7
msi: Read the source list properties from the user-unmanaged context.
2008-02-26 11:20:18 +01:00
acfed4cfab
msi: Read the disk prompt source list property from the user-unmanaged context.
2008-02-26 11:20:13 +01:00
d62bd166dc
msi: Remove setting a source list property that's in the wrong place.
2008-02-26 11:20:07 +01:00
4d2cf7a44b
msi: Publish source information in the user-unmanaged context.
2008-02-26 11:20:02 +01:00
7e8cd606a0
msi: Add tests for MsiSourceListEnumMediaDisks.
2008-02-26 11:19:45 +01:00
1bd49bcf74
msi: Implement MsiSourceListEnumMediaDisks.
2008-02-26 11:19:40 +01:00
45d7d6a4e1
msi: Fix skipping a NULL record.
2008-02-26 11:19:29 +01:00
89c8e795d8
msi/tests: Make tests run on win9x/NT4 again.
2008-02-25 19:49:54 +01:00
21b4af1b46
msi: Fix and simplify handling of REG_MULTI_SZ strings in the WriteRegistryValues action.
2008-02-25 12:22:16 +01:00
b532c0c306
msi: Simplify MsiSourceListAddMediaDisk.
2008-02-25 12:22:09 +01:00
d3b3738567
msi: Remove invalid fixmes.
2008-02-25 12:22:03 +01:00
08172ad1c4
msi: Return the result of the call to OpenSourceKey.
2008-02-25 12:21:58 +01:00
34d50c1e3e
msi: Validate the parameters of MsiSourceListAddMediaDisk.
2008-02-25 12:21:51 +01:00
1fced5cc1d
msi: Add tests for MsiSourceListAddMediaDisk.
2008-02-25 12:21:42 +01:00
8b540d2670
msi: Fix the INSTALLPROPERTY_LASTUSEDTYPE case.
2008-02-25 12:21:19 +01:00
737dedfcbb
msi: Fix the INSTALLPROPERTY_LASTUSEDSOURCE case.
2008-02-25 12:20:56 +01:00
d41cae07d5
msi: Factorize and fix the INSTALLPROPERTY_MEDIAPACKAGEPATH case.
2008-02-25 12:20:48 +01:00
f178985db3
msi: Simplify the check for a valid product code.
2008-02-25 12:20:39 +01:00
868de4d56b
msi: Add more tests for MsiSourceListGetInfo.
2008-02-25 12:20:33 +01:00
88c7c2c7a1
msi: Fix the size of the data sent in to RegSetValueExW.
2008-02-22 12:11:16 +01:00
e43eee8759
msi: Fix the INSTALLPROPERTY_LASTUSEDSOURCE case of MsiSourceListSetInfo.
2008-02-21 12:53:00 +01:00
6c7339eea1
msi: Allow enumerating the sources without querying the source name.
2008-02-21 12:53:00 +01:00
3de0014750
msi: Publish a few SourceList properties.
2008-02-21 12:53:00 +01:00
2d5ba8d20d
msi: Implement MsiSourceListEnumSources.
2008-02-21 12:53:00 +01:00
55b470545f
msi: Forward MsiSourceListEnumSourcesA to a stub implementation of MsiSourceListEnumSourcesW.
2008-02-20 12:07:10 +01:00
db70edfc82
msi: Remove unused parameter to msi_comp_find_prodcode().
2008-02-19 18:08:38 +01:00
6bf0f0e1f6
msi: Adjust the signedness of three variables.
2008-02-19 18:08:28 +01:00
123602df78
msi: Remove invalid FIXMEs.
2008-02-19 13:39:25 +01:00
7cf6be8aeb
msi: Return ERROR_INVALID_PARAMETER if the context is machine and szUserSid is non-NULL.
2008-02-19 13:39:25 +01:00
4ee1745e81
msi: Validate the dwOptions parameter of MsiSourceListSetInfo.
2008-02-19 13:39:25 +01:00
95ef6a1fbc
msi: Simplify the MEDIAPACKAGEPATH and DISKPROMPT cases.
2008-02-19 13:39:25 +01:00
fe987103fb
msi: Return the results from OpenSourceKey.
2008-02-19 13:39:25 +01:00
d37ac289db
msi: Return ERROR_UNKNOWN_PATCH if dwOptions contains MSICODE_PATCH.
2008-02-19 13:39:25 +01:00
f83d049888
msi: Validate the szProduct parameter of MsiSourceListSetInfo.
2008-02-19 13:39:25 +01:00
10be16f33a
msi: Add tests for MsiSourceListSetInfo.
2008-02-19 13:39:25 +01:00
4a7bedfe75
msi: Use 'HKCU\Software\Microsoft\MS Setup (ACME)' as a source for the default user and company names before falling back to the RegisteredXXX values. Fix the conformance test accordingly.
2008-02-19 13:39:24 +01:00
9b5d3677df
msi: Remove some unused functions.
2008-02-19 13:39:24 +01:00
9d0ae904d0
msi: Add tests for MsiSourceListEnumSources.
2008-02-18 12:41:37 +01:00
f177dc9f90
msi: Add tests for enumerating the source list after publishing.
2008-02-18 12:41:37 +01:00
40aa7df344
msi: Implement the MSIMODIFY_REFRESH command of MsiViewModify.
2008-02-18 12:41:37 +01:00
30e5321867
msi: Add tests for the MSIMODIFY_REFRESH command.
2008-02-18 12:41:37 +01:00
bbdf79bc8c
msi: Convert REG_DWORD properties to strings in MsiGetProductInfo.
2008-02-18 12:41:37 +01:00
8412a1363b
msi: Set the UserLanguageID property.
2008-02-18 12:41:37 +01:00
85fbdfcc9e
msi: Fix the character count passed into RegSetValueExA in test_MsiQueryFeatureState.
2008-02-18 12:41:36 +01:00
11b25a65ac
msi: Fixed error reporting of add_streams_to_table.
2008-02-16 15:15:26 +01:00
4c105b2f5c
msi/tests: Services are not available on win9x.
2008-02-15 11:07:19 +01:00
e35bd05082
msi: Add stub implementation of MsiIsProductElevatedA/W.
2008-02-15 09:59:59 +01:00
050fa6a40c
msi: Add tests for source folder resolution.
2008-02-13 16:41:14 +01:00
ec086f77e3
msi: Handle carriage returns in MsiDatabaseImport.
2008-02-12 22:59:53 +01:00
00cfd2899b
msi: Use MsiViewModify instead of building a SQL query when adding rows to the table.
2008-02-12 22:59:46 +01:00
4cc569cce6
msi: Read the language info from the file.
2008-02-12 22:59:37 +01:00
1f3d6a9744
msi: Reimplement MsiGetProductInfo.
2008-02-12 22:59:29 +01:00
f461a8d4c1
msi: Test the remaining installer properties returned by MsiGetProductInfo.
2008-02-11 20:55:03 +01:00
ff0dc44f2d
msi: Return ERROR_INVALID_PARAMETER if szProduct is invalid.
2008-02-11 20:53:13 +01:00
33c1e6ef56
msi: Add tests for MsiGetProductInfo.
2008-02-11 20:47:52 +01:00
0d56df214b
msi: Successfully return an empty string when requesting a record index beyond the record's size.
2008-02-11 20:45:24 +01:00
2750ed167f
msi: Don't check for the existence of the msi package when running a concurrent install.
2008-02-11 20:45:17 +01:00
a8d87a86cc
msi: Handle the special table _ForceCodepage in MsiDatabaseExport.
2008-02-11 20:42:29 +01:00
7d529228d3
msi: Add tests for not using quotes in SQL queries.
2008-02-11 20:42:19 +01:00
2e6ec39565
msi/tests: Fix test that depends on the order of the files in a directory.
2008-02-11 20:41:40 +01:00
d89ee5fdd6
msi: Test using carriage returns in SQL queries and imported tables.
2008-02-07 12:09:10 +01:00
41848c828b
msi: Fix "type of 'x' defaults to 'int'" warnings.
2008-02-06 11:36:04 +01:00
2f658cb337
msi: Fix handling of the NULL separator when writing registry values.
2008-02-05 12:21:23 +01:00
5a0d459cc4
msi: Reimplement MsiFormatRecord.
2008-02-05 12:19:37 +01:00
e618c6d115
msi: Add more tests for MsiFormatRecord.
2008-02-05 12:19:37 +01:00
ffc251f5dd
msi: Return ERROR_MORE_DATA if the size is too small.
2008-02-05 12:19:37 +01:00
dc8f714ade
msi: Return the string length even if the string is NULL.
2008-02-05 12:19:37 +01:00
40841946f5
msi: Leave room for the NULL terminator.
2008-02-05 12:19:37 +01:00
d165435048
msi: Return ERROR_FILE_INVALID if the file has no version information.
2008-02-05 12:19:37 +01:00
03335de8d0
msi: Return ERROR_INVALID_PARAMETER if a string pointer is non-NULL and the size pointer is NULL.
2008-02-05 12:19:37 +01:00
856800c84b
msi: Translate ERROR_BAD_PATHNAME into ERROR_FILE_NOT_FOUND.
2008-02-05 12:19:37 +01:00
5d46eeac75
msi: Only convert output strings if the call succeeded.
2008-02-05 12:19:36 +01:00
8079d9f2ab
msi: Add tests for MsiGetFileVersion.
2008-02-05 12:19:36 +01:00
146e34e662
msi: Implement the MSIMODIFY_ASSIGN action of MsiViewModify for the streams table.
2008-02-05 12:19:36 +01:00
56574c7c6e
msi: Add tests for using single quotes in an INSERT query.
2008-02-05 12:19:36 +01:00
46f1330e02
msi/tests: Only use functions if they are implemented.
2008-01-24 12:08:44 +01:00
3272fef91a
msi/tests: Only use functions if they are implemented.
2008-01-24 12:08:39 +01:00
1868abda89
msi: Add more MsiFormatRecord tests.
2008-01-21 11:51:20 +01:00
943ac9795b
msi: Replaced msi_free() by LocalAlloc() since ConvertSidToStringSidW uses LocalAlloc().
...
Spotted by Christoph von Wittich <Christoph@ApiViewer.de>.
2008-01-21 11:51:08 +01:00
007833f130
msi: Fix process token leak.
2008-01-21 11:39:37 +01:00
44b52b128c
Assorted spelling fixes.
2008-01-16 12:48:29 +01:00
ced64861f5
msi: dest_path refers to the directory prefix, not the entire file path.
2008-01-16 12:16:43 +01:00
62c59deaa1
msi/tests: Tweaked so it does not look like things are misspelled.
2008-01-11 12:25:44 +01:00
388edd1086
msi: Complete initializers.
2008-01-10 13:20:15 +01:00
4b75f33012
msi: Actually delete the row data instead of blanking it out.
2008-01-09 13:38:02 +01:00
419a8a2426
msi: Test committing a table with a removed row.
2008-01-09 13:38:02 +01:00
ce8199a46e
msi: Handle markers in the WHERE section of an UPDATE query, with tests.
2008-01-09 13:38:02 +01:00
63c5e152a1
msi: Fix memory leaks (found by Smatch).
2008-01-07 13:46:06 +01:00
5352d099b4
msi: Create parent directories when duplicating files if they don't exist, with tests.
2008-01-07 12:16:56 +01:00
837588c6a3
msi: Pad the month and day to two digits.
2008-01-07 12:16:45 +01:00
d316a94ecb
msi: Remove an erroneous table.
2008-01-07 12:16:30 +01:00
c37849ad82
msi: Copy the temporary package when storing the installer.
2008-01-07 12:16:15 +01:00
e28cedf698
msi: Check the local package for existence when resolving the package source.
2008-01-07 12:16:04 +01:00
b012c3366c
msi: Directly download mi->source now that SourceDir points to the URL.
2008-01-07 12:15:56 +01:00
186487663a
msi: OriginalDatabase can be a URL so check for a forward slash too.
2008-01-07 12:15:48 +01:00
062070bfbe
msi: SourceDir is formed from the path of OriginalDatabase.
2008-01-07 12:15:27 +01:00
781e19aa4c
msi: OriginalDatabase is the fully-expanded path to the original package if the package is local and installed from the command line.
2008-01-07 12:15:16 +01:00
c777d3095a
msi: Factor out msi_set_sourcedir_props.
2008-01-07 12:15:10 +01:00
4121c9bbc6
msi: If the package is a URL, the OriginalDatabase property should be the URL and the DATABASE property should be the path to the local temporary package.
2008-01-07 12:15:01 +01:00
31c461ea5b
msi: WriteEnvironmentStrings should also write to REG_EXPAND_SZ strings.
2008-01-07 12:14:52 +01:00
4b4f737bfc
msi: Only read an internal package if the file to install is compressed.
2008-01-07 12:14:43 +01:00
2b1e487d36
msi: Adjust the types of loop variables.
2008-01-04 12:12:43 +01:00
bb8471beac
msi: Remove an extraneous safety check and simplify generate_error_string().
2008-01-03 11:53:45 +01:00
739152ce3e
msi: Remove an extraneous safety check and simplify deformat_string().
2008-01-02 13:29:41 +01:00
92e7fed80c
msi: Fix several typos.
2008-01-02 13:20:06 +01:00
99ad76c3c1
msi: Correctly handle return value of msi_realloc.
2008-01-02 13:17:52 +01:00
f7fea9e9f0
msi: Simplify condition in TABLE_fetch_stream().
2008-01-02 12:38:42 +01:00
1f26b146d1
janitorial: Remove superfluous backslashes at end of lines.
2007-12-31 19:23:45 +01:00
63655bc1a1
msi: Add missing initializer for delete_ops.
2007-12-31 17:29:24 +01:00
Hans Leidekker