Commit Graph

86 Commits

Author SHA1 Message Date
Mark Jansen 145b410920 msi: Prevent uninitialized variable usage.
Observed with Lync 2010 setup in ReactOS. The embedded Silverlight
setup hits this case (no LASTUSEDSOURCE in the registry).

Signed-off-by: Mark Jansen <mark.jansen@reactos.org>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-02-18 16:00:53 +01:00
Mark Jansen c91f254a77 msi: Do not leak rootkey.
Signed-off-by: Mark Jansen <mark.jansen@reactos.org>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-02-18 16:00:45 +01:00
Michael Stefaniuc a9cb67bb7f msi: Use the ARRAY_SIZE() macro.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-21 10:22:10 +02:00
Hans Leidekker 2b0d2ec553 msi: Use exact size for squashed GUID buffers.
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-04 14:09:59 +01:00
Bernhard Übelacker a1dbf4d78b msi: Remove shortcut which calls RegEnumValueW with value and val_count as NULL. 2015-07-01 15:19:13 +09:00
Francois Gouget 232d1b6e3f msi: Remove unneeded NONAMELESSXXX directives. 2015-03-16 15:04:21 +09:00
Nikolay Sivov 5497a41e92 msi: Fix a leak on error path (Coverity). 2014-04-10 09:11:52 +02:00
Frédéric Delanoy 85bf1082ce msi: Fix some leaks (coverity). 2012-11-07 13:56:03 +01:00
Hans Leidekker eb4e5d6024 msi: Return the correct disk prompt size from MsiSourceListEnumMediaDisksW (clang). 2011-01-27 16:31:32 +01:00
Hans Leidekker 53b5e7f319 msi: Check a return value (clang). 2011-01-27 16:31:25 +01:00
Hans Leidekker eaa57c5b7b msi: Compare strings without depending on thread locale. 2010-10-19 13:49:54 +02:00
Hans Leidekker 3929369611 msi: Remove a fixme that no longer applies. 2010-07-21 13:24:01 +02:00
Hans Leidekker 843382f284 msi: Define common strings only once. 2009-10-15 14:16:50 +02:00
Hans Leidekker c844582177 msi: Add stub implementations of MsiSourceListClearAllExA/W. 2009-03-24 13:31:36 +01:00
James Hawkins c965d839f9 msi: Allow the enumeration of other users' patches. 2009-03-23 15:52:17 +01:00
Hans Leidekker 8fec17b5ad msi: Add stub implementations of MsiSourceListClearSourceA/W. 2009-01-27 14:27:00 +01:00
James Hawkins 70be1e7746 msi: Factor out the code to open a product key. 2008-11-04 11:23:51 +01:00
Andrew Talbot 1c9886d6e7 msi: Sign-compare warnings fix. 2008-10-21 11:45:44 +02:00
James Hawkins d880470dbf msi: Handle converting a value of REG_DWORD in MsiSourceListEnumMediaDisks. 2008-08-29 13:26:25 +02:00
Dan Kegel ecfa0fbcea msi: MsiSourceListEnumMediaDisksW: free original string, not substring. 2008-06-04 12:53:25 +02:00
Alexandre Julliard 06bf8ea291 msi: Avoid creating zero-length string values in the registry. 2008-04-22 17:05:05 +02:00
Andrew Talbot 68975938f6 msi: Remove unused variables. 2008-04-22 11:54:38 +02:00
James Hawkins e94b065df3 msi: Fix the type of the ID parameter of MsiSourceListEnumMediaDisks. 2008-03-20 14:27:35 +01:00
James Hawkins 65f99ed91b msi: Test and fix MsiSourceListAddSource. 2008-03-13 11:36:24 +01:00
James Hawkins 5871bee8c7 msi: Optimize MsiSourceListAddSourceEx for adding to the end of the list. 2008-03-11 12:12:07 +01:00
James Hawkins cf84e2df5b msi: Allow setting a media disk as the last used source in the internal msi_set_last_used_source. 2008-02-26 11:20:35 +01:00
James Hawkins 1bd49bcf74 msi: Implement MsiSourceListEnumMediaDisks. 2008-02-26 11:19:40 +01:00
James Hawkins b532c0c306 msi: Simplify MsiSourceListAddMediaDisk. 2008-02-25 12:22:09 +01:00
James Hawkins d3b3738567 msi: Remove invalid fixmes. 2008-02-25 12:22:03 +01:00
James Hawkins 08172ad1c4 msi: Return the result of the call to OpenSourceKey. 2008-02-25 12:21:58 +01:00
James Hawkins 34d50c1e3e msi: Validate the parameters of MsiSourceListAddMediaDisk. 2008-02-25 12:21:51 +01:00
James Hawkins 1fced5cc1d msi: Add tests for MsiSourceListAddMediaDisk. 2008-02-25 12:21:42 +01:00
James Hawkins 8b540d2670 msi: Fix the INSTALLPROPERTY_LASTUSEDTYPE case. 2008-02-25 12:21:19 +01:00
James Hawkins 737dedfcbb msi: Fix the INSTALLPROPERTY_LASTUSEDSOURCE case. 2008-02-25 12:20:56 +01:00
James Hawkins d41cae07d5 msi: Factorize and fix the INSTALLPROPERTY_MEDIAPACKAGEPATH case. 2008-02-25 12:20:48 +01:00
James Hawkins f178985db3 msi: Simplify the check for a valid product code. 2008-02-25 12:20:39 +01:00
James Hawkins 88c7c2c7a1 msi: Fix the size of the data sent in to RegSetValueExW. 2008-02-22 12:11:16 +01:00
James Hawkins e43eee8759 msi: Fix the INSTALLPROPERTY_LASTUSEDSOURCE case of MsiSourceListSetInfo. 2008-02-21 12:53:00 +01:00
James Hawkins 6c7339eea1 msi: Allow enumerating the sources without querying the source name. 2008-02-21 12:53:00 +01:00
James Hawkins 2d5ba8d20d msi: Implement MsiSourceListEnumSources. 2008-02-21 12:53:00 +01:00
James Hawkins 55b470545f msi: Forward MsiSourceListEnumSourcesA to a stub implementation of MsiSourceListEnumSourcesW. 2008-02-20 12:07:10 +01:00
James Hawkins 123602df78 msi: Remove invalid FIXMEs. 2008-02-19 13:39:25 +01:00
James Hawkins 7cf6be8aeb msi: Return ERROR_INVALID_PARAMETER if the context is machine and szUserSid is non-NULL. 2008-02-19 13:39:25 +01:00
James Hawkins 4ee1745e81 msi: Validate the dwOptions parameter of MsiSourceListSetInfo. 2008-02-19 13:39:25 +01:00
James Hawkins 95ef6a1fbc msi: Simplify the MEDIAPACKAGEPATH and DISKPROMPT cases. 2008-02-19 13:39:25 +01:00
James Hawkins fe987103fb msi: Return the results from OpenSourceKey. 2008-02-19 13:39:25 +01:00
James Hawkins d37ac289db msi: Return ERROR_UNKNOWN_PATCH if dwOptions contains MSICODE_PATCH. 2008-02-19 13:39:25 +01:00
James Hawkins f83d049888 msi: Validate the szProduct parameter of MsiSourceListSetInfo. 2008-02-19 13:39:25 +01:00
James Hawkins 10be16f33a msi: Add tests for MsiSourceListSetInfo. 2008-02-19 13:39:25 +01:00
Rico Schüller 63c5e152a1 msi: Fix memory leaks (found by Smatch). 2008-01-07 13:46:06 +01:00