Commit Graph

243 Commits

Author SHA1 Message Date
Nikolay Sivov 5cb0ac15f6 shell32: Fix destination buffer size (Coverity).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-02 10:33:09 +02:00
Nikolay Sivov 612a194133 shell32: Use ARRAY_SIZE macro.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-19 12:35:12 +01:00
Nikolay Sivov e3b200bd8a shell32: Use global memory allocation helpers.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-22 14:16:33 +01:00
Andrey Gusev 498578d1bb shell32: Fix misplaced parenthesis.
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-13 14:21:32 +02:00
Mark Jansen 32520439e1 shell32: Prevent a possible null pointer dereference in SHGetFileInfoW.
Signed-off-by: Mark Jansen <mark.jansen@reactos.org>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-19 19:13:31 +02:00
Nikolay Sivov 1a5561c0cf shell32: Avoid zero length allocations when converting path in ExtractIconA() (Valgrind).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-05 11:07:54 +02:00
Huw Davies a7d79fe445 shell32: Load icons with the correct size.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-02 17:51:29 +02:00
Huw Davies b8bf0c2628 shell32: Simplify imagelist handling.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-02 17:51:27 +02:00
Huw Davies c4155c523d shell32: Take a reference on the imagelist returned with SHGFI_SYSICONINDEX.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-21 10:53:31 +02:00
Nikolay Sivov f2499d20d4 shell32: Implement SHGetPropertyStoreFromParsingName() as a wrapper over IShellItem2.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-27 16:24:55 +01:00
Lauri Kenttä 1c3d6ab9cc shell32: Cosmetic changes to file type names.
Signed-off-by: Lauri Kenttä <lauri.kentta@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-29 21:21:31 +01:00
Austin English ebfe169c43 shell32: Add SHGetPropertyStoreForWindow stub.
Signed-off-by: Austin English <austinenglish@gmail.com>
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-19 22:05:18 +09:00
Hans Leidekker 7ec5f555b0 shell32: Add a stub implementation of SHQueryUserNotificationState. 2015-08-06 21:42:30 +09:00
Nikolay Sivov e7acfee978 shell32: Added GetCurrentProcessExplicitAppUserModelID() stub. 2015-07-22 16:42:42 +02:00
Marcus Meissner 97be8d027b shell32: Added stub for SHEnumerateUnreadMailAccountsW. 2014-09-15 10:12:20 +02:00
Sebastian Lackner d892239f5a shell32: Return NULL-terminated list of arguments in CommandLineToArgvW. 2014-07-09 09:29:33 +02:00
Nikolay Sivov d3a034e348 shell32: Release cached desktop folder on process detach. 2014-06-16 09:30:52 +02:00
Alexandre Julliard e330a128d5 shell32: Use Shell_GetImageLists to retrieve image lists instead of using a global variable. 2014-01-02 11:56:11 +01:00
Nikolay Sivov b6efcef7a7 shell32: Cache typeinfo instances. 2013-11-19 18:49:10 +01:00
Alexandre Julliard d80ca173af shell32: Delay common controls initialization until needed. 2013-10-17 20:29:24 +02:00
Alexandre Julliard 116e33d50a shell32: Delay initialization of the icon cache until needed. 2013-10-17 20:29:23 +02:00
Alexandre Julliard d92a9264f3 shell32: Don't bother to free memory at process exit. 2013-05-15 10:27:25 +02:00
Francois Gouget 3b6b2107e2 shell32: Fix a buffer overflow in CommandLineToArgvW(). 2012-11-12 12:13:02 +01:00
Francois Gouget 40b01c1bfc shell32: Fix CommandLineToArgvW()'s handling of the executable path and consecutive quotes. 2012-10-09 10:04:04 +02:00
Francois Gouget 35004f84a2 shell32: Simplify CommandLineToArgvW() a bit. 2012-10-09 10:03:52 +02:00
Austin English cfa1813e1b shell32: Add a stub for SHSetUnreadMailCountW. 2012-06-29 20:41:46 +02:00
Francois Gouget f445325999 Assorted spelling fixes. 2012-01-23 16:07:32 +01:00
Nikolay Sivov a4dd8fb6a8 shell32: Use S_OK as successful return code name. 2012-01-09 15:34:15 +01:00
Bruno Jesus f621f8ea78 shell32: Don't parse command line if numargs is NULL in CommandLineToArgvW. 2011-10-26 17:12:13 +02:00
Alexandre Julliard b56dc9a6f7 winecrt0: Remove the clsid parameter in __wine_(un)register_resources. 2011-08-02 20:47:49 +02:00
André Hentschel 38c13e56a7 shell32: Add stub for SetCurrentProcessExplicitAppUserModelID. 2011-07-01 20:26:42 +02:00
Alexandre Julliard 2afe205ebd shell32: Convert dll registration to the IRegistrar mechanism. 2011-01-19 20:36:57 +01:00
Maarten Lankhorst e7a6b87c2d shell32: Fix pointer truncation in SHGetFileInfoA. 2010-11-29 11:22:42 +01:00
Alexandre Julliard 40977bf1d2 shell32: Store the raw AUTHORS file in resources instead of trying to convert to a C array. 2010-11-11 12:24:46 +01:00
Alexandre Julliard f6bcd27baa shell32: Add missing WINAPI to SHGetPropertyStoreFromParsingName. 2010-08-26 18:08:23 +02:00
Ilya Basin 9dee1b24ee shell32: Fix CommandLineToArgvW("") truncating returned exe path. 2010-07-26 18:38:33 +02:00
André Hentschel bb2600b687 shell32: Add stub for SHGetPropertyStoreFromParsingName. 2010-07-21 13:23:56 +02:00
Vincent Povirk 537bfbf494 shell32: Don't access szFullPath when SHGFI_PIDL is set in SHGetFileInfo. 2010-07-19 11:10:08 +02:00
Nikolay Sivov 7abdcd2c45 shell32: Add SHGetLocalizedName stub. 2010-05-21 14:37:52 +02:00
Nikolay Sivov 9e80570a3b shell32: Remove a useless debug switch, fix prototype. 2010-03-22 15:52:36 +01:00
Nikolay Sivov 82a4b85424 shell32: Add SHCreateFileExtractIconW stub. 2010-03-15 14:18:06 +01:00
Reece Dunn a2c41b72f8 Don't generate FIXME warnings for DllCanUnloadNow. 2010-01-06 10:59:51 +01:00
Michael Stefaniuc 6f36945f2b shell32: Remove some superfluous LPARAM/WPARAM casts. 2009-12-28 12:27:15 +01:00
Alexandre Julliard 29c0ecfd1c shell32: Use the module instance instead of that of the owner window for the about dialog. 2009-12-21 11:20:04 +01:00
Vincent Povirk a8c2d4b5bc shell32: Fix an uninitialized memory access in SHGetFileInfoW.
If we are passed SHGFI_PIDL, szFullPath is not initialized. If we're passed
the flags PIDL, USEFILEATTRIBUTES, and an icon flag, we will try to use the
uninitialized filename to get the icon. Since the test claims that the
function should return an icon in this case, and we cannot always convert
a pidl to a path, we should just use the pidl.
2009-12-14 12:07:25 +01:00
Aric Stewart 42e54f9513 shell32: Stub ShellHookProc. 2009-09-25 14:35:38 +02:00
Vladimir Pankratov 8777994882 shell32: Handle NULL path. 2009-08-28 16:48:23 +02:00
Stefan Leichter a14256f621 shell32: Make the tests of the value returned from function SHGetFileInfoA more strick, fix wine to pass the tests. 2009-08-05 11:23:41 +02:00
Ken Sharp 6ed93bf824 shell32: Add stub for InitNetworkAddressControl. 2009-06-02 11:27:01 +02:00
Francois Gouget aad81e5cea shell32: Make AboutDlgProc() and SHELL_execute() static. 2009-05-15 10:31:43 +02:00