Commit Graph

812 Commits

Author SHA1 Message Date
Hugh McMaster 8a8a2c9bb9 regedit: Correctly export REG_DWORD values with no data.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-10 13:46:31 +01:00
Hugh McMaster aabdc271f8 regedit: Correctly export hex values with no data.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-10 13:46:25 +01:00
Alexandre Julliard 7344ac9b72 regedit: Use WINAPIV calling convention for variadic functions.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-02 10:21:53 +01:00
Zebediah Figura 25c78b61de regedit: Always start the GUI as 64-bit when on a 64-bit prefix.
Same as we do with winecfg. This should help to eliminate some confusion
with users who may want to edit keys with WOW64 redirection (e.g.
Software\\Wine\\Drives).

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-01 23:16:07 +01:00
Hugh McMaster 84dda23536 regedit: Correctly import hex values with no data.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-16 15:26:33 +02:00
Hugh McMaster 33f9093f6d regedit/tests: Add more export tests.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-13 12:57:34 +02:00
Hugh McMaster 8ecc0d41ca regedit/tests: Add REG_NONE to the empty hex data import tests.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-13 12:57:30 +02:00
Hugh McMaster a5de10a207 regedit/tests: Delete the export file before returning from compare_export().
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-13 12:57:27 +02:00
Hugh McMaster 1baa026bc3 regedit/tests: Use a helper function to open registry keys.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-13 12:57:25 +02:00
Hugh McMaster c751b69f88 regedit/tests: Print an error code when CreateFile fails.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-13 12:57:22 +02:00
Hugh McMaster 1e6bf7d996 regedit/tests: Add REG_BINARY to the empty hex data import tests.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-09 19:50:40 +02:00
Hugh McMaster 52f686e054 regedit/tests: Test the importing of hex values with no data.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-05 19:33:09 +02:00
Fabian Maurer 8e9a469e9c regedit: Don't crash if REG_SZ is empty.
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-02 10:14:13 +02:00
Hugh McMaster 326fa95eab regedit/tests: Use a helper function to delete registry values.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-25 22:21:42 +02:00
Hugh McMaster 03a9bf4f5c regedit/tests: Test registry export against order of data creation.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-25 22:21:42 +02:00
Hugh McMaster 73bb1f66a3 regedit/tests: Test registry export with a complex data structure.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-25 22:21:42 +02:00
Hugh McMaster b3032b425e regedit/tests: Test registry export with a simple data structure.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-25 22:21:42 +02:00
Hugh McMaster fd4ce9a0ef regedit/tests: Test registry export with an empty key.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-25 22:21:42 +02:00
Hugh McMaster cca0147fcf regedit/tests: Use a helper function to delete registry keys.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-25 22:21:42 +02:00
Hugh McMaster 0ab54e4a64 regedit: Export Unicode registry files by default.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-18 15:23:04 +02:00
Hugh McMaster ee11f6fff5 regedit/tests: Combine and rename the r_exec_import_*str functions.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-18 15:22:58 +02:00
Hugh McMaster 7744204962 regedit/tests: Use a helper function to write registry files.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-18 15:22:53 +02:00
Hugh McMaster e9daef47e1 regedit: Null-terminate incomplete REG_EXPAND_SZ and REG_MULTI_SZ Unicode data.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-28 14:57:10 +02:00
Hugh McMaster 60e771e686 regedit: Close any open registry keys before starting the key deletion process.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-25 08:07:57 +02:00
Hugh McMaster 484f88080d regedit/tests: Add some mixed key creation and deletion tests.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-25 08:07:50 +02:00
Hugh McMaster d78767b63c regedit/tests: Add Unicode tests for importing invalid registry data.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-24 16:59:59 +02:00
Hugh McMaster cbe95347fc regedit/tests: Add Unicode tests for value deletion.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-24 16:59:57 +02:00
Hugh McMaster 0eab4519c0 regedit/tests: Add Unicode tests for registry key creation and deletion.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-24 16:59:55 +02:00
Hugh McMaster 634156b10a regedit/tests: Add Unicode tests for importing registry data with whitespace.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-24 16:59:53 +02:00
Hugh McMaster 13cbc36690 regedit/tests: Add Unicode tests for importing registry data with inter-mixed comments.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-24 16:59:51 +02:00
Hugh McMaster b46b698e82 regedit/tests: Delete the test registry key before starting each test.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-24 16:59:49 +02:00
Hugh McMaster d8cdafcc6f regedit/tests: Add Unicode import tests and remove the WCHAR support check.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-24 08:42:21 +09:00
Hugh McMaster 3f0ebaeebb regedit: Return a valid pointer in the QUOTED_VALUE_NAME state if REGPROC_unescape_string() returns FALSE.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-20 09:24:49 +09:00
Hugh McMaster efb8d0b497 regedit: Allow editing of all hex data types.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-08 20:13:56 +09:00
Hugh McMaster fc5bd1b438 regedit: Replace a HeapAlloc() HEAP_ZERO_MEMORY call in framewnd.c.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-02 20:19:43 +02:00
Hugh McMaster 4c25f6497e regedit: Use the heap_*() functions in hexedit.c where possible.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-02 20:18:50 +02:00
Hugh McMaster 744d538509 regedit: Pass memcpy() the correct destination address.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-31 15:05:01 +02:00
Hugh McMaster 5d9a4c4dbd regedit: Store the data from a listview subitem in a valid memory address.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-28 15:42:20 +02:00
Hugh McMaster 793ddc992c regedit: Use the heap_*() functions in treeview.c where possible.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-28 15:42:18 +02:00
Hugh McMaster e0a527ab43 regedit: Use the heap_*() functions in listview.c where possible.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-28 15:42:16 +02:00
Hugh McMaster 792e7046a6 regedit: Remove commented code from resize_frame_rect().
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-27 17:04:05 +02:00
Hugh McMaster 9be3c53701 regedit: Use the heap_*() functions in regedit.c where possible.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-27 17:04:04 +02:00
Hugh McMaster a3e043b82e regedit: Use the heap_*() functions in framewnd.c where possible.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-27 17:04:04 +02:00
Hugh McMaster 6238cd46f2 regedit: Use the heap_*() functions in edit.c where possible.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-27 17:04:04 +02:00
Hugh McMaster c193bffb3e regedit: Use the heap_*() functions in childwnd.c where possible.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-27 17:04:04 +02:00
Hugh McMaster 1b3afb27c7 regedit: Use heap_xrealloc() for consistency.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-27 17:04:04 +02:00
Hugh McMaster f7bdf34029 regedit: Use a helper function to free allocated memory.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-27 17:04:04 +02:00
Hugh McMaster 79ff4148c2 regedit: Use a helper function to allocate memory and check for a valid pointer.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-27 17:04:04 +02:00
Hugh McMaster 976c2aa649 regedit: Prevent out-of-bounds reads when unescaping a string (Valgrind).
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-26 22:14:00 +02:00
Hugh McMaster 5bd636dc16 regedit: Check for a valid subkey pointer before attempting to delete a registry key (Coverity).
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-24 18:58:31 +02:00