Commit Graph

186 Commits

Author SHA1 Message Date
Andrew Talbot 8366dd1703 comctl32: Constify some variables. 2007-04-03 11:21:17 +02:00
Hagop Hagopian 637a6116e2 comctl32: tab: Minor bug fixes in the curSel and curFocus getters and setters. 2007-03-19 12:16:41 +01:00
Felix Nawothnig 0f2f718dea comctl32: Layout and redraw on TCM_SETIMAGELIST. 2007-03-13 21:54:47 +01:00
Michael Stefaniuc 22ecd7aa67 comctl32: Remove redundant NULL checks before Free() (found by Smatch). 2007-03-08 11:58:04 +01:00
Felix Nawothnig 8784d47cba comctl32: Remove redundant NULL checks before Free() calls. 2007-02-14 12:22:39 +01:00
Felix Nawothnig 79e265accd comctl32: Remove unnecessary and misused mask member from TAB_ITEM. 2007-02-07 11:03:01 +01:00
Thomas Weidenmueller 2c620c8269 comctl32: Fix the TAB_ITEM_SIZE macro. 2007-02-05 12:25:16 +01:00
Oleg Krylov 32caf30f9c comctl32: Create tooltip windows with WS_POPUP style. 2006-10-25 20:21:34 +02:00
Alexandre Julliard 7cca856315 comctl32: Properly handle negative coordinates for mouse events. 2006-10-25 17:41:48 +02:00
Michael Ploujnikov 1c16d83379 comctl32: Win64 printf format warning fixes. 2006-10-14 20:17:06 +02:00
Francois Gouget 82babbee0b Add missing '\n's to Wine traces. 2006-10-05 17:46:48 +02:00
Jonathan Ernst 360a3f9142 Update the address of the Free Software Foundation. 2006-05-23 14:11:13 +02:00
James Hawkins aa57ad373d comctl32: A couple fixes for tab icon offsets.
- Shift selected icons up and non-selected icons down.
- Add the top or left draw rect to the vertical offset, because it may
  not be zero.
2006-03-23 20:20:33 +01:00
Tobias Loew 1911eed08e comctl32: Fix tab-control flickering. 2006-01-30 14:57:26 +01:00
Michael Kaufmann e9310da57b Handle WM_PRINTCLIENT.
Don't use SelectClipRgn in WM_PRINTCLIENT.
2005-11-08 12:52:35 +00:00
Dmitry Timoshkov 592a81ab22 Avoid printing out a possibly uninitialized variable. 2005-11-02 19:56:24 +00:00
Francois Gouget a1f9a13997 Use "static const" rather than "const static" as gcc -W complains
about the former.
2005-10-06 11:38:45 +00:00
Vitaliy Margolen 059a8c15f2 Don't arrange tabs if there is only one line. 2005-10-03 18:46:07 +00:00
Frank Richter 9e57091ffa Fix warnings in 64bit. 2005-08-30 10:07:17 +00:00
Mike McCormack 280bcf6e4a Fix gcc 4.0 warnings. 2005-08-27 10:00:38 +00:00
Vitaliy Margolen abd12e4dbf Fix handling of minimum tab width.
Add more tests to test it.
2005-08-23 10:05:54 +00:00
Aric Stewart bf129c41de Fix for dreamweaver site definition dialog. Need to initialize the
rect for a tab control to an empty rect if it is not visible.
2005-08-22 14:07:22 +00:00
Frank Richter b5940f7283 Fix text color for "button" style tabs when theming is enabled. 2005-08-11 18:35:00 +00:00
Frank Richter c952f08ba8 Add theming support for the tab control. 2005-07-28 10:14:52 +00:00
James Hawkins 645ec7d6e2 Audit the Tab control. 2005-06-06 10:03:03 +00:00
James Hawkins 4d639be88b - Factor out common text shifting logic.
- Shift selected tab text up instead of down.
2005-06-04 09:37:22 +00:00
James Hawkins 1aa7afeed9 Fixed centering of tab text. 2005-05-17 10:19:37 +00:00
Aric Stewart 8a0f989891 Handle WM_NCCALCSIZE in the tab control. 2005-05-12 09:57:10 +00:00
Vitaliy Margolen b58004d9ae Draw only visible tabs. 2005-04-13 14:40:12 +00:00
Dimitrie O. Paun 9da93dd879 Tab unicodification. 2005-04-11 14:21:15 +00:00
Francois Gouget 93416cdaf7 Assorted spelling fixes. 2005-03-23 13:15:18 +00:00
Jon Griffiths 3388eb0885 Remove unneeded calls to TAB_GetInfoPtr(), const fixes, inline small
funcs & remove unused parameters.
2005-02-25 16:19:07 +00:00
Eric Pouech cf1d00bb08 Removed excessive statement (break after return or goto, not useful
break, not needed vars...)
2005-01-09 16:42:53 +00:00
Vitaly Lipatov 6971e1d762 Add comments, fix negative value from GetCurFocus. 2005-01-03 20:12:42 +00:00
Alexandre Julliard ebe3c529b1 Janitorial: C booleans must not be compared against TRUE. 2004-12-09 14:07:59 +00:00
Thorsten Kani d93d3d5ada Use address of tab_item.extra when building drawitemstruct. 2004-10-26 00:22:31 +00:00
Jon Griffiths ef138f090e Items are variable sized, use an accessor to get at them.
Combine A/W calls together to remove duplication.
Don't leak text when removing/changing items.
Turn off hot tracking when we delete the last item.
Use the 'delete 1 item' logic when deleting all items.
2004-10-09 02:27:00 +00:00
Robert Shearman 62d60b9b39 - Set hbrBackground class property to same value as native.
- Remove no longer needed WM_ERASEBKGND handler.
- Use Unicode window functions instead of ANSI.
2004-09-14 00:44:26 +00:00
Hans Leidekker 411fc5f164 Fix signed/unsigned comparison warnings. 2004-09-02 23:00:53 +00:00
Robert Shearman cdb263e588 Replace GetWindowLong by GetWindowLongPtr. 2004-08-25 17:33:01 +00:00
Ulrich Czekalla 0d173d01a8 The rectangle passed in DRAWITEMSTRUCT is slightly too large as
compared with Windows.
2004-08-19 19:06:18 +00:00
Jon Griffiths 86a0e50a1d Don't crash on NULL tab text. 2004-07-16 02:30:48 +00:00
Jon Griffiths 438bf11a7d Implemented TCM_SETITEMEXTRA. 2004-06-04 18:11:03 +00:00
Vitaliy Margolen c03dabb2fe Adjust all dimensions to match native.
Invalidate whole tab area when multi-line.
In vertical tab placement go from top to bottom.
Fix annoying visual artifacts.
2004-03-02 04:52:35 +00:00
Vitaliy Margolen a6637ddb5d - Fix handling of TCS_RAGGEDRIGHT style.
- Clip UpDown control only if it is present.
- Add ToDos.
2004-02-07 01:02:03 +00:00
Francois Gouget 640cc3f3e1 Assorted spelling fixes. 2004-01-06 22:08:33 +00:00
Vitaliy Margolen 036dcf167e - Fix drawing of HotTracked tabs & buttons.
- More tab size fixes in different styles.
- Don't use new padding until style changes.
- Fix left alignment of labels &| icons.
- Don't draw over UpDown control.
- Fully erase tabs when scrolling.
- More tests.
2003-12-02 03:31:44 +00:00
Dimitrie O. Paun c594043316 Make the controls send notifications to the parent window passed to
them in CREATESTRUCT.  Based on a treeview patch by Igor Grahek.
2003-11-20 22:04:13 +00:00
Vitaliy Margolen 785bae8aae - Fix tab size for TCS_OWNERDRAWFIXED style.
- Correct size recalculation after setting tab width.
- Fix button sizes to match native.
- Center both vertically and horizontally tab text & icon.
- Use correct left/center alignment flags.
2003-10-31 00:06:42 +00:00
Maxime Bellengé ed3847247e Fix TAB_DeleteItem and TAB_DeleteAllItems regressions introduced by
the last TAB_InvalidateTabArea changes.
Correct the indentation for these functions.
2003-10-21 23:44:03 +00:00
Maxime Bellengé 8147ee1095 Only redraw the necessary area of the tab component and not the whole
component like windows does.
2003-10-14 20:12:05 +00:00
Vitaliy Margolen bd7bdbce3f Fix setting size of tab control. 2003-10-14 01:16:16 +00:00
Dimitrie O. Paun 7de279a73a Rename COMCTL32_{Alloc,ReAlloc,Free} to {Alloc,ReAlloc,Free}. 2003-09-22 21:32:33 +00:00
Alexandre Julliard cf52644a1c Removed the A/W constants for builtin cursors, icons and resource
types since they don't exist on Windows, and added typecasts
everywhere instead.
2003-09-10 03:56:47 +00:00
Alexandre Julliard e37c6e18d0 Fixed header dependencies to be fully compatible with the Windows
headers (with help from Dimitrie O. Paun).
2003-09-05 23:08:26 +00:00
Maxime Bellengé bcd1222650 Implemented TAB_SetMinTabWidth and TAB_HighlightItem. 2003-09-02 00:56:43 +00:00
Maxime Bellengé 0485fc19b6 Fix bounding rectangle computation for an ownerdraw tab. 2003-04-30 00:50:26 +00:00
Stephan BEUZE 8410e71fb5 Implemented message TCM_SETPADDING with the Dimitri's advice. 2003-04-27 20:34:30 +00:00
Mike Hearn c7b1874b54 Fix the tab height so the labels don't clip, and restore the offset
constant to what it was before.
2003-03-17 04:43:26 +00:00
Mike Hearn c6914b202a - Reduced tab offset constant slightly to avoid clipping the label.
- Prevent label overdraw of updown control by reducing the width of
  the invalidated region.
2003-03-12 20:14:12 +00:00
Mike Hearn 6b2d22a0f6 It's not just height that can be set to the default by passing zero to
TCM_SETITEMSIZE, but also width.
2003-03-10 19:04:13 +00:00
Vitaliy Margolen e6af4ec6bd Fix invisible tabs in TabControls with fixed tab width. 2003-03-04 04:34:03 +00:00
Dan Kegel 0fd521fee3 Change RECT to use LONG to match win32 standard headers and fix format
strings to use %ld for RECT elements.
2003-01-08 21:09:25 +00:00
Francois Gouget d2667a4ce3 Removed unnecessary HANDLE typecasts. 2002-12-02 18:10:57 +00:00
Michael Stefaniuc 353529b2c8 - fix the "int format, HANDLE arg" type of warnings for comctl32
- compile the comctl32 dll with -DSTRICT
2002-10-23 22:19:10 +00:00
Michael Stefaniuc 025c0b716b Prepare dlls/{comctl32,gdi,msvideo,setupapi,shell32,twain,winmm} for
the conversion of HWND to a void*.
2002-09-06 19:41:17 +00:00
Guy L. Albertelli 23739a339a Don't issue error message if message number in application range. 2002-07-16 01:23:59 +00:00
Guy L. Albertelli 533905e2ab - Add routines to dump out tab items internally and externally
- Adjust TAB_SetItemBounds to split vertical tabs more like the native.
- Document major difference in laying out the vertical tabs.
- Fix drawing of icons. Wrong item padding used in vertical case.
- Fixed size of horizontal padding.
2002-06-20 22:45:29 +00:00
Vincent Béron 9a62491660 Removed trailing whitespace. 2002-05-31 23:06:46 +00:00
Guy L. Albertelli dea6820b29 - Fixed drawing of borders to that of native (uses DrawEdge).
- Fixed drawing of separators to match the native.
- Fixed height of tabs and buttons to match native.
- Add/improved traces.
- Handle WM_SYSCOLORCHANGE message.
2002-05-29 00:32:02 +00:00
Alexandre Julliard 4344c368cb Got rid of GetSysColorPen. 2002-05-20 18:15:28 +00:00
Alexandre Julliard 0799c1a780 Added LGPL standard comment, and copyright notices where necessary.
Global replacement of debugtools.h by wine/debug.h.
2002-03-09 23:29:33 +00:00
Gerard Patel b3a3a8f3bc Forward tab notifications to the parent. 2001-12-24 20:24:58 +00:00
Nog f12e130fc2 Pass on all unhandeled messages to the owner. 2001-12-17 20:52:11 +00:00
Francois Gouget 070e749cfb Don't prefix %p with 0x.
Various English fixes.
2001-11-06 21:01:32 +00:00
Patrik Stridvall 3c0211f969 Cleanup code that is strange or difficult to parse. 2001-09-11 00:32:32 +00:00
Francois Gouget ee285b7ac8 Remove unnecessary single quoting of debugstr_xxx strings. 2001-05-11 20:03:40 +00:00
Gerard Patel 09d64c83cf Don't send notifications for the initial display of the first tab of
the control.
2001-01-25 21:48:01 +00:00
Gerard Patel ea241dcdbd Fixed TCM_GetRowCount. 2001-01-09 20:49:17 +00:00
Andreas Mohr a6d83ebae1 - clarify many error messages
- add data corruption warning to README file
2000-12-27 04:02:46 +00:00
Aric Stewart 844625cbc5 Fixed some difficulties with the font on vertical tabs. Also plugged a
resource leak.
2000-12-15 20:55:20 +00:00
Gerard Patel 4d975b328f Use DrawText to display text in horizontal tabs. 2000-12-12 00:35:20 +00:00
Eric Kohl 7379b89185 Removed calls to internal (non-exported) wine functions. 2000-11-25 01:27:42 +00:00
Eric Kohl 76386564a6 Use internal unicode strings.
Added unicode messages.
2000-11-15 22:15:11 +00:00
Francois Gouget a2882e03f8 Use DrawFocusRect to draw the focus rectangle. 2000-11-07 20:26:51 +00:00
Alexandre Julliard 908464d448 Authors: Andreas Mohr <amohr@codeweavers.com>, Dimitrie O. Paun <dimi@cs.toronto.edu>, Patrik Stridvall <ps@leissner.se>
Various warning fixes.
2000-11-01 03:11:12 +00:00
Francois Gouget 7203ee6623 Use PS_ALTERNATE rather than PS_DOT.
Use Rectangle to draw focus rectangles.
2000-10-31 02:05:11 +00:00
Chris Morgan 7a6cf75f76 Implement TCS_VERTICAL style. Fix tab borders to have shading that
matches Windows.  Center image and text in tabs.  Size tabs to
completely fill each row with multiline style.  Fix positioning of
tabs for TCS_BOTTOM style.  Fix various drawing issues.
2000-10-25 20:31:18 +00:00
Susan Farley b409cf62d4 Added support for FLATBUTTON style tabs.
Made width of BUTTON style tabs no less than 2x their height.
Expanded focus rect to be just inside the border.
2000-09-22 20:54:16 +00:00
Andreas Mohr 05aa048691 Fixed tab control to use HTTRANSPARENT when mouse hits client area,
but not tab control buttons.
2000-09-16 20:47:27 +00:00
Andreas Mohr 20cd9356a8 - fixes debugger output
- get rid of wrong comments
- fix comments
- .spec spelling fix
- improve warning message
2000-09-12 23:40:40 +00:00
Marcus Meissner e89f6c4466 Implemented TCM_GETROWCOUNT. 2000-09-09 20:31:32 +00:00
Alexandre Julliard c7e7df8b17 Replaced all lstr* calls from inside Wine code by their str* equivalent. 2000-08-14 14:41:19 +00:00
Alexandre Julliard 5ab9d860f2 Removed some unnecessary #includes and dll dependencies. 2000-08-09 22:35:05 +00:00
Alexandre Julliard 70c9e095ef Removed all non-standard common control headers from the include
directory.
2000-08-09 00:41:17 +00:00
Aric Stewart 6274a7ab88 Corrected the problem where a tab control marked multiline but has
only one tab was being justified to fill the whole tab space.
2000-05-24 21:02:29 +00:00
Francois Gouget 244ad84f50 Convert C++ comments to regular C comments. 2000-05-18 00:05:10 +00:00
Ken Thomases da2cd4d070 Implemented tab control style TCS_HOTTRACK (tabs are highlighted on
mouse-over).
2000-05-11 21:40:36 +00:00
Ken Thomases f9e280aab3 Restore accidentally undone changes. 2000-05-10 21:42:53 +00:00
Gerard Patel a1b2fc2a80 Protect against use of comctl32 private control memory after it has
been freed.
2000-05-10 01:34:53 +00:00