Fabian Maurer
3d0be0bad8
user32/combo: Properly set dropdown height.
...
Now that user32 and comctl32 combo are separated,
this won't lead to a regression anymore.
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-20 09:17:31 +02:00
Nikolay Sivov
080cb3aa81
user32: Remove some misleading TODOs.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-21 17:33:36 +01:00
Nikolay Sivov
1ae05c04a2
user32: Remove confusing comments.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-08 13:10:50 +01:00
Piotr Caban
a5118adbbc
user32: Add more CB_SETCURSEL tests on ComboBox.
...
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-05 19:30:26 +01:00
Piotr Caban
a912b23771
user32: Redraw combo text field even if it's empty.
...
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-05 19:30:12 +01:00
Piotr Caban
910129fcf7
user32: Let ComboBox edit control handle the redraw even if CBF_NOREDRAW is set.
...
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-05 19:30:08 +01:00
Sebastian Lackner
f0fc034997
Revert "user32/combo: Set listbox popup height correctly and add tests.".
...
This partly reverts commit f7f7b89e2e
(tests are left in place).
Any application that currently uses "Microsoft.Windows.Common-Controls
v6" via a Manifest has the possibility of breaking comboboxes. Using
this version of the control ensures that dropdown for comboboxes, will
show multiple items, regardless of its height in the resource.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-11 15:29:42 +01:00
Piotr Caban
8159af76b4
user32: Don't do the painting if combobox is not visible in CBPaintText.
...
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-24 19:10:06 +02:00
Piotr Caban
1a114c9f4b
user32: Don't invalidate ComboBox on CB_SETCURSEL message.
...
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-06 21:48:48 +02:00
Piotr Caban
9cb29e5182
user32: Don't invalidate ComboBox on LBN_SELCHANGE and LBN_SELCANCEL.
...
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-06 21:48:48 +02:00
Piotr Caban
e5dd995708
user32: Remove unneeded RECT parameter from CBPaintText helper.
...
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-06 21:48:48 +02:00
Fabian Maurer
f7f7b89e2e
user32/combo: Set listbox popup height correctly and add tests.
...
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-28 09:29:27 +02:00
Michael Stefaniuc
07f9f71278
user32: Use straight assignments instead of CopyRect().
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-02 16:18:05 -05:00
Alex Henrie
5b53c0b88b
user32: Avoid double initialization.
...
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-06 21:59:08 +09:00
Huw Davies
4c2ad39140
user32: Make the combo's listbox a topmost window.
2014-11-10 19:23:46 +09:00
Huw Davies
b4b99697f9
user32: Keep the combo listbox within the monitor's work area.
2013-03-28 18:55:09 +01:00
Sergey Guralnik
ac0738471d
user32: Use window height/width instead of client for combo resizing.
2013-03-12 11:25:58 +01:00
Michael Stefaniuc
4affaea0ba
user32: Avoid TRUE:FALSE conditional expressions.
2012-08-13 11:50:51 +02:00
Sergey Guralnik
cbf9589ba3
user32: Rearrange ComboBox repositioning code.
2012-07-26 21:38:10 +02:00
Bruno Jesus
7c76a79ffa
user32: Fix support for CB_SETDROPPEDWIDTH in combobox.
2011-09-02 18:28:25 +02:00
Marcus Meissner
3d44f4c8b3
user32: Added missing break (Coverity).
2011-03-28 17:11:34 +02:00
Alexandre Julliard
0f90053575
user32: Add a common helper to set controls clip region, and make it behave correctly when mirrored.
2010-09-02 11:35:14 +02:00
Jason Edmeades
f27b032d50
user32: Preselect all editbox text when combo gets focus.
2010-01-25 18:05:03 +01:00
Dmitry Timoshkov
2d0b2433c2
user32: Handle virtual key codes only in the WM_KEYDOWN case.
...
Reported by David Quintana.
2009-12-30 16:14:11 +01:00
Michael Stefaniuc
6f3b494463
user32: Remove some explicit LPARAM/WPARAM casts.
2009-12-28 12:27:13 +01:00
Alexandre Julliard
d081a7352c
user32: Simplify window procedure allocation for the builtin classes.
2009-12-18 12:39:13 +01:00
Alexandre Julliard
05cf0ff29f
user32: Pre-allocate the window procedure for the combobox class.
2009-12-17 13:09:50 +01:00
Alexandre Julliard
57d439f4f1
user32: Turn the combobox winproc into a Wow handler.
2009-12-15 16:09:13 +01:00
Alexandre Julliard
51770cdbbc
user32: Split the handling of the 16-bit messages out of the combo winproc.
2009-12-13 12:12:56 +01:00
Rein Klazes
8ac8957a36
user32: In COMBO_WindowPosChanging() do not change the height of the the dropped rectangle, if the new height is too small.
2009-04-03 13:01:14 +02:00
Austin English
6e59cd2c34
Spelling fixes.
2008-04-22 12:20:12 +02:00
Aric Stewart
d0cf2342df
user32: Make sure there is space for at least 6 items in a combo dropdown without forcing it to be at most 6 items as well.
2008-04-14 12:05:04 +02:00
Dmitry Timoshkov
113f2c9dbb
user32: Add a test for combobox navigation with arrow keys, make it pass under Wine.
2008-03-27 11:06:02 +01:00
James Hawkins
c29c740de0
janitorial: Remove links to any microsoft site.
2008-03-01 12:17:10 +01:00
Lei Zhang
6c1cdc7186
user32: Use wine_dbgstr_rect() in traces.
2008-02-07 11:59:53 +01:00
Andrew Talbot
ba596d30ce
user32: Remove unneeded casts.
2008-01-22 11:27:45 +01:00
Dmitry Timoshkov
0e799c6d7b
user32: Set the edit text in a combobox only if combobox has strings.
2007-12-19 12:20:03 +01:00
Andrew Talbot
1818d3a208
user32: Fix a typo.
2007-11-26 12:27:25 +01:00
Andrew Talbot
d98b83bed5
user32: Constify some variables.
2007-11-09 12:26:23 +01:00
Alexandre Julliard
bfe88a00f8
user32: Store the builtin class names in Unicode.
2007-11-01 12:55:00 +01:00
Mikolaj Zalewski
71d77d98e2
user32: combo: CB_SETITEMHEIGHT should make the edit area 2px higher than the item (with testcase).
2007-08-31 13:24:13 +02:00
Dmitry Timoshkov
ce1ab638da
user32: CBN_SELCHANGE notification should be sent before an edit update.
2007-08-09 14:40:59 +02:00
Dmitry Timoshkov
3c9e7a7f33
wine: Switch to using 'long' for INT_PTR type for 64-bit compatibility.
2007-05-25 20:37:56 +02:00
Andrew Talbot
01e93cc2d1
user32: Exclude unused headers.
2007-05-21 13:36:02 +02:00
Mikołaj Zalewski
4043b007fe
user32: combobox: The text area height should be font_height+4.
...
The tests shows that CBGetTextAreaHeight was using a bad formula.
2007-03-27 12:31:31 +02:00
Aric Stewart
ea60a508b1
user32: We are calculating the height for the drop down based on
...
number of items however the if statement used nIHeight (just the
height of 1 item) and not nHeight (the height all the items).
2007-02-07 20:43:58 +01:00
Kai Blin
7bfe2b06c3
user32: If pTest was allocated, length has to be > 0 (Coverity).
2007-01-05 20:26:52 +01:00
Alexandre Julliard
b8a2e3b8a4
user32: Renamed the user/ directory to user32.
2006-11-16 14:49:25 +01:00