Commit Graph

795 Commits

Author SHA1 Message Date
Damjan Jovanovic 06cd8d3d2e msxml3: Return S_FALSE from IXMLDOMNamedNodeMap::nextNode() when there are no attributes.
Currently Wine return S_FALSE when IXMLDOMNamedNodeMap::nextNode()
has run out of attributes to return, but when an XML node has no
attributes at all, it returns S_OK despite setting the nextNode
output parameter to NULL, causing the caller to crash when it
accesses this pointer. Return S_FALSE in this case instead.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50603
Signed-off-by: Damjan Jovanovic <damjan.jov@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-06-22 17:57:47 +02:00
Damjan Jovanovic b5f3b8d07f msxml3/tests: Add some regex tests.
Signed-off-by: Damjan Jovanovic <damjan.jov@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-06-04 10:19:42 +02:00
Jefferson Carpenter 653504a3ca msxml3: Null check newNode in domelem insertBefore.
Signed-off-by: Jefferson Carpenter <jeffersoncarpenter2@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-05-31 23:00:29 +02:00
Jefferson Carpenter ec867bc428 msxml3: Null check newChild in DOMDocument insertBefore.
Signed-off-by: Jefferson Carpenter <jeffersoncarpenter2@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-05-31 23:00:21 +02:00
Dmitry Timoshkov a39df8bb61 msxml3: Implement IXMLDOMNamedNodeMap::getNamedItem() for a processing instruction node.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-05-31 17:42:58 +02:00
Dmitry Timoshkov 13b1e36de0 msxml3: IVBSAXContentHandler::startElement() should also check *namespaceURI for NULL.
Like ISAXContentHandler::startElement() does.

Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-05-21 18:11:06 +02:00
Dmitry Timoshkov bbfa8d17f8 msxml3/tests: Add some tests for IVBSAXContentHandler::startElement() and IVBSAXContentHandler::endElement().
These are mostly a copy of ISAXContentHandler::startElement() and
ISAXContentHandler::endElement() tests.

Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-05-21 18:11:04 +02:00
Dmitry Timoshkov d7ce5bddf9 msxml3/tests: Execute ProcessingInstruction tests before other tests to avoid crashes under 64-bit Windows.
It seems that the ProcessingInstruction tests somehow trigger internal inconsistency
in 64-bit msxml under Windows, and I haven't found other ways to stop crashes on exit.

Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-05-19 10:36:31 +02:00
Dmitry Timoshkov a0dd105c65 msxml3/tests: Add more tests for processing instruction attributes.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-05-07 22:34:32 +02:00
Dmitry Timoshkov ee49f13ab2 msxml3/tests: Don't '\0' terminate output after ::save().
This fixes heap corruption when running the domdoc tests.

Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-05-07 22:34:06 +02:00
Dmitry Timoshkov b896230547 msxml3: Don't unlink the XML declaration when saving document.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-23 20:02:06 +02:00
Dmitry Timoshkov 875b8a598f msxml3/tests: Add a test for saving XML with not default encoding.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-05 15:07:39 +02:00
Jefferson Carpenter eca796bf75 msxml3/tests: Test mxwriter domdoc output.
Signed-off-by: Jefferson Carpenter <jeffersoncarpenter2@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-24 22:01:42 +01:00
Francois Gouget 251a2b955a msxml3/tests: Fix the spelling of a test string.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-11-30 21:36:12 +01:00
Alexandre Julliard b00e2df3e8 msxml3: Clear one extra variant in collection enumeration.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-11-27 11:37:10 +01:00
Daniel Lehman 4610dc7920 msxml3: Support ISequentialStream in domdoc_transformNodeToObject.
Signed-off-by: Daniel Lehman <dlehman25@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-11-25 21:39:18 +01:00
Michael Stefaniuc 21ca8e1648 msxml3/tests: Use wide-char string literals.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-10-28 20:36:26 +01:00
Nikolay Sivov e5c87396b1 msxml3/tests: Use wide string literals in tests.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-10-06 11:56:55 +02:00
Nikolay Sivov 44705156b5 msxml3/tests: Fix tests failures with unreachable network resources.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-10-05 20:51:25 +02:00
Nikolay Sivov 20e36dcb1b msxml3/tests: Use wide string literals in more tests.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-10-05 20:51:23 +02:00
Daniel Lehman 38844dc31e msxml3: Handle namespaces in removeNamedItem.
Signed-off-by: Daniel Lehman <dlehman25@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-10-05 20:51:16 +02:00
Daniel Lehman f726691bdc msxml3/tests: Add some removeNamedItem tests.
Signed-off-by: Daniel Lehman <dlehman25@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-10-05 20:51:14 +02:00
Gijs Vermeulen 49eac508b5 msxml3: Support retrieving more than one element in IEnumVARIANT::Next() for IXMLElementCollection.
Signed-off-by: Gijs Vermeulen <gijsvrm@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-09-16 17:13:50 +02:00
Gijs Vermeulen 4ad0e7485d msxml3: Support Reset() for IEnumVARIANTs created by create_enumvariant.
Signed-off-by: Gijs Vermeulen <gijsvrm@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-09-16 17:13:50 +02:00
Gijs Vermeulen fa466d13a7 msxml3/tests: Add more iteration tests for IXMLDOMNamedNodeMap, IXMLDOMSchemaCollection and IXMLDOMNodeList.
Signed-off-by: Gijs Vermeulen <gijsvrm@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-09-16 17:13:50 +02:00
Alexandre Abgrall 72f42516b2 msxml3: Fix value of 'fetched' in IEnumVARIANT::Next() for IXMLDOMSelection.
It must be the number of elements returned in 'var', as specified here:
https://docs.microsoft.com/en-us/windows/win32/api/oaidl/nf-oaidl-ienumvariant-next

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=40430
Signed-off-by: Alexandre Abgrall <aabgrall98@gmail.com>
Signed-off-by: Gijs Vermeulen <gijsvrm@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-09-15 21:30:27 +02:00
Nikolay Sivov 007df5deed msxml3/tests: Remove traces.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-07-14 18:27:59 +02:00
Dmitry Timoshkov 25abcac61a msxml3: IXMLDOMDocument2's ::SetSite implementation should query site for base URI.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-07-09 09:52:42 +02:00
Dmitry Timoshkov f9920d27b3 msxml3/tests: Add some tests for XML loading with site assigned.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-07-09 09:52:40 +02:00
Daniel Lehman da3893fe48 msxml3: Set internal error on loading from IPersistStream.
Signed-off-by: Daniel Lehman <dlehman25@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-07-08 16:06:06 +02:00
Daniel Lehman 50650c26fe msxml3: Set internal error on loading from IStream.
Signed-off-by: Daniel Lehman <dlehman25@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-07-08 16:06:06 +02:00
Hans Leidekker 0bec5dfeec msxml3: Add support for 'int' in IXMLDOMElement_put_dataType.
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-06-23 10:12:11 +02:00
Michael Stefaniuc 8b8460de07 msxml3/tests: Just use a wchar string literal instead of _bstr_().
lstrcmpW and memcmp can deal just fine with WCHAR* and don't need
a BSTR.

Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-02-18 20:29:09 +01:00
Michael Stefaniuc 077224622d msxml3/tests: Get rid of a2bstr().
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-02-18 20:29:07 +01:00
Jacek Caban c041605b00 guiddef.h: Remove GUID_NULL declaration.
It's declared in cguid.h with proper extern "C".

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-02-04 21:30:27 +01:00
Daniel Lehman e31469eb58 msxml3/tests: Fix copy & paste in traces.
Signed-off-by: Daniel Lehman <dlehman25@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-01-24 17:15:54 +01:00
Francois Gouget 280cbcb28a msxml3: Fix the spelling of some comments.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-12-12 23:17:05 +01:00
Francois Gouget a245084ae8 msxml3/tests: Avoid an unneeded lstrlenW() call.
This being a test we have to assume IXMLElement_get_text() could return
a NULL string.

Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-12-10 22:15:05 +01:00
Damjan Jovanovic e2f2ad0e81 msxml3: All string passed to IXMLDOMDocument_load() need to be URL-unescaped.
msxml3 allows URL escape sequences even for C:\ style paths.
eg. C:\Program%20Files\...

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48242
Signed-off-by: Damjan Jovanovic <damjan.jov@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-12-09 23:47:45 +01:00
Alexandre Julliard f077f8b08d msxml3/tests: Avoid winetest_strcmpW.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-11-29 13:57:51 +01:00
Piotr Caban 78259fceb3 msxml3: Don't return NULL namespace and local name in saxreader callbacks.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-09-27 22:42:50 +02:00
Jacek Caban 73af53c4bc msxml3: Fix string length handling in I[VB]SAXContentHandler::characters.
Windows crashes when -1 length is passed. Escaping should just copy
embedded null bytes.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-07-02 20:43:37 +02:00
Michael Stefaniuc 94e76b1b3c msxml3/tests: Floating point numeric constants are by default doubles.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-02-20 09:18:48 +01:00
Michael Stefaniuc c743b72d25 msxml3/tests: Use the ARRAY_SIZE() macro.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-20 20:23:36 +01:00
Daniel Lehman c1d21f1ae4 msxml3: Return URL from get_namespaceURI from attributes for MSXML6.
Signed-off-by: Daniel Lehman <dlehman25@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-10-22 09:52:50 +02:00
Daniel Lehman f95a111608 msxml3/tests: Add some more namespaces tests.
Signed-off-by: Daniel Lehman <dlehman25@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-10-22 09:52:49 +02:00
Daniel Lehman 4460cb3377 msxml3: Treat namespaces as floating attributes.
Signed-off-by: Daniel Lehman <dlehman25@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-10-22 09:52:45 +02:00
Francois Gouget ed42959693 msxml3/tests: Make test_namespaces_as_attributes() static.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-17 15:37:49 +02:00
Daniel Lehman 9b950387e5 msxml3/tests: Add test for treating namespaces as attributes.
Signed-off-by: Daniel Lehman <dlehman25@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-31 09:05:20 +02:00
Alistair Leslie-Hughes 8ad509ed70 msxml3: Accept NormalizeAttributeValues property.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 12:06:56 +02:00