Commit Graph

2511 Commits

Author SHA1 Message Date
Vincent Povirk 00e2d897c2 comctl32: Do not repaint on TBM_SETPOS if position is unchanged. 2008-11-17 13:54:52 +01:00
Detlef Riekenberg f0d0ac75dc comctl32/tests: Make the header test dpi aware. 2008-11-14 12:08:42 +01:00
Lei Zhang 87ca1b9416 comctl32: Check for NULL input in TAB_AdjustRect. 2008-11-11 11:40:46 +01:00
Sergey Khodych 30a6f54dc9 comctl32/tests: Fix typo in toolbar todo test. 2008-11-07 11:17:56 +01:00
Reece Dunn 9368972866 comctl32: Don't draw the theme background of the group box over it's content area.
Hi,

Some applications (e.g. Cepstral SwiftTalker) have dialogs that
contain controls that are ordered before the group box that contains
them. The current rendering of themed group boxes will draw it's
background over the content area, hiding any controls that have
already been drawn. XP with the default and other custom themes
correctly shows controls beneath the group box.

This patch excludes the group box content area from being drawn to, so
that any controls that have already been drawn do not get overridden.

- Reece

From 889e477bcb4561565b8caaf41c88c5fe7d83b8d2 Mon Sep 17 00:00:00 2001
From: Reece Dunn <msclrhd@gmail.com>
Date: Fri, 7 Nov 2008 00:11:52 +0000
Subject: [PATCH] comctl32: don't draw the theme background of the group box over it's content area.
2008-11-07 11:01:26 +01:00
Michael Stefaniuc c46a88a3c9 comctl32: Remove superfluous casts that crept in as well as some older ones. 2008-11-07 11:00:16 +01:00
Sergey Khodych 7f25cd993c comctl32: toolbar: Use a cx field for buttons in TOOLBAR_WrapToolbar. 2008-11-06 11:56:03 +01:00
Sergey Khodych 65e9a6e02e comctl32: toolbar: Improve text layout in TBSTYLE_LIST toolbars. 2008-11-06 11:55:56 +01:00
Sergey Khodych 1232b08449 comctl32: toolbar: Calculate a correct size for empty buttons with the BTNS_AUTOSIZE style. 2008-11-06 11:55:51 +01:00
Reece Dunn 5c76b4da73 comctl32: Support themed check boxes and radio buttons. 2008-11-05 13:14:13 +01:00
Reece Dunn 1f9cc20466 comctl32: Support themed push buttons. 2008-11-05 13:13:29 +01:00
Aric Stewart e46a875996 comctl32: Add implementation of LVS_EX_ONECLICKACTIVATE. 2008-11-05 10:55:05 +01:00
Michael Stefaniuc 62e17fa8c4 comctl32: Do not cast zero. 2008-11-04 11:26:22 +01:00
Michael Stefaniuc 06c4de0461 comctl32/tests: Use MAKELPARAM instead of "(LPARAM) MAKELONG". 2008-11-04 11:26:01 +01:00
Michael Stefaniuc d4b8948ce3 comctl32: Do not cast NULL. 2008-11-03 13:41:58 +01:00
Lei Zhang 913373d2e6 comctl32: Only update comboex edit box if the mask has CBEIF_TEXT set. 2008-10-29 13:29:33 +01:00
Lei Zhang 2881b171df comctl32: Reset nEditLabelItem in LISTVIEW_EndEditLabelT. 2008-10-29 13:29:33 +01:00
Lei Zhang 10d3ea30b7 comctl32: Don't notify if listview edit box contents have not changed. 2008-10-29 13:29:33 +01:00
Lei Zhang 9b057494d0 comctl32: Get rid of DragDetect. 2008-10-29 13:29:33 +01:00
Michael Stefaniuc b12fbe1630 comctl32: HANDLE/HGLOBAL are basically just void pointers. No casts to other pointers are needed. 2008-10-29 11:52:22 +01:00
Michael Stefaniuc d1791f8108 comctl32: Remove superfluous casts as HANDLE to other handle types. 2008-10-28 12:34:05 +01:00
Clinton Stimpson 9f1ea3f15b comctl32: Fix getting of min size of monthcal when changing font. 2008-10-27 11:41:56 +01:00
Michael Stefaniuc 092b892f54 comctl32: HGDIOBJ is interchangeable with other handle types so don't cast. 2008-10-27 11:29:46 +01:00
Michael Stefaniuc 758f799205 comctl32: Just use 0 instead of casting NULL twice to an integer type. 2008-10-27 11:28:12 +01:00
Michael Stefaniuc 6060ca9438 comctl32: LockResource() returns a LPVOID so don't cast its return value. 2008-10-24 14:24:59 +02:00
Michael Stefaniuc 1659313142 comctl32: DPA_GetPtr() returns a LPVOID so don't cast its return value. 2008-10-24 14:24:59 +02:00
Michael Stefaniuc b723e6f6b6 comctl32: Remove the superfluous casting of the LPVOID returned by Alloc(). 2008-10-24 14:24:59 +02:00
Paul Vriens aad6125340 comctl32/tests: Use win_skip instead of trace. 2008-10-21 11:43:41 +02:00
Paul Vriens 1b494e7f31 comctl32/tests: Use win_skip instead of trace. 2008-10-21 11:43:36 +02:00
Detlef Riekenberg 2910b90c70 comctl32/tests: Fix tests to not depend on 96 dpi, make it pass in Wine. 2008-10-14 14:02:28 +02:00
Muneyuki Noguchi 9035894fff comctl32: Convert Japanese resource to UTF-8. 2008-10-13 11:40:51 +02:00
James Hawkins a7762476f2 comctl32: Fix MCM_SETFIRSTDAYOFWEEK when the first day set is greater than max allowed. 2008-10-10 12:28:11 +02:00
Michael Stefaniuc 15e5f6844a comctl32: Use FAILED instead of !SUCCEEDED. 2008-10-08 13:42:47 +02:00
Paul Vriens d0dfd9d784 comctl32/tests: Don't crash on some win9x boxes. 2008-10-02 10:41:26 -05:00
James Hawkins 23d899d8ab comctl32: Only log system messages. 2008-10-01 11:41:59 -05:00
James Hawkins 3e8a63d5fa comctl32: Fix several test failures in win2k. 2008-10-01 11:41:54 -05:00
James Hawkins e1111a5bef comctl32: Only log system messages. 2008-10-01 11:41:45 -05:00
Lei Zhang 60d97040f8 comctl32: Avoid a divide by zero in listview. 2008-09-30 10:56:55 -05:00
James Hawkins 2f8830d55b comctl32: Fix a test on locales where default first day of week is not the max value. 2008-09-29 17:25:30 -05:00
Francois Gouget 1177bbaa9e comctl32/tests: Don't crash if adding the tooltip failed. 2008-09-29 17:24:55 -05:00
Francois Gouget 17d798eae9 comctl32/tests: FreeMRUList(NULL) crashes on Win98 OSR0. 2008-09-29 17:23:48 -05:00
Muneyuki Noguchi adb32f76fc comctl32: Use "MS Shell Dlg" 9 in Japanese resources. 2008-09-29 17:17:19 -05:00
James Hawkins 56260ec782 comctl32: Add a missing newline. 2008-09-24 13:11:55 +02:00
James Hawkins 921f67a607 comctl32: Fix a failing test in win95. 2008-09-24 13:11:51 +02:00
James Hawkins 0f38a6c881 comctl32: Fix several failing tests in win95. 2008-09-24 13:11:30 +02:00
Alexandre Julliard 8552b50640 comctl32/tests: Fix a couple of message test failures. 2008-09-22 12:15:11 +02:00
Andrew Talbot d0e860b8a3 comctl32: Sign-compare warnings fix. 2008-09-22 11:52:15 +02:00
Jan de Mooij 403221c228 comctl32/treeview: Fix pszText NULL pointer dereference. 2008-09-18 13:26:19 +02:00
Nicolas Le Cam 47bcdc32a4 comctl32/tests: Fix a failing test for some platforms. 2008-09-16 11:28:58 +02:00
Nicolas Le Cam af78a7bfe4 comctl32: Fix a failing test for some platforms. 2008-09-15 13:38:58 +02:00
Andrew Talbot 183f92b22a comctl32: Sign-compare warnings fix. 2008-09-15 11:47:45 +02:00
James Hawkins 72638e0ea4 comctl32: Fix the remaining broken tests in win95. 2008-09-15 11:29:39 +02:00
James Hawkins 3b5c2cba44 comctl32: Fix several failing tests in win95. 2008-09-15 11:29:33 +02:00
Lei Zhang fc2404bc20 comctl32: Handle listview dragging better. 2008-09-11 12:33:01 +02:00
Lei Zhang 5f9b0db217 comctl32: listview: Prevent DragDetect from removing WM_LBUTTONUP messages. 2008-09-11 12:32:53 +02:00
James Hawkins cc0ea85c34 comctl32: Store the previous timeout value to test with. 2008-09-09 11:46:17 +02:00
Gerald Pfeifer 3dbdb31128 comctl32: Remove unused paramters from MONTHCAL_GetRange, MONTHCAL_MouseMove, and MONTHCAL_Create. 2008-09-09 11:46:14 +02:00
James Hawkins a061f642d6 comctl32: Fix two test failures in win2000. 2008-09-08 12:47:23 +02:00
James Hawkins e7d9185419 comctl32: Trace the first day of the week. 2008-09-08 12:47:23 +02:00
James Hawkins 66e4be152a comctl32: Fix a failing test for some platforms. 2008-09-08 12:47:23 +02:00
James Hawkins 3e2ac662f1 comctl32: Fix a typo. 2008-09-08 12:47:22 +02:00
James Hawkins 106791c610 comctl32: Fix several test failures in win98. 2008-09-08 12:47:22 +02:00
James Hawkins 66483daf34 comctl32: Fix a failing test in win98. 2008-09-08 12:47:22 +02:00
James Hawkins dcc230c567 comctl32: Fix a couple failing tests in win98. 2008-09-08 12:47:22 +02:00
James Hawkins d54963e512 comctl32: Allow a little slop in the status bar metric tests. 2008-09-08 12:47:22 +02:00
James Hawkins f5e298d2db comctl32: Fix several failing tests in win98. 2008-09-08 12:47:22 +02:00
James Hawkins 5362bfa776 comctl32: Fix two failing tests in win98. 2008-09-08 12:47:22 +02:00
Marcus Meissner 96412ee564 Annotate with allocation size attribute. 2008-09-05 11:22:26 +02:00
Nicolas Le Cam 22e69c0ee4 comctl32: Implement LVM_GETUNICODEFORMAT. 2008-09-04 11:51:40 +02:00
James Hawkins 99a5afa616 comctl32: Fix a failing test in win9x. 2008-09-03 14:21:42 +02:00
James Hawkins a9086abac6 comctl32: Fix a failing test in win98. 2008-09-03 14:21:42 +02:00
Aric Stewart bf6e766df6 comctl32: monthcal: Set the stStart parameter when sending the MCN_GETDAYSTATE notification. 2008-09-02 13:34:02 +02:00
Hongbo Ni a2ac029599 comctl32: Add traditional Chinese resources. 2008-09-02 11:57:32 +02:00
Alexandre Julliard c5ef467f4d comctl32: Rename the Chinese resources to comctl_Zh.rc. 2008-08-29 13:53:21 +02:00
James Hawkins 24bd8c0faf comctl32: Fix a failing test in win2000. 2008-08-29 13:26:07 +02:00
James Hawkins fd16a61128 comctl32: Trace the message sequences. 2008-08-29 13:26:02 +02:00
James Hawkins 72f55763f6 comctl32: Fix a test failure in win98. 2008-08-29 13:25:57 +02:00
James Hawkins eb86c5bb12 comctl32: Fix several test failures in win98. 2008-08-29 13:24:58 +02:00
James Hawkins f126c765c7 comctl32: Fix a failing test in XP. 2008-08-29 13:21:01 +02:00
James Hawkins 1258e4d8ff comctl32: Fix a few failing tests in win2000. 2008-08-29 13:20:53 +02:00
Hongbo Ni e2f5ab434a comctl32: Convert simplified Chinese resource to utf8. 2008-08-27 13:21:22 +02:00
Paul Vriens 2d18e5aac4 comctl32/tests: Don't assert on not implemented function. 2008-08-27 13:21:21 +02:00
Hongbo Ni a8a359ac68 comctl32: Update simplified Chinese resource. 2008-08-22 10:40:43 +02:00
Lei Zhang 098dc7b330 comctl32: Set listview focus on WM_LBUTTONUP instead of WM_LBUTTONDOWN. 2008-08-21 14:11:58 +02:00
Rob Shearman 6181419b64 comctl32: Fix use of arithmetic operator on Boolean type in TREEVIEW_ComputeItemInternalMetrics.
Use a conditional operator to get the same result, but improving
readability of the code.
2008-08-18 17:34:12 +02:00
Lei Zhang fc6553973f comctl32: Add a test for TTM_GETTEXT. 2008-08-18 17:15:56 +02:00
Will Tipton accb5f8faf comctl32: Added input validation to TOOLTIPS_GetTextW() in order to handle gracefully the case where it is called with an empty tooltip. 2008-08-18 17:15:56 +02:00
Paul Vriens 47edb3cbab comctl32/tests: Run tests again on Win95. 2008-07-30 13:50:39 +02:00
Gerald Pfeifer 1cdb06c69c comctl32: Remove unused parameter from _read_bitmap(). 2008-07-29 13:53:42 +02:00
Gerald Pfeifer d585d42209 comctl32: Push down function scope variable into the different case statements which allows us using more specific types in case. 2008-07-29 13:53:36 +02:00
Reece Dunn e7d22dc966 comctl32: Made the button theme drawing code extensible. 2008-07-24 12:08:42 +02:00
Nicolas Le Cam 5cf418f521 comctl32/tests: Fix a test failure in multiple platforms. 2008-07-23 13:54:00 +02:00
Mikołaj Zalewski 9a70306c53 comctl32: statusbar: Optimize STATUSBAR_RefreshPart. 2008-07-23 11:21:38 +02:00
Mikołaj Zalewski 72d4318c8c comctl32: statusbar: Test and fix SB_SETMINHEIGHT.
The minimal height should be saved so that it survives WM_SIZE or WM_SETFONT.
2008-07-23 11:21:18 +02:00
Mikołaj Zalewski a289bab122 comctl32: toolbar: TB_SETBITMAPSIZE should not change a coordinate when passed -1 (with testcase). 2008-07-23 11:20:58 +02:00
Gerald Pfeifer ec351ad16f comctl32: datetime: Simplify by shedding off unused parameters. 2008-07-22 15:25:25 +02:00
Mikołaj Zalewski 60a1e20ba8 comctl32: Don't print ERRs for reflected messages. 2008-07-22 13:25:08 +02:00
Mikołaj Zalewski f240b8f49e comctl32: statusbar: Change the height expression to one that seems to be the same as in Windows. 2008-07-22 13:24:43 +02:00
Gerald Pfeifer f3a031f248 comctl32: Fix type of loop variable in HEADER_DeleteItem. 2008-07-21 15:06:05 +02:00
Gerald Pfeifer 9500e70def comctl32: header: Simplify by shedding off unused parameters. 2008-07-21 15:05:47 +02:00