Jacek Caban
48aab01d65
advapi32: Initialize retkey value in open_key.
...
Office 2013 registry virtualization depends on this. Its NtOpenKey[Ex]
hook doesn't set it to NULL, but it's expected to be NULL.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-17 16:19:47 -07:00
Jacek Caban
41c7d1e227
advapi32: Pass options argument to NtOpenFileEx.
...
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-17 16:19:47 -07:00
Hans Leidekker
bacc68822a
advapi32: Add a stub implementation of EnableTraceEx2.
...
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-04 14:51:51 +02:00
André Hentschel
49f2d424ac
advapi32/tests: Don't crash the service test on wow64 Wine.
...
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-10-03 20:43:00 +02:00
Austin English
e6e8ed47e6
advapi32: Add EventWriteTransfer stub.
...
Signed-off-by: Austin English <austinenglish@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-09-21 00:19:17 +09:00
Sebastian Lackner
a388cc1ff9
advapi32: Use variable of correct type to store LSTATUS result.
...
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-09-13 22:41:03 +09:00
Sebastian Lackner
1c5affa205
advapi32: Unify service startup and control handling.
...
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-31 22:22:59 +09:00
Sebastian Lackner
2263baaf2e
advapi32: Do not stop service main thread as long as there are still running services.
...
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-18 00:09:37 +09:00
Sebastian Lackner
13bb213aeb
advapi32: Hold lock while handling service thread shutdown.
...
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-18 00:09:37 +09:00
Sebastian Lackner
63c36da6da
advapi32: Hold lock while processing service controls.
...
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-18 00:09:37 +09:00
Sebastian Lackner
f4590e91eb
advapi32: Simplify RegisterServiceCtrlHandlerExW.
...
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-18 00:09:36 +09:00
Sebastian Lackner
8f8626feef
services: Implement functionality to transfer extra data when sending service control.
...
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-10 16:17:29 +09:00
Sebastian Lackner
7a200887bb
advapi32: Validate received service name.
...
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-10 16:16:49 +09:00
Austin English
ec45ce75b6
advapi32: Add stubs for some advapi32 wmi functions.
...
Signed-off-by: Austin English <austinenglish@gmail.com>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-04 11:00:30 +09:00
André Hentschel
4464793e60
advapi32/tests: Allow Win8+ flags for Admins ACE.
...
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-23 12:04:12 +09:00
André Hentschel
9db9c9ef5a
advapi32/tests: Allow MACHINE\Software to be owned by local system.
...
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-23 12:04:10 +09:00
Andrey Gusev
2c598e5523
advapi32: Fix a typo in comment.
...
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-03 12:30:39 +09:00
Frédéric Delanoy
1d131cff6e
advapi32: Use dbgstr_a() to print string in a FIXME.
...
Signed-off-by: Frédéric Delanoy <frederic.delanoy@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-23 14:09:26 +09:00
Francois Gouget
0beaaa6bc2
advapi32/tests: Some spelling fixes for the security ok() messages.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-19 14:56:58 +09:00
Sebastian Lackner
df77e490d8
advapi32: Fix return value of RegNotifyChangeKeyValue for pending events.
...
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-06 00:31:20 +09:00
Alexandre Julliard
303daeef58
advapi32: Fix null termination in RegQueryInfoKeyA.
...
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-15 14:10:41 +09:00
Jacek Caban
e625e86ee1
kernel32: Don't set unconditionally SECTION_QUERY flag in OpenFileMapping.
...
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-14 13:54:52 +09:00
André Hentschel
b83a5d78a4
advapi32: Add CreatePrivateObjectSecurityEx.
...
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-14 13:54:52 +09:00
Louis Lenders
eee837e931
ntdll: Add stub for RtlAddAccessDeniedObjectAce and forward to AddAccessDeniedObjectAce in advapi32.
...
Signed-off-by: Louis Lenders <xerox.xerox2000x@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-07 13:23:06 +09:00
Louis Lenders
c63d417222
ntdll: Add stub for RtlAddAccessAllowedObjectAce and forward to AddAccessAllowedObjectAce in advapi32.
...
Signed-off-by: Louis Lenders <xerox.xerox2000x@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-03 12:58:27 +09:00
Sebastian Lackner
2ddcd97bb1
advapi32: Fix RegDeleteTreeW when an empty string is passed.
...
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-02 23:29:26 +09:00
Hugh McMaster
50c5a2ce2e
advapi32/tests: Add tests for deleting the default value.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-01 21:35:40 +09:00
Hugh McMaster
80383dcf39
advapi32/tests: Fix typos.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-01 21:35:24 +09:00
Louis Lenders
d37b3f59e9
ntdll: Add stub for RtlAddAuditAccessObjectAce and forward to AddAuditAccessObjectAce in advapi32.
...
Signed-off-by: Louis Lenders <xerox.xerox2000x@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-01 18:51:44 +09:00
Frédéric Delanoy
1bccc8b027
advapi32/tests: Use todo_wine_if() in tests.
...
Signed-off-by: Frédéric Delanoy <frederic.delanoy@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-29 20:05:01 +09:00
Sebastian Lackner
3f5457accf
advapi32: Simplify and clean up RegDeleteTree implementation.
...
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-29 20:05:01 +09:00
Michael Müller
6b7c576bc5
advapi32: Implement RegCopyTreeA/W.
...
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-29 20:05:01 +09:00
Sebastian Lackner
8358fd1c26
advapi32/tests: Add tests for RegCopyTree.
...
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-29 20:05:00 +09:00
Sebastian Lackner
ae0dc70bb0
advapi32/tests: Improve RegDeleteTree tests.
...
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-29 20:05:00 +09:00
Jacek Caban
d2d40b1da3
ntdll: Moved RegisterTraceGuids[AW] implementation to ntdll.
...
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-25 22:45:08 +09:00
Qian Hong
954ca154ac
advapi32/tests: Add more invalid parameter tests for AccessCheck.
...
Signed-off-by: Qian Hong <qhong@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-19 19:37:41 +09:00
Charles Davis
09b1467575
advapi32: Don't print 32-bit values as long integers.
...
Signed-off-by: Charles Davis <cdavis5x@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-19 00:49:11 +09:00
Qian Hong
86c4790721
advapi32/tests: Add invalid parameter tests for AccessCheck.
...
Signed-off-by: Qian Hong <qhong@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-16 23:26:30 +09:00
André Hentschel
4684dc2bfb
advapi32/tests: Use todo_wine_if() in tests.
...
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-16 12:09:39 +09:00
Nikolay Sivov
2abec634ac
advapi32/tests: Simplify tests using todo_wine_if().
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-12 12:17:44 +09:00
Michael Müller
c937cf6ad2
advapi32/tests: Add tests for Win8 pseudo handles.
...
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-11 12:15:57 +09:00
Francois Gouget
7371c44336
advapi32/tests: Trace the SIDs if they are not as expected.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-28 21:27:34 +09:00
Nikolay Sivov
62d3309a72
advapi32: Make RegOpenCurrentUser() return real key handles for current SID.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-05 17:53:17 +01:00
Sebastian Lackner
723146ca6d
advapi32: Add stubs for RegCreateKeyTransacted[A/W] functions.
...
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-24 11:30:41 +01:00
Michael Müller
79636bebbf
advapi32: Set last error to ERROR_SUCCESS in GetSidIdentifierAuthority.
...
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-09 00:53:41 +09:00
Nikolay Sivov
f611fcafd8
advapi32: Use proper enum member to initialize SECURITY_IMPERSONATION_LEVEL variable (Clang).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-02 12:58:25 +09:00
Vincent Povirk
f742b05d77
advapi32/tests: Skip test when registry virtualization can't delete values.
...
Signed-off-by: Vincent Povirk <vincent@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-23 13:14:13 +09:00
Alexandre Julliard
eafdbdd13b
advapi32: Don't try to create the registry root.
...
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-20 20:28:53 +09:00
Hugh McMaster
11669fa5e2
Assorted spelling and grammar fixes.
...
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-17 22:56:40 +09:00
Sebastian Lackner
96f4f53937
server: Do not require SeBackupPrivilege in load_registry and unload_registry.
...
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-16 17:26:22 +09:00
Jacek Caban
ba081cab56
advapi32: Use absolute registry paths to create special root keys.
...
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-13 11:53:09 +09:00
Jacek Caban
fdc6f610c3
advapi32: Added DECLSPEC_HOTPATCHABLE to CreateProcessAsUser[AW] functions.
...
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-13 11:53:01 +09:00
Jacek Caban
3d5db6bdf5
server: Return KeyFullInformation maximal string lengths in bytes.
...
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-12 11:32:49 +09:00
Jacek Caban
a0d0d0dd0a
ntdll: Fixed argument order in NtNotifyChangeKey.
...
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-06 23:20:50 +09:00
Jacek Caban
b4eab7146f
advapi32: Pass SYNCHRONIZE flag in NtCreateFile and NtOpenFile calls.
...
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-30 21:01:56 +09:00
Jacek Caban
a754579159
advapi32: Added FIXME about an unsupported argument and initialize its value.
...
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-16 20:04:38 +09:00
Jacek Caban
5935e9509b
advapi32/tests: Properly test sdlen value.
...
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-16 20:04:30 +09:00
Nikolay Sivov
076f50ee6c
advapi32/tests: Simplify conditional expression (PVS-Studio).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-13 23:35:24 +09:00
Dmitry Timoshkov
d2f0bc2f74
advapi32: Add CreatePrivateObjectSecurityWithMultipleInheritance semi-stub.
...
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-11 13:46:21 +09:00
Alex Henrie
18b7ec9479
advapi32: Remove always-true if statements from RegEnumValue[AW].
...
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
2015-10-07 21:28:50 +09:00
Michael Müller
9eb8aa1ebb
advapi32: Mark some registry functions as hotpatchable.
...
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
2015-10-05 22:27:14 +09:00
Hans Leidekker
a5b4ed75cf
advapi32/tests: Avoid more test failures.
2015-09-11 18:21:58 +09:00
Hans Leidekker
ca32deb0d2
advapi32/tests: Perform a case-insensitive match on domain names.
2015-09-07 18:52:18 +09:00
Hans Leidekker
b368cd1b71
advapi32/tests: Avoid test failures when running as an unprivileged user.
2015-09-07 18:52:16 +09:00
Vincent Povirk
997484964a
advapi32: RegOpenKeyEx can return special roots when asked for empty subkey.
2015-09-01 15:24:14 +09:00
Matt Durgavich
b573986188
advapi32/tests: Fix for crashes on Mac OS X.
2015-08-27 21:43:46 +09:00
Hans Leidekker
3a771b6066
advapi32: Add well-known SID WinBuiltinAnyPackageSid.
2015-08-26 23:15:26 +09:00
Dmitry Timoshkov
48ed6a6f3e
advapi32/tests: Add a test to show that THREAD_QUERY_INFORMATION should grant THREAD_QUERY_LIMITED_INFORMATION.
2015-08-20 17:35:13 +09:00
Alistair Leslie-Hughes
3b5107d063
advapi32: Prevent buffer overrun.
2015-08-19 21:46:05 +09:00
Dmitry Timoshkov
9e22949cec
advapi32/tests: Add a test to show that PROCESS_QUERY_INFORMATION should implicitly grant PROCESS_QUERY_LIMITED_INFORMATION access.
2015-08-19 20:19:57 +09:00
Dmitry Timoshkov
8a088d7c2f
advapi32/tests: Fix compilation with PSDK.
2015-08-19 20:19:56 +09:00
Eric Kohl
424f010ac1
advapi32: Add some well-known SDDL SID strings.
2015-08-19 20:19:55 +09:00
Hans Leidekker
09de5cdb38
advapi32: Add a stub implementation of RegisterWaitChainCOMCallback.
2015-08-03 20:50:33 +02:00
Huw Davies
3e55f1d2cc
advapi32: Don't call CloseServiceHandle() with an invalid handle.
2015-07-16 21:20:44 +09:00
Bernhard Übelacker
eecd136cb7
advapi32: Fail in RegEnumValue on missing value or val_count parameters.
2015-07-08 16:02:25 +09:00
Michael Müller
4f3acf31de
advapi32: Add initial implementation for GetWindowsAccountDomainSid.
2015-06-24 23:01:45 +09:00
Michael Müller
54b3973ee0
advapi32/tests: Add tests for GetWindowsAccountDomainSid.
2015-06-24 23:01:45 +09:00
Sebastian Lackner
a176655414
advapi32/tests: Explicitly check return value of GetTokenInformation.
2015-06-24 22:57:37 +09:00
Huw Davies
645a31474c
Revert "advapi32: Fix RegEnumValueW when enumerating long values.".
...
This reverts commit 443ef6e7a6
.
The tests fail on all versions of Windows.
2015-06-23 15:04:03 +09:00
Bernhard Übelacker
443ef6e7a6
advapi32: Fix RegEnumValueW when enumerating long values.
2015-06-22 20:58:23 +09:00
Hans Leidekker
1fb3f9cb15
advapi32/tests: Add tests to show that reading the SACL requires a special privilege.
2015-06-17 22:37:01 +09:00
Sebastian Lackner
e24eb501d3
advapi32: Forward ImpersonateAnonymousToken to ntdll.
2015-05-21 13:57:27 +09:00
Thomas Faber
817d903cb9
advapi32: Write back partial results in RegQueryInfoKeyA.
2015-05-20 17:26:44 +09:00
Thomas Faber
87b6d42c12
advapi32: Do not fail in RegQueryInfoKey if *class_len is 0.
2015-05-20 17:26:24 +09:00
Thomas Faber
b6c31bea3d
advapi32: Use STATUS_BUFFER_TOO_SMALL for buffer overflows in RegQueryInfoKeyW.
2015-05-20 17:25:56 +09:00
Thomas Faber
b8bcec140c
advapi32/tests: Add tests for RegQueryInfoKey.
2015-05-14 15:13:55 +09:00
Martin Storsjo
518e102a7e
advapi32: Add a stub implementation of EventSetInformation.
2015-05-11 15:39:24 +09:00
Hans Leidekker
191b1bfbba
advapi32: Return fake handles from RegisterTraceGuidsW.
2015-04-24 22:04:29 +09:00
Hans Leidekker
985e226c07
advapi32: Support parsing mandatory label ACE strings.
2015-04-17 14:53:13 +09:00
Piotr Caban
52df833a72
advapi32: Handle NULL DACL in SetSecurityInfo.
2015-04-03 17:07:44 +09:00
Sebastian Lackner
9e0045e167
advapi32/tests: Add tests for CreateFile with set security descriptor.
2015-04-01 22:34:19 +09:00
Sebastian Lackner
bfcfceec39
advapi32/tests: Merge common code to test DACL descriptors in a helper function.
2015-04-01 22:34:19 +09:00
Sebastian Lackner
3e47270b68
advapi32/tests: Add tests for NtCreateFile inheritance when security descriptor is set.
2015-03-31 14:49:14 +09:00
Sebastian Lackner
80b384311f
advapi32/tests: Repeat ACL inheritance tests for NtCreateFile.
2015-03-31 14:49:10 +09:00
Erich E. Hoover
404d5bf09d
advapi32/tests: Add tests for inheriting ACL attributes.
...
CreateFile should also inherit ACL from the parent directory.
2015-03-31 14:49:02 +09:00
Piotr Caban
00b3f055be
server: Fix DACL to permissions conversion.
2015-03-31 00:04:43 +09:00
Piotr Caban
966c5dffed
ntdll: Improve parameter validation in RtlAddAce.
2015-03-30 20:03:44 +09:00
Piotr Caban
f974d72672
advapi32: Add DACL inheritance support in SetSecurityInfo.
2015-03-27 20:46:02 +09:00
Piotr Caban
a4b12eb9f9
advapi32/tests: Add test for mapping DACL to permission.
...
This test shows that first DACL entry that allows or denies access
should be used. The logic inside server for translating DACL to
permission is not matching it (always scans all DACL entries, deny
entries have bigger priority).
2015-03-27 20:45:49 +09:00
Piotr Caban
02c4f5bd27
advapi32: Add SetNamedSecurityInfo test with empty DACL.
2015-03-27 20:45:07 +09:00