Marcus Meissner
2d5ca30994
wininet: Removed redundant NULL check (Coverity).
2008-11-03 11:50:10 +01:00
Nicolas Le Cam
6c7720e2ce
wininet/tests: Fix a failing test on IE6.
2008-10-28 13:26:22 +01:00
Hans Leidekker
bd80529709
wininet: Add an exception handler in HttpOpenRequestA to protect against invalid accept type pointers.
2008-10-24 14:25:00 +02:00
Hans Leidekker
4615b1c0b4
wininet: Fix buffer size query for InternetQueryOption(INTERNET_OPTION_PROXY).
2008-10-17 20:16:06 +02:00
Hans Leidekker
4a6b856ff2
wininet: Add a test for basic authentication.
2008-10-17 14:12:37 +02:00
Hans Leidekker
d5dca63cb6
wininet: Don't destroy authentication data when closing the connection.
...
Fixes basic authentication in combination with connection close semantics.
Spotted by Vincent Povirk.
2008-10-17 14:12:33 +02:00
Michael Stefaniuc
61d77284ae
wininet: Remove duplicated header includes.
2008-10-16 11:28:08 +02:00
Austin English
3d143253e4
wininet: Quiet a noisy fixme.
2008-10-15 14:02:20 +02:00
Muneyuki Noguchi
66bcb9c689
wininet: Convert Japanese resource to UTF-8.
2008-10-13 11:41:30 +02:00
Paul Vriens
eba92bd7ee
wininet/tests: Don't crash on W2K and below.
2008-10-09 12:14:37 +02:00
Jan-Peter Nilsson
b261836709
wininet: Fix HTTP_ProcessCookies only processing one cookie.
2008-10-08 14:17:08 +02:00
Juan Lang
f50b2c237d
wininet: Fix trace typo.
2008-10-08 12:17:52 +02:00
Juan Lang
9189bf3d72
wininet: Don't call URL_LocalFileNameToPathA when asked for a unicode string and URL_LocalFileNameToPathW fails.
2008-10-08 12:17:45 +02:00
Juan Lang
024c13c174
wininet: Trace the cache file entry's local file name rather than the passed-in cache entry info's local file name, as the caller may have passed a NULL pointer.
2008-10-08 12:17:37 +02:00
Rob Shearman
0715d9c123
wininet: Fix crash when calling HttpQueryInfoA/W(HTTP_QUERY_RAW_HEADERS) before any response has been received from a server.
2008-10-08 12:17:11 +02:00
Rob Shearman
dbd1800ab2
wininet: Get rid of rc variable in InternetReadFile_test.
...
All of the tested functions return BOOLs, not DWORDs so use res instead of rc.
2008-10-08 12:17:05 +02:00
Rob Shearman
0c75ead3e8
wininet: Validate parameters passed to RetrieveUrlCacheEntryInfoA/W.
...
Add tests for this.
2008-10-08 12:16:59 +02:00
Hans Leidekker
128b8a5e0c
wininet: Avoid a crash on certain buffer size queries in HTTP_HttpQueryInfoW.
2008-10-07 12:03:12 +02:00
Hans Leidekker
096fa3b9f5
wininet: Option INTERNET_OPTION_CALLBACK is not settable.
2008-10-07 12:02:54 +02:00
Rob Shearman
7ffaafb265
wininet: Fix behaviour of InternetTimeFromSystemTimeA/W when dealing with invalid parameters.
2008-10-06 13:07:56 +02:00
Rob Shearman
2584323ff9
wininet: Add tests for passing invalid parameters into InternetTimeFromSystemTimeA/W.
2008-10-06 13:07:49 +02:00
Rob Shearman
ab849ee297
wininet: Fix GetUrlCacheEntryInfoA/W when a NULL lpCacheEntryInfo parameter is passed in.
2008-10-06 13:07:43 +02:00
Rob Shearman
d929cdef97
wininet: Return error codes explicitly from URLCache functions instead of returning a BOOL and storing the error code in the last error value.
...
This makes the code more efficient and allows errors from functions to
be ignored without side-effects.
2008-10-06 13:07:36 +02:00
Rob Shearman
f55afa8a59
wininet: Move internet time tests from http.c to internet.c.
2008-10-02 10:29:31 -05:00
Rob Shearman
fa066c74e3
wininet: Fix behaviour of InternetTimeFromSystemTimeA/W when a buffer that is too small is passed in.
2008-10-02 10:29:19 -05:00
Rob Shearman
ef0e3792bb
wininet: Add tests for InternetTimeFromSystemTimeW with insufficient buffer.
2008-10-02 10:29:15 -05:00
Rob Shearman
573abdca4a
wininet: Make WININET_AllocHandle 64-bit safe by using the correct type in the sizeof expression.
2008-10-01 11:44:25 -05:00
Rob Shearman
d31ce9ae37
wininet: Compare HRESULT values explicitly against S_OK instead of using an implicit != 0 comparison.
2008-10-01 11:43:30 -05:00
Muneyuki Noguchi
6c0c3fdaac
wininet: Use "MS Shell Dlg" 9 in Japanese resources.
2008-09-29 17:17:09 -05:00
Hans Leidekker
8c20124fc4
wininet: Support setting username and password through options.
2008-09-25 11:51:41 +02:00
Muneyuki Noguchi
8d97c6e1ab
wininet: Update Japanese translation.
2008-09-08 14:08:01 +02:00
Hongbo Ni
ab08a0102f
wininet: Add simplified and traditional Chinese resources.
2008-09-04 11:42:45 +02:00
Lei Zhang
f7e56d19c4
wininet: Remove redundant CrLf variables.
2008-08-28 11:24:50 +02:00
Lei Zhang
bc9e214f6f
wininet: Work around NULL headers when handling HTTP_QUERY_RAW_HEADERS_CRLF.
2008-08-28 11:24:50 +02:00
Alexandre Julliard
220bc61c21
Include sys/filio.h to get the FIONREAD definition on Solaris.
2008-08-26 20:40:57 +02:00
Alexandre Julliard
8f3a7a8494
wininet/tests: Add a couple more optional notifications.
2008-08-26 20:40:28 +02:00
Alexandre Julliard
9bded7bb2a
wininet: Avoid testing errno when it isn't set. Simplify NETCON_getNextLine a bit.
2008-08-26 20:40:09 +02:00
Alexandre Julliard
1f563440aa
wininet/tests: Add support for optional notifications. Fix the test to pass again on Windows and Wine.
2008-08-26 12:07:42 +02:00
Vincent Povirk
17c0c0a54b
wininet: Default to keep-alive when the server is HTTP/1.1, not when it isn't.
2008-08-19 14:56:06 +02:00
Hans Leidekker
3c43a6568f
wininet: Properly initialize access type when no proxy is configured.
2008-08-04 13:04:16 +02:00
Hans Leidekker
daa2fdfccb
wininet: Use getaddrinfo for thread-safe resolving if available.
2008-08-04 13:04:12 +02:00
Colin Finck
a33d7fc8c9
Fix some hackish usages of WideCharToMultiByte.
2008-07-31 14:08:29 +02:00
Dan Kegel
1e7f89194c
wininet: HTTP_QUERY_RAW_HEADERS_CRLF length shouldn't include nul.
2008-07-31 14:02:04 +02:00
Francois Gouget
eb16f43bdf
Add some API documentation stubs to make winapi_check happy.
2008-07-28 11:34:45 +02:00
Hans Leidekker
216d4c0834
wininet: Fix cookie buffer overflow.
...
Spotted by Yann Droneaud.
2008-07-21 12:22:05 +02:00
Hans Leidekker
572b0bab88
wininet: Move insertion of cookie header from HttpOpenRequest to HttpSendRequest.
...
Based on a patch by Yann Droneaud.
2008-07-21 12:21:58 +02:00
Hans Leidekker
b311cca552
wininet: Delete local file on error in FtpGetFile.
2008-07-21 12:21:40 +02:00
Hans Leidekker
a5c6455193
wininet: Make another test pass on IE6.
2008-07-21 12:21:33 +02:00
Hans Leidekker
e3e2622e41
wininet: Fix a memory leak.
2008-07-21 12:21:27 +02:00
Jacek Caban
9f5748e6b4
wininet: Move remeining InternetQueryOption implementation to vtbl.
2008-07-21 12:19:12 +02:00
Jacek Caban
46f2628448
wininet: Moved InternetQueryOption(INTERNET_OPTION_PROXY) implementation to vtbl.
2008-07-21 12:18:57 +02:00
Jacek Caban
7426e7e055
wininet: Moved more InternetQueryOption implementation to vtbl.
2008-07-21 12:18:48 +02:00
Jacek Caban
13a95f1648
wininet: Move InternetQueryOption(INTERNET_OPTION_USER_AGENT) to vtbl.
2008-07-21 12:18:41 +02:00
Vincent Povirk
fd5b97bc4d
wininet: Always respect Proxy-Connection: or Connection: if it exists.
2008-07-17 10:51:26 +02:00
Andrew Talbot
6a26bccb8e
wininet: Remove unneeded address-of operators from array names.
2008-07-14 11:50:41 +02:00
Zac Brown
173cd38e68
wininet/tests: Change some traces to skips in tests.
2008-07-10 14:42:43 +02:00
Alexander Morozov
4f51b6c1d8
wininet: Add port number to Host HTTP header.
2008-07-07 14:16:07 +02:00
Alexander Morozov
ad2f53db8f
wininet: Add support of INTERNET_FLAG_NO_CACHE_WRITE.
2008-07-07 14:16:07 +02:00
Alexander Morozov
70218092bb
wininet: Remove unneeded variable.
2008-07-04 19:50:58 +02:00
Alexander Morozov
3ac3194527
wininet/tests: Add HTTP 1.1 test.
2008-07-03 13:08:18 +02:00
Alexander Morozov
9d23d8ecef
wininet/tests: Additional HTTP header tests.
2008-07-03 13:08:18 +02:00
James Hawkins
ce823a8e47
wininet: Fix a failing test in win2k.
2008-07-01 13:45:38 +02:00
Hans Leidekker
bdf311f91f
wininet: Only reconnect when redirected to an external site.
2008-06-30 15:08:47 +02:00
Hans Leidekker
fdc82adfcc
wininet: Allocate buffers in InternetCrackUrlA.
2008-06-30 15:08:33 +02:00
Hans Leidekker
c35a0428f6
wininet: Don't assume URL is null-terminated in InternetCrackUrlW.
2008-06-30 15:08:07 +02:00
Hans Leidekker
c3ecb7244b
wininet: More win64 compatibility fixes.
2008-06-30 15:07:47 +02:00
Hans Leidekker
01e21366cb
wininet: Avoid a crash on an invalid handle in InternetQueryOption.
2008-06-30 15:07:36 +02:00
Hans Leidekker
f1dc1bb070
wininet: Add a test for InternetCanonicalizeUrl.
2008-06-30 15:07:29 +02:00
Mikołaj Zalewski
9c030d4660
shlwapi: UrlCanonicalize should strip all the characters <= 32 from the end of the string.
2008-06-30 13:26:40 +02:00
Dan Kegel
bcdb10a9ed
wininet: InternetCrackUrlW: For URLs that have no urlpath, native clears lpszUrlPath.
2008-06-24 12:20:44 +02:00
Hans Leidekker
95d572dd7e
wininet: Make a test pass on IE6.
2008-06-24 11:45:33 +02:00
Hans Leidekker
e43cda6b54
wininet: Win64 compatibility fixes.
2008-06-24 11:45:27 +02:00
Hans Leidekker
6233704481
wininet: Resolve hostname once per connection.
2008-06-24 11:45:18 +02:00
Hans Leidekker
34ff555cf9
wininet: Send a 'Pragma: no-cache' header if asked for.
2008-06-24 11:45:10 +02:00
Hans Leidekker
ed38af127d
wininet: Improve some traces.
2008-06-24 11:45:03 +02:00
Hans Leidekker
3434935f44
wininet: Clear last error upon successful return from HttpSendRequest.
2008-06-24 11:44:57 +02:00
Rob Shearman
62e0a8ca38
wininet: Fix memory leak in HTTP_DeleteCustomHeader.
...
Free the memory associated with the field and value of the custom
header otherwise it will be leaked. Found by Valgrind.
2008-06-21 11:12:50 +02:00
Colin Finck
bbd550ad5c
wininet: Always pass a variable as lpNumberOfBytesWritten on a WriteFile call if lpOverlapped is set to NULL.
2008-06-19 11:47:03 +02:00
Rob Shearman
9060d2aaab
Update generated packing tests using current headers.
2008-06-18 15:21:48 +02:00
Michael Stefaniuc
b5186aab0d
wininet: Add the Romanian translation.
2008-06-13 10:17:22 +02:00
Hans Leidekker
656a035821
wininet: Don't send a "Connection: Close" header.
2008-06-02 14:05:32 +02:00
Hans Leidekker
a6dc4a9a44
wininet: Return success from the InternetSetOption(INTERNET_OPTION_DISABLE_AUTODIAL) stub.
2008-06-02 13:46:00 +02:00
Hans Leidekker
9d55252d41
wininet: Don't send a handle closing callback for session handles created with InternetOpenUrl.
2008-06-02 13:45:53 +02:00
Hans Leidekker
2f99450c49
wininet: Make resolving hostnames thread-safe.
2008-06-02 13:44:31 +02:00
Alexandre Julliard
7c61679989
wininet: Include openssl/ssl.h before Windows headers.
2008-06-02 12:14:37 +02:00
Dmitry Timoshkov
8f75f51c3f
wininet: INTERNET_InternetOpenUrlW is an internal helper.
2008-05-26 19:46:05 +02:00
Lei Zhang
bd58463eda
wininet: Send https scheme to proxy server when appropriate.
2008-05-22 11:44:29 +02:00
Francois Gouget
089221fcce
wininet/tests: Get the tests running again on Win98.
2008-05-22 11:43:18 +02:00
Francois Gouget
824842cac7
wininet/tests: Remove a stray reference to InternetSetStatusCallback().
2008-05-22 11:43:15 +02:00
Mikołaj Zalewski
14a42f802d
Make Swedish use SUBLANG_NEUTRAL.
2008-05-19 16:09:13 +02:00
Hans Leidekker
694a09284a
wininet: Fix buffer size query for HttpQueryInfo(HTTP_QUERY_RAW_HEADERS_CRLF).
2008-05-19 14:04:10 +02:00
Hans Leidekker
e1b889830d
wininet: INTERNET_STATUS_REQUEST_COMPLETE callback must supply a handle.
2008-05-19 13:35:24 +02:00
Rob Shearman
6021fa09f3
wininet: Fix a typo in is_basic_auth_value.
...
This fixes basic authentication when the server uses a realm string.
2008-05-19 13:35:19 +02:00
Alexandre Julliard
8354e6a93a
configure: Improve the libcrypto checks.
2008-05-13 10:42:54 +02:00
Hans Leidekker
6c8d315a72
wininet: Implement INTERNET_OPTION_USER_AGENT for InternetQueryOption.
2008-05-12 14:01:44 +02:00
Hans Leidekker
1c5bc9a772
wininet: HTTP_BuildProxyRequestUrl returns a pointer.
2008-05-12 14:01:06 +02:00
Hans Leidekker
a3ea34c56e
wininet: Partial implementation of InternetGet/SetCookieEx.
2008-05-12 14:01:01 +02:00
Hans Leidekker
3f795c621d
wininet: Make a test pass on IE6.
2008-05-12 14:00:56 +02:00
Hans Leidekker
aec0e93d23
wininet: Don't overwrite content length header in HttpSendRequest.
2008-05-12 14:00:51 +02:00
Lei Zhang
255eebe44d
wininet: Handle NULL input for FindCloseUrlCache.
2008-05-08 22:48:30 +02:00
Hans Leidekker
493b6915ca
wininet: Deal with bogus accept types array passed into HttpOpenRequestA.
2008-05-07 17:49:31 +02:00
Maarten Lankhorst
11a0e45304
wininet: Ignore INTERNET_STATUS_DETECTING_PROXY messages in the http test.
2008-05-07 12:11:08 +02:00
Jens Albretsen
d2f5a9b115
wininet: Danish translation.
2008-05-07 12:10:30 +02:00
Andrew Talbot
07ae2992b8
wininet: Remove unused variables.
2008-05-05 12:52:26 +02:00
Hans Leidekker
e2f690a0ac
wininet: Don't add the user agent header until HttpSendRequest is called.
2008-05-05 12:51:56 +02:00
Rob Shearman
64806e642f
wininet: Add tests for GetUrlCacheEntryInfoExA.
...
Factorise out bits of the other tests so that the code is cleaner and
can be re-used.
2008-04-30 17:00:06 +02:00
Rob Shearman
1ea7666c57
wininet: Don't crash in GetUrlCacheEntryInfoA/W if lpdwCacheEntryInfoBufferSize is NULL.
2008-04-30 17:00:02 +02:00
Dan Hipschman
d3051cba22
wininet: Don't forget the INTERNET_STATUS_REDIRECT callback in HttpEndRequest.
2008-04-24 12:03:34 +02:00
Dan Hipschman
a1ebffb452
wininet: Remove custom content-length/type headers from redirects.
2008-04-23 12:23:39 +02:00
Austin English
6e59cd2c34
Spelling fixes.
2008-04-22 12:20:12 +02:00
Louis Lenders
b3f7860917
wininet: Improve stub for FindNextUrlCacheEntryW a tiny bit.
2008-04-18 14:23:19 +02:00
Aric Stewart
bade2a31a6
wininet: Correct the case where Content-Length is set as well as Transfer-Encoding == chunked.
2008-04-18 11:45:52 +02:00
Vitaliy Margolen
9f82e4730b
wininet: Properly initialize struct.
2008-04-11 12:11:33 +02:00
Rok Mandeljc
59efdb3e80
wininet: Updated Slovenian translation.
2008-04-07 21:40:53 +02:00
Alexandre Julliard
631f469cb5
wininet: Avoid size_t type in trace.
2008-04-04 13:12:21 +02:00
Hans Leidekker
612f3c1414
wininet: Use INTERNET_MAX_URL_LENGTH to size buffers we intend to store a URL in.
2008-04-01 11:27:03 +02:00
Hans Leidekker
8210e1b454
wininet: Parse the redirect URL in HTTP_HandleRedirect in case of a proxy connection.
2008-04-01 11:26:52 +02:00
Hans Leidekker
729631d907
wininet: Remove dead code from HTTP_DealWithProxy and improve its debug trace.
2008-04-01 11:26:42 +02:00
Hans Leidekker
bbf5dae444
wininet: Use a direct connection for tests that connect to localhost.
2008-03-31 13:01:11 +02:00
Hans Leidekker
ed1cb1f099
wininet: Set ProxyEnable registry value if it isn't already set.
2008-03-31 13:01:01 +02:00
Hans Leidekker
e4c59c263d
wininet: Don't set the host port from the server port.
...
This works for direct connections but in case of proxy connections server
port and host port usually are different.
2008-03-31 13:00:42 +02:00
Hans Leidekker
0ffe9f5207
wininet: Fix redirects through a proxy.
...
HTTP_DealWithProxy replaces the request path with a full URL to make sure
a correct request is built for for the proxy. This will work just once in
case of a redirect because the path will be appended to the redirect url,
resulting in an incorrect url.
2008-03-31 13:00:32 +02:00
Hans Leidekker
454fae8432
wininet: Don't close proxy connections when keep-alive is specified.
2008-03-31 13:00:18 +02:00
Hans Leidekker
c7f93666c3
wininet: Support http_proxy environment variable.
...
Based on a patch by Mike Hearn.
2008-03-31 13:00:10 +02:00
Vitaliy Margolen
66417eea64
Update Russian translations.
2008-03-31 12:15:14 +02:00
Dan Hipschman
0929593b6c
wininet: InternetReadFileExA should check INTERNET_FLAG_ASYNC.
2008-03-28 09:50:42 +01:00
Dan Hipschman
aaecdf79bd
wininet: HttpSendRequestExA is not a stub.
2008-03-28 09:50:38 +01:00
Hans Leidekker
058761fa34
wininet: Support chunked reads in InternetReadFileEx too.
2008-03-26 23:48:13 +01:00
Hans Leidekker
0936601f5b
wininet: Implement chunked reads.
2008-03-26 13:46:12 +01:00
Hans Leidekker
26b38dc503
wininet: Avoid a crash with traces on.
2008-03-25 11:33:41 +01:00
Hans Leidekker
af4c428a9a
wininet: Correct spec file entry for InternetCanonicalizeUrl{A, W}.
2008-03-25 11:33:36 +01:00
Hans Leidekker
3a57711bb8
wininet: Don't strip Accept-Encoding headers from version 1.1 requests.
2008-03-25 11:33:32 +01:00
Kai Blin
63504e9e80
janitorial: Use poll() instead of select().
2008-03-24 13:41:57 +01:00
Andrew Talbot
7b380e0aeb
wininet: Assign to structs instead of using memcpy.
2008-03-24 11:33:16 +01:00
Rob Shearman
99f651bd37
wininet: The lpszLocalFileName parameter to CommitUrlCacheEntryA is optional, so check before converting it from Unicode to ANSI.
2008-03-17 15:20:10 +01:00
Jacek Caban
e8be5eaba7
wininet: Don't use query and hash part of URL to generate cache file name.
2008-03-17 11:42:39 +01:00
Marcus Meissner
ed966469a4
wininet: Split out NULL ptr and function ptr check.
2008-03-15 11:29:16 +01:00
Rob Shearman
db5745c001
wininet: If we receive an error from InitializeSecurityContext in HTTP_DoAuthorization then set pAuthInfo->finished so that we don't carry on using the security context.
2008-03-15 10:58:38 +01:00
Rob Shearman
e74514b138
wininet: Assume that if we're connected to an HTTP/1.1 server then connections can be kept alive by default.
...
So don't close the connection in this case in HTTP_FinishedReading.
2008-03-15 10:58:38 +01:00
Joris Huizer
4fca67e651
wininet: Fixed typos in two out-of-memory checks.
2008-03-13 20:44:18 +01:00
Rob Shearman
bcfb47e85b
wininet: Fix local variable shadowing in URLCacheContainer_OpenIndex.
2008-03-12 19:21:38 +01:00
Rob Shearman
716ecc42f9
wininet: Support the lpszFileExtension "reserved" parameter being passed into CommitUrlCacheEntryA.
...
Store it in the URL cache entry and allow it to be retrieved by
RetrieveUrlCacheEntryFile and other functions.
2008-03-12 17:58:37 +01:00
Rob Shearman
fee165ae47
wininet: The URL in CommitUrlCacheEntryInternal shouldn't be restricted to MAX_PATH chars in length.
...
Dynamically allocate it and consolidate cleanup at the end of the function.
2008-03-12 17:58:31 +01:00
Rob Shearman
cdd135c2f3
wininet: Fix URLCache_LocalFileNameToPathA to return a full path, rather than just the container path.
...
This was caused by path_len including the nul-terminator and so the rest
of the string was being added after the nul-terminator, which is
incorrect. This is fixed by making path_len not include the nul-terminator.
Also fix a few other issues with the function, like not passing a
correct length into the second call to WideCharToMultiByte, nRequired
being calculated incorrectly and the string not always being nul-terminated.
Add a test for this function by testing the lpszLocalFileName field
obtained from RetrieveUrlCacheEntryFileA.
2008-03-12 17:58:20 +01:00
Rob Shearman
c46279ced7
wininet: Make some pointers const in URL cache functions.
2008-03-12 17:58:10 +01:00
Rob Shearman
f1af593988
wininet: Use LIST_FOR_EACH_ENTRY in URLCacheContainers_FindContainerW instead of LIST_FOR_EACH and LIST_ENTRY.
2008-03-12 17:58:03 +01:00
Rob Shearman
4041c2015b
wininet: Add tests for Find{First,Next}UrlCacheEntryA functions.
2008-03-12 17:57:56 +01:00
Rob Shearman
160bc04343
wininet: Move URL cache hash entry validation to a separate function.
2008-03-12 17:57:30 +01:00
Rob Shearman
7fde7aef78
wininet: Implement FindFirstUrlCacheEntry{A, W}, FindNextUrlCacheEntryA and FindCloseUrlCache.
2008-03-12 17:57:25 +01:00
Rob Shearman
99e7f7ab6e
wininet: Add tests for some URL cache functions.
2008-03-12 17:55:41 +01:00