Commit Graph

290 Commits

Author SHA1 Message Date
Zebediah Figura c55e8822ae msctf/tests: Fix some test failures on Windows 10.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-01-23 22:41:38 +01:00
Gabriel Ivăncescu 6393edb714 msctf: Clear the corresponding DocumentMgr pointers for Associated Focus Windows on destruction.
Fixes a regression introduced by d541087079.

AssociateFocus does not grab ownership of the Document Manager, but it does
return it in the "prev" output parameter with an increased refcount. So,
if the docmgr gets destroyed and AssociateFocus is called again, its "prev"
parameter will refer to freed memory. Windows sets it to NULL in such case.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48469
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-01-16 12:21:11 +01:00
Zebediah Figura 08cc7290df msctf/tests: Trace method calls more completely and only when WINETEST_DEBUG is set.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-10-27 19:28:22 +01:00
Zebediah Figura 507abe4dcd msctf/tests: Don't test calls to ITextStoreACP::GetStatus().
They vary across platforms, and in any case there's not much point
testing methods that just query state.

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-10-27 19:28:20 +01:00
Zebediah Figura 9516ad1fc7 msctf/tests: Simplify ITfThreadMgrEventSink refcounting tests.
Just use one static object, and don't depend on the thread manager
never calling AddRef()/Release().

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-10-27 19:28:17 +01:00
Zhiyi Zhang 0bebbbaa51 msctf: Check TF_GetThreadMgr error in DocumentMgr_Destructor.
Thread manager could be already destroyed when calling DocumentMgr_Destructor.
This removes the error dialog when closing Unreal Engine 4 games.

Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-08-27 20:23:34 +02:00
Rémi Bernon b9b834b6ba msctf/tests: Add multi-threaded apartment test for ITfSource_AdviseSink.
We expect it to fail because the ITfUIElementSink interface is flagged
as "local" and cannot be marshalled, and because ITfThreadMgr is flagged
with "threading(apartment)" and cannot be instanciated in the MTA.

Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-08-21 14:32:39 +02:00
Zhiyi Zhang ef542fc797 msctf: Add ITfContextOwnerCompositionServices stub.
Fix crash at launch for games that use Unreal Engine 4.

Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-08-16 23:44:09 +02:00
Andrew Eikum d541087079 msctf: Accept ITfInputProcessorProfileActivationSink in ThreadMgr AdviseSink.
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-07-31 09:42:55 +02:00
Andrew Eikum 9122bf768f msctf: Accept ITfUIElementSink in ThreadMgr AdviseSink.
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-07-31 09:41:50 +02:00
Alexandre Julliard dc176dedf0 msctf: Build with msvcrt.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-06-12 11:44:26 +02:00
Michael Stefaniuc 61aea5a987 msctf: Remove useless cast to self.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-17 22:38:28 +02:00
Michael Stefaniuc 7aef9a9db1 msctf: Use the ARRAY_SIZE() macro.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 10:15:59 +02:00
Zebediah Figura b4843f29cb msctf/tests: Skip tests if limited.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-28 14:15:09 +02:00
Zebediah Figura e050c24998 msctf/tests: Set requestedExecutionLevel to asInvoker to prevent virtualization.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-28 14:15:04 +02:00
Michael Stefaniuc 5da1f82620 msctf/tests: Use the available ARRAY_SIZE() macro.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-04 14:23:31 +02:00
Louis Lenders bd64a86f0c msctf: Return S_OK in TextStoreACPSink_OnLayoutChange.
Signed-off-by: Louis Lenders <xerox.xerox2000x@gmail.com>
Signed-off-by: Aric Stewart <aric@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-04 22:04:25 +02:00
Louis Lenders 08b077296c msctf: Return S_OK in TextStoreACPSink_OnSelectionChange.
Signed-off-by: Louis Lenders <xerox.xerox2000x@gmail.com>
Signed-off-by: Aric Stewart <aric@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-04 22:04:25 +02:00
Louis Lenders a78d411b38 msctf: Return S_OK in TextStoreACPSink_OnTextChange.
Signed-off-by: Louis Lenders <xerox.xerox2000x@gmail.com>
Signed-off-by: Aric Stewart <aric@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-04 22:04:25 +02:00
Jacek Caban c082108e24 msctf: Added semi-stub support for ITfKeyTraceEventSink event sink.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Aric Stewart <aric@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-14 15:27:57 +01:00
Andrey Gusev 0b7882b00b msctf/tests: Fix a typo in sink_check_ok().
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Aric Stewart <aric@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-08 13:58:25 +01:00
Nikolay Sivov 8d03bef891 msctf/tests: Fix test object leak (Valgrind).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-03-13 19:39:38 +01:00
Nikolay Sivov 7bcca927bc msctf: Return proper pointer to interface.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-06 13:44:45 +01:00
Jacek Caban 04b97c2eaa msctf: Allow unadvising ITfThreadFocusSink.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-02 19:50:35 +01:00
Jacek Caban 7ebe59b922 msctf: Use correct sink for ITfThreadFocusSink.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-31 15:58:44 +01:00
Huw Davies aac4cc8fbb msctf/tests: Return if the constructor fails. This avoids several clang warnings.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-17 12:50:42 +01:00
Huw Davies 5fb2267a78 msctf/tests: Fix tests on Windows 8 and 10.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-17 12:50:40 +01:00
Huw Davies 543496a4fc msctf/tests: Fix usage of test_ShouldDeactivate which is a BOOL.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-17 12:50:38 +01:00
Brock York d7662881a5 msctf: Remove incorrect dereference of double pointer.
Signed-off-by: Brock York <twunknown@gmail.com>
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-09 16:30:41 +01:00
Nikolay Sivov 137166ff0a msctf: Use interface pointer instead of object pointer.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-28 13:55:15 +01:00
Jacek Caban 63859e382f msctf: Added IID_ITfThreadFocusSink support to AdviseSink.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-09-06 11:29:22 +09:00
Nikolay Sivov bbae410a2b msctf/tests: Return interface pointers instead of pointers to impl structure.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-09-01 20:47:48 +09:00
Michael Stefaniuc a944b4eed9 msctf: Avoid a cast from IEnumTfLanguageProfiles to the COM object.
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Aric Stewart <aric@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-20 11:02:34 +09:00
Michael Stefaniuc fd0101ab61 msctf: Don't crash on NULL input in EnumLanguageProfiles().
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Aric Stewart <aric@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-20 11:02:32 +09:00
Michael Stefaniuc 8e2db1dfe1 msctf: Get rid of a cast from a COM object to an iface.
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-04 17:30:40 +09:00
Francois Gouget 7fabedfadf msctf: Spelling fix.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Aric Stewart <aric@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-14 01:02:44 +09:00
Jacek Caban 0bf6df6866 msctf: Fixed ref counts in tests.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-28 22:54:11 +09:00
Jacek Caban bc645ca71a msctf: Added Push/Pop context tests.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-28 22:54:09 +09:00
Jacek Caban 79025d0e6a msctf: Don't call ITextStoreACP::UnadviseSink in context destructor.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-28 22:54:07 +09:00
Jacek Caban 4585687e7d msctf: Added ITfTransitoryExtensionSink tests.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-05 20:40:11 +09:00
Jacek Caban a9d4b0344b msctf: Added document manager's AdviseSink and UnadviseSink implementation.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-05 20:40:07 +09:00
Jacek Caban 361f0690f6 msctf: Use generic sinks in InputProcessorProfiles object.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-05 20:40:05 +09:00
Jacek Caban c80a96504e msctf: Use generic sinks in Context object.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-05 20:40:03 +09:00
Jacek Caban 40cdfd2a6a msctf: Use generic sinks in Compartment object.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-05 20:40:01 +09:00
Jacek Caban 7c1c94c258 msctf: Added a helper macro for interating sink list.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-05 20:39:59 +09:00
Jacek Caban a27da35b05 msctf: Moved thread manager's sink list destructor implementation into a more generic helper.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-05 20:39:57 +09:00
Jacek Caban 0374ee290d msctf: Moved thread manager's UnadviseSink implementation into a more generic helper.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-05 20:39:55 +09:00
Jacek Caban c0efd074b2 msctf: Moved thread manager's AdviseSink implementation into a more generic helper.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-05 20:39:52 +09:00
Jacek Caban 0b912fecf6 msctf: Use generic sink type for thread manager sinks.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-05 20:39:50 +09:00
Jacek Caban dfebe8cb63 msctf: Improved ITfKeystrokeMgr::TestKeyUp and TestKeyDown stubs.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Aric Stewart <aric@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-05 01:27:53 +09:00