Commit Graph

1092 Commits

Author SHA1 Message Date
Michael Stefaniuc 8445bf3428 shlwapi/tests: Pass the correct buffer size to WideCharToMultiByte().
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-27 10:06:00 +02:00
Michael Stefaniuc f2f52bcb28 shlwapi/tests: Pass the correct buffer size to PathUnExpandEnvStringsW().
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-27 10:05:56 +02:00
Michael Stefaniuc 3851d97e99 shlwapi/tests: Use the available ARRAY_SIZE() macro.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-27 10:05:50 +02:00
Marcus Meissner 75236a636b shlwapi: SHGetIniStringW buffer size is in characters.
Signed-off-by: Marcus Meissner <meissner@suse.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-26 16:40:05 +02:00
Katayama Hirofumi MZ 7be8beab68 shlwapi: Don't attempt to un-expand ComputerName in PathUnExpandEnvStrings.
Signed-off-by: Thomas Faber <thomas.faber@reactos.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-23 20:16:59 +01:00
Zebediah Figura ea52b552d7 shlwapi/tests: Fix link order.
Some functions are declared both in shell32 and in shlwapi; we want to link
to the latter.

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-20 18:39:24 +01:00
Alex Henrie a5c6652389 shlwapi/tests: Drop ordinal test workarounds for Windows <= 2000.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-19 16:55:08 +01:00
Hermes Belusca-Maito 2c16322573 shlwapi: Make SHCreateWorkerWindowA/W 64-bit compatible.
Signed-off-by: Hermes Belusca-Maito <hermes.belusca@sfr.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-13 19:15:00 +01:00
Alex Henrie 031f2ab64f shlwapi/tests: Add missing return value checks to istream tests (Coverity).
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-08 19:26:54 +01:00
Jacek Caban 62c4ffb4d6 shlwapi: Support NT prefix paths in PathGetDriveNumberW.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-10 09:26:04 +02:00
Zebediah Figura 3559c261c1 shlwapi: URL schemes may contain hyphen, plus, or period.
Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-09-22 08:31:45 +02:00
Alistair Leslie-Hughes ee778749e3 shlwapi/tests: Use standard wine_dbgstr_longlong.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-04 10:47:18 +02:00
Akihiro Sagawa 98d0fa99da shlwapi: Use isalnumW() instead of isalnum() for WCHARs.
Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-17 16:11:21 +02:00
Nikolay Sivov e878b79549 shlwapi/tests: Remove workarounds for versions we don't test on anymore.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-04-03 13:21:32 +02:00
Jacek Caban dfb846c214 shlwapi: Fixed error handling in StrRetToBufW.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-23 20:12:36 +01:00
Andrey Gusev 437123b58a shlwapi: Avoid 'else if' for IStream_fnQueryInterface.
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-01 21:19:38 +01:00
Bruno Jesus 57b83e1459 shlwapi/tests: Test NULL handle duplication in SHMapHandle().
Signed-off-by: Bruno Jesus <00cpxxx@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-01-31 08:57:45 +01:00
Fabian Maurer 101edb1f6d shlwapi: Changed UrlEscapeW error paths and add tests.
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-12-14 17:32:44 +01:00
Daniel Lehman 4eac6e84ba shlwapi: Remove dot segments for URLs starting with /.
Signed-off-by: Daniel Lehman <dlehman@esri.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-30 13:23:04 +01:00
Daniel Lehman 6cbcc76e41 shlwapi: Make ParseURL case-insensitive.
Signed-off-by: Daniel Lehman <dlehman@esri.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-11-17 10:21:50 -06:00
Sebastian Lackner 0198d0d56a shlwapi: Return E_NOTIMPL for unknown types in StrRetToBuf{A,W}.
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-09-14 11:51:51 +09:00
Nikolay Sivov e078c97d53 shlwapi/tests: Fix indentation warning on GCC 6.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-12 12:31:52 +09:00
Nikolay Sivov 817302b568 shlwapi: Fix its vs it's typo.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-08-04 09:07:57 -05:00
Michael Stefaniuc b713c438c1 shlwapi/tests: Use wine_dbgstr_guid() to trace REFIIDs.
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-07-20 22:54:09 +09:00
Nikolay Sivov 568b08047b shlwapi: Fix a string leak (Valgrind).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-06-13 11:34:14 +09:00
Dmitry Timoshkov 860f5562c7 shlwapi: Fix IStream::Read() return value for partial reads.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-04-26 14:52:01 +09:00
Francois Gouget 637799db98 shlwapi/tests: Fix a test failure on Windows 10.
AssocQueryString() can return S_FALSE with the size of the required buffer.

Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-03-18 12:21:10 +09:00
Alexandre Julliard 262a41ca4a shlwapi: Use the standard WideCharToMultiByte instead of wine_utf8_wcstombs.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-25 00:24:59 +09:00
André Hentschel dbc043c3d8 shlwapi/tests: Use todo_wine_if() in tests.
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-02-22 17:37:09 +09:00
Nikolay Sivov ed0520e2e2 shlwapi/tests: Fix uninitialized data access in tests (Valgrind).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-09 17:30:04 +09:00
Nikolay Sivov 37cdf65949 shlwapi: Fix initializer causing compiler warning.
Spotted by Józef.

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-08 21:38:20 +09:00
Jared Smudde 1c2dd4b3e7 shlwapi: Fix OS_TABLETPC typo.
Signed-off-by: Jared Smudde <computerwhiz02@hotmail.com> 
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-06 18:13:50 +01:00
Nikolay Sivov 9171865661 shlwapi: Remove a cast that's not really needed.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-01-06 18:08:31 +01:00
Daniel Lehman 74e71b6643 shlwapi: Implement URL_ESCAPE_AS_UTF8.
Signed-off-by: Daniel Lehman <dlehman@esri.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-30 08:06:43 +01:00
Nikolay Sivov 0e4be06cd6 shlwapi: Handle NULL pointer in DllGetVersion() (Coverity).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-29 17:13:52 +01:00
Olivier F. R. Dierick 71bbd8da87 shlwapi/tests: Test SHFreeShared with NULL handle.
Signed-off-by: Olivier F. R. Dierick <o.dierick@piezo-forte.be>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-03 23:38:22 +09:00
Olivier F. R. Dierick de0d8719d2 shlwapi: SHFreeShared returns TRUE when passed NULL handle.
Signed-off-by: Olivier F. R. Dierick <o.dierick@piezo-forte.be>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-12-03 23:38:11 +09:00
Piotr Caban 31c49c2851 shlwapi: Don't crash in PathStripPath when read-only string is passed and it's not modified.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-29 10:54:15 +09:00
Nikolay Sivov bef3298e89 shlwapi/tests: Fix a couple of prototypes to match implementation (PVS-Studio).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-15 19:18:49 +09:00
Nikolay Sivov f51e7900eb shlwapi: Fix SHPropertyBag_ReadLONG prototype (PVS-Studio).
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-15 19:18:43 +09:00
Bruno Jesus ffb4d15117 shlwapi: Reject NULL key on SHRegCloseUSKey with tests. 2015-09-07 15:04:27 +09:00
Marcus Meissner a2869de4d4 shlwapi: Add missing braces (Coverity). 2015-06-15 14:47:32 +09:00
Huw Davies 9327e476d4 shlwapi/tests: Fix failing tests on Vista and Win 2008.
SHMapHandle fails with a variety of errors on these platforms.
2015-06-10 23:36:28 +09:00
Nikolay Sivov b5c2c0b05a shlwapi: Fix error handling in IUnknown_GetClassID (Coverity). 2015-06-08 15:26:36 +09:00
Francois Gouget 7411c72e82 shlwapi/tests: Silence some istream traces that generate too many lines. 2015-05-12 22:32:22 +09:00
Nikolay Sivov d6180c05b5 shlwapi/tests: Fix uninitialized memory reads (Valgrind). 2015-04-13 15:05:12 +09:00
Francois Gouget 14aa446f1d shlwapi: Remove unneeded NONAMELESSXXX directives. 2015-03-20 18:05:07 +09:00
André Hentschel e26e33fa06 shlwapi: Avoid assigning values twice (PVS-Studio). 2015-03-20 12:42:28 +09:00
Michael Stefaniuc a0e28403d4 shlwapi: Remove two unused assignments (PVS-Studio). 2015-03-04 21:50:44 +09:00
Austin English 1b698ccd59 shlwapi: Sync wsprintf implementation from user32. 2015-02-23 21:45:47 +09:00