Commit Graph

2269 Commits

Author SHA1 Message Date
Dmitry Timoshkov 3dcd048175 oleaut32: Use common helper for masked bitmaps to render an icon.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-24 20:12:04 +02:00
Dmitry Timoshkov 293a679076 oleaut32: Move rendering a bitmap to a separate helper.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-24 20:12:04 +02:00
Dmitry Timoshkov 4b525aa0a4 oleaut32/tests: Fix the IPicture::Render() usage.
When one specifies the target rectangle (0, 0, width, -height)
IPicture::Render() places the origin at 0,0 and flips the image
vertically. This means that in order to paint an icon on the DC
it's necessary to specify the rectangle (0, height, width, -height),
i.e. place the origin at 0,height. I've written a test app that
verifies this behaviour, ufortunately I don't see a way to add
a Wine test case for this.

The test currently works by chance under Windows because in case
of (0, 0, width, -height) IPicture::Render() draws black rectangle
instead of an icon at (0, 0, width, height). If Wine intends to
replicate this behaviour it should be fixed by a separate patch.

Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-24 20:12:04 +02:00
Daniel Lehman 1d2ac5d8b6 oleaut32: Extend value range before getting absolute value in VarBstrFromI4.
Signed-off-by: Daniel Lehman <dlehman@esri.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-15 10:49:06 +02:00
Daniel Lehman 7198499dd0 oleaut32/tests: Add test for VarBstrFromI4.
Signed-off-by: Daniel Lehman <dlehman@esri.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-15 10:49:06 +02:00
Alexandre Julliard 3c562da161 oleaut32: Explicitly define call_double_method() to avoid function mismatch warning.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-15 07:16:06 +02:00
Alexandre Julliard 18f7ec3670 oleaut32: Remove unnecessary consts.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-16 10:14:52 +02:00
Dmitry Timoshkov bab5a703da oleaut32/tests: Add tests for IPicture::get_hPal() and IPicture::set_hPal().
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-09 18:04:17 +02:00
Dmitry Timoshkov e34d570b45 oleaut32: IPicture::set_hPal() supports only bitmaps.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-09 18:04:17 +02:00
Dmitry Timoshkov e5553bbd05 oleaut32: IPicture::get_hPal() supports only bitmaps.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-09 17:51:59 +02:00
Dmitry Timoshkov ee08f1cf5b oleaut32: Don't accept unsupported picture types in OleCreatePictureIndirect.
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-09 17:51:46 +02:00
Zebediah Figura bab41c8aea oleaut32: Correct some comments.
This corresponds to 652ec646ad affecting widl.

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-21 11:16:18 +02:00
Michael Stefaniuc 2441e9417c oleaut32/tests: Use a better type to avoid a cast.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-19 20:49:24 +02:00
Michael Stefaniuc db48640a51 oleaut32/tests: Avoid an ARRAY_SIZE-like macro.
Also use a better type for the dimension variable.

Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-19 20:49:11 +02:00
Michael Stefaniuc 050edeb420 oleaut32/tests: Use the available ARRAY_SIZE() macro.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-19 20:49:04 +02:00
Zebediah Figura 50a7b239bd widl: Generate correct size and alignment for all types.
Using type_memsize_and_alignment() directly instead of reimplementing it.

Also fix the generated tests in oleaut32 to reflect correct sizes for 64-bit
typelibs.

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-05 10:07:10 +02:00
Zebediah Figura 8c968f774c widl: Don't remove the FDUAL flag from non-dispatchable interfaces.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-29 17:13:05 +02:00
Zebediah Figura 413821f8b1 widl: Properly implement syntax 2 dispinterfaces.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-29 17:13:05 +02:00
Nikolay Sivov 8259f383f6 oleaut32: Ignore SetObjects() result when building property frame.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-22 21:46:27 +01:00
Nikolay Sivov 8fa582ae68 oleaut32: Allow NULL objects array when creating property frame.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-22 21:46:27 +01:00
Nikolay Sivov 1ac1c78f05 oleaut32: Don't reset property page site to NULL.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-22 21:46:27 +01:00
Alex Henrie 96e9da5c87 oleaut32/tests: Mark some tmarshal tests as todo on x64 and ARM.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-15 19:35:13 +01:00
Daniel Lehman ff4a02fe3c oleaut32/tests: Fix leak (Valgrind).
Signed-off-by: Daniel Lehman <dlehman25@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-06 22:11:14 +01:00
Michael Stefaniuc d0ecd514b4 oleaut32: Use the global HeapAlloc() wrappers.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-06 19:38:30 +01:00
Huw Davies dd012af92a oleaut32: Fix vtable offset for a SYS_WIN32 typelib loaded on WIN64.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-22 10:27:57 +01:00
Huw Davies 138f75f19f oleaut32/tests: Remove some no longer needed test work-arounds.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-22 10:27:55 +01:00
Nikolay Sivov 4cc41fc5ce oleaut32/tests: Use SafeArraySetIID() directly.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-19 16:40:55 +01:00
Nikolay Sivov 0fc0e34fb0 oleaut32/tests: Test more return values.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-01-05 16:13:37 +01:00
Alexandre Julliard 756f781786 oleaut32: Fix check for DECIMAL variant in VarNumFromParseNum.
Reported by Gerald Pfeifer.

Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-08 16:45:56 +01:00
Alexandre Julliard b67dc2f4da oleaut32: Fix ARM floating point register allocations.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-08 16:45:56 +01:00
Alexandre Julliard 46aedd2ba4 oleaut32: Disable floating point instructions for the soft-float ARM build.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-12-08 16:45:56 +01:00
Marcus Meissner 4f45fa0581 oleaut32/tests: Fixed 64-bit crash on tmarshal test.
Signed-off-by: Marcus Meissner <marcus@jet.franken.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-08 21:42:17 +01:00
Piotr Caban 409bafcc73 oleaut32: Ignore underflows in VarR8FromStr.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-07 21:24:45 +01:00
Piotr Caban 61c18632b8 oleaut32: Fix automatic value getting in ITypeInfo::Invoke.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-07 21:24:45 +01:00
Donna Whisnant c4ac2d285d oleaut32: Fix DispCallFunc() stdcall test to be ABI not x64 specific.
The tests checking callee stack cleaning for stdcall vs. cdecl should
be a function of the calling ABI of the platform, not whether it is
64-bit or not.  This fixes the check for platforms like ARM that may
be 32-bit but that do not use the stdcall convention of callee stack
cleaning.

Signed-off-by: Donna Whisnant <dewhisna@dewtronics.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-06 12:15:28 +01:00
Donna Whisnant 0b393119bb oleaut32: Add ARM support to DispCallFunc().
Signed-off-by: Donna Whisnant <dewhisna@dewtronics.com>
Signed-off-by: André Hentschel <nerv@dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-01 23:16:07 +01:00
Andrey Gusev 307b3c8ed5 oleaut32: Remove redundant comparison.
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-10 18:19:10 +02:00
Alistair Leslie-Hughes 884c6ddd51 oleaut32/tests: Add VarDateFromStr test.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-04 10:44:35 +02:00
Fabian Maurer c0da750e8a oleaut32: In userdefined_to_variantvt remove unneeded statement (cppcheck).
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-10-03 19:58:17 +02:00
Alexandre Julliard 8da116d0b7 oleaut32: Don't copy uninitialized data.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-28 20:21:36 +02:00
Nils Kuhnhenn 0dde88202a oleaut32: Use variable with the correct type in LIST_FOR_EACH_ENTRY_SAFE macro.
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-16 18:10:38 +02:00
Jacek Caban 840ab7cd1c oleaut32: Simplify VarCat implementation.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-15 21:54:39 +02:00
Alistair Leslie-Hughes 538e46adea oleaut32: Improve support for IDispatch in VarCat.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-14 21:22:50 +02:00
Nikolay Sivov 19b944d49c oleaut32/tests: Basic test for invalid arguments in LoadTypeLib/LoadTypeLibEx.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-07 11:24:48 +02:00
Dmitry Timoshkov cf45f3bcc8 oleaut32: Add an arguments check to LoadTypeLibEx.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-07 11:24:47 +02:00
Francois Gouget 4be8d8392c oleaut32: Make VARIANT_GetLocalisedText() static.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-05 13:11:44 +02:00
Jacek Caban e42a12d8b8 oleaut32/tests: Use static oleaut32 linking in vartest.c.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-30 21:49:50 +02:00
Alistair Leslie-Hughes e0b5496ccb oleaut32/tests: Add more VarCat tests.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-25 13:18:00 +02:00
Alistair Leslie-Hughes 1762f89ff2 oleaut32: Use VariantChangeTypeEx to convert to VT_BOOL.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-22 13:45:11 +02:00
Alistair Leslie-Hughes c260de0faa oleaut32: Remove dead code.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-18 16:17:28 +02:00