Commit Graph

84 Commits

Author SHA1 Message Date
Alex Henrie 776eebe80b ole32: Fix memory leak in FileMonikerImpl_ComposeWith.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2016-05-05 01:27:52 +09:00
Huw Davies d340f09a33 ole32: Don't try to load a handler - the real server is needed.
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-09 19:16:51 +09:00
Huw Davies 577644f3c1 ole32: Test the result of IRunningObjectTable_GetObject against S_OK.
Typically it would return MK_E_UNAVAILABLE and not S_FALSE if the moniker
is not registered.

Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-09 19:16:43 +09:00
Francois Gouget 7fe0600237 ole32: Remove unneeded NONAMELESSXXX directives. 2015-03-17 14:18:54 +09:00
Sebastian Lackner 59a1bcd96a ole32: Fix call to free_stringtable with uninitialized pointer (Coverity). 2015-03-11 12:47:40 +09:00
Vincent Povirk 69ff6f74b2 ole32: Simplify the FileMonikerImpl_BindToStorage code. 2014-07-01 12:52:43 +02:00
Nikolay Sivov 4768ac4413 ole32: Fix leaks on error paths (Coverity). 2014-03-25 10:56:35 +01:00
Frédéric Delanoy 57d7f74d34 Assorted spelling fixes. 2013-11-21 19:44:46 +01:00
Frédéric Delanoy 4473ce4db9 Assorted spelling fixes. 2013-10-30 09:46:27 +01:00
Frédéric Delanoy 4bb61ec0df ole32: Use BOOL type where appropriate. 2013-10-15 14:28:20 +02:00
Frédéric Delanoy 8ddb00b22b ole32: Fix some leaks (coverity). 2012-11-27 19:45:37 +01:00
Frédéric Delanoy 02da0411e1 ole32: Add helper for string table memory freeing. 2012-11-27 19:45:37 +01:00
André Hentschel c223354912 ole32: Don't leak memory allocated by FileMonikerImpl_DecomposePath (coverity). 2012-10-29 10:39:42 +01:00
Jacek Caban 153b94b3c5 ole32: Use proper helpers for iface calls. 2012-08-13 16:28:48 +02:00
Michael Stefaniuc 70c038dc2f ole32: COM cleanup in filemoniker.c. 2011-08-30 11:57:03 +02:00
Nikolay Sivov 114510801f ole32: No need to test for interface pointer being null. 2010-07-21 17:38:37 +02:00
Nikolay Sivov 5185409144 ole32: Remove redundant variables. 2010-07-21 17:38:37 +02:00
Rob Shearman db33e8fdd9 ole32: Fix off-by-one error in FileMonikerImpl_DecomposePath.
strgtable needs to be an array of the same size as str, including the
nul-terminator.
2009-11-29 16:39:45 +01:00
Marcus Meissner 000e1e0ce0 ole32: Some missing error checking in FileMonikerImpl_CommonPrefixWith (Coverity). 2009-11-24 10:51:42 +01:00
Rob Shearman 377159c4a7 ole32: Fix size of memory allocation in FileMonikerImpl_DecomposePath. 2009-11-20 16:38:46 +01:00
Andrew Eikum 968126c231 ole32: Don't fail when constants are 'incorrect'. 2009-09-08 12:11:10 +02:00
Michael Stefaniuc 0449701c31 ole32: Remove superfluous pointer casts. 2009-02-11 12:29:56 +01:00
Francois Gouget 66063ae4a4 ole32: Remove WINAPI on static functions where not needed. 2008-11-26 12:33:13 +01:00
Michael Stefaniuc 3ed8ffcc99 ole32: Use the right FAILED/SUCCEEDED macro instead of negating the opposite. 2008-10-08 13:41:58 +02:00
Francois Gouget 02bcdf6db7 ole32: Fix spelling of GetComparisonData(). 2008-04-14 12:40:22 +02:00
Austin English 1b24da3aa0 ole32: Spelling fixes. 2008-04-10 09:51:12 +02:00
Rob Shearman 3bd222004e ole32: Fix a leak of the IBindCtx object in FileMonikerImpl_IsEqual. 2007-11-12 11:45:57 +01:00
Francois Gouget c4b1195c0c Assorted spelling fixes. 2007-10-23 18:20:27 +02:00
Ulrich Czekalla c2fdea600a ole32: Remove stack-based string buffer inFileMonikerImpl_DecomposePath. 2007-06-07 20:40:12 +02:00
Rob Shearman f8789122aa ole32: Implement MkParseDisplayName. 2007-03-28 12:12:49 +02:00
Michael Stefaniuc 21ff87bf50 ole32: Win64 printf format warning fixes. 2006-10-16 10:53:28 +02:00
Alexandre Julliard 32f57b0214 ole32: Use the standard DEFINE_OLEGUID macro to define GUIDs. 2006-06-09 21:09:49 +02:00
Jonathan Ernst 360a3f9142 Update the address of the Free Software Foundation. 2006-05-23 14:11:13 +02:00
Robert Shearman bff74c1763 ole32: Fix typo in FileMonikerImpl_BindToObject.
Fix apparent typo in FileMonikerImpl_BindToObject, where ppf was
incorrectly passed into IClassFactory_CreateInstance instead of &ppf
(found by Coverity).
2006-04-07 13:10:18 +02:00
Alexandre Julliard b1a9701bb5 Replace the _ICOM_THIS_From macros by inline functions the way it's
already done in shelllink.c.
2005-07-27 11:10:52 +00:00
Mike McCormack c7fdb4565a Fix gcc 4.0 -Wpointer-sign warnings. 2005-07-05 11:02:54 +00:00
Dmitry Timoshkov eba47f1dfe Make remaining OLE interface vtables const. 2005-06-06 19:50:35 +00:00
Richard Cohen 54f041ad32 - Base FileMonikerImpl_Save() on XP.
- Correct handling of Unicode strings & multibyte locales.
- More error checking.
- Change ERR to WARN.
- Match Windows quick & dirty estimate for GetSizeMax().
2005-06-02 19:42:48 +00:00
Robert Shearman 8d6a673cf7 - Add error messages on failure in file moniker load function.
- Fix incorrect pointer check in both monikers.
- Fix max size calculation of item moniker to match native.
2005-05-23 10:27:42 +00:00
Robert Shearman 34d3049360 - Add a generic moniker marshaler that works by saving & loading
monikers to & from the stream.
- Use the generic moniker marshal in the file & item monikers and add
  a class factory for each.
2005-05-19 14:22:14 +00:00
Robert Shearman 10ee7b36e8 Implement IROTData::GetComparisonData for file & item monikers. 2005-05-18 18:28:15 +00:00
Mike McCormack 912ffd6a0f Remove unnecessary declarations and make functions static. 2005-05-12 09:57:21 +00:00
Robert Shearman 4390d003f4 - Better tracing.
- Small cleanup of creation functions.
2005-02-18 20:13:23 +00:00
Michael Stefaniuc 5ad7d858e0 Do not check for non NULL pointer before HeapFree'ing it. It's
redundant.
2004-12-23 17:06:43 +00:00
Francois Gouget 486d020c1b Don't define COBJMACROS in objbase.h.
Update the Wine sources accordingly.
2004-10-07 03:06:48 +00:00
Joris Huizer 34cffce6f9 Ref count increment/decrement cleanup. 2004-09-24 01:16:53 +00:00
Alexandre Julliard 241a4c34b1 Get rid of the non-standard ICOM_THIS macro. 2004-09-09 21:03:58 +00:00
Alexandre Julliard f714b39762 Get rid of the no longer used ICOM_MSVTABLE_COMPAT_DummyRTTIVALUE
macro.
2004-08-23 19:39:48 +00:00
Alexandre Julliard 48c4bb3c31 Get rid of the non-standard ICOM_VTABLE macro. 2004-08-12 23:00:51 +00:00
Francois Gouget f8e01efb3d Assorted spelling fixes. 2004-07-23 23:02:09 +00:00