836d9af1be
msi/tests: Avoid size_t in traces.
2009-03-26 14:01:26 +01:00
6fa69c3f2b
msi: Remove redundant NULL check before msi_free (Smatch).
2009-03-26 11:51:08 +01:00
9c6e6efa32
msi: Detect privately installed assemblies.
...
Another fix for the office 2007 sp1 installer.
2009-03-25 15:02:45 +01:00
c2221f325f
msi: Add some tests for MsiQueryFeatureState.
...
These tests confirm that a feature is reported as advertised if only
one of its components is missing.
2009-03-25 15:02:37 +01:00
28bc76b5d3
msi: Verify the existence of fusion.dll before reporting the .Net version.
...
Fixes an issue with .Net 3.0 where it does not install a new
fusion.dll but does add a key to the registery. The fact that a new
dll is not installed has been verified on windows.
2009-03-25 12:39:27 +01:00
86af876987
msi: Only apply a transform when its language id matches the system language id.
...
Fix for office 2007 sp1 installer.
2009-03-24 13:32:11 +01:00
b8965ee7c9
msi: Don't initialize COM for custom action threads.
2009-03-24 13:31:59 +01:00
c844582177
msi: Add stub implementations of MsiSourceListClearAllExA/W.
2009-03-24 13:31:36 +01:00
7590a3f335
msi: Implement MsiReinstallProductA/W.
2009-03-24 13:31:24 +01:00
201e291e5d
msi: Add stub implementations of MsiDeterminePatchSequenceA/W.
2009-03-24 13:31:12 +01:00
6789fa8544
msi: Add the Romanian translation.
2009-03-24 13:00:02 +01:00
5e62686a0f
msi: Handle a NULL and empty szPackagePath in MsiInstallProduct (Coverity 181).
2009-03-23 15:52:18 +01:00
fb8db0ac13
msi: Don't try to release a NULL record, with tests (Coverity 536).
2009-03-23 15:52:17 +01:00
baf86bd5bb
msi: MsiCollectUserInfo cannot be called from a custom action (Coverity 565, 566).
2009-03-23 15:52:17 +01:00
cb958cd773
msi: Test and handle the case where the SourceList key does not exist and the PackageName value does not exist in MsiGetProductInfo.
2009-03-23 15:52:17 +01:00
dc50773c28
msi: Factor out the MsiEnumPatchesEx tests and test the NULL szUserSid and an szUserSid that is different from the current user.
2009-03-23 15:52:17 +01:00
c965d839f9
msi: Allow the enumeration of other users' patches.
2009-03-23 15:52:17 +01:00
f7c615b188
msi: Enumerate the current user's patches if szUserSid is NULL.
2009-03-23 15:52:17 +01:00
3956bb5b0e
msi: Fix a typo (Coverity 910).
2009-03-23 15:52:17 +01:00
fccdccc378
msi: Update the German translation.
2009-03-23 15:52:17 +01:00
b4cb8562ae
msi: Convert the German translation to UTF8 encoding.
2009-03-23 15:52:17 +01:00
39600d9d2e
msi: Reorder the condition operators so that longer strings are matched first.
...
This allows ~<< to be properly matched.
2009-03-23 15:26:02 +01:00
ba50d15060
msi: Set concurrency model to multi-threaded for custom action threads.
...
A custom action in the office 2007 sp1 installer fails right after calling
CoInitializeEx(NULL, COINIT_MULTITHREADED). This is because our code calls
CoInitialize(NULL) first, which sets a different concurrency model, and a
subsequent call with a different model will return RPC_E_CHANGED_MODE.
Ergo, we should set the model to multi-threaded too.
2009-03-13 14:52:48 +01:00
4da865f324
msi: Handle ADVERTISE overrides.
2009-03-13 13:21:07 +01:00
804d66039d
msi: Correct spec entry for MsiGetProductInfoA/W.
2009-03-13 13:21:07 +01:00
7a8000d4e8
msi/tests: Fix a test for systems with %TEMP% being less than 2 levels deep.
2009-03-12 14:29:56 +01:00
40cfbaf023
msi: Fix handling of REINSTALL overrides.
...
We were forcing features with a REINSTALL override to be reinstalled
locally, which is only correct if the original install state is local.
This causes problems with the office 2007 sp1 installer, which applies
a REINSTALL override to an advertised feature.
2009-03-12 14:29:56 +01:00
fca2626768
msi/tests: Fix a test failure on Win95.
2009-03-03 12:36:25 +01:00
9540d762ad
msi: Handle reading from a NULL stream.
2009-03-02 12:06:37 +01:00
2f1eacfcad
msi: Don't treat carriage returns as spaces.
2009-03-02 12:06:30 +01:00
7f3faffc3b
msi: Don't allow nested quotes in SQL queries.
2009-03-02 12:06:24 +01:00
e821f9d724
msi: Add missing calls to MsiViewClose.
2009-03-02 12:06:18 +01:00
293bdffa29
msi: Use a SQL marker to query the _Property table when fetching a property.
2009-03-02 12:06:10 +01:00
f36e13fd81
msi: Delete the view on error.
2009-03-02 12:06:02 +01:00
046bcc918c
msi: The PATH environment variable can be longer than MAX_PATH, so dynamically allocate strings to deal with that.
2009-03-02 12:05:57 +01:00
37c5e04010
msi: The _Streams and _Storages table are special and always exist.
2009-03-02 12:05:45 +01:00
c9b3bc1165
msi: Column attributes for temporary string and int columns should be g and j respectively.
2009-03-02 12:05:28 +01:00
c07b554edc
msi: Order primary keys to be first in the column list when creating a table.
2009-03-02 12:05:09 +01:00
b3c9875cf7
msi: Correctly order transposed column values in the INSERT query.
2009-03-02 12:04:57 +01:00
148ef5f485
msi: Add reinstall tests.
...
Based on a patch by Aric Stewart.
2009-02-26 15:13:25 +01:00
b55c031032
msi: Fix a failing test on win9x.
2009-02-26 12:14:19 +01:00
a7d5adc91f
msi: Trace the username to help debug test failures on certain machines.
2009-02-26 12:14:13 +01:00
5735e2fafd
msi: Fix a failing test on win9x.
2009-02-26 12:14:08 +01:00
ea28915133
msi: Don't create a temporary table that is not held.
2009-02-26 12:14:01 +01:00
241933e13c
msi: A non-temporary table cannot have a temporary primary key.
2009-02-26 12:13:57 +01:00
74aa053485
msi: The _Tables and _Columns tables have no persistence attribute.
2009-02-26 12:13:52 +01:00
2f8c2a8d41
msi: Make sure the view being updated is the same view the record was fetched from.
2009-02-26 12:13:49 +01:00
e872681af7
msi: Set field zero to the name of the table containing the primary keys.
2009-02-26 12:13:44 +01:00
7d7f14c101
msi: Add tests for field zero of a record.
2009-02-26 12:13:10 +01:00
60ad75eade
msi: Make sure a constant string's quotes match up.
2009-02-26 12:13:02 +01:00
b5ac29a73d
msi/tests: Add some tests for MsiEnumPatchesW, fix a few failures on XP.
2009-02-25 16:06:21 +01:00
b4d81f8517
msi: Fix handling of buffer sizes in MsiEnumPatchesA and avoid a redundant call to MsiEnumPatchesW.
2009-02-25 16:06:21 +01:00
18cd216e80
msi: Don't release view object twice in check_assembly_installed.
2009-02-19 16:17:17 +01:00
43094e4a3e
msi: Make comparison of assembly field names case insensistive.
2009-02-19 16:17:17 +01:00
fb04bcf638
Fix position of CDECL qualifier for functions that return pointers.
2009-02-06 14:54:01 +01:00
c0ad988e67
msi: Remove unused functions.
2009-02-06 13:04:03 +01:00
4e29ceeb77
include: Define LANGID in wtypes.idl.
2009-02-04 15:06:25 +01:00
0194b8f08c
jscript: Add IActiveScriptParse64 declaration and use it on Win64.
2009-02-03 12:39:23 +01:00
8ca2aa3da9
msi: Fix compiler warning on older gcc.
2009-01-30 13:44:06 +01:00
0bd6da81c5
msi/tests: Fix missing void in empty parameter list.
2009-01-29 12:19:44 +01:00
8fec17b5ad
msi: Add stub implementations of MsiSourceListClearSourceA/W.
2009-01-27 14:27:00 +01:00
76b08f3aa7
msi: Initialize row (Coverity).
2009-01-26 16:08:25 +01:00
2fbe8d23eb
msi: Fix potential NULL pointer dereference in ILockBytes_Release (Coverity).
2009-01-26 15:49:01 +01:00
9598a50916
msi: Fix NULL dereference in MsiQueryComponentStateW (Coverity).
2009-01-26 15:48:57 +01:00
c3e2cb00d5
msi: Remove redundant pointer check (Coverity).
2009-01-26 14:30:34 +01:00
78457300aa
msi/tests: EstimatedSize is not set consistently between Windows Installer versions.
2009-01-20 14:02:43 +01:00
3355f3d66f
msi/tests: Double nul-terminate REG_MULTI_SZ values.
2009-01-19 14:18:04 +01:00
349d8bd1a1
msi/tests: Windows Installer 3.0 often returns ERROR_INVALID_PARAMETER.
2009-01-19 14:17:57 +01:00
6d75522fb4
msi/tests: Fix a few handle leaks.
...
This was pointed out by Christoph von Wittich.
2009-01-19 13:36:27 +01:00
5f3ac30b3c
msi: Remove superfluous pointer casts.
2009-01-15 12:43:03 +01:00
9975dcd19e
msi/tests: Remove superfluous pointer casts.
2009-01-15 12:42:57 +01:00
f516cab017
include: Change to LONG/ULONG in fdi.h for Win64 compatibility.
2009-01-14 12:21:20 +01:00
602f42c25f
include: Change to LONG/ULONG in fci.h for Win64 compatibility.
2009-01-14 12:21:13 +01:00
f9f2e91198
msi/tests: Opening package with relative filename sometimes succeeds on Windows.
2009-01-12 14:34:51 +01:00
668197a898
msi: Declare some functions static.
2009-01-12 13:10:53 +01:00
81ecd7041a
msi: Fix pointer cast warnings on 64-bit.
2009-01-08 17:26:44 +01:00
35811a9078
msi/tests: Use CreateFile instead of OpenFile to avoid handle casts.
2009-01-08 13:05:27 +01:00
bb7efb1deb
msi/tests: Skip some tests if we don't have enough rights.
2009-01-08 12:40:26 +01:00
6bd893a960
msi: Change MSIHANDLE to ULONG for Win64 compatibility.
...
Also fix the compiler warnings produced by this change.
2009-01-05 12:34:12 +01:00
ddc34141cd
msi/tests: Fix pointer casting warnings on 64-bit.
2009-01-03 20:13:45 +01:00
3e7ac7ea2e
msi/tests: Add CDECL to the cabinet callback functions.
2009-01-03 20:12:49 +01:00
49abc9878f
msi: Add missing CDECL to cabinet functions.
2008-12-23 18:50:57 +01:00
2a5cf54f05
msi/tests: Avoid sizeof in traces.
2008-12-20 13:32:59 +01:00
17ffb562aa
msi: Fix some NULL checking in MSI_RecordGetStringA.
...
Includes a few record tests with a NULL buffer.
2008-12-18 14:19:40 +01:00
f10eb0bfa2
msi: EndDialog with Ignore should not be an error.
2008-12-17 11:38:52 +01:00
8bd9a3aa09
janitorial: Don't depend on user32 for the self registration functions.
2008-12-17 11:38:32 +01:00
017fee4aa0
msi/tests: Run tests again on Win9x and NT4.
2008-12-16 12:51:20 +01:00
0ccb714470
msi: Add tests for MsiGetPatchInfo.
2008-12-15 12:36:00 +01:00
c059ceb5b0
msi: Set the property specified by the Source attribute of the Media table when applying a patch.
2008-12-15 12:34:56 +01:00
01eb930005
msi: Publish the patch information.
2008-12-15 12:34:52 +01:00
5aac1ec6e5
msi: Implement MsiGetPatchInfoExW.
2008-12-15 12:34:35 +01:00
b5e3e19a19
msi: Add the ability to query a specific context for install properties.
2008-12-15 12:34:18 +01:00
880b9199a9
msi: Add the ability to query a specific context for a patch.
2008-12-15 12:34:12 +01:00
4a9f6995aa
msi: Add the ability to query a specific context for a product key.
2008-12-15 12:34:06 +01:00
d195ee3cc4
msi: Forward MsiGetPatchInfoExA to MsiGetPatchInfoExW.
2008-12-15 12:34:00 +01:00
199a26c81a
msi: Add a stub implementation of MsiGetPatchInfoEx.
2008-12-15 12:33:56 +01:00
0d7cb11fdf
msi/tests: Make enum_stream_names() and package_RegDeleteTreeW() static.
2008-12-15 12:25:48 +01:00
0b99af82b2
msi: Don't include msvcrt headers.
2008-12-12 10:19:54 +01:00
5f3287d79f
*Ko.rc: Update Korean resource.
...
Fix the unnecessary SUBLANG_NATURAL.
Change the font size from 8 to 9.
2008-12-11 12:21:07 +01:00
194c053021
msi/tests: Skip tests on win9x due to different registry keys.
2008-12-11 11:50:12 +01:00
732c1e8d31
msi/tests: Run tests again on Win9x and NT4.
2008-12-10 10:48:05 +01:00
dfb8b664d6
msi: Add tests for MsiGetProductProperty.
2008-12-09 11:24:19 +01:00
da783c3888
msi: Implement MsiGetProductPropertyW.
2008-12-09 11:24:13 +01:00
06a438152c
msi: Forward MsiGetProductPropertyA to MsiGetProductPropertyW.
2008-12-09 11:24:09 +01:00
61c94d281a
msi: Add tests for MsiEnumPatches.
2008-12-09 11:24:04 +01:00
e07ed1a2eb
msi: Implement MsiEnumPatchesW.
2008-12-09 11:23:56 +01:00
c46f2102c9
msi: Forward MsiEnumPatchesA to MsiEnumPatchesW.
2008-12-09 11:23:49 +01:00
a9e0290934
msi: Add the ability to delete multiple users' component keys.
2008-12-09 10:28:14 +01:00
bdf7da9bdc
msi: Remove a duplicated function.
2008-12-09 10:28:04 +01:00
8438d21127
msi: Remove a duplicated function.
2008-12-09 10:27:58 +01:00
98c703ab87
msi: Add the ability to open multiple users' install properties key.
2008-12-09 10:27:52 +01:00
b198f4f23f
msi: Add the ability to open multiple users' component keys.
2008-12-09 10:27:45 +01:00
930b429d1e
msi: Add the ability to open multiple users product keys.
2008-12-09 10:27:37 +01:00
947c4c312a
msi: Add tests for MsiEnumPatchesEx.
2008-12-09 10:25:47 +01:00
ff87f354c4
msi: Fix an uninitialized variable.
2008-12-09 10:25:44 +01:00
94d22682c1
msi: Remove an unused declaration.
2008-12-08 22:02:53 +01:00
87fef9fd22
msi: Implement MsiEnumPatchesExW.
2008-12-08 12:18:49 +01:00
a32fcfa9b1
msi: Forward MsiEnumPatchesExA to MsiEnumPatchesExW.
2008-12-08 12:06:42 +01:00
7df94f3b04
msi: Fix the type of the last parameter of MsiEnumPatchesEx.
2008-12-08 12:06:06 +01:00
4153fc1904
msi: Set DllVersion registry key for CLSID_IMsiServerMessage.
2008-11-28 13:41:00 +01:00
d7119f2b73
msi: Remove WINAPI on static functions where not needed.
2008-11-28 12:54:37 +01:00
b1a54bf7a3
msi: Remove casts of void pointers.
2008-11-25 11:55:56 +01:00
3c533397e9
msi/tests: Skip tests on win9x by checking functionality instead of registry keys.
2008-11-17 13:16:08 +01:00
1dba41b104
msi/tests: Skip some tests on Win9x and WinMe.
2008-11-13 15:41:30 +01:00
b4874a8921
msi/tests: Fix some test failures on Win9x and WinMe.
2008-11-11 14:06:49 +01:00
7051bf5e22
msi: Remove an unused registry function.
2008-11-04 11:24:16 +01:00
e3074348fc
msi: Factor out the code to open the UserData features key.
2008-11-04 11:24:11 +01:00
0c01c586c7
msi: Factor out the code to open the features key.
2008-11-04 11:24:04 +01:00
70be1e7746
msi: Factor out the code to open a product key.
2008-11-04 11:23:51 +01:00
f12b9cea99
msi: Factor out the table insertion code.
2008-11-04 11:23:30 +01:00
2abb8bba13
msi: Factor out the table insertion code.
2008-11-04 11:23:07 +01:00
88f39d95f2
msi: Factor out the table insertion code.
2008-11-04 11:22:45 +01:00
4f199a10ad
Remove the remaining casts of NULL.
2008-11-03 13:42:09 +01:00
ca71e5aff0
msi: Allow private properties from the AdminProperties property list.
2008-10-30 11:47:10 +01:00
019f4af1c2
msi: Do not reinstall an assembly that already exists in the global assembly cache.
2008-10-29 13:29:32 +01:00
cec5d3f514
msi/tests: Fix a failing test on all platforms up to and including win2k.
2008-10-28 12:13:53 +01:00
c261030d21
msi: Skip the leading period of the extension to be registered.
2008-10-27 12:02:19 +01:00
2ffa433f80
msi: Convert command line property names to uppercase.
2008-10-27 12:02:13 +01:00
bf9538f383
msi: Use the long file name in the WriteIniValues action.
2008-10-27 12:02:04 +01:00
7616a750ba
msi: Set the source path tests to "interactive" to avoid timing out on some machines.
2008-10-27 12:01:57 +01:00
cd4b952863
msi: Fix several test failures.
2008-10-24 14:25:01 +02:00
acfc915914
msi: Fix a failing test in win9x.
2008-10-24 14:25:01 +02:00
f18c6ba28d
msi: Only compare the file version if a version was specified.
2008-10-22 13:54:53 +02:00
1c9886d6e7
msi: Sign-compare warnings fix.
2008-10-21 11:45:44 +02:00
40db5bdb16
msi: Sign-compare warnings fix.
2008-10-21 11:45:39 +02:00
03282df13d
msi: Use the quoted part of the registry value when searching for a file or directory.
2008-10-20 13:16:24 +02:00
6df69c6aaa
msi: Fix a copy and paste error.
2008-10-20 13:16:09 +02:00
7eba78dc7e
msi: Strip the file off the parent path if it's not a directory.
2008-10-20 13:16:04 +02:00
0ed516908b
msi: Only check the file signature if the candidate file is not a directory.
2008-10-20 13:15:36 +02:00
1fb22654e4
msi: Append the next directory to search to the current directory when recursing.
2008-10-20 13:11:14 +02:00
4aca381ff7
msi: Only append a backslash to directories.
2008-10-20 13:10:59 +02:00
7497f1ab5c
msi: Don't get rid of the file signature when searching the DrLocator table.
2008-10-20 13:10:54 +02:00
2e17638dc4
msi: Simplify and clean up ACTION_RecurseSearchDirectory.
2008-10-20 13:10:50 +02:00
29c0836fcc
msi: Handle searching for directories in the IniLocator part of the AppSearch action.
2008-10-20 13:10:44 +02:00
c48497d0e6
msi: Handle searching for a file with no signature.
2008-10-20 13:10:39 +02:00
326a1b6c47
msi: Add more tests for the RegLocator part of the AppSearch action.
2008-10-20 13:10:34 +02:00
859bd01b5e
msi: Check the file version when a version is provided in the signature.
2008-10-20 13:10:28 +02:00
fbba2e8b93
msi: Add more tests for the AppSearch action.
2008-10-20 13:10:19 +02:00
642cddf180
msi: Return the requested ini field.
2008-10-20 13:10:08 +02:00
f1e2041bf4
msi: Pass the correct view to get_row.
2008-10-20 13:09:59 +02:00
f80b5f6e66
msi: All files are uncompressed in an administrative image.
2008-10-17 11:44:21 +02:00
7620bb367f
msi: Append a backslash to the AppSearch registry path.
2008-10-16 11:22:43 +02:00
3adf1e4e0e
msi: Append a backslash to the AppSearch directory path.
2008-10-16 11:22:40 +02:00
47ac325f82
msi: Fix the returned format of REG_BINARY data.
2008-10-13 13:04:30 +02:00
6d02194a46
msi: Expand REG_EXPAND_SZ registry values in the RegLocator table.
2008-10-13 13:00:47 +02:00
65915af1ae
msi: Append the file signature to the component's directory when searching for the component's key path.
2008-10-13 13:00:42 +02:00
701c2a2728
msi: Add tests for the DrLocator part of the AppSearch action.
2008-10-13 13:00:37 +02:00
33c9e80be5
msi: Add tests for the RegLocator part of the AppSearch action.
2008-10-13 13:00:32 +02:00
3e76ade6c8
msi: Add tests for the IniLocator part of the AppSearch action.
2008-10-13 13:00:25 +02:00
41c8bc8ae6
msi: Add more tests for the CompLocator part of the AppSearch action.
2008-10-13 13:00:06 +02:00
87e21fe585
msi/tests: Clean up the binary.dat file.
2008-10-09 14:27:21 +02:00
68268dc3df
msi: Initialize the count variable to zero.
2008-10-09 13:01:31 +02:00
451aff9ae5
msi: Add extra constraints on the formatting string of edit path text.
2008-10-09 13:01:25 +02:00
1484c6272d
msi: Add a stub implementation of MsiDetermineApplicablePatches.
2008-10-09 13:01:18 +02:00
8128d97fd4
msi: Replace lengthy calls to MSI_DatabaseOpenView with MSI_OpenQuery.
2008-10-09 12:58:47 +02:00
f03889ae82
msi: Add initial implementation of MsiDatabaseMerge, with tests.
2008-10-09 12:58:25 +02:00
c9ec69db02
msi: Add tests for converting record fields between strings and ints.
2008-10-09 12:58:12 +02:00
b187008345
msi: Remove a part of a debugging statement that was accidentally left in.
2008-10-09 12:58:09 +02:00
704ebf280e
msi: Use the right FAILED/SUCCEEDED macro instead of negating the opposite.
2008-10-08 13:43:17 +02:00
e88b09a342
msi: Don't update the table columns if there are no more columns.
...
This should fix the heap corruption that caused intermittent crashes
for patchwatcher.
2008-10-07 12:14:03 +02:00
7cd6736886
msi: Add tests for dropping tables with multiple columns.
2008-10-07 12:13:52 +02:00
374c042880
msi: Remove the columns in reverse order.
2008-10-07 12:13:46 +02:00
aa230a6267
msi: Remove a break that kept other columns from getting the table name.
2008-10-07 12:13:39 +02:00
d15fddf6f5
msi: Resolve file source paths dynamically, as the source directory can be changed.
2008-10-07 12:13:33 +02:00
417134709d
msi: Added MsiInstallMissingComponentW stub implementation.
2008-10-07 12:12:54 +02:00
62c544cf4f
msi: Implement the DROP TABLE sql command.
2008-10-06 13:05:52 +02:00
48e6e584d3
msi: Fix a test that fails in win95.
2008-10-01 11:41:34 -05:00
4749ee2662
msi: Forward MsiDatabaseMergeA to MsiDatabaseMergeW.
2008-10-01 11:41:29 -05:00
525865447e
msi: Add a stub implementation of MsiDatabaseMerge.
2008-10-01 11:41:23 -05:00
628b8e7630
msi: Fix potential uninitialized use of substg.
2008-09-30 11:33:38 -05:00
3713720351
msi: Fix several test failures in win9x.
2008-09-29 17:24:17 -05:00
dd142bf5a7
msi/tests: Fix explicit C:\\Program Files\\ references.
2008-09-29 17:23:42 -05:00
e16e15bf0c
msi: Add stub for MsiSetExternalUIRecord.
2008-09-25 13:27:38 +02:00
88a5bdb858
msi: Remove redundant NULL check before SysFreeString.
2008-09-23 12:12:35 +02:00
67b06ecba5
msi/tests: Reduce buffer to size of string written.
2008-09-15 11:43:53 +02:00
2dfcb94211
msi/tests: Prevent a crash on NT4.
2008-09-15 11:23:42 +02:00
58ddb6f564
msi/tests: Create only one log file and delete it afterwards.
2008-09-11 11:43:09 +02:00
ef1b0cacfa
msi: Reduce destination file name used in the MoveFiles action to the long file name.
...
Add a test for this behaviour.
2008-09-10 12:08:52 +02:00
be759dddb8
msi: Uninitialized variable fix (Coverity).
2008-09-10 10:41:54 +02:00
d11968cade
msi: Fix a few file access discrepancies between platforms.
2008-09-09 11:46:17 +02:00
Alexandre Julliard