Commit Graph

3745 Commits

Author SHA1 Message Date
Nikolay Sivov 5d6f0de3ea shell32/tests: Fix some compiler warnings on sprintf() buffer sizes.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-02-07 21:28:24 +01:00
Nikolay Sivov 5b7dc90efb shell32/tests: Get rid of strcmp_wa().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-02-07 21:28:24 +01:00
Nikolay Sivov 84e06f2289 shell32: Do not use SHGetMalloc() internally.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-01-27 14:43:31 +01:00
Alexandre Julliard e4e3dc7eb6 shell32/tests: Get rid of strcmpW().
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-01-26 10:59:43 +01:00
Zebediah Figura 49a71fcc77 shell32/tests: Fix some failures in test_contextmenu().
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-01-21 20:55:34 +01:00
Nikolay Sivov 8a13cc6437 shell32/tests: Use SHParseDisplayName() directly.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-01-09 09:24:29 +01:00
Nikolay Sivov 464bbdcfb1 shell32/tests: Remove some more workarounds from shelllink tests.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-01-08 21:11:34 +01:00
Nikolay Sivov b9349d135e shell32/tests: Use ILIsEqual() directly.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-01-08 21:11:22 +01:00
Nikolay Sivov 6bfc988ea4 shell32/tests: Use GetShortPathNameA() directly in tests.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-01-07 22:26:08 +01:00
Nikolay Sivov d259c56c80 shell32/tests: Use GetLongPathNameA() directly in tests.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-01-07 22:26:08 +01:00
Nikolay Sivov 0c1a701e24 shell32/tests: Use ILFree() directly.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-01-07 22:26:08 +01:00
Nikolay Sivov 9a2e36b214 shell32/tests: Get rid of SHGetMalloc() in tests.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-01-07 22:26:08 +01:00
Nikolay Sivov 5b66af0204 shell32/tests: Remove workarounds for SHGetFolderLocation().
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-01-07 21:51:35 +01:00
Zebediah Figura 649119b30e shell32/tests: Avoid testing that only certain services are requested by IObjectWithSite::SetSite().
There doesn't seem to be a lot of point in doing this, especially given that
newer versions of Windows continually add more interfaces.

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-01-05 17:34:03 +01:00
Alexandre Julliard 4429b9f803 advapi32/tests: Use debug.h functions.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-12-17 16:55:16 +01:00
Francois Gouget 013949fc0b shell32: Tweak / fix the MS-DOS name in a comment.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-12-13 09:59:08 +01:00
Gijs Vermeulen 750d382f54 shell32/tests: Add PathResolve tests.
Signed-off-by: Gijs Vermeulen <gijsvrm@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-12-12 23:17:06 +01:00
Gijs Vermeulen a5a2749cfe shell32: Implement PathResolve.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48082
Signed-off-by: Gijs Vermeulen <gijsvrm@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-12-12 23:17:06 +01:00
Francois Gouget fc0ccc4486 shell32: Fix the spelling of a variable name.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-12-11 21:51:28 +01:00
Francois Gouget 308447324f shlwapi/tests: Fix the spelling of a couple of ok() messages.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-12-09 23:47:46 +01:00
Alex Henrie 477ff7e034 shell32: Symlink the Downloads and Templates folders too.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-12-05 23:36:23 +01:00
Alexandre Julliard 8310d7c417 shell32/tests: Avoid winetest_strcmpW.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-11-29 13:57:56 +01:00
Vijay Kiran Kamuju ec9eddf86b shell32: Update the LINKHEADER based on binary file format.
Signed-off-by: Vijay Kiran Kamuju <infyquest@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-11-28 20:45:46 +01:00
Serge Gautherie 7cc2806e0e shell32: Properly init/use icon_idx.
Signed-off-by: Serge Gautherie <winehq-git_serge_180711@gautherie.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-11-21 21:00:11 +01:00
Louis Lenders 36eb51b8a6 shell32: Add stub for SHCreateDataObject.
Signed-off-by: Louis Lenders <xerox.xerox2000x@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-11-21 20:48:31 +01:00
Hans Leidekker 3ca6b296da shell32: Fix definitions for FOLDERID_ProgramFilesX64 and FOLDERID_ProgramFilesCommonX64 on 64-bit.
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-11-14 15:45:18 +01:00
Alexandre Julliard b680571a50 shell32: Process all messages in control panel.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47947
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-11-12 23:04:29 +01:00
Nikolay Sivov 539644ad63 shell32: Remove "stub" from traces.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-11-05 16:16:15 +01:00
Sven Baars 6796cd8ac4 shell32: Fix a memory leak (Valgrind).
Signed-off-by: Sven Baars <sven.wine@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-11-04 22:43:01 +01:00
Hans Leidekker d7533e28df shell32: Improve the stub for SHGetPropertyStoreForWindow.
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-11-01 17:14:37 +01:00
Nikolay Sivov 062c55bf1a shell32/tests: Relax some tests to fix failures on Win10.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-10-27 19:13:53 +01:00
Fabian Maurer b7bca1be24 shell32: Prevent text truncation inside the old "browse folder" dialog.
We use the same height for the title as in the new "browse folder" dialog.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46404
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-09-23 19:44:17 +02:00
Dmitry Timoshkov f6ecc6be42 shell32: Return S_OK from IDropTargetHelper::Show().
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-09-19 12:23:22 +02:00
Akihiro Sagawa 4c6aa8b2fa shell32: Fix return value for DragQueryPoint.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47514
Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-08-13 20:42:57 +02:00
Akihiro Sagawa 865fe9cf97 shell32/tests: Add DragQueryPoint tests.
Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-08-13 20:42:53 +02:00
Huw Davies 4da35deaa2 shell32: On macOS don't link against CoreServices.
This has not been required since commit efac5d0672.

Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-08-02 10:52:03 +02:00
Austin English 4429608189 shell32: Add SHMultiFileProperties stub.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47411
Signed-off-by: Austin English <austinenglish@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-07-31 11:51:48 +02:00
Alexandre Julliard 47c131ebcb shlwapi: Import string functions from kernelbase.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-06-20 09:17:06 +02:00
Michael Stefaniuc 245417571a shell32: Don't cast from COM object to interface.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-06-03 22:33:30 +02:00
Sven Baars 4aad5655f2 shell32/tests: Fix a memory leak (Valgrind).
Signed-off-by: Sven Baars <sven.wine@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-31 21:32:50 +02:00
Sven Baars 0d0fa46553 shell32: Fix an item identifier list leak (Valgrind).
Signed-off-by: Sven Baars <sven.wine@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-31 21:32:47 +02:00
Sven Baars e6ce281d30 shell32: Fix a use after free (Coverity).
Signed-off-by: Sven Baars <sven.wine@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-29 16:21:24 +02:00
John Thomson 9b6d198a3c shell32: Do not fail in SHCreateDirectoryExW for ERROR_ALREADY_EXISTS.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47023
Signed-off-by: John Thomson <git@johnthomson.fastmail.com.au>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-04-24 22:48:08 +02:00
Alexandre Julliard d4ef782db7 makefiles: Build all tests with msvcrt.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-04-24 12:10:51 +02:00
Alexandre Julliard 06c7d3a945 shell32: Fix compiler warnings for the Windows build.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-04-15 21:33:07 +02:00
Alexandre Julliard 1459a0105d makefiles: Default to building test modules as PE.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-04-09 15:45:59 +02:00
Piotr Caban 232255f3c5 shell32: Don't use strcasecmp.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-04-04 17:24:13 +02:00
Gabriel Ivăncescu e95dc7e03e shell32/autocomplete: Use LBS_NODATA for the dropdown listbox.
This eliminates the overhead of populating the listbox completely and
simplifies the code.

Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-04-03 19:28:19 +02:00
Gabriel Ivăncescu 0cd95038af shell32/autocomplete: Use an owner-drawn listbox for the dropdown.
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-04-03 19:28:19 +02:00
Gabriel Ivăncescu 6f3beaee37 shell32/autocomplete: Encapsulate the listbox into an owner window.
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-04-03 19:28:19 +02:00