Gabriel Ivăncescu
ff87384048
comctl32/listbox: Shrink the item array with resize_storage.
...
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-02-07 22:44:04 +01:00
Gabriel Ivăncescu
3afbda2ae2
comctl32/listbox: Use a helper to expand the item array.
...
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-02-07 22:43:49 +01:00
Gabriel Ivăncescu
98ece04660
comctl32/listbox: Check for out of bounds using the index when painting the item.
...
Needed for LBS_NODATA.
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-02-07 22:43:40 +01:00
Nikolay Sivov
fc87823654
comctl32/rebar: Do not use global variable for debug buffer (Coverity).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-01-28 10:25:54 +01:00
Nikolay Sivov
620a25ef1d
comctl32/progress: Handle min == max case in PBM_STEPIT.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46485
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-01-23 17:05:10 +01:00
Andrey Gusev
535ef08b67
comctl32/tests: Remove redundant assignment.
...
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-01-04 17:03:39 +01:00
Huw Davies
76a9f965fd
comctl32/tests: Move the cursor over the treeview to avoid random mouse move messages.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45719
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-01-03 12:49:49 +01:00
Dmitry Timoshkov
4ee173dfdd
comctl32: Don't ignore page creation error for a non-modal propery sheet.
...
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-12-18 20:49:56 +01:00
Dmitry Timoshkov
ca41fd8904
comctl32/tests: Add a test for passing dialog template with bad control class to PropertySheet.
...
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-12-18 20:49:51 +01:00
Alexandre Julliard
0e166d998d
comctl32/tests: Avoid a structure initialization warning.
...
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-12-14 18:33:34 +01:00
Dmitry Timoshkov
bf4304211c
comctl32/tests: Add a test to check built-in comctl32 classes.
...
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-12-14 18:24:46 +01:00
Dmitry Timoshkov
685a4b5062
comctl32/tests: Fix a test failure under Windows 7.
...
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-12-14 18:24:46 +01:00
Eberhard Beilharz
f760079a71
comctl32/imagelist: Fix crash with large number of images.
...
Fix a crash that occurred when reading a imagelist with a large number
of images. In the particular case we read a cMaxImage value of 1032,
but allocated only 40 or so images. This lead to memory corruption in
ImageList_Read. This change allows to run TntConnect.
Signed-off-by: Eberhard Beilharz <eb1@sil.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-12-12 19:43:12 +01:00
Nikolay Sivov
cb7a426ceb
comctl32/tests: Use actual text width for ideal button size tests.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-12-11 14:45:02 +01:00
Waritnan Sookbuntherng
0f12fa1e43
comctl32/status: Checking size grip bounds in x-axis only.
...
Signed-off-by: Waritnan Sookbuntherng <lion328@hotmail.co.th>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-12-10 14:59:46 +01:00
Waritnan Sookbuntherng
1bb95af322
comctl32/status: Hide size grip when the parent window is maximized.
...
Signed-off-by: Waritnan Sookbuntherng <lion328@hotmail.co.th>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-12-10 14:59:45 +01:00
Waritnan Sookbuntherng
d8428406c6
comctl32/tests: Test status bar size grip behavior and bounds.
...
Signed-off-by: Waritnan Sookbuntherng <lion328@hotmail.co.th>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-12-10 14:59:42 +01:00
Nikolay Sivov
e6a91103a0
comctl32/listview: Fix NM_CLICK notification when clicking on checkboxes.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-12-05 22:33:43 +01:00
Michael Stefaniuc
f98f01b368
comctl32/tests: Use SetRect() instead of open coding it.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-12-05 09:24:20 +01:00
Alistair Leslie-Hughes
929058a2ef
comctl32/edit: Don't set caret position when we don't have focus.
...
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-12-05 09:23:43 +01:00
Alex Henrie
baf6adfef7
comctl32: Make constant 'mdays' static.
...
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-12-04 16:13:05 +01:00
Gabriel Ivăncescu
ece6dfe52c
comctl32/listbox: Store the items array size instead of using HeapSize().
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-28 12:12:57 +01:00
Gabriel Ivăncescu
423ea9790b
comctl32/tests: Also include LBS_NODATA cases when testing ownerdraw.
...
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-28 12:12:29 +01:00
Gabriel Ivăncescu
79bb84d20d
comctl32/listbox: Account for NULL item when painting ownerdrawn list.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-23 12:52:36 +01:00
Nikolay Sivov
656f3f5b29
comctl32/listbox: Remove duplicated condition.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-23 12:52:34 +01:00
Nikolay Sivov
a27db5169c
comctl32/listbox: Use helper to test for selected state on painting.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-23 12:52:32 +01:00
Gabriel Ivăncescu
54ee4db69a
comctl32/listbox: Use a helper function to check the selection state of an item.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-23 12:52:30 +01:00
Gabriel Ivăncescu
084eb528c1
comctl32/tests: Confirm that emptying the listbox sends LB_RESETCONTENT to itself.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-23 12:52:29 +01:00
Gabriel Ivăncescu
0b7dbc9e19
comctl32/listbox: Make LBS_NODATA listboxes error on any attempt to find a value.
...
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-14 16:55:01 +01:00
Gabriel Ivăncescu
19f26c35d5
comctl32/listbox: Don't set any data for LBS_NODATA listboxes.
...
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-14 16:54:56 +01:00
Gabriel Ivăncescu
1b17d8c09a
comctl32/listbox: Return 0 from LB_GETITEMDATA for LBS_NODATA listboxes.
...
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-14 16:54:53 +01:00
Gabriel Ivăncescu
ebe99b92d4
comctl32/listbox: Always retrieve zeros in LB_GETTEXT for LBS_NODATA listboxes.
...
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-14 16:54:47 +01:00
Gabriel Ivăncescu
ac174f4cf4
comctl32/listbox: Use ULONG_PTR instead of DWORD when retrieving text without HAS_STRINGS.
...
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-14 16:54:38 +01:00
Gabriel Ivăncescu
2aedcf3f8c
comctl32/listbox: Make SetCount fail if LBS_NODATA is not set.
...
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-13 20:54:28 +01:00
Gabriel Ivăncescu
8e13120c80
comctl32/listbox: Disable LBS_NODATA if styles are incompatible with it.
...
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-13 20:54:27 +01:00
Gabriel Ivăncescu
2813b43aeb
comctl32/listbox: Clear LBS_OWNERDRAWVARIABLE if LBS_OWNERDRAWFIXED is set.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-12 10:21:52 +01:00
Gabriel Ivăncescu
4c5f38493d
comctl32/tests: Test incompatible styles for LBS_NODATA.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-12 10:21:52 +01:00
Gabriel Ivăncescu
9324f89f4b
comctl32/tests: Add some tests for LBS_NODATA.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-12 10:21:52 +01:00
Gabriel Ivăncescu
ed7804e714
comctl32/tests: Add more Listbox tests for ownerdraw styles.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-12 10:21:52 +01:00
Nikolay Sivov
480731aec3
comctl32/tests: Fix Listbox test failures on some configurations.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-07 17:08:57 +01:00
Zhiyi Zhang
0e795d5382
comctl32/pager: Support header notification conversion.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-11-01 12:04:34 +01:00
Nikolay Sivov
8bd48fd6d9
comctl32/edit: Handle focused cue text.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-10-31 16:18:24 +01:00
Nikolay Sivov
aa601fdf0c
comctl32/edit: Add missing message macros.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-10-31 16:18:17 +01:00
Sergio Gómez Del Real
0d4a1f7bee
comctl32: Implement handling of EM_SETCUEBANNER/EM_GETCUEBANNER messages.
...
Signed-off-by: Sergio Gómez Del Real <sdelreal@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-10-30 10:52:36 +01:00
Zhiyi Zhang
589cbf3bcc
comctl32/taskdialog: Handle button clicks better.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-10-30 10:51:49 +01:00
Zhiyi Zhang
d61acf7ec0
comctl32/taskdialog: Add support for TDF_ALLOW_DIALOG_CANCELLATION.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-10-30 10:51:49 +01:00
Zhiyi Zhang
dcd5a37b1c
comctl32/taskdialog: Fix id casting.
...
This fix tests on 64bit because id is a signed int.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-10-30 10:51:49 +01:00
Francois Gouget
ab9dccda63
comctl32: Avoid an unneeded lstrlenW() call.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-10-22 11:12:28 +02:00
Nikolay Sivov
7a54ff7711
comctl32/tests: Remove remaining traces in ListView tests.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-10-15 13:58:03 +02:00
Nikolay Sivov
332062963f
comctl32/listview: Simplify iterator helpers that can't fail.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-10-15 13:58:02 +02:00
Nikolay Sivov
fae75d7961
comctl32/listview: Fix crashing in LVM_GETCOUNTPERPAGE for partially initialize lists.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-10-15 13:58:00 +02:00
Nikolay Sivov
39c9fe1d37
comctl32/listview: Skip earlier when creating iterator for empty lists.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-10-15 13:57:57 +02:00
Zhiyi Zhang
daf3e90707
comctl32/pager: Support tree view notification conversion.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-28 17:27:53 +02:00
Zhiyi Zhang
2536cbaa29
comctl32/pager: Support list view notification conversion.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-28 17:27:51 +02:00
Zhiyi Zhang
d8f3f1b717
comctl32/pager: Support date time picker notification conversion.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-28 01:12:20 +02:00
Jim Mussared
4a8a8bddda
comctl32/listview: Fix subitem invalidation.
...
It's wrong to offset by item position, columns could be reordered.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-24 22:41:29 +02:00
Zhiyi Zhang
eb317039e0
comctl32/pager: Support comboboxex notification conversion.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-22 00:02:14 +02:00
Zhiyi Zhang
d7dcfe032f
comctl32/pager: Support tooltip notification conversion.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-22 00:02:14 +02:00
Zhiyi Zhang
76f8ea7501
comctl32/pager: Support toolbar notification conversion.
...
Fix BibleWorks 10 not displaying toolbar.
Pager always wants Unicode notifications from its children.
And the parent of pager may want ANSI notifications. In this
case, pager need to convert Unicode notifications to ANSI ones
before sending them to parent and convert ANSI notifications
from parent to Unicode before returning the result to its children.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-22 00:02:14 +02:00
Sven Baars
04847e68f8
comctl32: Add NULL checks to SetWindowSubclass (Valgrind).
...
Signed-off-by: Sven Baars <sven.wine@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-20 15:36:21 +02:00
Nikolay Sivov
ec09119f2e
comctl32/button: Fix text buffer leak (Coverity).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-17 15:41:54 +02:00
Fabian Maurer
9a94f55958
comctl32/taskdialog: Use parentheses around & operator.
...
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-17 15:38:07 +02:00
Gabriel Ivăncescu
bb116577a3
comctl32/listbox: Update the size in SetColumnWidth before calling UpdatePage.
...
Some applications don't forward WM_SIZE from DefWindowProc to the control,
but instead only send a LB_SETCOLUMNWIDTH message, even when the column
width doesn't change (but the listbox size does).
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=22440
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-07 13:23:48 +02:00
Zhiyi Zhang
81f6437482
comctl32/button: Support BCM_GETIDEALSIZE message.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=24623
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-05 19:05:46 +02:00
Zhiyi Zhang
eb79ebe50c
comctl32/button: Support text margin rendering.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-05 19:05:39 +02:00
Zhiyi Zhang
c9aa8dab8f
comctl32/button: Support imagelist rendering.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=40445
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=40062
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45246
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-05 19:05:33 +02:00
Zhiyi Zhang
790d13ee98
comctl32/button: Avoid push button content covering frames.
...
A focus frame may be covered by content in the push button.
Shrink the label rectangle before layout calculation so that
content can never cover the frame.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-05 19:05:20 +02:00
Zhiyi Zhang
1f323f31d6
comctl32/button: Support displaying both image and text.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45727
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-05 19:05:01 +02:00
Zhiyi Zhang
fa4183ef84
comctl32/button: Use get_draw_state() helper.
...
Use a helper so that the get draw state routine can be shared
by later code.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-05 19:04:55 +02:00
Zhiyi Zhang
396ebaa588
comctl32/tests: Add tests for button state.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-05 19:04:47 +02:00
Nikolay Sivov
e84742abcc
comctl32/listbox: Fix debug channel name.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-03 15:52:47 +02:00
Zhiyi Zhang
ba1eb91a69
comctl32/tests: Fix a memory leak.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-29 22:01:38 +02:00
Fabian Maurer
48e8e579bc
comctl32/tests: Add a test for base class names.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-27 10:57:39 +02:00
Fabian Maurer
f6bd24fda6
comctl32/listview: Avoid duplicate LVN_ENDLABELEDIT notifications on focus change.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-27 10:57:39 +02:00
Fabian Maurer
d8dd281652
comctl32/listview: Use mask to disable change notifications.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-27 09:34:00 +02:00
Zhiyi Zhang
069eb68bf9
comctl32/pager: Support WM_NOTIFYFORMAT message.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-27 09:30:56 +02:00
Zhiyi Zhang
4be93106cd
comctl32/tests: Add WM_NOTIFYFORMAT tests for pager.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-27 09:30:54 +02:00
Zhiyi Zhang
b200fac42d
comctl32/tests: Remove pager skip check.
...
Pager should be available on all VMs(XP+) on TestBot.
So there's no need to check for the availability of
pager control. Add calling InitCommonControls() so that
pager control can be correctly initialized on XP.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-27 09:30:50 +02:00
Nikolay Sivov
a570499165
comctl32/tests: Fix test failures on XP.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-24 20:12:05 +02:00
Gabriel Ivăncescu
69ae3898c9
comctl32/edit: Move common calls outside the blocks.
...
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-23 19:48:49 +02:00
Nikolay Sivov
da75153eae
comctl32/listbox: Fix multicolumn navigation on VK_RIGHT.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-22 17:02:34 +02:00
Gabriel Ivăncescu
3f266610d5
comctl32/listbox: Fix scrolling for multi-column listboxes.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=38565
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-21 23:02:30 +02:00
Fabian Maurer
313c63e194
comctl32/combo: Implement logic for setting and getting dropdown height.
...
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-20 09:21:52 +02:00
Nikolay Sivov
4ee79efd86
comctl32/listbox: Update anchor index on LB_SETSEL.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-15 20:55:10 +02:00
Nikolay Sivov
b3e005483c
comctl32/tests: Add some ListBox tests for anchor index.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-15 20:55:10 +02:00
Nikolay Sivov
824837ec2c
comctl32: Fix background and text color for DrawStatusText().
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 12:06:39 +02:00
Nikolay Sivov
2225ff4126
comctl32/header: Fix item text color.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 12:06:34 +02:00
Nikolay Sivov
898db9248c
comctl32/tests: More tests for HTREEITEM layout.
...
Based on research by Zhiyi Zhang.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 12:06:23 +02:00
Zhiyi Zhang
22184d1295
comctl32/taskdialog: Fix center positioning.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 09:41:55 +02:00
Zhiyi Zhang
8097fbdf50
comctl32/taskdialog: Add vertical spacing for radio buttons.
...
Add vertical spacing to make dialog look nicer.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 09:41:49 +02:00
Zhiyi Zhang
4a9b877a98
comctl32/taskdialog: Add support for TDM_UPDATE_ICON.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 09:41:46 +02:00
Zhiyi Zhang
5349e5bdcc
comctl32/taskdialog: Add support for TDF_SIZE_TO_CONTENT.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 09:41:42 +02:00
Zhiyi Zhang
c3cb1c78c4
comctl32/taskdialog: Add support for TDM_{SET,UPDATE}_ELEMENT_TEXT.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 09:41:39 +02:00
Zhiyi Zhang
5f849e6b42
comctl32/taskdialog: Add support for TDM_SET_BUTTON_ELEVATION_REQUIRED_STATE.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 09:41:34 +02:00
Zhiyi Zhang
2c1abb2768
comctl32/taskdialog: Add support for navigating page.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 09:41:30 +02:00
Zhiyi Zhang
065b52a09e
comctl32/taskdialog: Update vertical layout only when expando button clicked.
...
Update vertical layout only to improve efficiency.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-08-14 09:41:23 +02:00
Zhiyi Zhang
3fcfb9c5cc
comctl32/taskdialog: Add support for footer text.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-19 18:25:59 +02:00
Zhiyi Zhang
615f3a1fb7
comctl32/taskdialog: Add support for footer icon.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-19 18:25:38 +02:00
Zhiyi Zhang
bf6cde92fb
comctl32/taskdialog: Add support for verification box.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-19 18:25:36 +02:00
Zhiyi Zhang
c1b1af5af9
comctl32/taskdialog: Add support for expando button.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-19 18:25:31 +02:00
Zhiyi Zhang
ec11805139
comctl32/taskdialog: Add support for expanded information.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-19 18:24:09 +02:00
Zhiyi Zhang
d2fb18166d
comctl32/taskdialog: Use window handle to identify control internally.
...
Use window handle to identify control when handling BN_CLICKED
notification to support buttons with id larger than 0xFFFF.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-19 18:24:04 +02:00
Nikolay Sivov
489c01eeb2
comctl32/trackbar: Scale thumb size with resolution.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-17 17:39:56 +02:00
Nikolay Sivov
6292c0abdc
comctl32/taskdialog: Use per-window dpi settings.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-17 17:39:56 +02:00
Nikolay Sivov
40298cc69a
comctl32/button: Use per-window dpi settings.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-17 17:39:56 +02:00
Michael Stefaniuc
cf37c6c422
comctl32: Remove redundant NULL checks before Free().
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-10 18:59:11 +02:00
Alexandre Julliard
35289f81a4
comctl32/taskdialog: Fix pointer cast warnings.
...
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-06 20:51:25 +02:00
Zhiyi Zhang
cb468b682d
comctl32/taskdialog: Add support for command links.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-05 19:57:16 +02:00
Zhiyi Zhang
4836727d5e
comctl32/taskdialog: Add support for radio buttons.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-05 19:57:16 +02:00
Zhiyi Zhang
07d8d62459
comctl32/taskdialog: Use dynamic buffer for taskdialog_get_label_size().
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-05 19:57:16 +02:00
Dmitry Timoshkov
02c36b52b0
comctl32/listbox: Fix the listbox sorting algorithm.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=42602
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-05 19:08:34 +02:00
Dmitry Timoshkov
7decba4e2b
comctl32/listbox: Fix order of items passed in WM_COMPAREITEM data.
...
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=42602
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-05 19:08:34 +02:00
Nikolay Sivov
9313cb0866
comctl32/tests: Add some tests for ownerdrawn listbox.
...
Adapted from user32 tests contributed by Dmitry Timoshkov.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=42602
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-04 14:54:13 +02:00
Michael Stefaniuc
962b31c80b
include: Add a generic available ARRAY_SIZE().
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-04 10:39:15 +02:00
Marcus Meissner
7e0de24a75
comctl32: Treeview item gets characters not bytes passed in.
...
Signed-off-by: Marcus Meissner <meissner@suse.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-03 11:12:43 +02:00
Marcus Meissner
6e437acf1c
comctl32/tests: Header item struct gets characters not bytes.
...
Signed-off-by: Marcus Meissner <meissner@suse.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-03 11:12:43 +02:00
Zhiyi Zhang
5d7fa27a2f
comctl32/taskdialog: Fix buttons might disappear.
...
In the old button layout algorithm, line count is added
before adding button. This cause line count buffer
overflow when the first button is very long.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-25 16:06:13 +02:00
Zhiyi Zhang
1671ab5345
comctl32/taskdialog: Add support for progress bar.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-15 22:22:27 +02:00
Zhiyi Zhang
c61a70be2f
comctl32/taskdialog: Add support for hyperlink.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-14 17:10:54 +02:00
Zhiyi Zhang
629d9c5699
comctl32/taskdialog: Add support for loading standard icons.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-14 17:06:16 +02:00
Zhiyi Zhang
0e9346e978
comctl32/taskdialog: Add support for main icon.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-14 17:06:14 +02:00
Zhiyi Zhang
9fa19e055c
comctl32/taskdialog: Add support for TDM_ENABLE_BUTTON.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-14 17:06:12 +02:00
Zhiyi Zhang
6dd9b83822
comctl32/taskdialog: Create buttons without templates.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-13 22:13:27 +02:00
Zhiyi Zhang
4b72060ff0
comctl32/taskdialog: Create content without templates.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-12 14:08:03 +02:00
Zhiyi Zhang
ba08beb82a
comctl32/taskdialog: Create main instruction without templates.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-12 14:08:00 +02:00
Zhiyi Zhang
df2e5f3975
comctl32/taskdialog: Support dynamic layout.
...
Support dynamic layout since some controls might change
their own layout after creation.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-12 14:07:58 +02:00
Zhiyi Zhang
dd90ed02d9
comctl32/taskdialog: Add taskdialog_destroy().
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-12 14:07:56 +02:00
Zhiyi Zhang
6b8728b798
comctl32/taskdialog: Remove unused parameter.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-12 14:05:59 +02:00
Zhiyi Zhang
4762b751e8
comctl32/taskdialog: Zero out taskdialog_info at initialization.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-12 14:05:54 +02:00
Michael Stefaniuc
04cb8d51a3
comctl32/tests: Use the available ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-06-06 21:18:42 +02:00
Michael Stefaniuc
7b5668a6e7
include: Make ARRAY_SIZE() available in wine/test.h.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-25 12:09:17 +02:00
Zhiyi Zhang
bf4d0982fd
comctl32/taskdialog: Use bold font for main instruction.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-23 21:58:58 +02:00
Zhiyi Zhang
fe182ce1f0
comctl32/taskdialog: Send TDN_CREATED before window gets visible.
...
TDN_CREATED notification is sent before dialog window is shown.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-23 21:58:56 +02:00
Zhiyi Zhang
f267a36069
comctl32/taskdialog: Add support for TDN_TIMER notification.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-21 10:50:35 +02:00
Zhiyi Zhang
be1b8c9e1e
comctl32/taskdialog: Add a helper to initialize dialog data.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-21 10:50:27 +02:00
Alex Henrie
8e9ea7a8a1
comctl32/listview: Don't invalidate when new style is same as old.
...
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-18 23:42:44 +02:00
Zhiyi Zhang
35652ebfcd
comctl32/taskdialog: Add support for TDF_RTL_LAYOUT.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-18 16:28:40 +02:00
Zhiyi Zhang
8455d4b947
comctl32/taskdialog: Add support for TDF_NO_SET_FOREGROUND.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-18 16:28:37 +02:00
Zhiyi Zhang
1c6e1ff807
comctl32/taskdialog: Move TASKDIALOGCONFIG pointer in struct taskdialog_info.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-18 16:28:34 +02:00
Zhiyi Zhang
58c6ae8244
comctl32/taskdialog: Add support for TDF_CAN_BE_MINIMIZED.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-16 23:54:56 +02:00
Zhiyi Zhang
7dcaade498
comctl32/taskdialog: Add support for TDN_HELP.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-16 23:54:54 +02:00
Zhiyi Zhang
c5b469f7ab
comctl32/taskdialog: Return TRUE when message is handled.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-16 23:54:52 +02:00
Nikolay Sivov
c74a72c46e
comctl32/toolbar: Handle resource strings returned for tooltip text.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-09 09:45:22 +02:00
Nikolay Sivov
38e715387d
comctl32/trackbar: Fix reseting to default page size.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-08 10:41:45 +02:00
Nikolay Sivov
2e9b17922e
comctl32/trackbar: Remove separate field indicating focused state.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-07 12:02:31 +02:00
Nikolay Sivov
6dc3c6ba87
comctl32/trackbar: Don't update page size if it was explicitly set.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-07 12:02:29 +02:00
Nikolay Sivov
0645fa1373
comctl32/toolbar: Fix tooltip notification forwarding.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-30 19:59:15 +02:00
Nikolay Sivov
5e7e3cbda6
comctl32/tooltip: Compare to special callback pointer value directly.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-30 19:59:12 +02:00
Zhiyi Zhang
84ce292217
comctl32: Fix checkbox wrong box alignment with BS_VCENTER.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-26 21:17:38 +02:00
Francois Gouget
44c865649b
comctl32: Remove THEMING_SetSubclassData(). It is not used anymore.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-19 12:51:21 +02:00
Zhiyi Zhang
45eb3cb4fc
comctl32: GroupBox can have multiline text.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-18 17:10:47 +02:00
Alistair Leslie-Hughes
d6da1166ca
comctl32/treeview: Fix item icon background when using TVS_FULLROWSELECT style.
...
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-16 10:21:07 +02:00
Dan Bassi
c5cb2f1c50
comctl32/treeview: Improve item text change detection.
...
Signed-off-by: Dan Bassi <wine.fixes@gmail.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-13 14:37:13 +02:00
Nikolay Sivov
be2bec72ac
comctl32/tests: Remove useless trace() message.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-09 10:02:25 +02:00
Zhiyi Zhang
1c6e71d62a
comctl32/button: Implement BCM_{GET,SET}TEXTMARGIN message.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-04 22:04:25 +02:00
Zhiyi Zhang
0d4940b732
comctl32/button: Implement BCM_{GET,SET}IMAGELIST message.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-04 22:04:25 +02:00
Zhiyi Zhang
05d4e4a23b
comctl32/button: Remove style checking when handling BM_SETIMAGE.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-03 09:44:29 +02:00
Nikolay Sivov
64ecb3648e
comctl32/static: Remove some misleading comments.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-02 20:47:11 +02:00
Nikolay Sivov
b442a5c0f0
comctl32/button: Keep control style.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-04-02 12:28:12 +02:00
Nikolay Sivov
733a3ec1b9
comctl32/button: Improve button data layout compatibility.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-30 16:52:05 +02:00
Michael Stefaniuc
11caaa1b45
comctl32/tests: Use the available ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-29 17:28:00 +02:00
Zhiyi Zhang
06d2ad29ae
comctl32/button: Implement BCM_{GETNOTE,SETNOTE,GETNOTELENGTH} message.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-28 19:37:26 +02:00
Zhiyi Zhang
cc893cdcab
comctl32/datetime: Change DATETIME_ReturnFieldWidth() to return width.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-26 21:04:53 +02:00
Nikolay Sivov
9b9f97e3f6
user32: Add redirected class registration callback.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-20 11:41:44 +01:00
Zhiyi Zhang
ad698fc7be
comctl32/datetime: Implement DTM_GETIDEALSIZE message.
...
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-19 12:35:12 +01:00
Zhiyi Zhang
b683b541fa
comctl32/datetime: Fix length passed to GetLocaleInfoW().
...
Fix fullday not being rendered when long date format is used.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-19 12:35:12 +01:00
Zhiyi Zhang
46dcf0c7cb
comctl32/datetime: Fix wrong format for DTS_SHORTDATECENTURYFORMAT.
...
DTS_SHORTDATECENTURYFORMAT should use short date format
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-19 12:35:12 +01:00
Mark Jansen
f94d0e7b3a
comctl32/tests: Prevent a possible nullptr dereference.
...
Signed-off-by: Mark Jansen <mark.jansen@reactos.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-19 12:35:11 +01:00
Nikolay Sivov
74d24b2197
comctl32/listview: Do not try to invalidate for invalid item indices.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-09 10:57:15 -06:00
Piotr Caban
dc328fe314
comctl32/tests: Add out of visible area item expand test.
...
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-06 15:46:50 -06:00
Piotr Caban
c195311c62
comctl32: Update all items rects in TREEVIEW_RecalculateVisibleOrder.
...
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-06 15:46:48 -06:00
Nikolay Sivov
81e698da27
comctl32/button: Do not select old font back after painting.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-01 19:25:57 +01:00
Piotr Caban
2c0f6d9614
comctl32/tests: Add listbox WM_MEASUREITEM tests.
...
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-01 09:58:06 +01:00
Piotr Caban
0bb2cb3d99
comctl32: Fix itemData passed in ListBox WM_MEASUREITEM message.
...
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-01 09:58:04 +01:00
Roman Pišl
4803b7abc9
comctl32/tooltips: Set window size before TTN_SHOW and preserve it after.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-28 17:24:37 +01:00
Nikolay Sivov
037d315a28
comctl32/tests: Run some Progress control tests on version 6.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-28 17:24:37 +01:00
Michael Stefaniuc
58bb7b39fc
comctl32: Use the available ARRAY_SIZE() macro.
...
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-28 17:24:36 +01:00
Fabian Maurer
9036a84b0f
comctl32/progress: Fix wrapping of values in PBM_STEPIT and add tests.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-27 12:47:48 +01:00
Nikolay Sivov
db2a3b7028
comctl32: Use ARRAY_SIZE() macro.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-27 09:16:27 +01:00
Nikolay Sivov
7d9cf7f4b5
comctl32/tests: Add a test for TTN_SHOW order.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-27 09:01:39 +01:00
Francois Gouget
09ec2cd771
comctl32: Make COMBO_WindowProc() static.
...
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-22 21:46:28 +01:00
Nikolay Sivov
c586b759a9
comctl32/tooltips: Fix structure size check for TTM_ADDTOOLW.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-21 15:51:37 +01:00
Nikolay Sivov
73b70aff6c
comctl32/tests: Run some tooltips tests on version 6 too.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-21 15:51:35 +01:00
Nikolay Sivov
acc44e5d44
comctl32/tests: Replace some asserts with regular test calls.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-20 20:13:06 +01:00
Nikolay Sivov
dadea2d11d
comctl32/edit: Force update on focus change.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-16 14:25:59 +01:00
Nikolay Sivov
335f865ed5
comctl32/tests: Replace asserts with regular test checks for Edit tests.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-16 14:25:52 +01:00
Nikolay Sivov
6e55073574
comctl32/button: Use allocated structure to keep control data.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-15 19:34:41 +01:00
Nikolay Sivov
8874a6ecc3
comctl32/tests: Use the global memory allocation helpers.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-15 19:34:13 +01:00
Nikolay Sivov
887836cc6d
comctl32/combo: Use the global memory allocation helpers.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-15 19:34:08 +01:00
Nikolay Sivov
e265c49306
comctl32/edit: Use the global memory allocation helpers.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-15 19:34:04 +01:00
Nikolay Sivov
389c3add0a
comctl32/button: Fix paint handler check when theming is on.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-14 20:37:56 +01:00
Nikolay Sivov
0f98b0bb29
comctl32/listbox: Merge theming logic.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-14 09:05:34 +01:00
Nikolay Sivov
04fe481d2b
comctl32: Introduce ListBox control.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-14 09:05:30 +01:00
Nikolay Sivov
6204bbc389
comctl32/comboex: Remove child windows subclass on window destruction.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-14 09:04:49 +01:00
Nikolay Sivov
69d9052206
comctl32/tests: Use existing macros for control class names.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-14 09:04:47 +01:00
Nikolay Sivov
9d897b73a8
comctl32/button: Use the global memory allocation helpers.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-13 20:23:27 +01:00
Nikolay Sivov
65f23a745a
comctl32/button: Use messages to get control text.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-13 20:23:27 +01:00
Nikolay Sivov
694602eab1
comctl32/combo: Merge theming logic.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-13 19:15:00 +01:00
Nikolay Sivov
c9e98034b3
comctl32: Introduce ComboBox control.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-13 19:15:00 +01:00
Nikolay Sivov
1d5cc6efdf
comctl32/static: Reuse existing system colors helper.
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-12 11:07:43 +01:00