1b5aaa1639
comctl32/tests: Test more return values (Clang).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-12 11:29:19 +09:00
67819d6ee9
comctl32: Don't use comparisons to FALSE.
...
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-10 11:53:20 +09:00
60fedd23f9
comctl32: Protect TVM_GETITEM from invalid item pointers.
...
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-05 00:03:34 +09:00
7d6ca63154
comctl32/tests: Flush events in listview tests after setting foreground window.
...
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-04 14:41:38 +09:00
4e2d25c7cd
comctl32: Re-enable the parent before destroying the dialog.
...
Prevent 1602 AD from minimizing when the multiplayer dialog is
closed. When DestroyWindow is called, user32 tries to find a window to
activate, finds the main game window disabled and decides to go to the
desktop. Wined3d will help this process by minimizing the game out of
the way.
Signed-off-by: Stefan Dösinger <stefan@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-11-02 23:02:23 +09:00
7a59b27f4d
comctl32/listview: Fix printf format (PVS-Studio).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-28 22:31:32 +09:00
59cca65ce0
comctl32: Always call BeginPaint/EndPaint when handling a WM_PAINT message for the button.
...
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-21 01:04:35 +09:00
e0c421ff62
comctl32/syslink: Simplify conditional expression (PVS-Studio).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-21 00:25:34 +09:00
83a652a9d4
include: Add a couple of documented Toolbar messages definitions.
...
Thanks to Alan Feldman for pointing this out.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-19 12:20:56 +09:00
490b4eec4b
comctl32/tests: Fix function prototype (PVS-Studio).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-14 12:46:13 +09:00
680ba9330e
comctl32/imagelist: Use proper type for return variable (PVS-Studio).
...
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-14 12:45:43 +09:00
88531272ce
comctl32/tests: IDI_APPLICATION is already an INTRESOURCE (PVS-Studio).
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-13 22:24:56 +09:00
a16a270751
comctl32/tests: WC_DIALOG is already an INTATOM (PVS-Studio).
...
Signed-off-by: Michael Stefaniuc <mstefani@redhat.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2015-10-13 22:24:52 +09:00
9c87c7e76d
comctl32: Don't use uninitialized LVITEM fields in LISTVIEW_InsertItemT when LVS_EX_CHECKBOXES was specified.
...
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
2015-10-07 21:28:50 +09:00
c565145b0e
comctl32: Remove redundant if (button) statements.
...
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
2015-10-07 21:28:50 +09:00
aa39614e77
comctl32: Test TrackMouseEvent flags when LVS_EX_ONECLICKACTIVATE style is used.
...
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
2015-10-07 21:28:49 +09:00
4dd26ee814
comctl32: Don't ask for WM_MOUSEHOVER messages when LVS_EX_TRACKSELECT was not specified.
...
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
2015-10-07 21:28:49 +09:00
1e2c0a3029
comctl32/tests: Add tests for LoadIconMetric function.
...
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
2015-10-06 00:01:55 +09:00
088eb87e3b
comctl32: Add implementation for LoadIconMetric.
...
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
2015-10-06 00:01:55 +09:00
c098c13ee2
comctl32: Add semi-stub implementation for LoadIconWithScaleDown.
...
Thanks to Nikolay Sivov and Alistair Leslie-Hughes for various comments
and ideas for improvements.
Signed-off-by: Michael Müller <michael@fds-team.de>
Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
2015-10-06 00:01:54 +09:00
4f06425a03
comctl32: Set the item size after LISTVIEW_ScrollColumns().
...
LISTVIEW_ScrollColumns() increments the item width by the scroll
delta, so we need the original width to still be present.
2015-09-08 14:48:09 +09:00
80f887a064
comctl32/tests: Add ARM and ARM64 arch strings.
2015-08-12 22:52:24 +09:00
f8a7d6ed74
Assorted spelling fixes.
2015-08-07 23:50:48 +09:00
f6653a93eb
comctl32/tests: Extra WM_PAINT messages are occasionally sent on Vista and Win 7.
2015-07-06 20:08:21 +09:00
2a71d13b6b
comctl32: Implement the legacy notifications during restore.
2015-07-02 16:54:01 +09:00
6c95445559
comctl32: Set the default separator width when notifying a -ve cmd id.
2015-07-02 16:53:58 +09:00
eddfefa54f
comctl32: Reset the string and lparam fields between notifications.
2015-07-01 19:18:27 +09:00
96a6184c30
comctl32: All negative entries in the toolbar save state are special cases.
2015-07-01 19:18:27 +09:00
77ed3733af
comctl32: The number of buttons is set by the first TBN_RESTORE notification.
2015-07-01 19:18:27 +09:00
063c7866f5
comctl32: Implement toolbar saving.
2015-07-01 19:18:26 +09:00
199f51ff78
comctl32: Don't leak button text.
2015-07-01 19:18:26 +09:00
01cd45cce1
comctl32: Add a helper to free button text.
2015-07-01 19:18:25 +09:00
a29b6958e1
comctl32: Add helpers to set the button text.
2015-07-01 19:18:25 +09:00
035d0a1594
comctl32/monthcal: Fix title to use properly localized year/month format.
2015-06-18 21:41:02 +09:00
ccf2ea6179
comctl32/tests: Free memory used by property sheet page (Valgrind).
2015-06-18 21:41:02 +09:00
b7969dfd94
comctl32/toolbar: Remove always true condition (Coverity).
2015-06-03 19:29:49 +09:00
bae599092a
comctl32: Use DPI settings for checkbox size.
2015-05-25 14:34:07 +09:00
a1d54447b8
comctl32/tests: Skip the hover tests if the listview's parent is not the foreground window.
2015-05-21 20:01:29 +09:00
5c4dc9fc56
comctl32: Fix a typo in the TB_SAVERESTOREA handler.
2015-05-20 22:10:07 +09:00
0634f3b409
comctl32: If necessary add the width of a dropdown arrow while wrapping.
...
This also fixes the layout code for the BTNS_WHOLEDROPDOWN case.
2015-05-19 22:57:36 +09:00
797f42699e
comctl32: Wrap the buttons inside the toolbar's client rect.
...
The toolbar need not be the same width as the parent.
2015-05-19 22:57:27 +09:00
0bcadfa88f
comctl32: Layout the toolbar after a potential resize.
2015-05-19 22:57:22 +09:00
9d218048a6
comctl32: Don't store the width in the toolbar info structure.
...
It's only set and used by a single function.
2015-05-19 22:57:16 +09:00
6be21eeb3f
comctl32: Remove LoadString() fallback when loading from same module.
2015-05-18 19:59:28 +09:00
ad49634bbe
comctl32: Send WM_NOTIFY when expanding ancestors of the new selection.
2015-05-18 19:59:27 +09:00
36297f2cb0
comctl32: Do not send WM_NOTIFY if selecting an already-selected item.
2015-05-18 19:59:27 +09:00
a0ebe244c4
comctl32: Close previously selected treeview item at common ancestor.
...
Also, send WM_NOTIFY mesages when collapsing the previous selection and
expanding the new one.
2015-05-18 19:59:27 +09:00
9f93080754
comctl32/tests: Extend TVS_SINGLEEXPAND tests.
2015-05-18 19:59:27 +09:00
eb8df37a69
comctl32: Remove button wrap states when TBSTYLE_WRAPABLE is cleared.
2015-04-30 16:17:59 +09:00
abd673bde9
comctl32: A change in TBSTYLE_WRAPABLE should produce a recalc.
2015-04-28 20:23:59 +09:00
e82b9dc32e
comctl32: Move the style change code to the TB_SETSTYLE handler.
2015-04-28 20:23:59 +09:00
aba3b131bc
comctl32: TTM_SETTOOLINFO does not change subclassing flags.
2015-04-27 19:33:28 +09:00
13b65faf4e
comctl32: Avoid use-after-free in DPA_Merge (DPH).
2015-04-20 14:37:57 +09:00
60e305d983
comctl32: Invalidate the toolbar if the button size is changed.
2015-04-20 14:37:00 +09:00
5b7b911f06
comctl32: TBSTYLE_EX_MIXEDBUTTONS doesn't mean buttons should be auto-sized.
2015-04-20 14:36:55 +09:00
b0a9fb6b0d
comctl32: Fix drawing of buddy background for updown controls.
2015-04-09 14:55:17 +09:00
b4ec412203
comctl32: Avoid integer overflow (Coverity).
2015-04-07 15:15:11 +09:00
af30ffaa43
comctl32/tests: Fix couple of metrics tests that fail on some systems.
2015-04-02 23:14:36 +09:00
82bab3283b
comctl32/dsa: Implement DSA_GetSize().
2015-03-31 16:44:29 +09:00
ff0634dfe1
comctl32/dsa: Implement DSA_Clone().
2015-03-31 16:43:49 +09:00
30cdd59252
comctl32/listview: Always forward HDM_SETORDERARRAY to a header.
2015-03-31 14:47:56 +09:00
d12c2f8b6f
comctl32/listview: Use defined name instead of magic value.
2015-03-31 14:47:54 +09:00
9fcfaaa64a
comctl32/listview: Support header item image/bitmap in LVSCW_AUTOSIZE_USEHEADER case.
2015-03-31 14:47:52 +09:00
961c7b887b
comctl32: Redraw themed button on WM_ENABLE.
2015-03-31 14:47:37 +09:00
9f1f5d885c
comctl32: Print full flag values in traces.
2015-03-30 19:49:13 +09:00
c4a3651e34
comctl32/listview: Remove outdated TODO comment.
2015-03-30 16:37:44 +09:00
5c2e7075df
comctl32/listview: Always forward LVM_GETCOLUMNORDERARRAY to header.
2015-03-30 16:37:40 +09:00
3c9db1df60
comctl32/listview: Fix scrolling in LV_VIEW_DETAILS view.
2015-03-30 16:37:34 +09:00
782253f18d
comctl32/listview: Fix focus rectangle for LVS_EX_FULLROWSELECT case.
2015-03-30 16:37:31 +09:00
326af51ec2
comctl32/listview: Fix item focus rectangle to use proper label/selection bounds.
2015-03-30 16:37:27 +09:00
59cb4ff6f3
comctl32/tests: Listview doesn't subclass its header.
2015-03-25 19:38:30 +09:00
524f6860d4
comctl32: Claim success in InitializeFlatSB().
2015-03-25 15:16:45 +09:00
e7116725ff
comctl32: Use correct font for themed headers.
2015-03-24 16:42:05 +09:00
9d0ebc13ac
comctl32/tooltips: Allow NULL hinst value when fetching text from resources.
2015-03-24 14:07:17 +09:00
b6dc726bbd
comctl32/listview: Update view on style change only if LVS_TYPEMASK styles have changed.
2015-03-23 16:36:06 +09:00
c04cc70f7d
comctl32: Remove unneeded NONAMELESSSTRUCT directives.
2015-03-09 22:06:23 +09:00
a20c920bbd
comctl32: Draw hot parts of themed scrollbars.
2015-03-05 21:39:21 +09:00
d9708ecb93
comctl32: Add hit testing for themed scrollbars.
2015-03-05 21:39:14 +09:00
d7c2069721
comctl32: Paint themed scrollbars.
2015-03-03 23:16:46 +09:00
050bda2ece
comctl32: Call OpenThemeData on themed scrollbars.
2015-03-02 23:00:30 +09:00
f935a10add
comctl32/tests: Fix Monthcal tests failures on some VMs.
2015-03-02 13:54:13 +09:00
129862f369
comctl32: Themed buttons should not draw in System if font unset.
2015-02-18 15:45:04 +09:00
6a8da85c3b
comctl32: Do not call HEADER_FillItemFrame twice in a row.
2015-02-18 15:43:04 +09:00
50c2144999
comctl32: Fix graphical error on themed progress bars.
2015-02-16 19:18:52 +09:00
707361321a
comctl32: Redraw themed editboxes on focus change.
2015-02-16 19:18:50 +09:00
6f9724d581
comctl32: Use theming when drawing IP address control.
2015-02-16 19:18:49 +09:00
ca5184f512
comctl32: Add themed scrollbar stub.
2015-02-16 19:18:48 +09:00
18c41f7128
comctl32: Draw focus rect on themed pushbuttons.
2015-02-16 19:18:47 +09:00
f21a968d1c
comctl32: Draw the focus rect on themed checkboxes.
2015-02-13 18:20:55 +09:00
b8d3f1fe24
comctl32: Always redraw background on checkbox repaint.
2015-02-13 18:20:45 +09:00
26896f1bd5
comctl32: Fix clipping error with themed groupboxes.
2015-02-09 19:02:03 +09:00
39045b13d0
comctl32: Remove an unused variable assigment (PVS-Studio).
2015-01-13 19:54:01 +01:00
42c4c870af
comctl32: Add a stub for LoadIconWithScaleDown.
2014-12-15 14:18:56 +01:00
47fa711bbc
comctl32: Remove a stray unused GetFocus() statement (PVS-Studio).
2014-12-09 22:16:44 +01:00
2db0a3d01e
comctl32: Merge two if blocks with identical condition (PVS-Studio).
2014-12-05 11:24:12 +01:00
44dbf381a7
comctl32/tests: Fix imagelist leak (Valgrind).
2014-12-01 11:00:20 +01:00
ab7228f318
comctl32/tests: Remove unused structs (Clang).
2014-11-25 19:49:33 +01:00
735e2cd774
comctl32: Allow broken behaviour in StrRStr functions.
2014-11-19 23:36:34 +09:00
194b7cd5ae
comctl32: Fix invalid usage of CompareString in StrRStr functions.
2014-11-18 22:11:06 +09:00
e2c0694901
comctl32: Fix incorrect usage of CompareString in SYSLINK_ParseText.
2014-11-18 22:10:51 +09:00
Nikolay Sivov